claude-dev-env 8.43.5 → 8.44.0

package/scripts/test_invoke_code_review_chain.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+from datetime import datetime, timezone
 from pathlib import Path
 
 import pytest
@@ -22,6 +23,7 @@ from dev_env_scripts_constants.code_review_constants import (
     REVIEW_PERMISSION_MODE as PERMISSION_MODE_BYPASS,
     PERMISSION_MODE_FLAG,
 )
+from dev_env_scripts_constants.account_broker_constants import JobOutcome, WAIT_EXIT_CODE
 from dev_env_scripts_constants.grok_worker_constants import (
     MODEL_FLAG,
     OUTPUT_FORMAT_FLAG,
@@ -68,3 +70,27 @@ def test_chain_redirects_empty_stdin_and_sets_cwd(
 
     assert call_log.is_stdin_empty is True
     assert call_log.claude_working_directory == working_directory
+
+
+def test_wait_reports_reset_without_running_git_status(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    reset_at = datetime(2026, 10, 4, 12, tzinfo=timezone.utc)
+    call_log = install_seams(
+        monkeypatch,
+        host_profile=HOST_PROFILE_THIRD_PARTY,
+        claude_outcome=JobOutcome(WAIT_EXIT_CODE, "", "", None, (), "wait", None, reset_at),
+    )
+    monkeypatch.setattr(
+        invoker,
+        "review_git_status_runner",
+        lambda *args, **kwargs: pytest.fail("wait must not inspect the tree"),
+    )
+
+    outcome = run_review(tmp_path, session_model=FIXTURE_SESSION_SONNET)
+
+    assert call_log.claude_calls == 1
+    assert outcome.served_command is None
+    assert outcome.status == "wait"
+    assert outcome.wait_reset_at == reset_at.isoformat()
+    assert outcome.returncode == WAIT_EXIT_CODE

package/scripts/test_invoke_code_review_cli.py

@@ -19,7 +19,7 @@ from _code_review_test_support import (
     install_seams,
     run_review_cli,
 )
-from claude_chain_runner import ChainConfigurationError
+from dev_env_scripts_constants.account_broker_constants import BrokerConfigurationError
 from dev_env_scripts_constants.claude_chain_constants import (
     CHAIN_CONFIG_ERROR_EXIT_CODE,
 )
@@ -62,6 +62,8 @@ def test_cli_prints_result_json_only(
         RESULT_KEY_SERVED_COMMAND: None,
         RESULT_KEY_RETURNCODE: IN_SESSION_RETURNCODE,
         RESULT_KEY_DIRTY_TREE: False,
+        "status": None,
+        "wait_reset_at": None,
     }
 
 
@@ -74,7 +76,7 @@ def test_cli_emits_json_on_chain_configuration_error(
     install_seams(
         monkeypatch,
         host_profile=HOST_PROFILE_THIRD_PARTY,
-        claude_outcome=ChainConfigurationError(FIXTURE_CHAIN_CONFIG_ERROR_MESSAGE),
+        claude_outcome=BrokerConfigurationError(FIXTURE_CHAIN_CONFIG_ERROR_MESSAGE),
         working_directory=working_directory,
     )
     exit_code = run_review_cli(working_directory, session_model=FIXTURE_SESSION_OPUS)
@@ -87,13 +89,9 @@ def test_cli_emits_json_on_chain_configuration_error(
         RESULT_KEY_SERVED_COMMAND: None,
         RESULT_KEY_RETURNCODE: CHAIN_CONFIG_ERROR_EXIT_CODE,
         RESULT_KEY_DIRTY_TREE: False,
+        "status": None,
+        "wait_reset_at": None,
     }
-    config_error_outcome = invoker.CodeReviewOutcome(
-        mode=MODE_CHAIN,
-        served_command=None,
-        returncode=CHAIN_CONFIG_ERROR_EXIT_CODE,
-        is_dirty_tree=False,
-    )
 
 
 def test_cli_emits_json_on_host_profile_value_error(
@@ -121,6 +119,8 @@ def test_cli_emits_json_on_host_profile_value_error(
         RESULT_KEY_SERVED_COMMAND: None,
         RESULT_KEY_RETURNCODE: HOST_PROFILE_ERROR_RETURNCODE,
         RESULT_KEY_DIRTY_TREE: False,
+        "status": None,
+        "wait_reset_at": None,
     }
 
 

package/scripts/test_invoke_code_review_codec.py

@@ -20,12 +20,9 @@ FIXTURE_CHAIN_STDOUT = '{"result":"review done"}'
 
 def _install_invoker_codec_seams(
     monkeypatch: pytest.MonkeyPatch,
-    *,
-    all_chain_codec_keywords: dict[str, str],
 ) -> dict[str, object]:
     return install_codec_seams(
         monkeypatch,
-        all_chain_codec_keywords=all_chain_codec_keywords,
         chain_stdout=FIXTURE_CHAIN_STDOUT,
         runner_host=invoker,
         runner_attribute_name="review_claude_runner",
@@ -37,10 +34,6 @@ def test_forwards_text_codec_keywords_to_subprocess_runner(
 ) -> None:
     all_observed_runner_keywords = _install_invoker_codec_seams(
         monkeypatch,
-        all_chain_codec_keywords={
-            FIXTURE_ENCODING_KEYWORD_NAME: FIXTURE_CHAIN_ENCODING,
-            FIXTURE_ERRORS_KEYWORD_NAME: FIXTURE_CHAIN_ERRORS,
-        },
     )
 
     invoker._run_claude_with_empty_stdin(
@@ -59,12 +52,11 @@ def test_forwards_text_codec_keywords_to_subprocess_runner(
     )
 
 
-def test_absent_text_codec_keywords_are_not_invented(
+def test_empty_stdin_and_cwd_reach_broker(
     monkeypatch: pytest.MonkeyPatch, tmp_path: Path
 ) -> None:
     all_observed_runner_keywords = _install_invoker_codec_seams(
         monkeypatch,
-        all_chain_codec_keywords={},
     )
 
     invoker._run_claude_with_empty_stdin(
@@ -73,5 +65,5 @@ def test_absent_text_codec_keywords_are_not_invented(
         working_directory=tmp_path,
     )
 
-    assert FIXTURE_ENCODING_KEYWORD_NAME not in all_observed_runner_keywords
-    assert FIXTURE_ERRORS_KEYWORD_NAME not in all_observed_runner_keywords
+    assert all_observed_runner_keywords["stdin_text"] == ""
+    assert all_observed_runner_keywords["cwd"] == tmp_path

package/scripts/test_invoke_code_review_contract.py

@@ -20,6 +20,7 @@ from _code_review_test_support import (
     install_seams,
     run_review,
 )
+from dev_env_scripts_constants.account_broker_constants import WAIT_EXIT_CODE
 from dev_env_scripts_constants.code_review_constants import (
     CODE_REVIEW_MODEL_ALIAS,
     DEFAULT_CODE_REVIEW_EFFORT,
@@ -96,8 +97,9 @@ def test_chain_failure_preserves_returncode(
 
     assert review_outcome.mode == MODE_CHAIN
     assert review_outcome.served_command is None
-    assert review_outcome.returncode == FIXTURE_FAILED_RETURNCODE
+    assert review_outcome.returncode == WAIT_EXIT_CODE
     assert review_outcome.is_dirty_tree is False
+    assert review_outcome.status == "exhausted"
     assert invoker.is_successful_code_review(review_outcome) is False
 
 
@@ -114,6 +116,8 @@ def test_encode_code_review_outcome_shape() -> None:
         RESULT_KEY_SERVED_COMMAND: FIXTURE_SERVED_COMMAND,
         RESULT_KEY_RETURNCODE: FIXTURE_CHAIN_RETURNCODE,
         RESULT_KEY_DIRTY_TREE: True,
+        "status": None,
+        "wait_reset_at": None,
     }