claude-dev-env 8.43.0 → 8.43.2

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.43.0",
+    "version": "8.43.2",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/scripts/account_broker.py

@@ -244,7 +244,7 @@ def _attempt_once(context: _RunContext, decision: Decision) -> JobOutcome | None
     except (OSError, subprocess.TimeoutExpired) as error:
         status = "timeout" if isinstance(error, subprocess.TimeoutExpired) else "start_failed"
         _record_spent_attempt(context, account, status, COMMAND_MISSING_EXIT_CODE)
-        if not context.all_readings:
+        if isinstance(error, subprocess.TimeoutExpired) or not context.all_readings:
             context.report.final_decision = decision
             return JobOutcome(COMMAND_MISSING_EXIT_CODE, "", str(error), account.name, tuple(context.all_attempts), "advisor_blocked", None, None)
         return None

package/scripts/test_account_broker.py

@@ -361,12 +361,8 @@ def test_should_keep_spent_mark_until_reset(
     assert json.loads(capsys.readouterr().out)["decision"]["account"] == "second"
 
 
-@pytest.mark.parametrize(
-    ("start_error", "expected_status"),
-    ((OSError("missing command"), "start_failed"), (subprocess.TimeoutExpired("job", 1), "timeout")),
-)
 def test_should_leave_later_choices_open_after_start_failure(
-    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str], start_error: Exception, expected_status: str
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
 ) -> None:
     accounts = (_account("first"), _account("second"))
     monkeypatch.setitem(account_broker.all_product_adapters, Product.CODEX, _adapter(accounts, {
@@ -374,12 +370,37 @@ def test_should_leave_later_choices_open_after_start_failure(
     }))
 
     def runner(argv: object, **options: object) -> subprocess.CompletedProcess[str]:
-        raise start_error
+        raise OSError("missing command")
 
     with account_broker.override_subprocess_runner(runner):
         outcome, _ = account_broker._execute(Product.CODEX, ("job",), now=datetime.now(timezone.utc))
 
-    assert outcome.attempts == (("first", expected_status), ("second", expected_status))
+    assert outcome.attempts == (("first", "start_failed"), ("second", "start_failed"))
+    assert account_broker.main(("choose", "--product", "codex")) == 0
+    assert json.loads(capsys.readouterr().out)["decision"]["account"] == "first"
+
+
+def test_should_stop_after_timeout_without_running_job_again(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    accounts = (_account("first"), _account("second"))
+    monkeypatch.setitem(account_broker.all_product_adapters, Product.CODEX, _adapter(accounts, {
+        "first": _meters(80, 80), "second": _meters(70, 70)
+    }))
+    invoked_homes: list[str] = []
+
+    def runner(argv: object, **options: object) -> subprocess.CompletedProcess[str]:
+        invoked_homes.append(Path(options["env"]["CODEX_HOME"]).name)
+        raise subprocess.TimeoutExpired("job", 1)
+
+    with account_broker.override_subprocess_runner(runner):
+        outcome, report = account_broker._execute(Product.CODEX, ("job",), now=datetime.now(timezone.utc))
+
+    assert invoked_homes == ["first"]
+    assert outcome.attempts == (("first", "timeout"),)
+    assert outcome.status == "advisor_blocked"
+    assert outcome.account_name == "first"
+    assert report.final_decision.account.name == "first"
     assert account_broker.main(("choose", "--product", "codex")) == 0
     assert json.loads(capsys.readouterr().out)["decision"]["account"] == "first"
 

package/scripts/tests/test_rules.py

@@ -13,7 +13,7 @@ def _comment_policy_phrases() -> tuple[str, ...]:
         "leave comments tied to untouched code unchanged",
         "keep comment cleanup inside the requested task",
         "production and tests follow one rule",
-        "changed directive, todo, fixme, hack, xxx, and type-ignore comments are removed rather than added or justified",
+        "changed directive, todo, fixme, hack, xxx, and type-ignore comments are removed",
     )