claude-dev-env 8.40.0 → 8.40.1

package/bin/install.mjs

@@ -1364,8 +1364,12 @@ function commandRunsHookOfRootSharingSettings(normalizedCommand, relativePath, s
         const characterAfterPath = normalizedCommand[tailStart + hookPathTail.length];
         if (characterAfterPath === undefined || commandArgumentBoundary.test(characterAfterPath)) {
             let rootStart = tailStart;
-            while (rootStart > 0 && !commandArgumentBoundary.test(normalizedCommand[rootStart - 1])) {
-                rootStart--;
+            if (characterAfterPath === '"' || characterAfterPath === "'") {
+                rootStart = normalizedCommand.lastIndexOf(characterAfterPath, tailStart - 1) + 1;
+            } else {
+                while (rootStart > 0 && !commandArgumentBoundary.test(normalizedCommand[rootStart - 1])) {
+                    rootStart--;
+                }
             }
             const rootPath = normalizedCommand.slice(rootStart, tailStart);
             const rootSettingsRealPath = rootPath

package/bin/install.shared-settings.test.mjs

@@ -17,7 +17,7 @@ import {
 import { tmpdir } from 'node:os';
 import { fileURLToPath } from 'node:url';
 import { spawnSync } from 'node:child_process';
-import { managedHookScriptRelativePaths, mergeHooksIntoSettings } from './install.mjs';
+import { commandArgumentFromPath, managedHookScriptRelativePaths, mergeHooksIntoSettings } from './install.mjs';
 
 const INSTALLER_PATH = fileURLToPath(new URL('./install.mjs', import.meta.url));
 const PACKAGE_HOOKS_JSON_PATH = fileURLToPath(new URL('../hooks/hooks.json', import.meta.url));
@@ -200,3 +200,46 @@ test('the merge prunes a hook of a root sharing the settings file and keeps one
         rmSync(sandboxRoot, { recursive: true, force: true });
     }
 });
+
+test('the merge prunes a quoted hook of a sharing root whose path holds a space', t => {
+    const sandboxRoot = mkdtempSync(join(tmpdir(), 'cdev-shared-settings-space-'));
+    try {
+        const installRoot = join(sandboxRoot, 'install-root');
+        const sharingRoot = join(sandboxRoot, 'Jane Doe', 'profiles', 'second');
+        for (const eachRoot of [installRoot, sharingRoot]) mkdirSync(eachRoot, { recursive: true });
+        const settingsPath = join(installRoot, 'settings.json');
+        writeFileSync(settingsPath, '{}\n');
+        try {
+            symlinkSync(settingsPath, join(sharingRoot, 'settings.json'), 'file');
+        } catch (linkError) {
+            t.skip(`this host cannot create a file symlink (${linkError.code})`);
+            return;
+        }
+        const hooksConfig = {
+            hooks: {
+                SessionStart: [{
+                    matcher: '',
+                    hooks: [{ type: 'command', command: 'python3 ${CLAUDE_PLUGIN_ROOT}/hooks/session/start.py' }],
+                }],
+            },
+        };
+        const forwardSlashed = rootPath => rootPath.replace(/\\/g, '/');
+        const sharingHookPath = `${forwardSlashed(sharingRoot)}/hooks/session/start.py`;
+        for (const eachPlatform of ['linux', 'win32']) {
+            const sharingCommand = `python3 ${commandArgumentFromPath(sharingHookPath, eachPlatform)}`;
+            const settings = {
+                hooks: {
+                    SessionStart: [{ matcher: '', hooks: [{ type: 'command', command: sharingCommand }] }],
+                },
+            };
+
+            mergeHooksIntoSettings(settings, hooksConfig, forwardSlashed(installRoot), 'python3', settingsPath);
+
+            const allCommands = settings.hooks.SessionStart.flatMap(group => group.hooks.map(hook => hook.command));
+            assert.ok(!allCommands.includes(sharingCommand), `the ${eachPlatform}-quoted sharing root entry is pruned`);
+            assert.equal(allCommands.length, 1, `only the install root entry stays after the ${eachPlatform} merge`);
+        }
+    } finally {
+        rmSync(sandboxRoot, { recursive: true, force: true });
+    }
+});

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.40.0",
+    "version": "8.40.1",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {