claude-dev-env 8.36.1 → 8.36.2

package/bin/install.test.mjs

@@ -8,6 +8,7 @@ import {
     writeFileSync,
     symlinkSync,
     readFileSync,
+    readlinkSync,
     readdirSync,
     existsSync,
     copyFileSync,
@@ -16,6 +17,7 @@ import {
 import { tmpdir } from 'node:os';
 import { join, dirname } from 'node:path';
 import { fileURLToPath, pathToFileURL } from 'node:url';
+import { FAULT_PHASES, INSTALL_FAULT_ENV } from './install-transaction.mjs';
 
 import {
     collectPackageSourceConflicts,
@@ -50,6 +52,7 @@ import {
     commandNamesOwnedHookScript,
     hookCommandComparisonSpelling,
     detectPython,
+    pythonFileAndPrefixArguments,
     retainNewestRunBackupOnly,
 } from './install.mjs';
 import { EVER_SHIPPED_SKILL_NAMES } from './ever-shipped-skills.mjs';
@@ -2594,7 +2597,12 @@ test('a stale registration keeps working because the retired hook leaves an iner
             'a retired path no registration names gets no stand-in',
         );
 
-        const standInRun = spawnSync(detectPython(), [standInPath], { encoding: 'utf8' });
+        const pythonCommand = pythonFileAndPrefixArguments(detectPython());
+        const standInRun = spawnSync(
+            pythonCommand.file,
+            [...pythonCommand.prefixArguments, standInPath],
+            { encoding: 'utf8' },
+        );
 
         assert.equal(standInRun.status, 0, 'the stand-in exits 0, so a stale registration allows the tool');
         assert.equal(standInRun.stdout, '', 'the stand-in writes nothing to stdout');
@@ -3006,6 +3014,40 @@ test('pruneRetiredHookEntriesFromSettings warns and returns 0 when the host conf
 const PSTACK_TEST_PACKAGE_ROOT = dirname(fileURLToPath(new URL('./install.mjs', import.meta.url)));
 const PSTACK_TEST_INSTALLER_PATH = fileURLToPath(new URL('./install.mjs', import.meta.url));
 
+test('a failed update preserves an existing skills lookup pointer', () => {
+    const homeDirectory = mkdtempSync(join(tmpdir(), 'cdev-install-pointer-'));
+    try {
+        writeFileSync(join(homeDirectory, '.gitconfig'), '');
+        const environment = {
+            ...process.env,
+            HOME: homeDirectory,
+            USERPROFILE: homeDirectory,
+            CLAUDE_CONFIG_DIR: '',
+            GIT_CONFIG_GLOBAL: join(homeDirectory, '.gitconfig'),
+            CDE_INSTALL_PSTACK: '0',
+            CDE_INSTALL_USAGE_WRAPUP: '0',
+        };
+        const argumentsForCoreInstall = [PSTACK_TEST_INSTALLER_PATH, '--only', 'core'];
+        const firstRun = spawnSync(process.execPath, argumentsForCoreInstall, {
+            encoding: 'utf8',
+            env: environment,
+        });
+        assert.equal(firstRun.status, 0, firstRun.stdout + firstRun.stderr);
+        const pointerPath = join(homeDirectory, '.claude', 'skills');
+        const targetPath = readlinkSync(pointerPath);
+
+        const failedRun = spawnSync(process.execPath, argumentsForCoreInstall, {
+            encoding: 'utf8',
+            env: { ...environment, [INSTALL_FAULT_ENV]: FAULT_PHASES.AFTER_FILE_STAGING },
+        });
+        assert.notEqual(failedRun.status, 0, failedRun.stdout + failedRun.stderr);
+        assert.equal(lstatSync(pointerPath).isSymbolicLink(), true);
+        assert.equal(readlinkSync(pointerPath), targetPath);
+    } finally {
+        rmSync(homeDirectory, { recursive: true, force: true });
+    }
+});
+
 function writeRecordingHostCommand(directory, name, logPath) {
     mkdirSync(directory, { recursive: true });
     if (process.platform === 'win32') {

package/hooks/validation/test_mypy_validator.py

@@ -15,6 +15,8 @@ the cache directory redirected to a temporary directory.
 """
 
 import importlib.util
+import io
+import json
 import os
 import sys
 from pathlib import Path
@@ -53,6 +55,42 @@ def _load_validator() -> ModuleType:
     return module
 
 
+def test_type_error_block_uses_hook_reply_without_notification(
+    tmp_path_factory: pytest.TempPathFactory,
+    monkeypatch: pytest.MonkeyPatch,
+    capsys: pytest.CaptureFixture[str],
+) -> None:
+    validator = _load_validator()
+    project_root = tmp_path_factory.mktemp("blocked_project")
+    target_file = project_root / "typed_module.py"
+    target_file.write_text(TYPE_ERROR_MODULE_SOURCE, encoding="utf-8")
+    all_touched_names: list[str] = []
+
+    class RecordingNotificationModule(ModuleType):
+        def __getattr__(self, attribute_name: str) -> object:
+            if not attribute_name.startswith("__"):
+                all_touched_names.append(attribute_name)
+            return lambda *_arguments, **_options: False
+
+    monkeypatch.setitem(sys.modules, "notification_utils", RecordingNotificationModule("notification_utils"))
+    monkeypatch.setattr(validator, "discover_project_root", lambda _target: project_root)
+    monkeypatch.setattr(
+        validator,
+        "run_mypy",
+        lambda _target, _root: (1, f"{target_file}:1: error: Incompatible types\n"),
+    )
+    monkeypatch.setattr(validator, "log_hook_block", lambda **_details: None)
+    monkeypatch.setattr(
+        sys, "stdin", io.StringIO(json.dumps({"tool_input": {"file_path": str(target_file)}}))
+    )
+
+    with pytest.raises(SystemExit):
+        validator.main()
+
+    assert json.loads(capsys.readouterr().out)["decision"] == "block"
+    assert all_touched_names == []
+
+
 @pytest.fixture(autouse=True)
 def isolate_cache_directory(
     tmp_path_factory: pytest.TempPathFactory, monkeypatch: pytest.MonkeyPatch

package/hooks/workflow/test_auto_formatter.py

@@ -182,6 +182,33 @@ def _load_auto_formatter_module() -> ModuleType:
     return auto_formatter_module
 
 
+def test_successful_format_does_not_access_notifications(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    formatter = _load_auto_formatter_module()
+    all_touched_names: list[str] = []
+
+    class RecordingNotificationModule(ModuleType):
+        def __getattr__(self, attribute_name: str) -> object:
+            if not attribute_name.startswith("__"):
+                all_touched_names.append(attribute_name)
+            return lambda *_arguments, **_options: False
+
+    monkeypatch.setitem(sys.modules, "notification_utils", RecordingNotificationModule("notification_utils"))
+
+    def report_formatter_success(
+        command: list[str], _file_path: str, _timeout_seconds: int
+    ) -> tuple[subprocess.CompletedProcess[str], bool]:
+        return subprocess.CompletedProcess(command, 0, "", ""), False
+
+    monkeypatch.setattr(formatter, "_run_command", report_formatter_success)
+
+    formatter.run_eligible_formatter("formatted_module.py")
+    formatter._run_prettier("formatted_module.js")
+
+    assert all_touched_names == []
+
+
 def test_formatter_eligibility_requires_write_tool_and_untracked_source(
     monkeypatch: pytest.MonkeyPatch, tmp_path: Path
 ) -> None:

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.36.1",
+    "version": "8.36.2",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {