claude-dev-env 8.35.1 → 8.35.2

package/bin/install.mjs

@@ -76,6 +76,7 @@ import {
 } from './resolve-package-managed-directory.mjs';
 import {
     ensureDirectoryPointer,
+    POINTER_ACTION_CREATED,
 } from './publish-directory-pointer.mjs';
 import {
     parseInstallTargetSelectionFromArgv,
@@ -872,7 +873,11 @@ function owningManagedRoot(installedFilePath) {
  * so those two paths are pointers. A real directory from an older install at a
  * lookup path is merged into the agents home before the pointer is written.
  *
- * @returns {string[]} The lookup paths this run published.
+ * A pointer that already aimed at its target is left out of the result, so a
+ * rollback that removes this run's written paths keeps the pointer a prior
+ * install published.
+ *
+ * @returns {string[]} The lookup paths this run created.
  */
 function publishManagedLookupPointers() {
     const pointerPairs = [
@@ -897,10 +902,10 @@ function publishManagedLookupPointers() {
             INSTALL_ROOT_RESOLUTION.hooksInstallDirectory,
         ],
     ];
-    for (const [pointerPath, targetPath] of pointerPairs) {
-        ensureDirectoryPointer(pointerPath, targetPath);
-    }
-    return pointerPairs.map(([pointerPath]) => pointerPath);
+    return pointerPairs
+        .map(([pointerPath, targetPath]) => ensureDirectoryPointer(pointerPath, targetPath))
+        .filter((pointerResult) => pointerResult.action === POINTER_ACTION_CREATED)
+        .map((pointerResult) => pointerResult.pointerPath);
 }
 
 /**

package/bin/install.transaction.test.mjs

@@ -6,9 +6,11 @@ import { test } from 'node:test';
 import { strict as assert } from 'node:assert';
 import {
     existsSync,
+    lstatSync,
     mkdtempSync,
     mkdirSync,
     readFileSync,
+    realpathSync,
     rmSync,
     writeFileSync,
 } from 'node:fs';
@@ -501,3 +503,44 @@ test('successful install after prior install leaves one manifest and no fault',
         rmSync(homeDirectory, { recursive: true, force: true });
     }
 });
+
+test('installer fault keeps the lookup pointers a prior install published', () => {
+    const homeDirectory = mkdtempSync(join(tmpdir(), 'cdev-txn-e2e-pointers-'));
+    try {
+        writeFileSync(join(homeDirectory, '.gitconfig'), '');
+        const homeOnlyEnvironment = { CLAUDE_CONFIG_DIR: '' };
+        const okRun = runInstaller(homeDirectory, ['--only', 'core'], {
+            environment: homeOnlyEnvironment,
+        });
+        assert.equal(okRun.status, 0, okRun.stdout + okRun.stderr);
+        const allPointerTargets = [
+            ...['skills', 'agents', 'hooks', 'scripts'].map((name) => ({
+                pointerPath: join(homeDirectory, '.claude', name),
+                targetPath: realpathSync(join(homeDirectory, '.agents', name)),
+            })),
+            {
+                pointerPath: join(homeDirectory, '.codex', 'hooks'),
+                targetPath: realpathSync(join(homeDirectory, '.agents', 'hooks')),
+            },
+        ];
+
+        for (const faultPhase of [FAULT_PHASES.AFTER_FILE_STAGING, FAULT_PHASES.AFTER_MANIFEST_WRITE]) {
+            const failedRun = runInstaller(homeDirectory, ['--only', 'core'], {
+                faultPhase,
+                environment: homeOnlyEnvironment,
+            });
+            assert.notEqual(failedRun.status, 0, failedRun.stdout + failedRun.stderr);
+            assert.match(`${failedRun.stdout}${failedRun.stderr}`, /prior installation restored/);
+            for (const { pointerPath, targetPath } of allPointerTargets) {
+                assert.equal(
+                    lstatSync(pointerPath, { throwIfNoEntry: false })?.isSymbolicLink(),
+                    true,
+                    `${pointerPath} survives a fault at ${faultPhase}`,
+                );
+                assert.equal(realpathSync(pointerPath), targetPath);
+            }
+        }
+    } finally {
+        rmSync(homeDirectory, { recursive: true, force: true });
+    }
+});

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.35.1",
+    "version": "8.35.2",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {