claude-dev-env 8.33.1 → 8.33.2

package/hooks/advisory/pr_done_reminder.py

@@ -59,6 +59,7 @@ try:
         ALL_FAILING_CHECK_CONCLUSIONS,
         ALL_PASSING_CHECK_CONCLUSIONS,
         CHECK_COMPLETED_STATUS,
+        CHECKS_NOT_REPORTED_TEXT,
         DONE_LABEL_NAME,
         GH_PR_CREATE_ACTION,
         GH_PR_SUBCOMMAND,
@@ -164,7 +165,7 @@ def _check_counts(all_pr_fields: dict[str, object]) -> dict[str, int]:
 
 def _checks_line(all_check_counts: dict[str, int]) -> str:
     if all_check_counts["total"] == 0:
-        return "none reported"
+        return CHECKS_NOT_REPORTED_TEXT
     return (
         f"{all_check_counts['failing']} failing, "
         f"{all_check_counts['pending']} pending, "
@@ -185,6 +186,7 @@ def _has_done_label(all_pr_fields: dict[str, object]) -> bool:
 def _is_done(mergeable_value: str, all_check_counts: dict[str, int]) -> bool:
     return (
         mergeable_value == MERGEABLE_CLEAN_VALUE
+        and all_check_counts["total"] > 0
         and all_check_counts["failing"] == 0
         and all_check_counts["pending"] == 0
     )

package/hooks/advisory/test_pr_done_reminder.py

@@ -152,6 +152,58 @@ def test_should_say_done_when_mergeable_and_checks_pass() -> None:
     assert "NOT DONE" not in context
 
 
+def test_should_say_not_done_when_no_check_has_reported_on_the_head() -> None:
+    no_checks_yet = {**_CLEAN_PR_OBJECT, "statusCheckRollup": []}
+
+    context = pr_done_reminder.build_reminder_context(no_checks_yet)
+
+    assert "CI checks:   none reported yet on this head." in context
+    assert "NOT DONE" in context
+    assert "gh pr edit 42 --add-label" not in context
+
+
+def test_should_say_not_done_when_the_rollup_is_missing() -> None:
+    no_rollup = {key: value for key, value in _CLEAN_PR_OBJECT.items() if key != "statusCheckRollup"}
+
+    context = pr_done_reminder.build_reminder_context(no_rollup)
+
+    assert "none reported yet on this head." in context
+    assert "NOT DONE" in context
+
+
+def test_should_say_not_done_while_a_check_is_pending_on_an_otherwise_green_head() -> None:
+    one_pending = {
+        **_CLEAN_PR_OBJECT,
+        "statusCheckRollup": [
+            {"name": "pytest", "status": "COMPLETED", "conclusion": "SUCCESS"},
+            {"name": "mypy", "status": "QUEUED", "conclusion": ""},
+        ],
+    }
+
+    context = pr_done_reminder.build_reminder_context(one_pending)
+
+    assert "1 pending" in context
+    assert "NOT DONE" in context
+    assert "gh pr edit 42 --add-label" not in context
+
+
+def test_should_say_done_when_every_reported_check_passed() -> None:
+    all_green = {
+        **_CLEAN_PR_OBJECT,
+        "statusCheckRollup": [
+            {"name": "pytest", "status": "COMPLETED", "conclusion": "SUCCESS"},
+            {"name": "docs", "status": "COMPLETED", "conclusion": "SKIPPED"},
+            {"context": "lint", "state": "SUCCESS"},
+        ],
+    }
+
+    context = pr_done_reminder.build_reminder_context(all_green)
+
+    assert "CI checks:   0 failing, 0 pending, 3 total" in context
+    assert "Verdict:     DONE. Add the label now:" in context
+    assert "NOT DONE" not in context
+
+
 def test_should_keep_the_checklist_order_verdict_then_recheck_then_footer() -> None:
     all_lines = pr_done_reminder.build_reminder_context(_CLEAN_PR_OBJECT).split("\n")
 

package/hooks/hooks_constants/pr_done_reminder_constants.py

@@ -28,6 +28,7 @@ __all__ = [
     "REMINDER_FOOTER",
     "REMINDER_LINE_SEPARATOR",
     "ALL_REMINDER_HINTS_BY_MERGEABLE",
+    "CHECKS_NOT_REPORTED_TEXT",
     "VERDICT_DONE",
     "VERDICT_NOT_DONE",
     "NO_PULL_REQUEST_REMINDER",
@@ -75,6 +76,9 @@ ALL_REMINDER_HINTS_BY_MERGEABLE: dict[str, str] = {
     ),
     MERGEABLE_UNKNOWN_VALUE: "GitHub is still computing. Re-run the re-check command in a minute.",
 }
+CHECKS_NOT_REPORTED_TEXT: str = (
+    "none reported yet on this head. Wait for the checks, then run the re-check command."
+)
 VERDICT_DONE: str = "DONE. Add the label now:"
 VERDICT_NOT_DONE: str = "NOT DONE. Do not add the done label yet."
 NO_PULL_REQUEST_REMINDER: str = (

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.33.1",
+    "version": "8.33.2",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {