claude-dev-env 8.31.1 → 8.32.0

package/.agents/skills/pull-request/SKILL.md

@@ -32,7 +32,7 @@ process-local author value. Keep the parent environment unchanged.
 
 Use this skill for one pull request action:
 
-- Create a draft pull request.
+- Create a pull request, ready for review by default or a draft with `--draft`.
 - Edit a pull request title or body.
 - Add a pull request comment.
 - Submit a pull request review.
@@ -91,7 +91,8 @@ Process steps in order.
 
 Resolve the repository, action, and selected GitHub author. For create, resolve
 the source branch, base, and head. For other actions, resolve one existing pull
-request target. Create actions publish drafts. Record the target before any write.
+request target. Create publishes a ready pull request, and `--draft` publishes a
+draft. Record the target before any write.
 
 ### 2. Author the title and body
 
@@ -185,7 +186,7 @@ only after remote readback proves the requested state.
 ## Examples
 
 Create example: the writer produces `pr-body.md`. The linter exits `0` for
-`pr-create`. `pull_request.py create` publishes one draft pull request. The
+`pr-create`. `pull_request.py create` publishes one ready pull request. The
 readback matches the title, body, head SHA, and draft state.
 
 Rejected comment example: the comment body names a worktree file. The linter

package/.agents/skills/pull-request/reference/publication-tasks.md

@@ -3,7 +3,7 @@
 When the session exposes a task tool, register each line as one session task
 before starting the process. This file is a task seed catalog.
 
-1. Resolve one repository, action, and selected author. For create, resolve the source branch, base, and head. For other actions, resolve one existing pull request target. Create actions publish drafts.
+1. Resolve one repository, action, and selected author. For create, resolve the source branch, base, and head. For other actions, resolve one existing pull request target. Create publishes a ready pull request, and `--draft` publishes a draft.
 2. Record the title and body file for create or full body rewrite, written by you or drafted by `pstack:poteto-agent` with a PR-writing brief. Mark `N/A` for comment or review bodies that do not rewrite the pull request description.
 3. Validate every title, body, artifact, and local path input. Reject inline body input.
 4. Resolve the active managed root and run `<managed-root>/scripts/durable_post_lint.py` for the matching action. Record exit code `0` before credential lookup or network work.

package/.agents/skills/pull-request/scripts/pull_request.py

@@ -43,6 +43,7 @@ def _build_parser() -> argparse.ArgumentParser:
     create.add_argument("--head", required=True)
     create.add_argument("--title", required=True)
     create.add_argument("--body-file", required=True, type=Path)
+    create.add_argument("--draft", dest="is_draft", action="store_true")
     edit = all_actions.add_parser(ACTION_EDIT, allow_abbrev=False)
     edit.add_argument("--repo", required=True)
     edit.add_argument("--number", required=True)
@@ -105,11 +106,10 @@ def _linter_arguments(
 
 
 def _create_arguments(arguments: argparse.Namespace) -> list[str]:
-    return [
+    all_arguments = [
         "gh",
         "pr",
         "create",
-        "--draft",
         "--repo",
         arguments.repo,
         "--base",
@@ -121,6 +121,9 @@ def _create_arguments(arguments: argparse.Namespace) -> list[str]:
         "--body-file",
         str(arguments.body_file),
     ]
+    if arguments.is_draft:
+        all_arguments.append("--draft")
+    return all_arguments
 
 
 def _edit_arguments(arguments: argparse.Namespace) -> list[str]:

package/.agents/skills/pull-request/scripts/test_pull_request.py

@@ -47,7 +47,38 @@ ACTION_CASES = [
             "gh",
             "pr",
             "create",
+            "--repo",
+            REPOSITORY,
+            "--base",
+            "main",
+            "--head",
+            "feature/post",
+            "--title",
+            PR_TITLE,
+            "--body-file",
+            BODY_FILENAME,
+        ],
+    ),
+    (
+        [
+            "create",
+            "--repo",
+            REPOSITORY,
+            "--base",
+            "main",
+            "--head",
+            "feature/post",
+            "--title",
+            PR_TITLE,
+            "--body-file",
+            BODY_FILENAME,
             "--draft",
+        ],
+        "pr-create",
+        [
+            "gh",
+            "pr",
+            "create",
             "--repo",
             REPOSITORY,
             "--base",
@@ -58,6 +89,7 @@ ACTION_CASES = [
             PR_TITLE,
             "--body-file",
             BODY_FILENAME,
+            "--draft",
         ],
     ),
     (

package/commands/fix-followups.md

@@ -1,10 +1,10 @@
 ---
-description: Fix every non-breaking finding the follow-up ledger holds and open a draft PR for it
+description: Fix every non-breaking finding the follow-up ledger holds and open a PR for it
 argument-hint: [repository root, or blank for the current repository]
 ---
 
 Fix the non-breaking findings a local gate recorded rather than blocked on,
-and deliver them as one draft pull request.
+and deliver them as one pull request.
 
 The repository root is `$ARGUMENTS`, or the current repository when that is
 blank.
@@ -50,7 +50,7 @@ finding names a generated file, regenerate it with the repository's tooling.
 Branch from the repository's default branch. Commit each group on its own,
 with a message naming the check identifier and the files.
 
-Open the pull request as a draft. Write the body as:
+Open the pull request ready for review. Write the body as:
 
 - One `Before:` paragraph saying which findings stood open.
 - One `After:` paragraph saying what the tree now holds.

package/commands/sr-loop.md

@@ -39,7 +39,7 @@ stack's design, intent, and changes.
    code, not the full repo suite), commit once (`git commit -F <file>`, body
    written with the Write tool, Co-Authored-By line, 10-minute timeout — the
    pre-commit gate runs its own tests), and push to the PR head branch. The PR
-   stays draft.
+   keeps its draft or ready state.
 3. Repeat the invocation only after substantive findings or a user request.
    **Skips are sticky:** carry every adjudicated skip
    forward into the next pass as "already adjudicated — do not re-report: ..."
@@ -64,8 +64,9 @@ stack's design, intent, and changes.
 
 ## Finish
 
-When both phases are clean, or only fixed nits remain, mark the target PR ready
-with `gh pr ready`. Confirm that it is no longer a draft.
+When both phases are clean, or only fixed nits remain, a target PR that is a
+draft goes ready with `gh pr ready`. Confirm that it now reads ready. A
+ready target PR stays as it is.
 
 Report: passes run per phase, commits pushed with hashes, fixes applied, and
 the standing skip list with reasons.

package/hooks/advisory/test_pr_done_reminder.py

@@ -242,7 +242,8 @@ def test_main_should_remind_to_open_a_pr_when_the_branch_has_none(
     context = _additional_context(_run_main(monkeypatch, capsys, _payload("git push"), no_pr))
 
     assert "No open pull request found" in context
-    assert "gh pr create --draft" in context
+    assert "Open a pull request with gh pr create." in context
+    assert "--draft" not in context
 
 
 def test_main_should_stay_quiet_on_any_other_gh_failure(

package/hooks/blocking/block_main_commit.py

@@ -23,6 +23,7 @@ if _hooks_dir not in sys.path:
 
 from hooks_constants.hook_block_logger import log_hook_block  # noqa: E402
 
+from hooks_constants.block_main_commit_constants import PULL_REQUEST_INSTRUCTION
 from hooks_constants.subprocess_window import hidden_window_creation_flags
 
 GIT_COMMAND_TIMEOUT_SECONDS = 5
@@ -164,20 +165,11 @@ def parse_bash_command_from_stdin() -> str:
     return bash_command
 
 
-DRAFT_PR_INSTRUCTION = (
-    " Instead: (1) create a feature branch with `git checkout -b <descriptive-branch-name>`, "
-    "(2) commit your changes there, "
-    "(3) push with `git push -u origin <branch-name>`, "
-    "(4) create a draft PR with `gh pr create --draft`. "
-    "If you must commit to main, the user needs to approve explicitly."
-)
-
-
 def build_denial_response(branch_name: str, repo_dir: str | None) -> dict:
     location = f" in {repo_dir}" if repo_dir else ""
     denial_reason = (
         f"BLOCKED: Direct commit to '{branch_name}'{location} is not allowed."
-        + DRAFT_PR_INSTRUCTION
+        + PULL_REQUEST_INSTRUCTION
     )
 
     return {

package/hooks/blocking/test_block_main_commit.py

@@ -74,6 +74,19 @@ def test_blocks_commit_on_protected_branch_from_hook_event_cwd(tmp_path: Path) -
     assert str(repository) in hook_response["hookSpecificOutput"]["permissionDecisionReason"]
 
 
+def test_denial_should_open_a_ready_pull_request(tmp_path: Path) -> None:
+    repository = _create_repository(tmp_path, "main")
+    process_repository = _create_repository(tmp_path, "agent-owned-change")
+
+    completed_process = _run_commit_gate(repository, process_repository)
+
+    denial_reason = json.loads(completed_process.stdout)["hookSpecificOutput"][
+        "permissionDecisionReason"
+    ]
+    assert "open a pull request with `gh pr create`" in denial_reason
+    assert "--draft" not in denial_reason
+
+
 def test_allows_commit_on_owned_branch_from_hook_event_cwd(tmp_path: Path) -> None:
     repository = _create_repository(tmp_path, "agent-owned-change")
     process_repository = _create_repository(tmp_path, "main")

package/hooks/hooks_constants/block_main_commit_constants.py

@@ -0,0 +1,9 @@
+"""Constants for the protected-branch commit gate."""
+
+PULL_REQUEST_INSTRUCTION = (
+    " Instead: (1) create a feature branch with `git checkout -b <descriptive-branch-name>`, "
+    "(2) commit your changes there, "
+    "(3) push with `git push -u origin <branch-name>`, "
+    "(4) open a pull request with `gh pr create`. "
+    "If you must commit to main, the user needs to approve explicitly."
+)

package/hooks/hooks_constants/pr_done_reminder_constants.py

@@ -87,7 +87,7 @@ VERDICT_DONE: str = "DONE. Add the label now:"
 VERDICT_NOT_DONE: str = "NOT DONE. Do not add the done label yet."
 NO_PULL_REQUEST_REMINDER: str = (
     "=== PR DONE CHECKLIST (context reminder, never a block) ===\n"
-    "No open pull request found for this branch. Open a draft PR with gh pr create --draft.\n"
+    "No open pull request found for this branch. Open a pull request with gh pr create.\n"
     "A branch is done only when its PR has clean CI, no merge conflicts, and the done label."
 )
 RECHECK_COMMAND_TEMPLATE: str = (

package/hooks/pyproject.toml

@@ -17,7 +17,6 @@ exclude = [
     "validators/test_files/",
     "test_",
     "abbreviation_checks.py",
-    "git_checks.py",
     "exempt_paths.py",
     "code_rules_typeddict_stub.py",
 ]

package/hooks/validators/README.md

@@ -14,7 +14,6 @@ The checks live in `python_style_checks.py`. Shared source-line splitting, funct
 | `exempt_paths.py` | Shared config, test, and hook-infrastructure path exemptions |
 | `fast_save_validators.py` | In-process Write/Edit save-path validator roster |
 | `file_structure_checks.py` | File structure checks for pre-PR validation |
-| `git_checks.py` | Git and GitHub checks for pre-push review |
 | `health_check.py` | Validator availability, dependency, and version checks |
 | `hook_timing_harness.py` | Hook runtime measurement and threshold report |
 | `magic_value_checks.py` | Hardcoded magic-number checks |

package/hooks/validators/health_check.py

@@ -23,7 +23,6 @@ VALIDATOR_FILES = [
     "test_safety_checks.py",
     "file_structure_checks.py",
     "react_checks.py",
-    "git_checks.py",
     "comment_checks.py",
 ]
 

package/hooks/validators/run_all_validators.py

@@ -402,18 +402,6 @@ def run_react_checks(files: List[Path]) -> ValidatorResult:
     )
 
 
-def run_git_checks() -> ValidatorResult:
-    """Run git/GitHub checks."""
-    result = invoke_validator_module("git_checks", [])
-
-    return ValidatorResult(
-        name="Git/PR Workflow",
-        checks="23,24",
-        passed=result.returncode == 0,
-        output=result.stdout or result.stderr or "All checks passed",
-    )
-
-
 def run_comment_checks(files: List[Path]) -> ValidatorResult:
     """Report that comment policy runs through the explicit diff-aware linter."""
     return ValidatorResult(
@@ -1693,7 +1681,6 @@ def main() -> int:
 
     validators.extend([
         ("File Structure", run_file_structure_checks),
-        ("Git/PR", run_git_checks),
     ])
 
     for i, (name, validator_func) in enumerate(validators, 1):

package/hooks/validators/test_run_all_validators.py

@@ -19,7 +19,6 @@ from .run_all_validators import (
     format_timing_report,
     main,
     print_header,
-    run_git_checks,
     run_python_style_checks,
     run_with_fallback,
     validate_proposed_file,
@@ -164,11 +163,9 @@ class TestFixFlag:
     def test_fix_flag_is_accepted(self) -> None:
         """Verify --fix flag is recognized without error."""
         with patch("validators.run_all_validators.get_changed_files") as mock_get_files, \
-             patch("validators.run_all_validators.run_file_structure_checks") as mock_file, \
-             patch("validators.run_all_validators.run_git_checks") as mock_git:
+             patch("validators.run_all_validators.run_file_structure_checks") as mock_file:
             mock_get_files.return_value = []
             mock_file.return_value = _passing_mock_result()
-            mock_git.return_value = _passing_mock_result()
 
             assert _run_main_with_argv(["run_all_validators.py", "--fix"]) == 0
 
@@ -180,11 +177,10 @@ class TestFixFlag:
              patch("validators.run_all_validators.run_test_safety_checks") as mock_test, \
              patch("validators.run_all_validators.run_react_checks") as mock_react, \
              patch("validators.run_all_validators.run_comment_checks") as mock_comment, \
-             patch("validators.run_all_validators.run_file_structure_checks") as mock_file, \
-             patch("validators.run_all_validators.run_git_checks") as mock_git:
+             patch("validators.run_all_validators.run_file_structure_checks") as mock_file:
             mock_get_files.return_value = [Path("test.py")]
             mock_fix.return_value = ["test.py"]
-            for each_mock in (mock_style, mock_test, mock_react, mock_comment, mock_file, mock_git):
+            for each_mock in (mock_style, mock_test, mock_react, mock_comment, mock_file):
                 each_mock.return_value = _passing_mock_result()
 
             _run_main_with_argv(["run_all_validators.py", "--fix"])
@@ -199,10 +195,9 @@ class TestFixFlag:
              patch("validators.run_all_validators.run_test_safety_checks") as mock_test, \
              patch("validators.run_all_validators.run_react_checks") as mock_react, \
              patch("validators.run_all_validators.run_comment_checks") as mock_comment, \
-             patch("validators.run_all_validators.run_file_structure_checks") as mock_file, \
-             patch("validators.run_all_validators.run_git_checks") as mock_git:
+             patch("validators.run_all_validators.run_file_structure_checks") as mock_file:
             mock_get_files.return_value = [Path("test.py")]
-            for each_mock in (mock_style, mock_test, mock_react, mock_comment, mock_file, mock_git):
+            for each_mock in (mock_style, mock_test, mock_react, mock_comment, mock_file):
                 each_mock.return_value = _passing_mock_result()
 
             _run_main_with_argv(["run_all_validators.py"])
@@ -302,32 +297,6 @@ class TestStderrSurfacing:
 
             assert "ImportError" in validator_result.output
 
-    def test_git_check_surfaces_stderr_when_stdout_empty(self) -> None:
-        """When git validator crashes with no stdout, stderr must appear in output."""
-        with patch("validators.run_all_validators.invoke_validator_module") as mock_invoke:
-            crashed_result = MagicMock()
-            crashed_result.returncode = 1
-            crashed_result.stdout = ""
-            crashed_result.stderr = "SyntaxError: invalid syntax in git_checks.py"
-            mock_invoke.return_value = crashed_result
-
-            validator_result = run_git_checks()
-
-            assert "SyntaxError" in validator_result.output
-
-    def test_output_falls_back_to_all_checks_passed_when_both_empty(self) -> None:
-        """When both stdout and stderr are empty and returncode is 0, use fallback."""
-        with patch("validators.run_all_validators.invoke_validator_module") as mock_invoke:
-            clean_result = MagicMock()
-            clean_result.returncode = 0
-            clean_result.stdout = ""
-            clean_result.stderr = ""
-            mock_invoke.return_value = clean_result
-
-            validator_result = run_git_checks()
-
-            assert validator_result.output == "All checks passed"
-
 
 class TestTimingMetrics:
     def test_create_timing_metrics_empty(self) -> None:

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.31.1",
+    "version": "8.32.0",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/rules/agent-merges-its-own-green-pull-request.md

@@ -50,6 +50,6 @@ Delete nothing by hand. The repository deletes the head branch on merge.
 
 | Rule | Role |
 |---|---|
-| [`git-workflow.md`](git-workflow.md) | Draft first, and confirm each required context fired after the push |
+| [`git-workflow.md`](git-workflow.md) | Open ready for review, and confirm each required context fired after the push |
 | [`ci-owns-the-gate.md`](ci-owns-the-gate.md) | The gate runs once, and it runs on CI |
 | [`correction-lens.md`](correction-lens.md) | A correction becomes a control at the highest layer that can hold it |

package/rules/flag-non-breaking-findings.md

@@ -84,7 +84,7 @@ escalates rather than opening one more quiet pull request. The number is the
 repository's setting, and raising or lowering it is one edit there.
 
 The `/fix-followups` command drives the whole pass: it reads the brief, fixes
-each rule group, opens a draft pull request, and clears the ledger.
+each rule group, opens a pull request, and clears the ledger.
 
 ## Worked example
 

package/rules/git-workflow.md

@@ -15,7 +15,8 @@ User-level rule: applies to **every** git repo that uses GitHub with `gh`. Small
 
 ## Pull request submission rules
 
-**Create every pull request as a draft.** Use `gh pr create --draft`.
+**Open every pull request ready for review.** Pass `--draft` only when the owner asks
+for a draft.
 
 **A release bot's PR body is machine input. Leave it alone.** Release automation reads
 back the body of its own merged pull request to decide it owns that merge. Rewriting the
@@ -45,12 +46,6 @@ Use `.agents/skills/pull-request/scripts/recover_legacy_author.py
 author record. Do not infer a record from age alone. Keep every other record
 untouched.
 
-## Git golden rules
-
-1. **Draft before push.** Put a pull request in draft state before you push to it.
-   - Before push: `gh pr ready --undo`
-   - After review approved: `gh pr ready`
-
 ## Confirm the required checks fired, and let CI run them
 
 The gate runs once, and it runs on CI. Push the branch and read its verdict.

package/rules/review-closure-is-a-check.md

@@ -50,5 +50,5 @@ A repository that merges through a merge queue also runs the check on `merge_gro
 | Rule | Role |
 |---|---|
 | [`agent-merges-its-own-green-pull-request.md`](agent-merges-its-own-green-pull-request.md) | The agent that drives a pull request merges it once its gate passes |
-| [`git-workflow.md`](git-workflow.md) | Draft first, and confirm each required context fired after the push |
+| [`git-workflow.md`](git-workflow.md) | Open ready for review, and confirm each required context fired after the push |
 | [`correction-lens.md`](correction-lens.md) | A correction becomes a control at the highest layer that can hold it |

package/scripts/dev_env_scripts_constants/followup_constants.py

@@ -72,7 +72,7 @@ USAGE_TEXT: str = (
 )
 
 BRIEF_HEADER: str = (
-    "Fix every finding below in one change, then open a draft pull request "
+    "Fix every finding below in one change, then open a pull request "
     "for it. Each finding is non-breaking, so the change that raised it "
     "already shipped. Keep the fixes mechanical, touch no behavior, and run "
     "the repository's own checks before pushing."

package/scripts/test_followup_cli.py

@@ -130,7 +130,8 @@ def test_brief_names_every_recorded_finding_and_the_repository(tmp_path: Path) -
     assert exit_code == 0
     assert "instruction-git-mode" in output_text
     assert "wrong mode" in output_text
-    assert "draft pull request" in output_text
+    assert "open a pull request for it" in output_text
+    assert "draft pull request" not in output_text
 
 
 def test_brief_asks_for_no_work_on_an_empty_ledger(tmp_path: Path) -> None:

package/hooks/validators/git_checks.py

@@ -1,110 +0,0 @@
-"""Git and GitHub validation checks for pre-push review."""
-
-import json
-import subprocess
-import sys
-from dataclasses import dataclass
-from typing import List
-
-from hooks_constants.subprocess_window import hidden_window_creation_flags
-
-SUBPROCESS_TIMEOUT_SECONDS = 30
-
-
-@dataclass
-class Violation:
-    """Represents a validation violation."""
-    file: str
-    line: int
-    message: str
-
-
-def get_current_branch() -> str:
-    """Get the current git branch name."""
-    try:
-        result = subprocess.run(
-            ["git", "rev-parse", "--abbrev-ref", "HEAD"],
-            capture_output=True,
-            text=True,
-            check=True,
-            timeout=SUBPROCESS_TIMEOUT_SECONDS,
-            creationflags=hidden_window_creation_flags(),
-        )
-        return result.stdout.strip()
-    except (FileNotFoundError, subprocess.CalledProcessError, subprocess.TimeoutExpired):
-        return ""
-
-
-def check_draft_pr_state() -> List[Violation]:
-    """
-    Check that PR is in draft state.
-
-    Returns empty list if:
-    - No PR exists for current branch
-    - gh CLI not available
-    - PR is in draft state
-
-    Returns violation if:
-    - PR is not in draft state
-    """
-    branch = get_current_branch()
-    if not branch:
-        return []
-
-    try:
-        pr_info = subprocess.run(
-            ["gh", "pr", "list", "--head", branch, "--json", "number,isDraft"],
-            capture_output=True,
-            text=True,
-            check=True,
-            timeout=SUBPROCESS_TIMEOUT_SECONDS,
-            creationflags=hidden_window_creation_flags(),
-        )
-    except FileNotFoundError:
-        return []
-    except subprocess.CalledProcessError:
-        return []
-    except subprocess.TimeoutExpired:
-        return []
-
-    if not pr_info.stdout.strip():
-        return []
-
-    try:
-        pr_data = json.loads(pr_info.stdout)
-    except json.JSONDecodeError:
-        return []
-
-    if not pr_data:
-        return []
-
-    is_draft = pr_data[0].get("isDraft", False)
-
-    if is_draft:
-        return []
-
-    return [
-        Violation(
-            file="",
-            line=0,
-            message="PR must be in draft state before pushing. Run: gh pr ready --undo",
-        )
-    ]
-
-
-def main() -> None:
-    """Run all git checks and exit with appropriate code."""
-    violations: List[Violation] = []
-
-    violations.extend(check_draft_pr_state())
-
-    if violations:
-        for violation in violations:
-            print(violation.message)
-        sys.exit(1)
-
-    sys.exit(0)
-
-
-if __name__ == "__main__":
-    main()

package/hooks/validators/test_git_checks.py

@@ -1,112 +0,0 @@
-"""Tests for git and GitHub validation checks."""
-
-import subprocess
-from unittest.mock import MagicMock, patch
-
-import pytest
-
-from .git_checks import (
-    Violation,
-    check_draft_pr_state,
-    main,
-)
-
-
-class TestDraftPrState:
-    """Test that PR is in draft state when pushing review fixes."""
-
-    @patch("validators.git_checks.subprocess.run")
-    def test_no_pr_returns_empty(self, mock_run: MagicMock) -> None:
-        """When no PR exists, check should return empty list."""
-        mock_run.return_value = MagicMock(returncode=0, stdout="[]", stderr="")
-
-        violations = check_draft_pr_state()
-
-        assert violations == []
-
-    @patch("validators.git_checks.subprocess.run")
-    def test_draft_pr_passes(self, mock_run: MagicMock) -> None:
-        """Draft PR should pass."""
-        mock_run.return_value = MagicMock(
-            returncode=0,
-            stdout='[{"number": 123, "isDraft": true}]',
-            stderr=""
-        )
-
-        violations = check_draft_pr_state()
-
-        assert violations == []
-
-    @patch("validators.git_checks.subprocess.run")
-    def test_non_draft_pr_fails(self, mock_run: MagicMock) -> None:
-        """Non-draft PR should fail."""
-        mock_run.return_value = MagicMock(
-            returncode=0,
-            stdout='[{"number": 123, "isDraft": false}]',
-            stderr=""
-        )
-
-        violations = check_draft_pr_state()
-
-        assert len(violations) == 1
-        assert violations[0].file == ""
-        assert violations[0].line == 0
-        assert "draft" in violations[0].message.lower()
-        assert "gh pr ready --undo" in violations[0].message
-
-    @patch("validators.git_checks.subprocess.run")
-    def test_gh_cli_not_available_returns_empty(self, mock_run: MagicMock) -> None:
-        """When gh CLI not available, should return empty (warning, not failure)."""
-        mock_run.side_effect = FileNotFoundError("gh not found")
-
-        violations = check_draft_pr_state()
-
-        assert violations == []
-
-    @patch("validators.git_checks.subprocess.run")
-    def test_gh_timeout_returns_empty(self, mock_run: MagicMock) -> None:
-        """When gh CLI times out, should return empty (warning, not failure)."""
-        mock_run.side_effect = subprocess.TimeoutExpired(cmd=["gh", "pr", "list"], timeout=30)
-
-        violations = check_draft_pr_state()
-
-        assert violations == []
-
-
-class TestMain:
-    """Test main function integration."""
-
-    @patch("validators.git_checks.check_draft_pr_state")
-    def test_main_no_violations_exits_zero(
-        self,
-        mock_draft: MagicMock,
-        capsys,
-    ) -> None:
-        """main() should exit 0 when no violations found."""
-        mock_draft.return_value = []
-
-        with pytest.raises(SystemExit) as exc_info:
-            main()
-
-        assert exc_info.value.code == 0
-        captured = capsys.readouterr()
-        assert captured.out == ""
-
-    @patch("validators.git_checks.check_draft_pr_state")
-    def test_main_prints_violations_without_file_line(
-        self,
-        mock_draft: MagicMock,
-        capsys,
-    ) -> None:
-        """main() should print git violations without file:line: prefix."""
-        mock_draft.return_value = [
-            Violation(file="", line=0, message="PR must be in draft state")
-        ]
-
-        with pytest.raises(SystemExit) as exc_info:
-            main()
-
-        assert exc_info.value.code == 1
-        captured = capsys.readouterr()
-        assert captured.out == "PR must be in draft state\n"
-        assert ":0:" not in captured.out