claude-dev-env 8.24.0 → 8.25.1

package/hooks/blocking/test_code_rules_logging_printf_tokens.py

@@ -1,134 +0,0 @@
-"""Tests for the printf-token check on str.format-logger (automation_logging) calls."""
-
-from __future__ import annotations
-
-import importlib.util
-from pathlib import Path
-from types import ModuleType
-
-ENFORCER_FILENAME = "code_rules_enforcer.py"
-ENFORCER_MODULE_NAME = "code_rules_enforcer_printf_under_test"
-PRODUCTION_FILE_PATH = "shared_utils/web_automation/sample.py"
-TEST_FILE_PATH = "shared_utils/web_automation/tests/test_sample.py"
-FORMAT_LOGGER_IMPORT = (
-    "from shared_utils.automation_logging import log_error, log_info, log_debug\n"
-)
-
-
-def load_enforcer_module() -> ModuleType:
-    enforcer_path = Path(__file__).parent / ENFORCER_FILENAME
-    module_spec = importlib.util.spec_from_file_location(ENFORCER_MODULE_NAME, enforcer_path)
-    assert module_spec is not None
-    assert module_spec.loader is not None
-    enforcer_module = importlib.util.module_from_spec(module_spec)
-    module_spec.loader.exec_module(enforcer_module)
-    return enforcer_module
-
-
-enforcer = load_enforcer_module()
-
-
-def test_should_flag_percent_s_in_format_logger_call() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_error("Skipping %s after error: %s", name, err)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert len(issues) == 1
-    assert "printf token" in issues[0]
-
-
-def test_should_flag_percent_d_in_format_logger_call() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_debug("attempt %d of %d", index, total)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert len(issues) == 1
-
-
-def test_should_allow_brace_placeholders_in_format_logger_call() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_info("Processing {} of {}", index, total)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert issues == []
-
-
-def test_should_ignore_percent_token_without_format_logger_import() -> None:
-    source = 'log_error("Skipping %s", name)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert issues == []
-
-
-def test_should_ignore_attribute_style_logger_call() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'logger.info("delivered %s", message_id)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert issues == []
-
-
-def test_should_inspect_message_literal_not_argument_value() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_info("status: {}", "100%s done")\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert issues == []
-
-
-def test_should_exempt_test_files() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_error("Skipping %s", name)\n'
-    issues = enforcer.check_logging_printf_tokens(source, TEST_FILE_PATH)
-    assert issues == []
-
-
-def test_should_resolve_aliased_format_logger_import() -> None:
-    source = (
-        "from shared_utils.automation_logging import log_error as report_error\n"
-        + 'report_error("failed %s", name)\n'
-    )
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert len(issues) == 1
-
-
-def test_should_allow_token_bearing_message_with_no_format_args() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_info("Use %s for string substitution")\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert issues == []
-
-
-def test_should_allow_documentation_style_token_message_with_no_args() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_warning("avoid %s-style tokens here")\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert issues == []
-
-
-def test_should_allow_percent_adjacent_to_word_in_format_message() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_info("memory 80%free now", host)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert issues == []
-
-
-def test_should_allow_doubled_percent_in_format_message() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_info("100%% done", host)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert issues == []
-
-
-def test_should_allow_trailing_percent_in_format_message() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_info("100% done", host)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert issues == []
-
-
-def test_should_flag_width_token_in_format_logger_call() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_error("item %5d", index)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert len(issues) == 1
-
-
-def test_should_flag_precision_token_in_format_logger_call() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_error("took %0.2f sec", elapsed)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert len(issues) == 1
-
-
-def test_should_flag_float_general_token_in_format_logger_call() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_error("ratio %g", ratio)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert len(issues) == 1
-
-
-def test_should_flag_scientific_token_in_format_logger_call() -> None:
-    source = FORMAT_LOGGER_IMPORT + 'log_error("value %e", measurement)\n'
-    issues = enforcer.check_logging_printf_tokens(source, PRODUCTION_FILE_PATH)
-    assert len(issues) == 1

package/rules/nas-ssh-invocation.md

@@ -1,29 +0,0 @@
-# Running Commands on the NAS
-
-Reach the NAS through the `nas_ssh_key.py` runner, never through `ssh`, `scp` or `sftp`:
-
-```
-python <runner-path> <command-script.sh> <private-key-path>
-```
-
-The first argument is a **path to a file** holding a bash script, not a command string. Write that
-file with the Write tool. The whole script runs in one shell, so variables, `cd` and `source` carry
-from line to line.
-
-The runner ships with the automation project it serves; read its path from that project's own
-reference. Use the ops key under `~/.claude/keys` — keys under `~/.ssh` either carry a passphrase,
-which cannot be answered unattended, or belong to other hosts.
-
-The runner loads the key with paramiko and signs in the same process. The command-line clients check
-the key file's permissions first and refuse it, and Git Bash's `ssh` then falls back to a password
-prompt that hangs an unattended run. No hook denies an ssh-family word aimed at the NAS, so keep to
-the runner yourself. When the `System32/OpenSSH` binary is unavoidable, pass `-o BatchMode=yes` so it
-fails fast on a refused key.
-
-Host, ssh port and ssh user are constants inside the runner and are also under the `nas` key in
-`~/.claude/local-identity.json`. Keep all three out of anything committed or posted.
-
-To copy a file, write it inside the script with a quoted heredoc rather than reaching for `scp`.
-
-The `/tmp` size limit, how to tell a break in the code from a platform-only one, and a failure-to-cause
-table: `@~/.claude/docs/nas-ssh-invocation.md`.