claude-dev-env 8.21.0 → 8.23.0

package/scripts/test_shared_tree_paths.py

@@ -21,6 +21,10 @@ from dev_env_scripts_constants.grok_worker_constants import (  # noqa: E402
     SCRIPTS_DIRECTORY_NAME,
     SHARED_PACKAGE_DIRECTORY_NAME,
 )
+from dev_env_scripts_constants.shared_tree_constants import (
+    ADVISOR_DIRECTORY_NAME,
+    TIER_MODEL_IDS_MODULE_FILENAME,
+)
 
 
 def _create_directory_link(*, from_link: Path, to_target: Path) -> None:
@@ -143,6 +147,29 @@ def test_missing_module_returns_unresolved_candidate(tmp_path: Path) -> None:
     ).is_file()
 
 
+def test_junction_scripts_dir_finds_advisor_scripts_on_unresolved_parent(
+    tmp_path: Path,
+) -> None:
+    module_file = _build_junction_scripts_layout(tmp_path)
+    expected_scripts_directory = (
+        tmp_path
+        / "root"
+        / SHARED_PACKAGE_DIRECTORY_NAME
+        / ADVISOR_DIRECTORY_NAME
+        / SCRIPTS_DIRECTORY_NAME
+    )
+    expected_scripts_directory.mkdir(parents=True)
+    (expected_scripts_directory / TIER_MODEL_IDS_MODULE_FILENAME).write_text(
+        "", encoding="utf-8"
+    )
+    resolved_scripts_directory = (
+        shared_tree_paths.resolve_shared_advisor_scripts_directory(
+            module_file, all_environment={}
+        )
+    )
+    assert resolved_scripts_directory == expected_scripts_directory
+
+
 def test_generalized_resolver_serves_a_deeper_anchor(tmp_path: Path) -> None:
     """A caller three levels under the root resolves its own sub-package.
 

package/scripts/tests/test_adapter_configuration.py

@@ -58,6 +58,22 @@ def test_new_step_note_gate_registration_is_clean(tmp_path: Path) -> None:
     assert adapters.hook_configuration_diagnostics(current_document, tmp_path) == ()
 
 
+def test_new_reply_length_gate_registration_is_clean(tmp_path: Path) -> None:
+    current_document = _hook_document(
+        ["hooks/blocking/reply_length_gate.py"],
+        '{"hooks": {}}',
+    )
+    assert adapters.hook_configuration_diagnostics(current_document, tmp_path) == ()
+
+
+def test_new_edit_marker_gate_registration_is_clean(tmp_path: Path) -> None:
+    current_document = _hook_document(
+        ["hooks/blocking/edit_marker_gate.py"],
+        '{"hooks": {}}',
+    )
+    assert adapters.hook_configuration_diagnostics(current_document, tmp_path) == ()
+
+
 def test_new_blocker_in_staged_change_is_rejected(tmp_path: Path) -> None:
     current_document = _hook_document(
         ["hooks/blocking/new.py"],

package/scripts/tests/test_local_report_publisher_cli.py

@@ -6,6 +6,8 @@ import subprocess
 import sys
 from pathlib import Path
 
+import pytest
+
 SCRIPTS_DIRECTORY = Path(__file__).resolve().parents[1]
 if str(SCRIPTS_DIRECTORY) not in sys.path:
     sys.path.insert(0, str(SCRIPTS_DIRECTORY))
@@ -83,3 +85,55 @@ def test_publisher_script_displays_help_without_authentication() -> None:
 
     assert completed_process.returncode == 0
     assert "usage:" in completed_process.stdout
+
+
+def _token_arguments(tmp_path: Path, variable_name: str) -> list[str]:
+    return [
+        "--api-url",
+        "http://127.0.0.1:9",
+        "--token-environment",
+        variable_name,
+        "--repository",
+        "owner/repository",
+        "--pull-number",
+        "7",
+        "--local-repo",
+        str(tmp_path),
+        "--manifest",
+        str(tmp_path / "manifest.json"),
+        "--report",
+        str(tmp_path / "report.json"),
+    ]
+
+
+def test_cli_names_missing_token_variable_without_network_access(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    monkeypatch.delenv("PUBLISHER_TEST_TOKEN", raising=False)
+    standard_output = io.StringIO()
+    standard_error = io.StringIO()
+
+    exit_code = main(
+        _token_arguments(tmp_path, "PUBLISHER_TEST_TOKEN"),
+        stdout=standard_output,
+        stderr=standard_error,
+    )
+
+    assert exit_code == 3
+    assert standard_output.getvalue() == ""
+    assert "PUBLISHER_TEST_TOKEN" in standard_error.getvalue()
+
+
+def test_cli_token_path_reaches_the_api_without_app_settings(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    monkeypatch.setenv("PUBLISHER_TEST_TOKEN", "token")
+    standard_error = io.StringIO()
+
+    exit_code = main(
+        _token_arguments(tmp_path, "PUBLISHER_TEST_TOKEN"), stderr=standard_error
+    )
+
+    assert exit_code == 3
+    assert "Missing publisher setting" not in standard_error.getvalue()
+    assert "refused" in standard_error.getvalue().lower()

package/scripts/tests/test_review_closure.py

@@ -140,6 +140,7 @@ def should_print_the_url_of_a_waiting_top_level_comment(
         identifier=1,
         author_login="qodo-merge-pro[bot]",
         is_bot=True,
+        is_notice=False,
         created_at=posted,
         updated_at=posted,
         url=summary_url,

package/scripts/tests/test_review_closure_model.py

@@ -4,6 +4,8 @@ import sys
 from datetime import datetime
 from pathlib import Path
 
+import pytest
+
 SCRIPTS_DIRECTORY = Path(__file__).resolve().parents[1]
 if str(SCRIPTS_DIRECTORY) not in sys.path:
     sys.path.insert(0, str(SCRIPTS_DIRECTORY))
@@ -315,11 +317,13 @@ def top_level_comment(
     edited_minute: int | None = None,
     url: str = BOT_SUMMARY_URL,
     is_bot: bool = True,
+    is_notice: bool = False,
 ) -> model.TopLevelComment:
     return model.TopLevelComment(
         identifier=posted_minute,
         author_login=author_login,
         is_bot=is_bot,
+        is_notice=is_notice,
         created_at=at_minute(posted_minute),
         updated_at=at_minute(posted_minute if edited_minute is None else edited_minute),
         url=url,
@@ -445,6 +449,72 @@ def should_open_a_bot_comment_posted_after_the_driver_time() -> None:
     )
 
 
+def should_close_a_bot_notice_posted_after_the_driver_time() -> None:
+    comment = top_level_comment(REVIEW_BOT, 5, is_notice=True)
+
+    assert model.top_level_finding(comment, DRIVING_AGENT, at_minute(4)) is None
+
+
+@pytest.mark.parametrize(
+    "body",
+    [
+        "No code changes since the last review \u2014 review skipped",
+        "[Code review](https://example.test/pull/7#issuecomment-1) by qodo was "
+        "updated up to the latest commit https://example.test/commit/abc",
+        "<!-- graphite-review-comment -->\n\n### Graphite AI review",
+        "<h3>PR Summary by Qodo</h3>\n\nBuild the default map per instance",
+        "\n<h3>Qodo is busy working</h3>\n\nCheck back in a few minutes.",
+        "\n<h3>Code Review by Qodo</h3>\n<code>\U0001f41e Bugs (0)</code>\n\n"
+        "<h3>Great, no issues found!</h3>\nQodo reviewed your code",
+    ],
+)
+def should_read_a_bot_notice_as_a_notice(body: str) -> None:
+    comment = model.parse_top_level_comment(notice_record(body, "Bot"))
+
+    assert comment.is_notice
+    assert model.top_level_findings((comment,), DRIVING_AGENT) == ()
+
+
+def should_read_a_person_pasting_notice_text_as_a_comment() -> None:
+    comment = model.parse_top_level_comment(
+        notice_record("No code changes since the last review", "User")
+    )
+
+    assert not comment.is_notice
+    assert len(model.top_level_findings((comment,), DRIVING_AGENT)) == 1
+
+
+def should_read_a_bot_finding_as_a_comment() -> None:
+    comment = model.parse_top_level_comment(
+        notice_record("A finding: the loop never ends.", "Bot")
+    )
+
+    assert not comment.is_notice
+
+
+def should_read_a_qodo_review_with_bugs_as_a_comment() -> None:
+    comment = model.parse_top_level_comment(
+        notice_record(
+            "\n<h3>Code Review by Qodo</h3>\n<code>\U0001f41e Bugs (2)</code>\n\n"
+            "1. The loop never ends.",
+            "Bot",
+        )
+    )
+
+    assert not comment.is_notice
+
+
+def notice_record(body: str, user_type: str) -> dict[str, object]:
+    return {
+        "id": 1,
+        "user": {"login": REVIEW_BOT, "type": user_type},
+        "body": body,
+        "created_at": "2026-09-26T12:05:00+00:00",
+        "updated_at": "2026-09-26T12:05:00+00:00",
+        "html_url": BOT_SUMMARY_URL,
+    }
+
+
 def should_count_waiting_top_level_comments_among_the_findings() -> None:
     all_findings = model.all_open_findings(
         (), (top_level_comment(REVIEW_BOT, 1),), DRIVING_AGENT, None