claude-dev-env 8.126.5 → 8.126.6
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -9,7 +9,7 @@ block to the agent's context::
|
|
|
9
9
|
|
|
10
10
|
=== OWNED PR REVIEW LOOP (context reminder, never a block) ===
|
|
11
11
|
You opened jl-cmd-projects/claude-dev-env#42 https://github.com/...
|
|
12
|
-
1. Review loop.
|
|
12
|
+
1. Review loop. In Claude Code, run /code-review ... In Codex, load efficient-review ...
|
|
13
13
|
2. Mark ready. ...
|
|
14
14
|
3. Babysit. Follow the pstack babysit playbook ...
|
|
15
15
|
4. Ship. Follow the pstack shipping playbook ...
|
|
@@ -293,7 +293,9 @@ def test_should_name_every_step_and_skill_in_the_context() -> None:
|
|
|
293
293
|
}
|
|
294
294
|
)
|
|
295
295
|
assert "jl-cmd-projects/claude-dev-env#42" in context
|
|
296
|
-
assert "
|
|
296
|
+
assert "In Claude Code, run /code-review high --max-findings all 42" in context
|
|
297
|
+
assert "in this session" in context
|
|
298
|
+
assert "In Codex, load the efficient-review skill" in context
|
|
297
299
|
assert "three full passes" in context
|
|
298
300
|
assert "/code-review low --fix 42" in context
|
|
299
301
|
assert "gh pr ready 42 --repo jl-cmd-projects/claude-dev-env" in context
|
|
@@ -321,7 +323,7 @@ def test_main_should_emit_the_loop_after_gh_pr_create_on_an_owned_repository() -
|
|
|
321
323
|
stdout = _run_hook(_shell_payload("gh pr create --fill", f"{OWNED_PR_URL}\n"))
|
|
322
324
|
payload = json.loads(stdout)
|
|
323
325
|
assert payload["hookSpecificOutput"]["hookEventName"] == "PostToolUse"
|
|
324
|
-
assert "
|
|
326
|
+
assert "/code-review high --max-findings all 42" in _context_of(stdout)
|
|
325
327
|
|
|
326
328
|
|
|
327
329
|
def test_main_should_emit_the_loop_after_a_gh_api_pulls_post() -> None:
|
|
@@ -333,7 +335,9 @@ def test_main_should_emit_the_loop_after_a_gh_api_pulls_post() -> None:
|
|
|
333
335
|
}
|
|
334
336
|
)
|
|
335
337
|
stdout = _run_hook(
|
|
336
|
-
_shell_payload(
|
|
338
|
+
_shell_payload(
|
|
339
|
+
"gh api repos/jl-cmd-projects/claude-dev-env/pulls --input pr.json", rest_response
|
|
340
|
+
)
|
|
337
341
|
)
|
|
338
342
|
assert "jl-cmd-projects/claude-dev-env#42" in _context_of(stdout)
|
|
339
343
|
|
|
@@ -411,7 +415,12 @@ def test_hooks_json_should_route_shell_and_mcp_create_calls_to_the_hook() -> Non
|
|
|
411
415
|
|
|
412
416
|
def test_should_leave_a_held_pull_request_with_the_user() -> None:
|
|
413
417
|
context = owned_pr_review_loop.build_review_loop_context(
|
|
414
|
-
{
|
|
418
|
+
{
|
|
419
|
+
"owner": "jl-cmd-projects",
|
|
420
|
+
"repository": "claude-dev-env",
|
|
421
|
+
"number": "42",
|
|
422
|
+
"url": OWNED_PR_URL,
|
|
423
|
+
}
|
|
415
424
|
)
|
|
416
425
|
assert "When the user asked to hold this PR or to read it before it merges" in context
|
|
417
426
|
assert "Blocked: jl-cmd-projects/claude-dev-env#42 - the user holds the merge." in context
|
|
@@ -15,7 +15,7 @@ This family rewrites a Git Bash command when path conversion would change a revi
|
|
|
15
15
|
- `blocking/bash_post_call_dispatcher.py` runs hosted observers and joins their context output without blocking the call.
|
|
16
16
|
- When a hosted hook exits 2, both dispatchers exit 2. Its stderr reaches the host as written. Before a call, exit 2 blocks the call. After a call, exit 2 shows that stderr to Claude.
|
|
17
17
|
- `advisory/pr_done_reminder.py` adds a pull request checklist after a successful push or pull request creation.
|
|
18
|
-
- `advisory/owned_pr_review_loop.py` adds review-loop instructions after the agent opens a pull request on an owned repository outside the preset list of repositories that run their own automated review: run efficient-review until clean, mark the pull request ready, babysit it, and ship it to merge. It also records the pull request for the session in `owned_pr_session_record.py`.
|
|
18
|
+
- `advisory/owned_pr_review_loop.py` adds review-loop instructions after the agent opens a pull request on an owned repository outside the preset list of repositories that run their own automated review: run `/code-review` in a Claude Code session, or efficient-review in Codex, until clean, mark the pull request ready, babysit it, and ship it to merge. It also records the pull request for the session in `owned_pr_session_record.py`.
|
|
19
19
|
|
|
20
20
|
## When it fires
|
|
21
21
|
|
|
@@ -20,6 +20,8 @@ from __future__ import annotations
|
|
|
20
20
|
|
|
21
21
|
import re
|
|
22
22
|
|
|
23
|
+
from hooks_constants.merge_review_gate_constants import DEFAULT_REVIEW_COMMAND
|
|
24
|
+
|
|
23
25
|
__all__ = [
|
|
24
26
|
"NAME_DIGEST_TEXT_ENCODING",
|
|
25
27
|
"ALL_OWNED_OWNER_DIGESTS",
|
|
@@ -124,8 +126,9 @@ REVIEW_LOOP_CONTEXT_TEMPLATE: str = (
|
|
|
124
126
|
"This repository has no automated review, so you own the review and the merge.\n"
|
|
125
127
|
"Your task now runs past opening this PR to its merge, also when your brief\n"
|
|
126
128
|
"asked for a draft or stopped at opening it.\n"
|
|
127
|
-
"1. Review loop.
|
|
128
|
-
"
|
|
129
|
+
f"1. Review loop. In Claude Code, run {DEFAULT_REVIEW_COMMAND} {{number}}\n"
|
|
130
|
+
" in this session. In Codex, load the efficient-review skill (/efficient-review).\n"
|
|
131
|
+
" Check each finding against the code, fix every one that holds, push,\n"
|
|
129
132
|
" and review again. After three full passes, each later pass is\n"
|
|
130
133
|
" /code-review low --fix {number}; commit and push its fixes, then review the new head.\n"
|
|
131
134
|
" Repeat until a pass reports no findings.\n"
|