claude-dev-env 8.106.3 → 8.106.4

package/docs/CODE_RULES.md

@@ -62,7 +62,7 @@ Open [details](code-rules/design-and-structure.md) when adding a class or parame
 
 ## 7.5 SOLID PRINCIPLES
 
-Apply SRP throughout. Apply OCP, LSP, ISP, and DIP when two concrete implementations share a contract. Keep cohesive classes together.
+Keep a function whole while it reads top to bottom. Split it when the new piece has a second caller or makes the caller easier to read, or when it reaches the 60-line cap the lint and the write-time hook enforce. Apply OCP, LSP, ISP, and DIP when two concrete implementations share a contract. Keep cohesive classes together.
 
 Open [details](code-rules/design-and-structure.md) when extracting a responsibility.
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.106.3",
+    "version": "8.106.4",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/scripts/policy_lint/config/check_catalog_constants.py

@@ -61,6 +61,9 @@ ALL_CHECK_CATALOG_ENTRIES: tuple[CheckCatalogEntry, ...] = (
         "paired-test-missing-function",
     ),
     CheckCatalogEntry("but exercises nowhere", "paired-test-omitted-function"),
+    CheckCatalogEntry(") - consider splitting", "file-length"),
+    CheckCatalogEntry(" lines (max ", "function-line-cap"),
+    CheckCatalogEntry(" has nesting depth ", "nesting-depth"),
 )
 
 SEVERITY_BREAKING: str = "breaking"
@@ -68,5 +71,8 @@ SEVERITY_SMELL: str = "smell"
 SEVERITY_BY_CHECK_ID: dict[str, str] = {
     "code-rules/paired-test-missing-function": SEVERITY_SMELL,
     "code-rules/paired-test-omitted-function": SEVERITY_SMELL,
+    "validators/file-length": SEVERITY_SMELL,
+    "validators/function-line-cap": SEVERITY_SMELL,
+    "validators/nesting-depth": SEVERITY_SMELL,
     "test-pairing": SEVERITY_SMELL,
 }

package/scripts/tests/test_policy_lint_rules_check_catalog.py

@@ -18,6 +18,7 @@ from policy_lint.config.check_catalog_constants import (
 from policy_lint.model import Diagnostic, Severity
 
 _BUNDLING_RULE_ID = "code-rules"
+_VALIDATORS_RULE_ID = "validators"
 _HOOKS_DIRECTORY = Path(__file__).resolve().parents[2] / "hooks"
 _TEST_FILE_PREFIX = "test_"
 _PYTHON_GLOB = "*.py"
@@ -82,6 +83,9 @@ ALL_MESSAGE_SAMPLES: tuple[tuple[str, str], ...] = (
         " already covers another public function in that module",
         "paired-test-omitted-function",
     ),
+    ("src/app.py:1: File is 412 lines (max 400) - consider splitting", "file-length"),
+    ("src/app.py:4: Function 'run' is 37 lines (max 30)", "function-line-cap"),
+    ("src/app.py:9: Function 'run' has nesting depth 3 (max 2)", "nesting-depth"),
 )
 
 
@@ -169,6 +173,23 @@ def test_a_paired_test_check_reports_as_a_warning(check_name: str) -> None:
     assert severity_for_check_id(f"{_BUNDLING_RULE_ID}/{check_name}") is Severity.WARNING
 
 
+@pytest.mark.parametrize(
+    ("sample_message", "check_name"),
+    tuple(
+        each_sample
+        for each_sample in ALL_MESSAGE_SAMPLES
+        if each_sample[1] in ("file-length", "function-line-cap", "nesting-depth")
+    ),
+)
+def test_a_validator_smell_reports_as_a_warning(
+    sample_message: str, check_name: str
+) -> None:
+    check_id = check_id_for_message(_VALIDATORS_RULE_ID, sample_message)
+
+    assert check_id == f"{_VALIDATORS_RULE_ID}/{check_name}"
+    assert severity_for_check_id(check_id) is Severity.WARNING
+
+
 def test_an_unclassified_check_reports_as_an_error() -> None:
     unclassified_check_id = f"{_BUNDLING_RULE_ID}/{UNCLASSIFIED_CHECK_NAME}"