claude-dev-env 7.0.0 → 7.2.0

package/hooks/git-hooks/test_installed_policy_lint.py

@@ -10,8 +10,7 @@ import sys
 from pathlib import Path
 
 import pytest
-from test_pre_commit import ALL_RULE_FIXTURES, _git, _stage
-from test_pre_commit import repository_root as repository_root
+from test_native_hook_support import run_git
 
 ALL_RETIRED_HOOK_PATHS = (
     "blocking/code_rules_enforcer.py",
@@ -21,8 +20,53 @@ ALL_RETIRED_HOOK_PATHS = (
     "blocking/subprocess_budget_completeness.py",
     "blocking/hook_prose_detector_consistency.py",
     "blocking/workflow_substitution_slot_blocker.py",
+    "validation/hook_format_validator.py",
+    "blocking/open_questions_in_plans_blocker.py",
+    "blocking/docstring_rule_gate_count_blocker.py",
+    "blocking/plain_language_blocker.py",
+    "lifecycle/config_change_guard.py",
 )
 PACKAGE_ROOT = Path(__file__).resolve().parents[2]
+ALL_RULE_FIXTURES = (
+    ("code-rules", "src/worker.py", "from typing import Any\n\ndef worker() -> Any:\n    return None\n"),
+    ("test-pairing", "src/feature.py", "def work() -> None:\n    pass\n"),
+    ("state-description", "docs/config.md", "# Config\n\nPreviously set via env var.\n"),
+    ("subprocess-budget", "src/timing.py", "import subprocess\nPYTHON_FORMAT_TIMEOUT_SECONDS = 12\nGIT_CHECK_TIMEOUT_SECONDS = 5\ndef worst_case_python_format_seconds() -> int:\n    fix_phase_seconds = PYTHON_FORMAT_TIMEOUT_SECONDS\n    format_phase_seconds = PYTHON_FORMAT_TIMEOUT_SECONDS\n    return fix_phase_seconds + format_phase_seconds\ndef is_untracked_in_git(file_path: str) -> bool:\n    git_check = subprocess.run(['git', 'ls-files', file_path], timeout=GIT_CHECK_TIMEOUT_SECONDS)\n    return git_check.returncode != 0\ndef run_format(file_path: str) -> None:\n    subprocess.run(['ruff', 'format', file_path], timeout=PYTHON_FORMAT_TIMEOUT_SECONDS)\ndef main(file_path: str) -> None:\n    if is_untracked_in_git(file_path):\n        return\n    run_format(file_path)\n"),
+    ("hook-prose-consistency", "hooks/hooks_constants/probe_constants.py", 'CORRECTIVE_MESSAGE = "appears as a path or output-key segment"\n'),
+    ("workflow-substitution", "scripts/sample.workflow.js", "For EACH candidate i, build a bible dir cand_i per the contract.\n   & ${PY} compose.py --out ${args.work_dir}\\\\cand_i\\\\sample.png --glow <candidate glow_hex>\nReturn: {key: \"cand_i\", name, sample_png}\n"),
+)
+
+
+def _git(repository_path: Path, *arguments: str) -> str:
+    return run_git(repository_path, *arguments).stdout.strip()
+
+
+def _stage(repository_path: Path, relative_path: str, content: str) -> Path:
+    file_path = repository_path / relative_path
+    file_path.parent.mkdir(parents=True, exist_ok=True)
+    file_path.write_text(content, encoding="utf-8")
+    _git(repository_path, "add", "--", relative_path)
+    return file_path
+
+
+@pytest.fixture()
+def repository_root(tmp_path_factory: pytest.TempPathFactory, monkeypatch: pytest.MonkeyPatch) -> Path:
+    temporary_root = tmp_path_factory.mktemp("policy-fixture")
+    home_directory = temporary_root / "home"
+    home_directory.mkdir()
+    monkeypatch.setenv("HOME", str(home_directory))
+    monkeypatch.setenv("USERPROFILE", str(home_directory))
+    monkeypatch.setenv("GIT_CONFIG_GLOBAL", os.devnull)
+    monkeypatch.setenv("GIT_CONFIG_NOSYSTEM", "1")
+    repository_path = temporary_root / "repository"
+    repository_path.mkdir()
+    _git(repository_path, "init")
+    _git(repository_path, "config", "core.hooksPath", str(temporary_root / "disabled-fixture-hooks"))
+    _git(repository_path, "config", "user.name", "Fixture")
+    _git(repository_path, "config", "user.email", "fixture@example.com")
+    _git(repository_path, "commit", "--allow-empty", "-m", "fixture base")
+    monkeypatch.chdir(repository_path)
+    return repository_path
 
 
 def _legacy_settings_bytes(managed_root: Path, foreign_command: str) -> bytes:
@@ -115,7 +159,7 @@ def managed_installation(tmp_path_factory: pytest.TempPathFactory) -> Path:
 
 
 @pytest.mark.parametrize(("rule_id", "relative_path", "content"), ALL_RULE_FIXTURES)
-def test_installed_native_commit_catches_each_retired_file_rule(
+def test_installed_linter_reports_each_retired_file_rule_before_soft_commit(
     managed_installation: Path,
     repository_root: Path,
     monkeypatch: pytest.MonkeyPatch,
@@ -128,13 +172,18 @@ def test_installed_native_commit_catches_each_retired_file_rule(
     monkeypatch.setenv("CODE_RULES_GATE_PATH", str(repository_root / "missing-old-gate.py"))
     before = _git(repository_root, "rev-parse", "HEAD")
     _stage(repository_root, relative_path, content)
+    lint_completed = subprocess.run(
+        [sys.executable, str(managed_installation / "scripts/cde_lint.py"), "--staged", "--format", "json"],
+        cwd=repository_root, capture_output=True, text=True, check=False, timeout=240,
+    )
+    assert lint_completed.returncode != 0
+    assert rule_id in lint_completed.stdout + lint_completed.stderr
     completed = subprocess.run(
         ["git", "commit", "-m", "invalid fixture"],
         cwd=repository_root, capture_output=True, text=True, check=False, timeout=240,
     )
-    assert completed.returncode != 0
-    assert rule_id in completed.stdout + completed.stderr
-    assert _git(repository_root, "rev-parse", "HEAD") == before
+    assert completed.returncode == 0
+    assert _git(repository_root, "rev-parse", "HEAD") != before
 
 
 def test_installed_linter_and_native_commit_allow_valid_changes(

package/hooks/git-hooks/test_native_hook_support.py

@@ -0,0 +1,129 @@
+from __future__ import annotations
+
+import subprocess
+import sys
+from pathlib import Path
+
+
+def run_git(
+    repository_path: Path,
+    *arguments: str,
+) -> subprocess.CompletedProcess[str]:
+    return subprocess.run(
+        ["git", *arguments],
+        cwd=repository_path,
+        check=True,
+        capture_output=True,
+        text=True,
+        encoding="utf-8",
+    )
+
+
+def run_native_git_action(
+    repository_path: Path,
+    *arguments: str,
+) -> subprocess.CompletedProcess[str]:
+    return subprocess.run(
+        ["git", *arguments],
+        cwd=repository_path,
+        check=False,
+        capture_output=True,
+        text=True,
+        encoding="utf-8",
+    )
+
+
+def run_native_hook(
+    repository_path: Path,
+    hook_script_name: str,
+) -> subprocess.CompletedProcess[str]:
+    hook_script_path = Path(__file__).resolve().parent / hook_script_name
+    return subprocess.run(
+        [sys.executable, str(hook_script_path)],
+        cwd=repository_path,
+        check=False,
+        capture_output=True,
+        text=True,
+        encoding="utf-8",
+    )
+
+
+def read_git_head(repository_path: Path, reference_name: str) -> str:
+    return run_git(repository_path, "rev-parse", reference_name).stdout.strip()
+
+
+def create_bare_repository(temporary_directory: Path) -> Path:
+    bare_repository_path = temporary_directory / "remote.git"
+    subprocess.run(
+        ["git", "init", "--bare", "--quiet", str(bare_repository_path)],
+        cwd=temporary_directory,
+        check=True,
+        capture_output=True,
+        text=True,
+        encoding="utf-8",
+    )
+    return bare_repository_path
+
+
+def configure_remote_url_rewrite(
+    repository_path: Path,
+    bare_repository_path: Path,
+    remote_url: str,
+) -> None:
+    run_git(
+        repository_path,
+        "config",
+        f"url.{bare_repository_path.as_uri()}.insteadOf",
+        remote_url,
+    )
+
+
+def configure_native_repository(repository_path: Path, remote_url: str) -> None:
+    run_git(repository_path, "init", "--quiet")
+    run_git(repository_path, "config", "user.email", "test@example.invalid")
+    run_git(repository_path, "config", "user.name", "Verification Test")
+    run_git(repository_path, "remote", "add", "origin", remote_url)
+    (repository_path / "README.md").write_text("check\n", encoding="utf-8")
+
+
+def create_native_repository(
+    temporary_directory: Path,
+    repository_name: str,
+    remote_url: str,
+    initial_branch: str | None = None,
+) -> Path:
+    repository_path = temporary_directory / repository_name
+    repository_path.mkdir()
+    all_init_arguments = ["init", "--quiet"]
+    if initial_branch:
+        all_init_arguments.insert(1, f"--initial-branch={initial_branch}")
+    run_git(repository_path, *all_init_arguments)
+    run_git(repository_path, "config", "user.email", "test@example.invalid")
+    run_git(repository_path, "config", "user.name", "Verification Test")
+    run_git(repository_path, "remote", "add", "origin", remote_url)
+    (repository_path / "README.md").write_text("check\n", encoding="utf-8")
+    return repository_path
+
+
+def install_native_hook(
+    repository_path: Path,
+    hook_directory: Path,
+    hook_name: str,
+    module_name: str,
+) -> None:
+    source_directory = Path(__file__).resolve().parent
+    hook_directory.mkdir()
+    shim_text = (
+        "#!/usr/bin/env python3\n"
+        "import sys\n"
+        "from pathlib import Path\n"
+        f"hook_source_directory = Path({str(source_directory)!r})\n"
+        "if str(hook_source_directory) not in sys.path:\n"
+        "    sys.path.insert(0, str(hook_source_directory))\n"
+        f"import {module_name}\n"
+        f"sys.exit({module_name}.main())\n"
+    )
+    hook_path = hook_directory / hook_name
+    hook_path.write_text(shim_text, encoding="utf-8")
+    hook_path.chmod(0o755)
+    run_git(repository_path, "config", "core.hooksPath", str(hook_directory))

package/hooks/git-hooks/test_native_policy_commit.py

@@ -10,8 +10,31 @@ from pathlib import Path
 
 import pre_commit
 import pytest
-from test_pre_commit import _git, _stage
-from test_pre_commit import repository_root as repository_root
+from test_native_hook_support import run_git
+
+
+def _git(repository_path: Path, *arguments: str) -> str:
+    return run_git(repository_path, *arguments).stdout.strip()
+
+
+def _stage(repository_path: Path, relative_path: str, content: str) -> Path:
+    file_path = repository_path / relative_path
+    file_path.parent.mkdir(parents=True, exist_ok=True)
+    file_path.write_text(content, encoding="utf-8")
+    _git(repository_path, "add", "--", relative_path)
+    return file_path
+
+
+@pytest.fixture()
+def repository_root(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> Path:
+    repository_path = tmp_path / "repository"
+    repository_path.mkdir()
+    _git(repository_path, "init")
+    _git(repository_path, "config", "user.name", "Fixture")
+    _git(repository_path, "config", "user.email", "fixture@example.com")
+    _git(repository_path, "commit", "--allow-empty", "-m", "fixture base")
+    monkeypatch.chdir(repository_path)
+    return repository_path
 
 
 @pytest.fixture()
@@ -66,7 +89,7 @@ def _assert_write_proceeds(repository_root: Path, relative_path: str, content: s
     assert edit_output.get("hookSpecificOutput", {}).get("permissionDecision") != "deny"
 
 
-def test_retired_write_check_allows_edit_but_local_commit_catches_violation(
+def test_retired_write_check_allows_edit_but_explicit_lint_reports_violation(
     installed_native_hook: Path,
 ) -> None:
     relative_path = "docs/config.md"
@@ -74,6 +97,17 @@ def test_retired_write_check_allows_edit_but_local_commit_catches_violation(
     _assert_write_proceeds(installed_native_hook, relative_path, content)
     before = _git(installed_native_hook, "rev-parse", "HEAD")
     _stage(installed_native_hook, relative_path, content)
+    package_root = Path(pre_commit.__file__).resolve().parents[2]
+    lint_result = subprocess.run(
+        [sys.executable, str(package_root / "scripts/cde_lint.py"), "--staged", "--format", "json"],
+        cwd=installed_native_hook,
+        capture_output=True,
+        text=True,
+        check=False,
+        timeout=240,
+    )
+    assert lint_result.returncode != 0
+    assert "state-description" in lint_result.stdout + lint_result.stderr
     commit_result = subprocess.run(
         ["git", "commit", "-m", "invalid fixture"],
         cwd=installed_native_hook,
@@ -82,6 +116,5 @@ def test_retired_write_check_allows_edit_but_local_commit_catches_violation(
         check=False,
         timeout=240,
     )
-    assert commit_result.returncode != 0
-    assert "state-description" in commit_result.stdout + commit_result.stderr
-    assert _git(installed_native_hook, "rev-parse", "HEAD") == before
+    assert commit_result.returncode == 0
+    assert _git(installed_native_hook, "rev-parse", "HEAD") != before

package/hooks/git-hooks/test_post_commit.py

@@ -0,0 +1,43 @@
+from __future__ import annotations
+
+from pathlib import Path
+
+import post_commit
+import pytest
+from test_native_hook_support import (
+    create_native_repository,
+    install_native_hook,
+    read_git_head,
+    run_git,
+    run_native_git_action,
+)
+
+
+def test_main_always_returns_zero_when_notice_reports_failure(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    monkeypatch.setattr(post_commit, "verification_notice_main", lambda *args, **kwargs: 1)
+
+    exit_code = post_commit.main()
+
+    assert exit_code == 0
+
+
+def test_native_git_commit_notice_reports_the_new_head(tmp_path: Path) -> None:
+    repository_path = create_native_repository(
+        tmp_path,
+        "repo",
+        "https://github.com/JonEcho/python-automation.git",
+    )
+    hook_directory = tmp_path / "hooks"
+    install_native_hook(repository_path, hook_directory, "post-commit", "post_commit")
+    run_git(repository_path, "add", "README.md")
+
+    completed_commit = run_native_git_action(repository_path, "commit", "-m", "initial")
+
+    current_head = read_git_head(repository_path, "HEAD")
+    combined_output = completed_commit.stdout + completed_commit.stderr
+    assert completed_commit.returncode == 0
+    assert "Event: commit" in combined_output
+    assert f"Current SHA: {current_head}" in combined_output
+    assert "State: pending" in combined_output