claude-dev-env 4.3.0 → 7.0.0

package/scripts/tests/test_policy_lint_rules_installed_loader.py

@@ -0,0 +1,29 @@
+"""Load terminology through the verified installed shared-tree resolver."""
+
+from __future__ import annotations
+
+import sys
+from pathlib import Path
+
+import pytest
+from policy_lint import adapters
+
+
+def test_pr_loop_loader_uses_the_shared_tree_resolver(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    module_name = "policy_fixture_terminology"
+    (tmp_path / f"{module_name}.py").write_text("IS_FIXTURE = True\n", encoding="utf-8")
+    all_calls: list[tuple[object, ...]] = []
+
+    def resolve_directory(*all_arguments: object) -> Path:
+        all_calls.append(all_arguments)
+        return tmp_path
+
+    monkeypatch.setattr(adapters, "resolve_shared_scripts_directory", resolve_directory)
+    monkeypatch.setattr(sys, "path", list(sys.path))
+    loaded = adapters._pr_loop_script_module(module_name)
+    assert loaded.IS_FIXTURE is True
+    assert Path(loaded.__file__).parent == tmp_path
+    assert all_calls[0][2:] == ("pr-loop", f"{module_name}.py", 2)
+    monkeypatch.delitem(sys.modules, module_name)

package/scripts/tests/test_policy_lint_rules_registry.py

@@ -15,6 +15,7 @@ from policy_lint.model import (
     Document,
     DocumentRule,
     DocumentSet,
+    LintReport,
     LintRequest,
     SelectionKind,
 )
@@ -96,6 +97,164 @@ def _terminology_rule() -> ChangeSetRule:
     return terminology_rule
 
 
+def _head_revision(repository_root: Path) -> str:
+    completed = subprocess.run(
+        ("git", "rev-parse", "HEAD"),
+        cwd=repository_root,
+        check=True,
+        capture_output=True,
+        text=True,
+    )
+    return completed.stdout.strip()
+
+
+def _git_add(repository_root: Path, *all_paths: str) -> None:
+    subprocess.run(
+        ("git", "add", *all_paths),
+        cwd=repository_root,
+        check=True,
+        capture_output=True,
+    )
+
+
+def _quota_document_paths(
+    repository_root: Path,
+    source_name: str = "quota.py",
+    documentation_name: str = "README.md",
+) -> tuple[Path, Path]:
+    source_path = repository_root / "src" / source_name
+    documentation_path = repository_root / "docs" / documentation_name
+    source_path.parent.mkdir(parents=True, exist_ok=True)
+    documentation_path.parent.mkdir(parents=True, exist_ok=True)
+    return source_path, documentation_path
+
+
+def _write_text(file_path: Path, text: str) -> None:
+    file_path.write_text(text, encoding="utf-8")
+
+
+def _commit_quota_base(
+    repository_root: Path,
+    source_text: str,
+    documentation_text: str,
+    source_name: str = "quota.py",
+    documentation_name: str = "README.md",
+) -> tuple[Path, Path, str]:
+    _ensure_git_repository(repository_root)
+    source_path, documentation_path = _quota_document_paths(
+        repository_root, source_name, documentation_name
+    )
+    _write_text(source_path, source_text)
+    _write_text(documentation_path, documentation_text)
+    _commit_repository(repository_root, "base")
+    return source_path, documentation_path, _head_revision(repository_root)
+
+
+def _commit_identifier_then_documentation(
+    repository_root: Path,
+    source_path: Path,
+    documentation_path: Path,
+) -> None:
+    _write_text(source_path, "baseline = 1\npremium_request_interactions = 5\n")
+    _commit_repository(repository_root, "identifier")
+    _write_text(
+        documentation_path,
+        "The premium-request-budget field gates the run.\n",
+    )
+    _commit_repository(repository_root, "documentation")
+
+
+def _committed_near_miss_from_base(
+    repository_root: Path,
+) -> tuple[Path, Path, str]:
+    source_path, documentation_path, comparison_revision = _commit_quota_base(
+        repository_root,
+        "baseline = 1\n",
+        "Baseline quota text.\n",
+    )
+    _commit_identifier_then_documentation(
+        repository_root, source_path, documentation_path
+    )
+    return source_path, documentation_path, comparison_revision
+
+
+def _stage_unrelated_index_file(repository_root: Path) -> None:
+    _write_text(repository_root / "staged.txt", "unrelated index content\n")
+    _git_add(repository_root, "--", "staged.txt")
+
+
+def _worktree_and_index_near_miss_repository(repository_root: Path) -> str:
+    source_path, documentation_path, comparison_revision = (
+        _committed_near_miss_from_base(repository_root)
+    )
+    _write_text(
+        source_path,
+        "baseline = 1\npremium_request_interactions = 5\nanother_request_total = 2\n",
+    )
+    _write_text(
+        documentation_path,
+        "The another-request-budget field gates the run.\n",
+    )
+    _git_add(repository_root, "-A")
+    _write_text(
+        documentation_path,
+        "The another-request-total field gates the run.\n",
+    )
+    return comparison_revision
+
+
+def _existing_identifier_from_base(repository_root: Path) -> str:
+    source_path, documentation_path, comparison_revision = _commit_quota_base(
+        repository_root,
+        "premium_request_interactions = 5\n",
+        "Baseline quota text.\n",
+    )
+    _write_text(
+        source_path,
+        "premium_request_interactions = 5\npremium_request_interactions = 6\n",
+    )
+    _write_text(
+        documentation_path,
+        "The premium-request-budget field gates the run.\n",
+    )
+    _commit_repository(repository_root, "existing identifier")
+    return comparison_revision
+
+
+def _renamed_and_deleted_near_miss_from_base(repository_root: Path) -> str:
+    old_source_path, deleted_documentation_path, comparison_revision = (
+        _commit_quota_base(
+            repository_root,
+            "baseline = 1\n",
+            "Obsolete quota text.\n",
+            "old_quota.py",
+            "obsolete.md",
+        )
+    )
+    new_source_path = repository_root / "src" / "new_quota.py"
+    subprocess.run(
+        ("git", "mv", "--", str(old_source_path), str(new_source_path)),
+        cwd=repository_root,
+        check=True,
+        capture_output=True,
+    )
+    _write_text(new_source_path, "baseline = 1\npremium_request_interactions = 5\n")
+    deleted_documentation_path.unlink()
+    _write_text(
+        repository_root / "docs" / "README.md",
+        "The premium-request-budget field gates the run.\n",
+    )
+    _commit_repository(repository_root, "rename and delete")
+    return comparison_revision
+
+
+def _lint_base(repository_root: Path, comparison_revision: str) -> LintReport:
+    return lint(
+        LintRequest.base(repository_root, comparison_revision),
+        all_registry=(_terminology_rule(),),
+    )
+
+
 def test_hook_format_accepts_claude_settings() -> None:
     settings_document = Document.from_text(".claude/settings.json", "{}")
     hooks_document = Document.from_text("hooks/hooks.json", "{}")
@@ -161,7 +320,7 @@ def test_test_pairing_diagnostics_exempts_constants_only_python_modules(
         (
             Document.from_text(
                 "hooks_constants/tool_names.py",
-                "TOOL_NAME: str = \"tool\"\n",
+                'TOOL_NAME: str = "tool"\n',
             ),
         ),
         SelectionKind.STAGED,
@@ -244,9 +403,7 @@ def test_hook_configuration_diagnostics_rejects_registered_action_boundary_path(
         json.dumps(
             {
                 "hooks": {
-                    "PreToolUse": [
-                        {"hooks": [{"command": "hooks/blocking/deny.py"}]}
-                    ]
+                    "PreToolUse": [{"hooks": [{"command": "hooks/blocking/deny.py"}]}]
                 }
             }
         ),
@@ -263,7 +420,9 @@ def test_hook_configuration_diagnostics_ignore_description_text(tmp_path: Path)
         "hooks/hooks.json",
         json.dumps({"description": "blocking safety controls", "hooks": {}}),
     )
-    assert adapters.hook_configuration_diagnostics(configuration_document, tmp_path) == ()
+    assert (
+        adapters.hook_configuration_diagnostics(configuration_document, tmp_path) == ()
+    )
 
 
 def test_hook_configuration_diagnostics_ignore_task_path(tmp_path: Path) -> None:
@@ -271,7 +430,9 @@ def test_hook_configuration_diagnostics_ignore_task_path(tmp_path: Path) -> None
         "hooks/hooks.json",
         json.dumps({"hooks": {"PostToolUse": [{"command": "task_runner.py"}]}}),
     )
-    assert adapters.hook_configuration_diagnostics(configuration_document, tmp_path) == ()
+    assert (
+        adapters.hook_configuration_diagnostics(configuration_document, tmp_path) == ()
+    )
 
 
 def test_registry_omits_native_ruff_mypy_javascript_adapters() -> None:
@@ -291,7 +452,9 @@ def test_registry_registers_unique_python_validator_rule() -> None:
 def test_registry_registers_terminology_change_set_rule() -> None:
     terminology_rule = _terminology_rule()
     assert terminology_rule.rule_sets == _CHANGED_RULE_SETS
-    assert terminology_rule.selections == frozenset({SelectionKind.STAGED})
+    assert terminology_rule.selections == frozenset(
+        {SelectionKind.STAGED, SelectionKind.BASE}
+    )
 
 
 def test_registry_runs_test_pairing_for_staged_and_base_changes() -> None:
@@ -313,10 +476,11 @@ def test_terminology_rule_reports_cross_surface_path_and_line(
         tmp_path,
         "baseline = 1\n",
         "premium_request_interactions = 5\n",
-        "Quota fields use one name.\n"
-        "The premium-request-budget field gates the run.\n",
+        "Quota fields use one name.\nThe premium-request-budget field gates the run.\n",
+    )
+    lint_report = lint(
+        LintRequest.staged(tmp_path), all_registry=(_terminology_rule(),)
     )
-    lint_report = lint(LintRequest.staged(tmp_path), all_registry=(_terminology_rule(),))
 
     assert len(lint_report.diagnostics) == 1
     diagnostic = lint_report.diagnostics[0]
@@ -332,15 +496,65 @@ def test_terminology_rule_suppresses_identifier_present_in_prior_tree(
     _stage_terminology_change(
         tmp_path,
         "premium_request_interactions = 5\n",
-        "premium_request_interactions = 5\n"
-        "premium_request_interactions = 6\n",
+        "premium_request_interactions = 5\npremium_request_interactions = 6\n",
         "The premium-request-budget field gates the run.\n",
     )
-    lint_report = lint(LintRequest.staged(tmp_path), all_registry=(_terminology_rule(),))
+    lint_report = lint(
+        LintRequest.staged(tmp_path), all_registry=(_terminology_rule(),)
+    )
+
+    assert lint_report.diagnostics == ()
+
+
+def test_terminology_rule_reports_committed_changes_from_base(
+    tmp_path: Path,
+) -> None:
+    _, _, comparison_revision = _committed_near_miss_from_base(tmp_path)
+    _stage_unrelated_index_file(tmp_path)
+    lint_report = _lint_base(tmp_path, comparison_revision)
+    assert lint_report.failed_rules == ()
+    assert len(lint_report.diagnostics) == 1
+    assert lint_report.diagnostics[0].location is not None
+    assert lint_report.diagnostics[0].location.path == PurePosixPath("docs/README.md")
+
+
+def test_terminology_base_uses_worktree_while_staged_uses_index(
+    tmp_path: Path,
+) -> None:
+    comparison_revision = _worktree_and_index_near_miss_repository(tmp_path)
+    base_report = _lint_base(tmp_path, comparison_revision)
+    staged_report = lint(
+        LintRequest.staged(tmp_path),
+        all_registry=(_terminology_rule(),),
+    )
+    assert base_report.failed_rules == ()
+    assert staged_report.failed_rules == ()
+    assert base_report.diagnostics == ()
+    assert len(staged_report.diagnostics) == 1
+    assert staged_report.diagnostics[0].location is not None
+    assert staged_report.diagnostics[0].location.path == PurePosixPath("docs/README.md")
 
+
+def test_terminology_base_suppresses_identifier_present_in_comparison_base(
+    tmp_path: Path,
+) -> None:
+    comparison_revision = _existing_identifier_from_base(tmp_path)
+    lint_report = _lint_base(tmp_path, comparison_revision)
+    assert lint_report.failed_rules == ()
     assert lint_report.diagnostics == ()
 
 
+def test_terminology_base_handles_renames_and_deletions(
+    tmp_path: Path,
+) -> None:
+    comparison_revision = _renamed_and_deleted_near_miss_from_base(tmp_path)
+    lint_report = _lint_base(tmp_path, comparison_revision)
+    assert lint_report.failed_rules == ()
+    assert len(lint_report.diagnostics) == 1
+    assert lint_report.diagnostics[0].location is not None
+    assert lint_report.diagnostics[0].location.path == PurePosixPath("docs/README.md")
+
+
 def test_terminology_rule_skips_file_selection(tmp_path: Path) -> None:
     document_set = DocumentSet(
         (Document.from_text("docs/README.md", "text\n"),),

package/scripts/tests/test_policy_lint_selection.py

@@ -28,7 +28,7 @@ def _git_environment() -> dict[str, str]:
     }
 
 
-def _run_git(repository_root: Path, *all_arguments: str) -> None:
+def _git_stdout(repository_root: Path, *all_arguments: str) -> str:
     completed = subprocess.run(
         [constants.GIT_EXECUTABLE, *all_arguments],
         cwd=repository_root,
@@ -38,6 +38,11 @@ def _run_git(repository_root: Path, *all_arguments: str) -> None:
         env=_git_environment(),
     )
     assert completed.returncode == 0, completed.stderr
+    return completed.stdout.strip()
+
+
+def _run_git(repository_root: Path, *all_arguments: str) -> None:
+    _git_stdout(repository_root, *all_arguments)
 
 
 def _initialize_repository(repository_root: Path) -> Path:
@@ -200,7 +205,9 @@ def test_staged_missing_non_delete_blob_should_raise(
 def test_git_blob_unexpected_failure_should_raise(
     tmp_path: Path, monkeypatch: pytest.MonkeyPatch
 ) -> None:
-    def failed_git(*_all_arguments: object, **_all_keywords: object) -> subprocess.CompletedProcess[bytes]:
+    def failed_git(
+        *_all_arguments: object, **_all_keywords: object
+    ) -> subprocess.CompletedProcess[bytes]:
         return subprocess.CompletedProcess(
             args=[constants.GIT_EXECUTABLE],
             returncode=1,
@@ -254,6 +261,22 @@ def test_base_source_should_compare_merge_base_and_read_worktree_bytes(
     assert selected_document.origin == ContentOrigin.REVISION_DIFF
 
 
+def test_base_selection_records_merge_base_revision_and_staged_does_not(
+    tmp_path: Path,
+) -> None:
+    repository_root = _initialize_repository(tmp_path)
+    _commit_text(repository_root, "file.py", "base-text\n")
+    _run_git(repository_root, "checkout", "--quiet", "-b", "feature")
+    _commit_text(repository_root, "file.py", "feature-committed\n")
+
+    merge_base = _git_stdout(repository_root, "merge-base", "main", "HEAD")
+    base_document_set = select_documents(LintRequest.base(repository_root, "main"))
+    staged_document_set = select_documents(LintRequest.staged(repository_root))
+
+    assert base_document_set.base_revision == merge_base
+    assert staged_document_set.base_revision is None
+
+
 def test_repository_source_should_read_tracked_worktree_files_only(
     tmp_path: Path,
 ) -> None:

package/scripts/tests/test_policy_lint_selection_native_index.py

@@ -0,0 +1,30 @@
+"""Preserve Git's active index without accepting repository-directory overrides."""
+
+from __future__ import annotations
+
+from pathlib import Path
+
+import pytest
+from policy_lint import selection_git
+
+
+def test_active_git_index_survives_environment_sanitization(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    index_path = tmp_path / "index"
+    monkeypatch.setenv("GIT_INDEX_FILE", str(index_path))
+    monkeypatch.setenv("GIT_DIR", "foreign-repository")
+    monkeypatch.setenv("GIT_WORK_TREE", "foreign-worktree")
+    monkeypatch.setenv("PRESERVED_SETTING", "fixture")
+    active_environment = selection_git._git_subprocess_environment()
+    assert active_environment["GIT_INDEX_FILE"] == str(index_path)
+    assert "GIT_DIR" not in active_environment
+    assert "GIT_WORK_TREE" not in active_environment
+    assert active_environment["PRESERVED_SETTING"] == "fixture"
+
+
+def test_default_index_is_not_replaced_by_an_invented_path(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    monkeypatch.delenv("GIT_INDEX_FILE", raising=False)
+    assert "GIT_INDEX_FILE" not in selection_git._git_subprocess_environment()

package/scripts/tests/test_rules.py

@@ -96,7 +96,6 @@ def _comment_policy_surfaces(package_root: Path) -> tuple[Path, ...]:
         package_root / "system-prompts" / "software-engineer.xml",
         package_root / ".agents" / "agents" / "clean-coder.md",
         package_root / ".agents" / "agents" / "code-quality-agent.md",
-        package_root / "_shared" / "pr-loop" / "code-rules-gate.md",
         package_root / "audit-rubrics" / "category_rubrics" / "category-j-code-rules-compliance.md",
         package_root / "audit-rubrics" / "prompts" / "category-j-code-rules-compliance.md",
         package_root / "audit-rubrics" / "category_rubrics" / "category-l-behavior-equivalence.md",
@@ -160,7 +159,7 @@ def _category_l_policy_texts() -> tuple[str, str, str]:
     )
 
 
-def _comment_policy_summary_texts() -> tuple[str, str, str, str]:
+def _comment_policy_summary_texts() -> tuple[str, str, str]:
     clean_coder = _PACKAGE_ROOT / ".agents" / "agents" / "clean-coder.md"
     category_j = (
         _PACKAGE_ROOT
@@ -169,24 +168,21 @@ def _comment_policy_summary_texts() -> tuple[str, str, str, str]:
         / "category-j-code-rules-compliance.md"
     )
     code_quality = _PACKAGE_ROOT / ".agents" / "agents" / "code-quality-agent.md"
-    gate = _PACKAGE_ROOT / "_shared" / "pr-loop" / "code-rules-gate.md"
     return tuple(
         each_path.read_text(encoding="utf-8").lower()
-        for each_path in (clean_coder, category_j, code_quality, gate)
+        for each_path in (clean_coder, category_j, code_quality)
     )
 
 
 def test_comment_policy_uses_changed_comment_names_and_type_directives() -> None:
     category_l_rubric, category_l_prompt, audit_categories = _category_l_policy_texts()
-    clean_coder, category_j, code_quality, gate = _comment_policy_summary_texts()
+    clean_coder, category_j, code_quality = _comment_policy_summary_texts()
     assert "| l7 | changed-comment handling" in category_l_rubric
     assert "**l7. changed-comment handling**" in category_l_prompt
     assert '"axis_name": "changed-comment handling"' in audit_categories
     assert "no type-ignore directives" in clean_coder
     assert "no `# type: ignore` directives" in category_j
     assert "production and test code" in code_quality
-    assert "comments tied to touched code are removed" in gate
-    assert "comments tied to untouched code remain unchanged" in gate
 
 
 def test_comment_policy_removes_directive_justification_guidance() -> None:

package/.agents/skills/_shared/pr-loop/.claude/CLAUDE.md

@@ -1 +0,0 @@
-@../AGENTS.md

package/.agents/skills/_shared/pr-loop/AGENTS.md

@@ -1 +0,0 @@
-

package/.agents/skills/_shared/pr-loop/audit-contract.md

@@ -1,5 +0,0 @@
-# Audit contract
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/audit-contract.md

package/.agents/skills/_shared/pr-loop/audit-reply-template.md

@@ -1,5 +0,0 @@
-# Audit reply template
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/audit-reply-template.md

package/.agents/skills/_shared/pr-loop/code-rules-gate.md

@@ -1,5 +0,0 @@
-# Code rules gate
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/code-rules-gate.md

package/.agents/skills/_shared/pr-loop/fix-protocol.md

@@ -1,5 +0,0 @@
-# Fix protocol
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/fix-protocol.md

package/.agents/skills/_shared/pr-loop/gh-payloads.md

@@ -1,5 +0,0 @@
-# Gh payloads
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/gh-payloads.md

package/.agents/skills/_shared/pr-loop/portable-driver.md

@@ -1,149 +0,0 @@
-# Portable converge driver
-
-**Rule: deterministic control is script-only.** Phase transitions, wait delays,
-clean stamps, ready decisions, task lists, and “what next” never live as prose
-for the agent to invent. The agent runs scripts, reads JSON, and only performs
-judgment steps the JSON names.
-
-## Step 1 — task list (every autoconverge portable run)
-
-```
-python "$HOME/.claude/skills/_shared/pr-loop/scripts/build_converge_task_list.py" \
-  [--bugbot-down 0|1] [--copilot-down 0|1] \
-  [--codex-down 0|1] [--codex-required 0|1]
-```
-
-Register every `tasks[]` entry on the session task list. **Final task id is
-always** `all_runnable_reviews_clean_same_head`. The run is complete only when
-that final task is completed: every runnable code review is CLEAN on one
-shared HEAD. Do not invent tasks in prose.
-
-`open-run` embeds the same list (`tasks`, `runnable_review_ids`,
-`final_task_id`, `done_when`).
-
-## Pacer selection
-
-```
-python "$HOME/.claude/skills/_shared/pr-loop/scripts/select_converge_pacer.py" \
-  --skill autoconverge \
-  --has-workflow <0|1> \
-  --has-schedule-wakeup <0|1>
-```
-
-When `pacer` is not `portable`, use the skill’s native Workflow or
-ScheduleWakeup path. When `pacer=portable`, use the control script below.
-
-## Isolation and worktree
-
-1. When the tool list includes `EnterWorktree`, call it (same contract as the
-   Claude-host skills).
-2. When `EnterWorktree` is absent, isolate with git worktree machinery:
-   - Prefer an existing worktree already on the PR head ref under
-     `.claude/worktrees/` (or another dedicated worktree path).
-   - Otherwise `git fetch origin <headRefName>` and
-     `git worktree add <path> <headRefName>` (or `gh pr checkout <N>` into a
-     dedicated directory), then `cd` into that checkout.
-3. Confirm the working directory is the PR’s own repo on the PR head SHA:
-   `python "$HOME/.claude/skills/_shared/pr-loop/scripts/preflight_worktree.py" --owner <O> --repo <R> --mode strict`.
-   Non-zero exit → report the `ABORT` line and stop.
-4. Cross-repo routing: every local review and edit runs with cwd set to the **PR worktree** (see autoconverge pre-flight and `preflight_worktree.py --mode strict`).
-
-`open-run` runs the same strict preflight before seeding state.
-
-## Control script
-
-```
-python "$HOME/.claude/skills/_shared/pr-loop/scripts/portable_converge_driver.py" <command> ...
-```
-
-Stdout JSON: `status`, `next`, `phase`, `state_file`, optional `commands`,
-`wait_seconds`, `blocker`, and on `open-run` the task-list fields. Exit `0` =
-ok; `1` = contract failure; `2` = usage error.
-
-| Command | Deterministic effect |
-|---|---|
-| `open-run` | Require `portable`; preflight; seed state + task list; when `--codex-down` is off, set `codex_required` from CLI force-on or the weekly usage probe (same rule as `check_convergence`); next=`run_code_review` |
-| `after-code-review` | From returncode / dirty_tree / served_command |
-| `after-bugteam` | From pushed / converged (bug-audit phase on portable pacer) |
-| `after-bugbot` | From classification / inline lag |
-| `after-codex` | From classification clean / dirty / down |
-| `after-copilot-wait` | From review surfaced / wait cap |
-| `after-ready-check` | From check_convergence exit |
-| `show-state` | Echo state; rehydrate `commands` / `wait_seconds` for pending next |
-
-## Continuous tick loop
-
-After transport check, PR scope, isolation, permission grant, and the once-per-run
-Copilot quota pre-check:
-
-1. Seed or restore state via `open-run` or `show-state` (and handoff
-   `state-copy.json` when resuming).
-2. Run the driver command for the current step; read JSON `next` / `commands` /
-   `wait_seconds`.
-3. On non-terminal `next`:
-   - Write state and handoff when the after-* payload says so.
-   - If `next` is `poll_wait`, sleep `wait_seconds` only, then re-poll and call
-     the matching after-*.
-   - If `next` is immediate work, continue in the same turn without sleeping.
-4. On `mark_ready` / `stop_blocked` / named stop: run lifecycle Close, print the
-   entry skill’s exit block, omit further pacing.
-5. External reviewers remain skippable the same way as Claude-host runs when
-   opted out or down. Push and head-change reset push-invalidated markers
-   (`*_clean_at`, `merge_state_status`, `bugbot_down`, `codex_down`).
-
-## Agent loop (judgment only)
-
-1. Run the driver command for the current step.
-2. If JSON `commands` is non-empty, run that argv (scripted helper).
-3. Map JSON `next` to the single judgment action; report back via the matching
-   `after-*` command.
-4. Mark session tasks complete only when the scripted stamps say so; complete
-   the final task only when every runnable review is clean on the same HEAD.
-
-| `next` | Agent does | Report with |
-|---|---|---|
-| `run_code_review` | Run `commands` | `after-code-review` |
-| `apply_fixes_and_push` | Fix protocol; commit; push | re-review then `after-code-review` |
-| `run_bugteam` | Bug-audit lens / worker spawn body | `after-bugteam` |
-| `run_bugbot_gate` | Bugbot helper scripts | `after-bugbot` |
-| `run_codex_review` | Run Codex review step | `after-codex` |
-| `request_copilot_review` | Request Copilot | `after-copilot-wait` |
-| `poll_wait` | Sleep `wait_seconds` only | re-poll then after-* |
-| `check_ready` | Run `commands` (check_convergence) | `after-ready-check` |
-| `mark_ready` | Run `commands` (`gh pr ready`) | teardown |
-| `stop_blocked` | Teardown; print blocker | stop |
-
-## Autoconverge entry on portable pacer
-
-When `/autoconverge` selects `pacer=portable`:
-
-- Complete autoconverge pre-flight (scope, draft ownership, strict worktree,
-  grant, Copilot quota).
-- Drive the continuous tick loop above (scripted phase machine) until ready
-  or a documented blocker.
-- Skip `Workflow({ scriptPath: converge.mjs })` — that path requires the
-  Workflow tool.
-- Teardown uses the lifecycle Close path; the Workflow-only closing HTML
-  journal report is optional and skipped when no workflow run id exists.
-- Resume command on handoff: `/autoconverge <PR URL>`.
-
-When `/autoconverge` selects `pacer=workflow`, follow the skill’s Workflow
-sections unchanged.
-
-## Helpers (scripted)
-
-| Concern | Script |
-|---|---|
-| Task list | `build_converge_task_list.py` |
-| Pacer | `select_converge_pacer.py` |
-| Worktree | `preflight_worktree.py` |
-| Code review | `$HOME/.claude/scripts/invoke_code_review.py` |
-| Workers | `$HOME/.claude/scripts/resolve_worker_spawn.py` |
-| Ready | `$HOME/.claude/_shared/pr-loop/scripts/check_convergence.py` |
-| Handoff | `write_handoff.py` |
-
-## Fail closed
-
-Never abort solely because Workflow or ScheduleWakeup is missing once
-pacer=`portable`. Fail closed on contract failures only: auth, worktree,
-unresolvable gates, and wait caps.

package/.agents/skills/_shared/pr-loop/post-audit-thread-contract.md

@@ -1,5 +0,0 @@
-# Post-audit thread contract
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/post-audit-thread-contract.md

package/.agents/skills/_shared/pr-loop/precatch-rubric.md

@@ -1,5 +0,0 @@
-# Precatch rubric
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/precatch-rubric.md