claude-dev-env 4.2.0 → 7.0.0

package/scripts/tests/test_rules.py

@@ -96,7 +96,6 @@ def _comment_policy_surfaces(package_root: Path) -> tuple[Path, ...]:
         package_root / "system-prompts" / "software-engineer.xml",
         package_root / ".agents" / "agents" / "clean-coder.md",
         package_root / ".agents" / "agents" / "code-quality-agent.md",
-        package_root / "_shared" / "pr-loop" / "code-rules-gate.md",
         package_root / "audit-rubrics" / "category_rubrics" / "category-j-code-rules-compliance.md",
         package_root / "audit-rubrics" / "prompts" / "category-j-code-rules-compliance.md",
         package_root / "audit-rubrics" / "category_rubrics" / "category-l-behavior-equivalence.md",
@@ -160,7 +159,7 @@ def _category_l_policy_texts() -> tuple[str, str, str]:
     )
 
 
-def _comment_policy_summary_texts() -> tuple[str, str, str, str]:
+def _comment_policy_summary_texts() -> tuple[str, str, str]:
     clean_coder = _PACKAGE_ROOT / ".agents" / "agents" / "clean-coder.md"
     category_j = (
         _PACKAGE_ROOT
@@ -169,24 +168,21 @@ def _comment_policy_summary_texts() -> tuple[str, str, str, str]:
         / "category-j-code-rules-compliance.md"
     )
     code_quality = _PACKAGE_ROOT / ".agents" / "agents" / "code-quality-agent.md"
-    gate = _PACKAGE_ROOT / "_shared" / "pr-loop" / "code-rules-gate.md"
     return tuple(
         each_path.read_text(encoding="utf-8").lower()
-        for each_path in (clean_coder, category_j, code_quality, gate)
+        for each_path in (clean_coder, category_j, code_quality)
     )
 
 
 def test_comment_policy_uses_changed_comment_names_and_type_directives() -> None:
     category_l_rubric, category_l_prompt, audit_categories = _category_l_policy_texts()
-    clean_coder, category_j, code_quality, gate = _comment_policy_summary_texts()
+    clean_coder, category_j, code_quality = _comment_policy_summary_texts()
     assert "| l7 | changed-comment handling" in category_l_rubric
     assert "**l7. changed-comment handling**" in category_l_prompt
     assert '"axis_name": "changed-comment handling"' in audit_categories
     assert "no type-ignore directives" in clean_coder
     assert "no `# type: ignore` directives" in category_j
     assert "production and test code" in code_quality
-    assert "comments tied to touched code are removed" in gate
-    assert "comments tied to untouched code remain unchanged" in gate
 
 
 def test_comment_policy_removes_directive_justification_guidance() -> None:

package/.agents/skills/_shared/pr-loop/.claude/CLAUDE.md

@@ -1 +0,0 @@
-@../AGENTS.md

package/.agents/skills/_shared/pr-loop/AGENTS.md

@@ -1 +0,0 @@
-

package/.agents/skills/_shared/pr-loop/audit-contract.md

@@ -1,5 +0,0 @@
-# Audit contract
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/audit-contract.md

package/.agents/skills/_shared/pr-loop/audit-reply-template.md

@@ -1,5 +0,0 @@
-# Audit reply template
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/audit-reply-template.md

package/.agents/skills/_shared/pr-loop/code-rules-gate.md

@@ -1,5 +0,0 @@
-# Code rules gate
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/code-rules-gate.md

package/.agents/skills/_shared/pr-loop/fix-protocol.md

@@ -1,5 +0,0 @@
-# Fix protocol
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/fix-protocol.md

package/.agents/skills/_shared/pr-loop/gh-payloads.md

@@ -1,5 +0,0 @@
-# Gh payloads
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/gh-payloads.md

package/.agents/skills/_shared/pr-loop/portable-driver.md

@@ -1,149 +0,0 @@
-# Portable converge driver
-
-**Rule: deterministic control is script-only.** Phase transitions, wait delays,
-clean stamps, ready decisions, task lists, and “what next” never live as prose
-for the agent to invent. The agent runs scripts, reads JSON, and only performs
-judgment steps the JSON names.
-
-## Step 1 — task list (every autoconverge portable run)
-
-```
-python "$HOME/.claude/skills/_shared/pr-loop/scripts/build_converge_task_list.py" \
-  [--bugbot-down 0|1] [--copilot-down 0|1] \
-  [--codex-down 0|1] [--codex-required 0|1]
-```
-
-Register every `tasks[]` entry on the session task list. **Final task id is
-always** `all_runnable_reviews_clean_same_head`. The run is complete only when
-that final task is completed: every runnable code review is CLEAN on one
-shared HEAD. Do not invent tasks in prose.
-
-`open-run` embeds the same list (`tasks`, `runnable_review_ids`,
-`final_task_id`, `done_when`).
-
-## Pacer selection
-
-```
-python "$HOME/.claude/skills/_shared/pr-loop/scripts/select_converge_pacer.py" \
-  --skill autoconverge \
-  --has-workflow <0|1> \
-  --has-schedule-wakeup <0|1>
-```
-
-When `pacer` is not `portable`, use the skill’s native Workflow or
-ScheduleWakeup path. When `pacer=portable`, use the control script below.
-
-## Isolation and worktree
-
-1. When the tool list includes `EnterWorktree`, call it (same contract as the
-   Claude-host skills).
-2. When `EnterWorktree` is absent, isolate with git worktree machinery:
-   - Prefer an existing worktree already on the PR head ref under
-     `.claude/worktrees/` (or another dedicated worktree path).
-   - Otherwise `git fetch origin <headRefName>` and
-     `git worktree add <path> <headRefName>` (or `gh pr checkout <N>` into a
-     dedicated directory), then `cd` into that checkout.
-3. Confirm the working directory is the PR’s own repo on the PR head SHA:
-   `python "$HOME/.claude/skills/_shared/pr-loop/scripts/preflight_worktree.py" --owner <O> --repo <R> --mode strict`.
-   Non-zero exit → report the `ABORT` line and stop.
-4. Cross-repo routing: every local review and edit runs with cwd set to the **PR worktree** (see autoconverge pre-flight and `preflight_worktree.py --mode strict`).
-
-`open-run` runs the same strict preflight before seeding state.
-
-## Control script
-
-```
-python "$HOME/.claude/skills/_shared/pr-loop/scripts/portable_converge_driver.py" <command> ...
-```
-
-Stdout JSON: `status`, `next`, `phase`, `state_file`, optional `commands`,
-`wait_seconds`, `blocker`, and on `open-run` the task-list fields. Exit `0` =
-ok; `1` = contract failure; `2` = usage error.
-
-| Command | Deterministic effect |
-|---|---|
-| `open-run` | Require `portable`; preflight; seed state + task list; when `--codex-down` is off, set `codex_required` from CLI force-on or the weekly usage probe (same rule as `check_convergence`); next=`run_code_review` |
-| `after-code-review` | From returncode / dirty_tree / served_command |
-| `after-bugteam` | From pushed / converged (bug-audit phase on portable pacer) |
-| `after-bugbot` | From classification / inline lag |
-| `after-codex` | From classification clean / dirty / down |
-| `after-copilot-wait` | From review surfaced / wait cap |
-| `after-ready-check` | From check_convergence exit |
-| `show-state` | Echo state; rehydrate `commands` / `wait_seconds` for pending next |
-
-## Continuous tick loop
-
-After transport check, PR scope, isolation, permission grant, and the once-per-run
-Copilot quota pre-check:
-
-1. Seed or restore state via `open-run` or `show-state` (and handoff
-   `state-copy.json` when resuming).
-2. Run the driver command for the current step; read JSON `next` / `commands` /
-   `wait_seconds`.
-3. On non-terminal `next`:
-   - Write state and handoff when the after-* payload says so.
-   - If `next` is `poll_wait`, sleep `wait_seconds` only, then re-poll and call
-     the matching after-*.
-   - If `next` is immediate work, continue in the same turn without sleeping.
-4. On `mark_ready` / `stop_blocked` / named stop: run lifecycle Close, print the
-   entry skill’s exit block, omit further pacing.
-5. External reviewers remain skippable the same way as Claude-host runs when
-   opted out or down. Push and head-change reset push-invalidated markers
-   (`*_clean_at`, `merge_state_status`, `bugbot_down`, `codex_down`).
-
-## Agent loop (judgment only)
-
-1. Run the driver command for the current step.
-2. If JSON `commands` is non-empty, run that argv (scripted helper).
-3. Map JSON `next` to the single judgment action; report back via the matching
-   `after-*` command.
-4. Mark session tasks complete only when the scripted stamps say so; complete
-   the final task only when every runnable review is clean on the same HEAD.
-
-| `next` | Agent does | Report with |
-|---|---|---|
-| `run_code_review` | Run `commands` | `after-code-review` |
-| `apply_fixes_and_push` | Fix protocol; commit; push | re-review then `after-code-review` |
-| `run_bugteam` | Bug-audit lens / worker spawn body | `after-bugteam` |
-| `run_bugbot_gate` | Bugbot helper scripts | `after-bugbot` |
-| `run_codex_review` | Run Codex review step | `after-codex` |
-| `request_copilot_review` | Request Copilot | `after-copilot-wait` |
-| `poll_wait` | Sleep `wait_seconds` only | re-poll then after-* |
-| `check_ready` | Run `commands` (check_convergence) | `after-ready-check` |
-| `mark_ready` | Run `commands` (`gh pr ready`) | teardown |
-| `stop_blocked` | Teardown; print blocker | stop |
-
-## Autoconverge entry on portable pacer
-
-When `/autoconverge` selects `pacer=portable`:
-
-- Complete autoconverge pre-flight (scope, draft ownership, strict worktree,
-  grant, Copilot quota).
-- Drive the continuous tick loop above (scripted phase machine) until ready
-  or a documented blocker.
-- Skip `Workflow({ scriptPath: converge.mjs })` — that path requires the
-  Workflow tool.
-- Teardown uses the lifecycle Close path; the Workflow-only closing HTML
-  journal report is optional and skipped when no workflow run id exists.
-- Resume command on handoff: `/autoconverge <PR URL>`.
-
-When `/autoconverge` selects `pacer=workflow`, follow the skill’s Workflow
-sections unchanged.
-
-## Helpers (scripted)
-
-| Concern | Script |
-|---|---|
-| Task list | `build_converge_task_list.py` |
-| Pacer | `select_converge_pacer.py` |
-| Worktree | `preflight_worktree.py` |
-| Code review | `$HOME/.claude/scripts/invoke_code_review.py` |
-| Workers | `$HOME/.claude/scripts/resolve_worker_spawn.py` |
-| Ready | `$HOME/.claude/_shared/pr-loop/scripts/check_convergence.py` |
-| Handoff | `write_handoff.py` |
-
-## Fail closed
-
-Never abort solely because Workflow or ScheduleWakeup is missing once
-pacer=`portable`. Fail closed on contract failures only: auth, worktree,
-unresolvable gates, and wait caps.

package/.agents/skills/_shared/pr-loop/post-audit-thread-contract.md

@@ -1,5 +0,0 @@
-# Post-audit thread contract
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/post-audit-thread-contract.md

package/.agents/skills/_shared/pr-loop/precatch-rubric.md

@@ -1,5 +0,0 @@
-# Precatch rubric
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/precatch-rubric.md

package/.agents/skills/_shared/pr-loop/preflight-proposal.contract.test.mjs

@@ -1,119 +0,0 @@
-import assert from 'node:assert/strict'
-import { readFileSync } from 'node:fs'
-import { dirname, resolve } from 'node:path'
-import test from 'node:test'
-import { fileURLToPath } from 'node:url'
-
-const THIS_DIRECTORY = dirname(fileURLToPath(import.meta.url))
-const canonicalContractSource = readFileSync(
-  resolve(THIS_DIRECTORY, '../../../../_shared/pr-loop/preflight-proposal.md'),
-  'utf8',
-)
-const sharedSkillSource = readFileSync(
-  resolve(THIS_DIRECTORY, '../../pr-shared-extraction/SKILL.md'),
-  'utf8',
-)
-const capabilitySkillSource = readFileSync(
-  resolve(THIS_DIRECTORY, '../../pr-name-by-capability/SKILL.md'),
-  'utf8',
-)
-const capabilityTaskSeedsSource = readFileSync(
-  resolve(THIS_DIRECTORY, '../../pr-name-by-capability/reference/task-seeds.md'),
-  'utf8',
-)
-const reviewSkillSource = readFileSync(
-  resolve(THIS_DIRECTORY, '../../e-code-review/SKILL.md'),
-  'utf8',
-)
-const reviewProposalSource = readFileSync(
-  resolve(THIS_DIRECTORY, '../../e-code-review/reference/preflight-proposal.md'),
-  'utf8',
-)
-
-const allSkillContracts = [
-  {
-    name: 'shared extraction audit',
-    skillSource: sharedSkillSource,
-    invocationPattern: /pr-shared-extraction preflight-proposal/,
-    classificationPattern: /priority and target/,
-    expectedDefaultBehavior: 'applies the prioritized fix band by default',
-  },
-  {
-    name: 'name by capability audit',
-    skillSource: capabilitySkillSource,
-    invocationPattern: /pr-name-by-capability preflight-proposal/,
-    classificationPattern: /violation or OK-driver classification/,
-    expectedDefaultBehavior: 'applies the suggested rename direction by default',
-  },
-]
-
-function assertProposalAdapter(skillContract) {
-  const preflightRoutingOffset = skillContract.skillSource.indexOf('`preflight-proposal`')
-  const reportOnlyRoutingOffset = skillContract.skillSource.indexOf('`audit-only`')
-
-  assert.ok(preflightRoutingOffset >= 0, `${skillContract.name} selects proposal mode`)
-  assert.ok(preflightRoutingOffset < reportOnlyRoutingOffset, `${skillContract.name} routes proposal mode first`)
-  assert.match(skillContract.skillSource, skillContract.invocationPattern)
-  assert.match(skillContract.skillSource, skillContract.classificationPattern)
-  assert.match(skillContract.skillSource, new RegExp(skillContract.expectedDefaultBehavior))
-}
-
-function assertTaskRoutingAndNormalMode() {
-  assert.match(sharedSkillSource, /Register this checklist with `update_plan`/)
-  assert.match(capabilitySkillSource, /Register every bullet from `reference\/task-seeds\.md` with `update_plan`/)
-  assert.match(capabilityTaskSeedsSource, /Register each item with `update_plan`/)
-  assert.doesNotMatch(sharedSkillSource, /TodoWrite|TaskCreate/)
-  assert.doesNotMatch(capabilitySkillSource, /TodoWrite|TaskCreate/)
-  assert.doesNotMatch(capabilityTaskSeedsSource, /TodoWrite|TaskCreate/)
-  assert.match(sharedSkillSource, /audit-only` is report-only/)
-  assert.match(capabilitySkillSource, /audit-only` is report-only/)
-}
-
-function assertSharedProposalContract(contractSource) {
-  assert.match(contractSource, /caller-supplied isolated worktree/)
-  assert.match(contractSource, /resolved PR number/)
-  assert.match(contractSource, /immutable base SHA/)
-  assert.match(contractSource, /immutable head SHA/)
-  assert.match(contractSource, /exact `base_sha\.\.\.head_sha` range/)
-  assert.match(contractSource, /require exact equality with the head SHA/)
-  assert.match(contractSource, /immutable proposal identity/)
-  assert.match(contractSource, /deterministic diff hash/)
-  assert.match(contractSource, /changed paths/)
-  assert.match(contractSource, /exact tests and outcomes/)
-  assert.match(contractSource, /selected-candidate-ready proposal evidence/)
-  assert.match(contractSource, /selected or dispositioned proposal collection/)
-  assert.match(contractSource, /Reapplication uses exactly the selected records/)
-}
-
-function assertReviewProposalAdapter() {
-  const preflightRoutingOffset = reviewSkillSource.indexOf('`preflight-proposal`')
-  const refusalRoutingOffset = reviewSkillSource.indexOf('**Refusal — first match wins:**')
-  const allProposalEntryMatches = reviewSkillSource.match(
-    /Route the selected mode through \[reference\/preflight-proposal.md\]\(reference\/preflight-proposal.md\) to establish proposal context/g,
-  ) ?? []
-
-  assert.ok(preflightRoutingOffset >= 0)
-  assert.ok(preflightRoutingOffset < refusalRoutingOffset)
-  assert.equal(allProposalEntryMatches.length, 1)
-  assert.match(reviewSkillSource, /e-code-review preflight-proposal/)
-  assert.match(reviewSkillSource, /`--level <low\|medium\|xhigh>`/)
-  assert.match(reviewSkillSource, /@~\/.claude\/_shared\/pr-loop\/preflight-proposal.md/)
-  assert.match(reviewSkillSource, /Normal mode follows the current level/)
-  assert.match(reviewProposalSource, /Keep Gate 1, Gate 2, the bare code-rules gate, and exact required tests/)
-  assert.match(reviewProposalSource, /review_level: low \| medium \| xhigh/)
-  assert.match(reviewProposalSource, /severity: blocker \| high \| medium \| low \| nit/)
-  assert.match(reviewProposalSource, /verdict: CONFIRMED \| PLAUSIBLE/)
-  assert.match(reviewProposalSource, /outcome: fixed \| no_change_needed \| skipped/)
-}
-
-test('audit modes retain their normal routing behavior', () => {
-  assertTaskRoutingAndNormalMode()
-})
-
-test('one shared contract defines proposal evidence for audit and review skills', () => {
-  for (const eachSkillContract of allSkillContracts) {
-    assertProposalAdapter(eachSkillContract)
-  }
-  assertReviewProposalAdapter()
-  assertSharedProposalContract(canonicalContractSource)
-})

package/.agents/skills/_shared/pr-loop/preflight-proposal.md

@@ -1,5 +0,0 @@
-# Preflight proposal contract
-
-**Canonical home:**
-
-@~/.claude/_shared/pr-loop/preflight-proposal.md

package/.agents/skills/_shared/pr-loop/prompts/.claude/CLAUDE.md

@@ -1 +0,0 @@
-@../AGENTS.md

package/.agents/skills/_shared/pr-loop/prompts/AGENTS.md

@@ -1 +0,0 @@
-