claude-dev-env 2.7.1 → 2.9.0

package/skills/team-advisor/SKILL.md

@@ -2,60 +2,42 @@
 name: team-advisor
 description: >-
   Spawn one warm session-advisor at the strongest reachable tier and consult
-  it before big decisions, completion, commits, or when stuck. Triggers:
+  it before substantive work, completion, commits, or when stuck. Triggers:
   'team-advisor', 'team advisor', 'second opinion', 'advisor', 'consult',
   'verify', 'validate', 'commit', 'push'.
 ---
 
 # Team Advisor
 
-## Principle
+One warm advisor at the strongest tier this session can reach. This session is the sole consumer.
 
-One warm, addressable advisor available at the strongest model tier the session can reach. The session sends concise briefs when a decision benefits from a second opinion: before acting on a plan, at completion, before commits, when stuck, when reconsidering the approach, or when an agent deems it necessary and beneficial to the user's goals.
+## Refs
 
-## Follow the shared protocol
-
-**Detect the host profile first** (Host profiles in
-[`_shared/advisor/advisor-protocol.md`](../../_shared/advisor/advisor-protocol.md)
-— e.g. %USERPROFILE%\.claude\_shared\advisor\advisor-protocol.md). Do not start a model-floor
-walk until the host is known. 
-
-This session is the shared advisor's sole consumer, so its model floor is
-simply this session's own tier — no routing table to take a max against.
+| Doc | Holds |
+|---|---|
+| [`docs/references/advisor-tool.md`](../../docs/references/advisor-tool.md) | **Consult cadence and weight** — when to call, hard rule before first write, how to treat advice. Read this for every consult. |
+| [`~/.claude/_shared/advisor/advisor-protocol.md`](../../_shared/advisor/advisor-protocol.md) | **Bind and lifecycle** — host detect, model floor, warm-up or CLI bind, charter, drift re-bind, CLI fallback, executor paste blocks. |
+| [`agents/session-advisor.md`](../../agents/session-advisor.md) | **Reply contract** — ENDORSE / CORRECTION / PLAN / STOP; SendMessage only. |
 
-**Claude host:** follow the shared protocol for the model-floor walk, the
-warm-up spawn and charter, the consult format and cadence, drift-respawn, and
-the CLI fallback — using `team-advisor-agent` as the name and this session as
-the only consumer (skip the "who you are and your assignment" opener in each
-consult; a single-consumer session doesn't need it).
+## Bind
 
-**Third-party host:** bind a max-tier Claude advisor through the shared CLI Claude-chain
-in the protocol (Fable max, then Opus max; `claude_chain_runner.py` ranks
-`~/.claude/claude-chain.json` accounts by weekly remaining via `claude_chain_usage`
-and fails over on usage limits). Consult via
-`--resume <session_id>` on that bind. This session is the sole consumer of that
-CLI advisor; skip the multi-consumer opener. When the chain cannot bind or
-reply, fail closed and report to the user — do **not** answer ENDORSE /
-CORRECTION / PLAN / STOP as this third-party session.
+1. Detect the host profile first (protocol **Host profiles**), then walk the model floor.
+2. Floor: this session's own tier on Claude; Opus floor with Fable first on a third-party host.
+3. Name: `team-advisor-agent` on Claude (Agent spawn of `session-advisor`); one CLI `session_id` on a third-party host via the protocol Claude-chain.
+4. A Fable-tier spawn or re-spawn carries the exact token `FABLE-SPAWN-AUTHORIZED` in its prompt (protocol warm-up; `fable_spawn_gate` requires it).
+5. Skip the multi-consumer "who you are" opener — sole consumer.
+6. When the bind or reply path fails, fail closed and report to the user. On a third-party host, only the bound Claude advisor issues ENDORSE / CORRECTION / PLAN / STOP.
 
-## Constraints
+Full walk, charter, consult message shape, and drift re-bind live in the protocol.
 
-- One advisor bind per session (`team-advisor-agent` on Claude; one CLI
-  `session_id` on a third-party host), owned by this session for its whole lifecycle
-  (spawn or CLI bind, drift re-bind, shutdown) — see
-  [`_shared/advisor/advisor-protocol.md`](../../_shared/advisor/advisor-protocol.md).
-- Never bind the advisor, or its CLI path, at a tier below the protocol floor
-  for this host (Claude: this session's own tier; a third-party host: Opus floor
-  with Fable first).
-- The advisor only answers. It never edits a file, never runs a build or
-  test, and never posts anything on the session's behalf.
+## Consult
 
-## File Index
+Follow **When to call**, **Hard rule**, and **How to treat advice** in `advisor-tool.md`.
 
-| File | Purpose |
-|---|---|
-| `SKILL.md` | Pointer to the shared advisor protocol; this session's consumer-specific wiring and constraints. |
+Each brief: delta since last consult, live decision or blocker, paths or excerpts needed. Protocol owns the full consult format.
 
-## Folder Map
+## Constraints
 
-- `SKILL.md` — complete team-advisor workflow instructions.
+- One bind per session; this session owns spawn or CLI bind, drift re-bind, and shutdown.
+- Bind at or above the protocol floor for this host.
+- The advisor only answers (messaging); the session runs tools and posts.

package/system-prompts/software-engineer.xml

@@ -90,8 +90,10 @@
 </problem_solving>
 
 <code_quality>
-  Apply the system-prompt code-quality checklist as the canonical naming and style source for
-  all code you write or modify. ~/.claude/docs/CODE_RULES.md is a pointer to this source.
+  Canonical code-quality policy is repository-root AGENTS.md (installed review contract).
+  ~/.claude/docs/CODE_RULES.md is the compact projection of AGENTS.md for generation load —
+  when the two disagree, AGENTS.md wins. The checklist below is a short reminder, not a
+  second canonical source.
 
   Naming — full words only:
   - Use "context" over "ctx", "configuration" over "cfg", "message" over "msg",
@@ -109,7 +111,8 @@
   Types — complete coverage required:
   - Every parameter and return value carries an explicit type hint
   - Replace Any with the most specific type available
-  - Replace every # type: ignore annotation with correct typing
+  - Prefer a real type over `# type: ignore`; when an ignore is required, add a second
+    trailing `#` justification of at least five characters (AGENTS Types)
 
   Configuration — one source of truth:
   - Every constant lives in config/ only

package/skills/test_markdown_link_integrity.py

@@ -1,107 +0,0 @@
-"""Link-integrity check for the skills tree and shared protocol docs.
-
-Walks every markdown file under ``skills/``, ``_shared/pr-loop/``, and
-``_shared/advisor/`` and resolves each relative markdown link target against
-the linking file's directory. A link whose target file or directory does not
-exist on disk is reported with its source file and line number, and the test
-fails.
-"""
-
-from __future__ import annotations
-
-import re
-from pathlib import Path
-
-
-SKILLS_ROOT = Path(__file__).parent
-SHARED_PR_LOOP_ROOT = SKILLS_ROOT.parent / "_shared" / "pr-loop"
-SHARED_ADVISOR_ROOT = SKILLS_ROOT.parent / "_shared" / "advisor"
-
-MARKDOWN_LINK_PATTERN = re.compile(r"\]\(([^)\s]+)\)")
-FENCE_MARKER = "```"
-
-SKIPPED_TARGET_PREFIXES = (
-    "http://",
-    "https://",
-    "mailto:",
-    "#",
-    "/",
-    "$",
-    "~",
-    "<",
-)
-
-
-def _iter_markdown_files() -> list[Path]:
-    """List every markdown file the integrity check covers.
-
-    Returns:
-        All ``.md`` files under the skills tree, the shared pr-loop tree, and
-        the shared advisor tree.
-    """
-    all_markdown_files = sorted(SKILLS_ROOT.rglob("*.md"))
-    all_markdown_files.extend(sorted(SHARED_PR_LOOP_ROOT.rglob("*.md")))
-    all_markdown_files.extend(sorted(SHARED_ADVISOR_ROOT.rglob("*.md")))
-    return all_markdown_files
-
-
-def _is_checkable_target(link_target: str) -> bool:
-    """Decide whether a markdown link target names a local relative path.
-
-    Args:
-        link_target: The raw text between ``](`` and ``)`` in a markdown link.
-
-    Returns:
-        True when the target is a relative filesystem path this check can
-        resolve; False for URLs, anchors, absolute paths, environment-variable
-        paths, home-relative paths, and angle-bracket placeholders.
-    """
-    if link_target.startswith(SKIPPED_TARGET_PREFIXES):
-        return False
-    if "\\" in link_target and link_target.count(":") > 0:
-        return False
-    return True
-
-
-def _collect_broken_links(markdown_path: Path) -> list[str]:
-    """Resolve every relative link in one markdown file.
-
-    Fenced code blocks are skipped, and a ``#fragment`` suffix is stripped
-    before resolution.
-
-    Args:
-        markdown_path: The markdown file whose links are resolved.
-
-    Returns:
-        One ``file:line -> target`` description per unresolvable link.
-    """
-    all_broken_links: list[str] = []
-    is_inside_fence = False
-    for line_number, each_line in enumerate(
-        markdown_path.read_text(encoding="utf-8").splitlines(), start=1
-    ):
-        if each_line.lstrip().startswith(FENCE_MARKER):
-            is_inside_fence = not is_inside_fence
-            continue
-        if is_inside_fence:
-            continue
-        for each_match in MARKDOWN_LINK_PATTERN.finditer(each_line):
-            link_target = each_match.group(1).split("#", 1)[0]
-            if not link_target or not _is_checkable_target(link_target):
-                continue
-            resolved_target = (markdown_path.parent / link_target).resolve()
-            if not resolved_target.exists():
-                all_broken_links.append(
-                    f"{markdown_path}:{line_number} -> {each_match.group(1)}"
-                )
-    return all_broken_links
-
-
-def test_every_relative_markdown_link_resolves() -> None:
-    all_broken_links: list[str] = []
-    for each_markdown_path in _iter_markdown_files():
-        all_broken_links.extend(_collect_broken_links(each_markdown_path))
-    broken_link_report = "\n".join(all_broken_links)
-    assert not all_broken_links, (
-        f"Unresolvable relative markdown links:\n{broken_link_report}"
-    )