claude-dev-env 2.4.0 → 2.7.0

package/skills/autoconverge/reference/convergence.md

@@ -106,6 +106,18 @@ follow-up issue listing the findings, opens a draft environment-hardening PR
 (hooks/rules that block those violation classes at Write/Edit time), resolves
 any bot threads with a deferral note, and reports the deferral in
 `standardsNote`. The hardening PRs land in the run result's `deferredPrs` list.
+Standards-only deferral still takes precedence when every finding is category
+`code-standard`.
+
+When the already-deduped findings for a phase are all severity P2 (and not
+standards-only), the phase still applies the fixes once. If the fix does **not**
+move HEAD (for example `resolvedWithoutCommit`), the phase treats that HEAD as
+clean and advances forward. If the fix **does** move HEAD, the run re-enters
+CONVERGE on the fixed SHA so HEAD-bound CLEAN/review stamps rebuild before
+FINALIZE — those stamps are SHA-specific. The three CONVERGE reading lenses stay
+parallel; the P2-only decision is a routing branch on the deduped set after
+`resolveRoundOutcome` / gate classification. Mixed P0/P1 findings keep the
+existing fix + re-converge path.
 
 **BUGBOT** gate (terminal external confirmation):
 
@@ -115,7 +127,10 @@ any bot threads with a deferral note, and reports the deferral in
   to the Copilot gate with `bugbotDown` set.
 - Otherwise drive Cursor Bugbot to a verdict on HEAD (trigger and poll its CI
   check run when needed).
-- Bugbot findings → fix them and return to CONVERGE on the new HEAD.
+- Bugbot findings that are not standards-only and not P2-only → fix them and
+  return to CONVERGE on the new HEAD.
+- Bugbot P2-only findings → fix once; advance to Copilot only when HEAD is
+  unchanged, otherwise re-converge on the fixed HEAD.
 - Bugbot clean or approved → move to the Copilot gate.
 - Bugbot down after the poll cap → move to the Copilot gate with `bugbotDown` set.
 
@@ -123,7 +138,10 @@ any bot threads with a deferral note, and reports the deferral in
 
 - Request a Copilot review on HEAD (skipping a duplicate request), then poll up
   to the configured cap, 360 seconds apart.
-- Copilot findings → fix them and return to CONVERGE on the new HEAD.
+- Copilot findings that are not standards-only and not P2-only → fix them and
+  return to CONVERGE on the new HEAD.
+- Copilot P2-only findings → fix once; advance to Codex only when HEAD is
+  unchanged, otherwise re-converge on the fixed HEAD.
 - Copilot clean or approved → move to the Codex gate.
 - Copilot down or out of quota (an out-of-usage notice, or no review after the
   configured cap) → log a notice and move to the Codex gate with the Copilot gate
@@ -140,7 +158,10 @@ any bot threads with a deferral note, and reports the deferral in
 - Usage at/below threshold or null → skip with no stamp; the machine checklist
   applies the same rule.
 - Above threshold → run the codex-review wrapper against the PR base branch.
-  Non–code-standard findings → fix and return to CONVERGE.
+  Non–code-standard, non–P2-only findings → fix and return to CONVERGE.
+  P2-only findings → fix once; when HEAD is unchanged, stamp `codexCleanAt` and
+  move to the convergence check (no re-converge), otherwise re-converge on the
+  fixed HEAD.
   Standards-only findings → defer a follow-up, stamp `codexCleanAt`, and move to the
   convergence check (no fix push).
   Clean → stamp `codexCleanAt` and pass `--codex-clean-at` into the convergence check.

package/skills/autoconverge/workflow/CLAUDE.md

@@ -18,6 +18,7 @@ Workflow scripts and report utilities for the `autoconverge` skill.
 | `converge.precatch.test.mjs` | Tests the pre-catch stage: static-sweep ordering and gate coverage, the adversarial second pass, the self-review lens, the terminal Bugbot gate, the read-only/edit preamble split, and the commit-recovery cap. |
 | `converge.fix-progress.test.mjs` | Tests fix-progress tracking across rounds. |
 | `converge.fix-recovery.test.mjs` | Tests recovery when a fix commit fails. |
+| `converge.p2-advance.test.mjs` | Tests P2-only fix-then-advance helpers and phase routing. |
 | `converge.run-input.test.mjs` | Tests workflow input validation. |
 | `test_aggregate_runs.py` | Tests for `aggregate_runs.py`. |
 | `test_convergence_summary.py` | Tests for `convergence_summary.py`. |

package/skills/autoconverge/workflow/converge.clean-audit.test.mjs

@@ -215,7 +215,7 @@ test('every no-lens-reviewed round registers one shared counter and every lens-r
   const registerSites = loopBody.match(/registerNoLensRound\(/g) || [];
   assert.equal(registerSites.length, 3, 'expected the preflight-no-SHA, all-lenses-dead, and no-lens-ran rounds to register');
   const resetSites = loopBody.match(/resetNoLensRounds\(\)/g) || [];
-  assert.equal(resetSites.length, 5, 'expected a reset on the static-sweep, standards, findings, not-clean, and posted lens-ran rounds');
+  assert.equal(resetSites.length, 6, 'expected a reset on the static-sweep, standards, P2-only, findings, not-clean, and posted lens-ran rounds');
   const deadBranch = convergeSource.slice(
     convergeSource.indexOf('if (roundOutcome.allLensesDead) {'),
     convergeSource.indexOf('const findings = roundOutcome.findings'),
@@ -533,7 +533,7 @@ test('CLEAN_AUDIT_SCHEMA requires posted, reviewUrl, and reason', () => {
 test('the standards-only call site records a clean-audit bypass and continues to BUGBOT when the post does not land', () => {
   const branch = convergeSource.slice(
     convergeSource.indexOf('if (isStandardsOnlyRound(findings)) {'),
-    convergeSource.indexOf('if (findings.length > 0) {'),
+    convergeSource.indexOf('if (isP2OnlyFindings(findings)) {'),
   );
   assert.match(branch, /runGeneralUtilityTask\(.*'post-clean-audit'/);
   assert.match(branch, /cleanAuditNote = resolveCleanAuditNote\(auditResult, head, rounds\)/);
@@ -545,7 +545,7 @@ test('the standards-only call site records a clean-audit bypass and continues to
 test('the standards-only call site relays lens provenance, the deferred standards findings, and the deferral filing state', () => {
   const branch = convergeSource.slice(
     convergeSource.indexOf('if (isStandardsOnlyRound(findings)) {'),
-    convergeSource.indexOf('if (findings.length > 0) {'),
+    convergeSource.indexOf('if (isP2OnlyFindings(findings)) {'),
   );
   assert.match(branch, /const namedLenses = nameLensResults\(lenses\)/);
   assert.match(branch, /lensResults: namedLenses/);