claude-dev-env 2.31.0 → 2.31.1

package/hooks/hooks_constants/test_subprocess_budget_completeness_content.py

@@ -68,3 +68,36 @@ def test_resolved_content_returns_empty_for_an_unreadable_edit_target(
         resolved_content({"file_path": str(missing_target), "old_string": "a", "new_string": "b"})
         == ""
     )
+
+
+def test_reconstructed_edit_content_replaces_every_occurrence_when_replace_all_is_set(
+    tmp_path: pathlib.Path,
+) -> None:
+    """An Edit carrying replace_all rewrites every occurrence, as the tool does.
+
+    The MultiEdit branch has honored the flag since it moved onto apply_edits;
+    the Edit branch must agree, or one payload reconstructs two ways.
+    """
+    target_file = tmp_path / "module.py"
+    target_file.write_text("a = 1\na = 1\n", encoding="utf-8")
+    reconstructed = reconstructed_edit_content(
+        {
+            "file_path": str(target_file),
+            "old_string": "a = 1",
+            "new_string": "a = 2",
+            "replace_all": True,
+        }
+    )
+    assert reconstructed == "a = 2\na = 2\n"
+
+
+def test_reconstructed_edit_content_replaces_one_occurrence_without_replace_all(
+    tmp_path: pathlib.Path,
+) -> None:
+    """Without the flag, only the first occurrence changes."""
+    target_file = tmp_path / "module.py"
+    target_file.write_text("a = 1\na = 1\n", encoding="utf-8")
+    reconstructed = reconstructed_edit_content(
+        {"file_path": str(target_file), "old_string": "a = 1", "new_string": "a = 2"}
+    )
+    assert reconstructed == "a = 2\na = 1\n"

package/hooks/observability/pr_description_writer_spawn_tracker.py

@@ -23,7 +23,6 @@ touch each returns quietly.
 from __future__ import annotations
 
 import sys
-import tempfile
 from pathlib import Path
 
 _hooks_dir = str(Path(__file__).resolve().parent.parent)
@@ -33,18 +32,16 @@ if _hooks_dir not in sys.path:
 from hooks_constants.pr_description_writer_gate_constants import (  # noqa: E402
     ALL_AGENT_SPAWN_TOOL_NAMES,
     PR_DESCRIPTION_WRITER_SUBAGENT_TYPE,
-    SPAWN_MARKER_FILE_PREFIX,
-    SPAWN_MARKER_FILE_SUFFIX,
     SUBAGENT_TYPE_FIELD_NAME,
     TOOL_INPUT_FIELD_NAME,
     TOOL_NAME_FIELD_NAME,
 )
+from hooks_constants.pr_description_writer_gate_constants import (  # noqa: E402
+    spawn_marker_path as shared_spawn_marker_path,
+)
 from hooks_constants.pre_tool_use_stdin import (  # noqa: E402
     read_hook_input_dictionary_from_stdin,
 )
-from hooks_constants.session_edit_stage_gate_constants import (  # noqa: E402
-    SESSION_ID_UNSAFE_CHARACTERS_PATTERN,
-)
 
 
 def spawn_marker_path(session_id: str, temp_directory: Path | None = None) -> Path | None:
@@ -70,12 +67,7 @@ def spawn_marker_path(session_id: str, temp_directory: Path | None = None) -> Pa
         Absolute path to this session's marker file, or None when the payload
         names no session this hook can key on.
     """
-    sanitized_session_id = SESSION_ID_UNSAFE_CHARACTERS_PATTERN.sub("", session_id)
-    if not sanitized_session_id:
-        return None
-    file_name = f"{SPAWN_MARKER_FILE_PREFIX}{sanitized_session_id}{SPAWN_MARKER_FILE_SUFFIX}"
-    resolved_temp_directory = temp_directory or Path(tempfile.gettempdir())
-    return resolved_temp_directory / file_name
+    return shared_spawn_marker_path(session_id, temp_directory)
 
 
 def _record_spawn(session_id: str) -> None:

package/hooks/observability/test_pr_description_writer_spawn_tracker.py

@@ -26,6 +26,10 @@ assert _TRACKER_SPEC.loader is not None
 tracker_module = importlib.util.module_from_spec(_TRACKER_SPEC)
 _TRACKER_SPEC.loader.exec_module(tracker_module)
 
+_GATE_CONSTANTS = importlib.import_module(
+    "hooks_constants.pr_description_writer_gate_constants"
+)
+
 _SESSION_ID = "session-abc123"
 _OTHER_SUBAGENT_TYPE = "general-purpose"
 
@@ -65,7 +69,7 @@ def _run_tracker(payload: dict[str, object], temp_directory: Path) -> None:
     """
     with mock.patch("sys.stdin", io.StringIO(json.dumps(payload))):
         with mock.patch.object(
-            tracker_module.tempfile, "gettempdir", return_value=str(temp_directory)
+            _GATE_CONSTANTS.tempfile, "gettempdir", return_value=str(temp_directory)
         ):
             tracker_module.main()
 
@@ -120,7 +124,7 @@ def should_record_twice_without_error(tmp_path: Path) -> None:
 def should_ignore_a_malformed_payload(tmp_path: Path) -> None:
     """Unparseable stdin records nothing and raises nothing."""
     with mock.patch("sys.stdin", io.StringIO("this is not json")):
-        with mock.patch.object(tracker_module.tempfile, "gettempdir", return_value=str(tmp_path)):
+        with mock.patch.object(_GATE_CONSTANTS.tempfile, "gettempdir", return_value=str(tmp_path)):
             tracker_module.main()
     assert list(tmp_path.iterdir()) == []
 

package/hooks/validators/abbreviation_checks.py

@@ -14,7 +14,7 @@ from pathlib import Path
 from typing import List
 
 from .config.abbreviation_checks_constants import ALL_ALLOWED_SINGLE_LETTERS
-from .validator_base import Violation
+from .validator_base import Violation, source_text, syntax_tree
 
 
 def check_single_letter_variables(tree: ast.AST, filename: str) -> List[Violation]:
@@ -39,13 +39,13 @@ def validate_file(file_path: Path) -> List[Violation]:
     filename = str(file_path)
 
     try:
-        source = file_path.read_text(encoding="utf-8")
+        source = source_text(file_path)
     except Exception as error:
         violations.append(Violation(filename, 0, f"Error reading file: {error}"))
         return violations
 
     try:
-        tree = ast.parse(source)
+        tree = syntax_tree(source)
     except SyntaxError as error:
         violations.append(
             Violation(filename, error.lineno or 0, f"Syntax error: {error.msg}")

package/hooks/validators/code_quality_checks.py

@@ -11,7 +11,7 @@ import sys
 from pathlib import Path
 from typing import List
 
-from .validator_base import Violation
+from .validator_base import Violation, source_text, syntax_tree
 
 
 MAX_FUNCTION_LINES = 30
@@ -75,7 +75,7 @@ def check_file_length(file_path: Path) -> List[Violation]:
     filename = str(file_path)
 
     try:
-        lines = file_path.read_text(encoding="utf-8").splitlines()
+        lines = source_text(file_path).splitlines()
     except Exception as error:
         return [Violation(filename, 0, f"Error reading file: {error}")]
 
@@ -98,8 +98,8 @@ def validate_file(file_path: Path) -> List[Violation]:
     violations.extend(check_file_length(file_path))
 
     try:
-        source = file_path.read_text(encoding="utf-8")
-        tree = ast.parse(source)
+        source = source_text(file_path)
+        tree = syntax_tree(source)
     except Exception as error:
         return violations + [Violation(filename, 0, f"Error: {error}")]
 

package/hooks/validators/config/baseline_identity_constants.py

@@ -0,0 +1,12 @@
+"""Patterns and placeholders the baseline gate masks a violation message with.
+
+Config files are exempt from the string-literal magic-value checks, so the
+regex fragments and the placeholder text the scope-agnostic message shape needs
+live here rather than inline in ``run_all_validators.py``.
+"""
+
+QUALIFIED_SCOPE_NAME_SEPARATOR = "."
+WORD_BOUNDARY_PATTERN = r"\b"
+STANDALONE_NUMBER_PATTERN = r"(?<![A-Za-z0-9_])\d+(?![A-Za-z0-9_])"
+SCOPE_NAME_PLACEHOLDER = "<name>"
+SHAPE_NUMBER_PLACEHOLDER = "<number>"

package/hooks/validators/config/directory_exemption_constants.py

@@ -7,7 +7,9 @@ siblings). Exact names come from the authoritative path-exemption pattern sets
 and CLI markers, unioned with the config-directory allowlist. Substring
 patterns come from the separator-free members of those same pattern sets so a
 directory such as ``pkg/test_helpers/`` stages with the same test exemption as
-the real path.
+the real path. Directories pytest generates for its own scratch tree are
+recognized by name and contribute no signal, whatever ``--basetemp`` they sit
+under.
 """
 
 from __future__ import annotations
@@ -27,6 +29,15 @@ from ..exempt_paths import (
 POSIX_DIRECTORY_SEPARATOR = "/"
 WINDOWS_DIRECTORY_SEPARATOR = "\\"
 
+PYTEST_TEMPORARY_ROOT_NAME_PREFIX = "pytest-"
+DECIMAL_DIGIT_CHARACTERS = "0123456789"
+LOWERCASE_ASCII_LETTER_CHARACTERS = "abcdefghijklmnopqrstuvwxyz"
+UNDERSCORE_CHARACTER = "_"
+PYTEST_SANITIZED_TEST_NAME_LENGTH_LIMIT = 30
+ALL_PYTEST_SANITIZED_TEST_NAME_CHARACTERS: frozenset[str] = frozenset(
+    LOWERCASE_ASCII_LETTER_CHARACTERS + DECIMAL_DIGIT_CHARACTERS + UNDERSCORE_CHARACTER
+)
+
 ALL_SYSTEM_TEMPORARY_ROOT_ENVIRONMENT_VARIABLE_NAMES: frozenset[str] = frozenset(
     {
         "TEMP",
@@ -68,6 +79,38 @@ def is_filename_like_path_segment(path_segment: str) -> bool:
     return "." in path_segment
 
 
+def is_pytest_scratch_directory_segment(segment_lower: str) -> bool:
+    """Return True when *segment_lower* is a directory pytest itself created.
+
+    ::
+
+        is_pytest_scratch_directory_segment("test_drops_leading_anchor0")  # True
+        is_pytest_scratch_directory_segment("pytest-of-root")  # True
+        is_pytest_scratch_directory_segment("test_helpers")  # False
+
+    ``TempPathFactory`` names its roots ``pytest-of-<user>`` and ``pytest-<n>``, and
+    each per-test directory as a length-capped test-name stem with a number appended.
+    Those generated names carry ``test_`` without naming a real project directory.
+
+    Args:
+        segment_lower: One lowercased directory component of a target path.
+
+    Returns:
+        True when pytest generated the segment rather than the project.
+    """
+    if segment_lower.startswith(PYTEST_TEMPORARY_ROOT_NAME_PREFIX):
+        return True
+    sanitized_test_name = segment_lower.rstrip(DECIMAL_DIGIT_CHARACTERS)
+    if not sanitized_test_name or sanitized_test_name == segment_lower:
+        return False
+    if len(sanitized_test_name) > PYTEST_SANITIZED_TEST_NAME_LENGTH_LIMIT:
+        return False
+    return all(
+        each_character in ALL_PYTEST_SANITIZED_TEST_NAME_CHARACTERS
+        for each_character in sanitized_test_name
+    )
+
+
 def all_directory_segments_in_path_pattern(path_pattern: str) -> list[str]:
     """Return lowercased directory tokens from one path-exemption pattern.
 

package/hooks/validators/config/validator_base_constants.py

@@ -0,0 +1,9 @@
+"""Constants for the shared source reader and parser in validator_base."""
+
+from __future__ import annotations
+
+# One save validates one file, so a handful of entries covers a run and keeps
+# a long-lived CLI pass from holding every file it ever read.
+SOURCE_CACHE_ENTRIES: int = 8
+
+SOURCE_ENCODING: str = "utf-8"

package/hooks/validators/fast_save_validators.py

@@ -45,6 +45,7 @@ from .test_safety_checks import (
 from .todo_checks import validate_file as validate_todo_file
 from .type_safety_checks import validate_file as validate_type_safety_file
 from .useless_test_checks import validate_file as validate_useless_test_file
+from .validator_base import ValidatorResult
 
 FilePredicate = Callable[[Path], bool]
 FileViolationLineCollector = Callable[[Path], "list[str]"]
@@ -76,21 +77,6 @@ def _violation_lines_from(raw_validate_file: _RawFileValidator) -> FileViolation
     return _collect
 
 
-@dataclass(frozen=True)
-class FastSaveCheckOutcome:
-    """One save-path check's finding.
-
-    The caller wraps this into its own reporting type. This module never
-    imports that type back, so no circular import exists between the two
-    modules.
-    """
-
-    display_name: str
-    checks: str
-    is_clean: bool
-    violation_report: str
-
-
 def _is_python_file(file_path: Path) -> bool:
     return file_path.suffix == PYTHON_SOURCE_SUFFIX
 
@@ -122,15 +108,10 @@ def _collect_test_safety_violation_lines(file_path: Path) -> "list[str]":
 
 
 def _collect_react_violation_lines(file_path: Path) -> "list[str]":
-    """Adapt react_checks's whole-batch ``check_no_class_components`` to one file.
-
-    react_checks.Violation carries no ``__str__`` override, so this formats
-    each violation the same way react_checks's own ``main`` prints one.
-    """
-    all_violations = check_no_class_components([str(file_path)])
+    """Adapt react_checks's whole-batch ``check_no_class_components`` to one file."""
     return [
-        f"{each_violation.file}:{each_violation.line}: {each_violation.message}"
-        for each_violation in all_violations
+        str(each_violation)
+        for each_violation in check_no_class_components([str(file_path)])
     ]
 
 
@@ -145,11 +126,12 @@ class _FastSaveValidatorSpecification:
     no_matching_files_message: str
 
 
-def _python_naming_and_syntax_specifications() -> (
-    "list[_FastSaveValidatorSpecification]"
+def _all_fast_save_validator_specifications() -> (
+    "tuple[_FastSaveValidatorSpecification, ...]"
 ):
-    """Return the save-path checks for Python naming, style, and constants."""
-    return [
+    """Return the save-path roster: every non-Mypy, non-Ruff file-scoped check."""
+    return (
+        # Python naming, style, and constants.
         _FastSaveValidatorSpecification(
             "Python Style",
             "1,2,3,4",
@@ -171,14 +153,7 @@ def _python_naming_and_syntax_specifications() -> (
             _violation_lines_from(validate_magic_literal_file),
             NO_PYTHON_FILES_MESSAGE,
         ),
-    ]
-
-
-def _python_quality_and_tracking_specifications() -> (
-    "list[_FastSaveValidatorSpecification]"
-):
-    """Return the save-path checks for Python code quality and TODO tracking."""
-    return [
+        # Python code quality and TODO tracking.
         _FastSaveValidatorSpecification(
             "TODO Tracking",
             "36",
@@ -200,14 +175,7 @@ def _python_quality_and_tracking_specifications() -> (
             _violation_lines_from(validate_code_quality_file),
             NO_PYTHON_FILES_MESSAGE,
         ),
-    ]
-
-
-def _python_safety_and_typing_specifications() -> (
-    "list[_FastSaveValidatorSpecification]"
-):
-    """Return the save-path checks for Python anti-patterns and typing."""
-    return [
+        # Python anti-patterns and typing.
         _FastSaveValidatorSpecification(
             "Python Anti-patterns",
             "33,34,35",
@@ -222,12 +190,7 @@ def _python_safety_and_typing_specifications() -> (
             _violation_lines_from(validate_type_safety_file),
             NO_PYTHON_FILES_MESSAGE,
         ),
-    ]
-
-
-def _test_scoped_fast_save_specifications() -> "list[_FastSaveValidatorSpecification]":
-    """Return the save-path checks scoped to a ``test_*.py``-shaped file."""
-    return [
+        # Scoped to a test_*.py-shaped file.
         _FastSaveValidatorSpecification(
             "Test Safety",
             "11,21",
@@ -242,14 +205,7 @@ def _test_scoped_fast_save_specifications() -> "list[_FastSaveValidatorSpecifica
             _violation_lines_from(validate_useless_test_file),
             NO_TEST_FILES_MESSAGE,
         ),
-    ]
-
-
-def _cross_language_fast_save_specifications() -> (
-    "list[_FastSaveValidatorSpecification]"
-):
-    """Return the save-path checks that read a non-Python or multi-language file."""
-    return [
+        # Non-Python or multi-language files.
         _FastSaveValidatorSpecification(
             "React",
             "17",
@@ -264,39 +220,26 @@ def _cross_language_fast_save_specifications() -> (
             _violation_lines_from(validate_pr_reference_file),
             NO_CODE_REFERENCE_FILES_MESSAGE,
         ),
-    ]
-
-
-def _all_fast_save_validator_specifications() -> (
-    "list[_FastSaveValidatorSpecification]"
-):
-    """Return the save-path roster: every non-Mypy, non-Ruff file-scoped check."""
-    return [
-        *_python_naming_and_syntax_specifications(),
-        *_python_quality_and_tracking_specifications(),
-        *_python_safety_and_typing_specifications(),
-        *_test_scoped_fast_save_specifications(),
-        *_cross_language_fast_save_specifications(),
-    ]
+    )
 
 
 def _fast_save_outcome(
     specification: _FastSaveValidatorSpecification,
     is_clean: bool,
     violation_report: str,
-) -> FastSaveCheckOutcome:
-    """Build one outcome from a specification's display name and check numbers."""
-    return FastSaveCheckOutcome(
-        display_name=specification.display_name,
+) -> ValidatorResult:
+    """Build one result from a specification's display name and check numbers."""
+    return ValidatorResult(
+        name=specification.display_name,
         checks=specification.checks,
-        is_clean=is_clean,
-        violation_report=violation_report,
+        passed=is_clean,
+        output=violation_report,
     )
 
 
 def _run_specification(
     specification: _FastSaveValidatorSpecification, files: "list[Path]"
-) -> FastSaveCheckOutcome:
+) -> ValidatorResult:
     """Run one validator's violation collector in-process over its matching files."""
     matching_files = [
         each_file for each_file in files if specification.applies_to_file(each_file)
@@ -316,14 +259,14 @@ def _run_specification(
     return _fast_save_outcome(specification, False, violation_report)
 
 
-def run_fast_save_validators(files: "list[Path]") -> "list[FastSaveCheckOutcome]":
+def run_fast_save_validators(files: "list[Path]") -> "list[ValidatorResult]":
     """Run every save-path validator in-process, skipping Mypy and Ruff.
 
     Args:
         files: The files under validation -- one reconstructed file in gate mode.
 
     Returns:
-        One outcome per in-process validator, in roster order. The caller adds
+        One result per in-process validator, in roster order. The caller adds
         Ruff and never adds Mypy.
     """
     return [

package/hooks/validators/pr_reference_checks.py

@@ -9,7 +9,7 @@ import sys
 from pathlib import Path
 from typing import List
 
-from .validator_base import Violation
+from .validator_base import Violation, source_text
 
 
 PR_PATTERN = re.compile(r"#.*\bPR\s*#?\d+", re.IGNORECASE)
@@ -42,7 +42,7 @@ def check_pr_references(source: str, filename: str) -> List[Violation]:
 def validate_file(file_path: Path) -> List[Violation]:
     filename = str(file_path)
     try:
-        source = file_path.read_text(encoding="utf-8")
+        source = source_text(file_path)
     except Exception as error:
         return [Violation(filename, 0, f"Error reading file: {error}")]
 

package/hooks/validators/python_antipattern_checks.py

@@ -11,7 +11,7 @@ import sys
 from pathlib import Path
 from typing import List
 
-from .validator_base import Violation
+from .validator_base import Violation, source_text, syntax_tree
 
 _hooks_directory = str(Path(__file__).resolve().parent.parent)
 
@@ -90,8 +90,8 @@ def validate_file(file_path: Path) -> List[Violation]:
     filename = str(file_path)
 
     try:
-        source = file_path.read_text(encoding="utf-8")
-        tree = ast.parse(source)
+        source = source_text(file_path)
+        tree = syntax_tree(source)
     except Exception as error:
         return [Violation(filename, 0, f"Error: {error}")]
 

package/hooks/validators/python_style_checks.py

@@ -21,6 +21,7 @@ from hooks_constants.python_style_checks_constants import (  # noqa: E402
     EXPECTED_BLANK_LINES_BETWEEN_FUNCTIONS,
     MINIMUM_ARGUMENT_COUNT,
 )
+from validators.validator_base import source_text, syntax_tree  # noqa: E402
 from validators.python_style_helpers import (  # noqa: E402
     FunctionNode,
     blank_line_for_source,
@@ -331,12 +332,12 @@ def validate_file(file_path: Path) -> list[Violation]:
     violations: list[Violation] = []
     filename = str(file_path)
     try:
-        source = file_path.read_text(encoding="utf-8")
+        source = source_text(file_path)
     except Exception as error:
         violations.append(Violation(filename, 0, f"Error reading file: {error}"))
         return violations
     try:
-        tree = ast.parse(source)
+        tree = syntax_tree(source)
     except SyntaxError as error:
         violations.append(
             Violation(filename, error.lineno or 0, f"Syntax error: {error.msg}")

package/hooks/validators/react_checks.py

@@ -7,16 +7,9 @@ Validates React-specific code standards:
 
 import re
 import sys
-from dataclasses import dataclass
 from pathlib import Path
 
-
-@dataclass(frozen=True)
-class Violation:
-    """Represents a validation violation."""
-    file: str
-    line: int
-    message: str
+from .validator_base import Violation
 
 
 CLASS_COMPONENT_PATTERN = re.compile(
@@ -81,7 +74,7 @@ def main() -> int:
     violations = check_no_class_components(file_paths)
 
     for violation in violations:
-        print(f"{violation.file}:{violation.line}: {violation.message}")
+        print(violation)
 
     return 1 if violations else 0