claude-dev-env 2.3.0 → 2.5.0

package/hooks/blocking/test_verified_commit_message_accuracy_blocker.py

@@ -1,131 +1,131 @@
-"""Unit tests for the verified-commit-message-accuracy PreToolUse hook."""
-
-import importlib.util
-import pathlib
-import sys
-
-_HOOK_DIR = pathlib.Path(__file__).parent
-if str(_HOOK_DIR) not in sys.path:
-    sys.path.insert(0, str(_HOOK_DIR))
-
-hook_spec = importlib.util.spec_from_file_location(
-    "verified_commit_message_accuracy_blocker",
-    _HOOK_DIR / "verified_commit_message_accuracy_blocker.py",
-)
-assert hook_spec is not None
-assert hook_spec.loader is not None
-hook_module = importlib.util.module_from_spec(hook_spec)
-hook_spec.loader.exec_module(hook_module)
-is_guarded_file = hook_module.is_guarded_file
-claims_blanket_comment_exemption = hook_module.claims_blanket_comment_exemption
-extract_written_text = hook_module.extract_written_text
-build_corrective_message = hook_module.build_corrective_message
-
-OFFENDING_MESSAGE = (
-    "CORRECTIVE_MESSAGE = (\n"
-    '    "BLOCKED: [VERIFIED_COMMIT_GATE] This branch surface has no passing "\n'
-    '    "verification verdict. Spawn the code-verifier agent (Agent tool, "\n'
-    "    \"subagent_type 'code-verifier') with the task texts, the diff scope, \"\n"
-    '    "and recorded baselines; when it finishes with a clean verdict the "\n'
-    '    "SubagentStop hook mints the verdict and this command will pass. Any "\n'
-    '    "file change after verification invalidates the verdict, so verify "\n'
-    '    "last. Docs-, docstring-, comment-, and test-only surfaces are exempt "\n'
-    '    "automatically."\n'
-    ")\n"
-)
-ACCURATE_DOCS_EXEMPTION_MENTIONING_COMMENTS = (
-    "Comments inside Python files are stripped; docs are exempt "
-    "automatically by extension."
-)
-ACCURATE_MESSAGE = (
-    "CORRECTIVE_MESSAGE = (\n"
-    '    "BLOCKED: [VERIFIED_COMMIT_GATE] ... Docs and images are exempt by "\n'
-    '    "extension, and Python files whose docstring- and comment-stripped AST "\n'
-    '    "is unchanged."\n'
-    ")\n"
-)
-
-
-def test_constants_file_is_guarded() -> None:
-    assert is_guarded_file(
-        "/repo/.claude/hooks/blocking/config/verified_commit_constants.py"
-    )
-
-
-def test_unrelated_file_is_not_guarded() -> None:
-    assert not is_guarded_file("/repo/.claude/hooks/blocking/gh_body_arg_blocker.py")
-
-
-def test_blanket_comment_exemption_claim_is_detected() -> None:
-    assert claims_blanket_comment_exemption(OFFENDING_MESSAGE)
-
-
-def test_blanket_claim_detected_regardless_of_leading_words() -> None:
-    assert claims_blanket_comment_exemption(
-        "Comment-only surfaces are exempt automatically."
-    )
-
-
-def test_accurate_exemption_wording_passes() -> None:
-    assert not claims_blanket_comment_exemption(ACCURATE_MESSAGE)
-
-
-def test_accurate_docs_exemption_mentioning_comments_passes() -> None:
-    assert not claims_blanket_comment_exemption(
-        ACCURATE_DOCS_EXEMPTION_MENTIONING_COMMENTS
-    )
-
-
-def test_comma_joined_docs_exemption_mentioning_comments_passes() -> None:
-    assert not claims_blanket_comment_exemption(
-        "Comments are handled, and docs are exempt automatically."
-    )
-
-
-def test_python_ast_clause_mentioning_comments_passes() -> None:
-    assert not claims_blanket_comment_exemption(
-        "Python comment-stripped AST changes and docs are exempt automatically "
-        "by extension"
-    )
-
-
-def test_single_clause_python_ast_exemption_passes() -> None:
-    assert not claims_blanket_comment_exemption(
-        "Python files whose comment-stripped AST is unchanged are exempt "
-        "automatically."
-    )
-
-
-def test_commentary_word_stem_passes() -> None:
-    assert not claims_blanket_comment_exemption(
-        "Our commentary on the approach is exempt automatically from blame."
-    )
-
-
-def test_corrective_message_names_only_the_two_real_exemptions() -> None:
-    corrective_message = build_corrective_message()
-    assert "exempt by extension" in corrective_message
-    assert "docstring- and comment-stripped AST" in corrective_message
-    assert "test file" not in corrective_message
-    assert "by name convention" not in corrective_message
-
-
-def test_message_without_exemption_claim_passes() -> None:
-    assert not claims_blanket_comment_exemption(
-        'CORRECTIVE_MESSAGE = "Spawn the code-verifier agent to earn a verdict."'
-    )
-
-
-def test_write_content_is_extracted() -> None:
-    written_text = extract_written_text({"content": OFFENDING_MESSAGE})
-    assert claims_blanket_comment_exemption(written_text)
-
-
-def test_edit_new_string_is_extracted() -> None:
-    written_text = extract_written_text({"new_string": OFFENDING_MESSAGE})
-    assert claims_blanket_comment_exemption(written_text)
-
-
-def test_edit_new_string_with_accurate_wording_is_clean() -> None:
-    written_text = extract_written_text({"new_string": ACCURATE_MESSAGE})
-    assert not claims_blanket_comment_exemption(written_text)
+"""Unit tests for the verified-commit-message-accuracy PreToolUse hook."""
+
+import importlib.util
+import pathlib
+import sys
+
+_HOOK_DIR = pathlib.Path(__file__).parent
+if str(_HOOK_DIR) not in sys.path:
+    sys.path.insert(0, str(_HOOK_DIR))
+
+hook_spec = importlib.util.spec_from_file_location(
+    "verified_commit_message_accuracy_blocker",
+    _HOOK_DIR / "verified_commit_message_accuracy_blocker.py",
+)
+assert hook_spec is not None
+assert hook_spec.loader is not None
+hook_module = importlib.util.module_from_spec(hook_spec)
+hook_spec.loader.exec_module(hook_module)
+is_guarded_file = hook_module.is_guarded_file
+claims_blanket_comment_exemption = hook_module.claims_blanket_comment_exemption
+extract_written_text = hook_module.extract_written_text
+build_corrective_message = hook_module.build_corrective_message
+
+OFFENDING_MESSAGE = (
+    "CORRECTIVE_MESSAGE = (\n"
+    '    "BLOCKED: [VERIFIED_COMMIT_GATE] This branch surface has no passing "\n'
+    '    "verification verdict. Spawn the code-verifier agent (Agent tool, "\n'
+    "    \"subagent_type 'code-verifier') with the task texts, the diff scope, \"\n"
+    '    "and recorded baselines; when it finishes with a clean verdict the "\n'
+    '    "SubagentStop hook mints the verdict and this command will pass. Any "\n'
+    '    "file change after verification invalidates the verdict, so verify "\n'
+    '    "last. Docs-, docstring-, comment-, and test-only surfaces are exempt "\n'
+    '    "automatically."\n'
+    ")\n"
+)
+ACCURATE_DOCS_EXEMPTION_MENTIONING_COMMENTS = (
+    "Comments inside Python files are stripped; docs are exempt "
+    "automatically by extension."
+)
+ACCURATE_MESSAGE = (
+    "CORRECTIVE_MESSAGE = (\n"
+    '    "BLOCKED: [VERIFIED_COMMIT_GATE] ... Docs and images are exempt by "\n'
+    '    "extension, and Python files whose docstring- and comment-stripped AST "\n'
+    '    "is unchanged."\n'
+    ")\n"
+)
+
+
+def test_constants_file_is_guarded() -> None:
+    assert is_guarded_file(
+        "/repo/.claude/hooks/blocking/config/verified_commit_constants.py"
+    )
+
+
+def test_unrelated_file_is_not_guarded() -> None:
+    assert not is_guarded_file("/repo/.claude/hooks/blocking/gh_body_arg_blocker.py")
+
+
+def test_blanket_comment_exemption_claim_is_detected() -> None:
+    assert claims_blanket_comment_exemption(OFFENDING_MESSAGE)
+
+
+def test_blanket_claim_detected_regardless_of_leading_words() -> None:
+    assert claims_blanket_comment_exemption(
+        "Comment-only surfaces are exempt automatically."
+    )
+
+
+def test_accurate_exemption_wording_passes() -> None:
+    assert not claims_blanket_comment_exemption(ACCURATE_MESSAGE)
+
+
+def test_accurate_docs_exemption_mentioning_comments_passes() -> None:
+    assert not claims_blanket_comment_exemption(
+        ACCURATE_DOCS_EXEMPTION_MENTIONING_COMMENTS
+    )
+
+
+def test_comma_joined_docs_exemption_mentioning_comments_passes() -> None:
+    assert not claims_blanket_comment_exemption(
+        "Comments are handled, and docs are exempt automatically."
+    )
+
+
+def test_python_ast_clause_mentioning_comments_passes() -> None:
+    assert not claims_blanket_comment_exemption(
+        "Python comment-stripped AST changes and docs are exempt automatically "
+        "by extension"
+    )
+
+
+def test_single_clause_python_ast_exemption_passes() -> None:
+    assert not claims_blanket_comment_exemption(
+        "Python files whose comment-stripped AST is unchanged are exempt "
+        "automatically."
+    )
+
+
+def test_commentary_word_stem_passes() -> None:
+    assert not claims_blanket_comment_exemption(
+        "Our commentary on the approach is exempt automatically from blame."
+    )
+
+
+def test_corrective_message_names_only_the_two_real_exemptions() -> None:
+    corrective_message = build_corrective_message()
+    assert "exempt by extension" in corrective_message
+    assert "docstring- and comment-stripped AST" in corrective_message
+    assert "test file" not in corrective_message
+    assert "by name convention" not in corrective_message
+
+
+def test_message_without_exemption_claim_passes() -> None:
+    assert not claims_blanket_comment_exemption(
+        'CORRECTIVE_MESSAGE = "Spawn the code-verifier agent to earn a verdict."'
+    )
+
+
+def test_write_content_is_extracted() -> None:
+    written_text = extract_written_text({"content": OFFENDING_MESSAGE})
+    assert claims_blanket_comment_exemption(written_text)
+
+
+def test_edit_new_string_is_extracted() -> None:
+    written_text = extract_written_text({"new_string": OFFENDING_MESSAGE})
+    assert claims_blanket_comment_exemption(written_text)
+
+
+def test_edit_new_string_with_accurate_wording_is_clean() -> None:
+    written_text = extract_written_text({"new_string": ACCURATE_MESSAGE})
+    assert not claims_blanket_comment_exemption(written_text)

package/hooks/blocking/test_volatile_path_in_post_blocker.py

@@ -41,7 +41,7 @@ def test_scan_detects_job_scratch_path_forward_slash() -> None:
 
 
 def test_scan_detects_worktree_path() -> None:
-    text = r"edited .claude\worktrees\feature\file.py"
+    text = r"edited C:\Users\me\.claude\worktrees\feature\file.py"
     assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
 
 
@@ -71,6 +71,103 @@ def test_scan_clean_body_returns_none() -> None:
     assert scan_text_for_volatile_marker(text) is None
 
 
+def test_scan_bare_backticked_worktree_mention_is_allowed() -> None:
+    text = "the `.claude/worktrees/` prefix sits in ALL_TOOLING_STATE_PREFIXES"
+    assert scan_text_for_volatile_marker(text) is None
+
+
+def test_scan_bare_start_of_text_worktree_mention_is_allowed() -> None:
+    text = ".claude/worktrees/ entries are skipped by the manifest"
+    assert scan_text_for_volatile_marker(text) is None
+
+
+def test_scan_windows_absolute_worktree_path_is_detected() -> None:
+    text = r"C:\Users\me\.claude\worktrees\wt-1\notes.md"
+    assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
+
+
+def test_scan_home_anchored_worktree_path_is_detected() -> None:
+    text = "~/.claude/worktrees/wt-2/file.py"
+    assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
+
+
+def test_scan_posix_absolute_job_scratch_path_is_detected() -> None:
+    text = "/home/me/.claude-editor/jobs/j1/log.txt"
+    assert scan_text_for_volatile_marker(text) == ".claude-editor/jobs/"
+
+
+def test_scan_bare_parenthesized_job_scratch_mention_is_allowed() -> None:
+    text = "(.claude-editor/jobs/) as a directory name in prose"
+    assert scan_text_for_volatile_marker(text) is None
+
+
+def test_scan_bare_mention_before_anchored_path_is_detected() -> None:
+    text = (
+        ".claude/worktrees/ is the manifest key; the live path is "
+        r"C:\Users\me\.claude\worktrees\wt-1\notes.md"
+    )
+    assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
+
+
+def test_scan_unchanged_bare_markers_still_detected() -> None:
+    assert scan_text_for_volatile_marker(r"saved to %TEMP%\x") == "%temp%"
+    assert scan_text_for_volatile_marker("log at /tmp/x") == "/tmp/"
+    assert (
+        scan_text_for_volatile_marker(r"C:\Users\x\AppData\Local\Temp\y")
+        == "appdata/local/temp"
+    )
+
+
+def test_scan_space_prefixed_relative_worktree_path_is_detected() -> None:
+    text = "see .claude/worktrees/wt-1/notes.md"
+    assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
+
+
+def test_scan_cd_relative_worktree_path_is_detected() -> None:
+    text = "cd .claude/worktrees/wt-199 && pytest"
+    assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
+
+
+def test_scan_start_of_text_relative_worktree_path_is_detected() -> None:
+    text = ".claude/worktrees/wt-1/notes.md"
+    assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
+
+
+def test_scan_markdown_link_relative_worktree_target_is_detected() -> None:
+    text = "[notes](.claude/worktrees/wt-1/notes.md)"
+    assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
+
+
+def test_scan_space_prefixed_relative_job_scratch_path_is_detected() -> None:
+    text = "see .claude-editor/jobs/j1/log.txt"
+    assert scan_text_for_volatile_marker(text) == ".claude-editor/jobs/"
+
+
+def test_scan_backslash_relative_worktree_path_is_detected() -> None:
+    text = r"see .claude\worktrees\wt-1\notes.md"
+    assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
+
+
+def test_scan_prose_child_token_after_marker_is_detected() -> None:
+    text = "the .claude/worktrees/wt-name pattern"
+    assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
+
+
+def test_scan_relative_worktree_path_with_hyphen_child_is_detected() -> None:
+    text = "see .claude/worktrees/-scratch/notes.md"
+    assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
+
+
+def test_scan_placeholder_child_segment_is_allowed() -> None:
+    text = "worktrees live under `.claude/worktrees/<name>`"
+    assert scan_text_for_volatile_marker(text) is None
+
+
+def test_scan_sentence_final_marker_period_is_allowed() -> None:
+    text = "the constant is `.claude/worktrees/`. Next."
+    assert scan_text_for_volatile_marker(text) is None
+
+
 def test_gh_comment_with_job_scratch_path_is_blocked() -> None:
     command = (
         'gh pr comment 669 --body "Contact sheet at '
@@ -147,7 +244,7 @@ def test_mcp_issue_comment_body_blocked() -> None:
 
 
 def test_mcp_review_comment_param_blocked() -> None:
-    tool_input: dict[str, object] = {"comment": r"see .claude\worktrees\x\file"}
+    tool_input: dict[str, object] = {"comment": r"see C:\Users\me\.claude\worktrees\x\file"}
     assert _body_names_volatile_path(
         "mcp__plugin_github_github__add_reply_to_pull_request_comment", tool_input
     )
@@ -177,6 +274,21 @@ def test_extract_gh_post_body_texts_returns_inline_and_file(tmp_path: pathlib.Pa
     assert "file body text" in all_texts
 
 
+def test_gh_issue_edit_quoting_bare_constant_is_allowed(tmp_path: pathlib.Path) -> None:
+    body_file = tmp_path / "issue_body.md"
+    body_file.write_text(
+        "The manifest skips these tooling-state prefixes:\n"
+        '    ".claude/worktrees/",\n'
+        '    ".claude-editor/jobs/",\n'
+        "Neither is a machine-local path.",
+        encoding="utf-8",
+    )
+    command = f"gh issue edit 134 --body-file {body_file}"
+    all_body_texts = extract_gh_post_body_texts(command)
+    assert all_body_texts
+    assert hook_module._first_volatile_marker(all_body_texts) is None
+
+
 def test_hook_subprocess_denies_volatile_gh_comment() -> None:
     payload = {
         "tool_name": "Bash",