claude-dev-env 2.12.0 → 2.14.0

package/hooks/diagnostic/test_hook_log_stop_wrapper.py

@@ -1,345 +1,17 @@
-"""Tests for hook_log_stop_wrapper -- debounced, fire-and-forget Stop hook."""
+"""Tests for the disabled hook_log_stop_wrapper Stop hook."""
 
 from __future__ import annotations
 
-import os
-import subprocess
 import sys
-import time
 from pathlib import Path
 
-import pytest
-
 _HOOKS_ROOT = Path(__file__).resolve().parent.parent
 if str(_HOOKS_ROOT) not in sys.path:
     sys.path.insert(0, str(_HOOKS_ROOT))
 
 from diagnostic import hook_log_stop_wrapper
-from hooks_constants.hook_log_extractor_constants import (
-    BWS_ACCESS_TOKEN_ENV_VAR,
-    BWS_EXECUTABLE_NAME,
-    FLAG_INCREMENTAL,
-    STOP_WRAPPER_DEBOUNCE_SECONDS,
-)
-
-
-def _redirect_timestamp_path(
-    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
-) -> Path:
-    timestamp_file = tmp_path / "stop_wrapper_last_run.txt"
-    monkeypatch.setattr(
-        hook_log_stop_wrapper,
-        "_last_run_timestamp_path",
-        lambda: timestamp_file,
-    )
-    return timestamp_file
-
-
-def test_main_returns_zero_when_extractor_spawn_raises(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    def _raise(*_args: object, **_kwargs: object) -> None:
-        raise RuntimeError("boom")
 
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _raise)
 
+def test_main_returns_zero_without_side_effects() -> None:
+    """Disabled main exits success and does no work."""
     assert hook_log_stop_wrapper.main() == 0
-    assert not timestamp_file.exists()
-
-
-def test_main_writes_timestamp_before_spawn_to_narrow_toctou_window(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    timestamp_file_existed_at_spawn_time: list[bool] = []
-
-    def _capture_timestamp_state(*_args: object, **_kwargs: object) -> object:
-        timestamp_file_existed_at_spawn_time.append(timestamp_file.exists())
-        return object()
-
-    monkeypatch.setattr(
-        hook_log_stop_wrapper.subprocess, "Popen", _capture_timestamp_state
-    )
-
-    hook_log_stop_wrapper.main()
-
-    assert timestamp_file_existed_at_spawn_time == [True]
-
-
-def test_main_removes_timestamp_when_spawn_fails_to_allow_retry(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    timestamp_file.parent.mkdir(parents=True, exist_ok=True)
-    stale_timestamp = time.time() - STOP_WRAPPER_DEBOUNCE_SECONDS - 1
-    timestamp_file.write_text(str(stale_timestamp))
-
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    def _raise(*_args: object, **_kwargs: object) -> None:
-        raise RuntimeError("boom")
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _raise)
-
-    assert hook_log_stop_wrapper.main() == 0
-    assert not timestamp_file.exists()
-
-
-def test_main_uses_bws_when_token_and_binary_present(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.setenv(BWS_ACCESS_TOKEN_ENV_VAR, "secret-value")
-    monkeypatch.setattr(
-        hook_log_stop_wrapper.shutil,
-        "which",
-        lambda _name: "/usr/local/bin/bws",
-    )
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-    assert captured_commands[0][0] == BWS_EXECUTABLE_NAME
-    assert FLAG_INCREMENTAL in captured_commands[0]
-
-
-def test_main_skips_bws_when_token_missing(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(
-        hook_log_stop_wrapper.shutil,
-        "which",
-        lambda _name: "/usr/local/bin/bws",
-    )
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-    assert BWS_EXECUTABLE_NAME not in captured_commands[0]
-
-
-def test_main_skips_bws_when_binary_missing(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.setenv(BWS_ACCESS_TOKEN_ENV_VAR, "secret-value")
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-    assert BWS_EXECUTABLE_NAME not in captured_commands[0]
-
-
-def test_main_skips_spawn_when_recent_timestamp_within_debounce_window(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    timestamp_file.parent.mkdir(parents=True, exist_ok=True)
-    timestamp_file.write_text(str(time.time()))
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 0
-
-
-def test_main_spawns_when_timestamp_older_than_debounce_window(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    timestamp_file.parent.mkdir(parents=True, exist_ok=True)
-    stale_timestamp = time.time() - STOP_WRAPPER_DEBOUNCE_SECONDS - 1
-    timestamp_file.write_text(str(stale_timestamp))
-
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-
-
-def test_main_writes_current_timestamp_to_file(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-    monkeypatch.setattr(
-        hook_log_stop_wrapper.subprocess,
-        "Popen",
-        lambda *_args, **_kwargs: object(),
-    )
-
-    timestamp_before_call = time.time()
-    hook_log_stop_wrapper.main()
-    timestamp_after_call = time.time()
-
-    assert timestamp_file.exists()
-    written_timestamp = float(timestamp_file.read_text().strip())
-    assert timestamp_before_call <= written_timestamp <= timestamp_after_call
-
-
-def test_main_passes_devnull_streams_to_detached_spawn(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_kwargs: dict[str, object] = {}
-
-    def _fake_popen(command_list: list[str], **kwargs: object) -> object:
-        captured_kwargs.update(kwargs)
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    hook_log_stop_wrapper.main()
-
-    assert captured_kwargs.get("stdin") is hook_log_stop_wrapper.subprocess.DEVNULL
-    assert captured_kwargs.get("stdout") is hook_log_stop_wrapper.subprocess.DEVNULL
-    assert captured_kwargs.get("stderr") is hook_log_stop_wrapper.subprocess.DEVNULL
-
-
-def test_main_recovers_when_timestamp_file_is_corrupted(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    timestamp_file.parent.mkdir(parents=True, exist_ok=True)
-    timestamp_file.write_text("not-a-float")
-
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-
-
-def test_main_treats_future_timestamp_as_not_debounced(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    timestamp_file.parent.mkdir(parents=True, exist_ok=True)
-    far_future_timestamp = time.time() + 3600
-    timestamp_file.write_text(str(far_future_timestamp))
-
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-
-
-def test_main_passes_hidden_startupinfo_on_windows(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_kwargs: dict[str, object] = {}
-
-    def _fake_popen(command_list: list[str], **kwargs: object) -> object:
-        captured_kwargs.update(kwargs)
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    hook_log_stop_wrapper.main()
-
-    if os.name == "nt":
-        startup_info = captured_kwargs.get("startupinfo")
-        assert startup_info is not None
-        assert startup_info.dwFlags & subprocess.STARTF_USESHOWWINDOW
-        assert startup_info.wShowWindow == subprocess.SW_HIDE
-    else:
-        assert captured_kwargs.get("start_new_session") is True

package/hooks/git-hooks/AGENTS.md

@@ -0,0 +1,31 @@
+# hooks/git-hooks
+
+Native git hooks that run outside the Claude Code lifecycle — invoked directly by git at commit and push time. The installer copies these scripts into the user's shared git-hooks directory (`core.hooksPath`).
+
+## Key files
+
+| File | Git hook | What it does |
+|---|---|---|
+| `pre_commit.py` | `pre-commit` | Runs the CODE_RULES gate (`precommit_code_rules_gate.py`) over staged changes; exits 1 when any staged file has a blocking violation |
+| `pre_push.py` | `pre-push` | Blocks a push that would land a non-`main` local branch onto remote `main` (or `master`), then runs the CODE_RULES gate. An existing branch's gate base is the merge base with the remote default branch; the gate process still diffs that base against checkout HEAD, so the surface matches the pushed tip only when HEAD is that tip. |
+| `pre_push_base_reference.py` | — | Resolves a usable gate base for `pre_push.py`: reads the pushed remote name from git's arguments, then turns a symbolic default-branch head into a reference that git can resolve |
+| `post_commit.py` | `post-commit` | Runs after a commit lands; performs any post-commit bookkeeping |
+| `gate_utils.py` | — | Shared helpers: resolves the gate script path, checks that the path is a safe regular file |
+| `test_config.py` | — | Test configuration helpers |
+| `test_gate_utils.py` | — | Tests for `gate_utils.py` |
+| `test_pre_commit.py` | — | Tests for `pre_commit.py` |
+| `test_pre_push.py` | — | Tests for `pre_push.py` |
+| `test_pre_push_base_reference.py` | — | Tests for the gate base resolution in `pre_push.py` |
+| `conftest.py` | — | Puts this directory on `sys.path` and clears cached `config` modules, so each test module imports the hooks at the top of the file |
+
+## Subdirectory
+
+| Directory | Role |
+|---|---|
+| `git_hooks_constants/` | Shared constants imported by the git-hook scripts |
+
+## Conventions
+
+- The installer strips the `_` and `.py` suffix when copying into the live git-hooks path (e.g. `pre_commit.py` becomes `pre-commit`).
+- Constants (exit codes, argument names, error messages) live in `git_hooks_constants/` and are imported at the top of each script.
+- Run tests with `python -m pytest git-hooks/test_<name>.py`.

package/hooks/git-hooks/CLAUDE.md

@@ -1,31 +1 @@
-# hooks/git-hooks
-
-Native git hooks that run outside the Claude Code lifecycle — invoked directly by git at commit and push time. The installer copies these scripts into the user's shared git-hooks directory (`core.hooksPath`).
-
-## Key files
-
-| File | Git hook | What it does |
-|---|---|---|
-| `pre_commit.py` | `pre-commit` | Runs the CODE_RULES gate (`precommit_code_rules_gate.py`) over staged changes; exits 1 when any staged file has a blocking violation |
-| `pre_push.py` | `pre-push` | Blocks a push that would land a non-`main` local branch onto remote `main` (or `master`), then runs the CODE_RULES gate. An existing branch's gate base is the merge base with the remote default branch; the gate process still diffs that base against checkout HEAD, so the surface matches the pushed tip only when HEAD is that tip. |
-| `pre_push_base_reference.py` | — | Resolves a usable gate base for `pre_push.py`: reads the pushed remote name from git's arguments, then turns a symbolic default-branch head into a reference that git can resolve |
-| `post_commit.py` | `post-commit` | Runs after a commit lands; performs any post-commit bookkeeping |
-| `gate_utils.py` | — | Shared helpers: resolves the gate script path, checks that the path is a safe regular file |
-| `test_config.py` | — | Test configuration helpers |
-| `test_gate_utils.py` | — | Tests for `gate_utils.py` |
-| `test_pre_commit.py` | — | Tests for `pre_commit.py` |
-| `test_pre_push.py` | — | Tests for `pre_push.py` |
-| `test_pre_push_base_reference.py` | — | Tests for the gate base resolution in `pre_push.py` |
-| `conftest.py` | — | Puts this directory on `sys.path` and clears cached `config` modules, so each test module imports the hooks at the top of the file |
-
-## Subdirectory
-
-| Directory | Role |
-|---|---|
-| `git_hooks_constants/` | Shared constants imported by the git-hook scripts |
-
-## Conventions
-
-- The installer strips the `_` and `.py` suffix when copying into the live git-hooks path (e.g. `pre_commit.py` becomes `pre-commit`).
-- Constants (exit codes, argument names, error messages) live in `git_hooks_constants/` and are imported at the top of each script.
-- Run tests with `python -m pytest git-hooks/test_<name>.py`.
+@AGENTS.md

package/hooks/git-hooks/git_hooks_constants/AGENTS.md

@@ -0,0 +1,21 @@
+# hooks/git-hooks/git_hooks_constants
+
+Shared constants imported by the git-hook scripts in `git-hooks/`. Centralizes exit codes, argument names, and error messages so every tunable lives in one place.
+
+## Files
+
+| File | Contents |
+|---|---|
+| `__init__.py` | Exports all constants; marks this as a package so `from git_hooks_constants import ...` resolves |
+
+## Key constants (defined in `__init__.py`)
+
+- `GATE_INFRASTRUCTURE_FAILURE_EXIT_CODE` — exit code when the gate script cannot be found or launched
+- `GATE_SCRIPT_NOT_FOUND_MESSAGE` — error message when the gate script path does not exist
+- `INVOKE_GATE_FAILURE_MESSAGE` — error message when the gate subprocess fails to start
+- `STAGED_SCOPE_ARGUMENT` — CLI argument passed to the gate script to scope it to staged changes
+
+## Conventions
+
+- Import with `from git_hooks_constants import <CONSTANT>` from within the `git-hooks/` directory.
+- Add new constants here rather than inline in the hook scripts.

package/hooks/git-hooks/git_hooks_constants/CLAUDE.md

@@ -1,21 +1 @@
-# hooks/git-hooks/git_hooks_constants
-
-Shared constants imported by the git-hook scripts in `git-hooks/`. Centralizes exit codes, argument names, and error messages so every tunable lives in one place.
-
-## Files
-
-| File | Contents |
-|---|---|
-| `__init__.py` | Exports all constants; marks this as a package so `from git_hooks_constants import ...` resolves |
-
-## Key constants (defined in `__init__.py`)
-
-- `GATE_INFRASTRUCTURE_FAILURE_EXIT_CODE` — exit code when the gate script cannot be found or launched
-- `GATE_SCRIPT_NOT_FOUND_MESSAGE` — error message when the gate script path does not exist
-- `INVOKE_GATE_FAILURE_MESSAGE` — error message when the gate subprocess fails to start
-- `STAGED_SCOPE_ARGUMENT` — CLI argument passed to the gate script to scope it to staged changes
-
-## Conventions
-
-- Import with `from git_hooks_constants import <CONSTANT>` from within the `git-hooks/` directory.
-- Add new constants here rather than inline in the hook scripts.
+@AGENTS.md

package/hooks/git-hooks/git_hooks_constants/__init__.py

@@ -49,12 +49,9 @@ NO_PARSEABLE_STDIN_LINES_MESSAGE: str = (
 NO_PARSEABLE_STDIN_LINES_SENTINEL: str = "__no_parseable_stdin_lines__"
 UNRESOLVABLE_MERGE_BASE_SENTINEL: str = "__unresolvable_merge_base__"
 UNRESOLVABLE_MERGE_BASE_MESSAGE: str = (
-    "claude-dev-env pre-push: git found no merge base between the pushed object "
-    "and the default branch, so the gate scope is unknown and "
-    "enforcement is skipped. That happens when the pushed branch and the "
-    "default branch hold unrelated histories, or when a default-branch ref "
-    "resolved and merge-base still could not name a shared commit "
-    "(for example a shallow clone missing the connecting history)."
+    "claude-dev-env pre-push: CODE_RULES validation is pending because the pushed "
+    "object and default branch have no shared merge base. Restore shared history "
+    "or provide a reachable default branch, then run the push again."
 )
 LOCAL_BRANCH_REFERENCE_PREFIX: str = "refs/heads/"
 ORIGIN_HEAD_SYMBOLIC_REFERENCE: str = "refs/remotes/origin/HEAD"
@@ -63,6 +60,7 @@ ALL_DEFAULT_BRANCH_FALLBACK_REFERENCES: tuple[str, ...] = (
     "refs/remotes/origin/main",
     "refs/remotes/origin/master",
 )
+REMOTE_BRANCH_REFERENCE_TEMPLATE: str = "refs/remotes/{remote}/{branch}"
 ALL_GIT_SYMBOLIC_REFERENCE_COMMAND_PREFIX: tuple[str, ...] = (
     "git",
     "symbolic-ref",
@@ -76,12 +74,6 @@ ALL_GIT_VERIFY_REFERENCE_COMMAND_PREFIX: tuple[str, ...] = (
 )
 ALL_GIT_MERGE_BASE_COMMAND_PREFIX: tuple[str, ...] = ("git", "merge-base")
 GIT_REFERENCE_QUERY_TIMEOUT_SECONDS: int = 15
-CODE_REVIEW_PUSH_GATE_PATH_OVERRIDE_ENV_VAR: str = "CODE_REVIEW_PUSH_GATE_PATH"
-CODE_REVIEW_PUSH_GATE_MODULE_NAME: str = "code_review_push_gate"
-CODE_REVIEW_PUSH_GATE_SCRIPT_FILENAME: str = "code_review_push_gate.py"
-CODE_REVIEW_DENY_REASON_FUNCTION_NAME: str = "deny_reason_for_directory"
-BLOCKING_DIRECTORY_NAME: str = "blocking"
-CODE_REVIEW_STAMP_BLOCK_EXIT_CODE: int = 1
 ALL_PROTECTED_BRANCH_PUSH_NAMES: tuple[str, ...] = ("main", "master")
 PROTECTED_BRANCH_PUSH_BLOCK_EXIT_CODE: int = 1
 PROTECTED_BRANCH_PUSH_BLOCK_MESSAGE: str = (