claude-dev-env 2.12.0 → 2.13.0

package/hooks/diagnostic/test_hook_log_stop_wrapper.py

@@ -1,345 +1,17 @@
-"""Tests for hook_log_stop_wrapper -- debounced, fire-and-forget Stop hook."""
+"""Tests for the disabled hook_log_stop_wrapper Stop hook."""
 
 from __future__ import annotations
 
-import os
-import subprocess
 import sys
-import time
 from pathlib import Path
 
-import pytest
-
 _HOOKS_ROOT = Path(__file__).resolve().parent.parent
 if str(_HOOKS_ROOT) not in sys.path:
     sys.path.insert(0, str(_HOOKS_ROOT))
 
 from diagnostic import hook_log_stop_wrapper
-from hooks_constants.hook_log_extractor_constants import (
-    BWS_ACCESS_TOKEN_ENV_VAR,
-    BWS_EXECUTABLE_NAME,
-    FLAG_INCREMENTAL,
-    STOP_WRAPPER_DEBOUNCE_SECONDS,
-)
-
-
-def _redirect_timestamp_path(
-    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
-) -> Path:
-    timestamp_file = tmp_path / "stop_wrapper_last_run.txt"
-    monkeypatch.setattr(
-        hook_log_stop_wrapper,
-        "_last_run_timestamp_path",
-        lambda: timestamp_file,
-    )
-    return timestamp_file
-
-
-def test_main_returns_zero_when_extractor_spawn_raises(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    def _raise(*_args: object, **_kwargs: object) -> None:
-        raise RuntimeError("boom")
 
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _raise)
 
+def test_main_returns_zero_without_side_effects() -> None:
+    """Disabled main exits success and does no work."""
     assert hook_log_stop_wrapper.main() == 0
-    assert not timestamp_file.exists()
-
-
-def test_main_writes_timestamp_before_spawn_to_narrow_toctou_window(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    timestamp_file_existed_at_spawn_time: list[bool] = []
-
-    def _capture_timestamp_state(*_args: object, **_kwargs: object) -> object:
-        timestamp_file_existed_at_spawn_time.append(timestamp_file.exists())
-        return object()
-
-    monkeypatch.setattr(
-        hook_log_stop_wrapper.subprocess, "Popen", _capture_timestamp_state
-    )
-
-    hook_log_stop_wrapper.main()
-
-    assert timestamp_file_existed_at_spawn_time == [True]
-
-
-def test_main_removes_timestamp_when_spawn_fails_to_allow_retry(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    timestamp_file.parent.mkdir(parents=True, exist_ok=True)
-    stale_timestamp = time.time() - STOP_WRAPPER_DEBOUNCE_SECONDS - 1
-    timestamp_file.write_text(str(stale_timestamp))
-
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    def _raise(*_args: object, **_kwargs: object) -> None:
-        raise RuntimeError("boom")
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _raise)
-
-    assert hook_log_stop_wrapper.main() == 0
-    assert not timestamp_file.exists()
-
-
-def test_main_uses_bws_when_token_and_binary_present(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.setenv(BWS_ACCESS_TOKEN_ENV_VAR, "secret-value")
-    monkeypatch.setattr(
-        hook_log_stop_wrapper.shutil,
-        "which",
-        lambda _name: "/usr/local/bin/bws",
-    )
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-    assert captured_commands[0][0] == BWS_EXECUTABLE_NAME
-    assert FLAG_INCREMENTAL in captured_commands[0]
-
-
-def test_main_skips_bws_when_token_missing(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(
-        hook_log_stop_wrapper.shutil,
-        "which",
-        lambda _name: "/usr/local/bin/bws",
-    )
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-    assert BWS_EXECUTABLE_NAME not in captured_commands[0]
-
-
-def test_main_skips_bws_when_binary_missing(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.setenv(BWS_ACCESS_TOKEN_ENV_VAR, "secret-value")
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-    assert BWS_EXECUTABLE_NAME not in captured_commands[0]
-
-
-def test_main_skips_spawn_when_recent_timestamp_within_debounce_window(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    timestamp_file.parent.mkdir(parents=True, exist_ok=True)
-    timestamp_file.write_text(str(time.time()))
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 0
-
-
-def test_main_spawns_when_timestamp_older_than_debounce_window(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    timestamp_file.parent.mkdir(parents=True, exist_ok=True)
-    stale_timestamp = time.time() - STOP_WRAPPER_DEBOUNCE_SECONDS - 1
-    timestamp_file.write_text(str(stale_timestamp))
-
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-
-
-def test_main_writes_current_timestamp_to_file(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-    monkeypatch.setattr(
-        hook_log_stop_wrapper.subprocess,
-        "Popen",
-        lambda *_args, **_kwargs: object(),
-    )
-
-    timestamp_before_call = time.time()
-    hook_log_stop_wrapper.main()
-    timestamp_after_call = time.time()
-
-    assert timestamp_file.exists()
-    written_timestamp = float(timestamp_file.read_text().strip())
-    assert timestamp_before_call <= written_timestamp <= timestamp_after_call
-
-
-def test_main_passes_devnull_streams_to_detached_spawn(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_kwargs: dict[str, object] = {}
-
-    def _fake_popen(command_list: list[str], **kwargs: object) -> object:
-        captured_kwargs.update(kwargs)
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    hook_log_stop_wrapper.main()
-
-    assert captured_kwargs.get("stdin") is hook_log_stop_wrapper.subprocess.DEVNULL
-    assert captured_kwargs.get("stdout") is hook_log_stop_wrapper.subprocess.DEVNULL
-    assert captured_kwargs.get("stderr") is hook_log_stop_wrapper.subprocess.DEVNULL
-
-
-def test_main_recovers_when_timestamp_file_is_corrupted(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    timestamp_file.parent.mkdir(parents=True, exist_ok=True)
-    timestamp_file.write_text("not-a-float")
-
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-
-
-def test_main_treats_future_timestamp_as_not_debounced(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    timestamp_file = _redirect_timestamp_path(monkeypatch, tmp_path)
-    timestamp_file.parent.mkdir(parents=True, exist_ok=True)
-    far_future_timestamp = time.time() + 3600
-    timestamp_file.write_text(str(far_future_timestamp))
-
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_commands: list[list[str]] = []
-
-    def _fake_popen(command_list: list[str], **_kwargs: object) -> object:
-        captured_commands.append(list(command_list))
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    exit_code = hook_log_stop_wrapper.main()
-
-    assert exit_code == 0
-    assert len(captured_commands) == 1
-
-
-def test_main_passes_hidden_startupinfo_on_windows(
-    monkeypatch: pytest.MonkeyPatch,
-    tmp_path: Path,
-) -> None:
-    _redirect_timestamp_path(monkeypatch, tmp_path)
-    monkeypatch.delenv(BWS_ACCESS_TOKEN_ENV_VAR, raising=False)
-    monkeypatch.setattr(hook_log_stop_wrapper.shutil, "which", lambda _name: None)
-
-    captured_kwargs: dict[str, object] = {}
-
-    def _fake_popen(command_list: list[str], **kwargs: object) -> object:
-        captured_kwargs.update(kwargs)
-        return object()
-
-    monkeypatch.setattr(hook_log_stop_wrapper.subprocess, "Popen", _fake_popen)
-
-    hook_log_stop_wrapper.main()
-
-    if os.name == "nt":
-        startup_info = captured_kwargs.get("startupinfo")
-        assert startup_info is not None
-        assert startup_info.dwFlags & subprocess.STARTF_USESHOWWINDOW
-        assert startup_info.wShowWindow == subprocess.SW_HIDE
-    else:
-        assert captured_kwargs.get("start_new_session") is True

package/hooks/git-hooks/git_hooks_constants/__init__.py

@@ -76,12 +76,6 @@ ALL_GIT_VERIFY_REFERENCE_COMMAND_PREFIX: tuple[str, ...] = (
 )
 ALL_GIT_MERGE_BASE_COMMAND_PREFIX: tuple[str, ...] = ("git", "merge-base")
 GIT_REFERENCE_QUERY_TIMEOUT_SECONDS: int = 15
-CODE_REVIEW_PUSH_GATE_PATH_OVERRIDE_ENV_VAR: str = "CODE_REVIEW_PUSH_GATE_PATH"
-CODE_REVIEW_PUSH_GATE_MODULE_NAME: str = "code_review_push_gate"
-CODE_REVIEW_PUSH_GATE_SCRIPT_FILENAME: str = "code_review_push_gate.py"
-CODE_REVIEW_DENY_REASON_FUNCTION_NAME: str = "deny_reason_for_directory"
-BLOCKING_DIRECTORY_NAME: str = "blocking"
-CODE_REVIEW_STAMP_BLOCK_EXIT_CODE: int = 1
 ALL_PROTECTED_BRANCH_PUSH_NAMES: tuple[str, ...] = ("main", "master")
 PROTECTED_BRANCH_PUSH_BLOCK_EXIT_CODE: int = 1
 PROTECTED_BRANCH_PUSH_BLOCK_MESSAGE: str = (

package/hooks/git-hooks/pre_push.py

@@ -44,8 +44,6 @@ Exit codes:
 
 from __future__ import annotations
 
-import importlib.util
-import os
 import subprocess
 import sys
 from pathlib import Path
@@ -59,12 +57,6 @@ from git_hooks_constants import (
     ALL_PROTECTED_BRANCH_PUSH_NAMES,
     ALL_ZEROS_OBJECT_NAME_CHARACTER,
     BASE_REFERENCE_ARGUMENT,
-    BLOCKING_DIRECTORY_NAME,
-    CODE_REVIEW_DENY_REASON_FUNCTION_NAME,
-    CODE_REVIEW_PUSH_GATE_MODULE_NAME,
-    CODE_REVIEW_PUSH_GATE_PATH_OVERRIDE_ENV_VAR,
-    CODE_REVIEW_PUSH_GATE_SCRIPT_FILENAME,
-    CODE_REVIEW_STAMP_BLOCK_EXIT_CODE,
     DEFAULT_REMOTE_BASE_REFERENCE,
     GATE_INFRASTRUCTURE_FAILURE_EXIT_CODE,
     GIT_COMMAND_TIMEOUT_SECONDS,
@@ -509,80 +501,6 @@ def invoke_gate(gate_script_path: Path, base_reference: str) -> int:
     return completion.returncode
 
 
-def resolve_code_review_gate_path() -> tuple[Path, Path | None]:
-    """Return the code-review push gate script path and its exact-allow override.
-
-    The override environment variable, when set, names the only path the trust
-    check accepts; otherwise the gate script resolves to the ``blocking``
-    directory beside this hook's ``git-hooks`` directory, which holds in both
-    the repository layout and the installed ``~/.claude/hooks`` layout.
-
-    Returns:
-        A pair of the resolved gate script path and either the exact override
-        path (override set) or None (trust-root case).
-    """
-    override_path_raw = os.environ.get(
-        CODE_REVIEW_PUSH_GATE_PATH_OVERRIDE_ENV_VAR, ""
-    ).strip()
-    if override_path_raw:
-        exact_override = Path(override_path_raw).resolve()
-        return exact_override, exact_override
-    blocking_directory = Path(__file__).resolve().parent.parent / BLOCKING_DIRECTORY_NAME
-    return blocking_directory / CODE_REVIEW_PUSH_GATE_SCRIPT_FILENAME, None
-
-
-def load_code_review_deny_reason(gate_script_path: Path, work_tree_directory: str) -> str | None:
-    """Import the gate script and read its push deny reason for a work tree.
-
-    Any import or evaluation failure reads as no deny reason.
-
-    Args:
-        gate_script_path: The resolved code-review push gate script path.
-        work_tree_directory: The work tree the push targets.
-
-    Returns:
-        The gate's deny reason when the surface lacks a covering low stamp;
-        None when the gate allows the push or could not be evaluated.
-    """
-    try:
-        gate_specification = importlib.util.spec_from_file_location(
-            CODE_REVIEW_PUSH_GATE_MODULE_NAME, str(gate_script_path)
-        )
-        if gate_specification is None or gate_specification.loader is None:
-            return None
-        gate_module = importlib.util.module_from_spec(gate_specification)
-        gate_specification.loader.exec_module(gate_module)
-        deny_reason_function = getattr(gate_module, CODE_REVIEW_DENY_REASON_FUNCTION_NAME, None)
-        if deny_reason_function is None:
-            return None
-        deny_reason = deny_reason_function(work_tree_directory)
-    except Exception:
-        return None
-    if isinstance(deny_reason, str) and deny_reason:
-        return deny_reason
-    return None
-
-
-def code_review_stamp_block_exit_code() -> int:
-    """Block the push when no clean low code-review stamp covers the surface.
-
-    Runs the gate decision only when the gate script sits at a trusted
-    installed location (or the exact override path). When the gate is absent
-    from a trusted location, the check is skipped and the push is allowed,
-    matching the CODE_RULES gate's fail-open posture.
-
-    Returns:
-        The block exit code when a covering low stamp is missing; 0 when the
-        surface is covered or the gate is not installed at a trusted location.
-    """
-    gate_script_path, exact_allowed_path = resolve_code_review_gate_path()
-    if not is_safe_regular_file(gate_script_path, exact_allowed_path):
-        return 0
-    deny_reason = load_code_review_deny_reason(gate_script_path, os.getcwd())
-    if deny_reason is None:
-        return 0
-    sys.stderr.write(deny_reason + "\n")
-    return CODE_REVIEW_STAMP_BLOCK_EXIT_CODE
 
 
 def main() -> int:
@@ -623,7 +541,7 @@ def main() -> int:
             pre_push_gate_script_not_found_message.format(path=gate_script_path),
             file=sys.stderr,
         )
-        return code_review_stamp_block_exit_code()
+        return 0
     base_reference = _resolve_gate_base_from_parsed(parsed_stdin)
     if base_reference is None:
         return 0
@@ -632,7 +550,7 @@ def main() -> int:
         return gate_infrastructure_failure_exit_code
     if base_reference == unresolvable_merge_base_sentinel:
         print(unresolvable_merge_base_message, file=sys.stderr)
-        return code_review_stamp_block_exit_code()
+        return 0
     remote_name = resolve_remote_name_from_arguments(sys.argv)
     try:
         usable_base_reference = resolve_usable_base_reference(
@@ -645,7 +563,7 @@ def main() -> int:
     code_rules_exit_code = invoke_gate(gate_script_path, usable_base_reference)
     if code_rules_exit_code != 0:
         return code_rules_exit_code
-    return code_review_stamp_block_exit_code()
+    return 0
 
 
 if __name__ == "__main__":