claude-dev-env 1.95.0 → 2.0.1

package/hooks/blocking/tests/test_pii_prevention_blocker.py

@@ -0,0 +1,260 @@
+"""Repository-resolution behavior of the PII commit gate (issue #65).
+
+The gate scans the repository the command names, not the session working
+directory, so::
+
+    git -C <healthy repo> commit  ->  scans <healthy repo> from any cwd
+    cd <repo> && git commit        ->  scans <repo>
+    git -C <repo> commit (cwd gone) ->  still scans <repo>, never refuses for cwd
+    git -C <not-a-repo> commit      ->  refusal names <not-a-repo>
+"""
+
+from __future__ import annotations
+
+import json
+import subprocess
+import sys
+from pathlib import Path
+
+import pytest
+from pii_prevention_blocker import evaluate, evaluate_bash_command
+
+_HOOK_PATH = Path(__file__).resolve().parents[1] / "pii_prevention_blocker.py"
+_ALLOW_SLUG = "AllowOwner/allow-repo"
+_OTHER_SLUG = "OtherOwner/other-repo"
+
+
+def _run_hook(payload: dict[str, object]) -> tuple[int, str]:
+    completed_process = subprocess.run(
+        [sys.executable, str(_HOOK_PATH)],
+        input=json.dumps(payload),
+        capture_output=True,
+        text=True,
+        timeout=30,
+        check=False,
+    )
+    return completed_process.returncode, completed_process.stdout
+
+
+def _assembled_fixture_email() -> str:
+    return "owner.fixture" + "@" + "acme-corp" + ".example" + ".io"
+
+
+def _assembled_unlisted_email() -> str:
+    return "other.person" + "@" + "different-co" + ".example" + ".io"
+
+
+def _write_allowlist_identity(identity_path: Path, slug: str, value: str) -> None:
+    identity_path.write_text(
+        json.dumps({"pii_allowlisted_values": {slug: [value]}}),
+        encoding="utf-8",
+    )
+
+
+def _init_repo_with_origin_and_staged_value(
+    repository_root: Path, origin_slug: str, staged_value: str
+) -> None:
+    repository_root.mkdir(parents=True, exist_ok=True)
+    subprocess.run(["git", "init", "-q"], cwd=repository_root, check=True)
+    subprocess.run(
+        ["git", "config", "user.email", "dev@example.com"],
+        cwd=repository_root,
+        check=True,
+    )
+    subprocess.run(
+        ["git", "config", "user.name", "Fixture Dev"], cwd=repository_root, check=True
+    )
+    subprocess.run(
+        ["git", "remote", "add", "origin", "https://github.com/" + origin_slug + ".git"],
+        cwd=repository_root,
+        check=True,
+    )
+    (repository_root / "notes.md").write_text(
+        "owner email " + staged_value + "\n", encoding="utf-8"
+    )
+    subprocess.run(["git", "add", "notes.md"], cwd=repository_root, check=True)
+
+
+def _commit_payload(repository_root: Path) -> dict[str, object]:
+    return {
+        "tool_name": "Bash",
+        "tool_input": {"command": f"git -C {repository_root} commit -m x"},
+    }
+
+
+def test_commit_subprocess_allows_allowlisted_value_in_the_allowlisted_repo(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    allowed_value = _assembled_fixture_email()
+    identity_path = tmp_path / "local-identity.json"
+    _write_allowlist_identity(identity_path, _ALLOW_SLUG, allowed_value)
+    monkeypatch.setenv("CLAUDE_LOCAL_IDENTITY_PATH", str(identity_path))
+    repository_root = tmp_path / "repo"
+    _init_repo_with_origin_and_staged_value(repository_root, _ALLOW_SLUG, allowed_value)
+    return_code, hook_stdout = _run_hook(_commit_payload(repository_root))
+    assert return_code == 0
+    assert hook_stdout.strip() == ""
+
+
+def test_commit_subprocess_blocks_allowlisted_value_in_a_different_repo(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    allowed_value = _assembled_fixture_email()
+    identity_path = tmp_path / "local-identity.json"
+    _write_allowlist_identity(identity_path, _ALLOW_SLUG, allowed_value)
+    monkeypatch.setenv("CLAUDE_LOCAL_IDENTITY_PATH", str(identity_path))
+    repository_root = tmp_path / "repo"
+    _init_repo_with_origin_and_staged_value(repository_root, _OTHER_SLUG, allowed_value)
+    _return_code, hook_stdout = _run_hook(_commit_payload(repository_root))
+    assert "email" in hook_stdout
+
+
+def test_commit_blocks_an_unlisted_value_in_the_allowlisted_repo(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    identity_path = tmp_path / "local-identity.json"
+    _write_allowlist_identity(identity_path, _ALLOW_SLUG, _assembled_fixture_email())
+    monkeypatch.setenv("CLAUDE_LOCAL_IDENTITY_PATH", str(identity_path))
+    repository_root = tmp_path / "repo"
+    _init_repo_with_origin_and_staged_value(
+        repository_root, _ALLOW_SLUG, _assembled_unlisted_email()
+    )
+    deny_reason = evaluate_bash_command(
+        f"git -C {repository_root} commit -m x",
+        working_directory=str(repository_root),
+    )
+    assert deny_reason is not None
+    assert "email" in deny_reason
+
+
+def test_commit_with_missing_local_identity_still_blocks_the_value(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    monkeypatch.setenv("CLAUDE_LOCAL_IDENTITY_PATH", str(tmp_path / "absent.json"))
+    repository_root = tmp_path / "repo"
+    _init_repo_with_origin_and_staged_value(
+        repository_root, _ALLOW_SLUG, _assembled_fixture_email()
+    )
+    deny_reason = evaluate_bash_command(
+        f"git -C {repository_root} commit -m x",
+        working_directory=str(repository_root),
+    )
+    assert deny_reason is not None
+    assert "email" in deny_reason
+
+
+def _init_repo_with_staged_pii(repository_root: Path) -> None:
+    repository_root.mkdir(parents=True, exist_ok=True)
+    subprocess.run(["git", "init", "-q"], cwd=repository_root, check=True)
+    subprocess.run(
+        ["git", "config", "user.email", "dev@example.com"],
+        cwd=repository_root,
+        check=True,
+    )
+    subprocess.run(
+        ["git", "config", "user.name", "Fixture Dev"],
+        cwd=repository_root,
+        check=True,
+    )
+    (repository_root / "notes.md").write_text(
+        "owner email " + _assembled_fixture_email() + "\n",
+        encoding="utf-8",
+    )
+    subprocess.run(["git", "add", "notes.md"], cwd=repository_root, check=True)
+
+
+def test_dash_c_scans_named_repo_from_unrelated_cwd(tmp_path: Path) -> None:
+    repository_root = tmp_path / "healthy_repo"
+    _init_repo_with_staged_pii(repository_root)
+    deny_reason = evaluate_bash_command(
+        f"git -C {repository_root} commit -m x",
+        working_directory="/tmp",
+    )
+    assert deny_reason is not None
+    assert "email" in deny_reason
+
+
+def test_cd_prefix_scans_named_repo_from_unrelated_cwd(tmp_path: Path) -> None:
+    repository_root = tmp_path / "healthy_repo"
+    _init_repo_with_staged_pii(repository_root)
+    deny_reason = evaluate_bash_command(
+        f"cd {repository_root} && git commit -m x",
+        working_directory="/tmp",
+    )
+    assert deny_reason is not None
+    assert "email" in deny_reason
+
+
+def test_cd_prefix_with_git_exe_scans_named_repo_from_unrelated_cwd(
+    tmp_path: Path,
+) -> None:
+    repository_root = tmp_path / "healthy_repo"
+    _init_repo_with_staged_pii(repository_root)
+    deny_reason = evaluate_bash_command(
+        f"cd {repository_root} && git.exe commit -m x",
+        working_directory="/tmp",
+    )
+    assert deny_reason is not None
+    assert "email" in deny_reason
+
+
+def test_removed_working_directory_does_not_block_named_repo(tmp_path: Path) -> None:
+    repository_root = tmp_path / "healthy_repo"
+    _init_repo_with_staged_pii(repository_root)
+    removed_directory = tmp_path / "gone"
+    removed_directory.mkdir()
+    removed_directory.rmdir()
+    deny_reason = evaluate_bash_command(
+        f"git -C {repository_root} commit -m x",
+        working_directory=str(removed_directory),
+    )
+    assert deny_reason is not None
+    assert "email" in deny_reason
+
+
+def test_multiple_dash_c_compose_to_the_named_repo(tmp_path: Path) -> None:
+    repository_root = tmp_path / "parent" / "healthy_repo"
+    _init_repo_with_staged_pii(repository_root)
+    deny_reason = evaluate_bash_command(
+        f"git -C {tmp_path / 'parent'} -C healthy_repo commit -m x",
+        working_directory="/tmp",
+    )
+    assert deny_reason is not None
+    assert "email" in deny_reason
+
+
+def test_full_dispatch_blocks_pii_commit_from_unrelated_cwd(tmp_path: Path) -> None:
+    repository_root = tmp_path / "healthy_repo"
+    _init_repo_with_staged_pii(repository_root)
+    deny_reason = evaluate(
+        {
+            "tool_name": "Bash",
+            "tool_input": {"command": f"git -C {repository_root} commit -m x"},
+            "cwd": "/tmp",
+        }
+    )
+    assert deny_reason is not None
+    assert "email" in deny_reason
+
+
+def test_unresolvable_named_repo_refusal_names_the_path() -> None:
+    deny_reason = evaluate_bash_command(
+        "git -C /nonexistent/repo/xyz commit -m x",
+        working_directory="/tmp",
+    )
+    assert deny_reason is not None
+    assert "repository root" in deny_reason
+    assert "/nonexistent/repo/xyz" in deny_reason
+
+
+def test_clean_named_repo_passes(tmp_path: Path) -> None:
+    repository_root = tmp_path / "clean_repo"
+    repository_root.mkdir()
+    subprocess.run(["git", "init", "-q"], cwd=repository_root, check=True)
+    (repository_root / "readme.md").write_text("all clear\n", encoding="utf-8")
+    subprocess.run(["git", "add", "readme.md"], cwd=repository_root, check=True)
+    deny_reason = evaluate_bash_command(
+        f"git -C {repository_root} commit -m x",
+        working_directory="/tmp",
+    )
+    assert deny_reason is None

package/hooks/blocking/tests/test_repository_exemption.py

@@ -0,0 +1,105 @@
+"""Behavioral tests for the moved repository-exemption helpers.
+
+Covers the origin-URL slug parser and the per-repository exemption decision::
+
+    https://github.com/Owner/Repo.git   ->  owner/repo
+    https://evil.test/Owner/Repo.git    ->  None
+    ok:   origin slug in CLAUDE_PII_EXEMPT_REPOS  ->  exempt (True)
+    flag: origin slug absent from the exempt set  ->  scanned (False)
+"""
+
+from __future__ import annotations
+
+import json
+import subprocess
+from pathlib import Path
+
+import pytest
+from pii_prevention_blocker_parts.repository_exemption import (
+    _is_repository_exempt_from_pii_scan,
+    _owner_repo_slug_from_origin_url,
+    repository_allowlisted_values,
+)
+
+_ALLOWED_VALUE = "owner.fixture" + "@" + "acme-corp" + ".example" + ".io"
+
+
+def _write_allowlist_identity(identity_path: Path, slug: str) -> None:
+    identity_path.write_text(
+        json.dumps({"pii_allowlisted_values": {slug: [_ALLOWED_VALUE]}}),
+        encoding="utf-8",
+    )
+
+
+def test_repository_allowlisted_values_returns_the_mapped_values(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    identity_path = tmp_path / "local-identity.json"
+    _write_allowlist_identity(identity_path, "AllowOwner/allow-repo")
+    monkeypatch.setenv("CLAUDE_LOCAL_IDENTITY_PATH", str(identity_path))
+    repository_root = tmp_path / "repo"
+    _init_repo_with_github_origin(repository_root, "AllowOwner/allow-repo")
+    assert repository_allowlisted_values(repository_root) == frozenset({_ALLOWED_VALUE})
+
+
+def test_repository_allowlisted_values_empty_for_an_unmapped_repo(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    identity_path = tmp_path / "local-identity.json"
+    _write_allowlist_identity(identity_path, "AllowOwner/allow-repo")
+    monkeypatch.setenv("CLAUDE_LOCAL_IDENTITY_PATH", str(identity_path))
+    repository_root = tmp_path / "repo"
+    _init_repo_with_github_origin(repository_root, "OtherOwner/other-repo")
+    assert repository_allowlisted_values(repository_root) == frozenset()
+
+
+def test_github_https_origin_yields_lowercased_owner_repo_slug() -> None:
+    assert _owner_repo_slug_from_origin_url("https://github.com/Owner/Repo.git") == "owner/repo"
+
+
+def test_github_ssh_origin_yields_lowercased_owner_repo_slug() -> None:
+    assert _owner_repo_slug_from_origin_url("git@github.com:Owner/Repo.git") == "owner/repo"
+
+
+def test_spoofed_host_origin_yields_no_slug() -> None:
+    assert _owner_repo_slug_from_origin_url("https://evil.test/Owner/Repo.git") is None
+
+
+def _init_repo_with_github_origin(repository_root: Path, origin_slug: str) -> None:
+    repository_root.mkdir(parents=True, exist_ok=True)
+    subprocess.run(["git", "init", "-q"], cwd=repository_root, check=True)
+    origin_url = "https://github.com/" + origin_slug + ".git"
+    subprocess.run(
+        ["git", "remote", "add", "origin", origin_url],
+        cwd=repository_root,
+        check=True,
+    )
+
+
+def test_repository_with_exempt_origin_is_exempt(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    monkeypatch.setenv("CLAUDE_PII_EXEMPT_REPOS", "ExemptOwner/exempt-repo")
+    repository_root = tmp_path / "repo"
+    _init_repo_with_github_origin(repository_root, "ExemptOwner/exempt-repo")
+    assert _is_repository_exempt_from_pii_scan(repository_root) is True
+
+
+def test_repository_with_unlisted_origin_is_scanned(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    monkeypatch.setenv("CLAUDE_PII_EXEMPT_REPOS", "ExemptOwner/exempt-repo")
+    repository_root = tmp_path / "repo"
+    _init_repo_with_github_origin(repository_root, "OtherOwner/other-repo")
+    assert _is_repository_exempt_from_pii_scan(repository_root) is False
+
+
+def test_repository_without_origin_is_never_exempt(tmp_path: Path) -> None:
+    repository_root = tmp_path / "repo"
+    repository_root.mkdir()
+    subprocess.run(["git", "init", "-q"], cwd=repository_root, check=True)
+    assert _is_repository_exempt_from_pii_scan(repository_root) is False
+
+
+def test_owner_repo_slug_strips_a_trailing_slash_origin() -> None:
+    assert _owner_repo_slug_from_origin_url("https://github.com/Owner/Repo/") == "owner/repo"

package/hooks/blocking/tests/test_repository_resolution.py

@@ -0,0 +1,108 @@
+"""Behavioral tests for the commit repository-path resolution helpers.
+
+Covers reading the repository a commit command targets, so the staged PII scan
+runs against the named path rather than the session working directory::
+
+    git -C /a -C sub commit   ->  /a/sub   (multiple -C compose)
+    git -C /a/b -C /c/d commit ->  /c/d    (a later absolute -C resets)
+    cd "/my repo" && git commit ->  /my repo (quoted cd path, shlex-parsed)
+    git commit                 ->  None     (runs in the session cwd)
+"""
+
+from __future__ import annotations
+
+from pathlib import Path
+
+from pii_prevention_blocker_parts.repository_resolution import (
+    compose_command_working_directory,
+    expand_user_directory,
+    refusal_reason_for_unresolved_repository,
+)
+
+
+def test_single_absolute_dash_c_is_the_target() -> None:
+    assert compose_command_working_directory("git -C /repo commit -m x") == "/repo"
+
+
+def test_relative_dash_c_composes_onto_a_leading_absolute_dash_c() -> None:
+    composed = compose_command_working_directory("git -C /a -C sub commit -m x")
+    assert composed is not None
+    assert Path(composed) == Path("/a") / "sub"
+
+
+def test_later_absolute_dash_c_resets_the_composition() -> None:
+    assert compose_command_working_directory("git -C /a/b -C /c/d commit -m x") == "/c/d"
+
+
+def test_quoted_dash_c_with_spaces_is_read_whole() -> None:
+    assert compose_command_working_directory('git -C "/my repo" commit -m x') == "/my repo"
+
+
+def test_leading_cd_supplies_the_target_when_no_dash_c() -> None:
+    assert compose_command_working_directory("cd /work/repo && git commit -m x") == "/work/repo"
+
+
+def test_quoted_cd_path_with_spaces_is_read_whole() -> None:
+    assert compose_command_working_directory('cd "/my repo" && git commit -m x') == "/my repo"
+
+
+def test_plain_commit_names_no_target() -> None:
+    assert compose_command_working_directory("git commit -m x") is None
+
+
+def test_expand_user_directory_expands_tilde() -> None:
+    expanded = expand_user_directory("~/repo")
+    assert expanded is not None
+    assert not expanded.startswith("~")
+    assert Path(expanded).name == "repo"
+
+
+def test_expand_user_directory_passes_none_through() -> None:
+    assert expand_user_directory(None) is None
+
+
+def test_refusal_names_the_attempted_path() -> None:
+    reason = refusal_reason_for_unresolved_repository("/gone/repo")
+    assert "repository root" in reason
+    assert "/gone/repo" in reason
+
+
+def test_refusal_names_the_session_cwd_when_no_path_given() -> None:
+    reason = refusal_reason_for_unresolved_repository(None)
+    assert "repository root" in reason
+    assert "session working directory" in reason
+
+
+def test_windows_git_exe_dash_c_is_the_target() -> None:
+    assert (
+        compose_command_working_directory(r'git.exe -C "/srv/repo" commit -m x')
+        == "/srv/repo"
+    )
+
+
+def test_leading_cd_with_git_exe_supplies_the_target() -> None:
+    assert (
+        compose_command_working_directory("cd /work/repo && git.exe commit -m x")
+        == "/work/repo"
+    )
+
+
+def test_leading_pushd_with_git_exe_supplies_the_target() -> None:
+    assert (
+        compose_command_working_directory("pushd /work/repo; git.exe commit -m x")
+        == "/work/repo"
+    )
+
+
+def test_quoted_cd_path_with_git_exe_is_read_whole() -> None:
+    assert (
+        compose_command_working_directory('cd "/my repo" && git.exe commit -m x')
+        == "/my repo"
+    )
+
+
+def test_dash_c_wins_over_leading_cd() -> None:
+    assert (
+        compose_command_working_directory("cd /ignored && git -C /named commit -m x")
+        == "/named"
+    )

package/hooks/diagnostic/hook_log_extractor.py

@@ -309,7 +309,7 @@ class AttachmentRecordIterator:
 
     def __iter__(self) -> Iterator[tuple[dict[str, object], int, int]]:
         try:
-            jsonl_file_handle = io.open(self._jsonl_file_path, "rb")
+            jsonl_file_handle = io.open(self._jsonl_file_path, "rb")  # noqa: SIM115
         except (FileNotFoundError, OSError):
             self.final_line_number = self._start_line_number
             self.final_byte_offset = self._start_offset
@@ -419,14 +419,13 @@ def save_offsets(
     state_file_parent = os.path.dirname(state_file_path)
     if state_file_parent:
         os.makedirs(state_file_parent, exist_ok=True)
-    temporary_file_handle = tempfile.NamedTemporaryFile(
+    with tempfile.NamedTemporaryFile(
         mode="w",
         encoding="utf-8",
         dir=state_file_parent or None,
         delete=False,
-    )
-    temporary_file_path = temporary_file_handle.name
-    try:
+    ) as temporary_file_handle:
+        temporary_file_path = temporary_file_handle.name
         try:
             json.dump(
                 offset_by_jsonl_path,
@@ -436,8 +435,14 @@ def save_offsets(
             )
             temporary_file_handle.flush()
             os.fsync(temporary_file_handle.fileno())
-        finally:
+        except Exception:
             temporary_file_handle.close()
+            try:
+                os.unlink(temporary_file_path)
+            except OSError:
+                pass
+            raise
+    try:
         os.replace(temporary_file_path, state_file_path)
     except Exception:
         try:
@@ -468,15 +473,12 @@ def _acquire_offsets_lock(state_file_path: str) -> Iterator[None]:
     lock_parent_directory = os.path.dirname(lock_file_path)
     if lock_parent_directory:
         os.makedirs(lock_parent_directory, exist_ok=True)
-    lock_file_handle = io.open(lock_file_path, "a+", encoding="utf-8")
-    try:
+    with io.open(lock_file_path, "a+", encoding="utf-8") as lock_file_handle:
         _lock_file_handle_blocking(lock_file_handle)
         try:
             yield
         finally:
             _unlock_file_handle(lock_file_handle)
-    finally:
-        lock_file_handle.close()
 
 
 def _lock_file_handle_blocking(lock_file_handle: IO[str]) -> None:

package/hooks/git-hooks/post_commit.py

@@ -10,7 +10,6 @@ When you commit in a submodule, this hook:
 This prevents the "lost work" issue where submodule commits aren't tracked by parent.
 """
 
-import os
 import subprocess
 import sys
 from pathlib import Path
@@ -21,7 +20,7 @@ def run_git(*args: str, cwd: Path | None = None) -> str:
     result = subprocess.run(
         ["git"] + list(args),
         cwd=cwd,
-        capture_output=True,
+        check=False, capture_output=True,
         text=True,
     )
     return result.stdout.strip()
@@ -74,7 +73,7 @@ def main() -> int:
 
     diff_result = subprocess.run(
         ["git", "diff", "--cached", "--quiet"],
-        cwd=parent_repo,
+        check=False, cwd=parent_repo,
     )
 
     if diff_result.returncode == 0:
@@ -89,7 +88,7 @@ Co-Authored-By: Claude <noreply@anthropic.com>"""
 
     subprocess.run(
         ["git", "commit", "-m", full_commit_msg],
-        cwd=parent_repo,
+        check=False, cwd=parent_repo,
     )
 
     print("Parent updated successfully.")

package/hooks/hooks_constants/CLAUDE.md

@@ -39,7 +39,7 @@ Shared constant modules imported by hooks throughout the `hooks/` tree. Each fil
 | `hosted_hook_runner.py` | `run_hook_capturing_output()` — shared runner that runs one dispatcher-hosted hook in-process via runpy and returns its captured stdout and crash flag |
 | `inline_tuple_string_magic_constants.py` | Patterns for detecting magic strings in inline tuple literals |
 | `js_conventions_constants.py` | Banned identifier set, boolean-prefix pattern, and declaration/JSDoc patterns for the JavaScript convention checks |
-| `local_identity.py` | Loader for local machine values: NAS host, ssh user, and ssh port the ssh enforcer guards (`CLAUDE_NAS_*` / `~/.claude/local-identity.json` with placeholder defaults), plus the PII commit-scan exempt-repo slug set (`CLAUDE_PII_EXEMPT_REPOS` / `pii_exempt_repositories`); also composes the ssh enforcer's two deny messages that quote the NAS values |
+| `local_identity.py` | Loader for local machine values: NAS host, ssh user, and ssh port the ssh enforcer guards (`CLAUDE_NAS_*` / `~/.claude/local-identity.json` with placeholder defaults), the PII commit-scan exempt-repo slug set (`CLAUDE_PII_EXEMPT_REPOS` / `pii_exempt_repositories`), and the per-repository allowlisted-values mapping (`pii_allowlisted_values`, keyed by owner/repo slug) read from the git-ignored local file whose path `CLAUDE_LOCAL_IDENTITY_PATH` may point elsewhere; also composes the ssh enforcer's two deny messages that quote the NAS values |
 | `messages.py` | Short user-facing notice strings shown when a Stop hook redirects agent behavior |
 | `multi_edit_reconstruction.py` | `apply_edits()` / `edits_for_tool()` — shared helpers that reconstruct the post-edit content of an Edit or MultiEdit, imported by the blockers that judge post-edit content |
 | `nas_ssh_binary_enforcer_constants.py` | Bash tool name, ssh-family basenames, OpenSSH binary path suffixes, launcher-wrapper set, shell control-operator tokens and split pattern, leading-assignment and duration patterns, and the batch-mode pattern for the NAS ssh binary enforcer |
@@ -87,5 +87,5 @@ Shared constant modules imported by hooks throughout the `hooks/` tree. Each fil
 - Hooks import from this package with `from hooks_constants.<module> import <CONSTANT>`.
 - Tests for these modules live beside them as `test_<module>.py`. Run with `python -m pytest hooks_constants/test_<name>.py`.
 - `dynamic_stderr_handler.py`, `pre_tool_use_stdin.py`, `multi_edit_reconstruction.py`, `hosted_hook_runner.py`, and `text_stripping.py` are utility modules (not pure constants) but live here because they are shared across many hooks.
-- `local_identity.py` is a loader: it reads the environment or `~/.claude/local-identity.json` to resolve private NAS values (with committed placeholder defaults) and the PII commit-scan exempt-repo slug set (`CLAUDE_PII_EXEMPT_REPOS` / `pii_exempt_repositories`).
+- `local_identity.py` is a loader: it reads the environment or `~/.claude/local-identity.json` (its path overridable via `CLAUDE_LOCAL_IDENTITY_PATH`) to resolve private NAS values (with committed placeholder defaults), the PII commit-scan exempt-repo slug set (`CLAUDE_PII_EXEMPT_REPOS` / `pii_exempt_repositories`), and the per-repository allowlisted-values mapping (`pii_allowlisted_values`).
 

package/hooks/hooks_constants/banned_identifiers_constants.py

@@ -22,7 +22,6 @@ ALL_BANNED_IDENTIFIERS: frozenset[str] = frozenset(
         "cnt",
         "btn",
         "idx",
-        "tmp",
         "msg",
         "elem",
         "val",

package/hooks/hooks_constants/code_rules_path_utils_constants.py

@@ -10,7 +10,6 @@ module.
 
 from __future__ import annotations
 
-
 ALL_CONFIG_DIRECTORY_NAMES = frozenset(
     {
         "anthropic_plan_scripts_constants",
@@ -23,6 +22,7 @@ ALL_CONFIG_DIRECTORY_NAMES = frozenset(
         "pr_converge_scripts_constants",
         "bugteam_scripts_constants",
         "usage_pause_constants",
+        "codex_review_scripts_constants",
         "dev_env_scripts_constants",
     }
 )