claude-dev-env 1.94.0 → 2.0.0

package/skills/pr-converge/scripts/test_check_convergence_contract.py

@@ -2,8 +2,12 @@
 
 ::
 
-    check_all(all gates passing)       -> exit 0, "All pre-conditions met ..."
-    check_all(one gate failing)        -> exit 1, "One or more ... do not mark ready."
+    check_all(all gates passing,
+        is_bugteam_post_blocked=False,
+    )       -> exit 0, "All pre-conditions met ..."
+    check_all(one gate failing,
+        is_bugteam_post_blocked=False,
+    )        -> exit 1, "One or more ... do not mark ready."
     _get_pr_head_sha raises SystemExit -> exit 2 propagates
     parse_arguments([... --bugteam-post-blocked]) -> bugteam_post_blocked True
 
@@ -22,6 +26,7 @@ from types import ModuleType
 import pytest
 
 import _pr_converge_path_setup  # noqa: F401
+import check_convergence_availability
 from pr_converge_skill_constants.constants import EXIT_CODE_GH_ERROR
 
 _SCRIPTS_DIRECTORY = Path(__file__).absolute().parent
@@ -45,9 +50,10 @@ EXPECTED_ALL_PASS_STDOUT = (
     "2. bugbot review body clean: PASS — clean\n"
     "3. bugteam_clean_at == current_head: PASS — clean\n"
     "4. copilot_clean_at == current_head: PASS — clean\n"
-    "5. zero unresolved bot threads: PASS — clean\n"
-    "6. PR is mergeable: PASS — clean\n"
-    "7. no pending requested reviews: PASS — clean\n\n"
+    "5. codex_clean_at == current_head: PASS — skipped (codex review not required)\n"
+    "6. zero unresolved bot threads: PASS — clean\n"
+    "7. PR is mergeable: PASS — clean\n"
+    "8. no pending requested reviews: PASS — clean\n\n"
     "All pre-conditions met — PR is ready to mark ready.\n"
 )
 
@@ -56,9 +62,10 @@ EXPECTED_BUGBOT_DOWN_STDOUT = (
     "1. bugbot_clean_at == current_head: PASS — bypassed (bugbot_down)\n"
     "2. bugteam_clean_at == current_head: PASS — clean\n"
     "3. copilot_clean_at == current_head: PASS — clean\n"
-    "4. zero unresolved bot threads: PASS — clean\n"
-    "5. PR is mergeable: PASS — clean\n"
-    "6. no pending requested reviews: PASS — clean\n\n"
+    "4. codex_clean_at == current_head: PASS — skipped (codex review not required)\n"
+    "5. zero unresolved bot threads: PASS — clean\n"
+    "6. PR is mergeable: PASS — clean\n"
+    "7. no pending requested reviews: PASS — clean\n\n"
     "All pre-conditions met — PR is ready to mark ready.\n"
 )
 
@@ -68,9 +75,10 @@ EXPECTED_COPILOT_DOWN_STDOUT = (
     "2. bugbot review body clean: PASS — clean\n"
     "3. bugteam_clean_at == current_head: PASS — clean\n"
     "4. copilot_clean_at == current_head: PASS — bypassed (copilot_down)\n"
-    "5. zero unresolved bot threads: PASS — clean\n"
-    "6. PR is mergeable: PASS — clean\n"
-    "7. no pending requested reviews: PASS — bypassed (copilot_down)\n\n"
+    "5. codex_clean_at == current_head: PASS — skipped (codex review not required)\n"
+    "6. zero unresolved bot threads: PASS — clean\n"
+    "7. PR is mergeable: PASS — clean\n"
+    "8. no pending requested reviews: PASS — bypassed (copilot_down)\n\n"
     "All pre-conditions met — PR is ready to mark ready.\n"
 )
 
@@ -110,8 +118,15 @@ def _refuse_bugteam_clean(**_call_keywords: object) -> tuple[bool, str]:
     )
 
 
+def _null_codex_percent_left() -> float | None:
+    return None
+
+
 def _patch_gates_clean(monkeypatch: pytest.MonkeyPatch) -> None:
     monkeypatch.setattr(check_convergence, "_get_pr_head_sha", _clean_head)
+    monkeypatch.setattr(
+        check_convergence, "_probe_codex_percent_left", _null_codex_percent_left
+    )
     for each_gate_name in _ALL_LEAF_GATE_NAMES:
         monkeypatch.setattr(check_convergence, each_gate_name, _clean_gate)
 
@@ -122,7 +137,7 @@ def test_all_pass_stdout_and_exit_code_match_the_pinned_contract(
     _patch_gates_clean(monkeypatch)
     exit_code = check_convergence.check_all(
         owner="o", repo="r", number=1, is_bugbot_down=False, is_copilot_down=False
-    )
+    , is_bugteam_post_blocked=False, is_codex_down=False, live_codex_clean_at=None)
     assert capsys.readouterr().out == EXPECTED_ALL_PASS_STDOUT
     assert exit_code == 0
 
@@ -133,7 +148,7 @@ def test_bugbot_down_bypass_line_matches_the_pinned_contract(
     _patch_gates_clean(monkeypatch)
     exit_code = check_convergence.check_all(
         owner="o", repo="r", number=1, is_bugbot_down=True, is_copilot_down=False
-    )
+    , is_bugteam_post_blocked=False, is_codex_down=False, live_codex_clean_at=None)
     assert capsys.readouterr().out == EXPECTED_BUGBOT_DOWN_STDOUT
     assert exit_code == 0
 
@@ -144,7 +159,7 @@ def test_copilot_down_bypass_lines_match_the_pinned_contract(
     _patch_gates_clean(monkeypatch)
     exit_code = check_convergence.check_all(
         owner="o", repo="r", number=1, is_bugbot_down=False, is_copilot_down=True
-    )
+    , is_bugteam_post_blocked=False, is_codex_down=False, live_codex_clean_at=None)
     assert capsys.readouterr().out == EXPECTED_COPILOT_DOWN_STDOUT
     assert exit_code == 0
 
@@ -160,9 +175,9 @@ def test_a_failing_gate_yields_exit_one_and_the_fail_summary(
     monkeypatch.setattr(check_convergence, "_get_mergeable", _blocked_mergeable)
     exit_code = check_convergence.check_all(
         owner="o", repo="r", number=1, is_bugbot_down=False, is_copilot_down=False
-    )
+    , is_bugteam_post_blocked=False, is_codex_down=False, live_codex_clean_at=None)
     captured_stdout = capsys.readouterr().out
-    assert "6. PR is mergeable: FAIL — blocked\n" in captured_stdout
+    assert "7. PR is mergeable: FAIL — blocked\n" in captured_stdout
     assert captured_stdout.endswith(EXPECTED_FAIL_SUMMARY)
     assert exit_code == 1
 
@@ -177,7 +192,7 @@ def test_gh_error_exit_code_is_two_and_propagates_from_head_fetch(
     with pytest.raises(SystemExit) as raised:
         check_convergence.check_all(
             owner="o", repo="r", number=1, is_bugbot_down=False, is_copilot_down=False
-        )
+        , is_bugteam_post_blocked=False, is_codex_down=False, live_codex_clean_at=None)
     assert EXIT_CODE_GH_ERROR == 2
     assert raised.value.code == 2
 
@@ -216,6 +231,8 @@ def test_skip_bugteam_gate_when_bugteam_post_blocked_is_true(
         is_bugbot_down=False,
         is_copilot_down=False,
         is_bugteam_post_blocked=True,
+        is_codex_down=False,
+        live_codex_clean_at=None,
     )
     assert "bypassed (bugteam_post_blocked)" in capsys.readouterr().out
     assert exit_code == 0
@@ -241,6 +258,8 @@ def test_run_bugteam_gate_when_bugteam_post_blocked_is_false(
         is_bugbot_down=False,
         is_copilot_down=False,
         is_bugteam_post_blocked=False,
+        is_codex_down=False,
+        live_codex_clean_at=None,
     )
     assert "_check_bugteam_clean" in invoked_gate_names
     assert "bypassed (bugteam_post_blocked)" not in capsys.readouterr().out
@@ -311,6 +330,9 @@ def test_main_derives_bugteam_post_blocked_from_env_when_flag_omitted(
         is_bugbot_down: bool,
         is_copilot_down: bool,
         is_bugteam_post_blocked: bool = False,
+        is_codex_down: bool = False,
+        live_codex_clean_at: str | None = None,
+        **_bypass_note_kwargs: str,
     ) -> int:
         captured_bugteam_post_blocked.append(is_bugteam_post_blocked)
         return 0
@@ -319,3 +341,53 @@ def test_main_derives_bugteam_post_blocked_from_env_when_flag_omitted(
     exit_code = check_convergence.main(["--owner", "o", "--repo", "r", "--pr-number", "1"])
     assert exit_code == 0
     assert captured_bugteam_post_blocked == [True]
+
+
+def test_copilot_probe_error_still_runs_live_gates(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    """A probe error must not hard-fail; live GitHub gates decide pass/fail."""
+    _patch_gates_clean(monkeypatch)
+    live_copilot_calls: list[str] = []
+    live_pending_calls: list[str] = []
+
+    def _recording_bot_review(**_keywords: object) -> tuple[bool, str]:
+        live_copilot_calls.append("copilot")
+        return True, "clean"
+
+    def _recording_pending(**_keywords: object) -> tuple[bool, str]:
+        live_pending_calls.append("pending")
+        return True, "clean"
+
+    monkeypatch.setattr(check_convergence, "_check_bot_review", _recording_bot_review)
+    monkeypatch.setattr(
+        check_convergence, "_check_no_pending_reviews", _recording_pending
+    )
+    monkeypatch.setattr(
+        check_convergence,
+        "_resolve_copilot_waiver",
+        lambda _flag: check_convergence_availability.ReviewerWaiver(
+            False, "", "quota API down"
+        ),
+    )
+    monkeypatch.setattr(
+        check_convergence,
+        "_resolve_bugbot_waiver",
+        lambda _flag: check_convergence_availability.ReviewerWaiver(True, "bugbot_down", ""),
+    )
+    exit_code = check_convergence.main(
+        [
+            "--owner",
+            "o",
+            "--repo",
+            "r",
+            "--pr-number",
+            "1",
+            "--bugbot-down",
+        ]
+    )
+    captured = capsys.readouterr().out
+    assert live_copilot_calls == ["copilot"]
+    assert live_pending_calls == ["pending"]
+    assert "enforced (probe error" not in captured
+    assert exit_code == 0

package/skills/pr-converge/scripts/test_check_convergence_fixture.py

@@ -0,0 +1,179 @@
+"""Fixture-mode tests for check_convergence --fixture replay."""
+
+from __future__ import annotations
+
+import importlib.util
+import json
+import sys
+from pathlib import Path
+from types import ModuleType
+
+import pytest
+
+import _pr_converge_path_setup  # noqa: F401
+
+_SCRIPTS_DIRECTORY = Path(__file__).absolute().parent
+_PR_CONVERGE_DIRECTORY = _SCRIPTS_DIRECTORY.parent
+
+CLEAN_LABEL = "Clean \u2014 no findings"
+CLEAN_BODY = (
+    f"**Bugteam audit completed** \u2014 {CLEAN_LABEL}\n\n"
+    "No findings.\n"
+)
+HEAD_SHA = "ae8005aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+
+
+def _load_module() -> ModuleType:
+    for each_cached_name in [
+        each_key
+        for each_key in list(sys.modules)
+        if each_key == "config" or each_key.startswith("config.")
+    ]:
+        sys.modules.pop(each_cached_name, None)
+    if str(_PR_CONVERGE_DIRECTORY) in sys.path:
+        sys.path.remove(str(_PR_CONVERGE_DIRECTORY))
+    sys.path.insert(0, str(_PR_CONVERGE_DIRECTORY))
+    module_path = _SCRIPTS_DIRECTORY / "check_convergence.py"
+    spec = importlib.util.spec_from_file_location(
+        "check_convergence_fixture_under_test", module_path
+    )
+    assert spec is not None
+    assert spec.loader is not None
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+check_convergence = _load_module()
+
+
+def _write_passing_fixture(tmp_path: Path) -> Path:
+    fixture_path = tmp_path / "pr-at-merge.json"
+    payload = {
+        "head_sha": HEAD_SHA,
+        "pr_object": {"mergeable": True, "mergeable_state": "clean"},
+        "reviews": [
+            {
+                "id": 1,
+                "body": CLEAN_BODY,
+                "commit_id": HEAD_SHA,
+            }
+        ],
+        "unresolved_bot_threads_passed": True,
+        "unresolved_bot_threads_detail": "0 unresolved",
+        "pending_reviews_passed": True,
+        "pending_reviews_detail": "none pending",
+    }
+    fixture_path.write_text(json.dumps(payload), encoding="utf-8")
+    return fixture_path
+
+
+def should_exit_zero_from_fixture_with_bugbot_and_copilot_down(
+    tmp_path: Path, capsys: pytest.CaptureFixture[str]
+) -> None:
+    fixture_path = _write_passing_fixture(tmp_path)
+    exit_code = check_convergence.main(
+        [
+            "--owner",
+            "jl-cmd",
+            "--repo",
+            "claude-dev-env",
+            "--pr-number",
+            "53",
+            "--fixture",
+            str(fixture_path),
+            "--bugbot-down",
+            "--copilot-down",
+        ]
+    )
+    captured = capsys.readouterr().out
+    assert exit_code == 0
+    assert "All pre-conditions met" in captured
+    assert "bypassed (bugbot_down)" in captured
+    assert "bypassed (copilot_down)" in captured
+    assert "clean bugteam audit" in captured
+    assert "PR is mergeable: PASS" in captured
+
+
+def should_exit_one_from_fixture_when_bugteam_clean_missing(
+    tmp_path: Path, capsys: pytest.CaptureFixture[str]
+) -> None:
+    fixture_path = tmp_path / "missing-bugteam.json"
+    payload = {
+        "head_sha": HEAD_SHA,
+        "pr_object": {"mergeable": True, "mergeable_state": "clean"},
+        "reviews": [],
+        "unresolved_bot_threads_passed": True,
+        "unresolved_bot_threads_detail": "0 unresolved",
+        "pending_reviews_passed": True,
+        "pending_reviews_detail": "none pending",
+    }
+    fixture_path.write_text(json.dumps(payload), encoding="utf-8")
+    exit_code = check_convergence.main(
+        [
+            "--owner",
+            "jl-cmd",
+            "--repo",
+            "claude-dev-env",
+            "--pr-number",
+            "80",
+            "--fixture",
+            str(fixture_path),
+            "--bugbot-down",
+            "--copilot-down",
+        ]
+    )
+    captured = capsys.readouterr().out
+    assert exit_code == 1
+    assert "no bugteam review found" in captured
+    assert "do not mark ready" in captured
+
+
+def should_parse_fixture_flag() -> None:
+    arguments = check_convergence.parse_arguments(
+        [
+            "--owner",
+            "o",
+            "--repo",
+            "r",
+            "--pr-number",
+            "1",
+            "--fixture",
+            "snap.json",
+            "--bugbot-down",
+            "--copilot-down",
+        ]
+    )
+    assert arguments.fixture == "snap.json"
+    assert arguments.bugbot_down is True
+    assert arguments.copilot_down is True
+
+
+def should_evaluate_bugteam_clean_from_reviews_on_clean_body() -> None:
+    head = HEAD_SHA
+    passed, detail = check_convergence._evaluate_bugteam_clean_from_reviews(
+        [{"id": 9, "body": CLEAN_BODY, "commit_id": head}],
+        head,
+    )
+    assert passed is True
+    assert "clean bugteam audit" in detail
+
+
+def should_load_convergence_fixture_from_disk(tmp_path: Path) -> None:
+    fixture_path = _write_passing_fixture(tmp_path)
+    fixture = check_convergence._load_convergence_fixture(fixture_path)
+    assert fixture.head_sha == HEAD_SHA
+    assert fixture.pr_object["mergeable"] is True
+    assert len(fixture.reviews) == 1
+
+
+def should_reject_fixture_missing_safety_gate_flags(tmp_path: Path) -> None:
+    fixture_path = tmp_path / "missing-safety-flags.json"
+    payload = {
+        "head_sha": HEAD_SHA,
+        "pr_object": {"mergeable": True, "mergeable_state": "clean"},
+        "reviews": [{"id": 1, "body": CLEAN_BODY, "commit_id": HEAD_SHA}],
+    }
+    fixture_path.write_text(json.dumps(payload), encoding="utf-8")
+    with pytest.raises(ValueError):
+        check_convergence._load_convergence_fixture(fixture_path)

package/skills/pr-converge/scripts/test_check_convergence_gates.py

@@ -1,68 +1,84 @@
-"""Behavioral tests for the review and Bugbot convergence gate leaves.
-
-::
-
-    _flatten_paginated_reviews(two pages) -> newest-first flat list
-    _bugbot_run_conclusion_detail(success) -> (True, "check run ...")
-    _check_bugbot(named complete run) -> (True, "check run ...")
-
-Each test drives the real leaf, stubbing only the ``gh`` transport helpers.
-"""
-
-from __future__ import annotations
-
-import json
-
-import pytest
-
-import check_convergence_gates as gates
-
-
-def test_flatten_paginated_reviews_flattens_and_sorts_newest_first() -> None:
-    pages = [
-        [{"id": 1, "submitted_at": "2026-01-01T00:00:00Z"}],
-        [{"id": 2, "submitted_at": "2026-03-01T00:00:00Z"}],
-    ]
-    flattened = gates._flatten_paginated_reviews(json.dumps(pages))
-    assert flattened is not None
-    assert [each_review["id"] for each_review in flattened] == [2, 1]
-
-
-def test_flatten_paginated_reviews_returns_none_for_non_list_payload() -> None:
-    assert (
-        gates._flatten_paginated_reviews(json.dumps({"message": "Not Found"})) is None
-    )
-
-
-def test_bugbot_run_conclusion_detail_passes_on_a_complete_conclusion() -> None:
-    complete_conclusion = gates.ALL_BUGBOT_CHECK_RUN_COMPLETE_CONCLUSIONS[0]
-    passed, detail = gates._bugbot_run_conclusion_detail(
-        {"id": 55, "conclusion": complete_conclusion, "html_url": ""}
-    )
-    assert passed is True
-    assert "check run 55" in detail
-
-
-def test_check_bugbot_reports_success_when_the_named_run_is_complete(
-    monkeypatch: pytest.MonkeyPatch,
-) -> None:
-    complete_conclusion = gates.ALL_BUGBOT_CHECK_RUN_COMPLETE_CONCLUSIONS[0]
-    run_name = f"x {gates.BUGBOT_CHECK_RUN_NAME_SUBSTRING} y"
-    payload = {
-        "check_runs": [
-            {
-                "name": run_name,
-                "id": 9,
-                "conclusion": complete_conclusion,
-                "html_url": "",
-            }
-        ]
-    }
-
-    def _stub_gh_api(endpoint_path: str) -> tuple[int, str]:
-        return 0, json.dumps(payload)
-
-    monkeypatch.setattr(gates, "_gh_api", _stub_gh_api)
-    passed, detail = gates._check_bugbot(owner="o", repo="r", sha="abc")
-    assert passed is True
-    assert "check run 9" in detail
+"""Behavioral tests for the review and Bugbot convergence gate leaves.
+
+::
+
+    _flatten_paginated_reviews(two pages) -> newest-first flat list
+    _bugbot_run_conclusion_detail(success) -> (True, "check run ...")
+    _check_bugbot(named complete run) -> (True, "check run ...")
+
+Each test drives the real leaf, stubbing only the ``gh`` transport helpers.
+"""
+
+from __future__ import annotations
+
+import json
+
+import pytest
+
+import check_convergence_gates as gates
+
+
+def test_flatten_paginated_reviews_flattens_and_sorts_newest_first() -> None:
+    pages = [
+        [{"id": 1, "submitted_at": "2026-01-01T00:00:00Z"}],
+        [{"id": 2, "submitted_at": "2026-03-01T00:00:00Z"}],
+    ]
+    flattened = gates._flatten_paginated_reviews(json.dumps(pages))
+    assert flattened is not None
+    assert [each_review["id"] for each_review in flattened] == [2, 1]
+
+
+def test_flatten_paginated_reviews_returns_none_for_non_list_payload() -> None:
+    assert (
+        gates._flatten_paginated_reviews(json.dumps({"message": "Not Found"})) is None
+    )
+
+
+def test_bugbot_run_conclusion_detail_passes_on_a_complete_conclusion() -> None:
+    complete_conclusion = gates.ALL_BUGBOT_CHECK_RUN_COMPLETE_CONCLUSIONS[0]
+    passed, detail = gates._bugbot_run_conclusion_detail(
+        {"id": 55, "conclusion": complete_conclusion, "html_url": ""}
+    )
+    assert passed is True
+    assert "check run 55" in detail
+
+
+def test_check_bugbot_reports_success_when_the_named_run_is_complete(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    complete_conclusion = gates.ALL_BUGBOT_CHECK_RUN_COMPLETE_CONCLUSIONS[0]
+    run_name = f"x {gates.BUGBOT_CHECK_RUN_NAME_SUBSTRING} y"
+    payload = {
+        "check_runs": [
+            {
+                "name": run_name,
+                "id": 9,
+                "conclusion": complete_conclusion,
+                "html_url": "",
+            }
+        ]
+    }
+
+    def _stub_gh_api(endpoint_path: str) -> tuple[int, str]:
+        return 0, json.dumps(payload)
+
+    monkeypatch.setattr(gates, "_gh_api", _stub_gh_api)
+    passed, detail = gates._check_bugbot(owner="o", repo="r", sha="abc")
+    assert passed is True
+    assert "check run 9" in detail
+
+
+def should_evaluate_mergeable_from_pr_object_clean() -> None:
+    passed, detail = gates._evaluate_mergeable_from_pr_object(
+        {"mergeable": True, "mergeable_state": "clean"}
+    )
+    assert passed is True
+    assert detail == "clean"
+
+
+def should_evaluate_mergeable_from_pr_object_unknown() -> None:
+    passed, detail = gates._evaluate_mergeable_from_pr_object(
+        {"mergeable": None, "mergeable_state": "unknown"}
+    )
+    assert passed is False
+    assert detail == "unknown"

package/skills/pr-converge/scripts/test_check_convergence_thread_gates.py

@@ -67,6 +67,30 @@ def test_count_unresolved_bot_threads_counts_a_single_cursor_thread(
     assert "src/app.py" in detail
 
 
+def test_check_no_pending_reviews_fails_closed_on_unparseable_response(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    def _stub_gh_api(endpoint_path: str) -> tuple[int, str]:
+        return 0, "not json at all"
+
+    monkeypatch.setattr(thread_gates, "_gh_api", _stub_gh_api)
+    passed, detail = thread_gates._check_no_pending_reviews(owner="o", repo="r", number=1)
+    assert passed is False
+    assert "not valid JSON" in detail
+
+
+def test_check_no_pending_reviews_passes_when_no_copilot_requested(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    def _stub_gh_api(endpoint_path: str) -> tuple[int, str]:
+        return 0, json.dumps({"users": [], "teams": []})
+
+    monkeypatch.setattr(thread_gates, "_gh_api", _stub_gh_api)
+    passed, detail = thread_gates._check_no_pending_reviews(owner="o", repo="r", number=1)
+    assert passed is True
+    assert "no pending reviewers" in detail
+
+
 def test_format_unresolved_detail_bounds_the_listed_paths() -> None:
     over_limit = thread_gates.UNRESOLVED_THREAD_DETAIL_MAX + 2
     all_threads = [{"path": f"file{each_index}.py"} for each_index in range(over_limit)]

package/skills/pr-converge/test_step5_host_branch.py

@@ -0,0 +1,106 @@
+"""Contract checks for Step 5 host-aware CODE_REVIEW wiring.
+
+Issue #103: Step 5 names ``invoke_code_review.py``, the mode decision inputs
+(host profile, session model), stdin/cwd rules, and the clean/dirty branches
+without changing ``code_review_clean_at`` semantics.
+"""
+
+from __future__ import annotations
+
+from pathlib import Path
+
+
+SKILL_ROOT = Path(__file__).resolve().parent
+SKILL_MARKDOWN_PATH = SKILL_ROOT / "SKILL.md"
+PER_TICK_MARKDOWN_PATH = SKILL_ROOT / "reference" / "per-tick.md"
+
+HELPER_SCRIPT_NAME = "invoke_code_review.py"
+SESSION_MODEL_FLAG = "--session-model"
+HOST_PROFILE_PHRASE = "host profile"
+SESSION_MODEL_PHRASE = "session model"
+IN_SESSION_MODE = "in_session"
+CHAIN_MODE = "chain"
+DIRTY_TREE_KEY = "dirty_tree"
+RETURNCODE_KEY = "returncode"
+SERVED_COMMAND_KEY = "served_command"
+SUCCESSFUL_SERVE_PHRASE = "successful serve"
+FAILED_REVIEW_PHRASE = "Failed review"
+CODE_REVIEW_CLEAN_AT = "code_review_clean_at"
+CLEAN_STAMP_HELPER = "is_code_review_clean_stamp_allowed"
+NEVER_COMMITS_PHRASE = "never commits"
+NEVER_PUSHES_PHRASE = "never pushes"
+EMPTY_STDIN_PHRASE = "empty"
+CWD_FLAG = "--cwd"
+OPUS_MODEL = "opus"
+HIGH_EFFORT_SLASH = "/code-review high --fix"
+
+
+def _read_markdown(markdown_path: Path) -> str:
+    return markdown_path.read_text(encoding="utf-8")
+
+
+def _code_review_section(per_tick_text: str) -> str:
+    section_start = per_tick_text.index("### `phase == CODE_REVIEW`")
+    section_end = per_tick_text.index("### `phase == BUGTEAM`", section_start)
+    return per_tick_text[section_start:section_end]
+
+
+def _step_five_checklist(skill_text: str) -> str:
+    step_start = skill_text.index("**Step 5: CODE-REVIEW")
+    step_end = skill_text.index("**Step 6: BUGTEAM", step_start)
+    return skill_text[step_start:step_end]
+
+
+def test_per_tick_code_review_names_helper_and_mode_inputs() -> None:
+    code_review_section = _code_review_section(_read_markdown(PER_TICK_MARKDOWN_PATH))
+    assert HELPER_SCRIPT_NAME in code_review_section
+    assert HOST_PROFILE_PHRASE in code_review_section
+    assert SESSION_MODEL_PHRASE in code_review_section
+    assert SESSION_MODEL_FLAG in code_review_section
+    assert CWD_FLAG in code_review_section
+    assert IN_SESSION_MODE in code_review_section
+    assert CHAIN_MODE in code_review_section
+    assert DIRTY_TREE_KEY in code_review_section
+    assert RETURNCODE_KEY in code_review_section
+    assert SERVED_COMMAND_KEY in code_review_section
+    assert SUCCESSFUL_SERVE_PHRASE in code_review_section
+    assert FAILED_REVIEW_PHRASE in code_review_section
+    assert CLEAN_STAMP_HELPER in code_review_section
+    assert HIGH_EFFORT_SLASH in code_review_section
+    assert OPUS_MODEL in code_review_section
+    assert NEVER_COMMITS_PHRASE in code_review_section
+    assert NEVER_PUSHES_PHRASE in code_review_section
+    assert EMPTY_STDIN_PHRASE in code_review_section
+    assert CODE_REVIEW_CLEAN_AT in code_review_section
+
+
+def test_skill_step_five_checklist_names_helper_and_mode_inputs() -> None:
+    step_five_checklist = _step_five_checklist(_read_markdown(SKILL_MARKDOWN_PATH))
+    assert HELPER_SCRIPT_NAME in step_five_checklist
+    assert HOST_PROFILE_PHRASE in step_five_checklist
+    assert SESSION_MODEL_PHRASE in step_five_checklist
+    assert SESSION_MODEL_FLAG in step_five_checklist
+    assert CWD_FLAG in step_five_checklist
+    assert IN_SESSION_MODE in step_five_checklist
+    assert CHAIN_MODE in step_five_checklist
+    assert DIRTY_TREE_KEY in step_five_checklist
+    assert RETURNCODE_KEY in step_five_checklist
+    assert SERVED_COMMAND_KEY in step_five_checklist
+    assert SUCCESSFUL_SERVE_PHRASE in step_five_checklist
+    assert HIGH_EFFORT_SLASH in step_five_checklist
+    assert OPUS_MODEL in step_five_checklist
+    assert NEVER_COMMITS_PHRASE in step_five_checklist
+    assert NEVER_PUSHES_PHRASE in step_five_checklist
+    assert CODE_REVIEW_CLEAN_AT in step_five_checklist
+
+
+def test_per_tick_clean_stamp_requires_successful_serve() -> None:
+    code_review_section = _code_review_section(_read_markdown(PER_TICK_MARKDOWN_PATH))
+    assert FAILED_REVIEW_PHRASE in code_review_section
+    assert "returncode != 0" in code_review_section
+    assert "null" in code_review_section
+    assert SERVED_COMMAND_KEY in code_review_section
+    assert "do not set" in code_review_section.lower() or "Do not set" in code_review_section
+    assert CODE_REVIEW_CLEAN_AT in code_review_section
+    assert SUCCESSFUL_SERVE_PHRASE in code_review_section
+    assert DIRTY_TREE_KEY in code_review_section