claude-dev-env 1.92.0 → 1.93.0

package/skills/autoconverge/workflow/converge.path-aware.test.mjs

@@ -39,7 +39,7 @@ test('a path-scoped run defers to a step that names a different repository direc
 test('convergeAgent prepends the worktree directive for the active repo path', () => {
   const agentDefinition = sliceBetween('const convergeAgent =', '\nconst PRE_COMMIT_GATE_STEP');
   assert.match(agentDefinition, /worktreeDirective\(activeRepoPath\)/);
-  assert.match(agentDefinition, /HEADLESS_SAFETY_PREAMBLE/);
+  assert.match(agentDefinition, /HEADLESS_EDIT_PREAMBLE/);
 });
 
 test('the run binds activeRepoPath from input.repoPath after the input is parsed', () => {

package/skills/autoconverge/workflow/converge.precatch.test.mjs

@@ -0,0 +1,152 @@
+import { test } from 'node:test';
+import { strict as assert } from 'node:assert';
+import { readFileSync } from 'node:fs';
+import { fileURLToPath } from 'node:url';
+import { dirname, join } from 'node:path';
+
+const workflowDirectory = dirname(fileURLToPath(import.meta.url));
+const convergeSource = readFileSync(join(workflowDirectory, 'converge.mjs'), 'utf8');
+
+function functionSource(functionName) {
+  const functionStart = convergeSource.indexOf(`function ${functionName}(`);
+  assert.notEqual(functionStart, -1, `expected ${functionName} to exist`);
+  const nextMatch = /\n(?:async )?function /.exec(convergeSource.slice(functionStart + 1));
+  const functionEnd =
+    nextMatch === null ? convergeSource.length : functionStart + 1 + nextMatch.index;
+  return convergeSource.slice(functionStart, functionEnd);
+}
+
+function sliceBetween(startNeedle, endNeedle) {
+  const sliceStart = convergeSource.indexOf(startNeedle);
+  assert.notEqual(sliceStart, -1, `expected ${startNeedle} to exist`);
+  const sliceEnd = convergeSource.indexOf(endNeedle, sliceStart + startNeedle.length);
+  assert.notEqual(sliceEnd, -1, `expected ${endNeedle} to exist after ${startNeedle}`);
+  return convergeSource.slice(sliceStart, sliceEnd);
+}
+
+test('runStaticSweep exists and runs after the preflight-git no-SHA guard and before the parallel lenses', () => {
+  assert.match(convergeSource, /function runStaticSweep\(/, 'expected the static-sweep lens builder to exist');
+  const sweepCallIndex = convergeSource.indexOf('await runStaticSweep(');
+  assert.notEqual(sweepCallIndex, -1, 'expected the CONVERGE round to invoke runStaticSweep');
+  const noShaGuardIndex = convergeSource.indexOf('preflight-git agent returned no SHA');
+  const parallelIndex = convergeSource.indexOf('const lenses = await parallel(');
+  assert.ok(
+    noShaGuardIndex !== -1 && noShaGuardIndex < sweepCallIndex,
+    'expected the static sweep to run after the no-SHA guard',
+  );
+  assert.ok(
+    sweepCallIndex < parallelIndex,
+    'expected the static sweep to run before the opus reading lenses so they review sweep-clean code',
+  );
+});
+
+test('the static-sweep prompt names the deterministic gates and never invokes the gh CLI', () => {
+  const body = functionSource('runStaticSweep');
+  assert.match(body, /code_rules_gate\.py/, 'expected the CODE_RULES gate to be named');
+  assert.match(body, /--base/, 'expected the gate to run against the origin/main base');
+  assert.match(body, /\bruff\b/, 'expected ruff to be named');
+  assert.match(body, /\bmypy\b/, 'expected mypy to be named');
+  assert.match(body, /\bpytest\b/, 'expected stem-matched pytest to be named');
+  assert.doesNotMatch(body, /\bgh\b/, 'expected the sweep to use only local commands so it runs in a cloud session');
+});
+
+test('the static-sweep runs on the sonnetMedium tier via convergeReadOnlyAgent with the Explore agent type', () => {
+  const body = functionSource('runStaticSweep');
+  assert.match(body, /convergeReadOnlyAgent\(/, 'expected the sweep to spawn through the read-only preamble');
+  assert.match(body, /renderLensDiffContext\(preflightResult\)/, 'expected the sweep to inject the preflight changed-file context');
+  assert.match(body, /label: 'lens:static-sweep'/);
+  assert.match(body, /agentType: 'Explore'/);
+  assert.match(body, /\.\.\.TIERS\.sonnetMedium/, 'expected the deterministic sweep to run on the cheaper sonnet tier');
+});
+
+test('a static-sweep finding routes through applyFixes with the static-sweep label and nulls head before continue', () => {
+  const sweepBranch = sliceBetween('await runStaticSweep(', "const lenses = await parallel(");
+  assert.match(sweepBranch, /applyFixes\(head, sweep\.findings, 'static-sweep'\)/, 'expected sweep findings to route through applyFixes');
+  assert.match(sweepBranch, /detectFixProgress\(sweepFix, head, false\)/, 'expected the sweep fix to check fix progress with no thread-bearing finding');
+  const headNullIndex = sweepBranch.indexOf('head = null');
+  const continueIndex = sweepBranch.indexOf('continue');
+  assert.notEqual(headNullIndex, -1, 'expected the sweep-findings branch to null head so the next round reviews the fixed code');
+  assert.ok(headNullIndex < continueIndex, 'expected head to be invalidated before the sweep branch continues');
+});
+
+test('runAuditLens carries the adversarial second pass and points at the pre-catch rubric', () => {
+  const body = functionSource('runAuditLens');
+  assert.match(body, /missed at least 3 P1/, 'expected the mandatory adversarial second pass');
+  assert.match(body, /CONFIG\.precatchRubric/, 'expected the audit lens to point at the pre-catch rubric for the doc-parity/test/PR-description lanes');
+  assert.doesNotMatch(body, /nothing new is an acceptable/i, 'expected a bare "nothing new" to be rejected');
+});
+
+test('runSelfReviewLens exists on opusMedium via convergeReadOnlyAgent and covers the three semantic lanes', () => {
+  const body = functionSource('runSelfReviewLens');
+  assert.match(body, /convergeReadOnlyAgent\(/, 'expected the self-review lens to spawn through the read-only preamble');
+  assert.match(body, /renderLensDiffContext\(preflightResult\)/, 'expected the self-review lens to inject the preflight changed-file context');
+  assert.match(body, /CONFIG\.precatchRubric/, 'expected the self-review lens to read the pre-catch rubric');
+  assert.match(body, /pr-consistency-audit/, 'expected the self-review lens to reuse the pr-consistency-audit method');
+  assert.match(body, /category-o-docstring-vs-impl-drift/, 'expected the self-review lens to cite the category-o drift rubric');
+  assert.match(body, /parity/i, 'expected the doc-vs-code parity lane');
+  assert.match(body, /Test-assertion completeness/i, 'expected the test-assertion completeness lane');
+  assert.match(body, /PR-description-vs-diff/i, 'expected the PR-description parity lane');
+  assert.match(body, /label: 'lens:self-review'/);
+  assert.match(body, /\.\.\.TIERS\.opusMedium/, 'expected the semantic lens to stay on opus');
+});
+
+test('the round parallel array holds exactly the three internal lenses and no Bugbot slot', () => {
+  const parallelArray = sliceBetween('const lenses = await parallel([', '])');
+  assert.match(parallelArray, /runCodeReviewLens\(head, reviewerAvailability\)/);
+  assert.match(parallelArray, /runAuditLens\(head, reviewerAvailability\)/);
+  assert.match(parallelArray, /runSelfReviewLens\(head, reviewerAvailability\)/);
+  assert.doesNotMatch(parallelArray, /runBugbotLens/, 'expected Bugbot to leave the per-round parallel and become a terminal gate');
+  assert.doesNotMatch(parallelArray, /isBugbotDownPreSpawn/, 'expected the pre-spawn Bugbot-down decision to be gone from the round');
+  assert.doesNotMatch(convergeSource, /const isBugbotDownPreSpawn/, 'expected no pre-spawn Bugbot-down decision anywhere in the round');
+});
+
+test('both the CONVERGE clean branch and the standards-only branch route to the terminal BUGBOT phase', () => {
+  const convergeBranch = sliceBetween("if (phase === 'CONVERGE') {", "if (phase === 'BUGBOT') {");
+  const toBugbot = convergeBranch.match(/phase = 'BUGBOT'/g) || [];
+  assert.equal(toBugbot.length, 2, 'expected the standards-only and all-clean branches to both set phase = BUGBOT');
+  assert.doesNotMatch(convergeBranch, /phase = 'COPILOT'/, 'expected the CONVERGE block to route to BUGBOT, not straight to COPILOT');
+});
+
+test('the terminal BUGBOT phase skips runBugbotLens when the reviewer-availability gate reports Bugbot down', () => {
+  const bugbotPhase = sliceBetween("if (phase === 'BUGBOT') {", "if (phase === 'COPILOT') {");
+  const availabilityGateIndex = bugbotPhase.indexOf('resolveReviewerDown(reviewerAvailability?.bugbot, input.bugbotDisabled || false)');
+  const gateCallIndex = bugbotPhase.indexOf('await runBugbotLens(head, reviewerAvailability)');
+  assert.notEqual(availabilityGateIndex, -1, 'expected the terminal gate to consult resolveReviewerDown before spawning the Bugbot lens');
+  assert.notEqual(gateCallIndex, -1, 'expected the terminal gate to call runBugbotLens when Bugbot is enabled');
+  assert.ok(availabilityGateIndex < gateCallIndex, 'expected the availability gate to short-circuit before any Bugbot agent spawns');
+  const beforeGate = bugbotPhase.slice(availabilityGateIndex, gateCallIndex);
+  assert.match(beforeGate, /bugbotDown = true/, 'expected the availability-down path to mark bugbotDown');
+  assert.match(beforeGate, /phase = 'COPILOT'/, 'expected the availability-down path to advance to the Copilot gate with no agent');
+});
+
+test('the terminal BUGBOT phase classifies via the shared reviewer-gate classifier and routes each outcome', () => {
+  const bugbotPhase = sliceBetween("if (phase === 'BUGBOT') {", "if (phase === 'COPILOT') {");
+  assert.match(bugbotPhase, /classifyReviewerGateOutcome\(bugbot\)/, 'expected the terminal gate to reuse the shared reviewer-gate classifier');
+  assert.match(bugbotPhase, /applyFixes\(head, bugbotOutcome\.findings, 'bugbot'\)/, 'expected a Bugbot fix outcome to route through applyFixes');
+  assert.match(bugbotPhase, /head = null\n\s*phase = 'CONVERGE'/, 'expected a Bugbot fix to invalidate head and re-enter CONVERGE');
+  assert.match(bugbotPhase, /phase = 'COPILOT'/, 'expected a clean or down Bugbot verdict to advance to the Copilot gate');
+});
+
+test('convergeReadOnlyAgent exists and the read-only preamble omits the rm-shape paragraph the edit preamble keeps', () => {
+  assert.match(convergeSource, /const convergeReadOnlyAgent = \(prompt, options\) =>/, 'expected the read-only agent spawner to exist');
+  const preambleRegion = convergeSource.slice(
+    convergeSource.indexOf('const HEADLESS_EDIT_PREAMBLE ='),
+    convergeSource.indexOf('\nlet activeRepoPath'),
+  );
+  const preambleModule = new Function(
+    `${preambleRegion}\nreturn { HEADLESS_EDIT_PREAMBLE, HEADLESS_READONLY_PREAMBLE };`,
+  )();
+  assert.match(preambleModule.HEADLESS_EDIT_PREAMBLE, /rm shape rules/, 'expected the edit preamble to retain the rm-shape rules');
+  assert.doesNotMatch(preambleModule.HEADLESS_READONLY_PREAMBLE, /rm shape rules/, 'expected the read-only preamble to drop the rm-shape paragraph');
+  assert.ok(
+    preambleModule.HEADLESS_READONLY_PREAMBLE.length < preambleModule.HEADLESS_EDIT_PREAMBLE.length,
+    'expected the read-only preamble to be shorter than the edit preamble',
+  );
+});
+
+test('COMMIT_RECOVERY_MAX_ATTEMPTS is one and bounds the commitWithRecovery loop', () => {
+  assert.match(convergeSource, /const COMMIT_RECOVERY_MAX_ATTEMPTS = 1/, 'expected a dedicated commit-recovery cap of one');
+  assert.match(convergeSource, /const FIX_RECOVERY_MAX_ATTEMPTS = 2/, 'expected the wider verify-recovery cap to stay at two');
+  const commitBody = functionSource('commitWithRecovery');
+  assert.match(commitBody, /attempt < COMMIT_RECOVERY_MAX_ATTEMPTS/, 'expected commitWithRecovery to bound its loop by the dedicated cap');
+});

package/skills/autoconverge/workflow/converge.run-input.test.mjs

@@ -22,7 +22,7 @@ const productionModule = new Function(
 
 const { normalizeRunInput, classifyRunInput } = productionModule;
 
-const VALID_COORDINATES = { owner: 'jl-cmd', repo: 'claude-code-config', prNumber: 543 };
+const VALID_COORDINATES = { owner: 'jl-cmd', repo: 'claude-dev-env', prNumber: 543 };
 
 test('an object payload passes through unchanged', () => {
   assert.deepEqual(normalizeRunInput(VALID_COORDINATES), VALID_COORDINATES);
@@ -59,13 +59,13 @@ test('classifyRunInput blocks a null payload with a structured blocker', () => {
 });
 
 test('classifyRunInput blocks a payload missing owner', () => {
-  const classified = classifyRunInput({ repo: 'claude-code-config', prNumber: 543 });
+  const classified = classifyRunInput({ repo: 'claude-dev-env', prNumber: 543 });
   assert.equal(classified.input, null);
   assert.match(classified.blocker, /coordinates/i);
 });
 
 test('classifyRunInput blocks a payload missing prNumber', () => {
-  const classified = classifyRunInput({ owner: 'jl-cmd', repo: 'claude-code-config' });
+  const classified = classifyRunInput({ owner: 'jl-cmd', repo: 'claude-dev-env' });
   assert.equal(classified.input, null);
   assert.match(classified.blocker, /coordinates/i);
 });

package/skills/autoconverge/workflow/converge_multi.run-input.test.mjs

@@ -38,15 +38,15 @@ const SCRIPT_PATH = '/abs/skills/autoconverge/workflow/converge.mjs';
 
 function validEntry(prNumber) {
   return {
-    owner: 'JonEcho',
-    repo: 'python-automation',
+    owner: 'example-org',
+    repo: 'example-repo',
     prNumber,
     repoPath: `/worktrees/pr-${prNumber}`,
   };
 }
 
 function validArgs() {
-  return { convergeScriptPath: SCRIPT_PATH, prs: [validEntry(398), validEntry(402)] };
+  return { convergeScriptPath: SCRIPT_PATH, prs: [validEntry(101), validEntry(102)] };
 }
 
 test('an object payload passes through unchanged', () => {
@@ -69,7 +69,7 @@ test('valid coordinates classify with no blocker and keep every PR entry', () =>
 });
 
 test('a missing convergeScriptPath is blocked', () => {
-  const classified = classifyMultiInput({ prs: [validEntry(398)] });
+  const classified = classifyMultiInput({ prs: [validEntry(101)] });
   assert.equal(classified.input, null);
   assert.match(classified.blocker, /convergeScriptPath/);
 });
@@ -93,14 +93,14 @@ test('a non-array prs value is blocked', () => {
 });
 
 test('an entry missing prNumber is blocked', () => {
-  const badEntry = { owner: 'JonEcho', repo: 'python-automation', repoPath: '/w/x' };
+  const badEntry = { owner: 'example-org', repo: 'example-repo', repoPath: '/w/x' };
   const classified = classifyMultiInput({ convergeScriptPath: SCRIPT_PATH, prs: [badEntry] });
   assert.equal(classified.input, null);
   assert.match(classified.blocker, /missing/);
 });
 
 test('an entry missing repoPath is blocked', () => {
-  const badEntry = { owner: 'JonEcho', repo: 'python-automation', prNumber: 398 };
+  const badEntry = { owner: 'example-org', repo: 'example-repo', prNumber: 101 };
   const classified = classifyMultiInput({ convergeScriptPath: SCRIPT_PATH, prs: [badEntry] });
   assert.equal(classified.input, null);
   assert.match(classified.blocker, /missing/);
@@ -113,29 +113,29 @@ test('a null payload is blocked', () => {
 });
 
 test('childRunInput forwards the PR coordinates to the child run', () => {
-  const childArgs = childRunInput(validEntry(398));
-  assert.equal(childArgs.owner, 'JonEcho');
-  assert.equal(childArgs.repo, 'python-automation');
-  assert.equal(childArgs.prNumber, 398);
-  assert.equal(childArgs.repoPath, '/worktrees/pr-398');
+  const childArgs = childRunInput(validEntry(101));
+  assert.equal(childArgs.owner, 'example-org');
+  assert.equal(childArgs.repo, 'example-repo');
+  assert.equal(childArgs.prNumber, 101);
+  assert.equal(childArgs.repoPath, '/worktrees/pr-101');
 });
 
 test('childRunInput forwards copilotDisabled true when the entry opts out', () => {
-  const optedOutEntry = { ...validEntry(398), copilotDisabled: true };
+  const optedOutEntry = { ...validEntry(101), copilotDisabled: true };
   assert.equal(childRunInput(optedOutEntry).copilotDisabled, true);
 });
 
 test('childRunInput defaults copilotDisabled to false when the entry omits it', () => {
-  assert.equal(childRunInput(validEntry(398)).copilotDisabled, false);
+  assert.equal(childRunInput(validEntry(101)).copilotDisabled, false);
 });
 
 test('childRunInput forwards bugbotDisabled true when the entry opts out', () => {
-  const optedOutEntry = { ...validEntry(398), bugbotDisabled: true };
+  const optedOutEntry = { ...validEntry(101), bugbotDisabled: true };
   assert.equal(childRunInput(optedOutEntry).bugbotDisabled, true);
 });
 
 test('childRunInput defaults bugbotDisabled to false when the entry omits it', () => {
-  assert.equal(childRunInput(validEntry(398)).bugbotDisabled, false);
+  assert.equal(childRunInput(validEntry(101)).bugbotDisabled, false);
 });
 
 test('the malformed-input blocker return carries an empty allDeferredPrs list', async () => {

package/skills/autoconverge/workflow/test_convergence_summary.py

@@ -32,7 +32,7 @@ def test_prompt_carries_pr_coordinates_and_round_count() -> None:
     """Should name the PR coordinates and the aggregated round count."""
     prompt = convergence_summary.build_summary_prompt(
         owner="jl-cmd",
-        repo="claude-code-config",
+        repo="claude-dev-env",
         pr_number=581,
         round_count=39,
         findings=SAMPLE_FINDINGS,
@@ -41,17 +41,17 @@ def test_prompt_carries_pr_coordinates_and_round_count() -> None:
         copilot_note=None,
     )
 
-    assert "owner=jl-cmd repo=claude-code-config PR #581" in prompt
-    assert "https://github.com/jl-cmd/claude-code-config/pull/581" in prompt
+    assert "owner=jl-cmd repo=claude-dev-env PR #581" in prompt
+    assert "https://github.com/jl-cmd/claude-dev-env/pull/581" in prompt
     assert "convergence in 39 round(s)" in prompt
-    assert "gh api repos/jl-cmd/claude-code-config/pulls/581" in prompt
+    assert "gh api repos/jl-cmd/claude-dev-env/pulls/581" in prompt
 
 
 def test_prompt_instructs_plain_json_object_not_structured_output() -> None:
     """Should instruct a plain JSON object answer and never name the StructuredOutput tool."""
     prompt = convergence_summary.build_summary_prompt(
         owner="jl-cmd",
-        repo="claude-code-config",
+        repo="claude-dev-env",
         pr_number=581,
         round_count=39,
         findings=SAMPLE_FINDINGS,
@@ -68,7 +68,7 @@ def test_prompt_numbers_every_finding_with_severity_and_location() -> None:
     """Should list each aggregated finding numbered with severity, file, and line."""
     prompt = convergence_summary.build_summary_prompt(
         owner="jl-cmd",
-        repo="claude-code-config",
+        repo="claude-dev-env",
         pr_number=581,
         round_count=39,
         findings=SAMPLE_FINDINGS,

package/skills/bdd-protocol/SKILL.md

@@ -1,11 +1,10 @@
 ---
 name: bdd-protocol
 description: >-
-  On-demand BDD depth aligned with jl-cmd/claude-code-config#82: Example Mapping (Smart &
-  Molak §6.4), scenario quality and anti-patterns (§7.6), solo minimal BDD, outside-in test
-  layout. Use when expanding `<behavior_protocol>` in the system prompt, writing executable
-  specifications, or when the user asks for discovery, "the one where" examples, or BDD
-  scenario quality. Triggers: bdd-protocol, Example Mapping, BDD anti-patterns, §7.6.
+  On-demand BDD depth: Example Mapping, scenario quality and anti-patterns, solo
+  minimal BDD, and outside-in test layout. Use when expanding `<behavior_protocol>`,
+  writing executable specifications, or giving 'the one where' examples.
+  Triggers: bdd-protocol, Example Mapping, BDD anti-patterns, §7.6.
 ---
 @~/.claude/skills/bdd-protocol/references/example-mapping.md
 @~/.claude/skills/bdd-protocol/references/anti-patterns.md

package/skills/bdd-protocol/references/anti-patterns.md

@@ -1,6 +1,6 @@
 # Scenario quality and anti-patterns (§7.6 and related)
 
-Use this as a **checklist** when writing or reviewing scenarios and developer-facing specifications. Phrasing follows *BDD in Action* 2e and the catalog summarized in [claude-code-config#82](https://github.com/jl-cmd/claude-code-config/issues/82).
+Use this as a **checklist** when writing or reviewing scenarios and developer-facing specifications. Phrasing follows *BDD in Action* 2e and the catalog summarized in [claude-dev-env#82](https://github.com/jl-cmd/claude-dev-env/issues/82).
 
 ## Positive targets (what "good" looks like)
 

package/skills/bugteam/SKILL.md

@@ -18,6 +18,14 @@ The audit agent loads the A–P category rubrics from
 `$HOME/.claude/audit-rubrics/{category_rubrics,prompts}/` alongside
 [`PROMPTS.md`](PROMPTS.md) and produces a single outcome XML per loop.
 
+## Transport check (before any GitHub step)
+
+Run `command -v gh`; when it succeeds, run `gh auth status`; once the PR
+scope is resolved, run `gh api repos/<owner>/<repo> --jq .permissions.push`
+and take `true` as the pass. When any check fails, run the
+`pr-loop-cloud-transport` skill first and route every `gh` operation in this
+skill through its substitution matrix.
+
 ## Pre-flight
 
 ```bash

package/skills/bugteam/reference/copilot-gap-analysis.md

@@ -2,7 +2,7 @@
 
 > **Status: HISTORICAL — patch plan partially superseded.**
 >
-> This file documents the read-only investigation that motivated the K–N rubric addendum and the Step 2.6 / Step 3.5 standards-review phases. **The audit-rubric portion of the patch plan was reverted in [PR #292](https://github.com/jl-cmd/claude-code-config/pull/292):** PROMPTS.md no longer carries the K–N addendum or the `<copilot_derived_addendum_source>` block, and SKILL.md no longer runs the Step 2.6 / Step 3.5 standards-review phases.
+> This file documents the read-only investigation that motivated the K–N rubric addendum and the Step 2.6 / Step 3.5 standards-review phases. **The audit-rubric portion of the patch plan was reverted in [PR #292](https://github.com/jl-cmd/claude-dev-env/pull/292):** PROMPTS.md no longer carries the K–N addendum or the `<copilot_derived_addendum_source>` block, and SKILL.md no longer runs the Step 2.6 / Step 3.5 standards-review phases.
 >
 > **What replaced K–N (partial coverage):** several judgment-heavy categories now have deterministic validators in `code_rules_enforcer.py` — `check_collection_prefix` (category K), `check_library_print` (category L), `check_inline_literal_collections`, `check_loop_variable_naming`, `check_parameter_annotations`, `check_return_annotations`. These validators are exercised by `bugteam_code_rules_gate.py` during the bugteam pre-audit / loop, and by the shipped repo `pre-commit` / `pre-push` git hooks that invoke that gate. They are **not** wired into the repo's default `PreToolUse` Write|Edit hook list in `packages/claude-dev-env/hooks/hooks.json`, so they do not block at Write/Edit time by default — enforcement comes from the gate (audit-time) and the git hooks (commit/push-time).
 >
@@ -12,7 +12,7 @@
 
 This file is the reference record produced by the read-only investigation of why the `/bugteam` audit/fix loop and `bugteam_code_rules_gate.py` repeatedly miss the classes of code-quality violations that the GitHub Copilot reviewer raises on follow-up review rounds. It is written so future bugteam runs can skim the inventory, the rubric/validator coverage diffs, and the patch plan without re-deriving them.
 
-Sources of truth cited below: `~/.claude/docs/CODE_RULES.md`, `~/.claude/CLAUDE.md`, `~/.claude/rules/file-global-constants.md`, `~/.claude/skills/bugteam/SKILL.md`, `~/.claude/skills/bugteam/PROMPTS.md`, `~/.claude/skills/bugteam/CONSTRAINTS.md`, `~/.claude/skills/bugteam/scripts/bugteam_code_rules_gate.py`, `~/.claude/skills/bugteam/scripts/bugteam_preflight.py`, `~/.claude/hooks/blocking/code_rules_enforcer.py`, plus `gh api repos/JonEcho/python-automation/pulls/{70,73}/comments` filtered to author `Copilot`.
+Sources of truth cited below: `~/.claude/docs/CODE_RULES.md`, `~/.claude/CLAUDE.md`, `~/.claude/rules/file-global-constants.md`, `~/.claude/skills/bugteam/SKILL.md`, `~/.claude/skills/bugteam/PROMPTS.md`, `~/.claude/skills/bugteam/CONSTRAINTS.md`, `~/.claude/skills/bugteam/scripts/bugteam_code_rules_gate.py`, `~/.claude/skills/bugteam/scripts/bugteam_preflight.py`, `~/.claude/hooks/blocking/code_rules_enforcer.py`, plus `gh api repos/example-org/example-repo/pulls/{101,102}/comments` filtered to author `Copilot`.
 
 ---
 
@@ -23,22 +23,22 @@ Sources of truth cited below: `~/.claude/docs/CODE_RULES.md`, `~/.claude/CLAUDE.
 Copilot review comments fetched with:
 
 ```
-gh api repos/JonEcho/python-automation/pulls/70/comments --paginate --jq '.[] | select(.user.login == "Copilot")'
-gh api repos/JonEcho/python-automation/pulls/73/comments --paginate --jq '.[] | select(.user.login == "Copilot")'
+gh api repos/example-org/example-repo/pulls/101/comments --paginate --jq '.[] | select(.user.login == "Copilot")'
+gh api repos/example-org/example-repo/pulls/102/comments --paginate --jq '.[] | select(.user.login == "Copilot")'
 ```
 
-PR #70 head SHA `29117309cf4ec1e83883160d8c819e0843f9c3ac` (merged). PR #73 head SHA `c9c935a96cc59d39d623dc7eddda3d341007607c` (merged); Copilot reviewed at original commit `e4abf52c3a6c724b4e64bfed0d979cd60a2c8bf0`.
+PR #101 head SHA `29117309cf4ec1e83883160d8c819e0843f9c3ac` (merged). PR #102 head SHA `c9c935a96cc59d39d623dc7eddda3d341007607c` (merged); Copilot reviewed at original commit `e4abf52c3a6c724b4e64bfed0d979cd60a2c8bf0`.
 
 | finding_id | pr_number | file:line | rule_cited | severity | mapped_bugteam_category_letter | layer_that_should_have_caught_it |
 |---|---|---|---|---|---|---|
-| 3153098661 | 70 | `shared_utils/theme_db/writer.py:158` | Magic values — column-name string literals (`"theme_name"`, `"content_id"`, …) hardcoded inside SQL builder bodies (CODE_RULES.md §⚡ Magic values; J) | P1 | J | bugteam pre-flight gate (`bugteam_code_rules_gate.py`) — string literals are masked by `_mask_string_literals_preserving_length`, so the number-only magic-value detector never sees them; bugteam audit rubric (J) names the rule but the regex passes |
-| 3153098689 | 70 | `shared_utils/theme_db/writer.py:361` | File-length / function-length / SRP smell (`write_outcome` >30 lines, module 446 lines exceeds the 400-line advisory) | P2 | none | initial+final standards-review phases bracketing the loop — no rubric letter exists; the existing 400/1000-line advisory in `code_rules_enforcer.advise_file_line_count` is stderr-only and never blocks |
-| 3153098727 | 70 | `shared_utils/theme_db/summary.py:267` | Library `print()` calls in non-CLI library code (CODE_RULES.md §Self-Documenting Code; "Make output stream explicit" practice) | P1 | none | harness PreToolUse hook (`code_rules_enforcer.py`) — no detector exists for `print(`/`sys.stdout.write` inside library modules |
-| 3153098762 | 70 | `shared_utils/theme_db/summary.py:263` | PR-description spec drift — banner missing column-header rows promised in PR body | P2 | A (loosely) | initial+final standards-review phases — A is signature/async-shaped, not "promised behavior vs implementation" shaped |
-| 3153098782 | 70 | `shared_utils/theme_db/writer.py:125` | Naming clarity — `_is_set_column_value` reads like it excludes `None` but does not | P2 | none | bugteam audit rubric addendum — no naming-clarity category in A–J |
-| 3153475246 | 73 | `shared_utils/theme_db/config/constants.py:91` | Collection naming — `THEMES_INSERT_REQUIRED_COLUMN_NAMES` is a tuple and must use the `ALL_*` prefix (CODE_RULES.md §5 "Extended naming rules" → Collections: `all_orders`, `all_users`) | P1 | none | harness PreToolUse hook AND bugteam pre-flight gate — no detector for the collection-prefix rule. Reproduced at `e4abf52c`; renamed to `ALL_THEMES_INSERT_REQUIRED_COLUMN_NAMES` in the merged PR head |
-| 3153475297 | 73 | `shared_utils/theme_db/writer.py:296` | Collection naming — parameter `column_value_pairs` is a list and must use the `all_*` prefix | P1 | none | harness PreToolUse hook AND bugteam pre-flight gate — same gap as 3153475246 for parameter names |
-| 3153475331 | 73 | `shared_utils/theme_db/summary.py:206` (referenced; underlying defect is in `shared_utils/theme_db/tracker.py` `flush()`) | Wrapper plumb-through — public `tracker.flush(*, output_folder)` silently drops `loud_banner_stream` that `ThemeDatabaseWriteSummary.flush(*, output_folder, loud_banner_stream=None)` accepts | P1 | A (loosely) | bugteam audit rubric addendum — A focuses on signatures/return types, not on whether a wrapper preserves the optional kwargs of the function it delegates to |
+| 3153098661 | 101 | `shared_utils/theme_db/writer.py:158` | Magic values — column-name string literals (`"theme_name"`, `"content_id"`, …) hardcoded inside SQL builder bodies (CODE_RULES.md §⚡ Magic values; J) | P1 | J | bugteam pre-flight gate (`bugteam_code_rules_gate.py`) — string literals are masked by `_mask_string_literals_preserving_length`, so the number-only magic-value detector never sees them; bugteam audit rubric (J) names the rule but the regex passes |
+| 3153098689 | 101 | `shared_utils/theme_db/writer.py:361` | File-length / function-length / SRP smell (`write_outcome` >30 lines, module 446 lines exceeds the 400-line advisory) | P2 | none | initial+final standards-review phases bracketing the loop — no rubric letter exists; the existing 400/1000-line advisory in `code_rules_enforcer.advise_file_line_count` is stderr-only and never blocks |
+| 3153098727 | 101 | `shared_utils/theme_db/summary.py:267` | Library `print()` calls in non-CLI library code (CODE_RULES.md §Self-Documenting Code; "Make output stream explicit" practice) | P1 | none | harness PreToolUse hook (`code_rules_enforcer.py`) — no detector exists for `print(`/`sys.stdout.write` inside library modules |
+| 3153098762 | 101 | `shared_utils/theme_db/summary.py:263` | PR-description spec drift — banner missing column-header rows promised in PR body | P2 | A (loosely) | initial+final standards-review phases — A is signature/async-shaped, not "promised behavior vs implementation" shaped |
+| 3153098782 | 101 | `shared_utils/theme_db/writer.py:125` | Naming clarity — `_is_set_column_value` reads like it excludes `None` but does not | P2 | none | bugteam audit rubric addendum — no naming-clarity category in A–J |
+| 3153475246 | 102 | `shared_utils/theme_db/config/constants.py:91` | Collection naming — `THEMES_INSERT_REQUIRED_COLUMN_NAMES` is a tuple and must use the `ALL_*` prefix (CODE_RULES.md §5 "Extended naming rules" → Collections: `all_orders`, `all_users`) | P1 | none | harness PreToolUse hook AND bugteam pre-flight gate — no detector for the collection-prefix rule. Reproduced at `e4abf52c`; renamed to `ALL_THEMES_INSERT_REQUIRED_COLUMN_NAMES` in the merged PR head |
+| 3153475297 | 102 | `shared_utils/theme_db/writer.py:296` | Collection naming — parameter `column_value_pairs` is a list and must use the `all_*` prefix | P1 | none | harness PreToolUse hook AND bugteam pre-flight gate — same gap as 3153475246 for parameter names |
+| 3153475331 | 102 | `shared_utils/theme_db/summary.py:206` (referenced; underlying defect is in `shared_utils/theme_db/tracker.py` `flush()`) | Wrapper plumb-through — public `tracker.flush(*, output_folder)` silently drops `loud_banner_stream` that `ThemeDatabaseWriteSummary.flush(*, output_folder, loud_banner_stream=None)` accepts | P1 | A (loosely) | bugteam audit rubric addendum — A focuses on signatures/return types, not on whether a wrapper preserves the optional kwargs of the function it delegates to |
 
 ### Rubric coverage diff
 
@@ -77,7 +77,7 @@ Source: every detector inside `~/.claude/hooks/blocking/code_rules_enforcer.py`
 - `check_skip_decorators_in_tests` / `check_existence_check_tests` / `check_constant_equality_tests` (enforcer.py:1079-1277) — test-file checks. Catches none.
 - `check_unused_optional_parameters` (enforcer.py:1854-1933) — same-file callers must vary an optional parameter. Does not catch the inverse case where a wrapper drops an underlying function's optional kwarg from its own signature. Misses 3153475331.
 - `check_incomplete_mocks` / `check_duplicated_format_patterns` (enforcer.py:1746-1851) — advisory-only on test files / repeated f-strings. Catches none.
-- `advise_file_line_count` (enforcer.py:379-399) — soft advisory at 400, hard advisory at 1000; never blocking. Triggers on PR #70 `writer.py` (446 lines) but is stderr-only, so the bugteam gate exit code stays 0 and the audit/fix loop never sees the signal as a finding. Misses 3153098689 in practice.
+- `advise_file_line_count` (enforcer.py:379-399) — soft advisory at 400, hard advisory at 1000; never blocking. Triggers on PR #101 `writer.py` (446 lines) but is stderr-only, so the bugteam gate exit code stays 0 and the audit/fix loop never sees the signal as a finding. Misses 3153098689 in practice.
 
 `bugteam_code_rules_gate.py` adds no detectors of its own — `run_gate` (gate.py:379-443) only filters violations to the changed-line set and routes blocking/advisory output. Extending the gate without extending `validate_content` (or adding sibling detectors invoked from `run_gate`) cannot close the gap.
 
@@ -97,7 +97,7 @@ The bugteam audit rubric (PROMPTS.md §bug_categories A–J) and the determinist
 
 > **Historical — the rubric/phases portion below was reverted in PR #292.** Sections (a) PROMPTS.md K–N addendum, (b) Step 2.6 INITIAL standards review, and the FINAL standards review (Step 3.5) were reverted and replaced by deterministic validators (see status banner at the top of this file). Sections that landed deterministic validators in `code_rules_enforcer.py` (collection prefix, library print, string-literal magic, inline literal collections, loop-variable naming, parameter/return annotations) remain in force. Treat the rubric/phase sections below as record-of-what-was-tried, not a current to-do list.
 
-Each section names exactly one target file, the literal text or regex to add, and a verification step that re-runs the new detection against the PR #70 / PR #73 diffs.
+Each section names exactly one target file, the literal text or regex to add, and a verification step that re-runs the new detection against the PR #101 / PR #102 diffs.
 
 ### a. `~/.claude/skills/bugteam/PROMPTS.md`
 
@@ -143,7 +143,7 @@ Each section names exactly one target file, the literal text or regex to add, an
 
 <copilot_derived_addendum_source>
   The K–N categories were added after Copilot raised real findings on
-  PR #70 (writer.py / summary.py) and PR #73 (constants.py / writer.py /
+  PR #101 (writer.py / summary.py) and PR #102 (constants.py / writer.py /
   tracker.py) that converged "0 P0 / 0 P1 / 0 P2" under the original
   A–J rubric. See ~/.claude/skills/bugteam/reference/copilot-gap-analysis.md
   for the inventory and the validators that now back categories K and L.
@@ -158,7 +158,7 @@ Each section names exactly one target file, the literal text or regex to add, an
 python $HOME/.claude/skills/bugteam/scripts/bugteam_code_rules_gate.py /tmp/pr70_writer.py /tmp/pr70_summary.py /tmp/pr73_constants.py /tmp/pr73_writer.py
 ```
 
-Run after the K and L deterministic detectors land in §c/d below; the categories M and N stay rubric-only and are exercised by replaying PR #70 / PR #73 through `/bugteam` with the new PROMPTS.md and observing that the audit posts findings keyed to lines 158 (M), 125 (rubric N — naming clarity), 263 (rubric N — PR-description drift), 361 (initial/final standards review — file length), and 206 (N — wrapper plumb-through).
+Run after the K and L deterministic detectors land in §c/d below; the categories M and N stay rubric-only and are exercised by replaying PR #101 / PR #102 through `/bugteam` with the new PROMPTS.md and observing that the audit posts findings keyed to lines 158 (M), 125 (rubric N — naming clarity), 263 (rubric N — PR-description drift), 361 (initial/final standards review — file length), and 206 (N — wrapper plumb-through).
 
 ### b. `~/.claude/skills/bugteam/SKILL.md`
 
@@ -228,7 +228,7 @@ Loop log:
 **Verification step:**
 
 ```
-gh pr diff 70 -R JonEcho/python-automation > /tmp/pr70.diff && gh pr diff 73 -R JonEcho/python-automation > /tmp/pr73.diff && /bugteam --dry-run --replay 70 73
+gh pr diff 101 -R example-org/example-repo > /tmp/pr101.diff && gh pr diff 102 -R example-org/example-repo > /tmp/pr102.diff && /bugteam --dry-run --replay 101 102
 ```
 
 Followed by reading `<team_temp_dir>/pr-70/initial-review.outcomes.xml` and `final-review.outcomes.xml` to confirm Copilot finding ids 3153098661, 3153098689, 3153098727, 3153098762, 3153098782, 3153475246, 3153475297, 3153475331 are surfaced as new entries in either the INITIAL or FINAL review (or both) and that `Step 3.5` upgrades the exit reason when any P0/P1 finding remains.
@@ -505,7 +505,7 @@ Expected output after the patch lands: a list containing `Line 91: Collection co
 
 ## Cross-references
 
-- Inventory data sources: live `gh api repos/JonEcho/python-automation/pulls/{70,73}/comments` filtered to `Copilot`; verbatim bodies preserved in the inventory table above.
-- Original-commit content used to confirm violations: PR #70 head `29117309cf4ec1e83883160d8c819e0843f9c3ac`; PR #73 review-time commit `e4abf52c3a6c724b4e64bfed0d979cd60a2c8bf0`; PR #73 merged head `c9c935a96cc59d39d623dc7eddda3d341007607c`.
+- Inventory data sources: live `gh api repos/example-org/example-repo/pulls/{101,102}/comments` filtered to `Copilot`; verbatim bodies preserved in the inventory table above.
+- Original-commit content used to confirm violations: PR #101 head `29117309cf4ec1e83883160d8c819e0843f9c3ac`; PR #102 review-time commit `e4abf52c3a6c724b4e64bfed0d979cd60a2c8bf0`; PR #102 merged head `c9c935a96cc59d39d623dc7eddda3d341007607c`.
 - CODE_RULES.md sections invoked by the patch plan: §⚡ Magic values; §5 Extended naming rules (collections `all_orders`, `all_users`); §6.5 File length guidance; §7 Right-Sized Engineering; §10 No redundant data fetches (used as analogue for wrapper plumb-through).
 - Constraints honored: `gh-body-file` (no `gh ... --body` calls in the new code paths), `no-shell-substitution` (no `$(...)` in the verification commands above; multi-step shell flows are written as separate Bash invocations or `&&`-chained literal strings).

package/skills/bugteam/reference/obstacles/audit-walk-categories.md

@@ -6,7 +6,7 @@ Audit every category A through P. Each returns Shape A finding or Shape B verifi
 
 Hit a wall on this step? Spawn a background agent to record it. Keep working.
 
-1. Spawn `Agent(run_in_background=true)` — brief it: check `jl-cmd/claude-code-config` for an open PR touching this file, add a commit to it, or create a fresh branch + worktree + draft PR.
+1. Spawn `Agent(run_in_background=true)` — brief it: check `jl-cmd/claude-dev-env` for an open PR touching this file, add a commit to it, or create a fresh branch + worktree + draft PR.
 2. Tell the agent your obstacle and what fixed it. It writes the entry below.
 
 ## Obstacles

package/skills/bugteam/reference/team-setup.md

@@ -137,7 +137,7 @@ Shape: dict keyed by `finding_id`. Each value: `{finding_comment_id, finding_com
 
 When `/bugteam` runs against multiple PRs across repos, each PR operates as a
 logical sub-team within the master `bugteam` team. The PR identity token is
-`{owner}/{repo}#{N}` (e.g. `jl-cmd/claude-code-config#422`). The slugified form
+`{owner}/{repo}#{N}` (e.g. `jl-cmd/claude-dev-env#422`). The slugified form
 comes from `slugify_pr_identity(owner, repo, pr_number)` in
 [`_path_resolver.py`](../../_shared/pr-loop/scripts/_path_resolver.py).
 
@@ -154,7 +154,9 @@ Self-claiming by task subject prefix keeps each teammate on its assigned PR.
 run` issue comment via the Step 2.5 issue-comments fallback endpoint after
 every successful FIX push, to re-trigger Cursor's bugbot on the new commit.
 
-**Opt-out gate.** When `CLAUDE_REVIEWS_DISABLED` (comma-separated,
-case-insensitive, whitespace-tolerant) contains the token `bugbot`, the FIX
-subagent skips the re-trigger post even when the flag is present. The rest of
-the bugteam audit/fix cycle continues unchanged.
+**Availability gate.** Cursor Bugbot is off by default. The FIX subagent
+posts the re-trigger only when bugbot is enabled for the run — when
+`CLAUDE_REVIEWS_ENABLED` (comma-separated, case-insensitive,
+whitespace-tolerant) lists `bugbot` and `CLAUDE_REVIEWS_DISABLED` does not.
+Otherwise it skips the re-trigger post even when the flag is present, and the
+rest of the bugteam audit/fix cycle continues unchanged.

package/skills/bugteam/scripts/reflow_skill_md.py

@@ -5,7 +5,7 @@ joined without a space only inside unfinished markdown link targets), then
 wrap with textwrap. Preserves fenced blocks verbatim.
 
 Same algorithm as ``packages/claude-dev-env/skills/pr-converge/scripts/reflow_skill_md.py``
-from https://github.com/jl-cmd/claude-code-config/pull/349 (branch
+from https://github.com/jl-cmd/claude-dev-env/pull/349 (branch
 ``cursor/pr-converge-skill-line-wrap-ecd1``); ``SKILL_PATH`` points at bugteam
 ``SKILL.md``. Link reference definitions (``[id]: url``) are treated as logical
 line starts so they are not merged with prior paragraphs.