claude-dev-env 1.89.0 → 1.92.0

package/hooks/blocking/test_pr_description_enforcer_proof_gate.py

@@ -0,0 +1,175 @@
+"""Entry-flow tests for the proof-of-work gates in pr_description_enforcer.
+
+Each test drives hook main() with a real Bash PreToolUse payload on stdin,
+mirroring test_pr_description_enforcer.py. The single gh subprocess boundary
+in pr_description_proof_of_work is patched with a fake runner, so command
+recognition, body extraction, and the proof audit run the production paths.
+"""
+
+import contextlib
+import importlib.util
+import io
+import json
+import pathlib
+import sys
+from unittest.mock import patch
+
+import pytest
+
+_HOOK_DIR = pathlib.Path(__file__).parent
+_HOOKS_ROOT = _HOOK_DIR.parent
+if str(_HOOKS_ROOT) not in sys.path:
+    sys.path.insert(0, str(_HOOKS_ROOT))
+if str(_HOOK_DIR) not in sys.path:
+    sys.path.insert(0, str(_HOOK_DIR))
+
+from blocking import pr_description_proof_of_work as proof_module  # noqa: E402
+from blocking import pr_description_readability as readability_module  # noqa: E402
+
+hook_spec = importlib.util.spec_from_file_location(
+    "pr_description_enforcer_proof_gate",
+    _HOOK_DIR / "pr_description_enforcer.py",
+)
+assert hook_spec is not None
+assert hook_spec.loader is not None
+hook_module = importlib.util.module_from_spec(hook_spec)
+hook_spec.loader.exec_module(hook_module)
+
+
+@pytest.fixture(autouse=True)
+def _isolate_readability_state(
+    tmp_path_factory: pytest.TempPathFactory, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    """Redirect the three readability state files to per-test temp paths.
+
+    The enabled file is written with enabled=False so readability scoring
+    stays out of these entry-flow tests and the live state directory is
+    never touched.
+    """
+    per_test_state_dir = tmp_path_factory.mktemp("proof_gate_readability_state")
+    monkeypatch.setattr(
+        readability_module, "READABILITY_STATE_FILE", per_test_state_dir / "strikes.json"
+    )
+    monkeypatch.setattr(
+        readability_module,
+        "READABILITY_THRESHOLD_OVERRIDE_FILE",
+        per_test_state_dir / "overrides.json",
+    )
+    enabled_path = per_test_state_dir / "enabled.json"
+    enabled_path.write_text(json.dumps({"enabled": False}))
+    monkeypatch.setattr(readability_module, "READABILITY_ENABLED_STATE_FILE", enabled_path)
+
+
+PASSING_PROOF_COMMENT_BODY = (
+    "## Summary\n\n"
+    "Recolored the launcher icons and checked every produced asset by hand "
+    "against the palette the plan names.\n\n"
+    "## Verification\n\n"
+    "```\n"
+    "C:\\Python313\\python.exe scripts/recolor.py --input themes/dawn\n"
+    "```\n\n"
+    "| Artifact | Measured |\n"
+    "| --- | --- |\n"
+    "| icons.zip | 48 files, 412,993 bytes |\n\n"
+    "This advances phase 2 of issue #12.\n\n"
+    "Known gap: the offline proof cannot show the on-device rendering; the "
+    "store preview covers that.\n"
+)
+
+ORDINARY_COMMENT_BODY = (
+    "The retry logic here mirrors what the uploader does for chunked "
+    "transfers, so the two stay in step."
+)
+
+
+def _run_hook_main_with_command(command: str) -> str:
+    hook_input_json = json.dumps({"tool_name": "Bash", "tool_input": {"command": command}})
+    captured_stdout = io.StringIO()
+    with (
+        patch("sys.stdin", io.StringIO(hook_input_json)),
+        patch("sys.stdout", captured_stdout),
+        contextlib.suppress(SystemExit),
+    ):
+        hook_module.main()
+    return captured_stdout.getvalue()
+
+
+def _install_fake_gh_responses(monkeypatch, all_comment_bodies, all_diff_names):
+    all_comment_records = [{"body": each_body} for each_body in all_comment_bodies]
+
+    def _fake_run_gh_command(all_gh_arguments):
+        if all_gh_arguments and all_gh_arguments[0] == "api":
+            return json.dumps([all_comment_records])
+        if "--name-only" in all_gh_arguments:
+            return "\n".join(all_diff_names)
+        if list(all_gh_arguments[:2]) == ["pr", "view"]:
+            return json.dumps({"number": 123})
+        if list(all_gh_arguments[:2]) == ["pr", "diff"]:
+            return ""
+        return None
+
+    monkeypatch.setattr(proof_module, "_run_gh_command", _fake_run_gh_command)
+
+
+def test_main_blocks_gh_pr_ready_without_proof_comment(monkeypatch: pytest.MonkeyPatch) -> None:
+    _install_fake_gh_responses(monkeypatch, [], ["src/parser.py"])
+    decision_output = _run_hook_main_with_command("gh pr ready 123")
+    assert "deny" in decision_output
+    assert "proof" in decision_output.lower()
+
+
+def test_main_allows_gh_pr_ready_with_passing_proof_comment(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    _install_fake_gh_responses(monkeypatch, [PASSING_PROOF_COMMENT_BODY], ["src/parser.py"])
+    decision_output = _run_hook_main_with_command("gh pr ready 123")
+    assert "deny" not in decision_output
+
+
+def test_main_allows_complete_proof_comment_post(
+    tmp_path: pathlib.Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    _install_fake_gh_responses(monkeypatch, [], ["src/parser.py"])
+    body_file = tmp_path / "proof.md"
+    body_file.write_text(PASSING_PROOF_COMMENT_BODY)
+    decision_output = _run_hook_main_with_command(f"gh pr comment 123 --body-file {body_file}")
+    assert "deny" not in decision_output
+
+
+def test_main_blocks_proof_comment_missing_visual_on_visual_change(
+    tmp_path: pathlib.Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    _install_fake_gh_responses(monkeypatch, [], ["assets/icon.png"])
+    body_file = tmp_path / "proof.md"
+    body_file.write_text(PASSING_PROOF_COMMENT_BODY)
+    decision_output = _run_hook_main_with_command(f"gh pr comment 123 --body-file {body_file}")
+    assert "deny" in decision_output
+    assert "visual" in decision_output
+
+
+def test_main_leaves_ordinary_comment_untouched(
+    tmp_path: pathlib.Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    all_recorded_calls: list[list[str]] = []
+
+    def _recording_run_gh_command(all_gh_arguments):
+        all_recorded_calls.append(list(all_gh_arguments))
+
+    monkeypatch.setattr(proof_module, "_run_gh_command", _recording_run_gh_command)
+    body_file = tmp_path / "comment.md"
+    body_file.write_text(ORDINARY_COMMENT_BODY)
+    decision_output = _run_hook_main_with_command(f"gh pr comment 123 --body-file {body_file}")
+    assert "deny" not in decision_output
+    assert all_recorded_calls == []
+
+
+def test_main_allows_gh_pr_ready_undo_without_queries(monkeypatch: pytest.MonkeyPatch) -> None:
+    all_recorded_calls: list[list[str]] = []
+
+    def _recording_run_gh_command(all_gh_arguments):
+        all_recorded_calls.append(list(all_gh_arguments))
+
+    monkeypatch.setattr(proof_module, "_run_gh_command", _recording_run_gh_command)
+    decision_output = _run_hook_main_with_command("gh pr ready 123 --undo")
+    assert "deny" not in decision_output
+    assert all_recorded_calls == []

package/hooks/blocking/test_pr_description_proof_of_work.py

@@ -0,0 +1,162 @@
+"""Behavior tests for the proof-of-work comment audit and gh pr ready gate.
+
+Each test drives the public audit surface of pr_description_proof_of_work
+with real comment bodies. The single gh subprocess boundary is patched with
+a fake runner, so parsing, part detection, and gate decisions all run the
+production code paths.
+"""
+
+import json
+import pathlib
+import sys
+
+import pytest
+
+_HOOK_DIR = pathlib.Path(__file__).parent
+_HOOKS_ROOT = _HOOK_DIR.parent
+if str(_HOOKS_ROOT) not in sys.path:
+    sys.path.insert(0, str(_HOOKS_ROOT))
+
+from blocking import pr_description_proof_of_work as proof_module  # noqa: E402
+from blocking.pr_description_proof_of_work import (  # noqa: E402
+    audit_proof_comment_body,
+    evaluate_pr_ready_gate,
+    is_pr_ready_command,
+    is_proof_shaped_body,
+)
+
+PASSING_PROOF_COMMENT_BODY = (
+    "## Summary\n\n"
+    "Recolored the launcher icons and checked every produced asset by hand "
+    "against the palette the plan names.\n\n"
+    "## Verification\n\n"
+    "```\n"
+    "C:\\Python313\\python.exe scripts/recolor.py --input themes/dawn\n"
+    "```\n\n"
+    "| Artifact | Measured |\n"
+    "| --- | --- |\n"
+    "| icons.zip | 48 files, 412,993 bytes |\n\n"
+    "This advances phase 2 of issue #12.\n\n"
+    "Known gap: the offline proof cannot show the on-device rendering; the "
+    "store preview covers that.\n"
+)
+
+VISUAL_PROOF_COMMENT_BODY = (
+    PASSING_PROOF_COMMENT_BODY + "\n![](https://placehold.co/20x20/AABBCC/AABBCC.png)\n"
+)
+
+BARE_PROOF_COMMENT_BODY = "## Verification\n\nLooks good overall to me.\n"
+
+ORDINARY_COMMENT_BODY = (
+    "The retry logic here mirrors what the uploader does for chunked "
+    "transfers, so the two stay in step."
+)
+
+
+def _install_fake_gh(monkeypatch, all_comment_bodies, all_diff_names, diff_text):
+    all_comment_records = [{"body": each_body} for each_body in all_comment_bodies]
+
+    def _fake_run_gh_command(all_gh_arguments):
+        if all_gh_arguments and all_gh_arguments[0] == "api":
+            return json.dumps([all_comment_records])
+        if list(all_gh_arguments[:2]) == ["pr", "view"]:
+            return json.dumps({"number": 77})
+        if "--name-only" in all_gh_arguments:
+            return "\n".join(all_diff_names)
+        if list(all_gh_arguments[:2]) == ["pr", "diff"]:
+            return diff_text
+        return None
+
+    monkeypatch.setattr(proof_module, "_run_gh_command", _fake_run_gh_command)
+
+
+def test_is_proof_shaped_body_detects_verification_heading() -> None:
+    assert is_proof_shaped_body(PASSING_PROOF_COMMENT_BODY)
+
+
+def test_is_proof_shaped_body_skips_ordinary_comment() -> None:
+    assert not is_proof_shaped_body(ORDINARY_COMMENT_BODY)
+
+
+def test_is_pr_ready_command_matches_ready() -> None:
+    assert is_pr_ready_command("gh pr ready 123")
+
+
+def test_is_pr_ready_command_skips_undo() -> None:
+    assert not is_pr_ready_command("gh pr ready 123 --undo")
+
+
+def test_is_pr_ready_command_matches_after_shell_operator() -> None:
+    assert is_pr_ready_command("git fetch && gh pr ready 5")
+
+
+def test_is_pr_ready_command_ignores_phrase_inside_commit_message() -> None:
+    assert not is_pr_ready_command(
+        'git commit -m "block gh pr ready without a proof comment"'
+    )
+
+
+def test_is_pr_ready_command_ignores_phrase_inside_search_argument() -> None:
+    assert not is_pr_ready_command('grep -r "gh pr ready" packages/')
+
+
+def test_audit_passes_complete_proof_on_non_visual_change(monkeypatch: pytest.MonkeyPatch) -> None:
+    _install_fake_gh(monkeypatch, [], ["src/parser.py"], "+ plain code line")
+    assert audit_proof_comment_body(PASSING_PROOF_COMMENT_BODY, 123) == []
+
+
+def test_audit_flags_missing_visual_on_image_diff(monkeypatch: pytest.MonkeyPatch) -> None:
+    _install_fake_gh(monkeypatch, [], ["assets/icon.png"], "")
+    all_missing_parts = audit_proof_comment_body(PASSING_PROOF_COMMENT_BODY, 123)
+    assert any("visual" in each_part for each_part in all_missing_parts)
+
+
+def test_audit_accepts_image_embed_on_image_diff(monkeypatch: pytest.MonkeyPatch) -> None:
+    _install_fake_gh(monkeypatch, [], ["assets/icon.png"], "")
+    assert audit_proof_comment_body(VISUAL_PROOF_COMMENT_BODY, 123) == []
+
+
+def test_audit_detects_visual_change_from_hex_colors(monkeypatch: pytest.MonkeyPatch) -> None:
+    _install_fake_gh(monkeypatch, [], ["src/theme.py"], '+ accent = "#AABBCC"')
+    all_missing_parts = audit_proof_comment_body(PASSING_PROOF_COMMENT_BODY, 123)
+    assert any("visual" in each_part for each_part in all_missing_parts)
+
+
+def test_audit_names_every_missing_part_of_bare_proof(monkeypatch: pytest.MonkeyPatch) -> None:
+    _install_fake_gh(monkeypatch, [], ["src/parser.py"], "")
+    all_missing_parts = audit_proof_comment_body(BARE_PROOF_COMMENT_BODY, 123)
+    assert len(all_missing_parts) == 4
+
+
+def test_ready_gate_blocks_when_no_proof_comment_exists(monkeypatch: pytest.MonkeyPatch) -> None:
+    _install_fake_gh(monkeypatch, [ORDINARY_COMMENT_BODY], ["src/parser.py"], "")
+    denial_reason = evaluate_pr_ready_gate("gh pr ready 123")
+    assert denial_reason is not None
+    assert "proof" in denial_reason.lower()
+
+
+def test_ready_gate_allows_with_passing_proof_comment(monkeypatch: pytest.MonkeyPatch) -> None:
+    _install_fake_gh(monkeypatch, [PASSING_PROOF_COMMENT_BODY], ["src/parser.py"], "")
+    assert evaluate_pr_ready_gate("gh pr ready 123") is None
+
+
+def test_ready_gate_blocks_when_proof_comment_is_incomplete(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    _install_fake_gh(monkeypatch, [BARE_PROOF_COMMENT_BODY], ["src/parser.py"], "")
+    denial_reason = evaluate_pr_ready_gate("gh pr ready 123")
+    assert denial_reason is not None
+    assert "123" in denial_reason
+    assert "proof" in denial_reason.lower()
+
+
+def test_ready_gate_fails_open_when_gh_is_unavailable(monkeypatch: pytest.MonkeyPatch) -> None:
+    monkeypatch.setattr(proof_module, "_run_gh_command", lambda all_gh_arguments: None)
+    assert evaluate_pr_ready_gate("gh pr ready 123") is None
+
+
+def test_ready_gate_resolves_pr_number_from_current_branch(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    _install_fake_gh(monkeypatch, [PASSING_PROOF_COMMENT_BODY], ["src/parser.py"], "")
+    assert evaluate_pr_ready_gate("gh pr ready") is None

package/hooks/blocking/test_precommit_code_rules_gate.py

@@ -40,6 +40,73 @@ def compute_total() -> int:
     return result
 '''
 
+WIDGET_MODULE_BASE_SOURCE = '''"""Arithmetic helpers used by the precommit gate worktree tests."""
+
+
+def add_one(number: int) -> int:
+    """Return *number* plus one.
+
+    Args:
+        number: The integer to increment.
+
+    Returns:
+        The incremented integer.
+    """
+    return number + 1
+'''
+
+WIDGET_MODULE_EXPANDED_SOURCE = '''"""Arithmetic helpers used by the precommit gate worktree tests."""
+
+
+def add_one(number: int) -> int:
+    """Return *number* plus one.
+
+    Args:
+        number: The integer to increment.
+
+    Returns:
+        The incremented integer.
+    """
+    return number + 1
+
+
+def subtract_one(number: int) -> int:
+    """Return *number* minus one.
+
+    Args:
+        number: The integer to decrement.
+
+    Returns:
+        The decremented integer.
+    """
+    return number - 1
+'''
+
+WIDGET_TEST_BASE_SOURCE = '''"""Behavior tests for the widget arithmetic helpers."""
+
+from widget import add_one
+
+
+def test_add_one_increments() -> None:
+    """add_one returns its argument plus one."""
+    assert add_one(1) == 2
+'''
+
+WIDGET_TEST_EXPANDED_SOURCE = '''"""Behavior tests for the widget arithmetic helpers."""
+
+from widget import add_one, subtract_one
+
+
+def test_add_one_increments() -> None:
+    """add_one returns its argument plus one."""
+    assert add_one(1) == 2
+
+
+def test_subtract_one_decrements() -> None:
+    """subtract_one returns its argument minus one."""
+    assert subtract_one(2) == 1
+'''
+
 
 def run_git(repository_root: Path, *git_arguments: str) -> None:
     subprocess.run(
@@ -124,3 +191,25 @@ def test_commit_with_no_staged_python_files_is_allowed(tmp_path: Path) -> None:
     completed_hook = run_hook("git commit -m docs", tmp_path)
     assert completed_hook.returncode == 0
     assert completed_hook.stdout.strip() == ""
+
+
+def test_worktree_commit_reads_worktree_paired_tests_not_sibling_checkout(
+    tmp_path: Path,
+) -> None:
+    main_checkout = tmp_path / "main_checkout"
+    main_checkout.mkdir()
+    initialize_repository(main_checkout)
+    (main_checkout / "widget.py").write_text(WIDGET_MODULE_BASE_SOURCE, encoding="utf-8")
+    (main_checkout / "test_widget.py").write_text(WIDGET_TEST_BASE_SOURCE, encoding="utf-8")
+    run_git(main_checkout, "add", "widget.py", "test_widget.py")
+    run_git(main_checkout, "commit", "-m", "base")
+    worktree_root = tmp_path / "sibling_worktree"
+    run_git(main_checkout, "worktree", "add", str(worktree_root), "-b", "feature")
+    stage_file(worktree_root, "widget.py", WIDGET_MODULE_EXPANDED_SOURCE)
+    stage_file(worktree_root, "test_widget.py", WIDGET_TEST_EXPANDED_SOURCE)
+    quoted_worktree = str(worktree_root)
+    completed_hook = run_hook(
+        f'git -C "{quoted_worktree}" commit -m expand', main_checkout
+    )
+    assert completed_hook.returncode == 0
+    assert completed_hook.stdout.strip() == ""

package/hooks/blocking/test_verdict_directory_write_blocker.py

@@ -736,6 +736,10 @@ def test_hook_subprocess_imports_real_config_when_parent_holds_shadowing_config(
         real_blocking_directory / "verdict_directory_write_blocker.py",
         staged_blocking_directory / "verdict_directory_write_blocker.py",
     )
+    shutil.copy(
+        real_blocking_directory / "verified_commit_config_bootstrap.py",
+        staged_blocking_directory / "verified_commit_config_bootstrap.py",
+    )
     shutil.copytree(
         real_blocking_directory / "config",
         staged_blocking_directory / "config",

package/hooks/blocking/test_verification_verdict_store.py

@@ -10,6 +10,7 @@ import json
 import pathlib
 import subprocess
 import sys
+from collections.abc import Callable
 
 import pytest
 
@@ -785,3 +786,13 @@ def test_manifest_hash_for_branch_cli_returns_nonzero_when_branch_absent(
     )
     assert completed_process.returncode != 0
     assert completed_process.stdout.strip() == ""
+
+
+def test_store_imports_under_foreign_config_shadow(
+    run_under_config_shadow: Callable[[str], subprocess.CompletedProcess[str]],
+) -> None:
+    completed_probe = run_under_config_shadow(
+        "import verification_verdict_store\nprint('IMPORT_OK')\n"
+    )
+    assert completed_probe.returncode == 0, completed_probe.stderr
+    assert "IMPORT_OK" in completed_probe.stdout

package/hooks/blocking/test_verified_commit_config_bootstrap.py

@@ -0,0 +1,49 @@
+"""Regression tests for the verified-commit constants bootstrap.
+
+These prove the shared constants module resolves to the sibling
+``config/verified_commit_constants.py`` file even when a foreign ``config``
+package sits ahead of ``blocking`` on ``sys.path``, and that a registration a
+caller placed first is left untouched.
+"""
+
+import subprocess
+from collections.abc import Callable
+
+RunUnderConfigShadow = Callable[[str], subprocess.CompletedProcess[str]]
+
+
+def test_register_binds_dotted_name_to_sibling_constants_file(
+    run_under_config_shadow: RunUnderConfigShadow,
+) -> None:
+    completed_probe = run_under_config_shadow(
+        "import verified_commit_config_bootstrap as bootstrap\n"
+        "bootstrap.register_verified_commit_constants()\n"
+        "import config.verified_commit_constants as loaded\n"
+        "print(loaded.__file__)\n"
+        "print(loaded.DETACHED_HEAD_LABEL)\n"
+    )
+    assert completed_probe.returncode == 0, completed_probe.stderr
+    assert "IS_DECOY_CONFIG" not in completed_probe.stdout
+    resolved_file_line, detached_head_line = completed_probe.stdout.splitlines()[:2]
+    assert resolved_file_line.replace("\\", "/").endswith(
+        "blocking/config/verified_commit_constants.py"
+    )
+    assert detached_head_line == "HEAD"
+
+
+def test_register_leaves_an_already_cached_module_untouched(
+    run_under_config_shadow: RunUnderConfigShadow,
+) -> None:
+    completed_probe = run_under_config_shadow(
+        "import sys\n"
+        "import types\n"
+        "sentinel = types.ModuleType('config.verified_commit_constants')\n"
+        "sentinel.ORIGIN = 'caller-seeded'\n"
+        "sys.modules['config.verified_commit_constants'] = sentinel\n"
+        "import verified_commit_config_bootstrap as bootstrap\n"
+        "bootstrap.register_verified_commit_constants()\n"
+        "import config.verified_commit_constants as loaded\n"
+        "print(getattr(loaded, 'ORIGIN', 'displaced'))\n"
+    )
+    assert completed_probe.returncode == 0, completed_probe.stderr
+    assert completed_probe.stdout.strip().splitlines()[-1] == "caller-seeded"

package/hooks/blocking/test_verified_commit_gate.py

@@ -12,6 +12,7 @@ import os
 import pathlib
 import subprocess
 import sys
+from collections.abc import Callable
 
 import pytest
 
@@ -568,3 +569,13 @@ def test_minted_verdict_from_other_worktree_with_wrong_hash_denies(
     deny_reason = deny_reason_for_directory(str(work_dir), str(transcript_path))
     assert deny_reason is not None
     assert "VERIFIED_COMMIT_GATE" in deny_reason
+
+
+def test_gate_imports_under_foreign_config_shadow(
+    run_under_config_shadow: Callable[[str], subprocess.CompletedProcess[str]],
+) -> None:
+    completed_probe = run_under_config_shadow(
+        "import verified_commit_gate\nprint('IMPORT_OK')\n"
+    )
+    assert completed_probe.returncode == 0, completed_probe.stderr
+    assert "IMPORT_OK" in completed_probe.stdout

package/hooks/blocking/test_verifier_verdict_minter.py

@@ -21,6 +21,7 @@ import json
 import pathlib
 import subprocess
 import sys
+from collections.abc import Callable
 
 _HOOK_DIR = pathlib.Path(__file__).parent
 if str(_HOOK_DIR) not in sys.path:
@@ -389,3 +390,13 @@ def test_attested_manifest_hash_binds_over_cwd_surface(tmp_path: pathlib.Path) -
     finally:
         if verdict_path is not None and verdict_path.exists():
             verdict_path.unlink()
+
+
+def test_minter_imports_under_foreign_config_shadow(
+    run_under_config_shadow: Callable[[str], subprocess.CompletedProcess[str]],
+) -> None:
+    completed_probe = run_under_config_shadow(
+        "import verifier_verdict_minter\nprint('IMPORT_OK')\n"
+    )
+    assert completed_probe.returncode == 0, completed_probe.stderr
+    assert "IMPORT_OK" in completed_probe.stdout