claude-dev-env 1.88.1 → 1.90.0

package/hooks/blocking/test_volatile_path_in_post_blocker.py

@@ -0,0 +1,210 @@
+"""Unit and integration tests for the volatile_path_in_post_blocker PreToolUse hook."""
+
+import importlib.util
+import json
+import pathlib
+import subprocess
+import sys
+
+_HOOK_DIR = pathlib.Path(__file__).parent
+if str(_HOOK_DIR) not in sys.path:
+    sys.path.insert(0, str(_HOOK_DIR))
+
+hook_spec = importlib.util.spec_from_file_location(
+    "volatile_path_in_post_blocker",
+    _HOOK_DIR / "volatile_path_in_post_blocker.py",
+)
+assert hook_spec is not None
+assert hook_spec.loader is not None
+hook_module = importlib.util.module_from_spec(hook_spec)
+hook_spec.loader.exec_module(hook_module)
+
+scan_text_for_volatile_marker = hook_module.scan_text_for_volatile_marker
+extract_gh_post_body_texts = hook_module.extract_gh_post_body_texts
+extract_mcp_body_texts = hook_module.extract_mcp_body_texts
+_collect_body_texts = hook_module._collect_body_texts
+
+
+def _body_names_volatile_path(tool_name: str, tool_input: dict[str, object]) -> bool:
+    all_body_texts = _collect_body_texts(tool_name, tool_input)
+    return hook_module._first_volatile_marker(all_body_texts) is not None
+
+
+def test_scan_detects_job_scratch_path_backslash() -> None:
+    text = r"See C:\Users\jon\.claude-editor\jobs\95762cea\tmp\staging\contact_sheet.png"
+    assert scan_text_for_volatile_marker(text) == ".claude-editor/jobs/"
+
+
+def test_scan_detects_job_scratch_path_forward_slash() -> None:
+    text = "artifact at /home/user/.claude-editor/jobs/abc/tmp/out.png"
+    assert scan_text_for_volatile_marker(text) == ".claude-editor/jobs/"
+
+
+def test_scan_detects_worktree_path() -> None:
+    text = r"edited .claude\worktrees\feature\file.py"
+    assert scan_text_for_volatile_marker(text) == ".claude/worktrees/"
+
+
+def test_scan_detects_appdata_temp_case_insensitive() -> None:
+    text = r"C:\Users\jon\AppData\Local\Temp\bugteam\worktree"
+    assert scan_text_for_volatile_marker(text) == "appdata/local/temp"
+
+
+def test_scan_detects_unix_tmp() -> None:
+    assert scan_text_for_volatile_marker("output written to /tmp/run/out.log") == "/tmp/"
+
+
+def test_scan_detects_percent_temp_token() -> None:
+    assert scan_text_for_volatile_marker("saved to %TEMP%\\out.txt") == "%temp%"
+
+
+def test_scan_detects_env_temp_token() -> None:
+    assert scan_text_for_volatile_marker("path is $env:TEMP\\out.txt") == "$env:temp"
+
+
+def test_scan_detects_claude_job_dir_token() -> None:
+    assert scan_text_for_volatile_marker("see $CLAUDE_JOB_DIR/staging/report.md") == "$claude_job_dir"
+
+
+def test_scan_clean_body_returns_none() -> None:
+    text = "The failing table is pasted below:\n| case | result |\n| a | pass |"
+    assert scan_text_for_volatile_marker(text) is None
+
+
+def test_gh_comment_with_job_scratch_path_is_blocked() -> None:
+    command = (
+        'gh pr comment 669 --body "Contact sheet at '
+        r'C:\Users\jon\.claude-editor\jobs\95762cea\tmp\staging\contact_sheet.png"'
+    )
+    assert _body_names_volatile_path("Bash", {"command": command})
+
+
+def test_gh_comment_with_clean_body_is_allowed() -> None:
+    command = 'gh pr comment 669 --body "All checks pass. Table pasted inline above."'
+    assert not _body_names_volatile_path("Bash", {"command": command})
+
+
+def test_gh_pr_create_short_flag_blocked() -> None:
+    command = 'gh pr create --title "T" -b "logs under /tmp/run/out.log"'
+    assert _body_names_volatile_path("Bash", {"command": command})
+
+
+def test_gh_issue_create_body_equals_form_blocked() -> None:
+    command = 'gh issue create --title "T" --body="dump in %TEMP%\\dump.json"'
+    assert _body_names_volatile_path("Bash", {"command": command})
+
+
+def test_body_file_content_is_scanned_and_blocked(tmp_path: pathlib.Path) -> None:
+    body_file = tmp_path / "body.md"
+    body_file.write_text(
+        "Artifact: $CLAUDE_JOB_DIR/tmp/contact_sheet.png",
+        encoding="utf-8",
+    )
+    command = f"gh pr comment 669 --body-file {body_file}"
+    assert _body_names_volatile_path("Bash", {"command": command})
+
+
+def test_body_file_clean_content_is_allowed(tmp_path: pathlib.Path) -> None:
+    body_file = tmp_path / "body.md"
+    body_file.write_text("Everything is green. Results inline above.", encoding="utf-8")
+    command = f"gh pr comment 669 --body-file {body_file}"
+    assert not _body_names_volatile_path("Bash", {"command": command})
+
+
+def test_non_post_gh_command_is_untouched() -> None:
+    assert not _body_names_volatile_path("Bash", {"command": "gh pr list --repo owner/repo"})
+
+
+def test_gh_pr_view_with_tmp_in_flag_is_untouched() -> None:
+    command = "gh pr view 10 --json body --jq .body > /tmp/out.json"
+    assert not _body_names_volatile_path("Bash", {"command": command})
+
+
+def test_substring_mention_of_gh_post_does_not_classify() -> None:
+    command = 'echo "example: gh pr comment 42 --body \\"see /tmp/x\\"" >> notes.txt'
+    assert not _body_names_volatile_path("Bash", {"command": command})
+
+
+def test_gh_word_not_first_token_does_not_classify() -> None:
+    command = r'echo gh pr comment 42 --body "see C:\.claude-editor\jobs\x"'
+    assert not _body_names_volatile_path("Bash", {"command": command})
+
+
+def test_env_assignment_prefix_still_classifies() -> None:
+    command = 'GH_TOKEN=abc gh pr comment 669 --body "log at /tmp/run.log"'
+    assert _body_names_volatile_path("Bash", {"command": command})
+
+
+def test_unparseable_command_is_allowed() -> None:
+    assert not _body_names_volatile_path(
+        "Bash", {"command": "gh pr comment 1 --body 'unterminated"}
+    )
+
+
+def test_mcp_issue_comment_body_blocked() -> None:
+    tool_input: dict[str, object] = {"body": "artifact at $CLAUDE_JOB_DIR/tmp/out.png"}
+    assert _body_names_volatile_path("mcp__plugin_github_github__add_issue_comment", tool_input)
+
+
+def test_mcp_review_comment_param_blocked() -> None:
+    tool_input: dict[str, object] = {"comment": r"see .claude\worktrees\x\file"}
+    assert _body_names_volatile_path(
+        "mcp__plugin_github_github__add_reply_to_pull_request_comment", tool_input
+    )
+
+
+def test_mcp_clean_body_allowed() -> None:
+    tool_input: dict[str, object] = {"body": "LGTM, results pasted inline."}
+    assert not _body_names_volatile_path("mcp__plugin_github_github__add_issue_comment", tool_input)
+
+
+def test_mcp_read_tool_without_body_allowed() -> None:
+    tool_input: dict[str, object] = {"pullNumber": 10}
+    assert not _body_names_volatile_path("mcp__plugin_github_github__pull_request_read", tool_input)
+
+
+def test_extract_mcp_body_texts_skips_non_string_values() -> None:
+    tool_input: dict[str, object] = {"body": None, "comment": 42}
+    assert extract_mcp_body_texts(tool_input) == []
+
+
+def test_extract_gh_post_body_texts_returns_inline_and_file(tmp_path: pathlib.Path) -> None:
+    body_file = tmp_path / "b.md"
+    body_file.write_text("file body text", encoding="utf-8")
+    command = f'gh pr create --title "T" --body "inline body" --body-file {body_file}'
+    all_texts = extract_gh_post_body_texts(command)
+    assert "inline body" in all_texts
+    assert "file body text" in all_texts
+
+
+def test_hook_subprocess_denies_volatile_gh_comment() -> None:
+    payload = {
+        "tool_name": "Bash",
+        "tool_input": {
+            "command": 'gh pr comment 669 --body "art at $CLAUDE_JOB_DIR/tmp/x.png"',
+        },
+    }
+    completion = subprocess.run(
+        [sys.executable, str(_HOOK_DIR / "volatile_path_in_post_blocker.py")],
+        input=json.dumps(payload),
+        capture_output=True,
+        text=True,
+        check=False,
+    )
+    decision = json.loads(completion.stdout)
+    assert decision["hookSpecificOutput"]["permissionDecision"] == "deny"
+
+
+def test_hook_subprocess_allows_clean_gh_comment() -> None:
+    payload = {
+        "tool_name": "Bash",
+        "tool_input": {"command": 'gh pr comment 669 --body "all green, results inline"'},
+    }
+    completion = subprocess.run(
+        [sys.executable, str(_HOOK_DIR / "volatile_path_in_post_blocker.py")],
+        input=json.dumps(payload),
+        capture_output=True,
+        text=True,
+        check=False,
+    )
+    assert completion.stdout.strip() == ""

package/hooks/blocking/volatile_path_in_post_blocker.py

@@ -0,0 +1,351 @@
+#!/usr/bin/env python3
+"""PreToolUse hook: block durable GitHub posts that reference volatile paths.
+
+Root cause: a background job posted a PR comment citing an artifact under a job
+scratch directory. Job tmp dirs, worktrees, and system temp locations are
+ephemeral — they are cleaned soon after the run — while a posted comment, PR
+body, issue, or review lives forever. A durable post that points at ephemeral
+scratch breaks the moment that scratch is removed.
+
+Detection strategy: gather the post body text from the tool call, then scan it
+for volatile-path markers. Two tool families carry post bodies: shell ``gh``
+post subcommands (``pr create/comment/edit/review``, ``issue
+create/comment/edit``) and the GitHub MCP post tools (any
+``mcp__plugin_github_github__*`` tool that carries a ``body`` or ``comment``
+parameter). For a ``gh`` command the body comes from ``--body``/``-b`` inline
+strings and from the file named by ``--body-file``/``-F`` (its contents are read
+and scanned, since that content is what gets embedded in the post). The ``gh``
+command is tokenized with ``shlex.split`` and the ``gh`` word must be the first
+command token, so a ``gh pr comment`` that only appears as quoted data inside
+another argument never classifies.
+"""
+
+import json
+import shlex
+import sys
+from pathlib import Path
+
+_hooks_dir = str(Path(__file__).resolve().parent.parent)
+if _hooks_dir not in sys.path:
+    sys.path.insert(0, _hooks_dir)
+
+from blocking._gh_body_arg_utils import (  # noqa: E402
+    all_body_flags,
+    body_file_flag,
+    body_file_short_flag,
+    count_extra_tokens_to_skip_for_split_quoted_value,
+    get_logical_first_line,
+    is_unresolvable_shell_value,
+    match_body_file_equals_prefix,
+    match_body_flag_equals_prefix,
+    strip_surrounding_quotes,
+)
+from hooks_constants.hook_block_logger import log_hook_block  # noqa: E402
+from hooks_constants.volatile_path_in_post_blocker_constants import (  # noqa: E402
+    ALL_GH_POST_SUBCOMMANDS,
+    ALL_MCP_BODY_PARAM_NAMES,
+    ALL_VOLATILE_PATH_MARKERS,
+    BASH_TOOL_NAME,
+    BODY_FILE_ENCODING,
+    CORRECTIVE_MESSAGE,
+    GH_COMMAND_NAME,
+    MCP_GITHUB_TOOL_PREFIX,
+    MINIMUM_POST_SUBCOMMAND_TOKEN_COUNT,
+    TOKEN_JOIN_SEPARATOR,
+)
+
+
+def scan_text_for_volatile_marker(text: str) -> str | None:
+    """Return the first volatile-path marker found in text, or None.
+
+    Backslashes normalize to forward slashes and the text lowercases before the
+    scan, so a marker matches regardless of slash direction or letter case::
+
+        ok:   "See the log table pasted below."        -> None
+        flag: r"C:\\Users\\me\\.claude-editor\\jobs\\x" -> ".claude-editor/jobs/"
+
+    Env-token markers such as ``%TEMP%`` and ``$CLAUDE_JOB_DIR`` match on the
+    same lowercased text.
+
+    Args:
+        text: The post body text to scan.
+
+    Returns:
+        The matched marker string, or None when the text names no volatile path.
+    """
+    normalized_text = text.replace("\\", "/").lower()
+    for each_marker in ALL_VOLATILE_PATH_MARKERS:
+        if each_marker in normalized_text:
+            return each_marker
+    return None
+
+
+def _is_environment_assignment(token: str) -> bool:
+    """Return whether a token is a ``NAME=value`` shell environment assignment."""
+    equals_index = token.find("=")
+    if equals_index <= 0:
+        return False
+    name_part = token[:equals_index]
+    if not (name_part[0].isalpha() or name_part[0] == "_"):
+        return False
+    return all(
+        each_character.isalnum() or each_character == "_"
+        for each_character in name_part
+    )
+
+
+def _tokens_name_gh_post_command(all_command_tokens: list[str]) -> bool:
+    """Return whether the tokens start with an affected ``gh`` post subcommand.
+
+    Leading ``NAME=value`` env assignments are skipped, then the next token must
+    be the literal ``gh`` command word followed by a post noun and verb. Anchoring
+    to the first command word keeps a ``gh pr comment`` mentioned only as quoted
+    argument data from classifying.
+
+    Args:
+        all_command_tokens: The shlex-split tokens of the logical command line.
+
+    Returns:
+        True when the command invokes an affected ``gh`` post subcommand.
+    """
+    command_index = 0
+    while command_index < len(all_command_tokens) and _is_environment_assignment(
+        all_command_tokens[command_index]
+    ):
+        command_index += 1
+    if command_index >= len(all_command_tokens):
+        return False
+    if all_command_tokens[command_index] != GH_COMMAND_NAME:
+        return False
+    remaining_tokens = all_command_tokens[command_index + 1 :]
+    if len(remaining_tokens) < MINIMUM_POST_SUBCOMMAND_TOKEN_COUNT:
+        return False
+    post_noun = remaining_tokens[0]
+    post_verb = remaining_tokens[1]
+    return post_verb in ALL_GH_POST_SUBCOMMANDS.get(post_noun, frozenset())
+
+
+def _reassemble_split_quoted_value(
+    value_token: str, all_following_tokens: list[str]
+) -> tuple[str, int]:
+    """Rejoin a quoted value that ``shlex.split(posix=False)`` split on spaces.
+
+    ``posix=False`` keeps backslashes intact (so Windows paths survive) but
+    splits a quoted value such as ``"dump in %TEMP%"`` into three tokens. This
+    rejoins the value token with the follow-on tokens up to the closing quote,
+    then strips the surrounding quotes so the full body text can be scanned.
+
+    Args:
+        value_token: The first token of the value, following the flag.
+        all_following_tokens: The tokens after ``value_token`` on the line.
+
+    Returns:
+        A ``(full_value, extra_tokens_consumed)`` pair; ``extra_tokens_consumed``
+        counts the follow-on tokens joined into the value.
+    """
+    extra_tokens = count_extra_tokens_to_skip_for_split_quoted_value(
+        all_following_tokens, value_token
+    )
+    if not extra_tokens:
+        return strip_surrounding_quotes(value_token), 0
+    joined_value = value_token + TOKEN_JOIN_SEPARATOR + TOKEN_JOIN_SEPARATOR.join(
+        all_following_tokens[:extra_tokens]
+    )
+    return strip_surrounding_quotes(joined_value), extra_tokens
+
+
+def _extract_flag_value_at(
+    all_command_tokens: list[str], token_index: int
+) -> tuple[bool, str, int] | None:
+    """Return a body/body-file value starting at token_index, or None.
+
+    Args:
+        all_command_tokens: The shlex-split tokens of the logical command line.
+        token_index: The index of the token to inspect.
+
+    Returns:
+        An ``(is_body_file, value, next_index)`` triple when the token opens a
+        body or body-file flag, else None. ``next_index`` is where scanning
+        resumes after the value's tokens.
+    """
+    current_token = all_command_tokens[token_index]
+    following_tokens = all_command_tokens[token_index + 1:]
+    body_equals_prefix = match_body_flag_equals_prefix(current_token)
+    if body_equals_prefix is not None:
+        value, extra = _reassemble_split_quoted_value(
+            current_token[len(body_equals_prefix):], following_tokens
+        )
+        return False, value, token_index + 1 + extra
+    body_file_equals_prefix = match_body_file_equals_prefix(current_token)
+    if body_file_equals_prefix is not None:
+        value, extra = _reassemble_split_quoted_value(
+            current_token[len(body_file_equals_prefix):], following_tokens
+        )
+        return True, value, token_index + 1 + extra
+    if current_token in all_body_flags and following_tokens:
+        value, extra = _reassemble_split_quoted_value(following_tokens[0], following_tokens[1:])
+        return False, value, token_index + 2 + extra
+    if current_token in (body_file_flag, body_file_short_flag) and following_tokens:
+        value, extra = _reassemble_split_quoted_value(following_tokens[0], following_tokens[1:])
+        return True, value, token_index + 2 + extra
+    return None
+
+
+def _collect_body_flag_values(
+    all_command_tokens: list[str],
+) -> tuple[list[str], list[str]]:
+    """Return inline body strings and body-file paths from the command tokens.
+
+    Args:
+        all_command_tokens: The shlex-split tokens of the logical command line.
+
+    Returns:
+        A ``(all_inline_bodies, all_body_file_paths)`` pair, each value stripped
+        of its surrounding quotes and rejoined across split-quote tokens.
+    """
+    all_inline_bodies: list[str] = []
+    all_body_file_paths: list[str] = []
+    token_index = 0
+    while token_index < len(all_command_tokens):
+        extraction = _extract_flag_value_at(all_command_tokens, token_index)
+        if extraction is None:
+            token_index += 1
+            continue
+        is_body_file, value, next_index = extraction
+        if is_body_file:
+            all_body_file_paths.append(value)
+        else:
+            all_inline_bodies.append(value)
+        token_index = next_index
+    return all_inline_bodies, all_body_file_paths
+
+
+def _read_body_file(body_file_path: str) -> str | None:
+    """Return the contents of a body-file path, or None when it cannot be read.
+
+    Args:
+        body_file_path: The path given to ``--body-file``/``-F``.
+
+    Returns:
+        The file text, or None for an unresolvable shell value (such as ``-`` for
+        stdin or a ``$VAR`` path) or an unreadable file.
+    """
+    if is_unresolvable_shell_value(body_file_path):
+        return None
+    try:
+        return Path(body_file_path).read_text(encoding=BODY_FILE_ENCODING)
+    except OSError:
+        return None
+
+
+def extract_gh_post_body_texts(command: str) -> list[str]:
+    """Return every post body text an affected ``gh`` command would send.
+
+    Non-post ``gh`` commands and unparseable command lines yield an empty list.
+    Body-file contents are read from disk so the embedded text is scanned rather
+    than the file path.
+
+    Args:
+        command: The raw Bash tool command string.
+
+    Returns:
+        Inline ``--body`` strings plus the contents of each readable body-file.
+    """
+    logical_line = get_logical_first_line(command)
+    if not logical_line:
+        return []
+    try:
+        all_command_tokens = shlex.split(logical_line, posix=False)
+    except ValueError:
+        return []
+    if not _tokens_name_gh_post_command(all_command_tokens):
+        return []
+    all_inline_bodies, all_body_file_paths = _collect_body_flag_values(
+        all_command_tokens
+    )
+    all_body_texts = list(all_inline_bodies)
+    for each_path in all_body_file_paths:
+        file_text = _read_body_file(each_path)
+        if file_text is not None:
+            all_body_texts.append(file_text)
+    return all_body_texts
+
+
+def extract_mcp_body_texts(all_tool_input: dict[str, object]) -> list[str]:
+    """Return the body and comment strings from a GitHub MCP post tool input.
+
+    Args:
+        all_tool_input: The MCP tool's input mapping.
+
+    Returns:
+        The non-empty string values of the ``body`` and ``comment`` parameters.
+    """
+    all_body_texts: list[str] = []
+    for each_param_name in ALL_MCP_BODY_PARAM_NAMES:
+        param_value = all_tool_input.get(each_param_name)
+        if isinstance(param_value, str) and param_value:
+            all_body_texts.append(param_value)
+    return all_body_texts
+
+
+def _collect_body_texts(tool_name: str, all_tool_input: dict[str, object]) -> list[str]:
+    if tool_name == BASH_TOOL_NAME:
+        command = all_tool_input.get("command", "")
+        if not isinstance(command, str) or not command:
+            return []
+        return extract_gh_post_body_texts(command)
+    if tool_name.startswith(MCP_GITHUB_TOOL_PREFIX):
+        return extract_mcp_body_texts(all_tool_input)
+    return []
+
+
+def _first_volatile_marker(all_body_texts: list[str]) -> str | None:
+    for each_text in all_body_texts:
+        matched_marker = scan_text_for_volatile_marker(each_text)
+        if matched_marker is not None:
+            return matched_marker
+    return None
+
+
+def _emit_block(tool_name: str, matched_marker: str) -> None:
+    deny_payload = {
+        "hookSpecificOutput": {
+            "hookEventName": "PreToolUse",
+            "permissionDecision": "deny",
+            "permissionDecisionReason": CORRECTIVE_MESSAGE,
+        }
+    }
+    log_hook_block(
+        calling_hook_name="volatile_path_in_post_blocker.py",
+        hook_event="PreToolUse",
+        block_reason=CORRECTIVE_MESSAGE,
+        tool_name=tool_name,
+        offending_input_preview=matched_marker,
+    )
+    print(json.dumps(deny_payload))
+    sys.stdout.flush()
+
+
+def main() -> None:
+    """Read the PreToolUse payload and block a post that names a volatile path."""
+    try:
+        hook_input = json.load(sys.stdin)
+    except json.JSONDecodeError:
+        sys.exit(0)
+
+    tool_name = hook_input.get("tool_name", "")
+    tool_input = hook_input.get("tool_input", {})
+    if not isinstance(tool_name, str) or not isinstance(tool_input, dict):
+        sys.exit(0)
+
+    all_body_texts = _collect_body_texts(tool_name, tool_input)
+    matched_marker = _first_volatile_marker(all_body_texts)
+    if matched_marker is None:
+        sys.exit(0)
+
+    _emit_block(tool_name, matched_marker)
+    sys.exit(0)
+
+
+if __name__ == "__main__":
+    main()

package/hooks/hooks.json

@@ -55,6 +55,11 @@
             "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/blocking/gh_body_arg_blocker.py",
             "timeout": 10
           },
+          {
+            "type": "command",
+            "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/blocking/volatile_path_in_post_blocker.py",
+            "timeout": 10
+          },
           {
             "type": "command",
             "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/blocking/conventional_pr_title_gate.py",
@@ -142,6 +147,16 @@
           }
         ]
       },
+      {
+        "matcher": "mcp__plugin_github_github__.*",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/blocking/volatile_path_in_post_blocker.py",
+            "timeout": 10
+          }
+        ]
+      },
       {
         "matcher": "Agent",
         "hooks": [
@@ -186,6 +201,16 @@
             "timeout": 10
           }
         ]
+      },
+      {
+        "matcher": "EnterWorktree",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/lifecycle/enter_worktree_origin_prefetch.py",
+            "timeout": 25
+          }
+        ]
       }
     ],
     "SessionStart": [

package/hooks/hooks_constants/CLAUDE.md

@@ -13,6 +13,7 @@ Shared constant modules imported by hooks throughout the `hooks/` tree. Each fil
 | `bot_mention_comment_blocker_constants.py` | Patterns for detecting bot @-mentions in PR comments |
 | `claude_md_orphan_file_blocker_constants.py` | Table patterns, file extensions, scan budget, and block-message text for the CLAUDE.md orphan-file blocker |
 | `code_rules_enforcer_constants.py` | File-extension sets, test-path patterns, advisory line thresholds, boolean-name prefixes |
+| `enter_worktree_prefetch_constants.py` | Tool name, origin-remote ref names, and git-command timeouts for the EnterWorktree origin-prefetch hook |
 | `env_var_table_code_drift_constants.py` | Table patterns, env-var-name and code-file recognizers, scan budget, and block-message text for the env-var-table code-drift blocker |
 | `code_rules_path_utils_constants.py` | Path-matching helpers used by the code-rules check modules |
 | `code_verifier_spawn_preflight_gate_constants.py` | Subagent type, merge-tree command flags, timeouts, and deny-message text for the code-verifier spawn pre-flight gate |
@@ -65,6 +66,7 @@ Shared constant modules imported by hooks throughout the `hooks/` tree. Each fil
 | `task_list_loop_starter_constants.py` | The one-line task-list instruction and the full session-start directive text for the task-list loop starter hook |
 | `text_stripping.py` | `strip_code_and_quotes()` — shared helper that removes fenced code blocks, inline code, and blockquotes from prose, imported by the Stop-hook prose blockers |
 | `unused_module_import_constants.py` | Patterns for detecting unused module-level imports |
+| `volatile_path_in_post_blocker_constants.py` | Volatile path markers, affected `gh` post subcommands, MCP body param names, and the corrective message for the volatile-path post blocker |
 | `windows_rmtree_blocker_constants.py` | The unsafe `shutil.rmtree` pattern and the safe replacement pattern |
 | `workflow_substitution_slot_blocker_constants.py` | Per-iteration token patterns for the workflow-slot blocker |
 

package/hooks/hooks_constants/enter_worktree_prefetch_constants.py

@@ -0,0 +1,18 @@
+"""Configuration constants for the ``enter_worktree_origin_prefetch`` hook.
+
+The hook keeps a freshly created worktree from starting on a stale cached
+``refs/remotes/origin/<default-branch>`` value: it fetches that ref right
+before ``EnterWorktree`` resolves its base.
+"""
+
+from __future__ import annotations
+
+ENTER_WORKTREE_TOOL_NAME: str = "EnterWorktree"
+ENTER_WORKTREE_PATH_INPUT_KEY: str = "path"
+
+ORIGIN_REMOTE_NAME: str = "origin"
+ORIGIN_HEAD_SYMBOLIC_REF: str = "refs/remotes/origin/HEAD"
+ORIGIN_REMOTE_REF_PREFIX: str = "refs/remotes/origin/"
+
+GIT_SYMBOLIC_REF_TIMEOUT_SECONDS: int = 5
+GIT_FETCH_TIMEOUT_SECONDS: int = 15

package/hooks/hooks_constants/volatile_path_in_post_blocker_constants.py

@@ -0,0 +1,48 @@
+"""Configuration constants for the volatile_path_in_post_blocker PreToolUse hook."""
+
+BASH_TOOL_NAME: str = "Bash"
+
+MCP_GITHUB_TOOL_PREFIX: str = "mcp__plugin_github_github__"
+
+ALL_MCP_BODY_PARAM_NAMES: tuple[str, ...] = ("body", "comment")
+
+GH_COMMAND_NAME: str = "gh"
+
+MINIMUM_POST_SUBCOMMAND_TOKEN_COUNT: int = 2
+
+TOKEN_JOIN_SEPARATOR: str = " "
+
+BODY_FILE_ENCODING: str = "utf-8"
+
+ALL_GH_POST_SUBCOMMANDS: dict[str, frozenset[str]] = {
+    "pr": frozenset({"create", "comment", "edit", "review"}),
+    "issue": frozenset({"create", "comment", "edit"}),
+}
+
+ALL_VOLATILE_PATH_MARKERS: tuple[str, ...] = (
+    ".claude-editor/jobs/",
+    ".claude/worktrees/",
+    "appdata/local/temp",
+    "/tmp/",
+    "%temp%",
+    "$env:temp",
+    "$claude_job_dir",
+)
+
+GH_ARTIFACT_UPLOAD_INVOCATION: str = (
+    "python3 ~/.claude/scripts/gh_artifact_upload.py <file-path> <owner/repo>"
+)
+
+CORRECTIVE_MESSAGE: str = (
+    "BLOCKED [durable-post-artifacts]: this post body references a volatile path "
+    "(a job scratch dir, worktree, or system temp location). The post is durable "
+    "and outlives that scratch, so the reference breaks the moment the directory "
+    "is cleaned.\n\n"
+    "Fix it before posting:\n"
+    "  1. Text data (logs, tables, diffs): paste the actual content inline in the "
+    "post instead of linking a scratch file path.\n"
+    "  2. Binary artifacts (images, archives): upload the file to the repo's "
+    "durable 'artifacts' release and link the permanent asset URL it prints:\n"
+    f"       {GH_ARTIFACT_UPLOAD_INVOCATION}\n\n"
+    "See ~/.claude/rules/durable-post-artifacts.md for the full contract."
+)