claude-dev-env 1.82.0 → 1.84.0

package/hooks/blocking/test_stale_comment_reference_blocker.py

@@ -0,0 +1,236 @@
+"""Tests for the stale_comment_reference_blocker hook."""
+
+import json
+import subprocess
+import sys
+from pathlib import Path
+from unittest.mock import patch
+
+_BLOCKING_DIR = str(Path(__file__).resolve().parent)
+_HOOKS_ROOT = str(Path(__file__).resolve().parent.parent)
+if _BLOCKING_DIR not in sys.path:
+    sys.path.insert(0, _BLOCKING_DIR)
+if _HOOKS_ROOT not in sys.path:
+    sys.path.insert(0, _HOOKS_ROOT)
+
+from stale_comment_reference_blocker import (  # noqa: E402
+    build_deny_payload,
+    evaluate,
+)
+
+from hooks_constants.hook_block_logger import _HOOK_BLOCKS_LOG_RELATIVE_PATH  # noqa: E402
+
+HOOK_SCRIPT_PATH = str(Path(__file__).resolve().parent / "stale_comment_reference_blocker.py")
+
+PATCHED_SLEEP_LINE = (
+    "    with patch('theme_exports.core.exporter.asyncio.sleep', new_callable=AsyncMock):\n"
+)
+PATCHED_POLL_LINE = "    with patch('theme_exports.core.exporter.wait_for_overlay_clear', new_callable=AsyncMock):\n"
+KEPT_COMMENT_LINE = "    # Mock asyncio\n"
+
+
+def _run_hook(tool_name: str, tool_input: dict) -> subprocess.CompletedProcess:
+    payload = json.dumps({"tool_name": tool_name, "tool_input": tool_input})
+    return subprocess.run(
+        [sys.executable, HOOK_SCRIPT_PATH],
+        input=payload,
+        capture_output=True,
+        text=True,
+        check=False,
+    )
+
+
+def _write_module(tmp_path: Path, source_text: str) -> Path:
+    written_module_path = tmp_path / "sample_module.py"
+    written_module_path.write_text(source_text, encoding="utf-8")
+    return written_module_path
+
+
+def test_blocks_edit_that_orphans_the_comment_above(tmp_path: Path) -> None:
+    """Rewriting the patched target under an unchanged comment naming it
+    is denied.
+    """
+    written_module_path = _write_module(
+        tmp_path,
+        "def launch_export() -> None:\n" + KEPT_COMMENT_LINE + PATCHED_SLEEP_LINE,
+    )
+    outcome = _run_hook(
+        "Edit",
+        {
+            "file_path": str(written_module_path),
+            "old_string": PATCHED_SLEEP_LINE.rstrip("\n"),
+            "new_string": PATCHED_POLL_LINE.rstrip("\n"),
+        },
+    )
+    assert outcome.returncode == 0
+    decision = json.loads(outcome.stdout)
+    assert decision["hookSpecificOutput"]["permissionDecision"] == "deny"
+    assert "asyncio" in decision["hookSpecificOutput"]["permissionDecisionReason"]
+
+
+def test_blocks_edit_that_deletes_the_line_the_comment_names(tmp_path: Path) -> None:
+    """Deleting the patched line under an unchanged comment naming it is
+    denied the same as rewriting it would be.
+    """
+    written_module_path = _write_module(
+        tmp_path,
+        "def launch_export() -> None:\n" + KEPT_COMMENT_LINE + PATCHED_SLEEP_LINE,
+    )
+    outcome = _run_hook(
+        "Edit",
+        {
+            "file_path": str(written_module_path),
+            "old_string": PATCHED_SLEEP_LINE,
+            "new_string": "",
+        },
+    )
+    assert outcome.returncode == 0
+    decision = json.loads(outcome.stdout)
+    assert decision["hookSpecificOutput"]["permissionDecision"] == "deny"
+    assert "asyncio" in decision["hookSpecificOutput"]["permissionDecisionReason"]
+
+
+def test_allows_edit_that_updates_the_comment_together(tmp_path: Path) -> None:
+    """An edit rewriting the comment and the line together passes."""
+    written_module_path = _write_module(
+        tmp_path,
+        "def launch_export() -> None:\n" + KEPT_COMMENT_LINE + PATCHED_SLEEP_LINE,
+    )
+    outcome = _run_hook(
+        "Edit",
+        {
+            "file_path": str(written_module_path),
+            "old_string": KEPT_COMMENT_LINE + PATCHED_SLEEP_LINE,
+            "new_string": "    # Mock the overlay poll\n" + PATCHED_POLL_LINE,
+        },
+    )
+    assert outcome.returncode == 0
+    assert outcome.stdout == ""
+
+
+def test_allows_edit_that_keeps_the_named_identifier(tmp_path: Path) -> None:
+    """A rewrite that still carries the identifier the comment names passes."""
+    written_module_path = _write_module(
+        tmp_path,
+        "def launch_export() -> None:\n" + KEPT_COMMENT_LINE + PATCHED_SLEEP_LINE,
+    )
+    retained_line = "    with patch('theme_exports.core.exporter.asyncio.sleep'):\n"
+    outcome = _run_hook(
+        "Edit",
+        {
+            "file_path": str(written_module_path),
+            "old_string": PATCHED_SLEEP_LINE.rstrip("\n"),
+            "new_string": retained_line.rstrip("\n"),
+        },
+    )
+    assert outcome.returncode == 0
+    assert outcome.stdout == ""
+
+
+def test_allows_prose_comment_with_no_orphaned_identifier(tmp_path: Path) -> None:
+    """A prose comment whose tokens never name anything in the edited line
+    passes.
+    """
+    written_module_path = _write_module(
+        tmp_path,
+        "def launch_export() -> None:\n"
+        "    # Overlay settle pause\n"
+        "    runner.pause_for_overlay_settle()\n",
+    )
+    outcome = _run_hook(
+        "Edit",
+        {
+            "file_path": str(written_module_path),
+            "old_string": "    runner.pause_for_overlay_settle()",
+            "new_string": "    runner.confirm_editor_ready()",
+        },
+    )
+    assert outcome.returncode == 0
+    assert outcome.stdout == ""
+
+
+def test_allows_non_python_file(tmp_path: Path) -> None:
+    """A non-Python target passes untouched."""
+    plain_text_target = tmp_path / "notes.txt"
+    plain_text_target.write_text("# Mock asyncio\nasyncio row\n", encoding="utf-8")
+    outcome = _run_hook(
+        "Edit",
+        {
+            "file_path": str(plain_text_target),
+            "old_string": "asyncio row",
+            "new_string": "other row",
+        },
+    )
+    assert outcome.returncode == 0
+    assert outcome.stdout == ""
+
+
+def test_allows_write_tool() -> None:
+    """A non-Edit invocation passes untouched."""
+    outcome = _run_hook(
+        "Write",
+        {
+            "file_path": "src/sample_module.py",
+            "content": KEPT_COMMENT_LINE + PATCHED_POLL_LINE,
+        },
+    )
+    assert outcome.returncode == 0
+    assert outcome.stdout == ""
+
+
+def test_allows_missing_file(tmp_path: Path) -> None:
+    """An Edit aimed at a path with no readable target passes."""
+    outcome = _run_hook(
+        "Edit",
+        {
+            "file_path": str(tmp_path / "absent_module.py"),
+            "old_string": "one",
+            "new_string": "two",
+        },
+    )
+    assert outcome.returncode == 0
+    assert outcome.stdout == ""
+
+
+def test_allows_old_string_not_found(tmp_path: Path) -> None:
+    """An Edit whose old_string never occurs in the target passes."""
+    written_module_path = _write_module(tmp_path, "value_count = 1\n")
+    outcome = _run_hook(
+        "Edit",
+        {
+            "file_path": str(written_module_path),
+            "old_string": "never present",
+            "new_string": "still never present",
+        },
+    )
+    assert outcome.returncode == 0
+    assert outcome.stdout == ""
+
+
+def test_deny_payload_logs_the_block(tmp_path: Path) -> None:
+    """One record lands in the block journal for each denial built through
+    evaluate plus build_deny_payload.
+    """
+    written_module_path = _write_module(
+        tmp_path,
+        "def launch_export() -> None:\n" + KEPT_COMMENT_LINE + PATCHED_SLEEP_LINE,
+    )
+    deny_reason = evaluate(
+        {
+            "tool_name": "Edit",
+            "tool_input": {
+                "file_path": str(written_module_path),
+                "old_string": PATCHED_SLEEP_LINE.rstrip("\n"),
+                "new_string": PATCHED_POLL_LINE.rstrip("\n"),
+            },
+        }
+    )
+    assert deny_reason is not None
+    with patch.object(Path, "home", return_value=tmp_path):
+        deny_payload = build_deny_payload(deny_reason)
+    assert deny_payload["hookSpecificOutput"]["permissionDecision"] == "deny"
+    block_log_path = tmp_path / _HOOK_BLOCKS_LOG_RELATIVE_PATH
+    all_log_records = block_log_path.read_text(encoding="utf-8").strip().splitlines()
+    assert len(all_log_records) == 1
+    parsed_log_line = json.loads(all_log_records[0])
+    assert parsed_log_line["hook"] == "stale_comment_reference_blocker.py"

package/hooks/blocking/test_state_description_blocker.py

@@ -633,6 +633,141 @@ def test_handles_non_string_tool_name():
     assert result.stdout == ""
 
 
+def test_detects_used_to_in_python_module_docstring() -> None:
+    """A module docstring carrying a transitional phrase counts as
+    documentation and is denied.
+    """
+    written_source = (
+        '"""Both paths used to pad with a flat sleep on every export."""\n'
+        "\n"
+        "RETRY_BUDGET = 5\n"
+    )
+    result = _run_hook(
+        "Write",
+        {
+            "file_path": "tests/test_exports.py",
+            "content": written_source,
+        },
+    )
+    assert result.returncode == 0
+    output = json.loads(result.stdout)
+    assert output["hookSpecificOutput"]["permissionDecision"] == "deny"
+    assert "used to" in output["hookSpecificOutput"]["permissionDecisionReason"]
+
+
+def test_detects_previously_in_python_function_docstring() -> None:
+    """A function docstring carrying a transitional phrase is denied.
+    """
+    written_source = (
+        "def load_configuration() -> None:\n"
+        '    """Previously configured via an environment variable."""\n'
+        "    raise ValueError\n"
+    )
+    result = _run_hook(
+        "Write",
+        {
+            "file_path": "src/configuration.py",
+            "content": written_source,
+        },
+    )
+    assert result.returncode == 0
+    output = json.loads(result.stdout)
+    assert output["hookSpecificOutput"]["permissionDecision"] == "deny"
+    assert "previously" in output["hookSpecificOutput"]["permissionDecisionReason"]
+
+
+def test_ignores_transitional_phrase_in_regular_python_string() -> None:
+    """A plain string literal counts as data rather than documentation and
+    passes.
+    """
+    result = _run_hook(
+        "Write",
+        {
+            "file_path": "src/messages.py",
+            "content": 'PADDING_NOTE = "used to pad with a flat sleep"\n',
+        },
+    )
+    assert result.returncode == 0
+    assert result.stdout == ""
+
+
+def test_ignores_quoted_mention_inside_python_docstring() -> None:
+    """A docstring quoting a phrase as a mention in double quotes passes.
+    """
+    written_source = (
+        '"""Blocks docstrings carrying phrases like "used to" in their prose."""\n'
+        "\n"
+        "RETRY_BUDGET = 3\n"
+    )
+    result = _run_hook(
+        "Write",
+        {
+            "file_path": "src/scanner.py",
+            "content": written_source,
+        },
+    )
+    assert result.returncode == 0
+    assert result.stdout == ""
+
+
+def test_detects_docstring_at_start_of_unparseable_edit_fragment() -> None:
+    """An Edit fragment opening with a docstring is scanned even when
+    parsing fails.
+    """
+    fragment = '"""The runner used to sleep between exports."""\n    continue\n'
+    result = _run_hook(
+        "Edit",
+        {
+            "file_path": "src/exports.py",
+            "old_string": "placeholder",
+            "new_string": fragment,
+        },
+    )
+    assert result.returncode == 0
+    output = json.loads(result.stdout)
+    assert output["hookSpecificOutput"]["permissionDecision"] == "deny"
+    assert "used to" in output["hookSpecificOutput"]["permissionDecisionReason"]
+
+
+def test_detects_docstring_after_def_header_in_unparseable_fragment() -> None:
+    """A triple-quoted block directly under a def header counts as a
+    docstring in a fragment.
+    """
+    fragment = (
+        "    def render_summary(self) -> None:\n"
+        '        """No longer writes the summary sheet."""\n'
+    )
+    result = _run_hook(
+        "Edit",
+        {
+            "file_path": "src/reporting.py",
+            "old_string": "placeholder",
+            "new_string": fragment,
+        },
+    )
+    assert result.returncode == 0
+    output = json.loads(result.stdout)
+    assert output["hookSpecificOutput"]["permissionDecision"] == "deny"
+    assert "no longer" in output["hookSpecificOutput"]["permissionDecisionReason"]
+
+
+def test_ignores_assigned_triple_quoted_string_in_unparseable_fragment() -> None:
+    """A triple-quoted block assigned to a name counts as data rather than
+    a docstring in a fragment.
+    """
+    fragment = 'FIXTURE_TEXT = """used to pad with a flat sleep"""\n    continue\n'
+    result = _run_hook(
+        "Edit",
+        {
+            "file_path": "src/fixtures.py",
+            "old_string": "placeholder",
+            "new_string": fragment,
+        },
+    )
+    assert result.returncode == 0
+    assert result.stdout == ""
+
+
 def test_native_dispatch_path_logs_the_block(tmp_path: Path) -> None:
     """A deny routed through the dispatcher's native path logs one record.
 

package/hooks/hooks.json

@@ -60,6 +60,11 @@
             "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/blocking/conventional_pr_title_gate.py",
             "timeout": 10
           },
+          {
+            "type": "command",
+            "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/blocking/reviewer_spawn_gate.py",
+            "timeout": 20
+          },
           {
             "type": "command",
             "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/blocking/block_main_commit.py",

package/hooks/hooks_constants/CLAUDE.md

@@ -24,7 +24,6 @@ Shared constant modules imported by hooks throughout the `hooks/` tree. Each fil
 | `dead_dataclass_field_constants.py` | Patterns for detecting unused dataclass fields |
 | `dead_module_constant_constants.py` | Patterns for detecting unexported `UPPER_SNAKE` constants in `*_constants.py` modules |
 | `destructive_command_segment_constants.py` | The list of destructive shell command patterns the blocker matches |
-| `doc_gist_auto_publish_constants.py` | Sentinel marker and URL patterns for the doc-gist auto-publish hook |
 | `docstring_rule_gate_count_blocker_constants.py` | Target rule basename, spelled-out-number lookup, count-clause and `check_*` validator patterns, and block-message text for the docstring-rule gate-count staleness blocker |
 | `duplicate_function_body_constants.py` | Hashing and comparison config for the duplicate-body check |
 | `duplicate_rmtree_helper_blocker_constants.py` | Sanctioned Windows-safe rmtree helper names, the definition pattern, and the exempt-path set for the duplicate-rmtree-helper blocker |
@@ -34,10 +33,8 @@ Shared constant modules imported by hooks throughout the `hooks/` tree. Each fil
 | `hook_block_logger.py` | `log_hook_block()` — shared fail-safe logger every blocking hook calls to append a JSON record of each block decision to `~/.claude/logs/hook-blocks.log` |
 | `hook_log_extractor_constants.py` | Neon table name, offset state file path, timeouts, and outcome-type mapping for the hook-log extractor |
 | `hook_prose_detector_consistency_constants.py` | Trigger patterns and corrective messages for the hook-prose consistency checker |
-| `html_companion_constants.py` | Blocked URL schemes and other config for the `.md`-to-`.html` companion hook |
 | `inline_tuple_string_magic_constants.py` | Patterns for detecting magic strings in inline tuple literals |
 | `js_conventions_constants.py` | Banned identifier set, boolean-prefix pattern, and declaration/JSDoc patterns for the JavaScript convention checks |
-| `md_to_html_blocker_constants.py` | Path exemptions and trigger patterns for the markdown-to-html blocker |
 | `messages.py` | Short user-facing notice strings shown when a Stop hook redirects agent behavior |
 | `multi_edit_reconstruction.py` | `apply_edits()` / `edits_for_tool()` — shared helpers that reconstruct the post-edit content of an Edit or MultiEdit, imported by the blockers that judge post-edit content |
 | `open_questions_in_plans_blocker_constants.py` | Patterns for detecting unresolved open questions in plan documents |
@@ -53,11 +50,13 @@ Shared constant modules imported by hooks throughout the `hooks/` tree. Each fil
 | `precommit_code_rules_gate_constants.py` | Scope argument and exit-code constants for the precommit gate |
 | `project_paths_reader.py` | Loads `~/.claude/project-paths.json` — the per-user project-path registry |
 | `pytest_testpaths_orphan_blocker_constants.py` | Marker filename, section and key names, test-file pattern, search budget, and block-message text for the pytest unregistered-test-directory blocker |
+| `reviewer_spawn_gate_constants.py` | Bash tool name, the sentinel marker, the Copilot and Bugbot trigger markers, the availability-script relative path and override env-var name, and the deny-message template for the reviewer-spawn gate |
 | `send_user_file_open_locally_blocker_constants.py` | Tool name, proactive status, and the block message for the open-locally attach blocker |
 | `session_env_cleanup_constants.py` | Stale-age threshold and directory names for the session-env cleanup hook |
 | `session_handoff_blocker_constants.py` | Trigger phrases for the session-handoff blocker |
 | `setup_project_paths_constants.py` | Encoding policy, BOM marker, and registry meta-key used across multiple hooks |
-| `state_description_blocker_constants.py` | The set of historical/comparative phrases the state-description blocker rejects |
+| `stale_comment_reference_blocker_constants.py` | Identifier pattern, comment stopwords, and denial text for the stale-comment-reference blocker |
+| `state_description_blocker_constants.py` | The set of historical/comparative phrases the state-description blocker rejects, plus the docstring-extraction and mention-span patterns for its Python docstring scan |
 | `stuttering_check_config.py` | Config for the stuttering (repeated-phrase) check |
 | `stuttering_import_binding_constants.py` | Import-binding patterns for the stuttering check |
 | `subprocess_budget_completeness_constants.py` | Required argument names for the subprocess-budget completeness check |

package/hooks/hooks_constants/blocking_check_limits.py

@@ -28,7 +28,20 @@ MAX_THIN_WRAPPER_ISSUES: int = 1
 MAX_ZERO_PAYLOAD_ALIAS_ISSUES: int = 3
 MAX_LOGGING_FSTRING_ISSUES: int = 3
 MAX_LOGGING_PRINTF_TOKEN_ISSUES: int = 3
+MAX_LOGGING_ADJACENT_LITERAL_ISSUES: int = 3
+MAX_CONFIG_DUPLICATE_PATH_ANCHOR_ISSUES: int = 3
 MAX_WINDOWS_API_NONE_ISSUES: int = 3
+MAX_NAIVE_DATETIME_ISSUES: int = 3
+DATETIME_CLASS_ATTRIBUTE_NAME: str = "datetime"
+NAIVE_DATETIME_TIMEZONE_KEYWORD: str = "tz"
+NAIVE_DATETIME_UTCNOW_CONSTRUCTOR: str = "utcnow"
+NAIVE_DATETIME_UTCFROMTIMESTAMP_CONSTRUCTOR: str = "utcfromtimestamp"
+NAIVE_DATETIME_FROMTIMESTAMP_CONSTRUCTOR: str = "fromtimestamp"
+FROMTIMESTAMP_POSITIONAL_TIMEZONE_ARGUMENT_COUNT: int = 2
+ALL_ALWAYS_NAIVE_DATETIME_CONSTRUCTORS: tuple[str, ...] = (
+    NAIVE_DATETIME_UTCNOW_CONSTRUCTOR,
+    NAIVE_DATETIME_UTCFROMTIMESTAMP_CONSTRUCTOR,
+)
 MAX_E2E_TEST_NAMING_ISSUES: int = 3
 MAX_IMPORT_BLOCK_SORT_ISSUES: int = 1
 IMPORT_BLOCK_SORT_RUFF_TIMEOUT_SECONDS: int = 15
@@ -48,6 +61,11 @@ ALL_IMPORT_BLOCK_SORT_RUFF_COMMAND_PREFIX: tuple[str, ...] = (
 )
 MAX_JS_RESUME_TASK_ENUMERATION_ISSUES: int = 5
 MAX_JS_RETURNS_OBJECT_SCHEMALESS_ISSUES: int = 5
+MAX_JS_SIBLING_RETURN_OBJECT_KEY_DRIFT_ISSUES: int = 5
+MINIMUM_SIBLING_RETURN_OBJECT_KEYS: int = 2
+SIBLING_RETURN_OBJECT_EXACT_MISSING_KEY_COUNT: int = 1
+SIBLING_RETURN_OBJECT_SINGLE_AGREED_MISSING_KEY_COUNT: int = 1
+MAX_JS_BARE_FLAG_RETURN_DIRECTIVE_ISSUES: int = 5
 MINIMUM_RESUME_TASK_ENUMERATION_ITEMS: int = 2
 DOCSTRING_TRIVIAL_FUNCTION_BODY_LINE_LIMIT: int = 3
 MAX_DOCSTRING_FALLBACK_BRANCH_ISSUES: int = 3
@@ -59,6 +77,7 @@ MAX_STALE_TEST_NAME_TARGET_ISSUES: int = 3
 STALE_TEST_NAME_MINIMUM_SHARED_TOKEN_COUNT: int = 2
 MAX_MODULE_DOCSTRING_CHECK_ROSTER_ISSUES: int = 5
 MINIMUM_PUBLIC_CHECKS_FOR_MODULE_DOCSTRING_ROSTER: int = 2
+MINIMUM_SIBLING_OCCURRENCES_FOR_SHARED_TOKEN: int = 2
 MAX_DOCSTRING_TUPLE_ENUMERATION_ISSUES: int = 5
 MINIMUM_TUPLE_MEMBERS_FOR_DOCSTRING_ENUMERATION: int = 2
 MAX_DOCSTRING_MARK_GLYPH_ENUMERATION_ISSUES: int = 5
@@ -199,6 +218,9 @@ DOCSTRING_RUNON_SENTENCE_WORD_LIMIT: int = 30
 MAX_DOCSTRING_RUNON_SENTENCE_ISSUES: int = 5
 ALL_DOCSTRING_RUNON_JOINER_MARKERS: tuple[str, ...] = ("—", " -- ", ";")
 DOCSTRING_RUNON_SENTENCE_BOUNDARY_PATTERN: re.Pattern[str] = re.compile(r"(?<=[.!?])\s+")
+DOCSTRING_NARRATIVE_PROSE_LINE_LIMIT: int = 6
+DOCSTRING_NARRATIVE_LINE_JOIN_SEPARATOR: str = " "
+MAX_DOCSTRING_PROSE_WALL_ISSUES: int = 5
 
 ALL_DOCSTRING_NO_CONSUMER_CLAIM_PHRASES: tuple[str, ...] = (
     "no consumer reads",
@@ -290,6 +312,30 @@ ALL_TEST_INDICATING_ENVIRONMENT_VARIABLE_NAMES: frozenset[str] = frozenset(
     }
 )
 
+MAX_DOCSTRING_DELEGATION_ENUMERATION_ISSUES: int = 5
+MINIMUM_DELEGATION_ENUMERATION_ITEMS: int = 2
+NEIGHBOR_SCAN_FILE_LIMIT: int = 40
+POINTER_TO_DELEGATE_PATTERN: re.Pattern[str] = re.compile(
+    r"full doc(?:umentation)?\s+on\s+`{1,2}([A-Za-z_][A-Za-z0-9_]*)`{1,2}",
+    re.IGNORECASE,
+)
+TOKEN_WORD_PATTERN: re.Pattern[str] = re.compile(r"[A-Za-z][A-Za-z0-9]{2,}")
+ALL_DELEGATION_ENUMERATION_STOP_TOKENS: frozenset[str] = frozenset(
+    {
+        "the",
+        "and",
+        "then",
+        "edit",
+        "edits",
+        "apply",
+        "applies",
+        "run",
+        "runs",
+        "step",
+        "steps",
+    }
+)
+
 MAX_MODULE_DOCSTRING_DATA_SCHEMA_SCOPE_ISSUES: int = 1
 MODULE_DOCSTRING_DATA_SCHEMA_CONSTANT_SAMPLE_LIMIT: int = 6
 ALL_USER_FACING_TEXT_SCOPE_DOCSTRING_PHRASES: tuple[str, ...] = (

package/hooks/hooks_constants/code_rules_enforcer_constants.py

@@ -185,7 +185,18 @@ LOGGING_FSTRING_PATTERN = re.compile(
 LOGGING_PRINTF_TOKEN_PATTERN: re.Pattern[str] = re.compile(
     r"(?<!%)%[#0\- +]?[0-9.*]*[sdrixfgeEcoX](?![a-zA-Z])"
 )
+ADJACENT_STRING_LITERAL_PATTERN: re.Pattern[str] = re.compile(
+    r'(?<!["\'])[rRbBfFuU]{0,2}(?:"(?:[^"\\\n]|\\.)*"|\'(?:[^\'\\\n]|\\.)*\')'
+    r'\s*[rRbBfFuU]{0,2}(?:"(?:[^"\\\n]|\\.)*"|\'(?:[^\'\\\n]|\\.)*\')(?!["\'])'
+)
 MINIMUM_FORMAT_LOGGER_ARGUMENT_COUNT = 2
+ALL_LOGGING_CALL_METHOD_NAMES: frozenset[str] = frozenset(
+    {"debug", "info", "warning", "error", "critical", "exception"}
+)
+LOGGING_HELPER_FUNCTION_NAME_PATTERN: re.Pattern[str] = re.compile(
+    r"^log_(?:debug|info|warning|error|critical|exception)$"
+)
+LOGGING_RECEIVER_NAME_PATTERN: re.Pattern[str] = re.compile(r"^_?(?:logger|logging|log)$")
 SPAWN_AGENT_WITH_JSDOC_PATTERN: re.Pattern[str] = re.compile(
     r"/\*\*(?P<jsdoc>(?:(?!\*/).)*?)\*/\s*"
     r"(?:async\s+)?function\s+spawn(?P<role>\w+?)Agent\s*\(",
@@ -233,9 +244,39 @@ JSDOC_RETURNS_STRUCTURED_OBJECT_PROMISE_PATTERN: re.Pattern[str] = re.compile(
 RETURN_CALL_OPENING_PARENTHESIS_PATTERN: re.Pattern[str] = re.compile(
     r"\breturn\s+(?:await\s+)?(?P<callee>\w+)\s*\("
 )
+BARE_FLAG_CONTRACT_PATTERN: re.Pattern[str] = re.compile(
+    r"never a bare (?P<flag>\w+) flag", re.IGNORECASE
+)
+BARE_FLAG_RETURN_DIRECTIVE_PATTERN: re.Pattern[str] = re.compile(
+    r"\breturn\s+(?P<flag>\w+)\s*:\s*(?:true|false)\b", re.IGNORECASE
+)
 SCHEMA_OPTIONS_PROPERTY_KEY_PATTERN: re.Pattern[str] = re.compile(
     r"(?<![A-Za-z0-9_])schema\s*:"
 )
+RETURN_OBJECT_LITERAL_OPENING_PATTERN: re.Pattern[str] = re.compile(r"\breturn\s*\{")
+ARROW_CONCISE_BODY_OBJECT_LITERAL_OPENING_PATTERN: re.Pattern[str] = re.compile(
+    r"=>\s*\(\s*\{"
+)
+JS_OBJECT_KEY_IDENTIFIER_PATTERN: re.Pattern[str] = re.compile(r"[A-Za-z_$][\w$]*")
+JS_OBJECT_METHOD_SHORTHAND_KEY_PATTERN: re.Pattern[str] = re.compile(
+    r"\A([A-Za-z_$][\w$]*)\s*\("
+)
+ALL_JAVASCRIPT_CONTROL_FLOW_BLOCK_KEYWORDS: frozenset[str] = frozenset(
+    {"if", "for", "await", "while", "switch", "catch", "with"}
+)
+ALL_JAVASCRIPT_PARENTHESIS_FREE_BLOCK_KEYWORDS: frozenset[str] = frozenset(
+    {"else", "do", "try", "finally"}
+)
+ALL_JAVASCRIPT_BRACKET_OPENERS: frozenset[str] = frozenset({"(", "[", "{"})
+ALL_JAVASCRIPT_BRACKET_CLOSERS: frozenset[str] = frozenset({")", "]", "}"})
+ALL_JAVASCRIPT_IDENTIFIER_EXTRA_CHARACTERS: frozenset[str] = frozenset({"_", "$"})
+ALL_JAVASCRIPT_RETURN_TYPE_TERMINATORS: frozenset[str] = frozenset({"}", ">", "]"})
+JAVASCRIPT_ARROW_TOKEN_LENGTH: int = 2
+ALL_JAVASCRIPT_BARE_RETURN_TYPE_EXTRA_CHARACTERS: frozenset[str] = frozenset(
+    {"_", "$", ".", "|", "&", "?"}
+)
+JAVASCRIPT_OBJECT_SPREAD_PREFIX: str = "..."
+JAVASCRIPT_MODULE_SCOPE_SENTINEL: int = -1
 ALL_BUILTIN_DICT_METHOD_NAMES: frozenset[str] = frozenset({
     "get", "items", "keys", "values", "update", "pop",
     "setdefault", "copy", "clear",

package/hooks/hooks_constants/code_rules_path_utils_constants.py

@@ -22,8 +22,8 @@ ALL_CONFIG_DIRECTORY_NAMES = frozenset(
         "pr_converge_skill_constants",
         "pr_converge_scripts_constants",
         "bugteam_scripts_constants",
-        "doc_gist_scripts_constants",
         "implement_scripts_constants",
+        "log_audit_constants",
         "dev_env_scripts_constants",
     }
 )

package/hooks/hooks_constants/duplicate_rmtree_helper_blocker_constants.py

@@ -19,7 +19,6 @@ ALL_EXEMPT_PATH_FRAGMENTS: tuple[str, ...] = (
     "windows_safe_rmtree.py",
     "windows_filesystem.py",
     "session_env_cleanup.py",
-    "_md_to_html_blocker_test_support.py",
     "teardown_worktrees.py",
 )
 

package/hooks/hooks_constants/post_tool_use_dispatcher_constants.py

@@ -62,9 +62,4 @@ ALL_POST_HOSTED_HOOK_ENTRIES: tuple[PostHostedHookEntry, ...] = (
         script_relative_path="workflow/auto_formatter.py",
         is_blocking=False,
     ),
-    PostHostedHookEntry(
-        script_relative_path="workflow/doc_gist_auto_publish.py",
-        extra_argument_relative_paths=(PLUGIN_ROOT_PLACEHOLDER,),
-        is_blocking=False,
-    ),
 )

package/hooks/hooks_constants/pre_tool_use_dispatcher_constants.py

@@ -105,6 +105,10 @@ ALL_HOSTED_HOOK_ENTRIES: tuple[HostedHookEntry, ...] = (
         applicable_tool_names=ALL_WRITE_AND_EDIT_TOOL_NAMES,
         native_module_name=STATE_DESCRIPTION_BLOCKER_MODULE_NAME,
     ),
+    HostedHookEntry(
+        script_relative_path="blocking/stale_comment_reference_blocker.py",
+        applicable_tool_names=frozenset({EDIT_TOOL_NAME}),
+    ),
     HostedHookEntry(
         script_relative_path="blocking/subprocess_budget_completeness.py",
         applicable_tool_names=ALL_WRITE_AND_EDIT_TOOL_NAMES,

package/hooks/hooks_constants/reviewer_spawn_gate_constants.py

@@ -0,0 +1,41 @@
+"""Configuration constants for the reviewer_spawn_gate PreToolUse hook."""
+
+from __future__ import annotations
+
+import re
+from pathlib import Path
+
+BASH_TOOL_NAME: str = "Bash"
+
+GATE_SENTINEL_MARKER: str = "CLAUDE_REVIEWER_GATE=autoconverge"
+
+COPILOT_REVIEWER_TOKEN: str = "copilot"
+BUGBOT_REVIEWER_TOKEN: str = "bugbot"
+
+COPILOT_REVIEWER_LABEL: str = "GitHub Copilot"
+BUGBOT_REVIEWER_LABEL: str = "Cursor Bugbot"
+
+ALL_COPILOT_TRIGGER_MARKERS: tuple[str, ...] = (
+    "requested_reviewers",
+    "copilot-pull-request-reviewer[bot]",
+)
+
+BUGBOT_TRIGGER_SCRIPT_MARKER: str = "post_fix_reply.py"
+BUGBOT_RUN_BODY_PATTERN: re.Pattern[str] = re.compile(
+    r'--body\s+["\']bugbot run["\']', re.IGNORECASE
+)
+
+AVAILABILITY_SCRIPT_RELATIVE_PATH: Path = (
+    Path("_shared") / "pr-loop" / "scripts" / "reviewer_availability.py"
+)
+AVAILABILITY_SCRIPT_PATH_ENV_VAR_NAME: str = "REVIEWER_SPAWN_GATE_AVAILABILITY_SCRIPT_PATH"
+AVAILABILITY_SCRIPT_TIMEOUT_SECONDS: int = 15
+AVAILABILITY_REVIEWER_FLAG: str = "--reviewer"
+AVAILABILITY_DOWN_EXIT_CODE: int = 3
+
+DENY_REASON_TEMPLATE: str = (
+    "BLOCKED [reviewer-spawn-gate]: {reviewer_label} is down or out of quota "
+    "this run. Skip requesting {reviewer_label} on this trigger — "
+    "autoconverge requests it again once the availability check reports it "
+    "back.\n\nAvailability check output: {availability_detail}"
+)