claude-dev-env 1.78.0 → 1.80.0

package/_shared/pr-loop/scripts/tests/test_copilot_quota.py

@@ -0,0 +1,242 @@
+"""Direct unit tests for the copilot_quota pre-check.
+
+Every case drives the production ``main`` / ``evaluate_copilot_quota`` path with
+only the ``gh`` subprocess boundary (``_run_gh``) stubbed, fed a captured
+``copilot_internal/user`` JSON fixture in the jonecho shape.
+"""
+
+import importlib.util
+import json
+import sys
+from pathlib import Path
+from types import ModuleType
+
+import pytest
+
+
+def _load_copilot_quota_module() -> ModuleType:
+    scripts_directory = Path(__file__).parent.parent
+    if str(scripts_directory) not in sys.path:
+        sys.path.insert(0, str(scripts_directory))
+    module_path = scripts_directory / "copilot_quota.py"
+    specification = importlib.util.spec_from_file_location("copilot_quota", module_path)
+    assert specification is not None
+    assert specification.loader is not None
+    module = importlib.util.module_from_spec(specification)
+    sys.modules[specification.name] = module
+    specification.loader.exec_module(module)
+    return module
+
+
+copilot_quota = _load_copilot_quota_module()
+
+FIXTURE_PATH = Path(__file__).parent / "fixtures" / "copilot_internal_user_jonecho.json"
+AVAILABLE_USER_JSON = FIXTURE_PATH.read_text(encoding="utf-8")
+FAKE_TOKEN_RESULT = (0, "ghp_faketoken_value\n")
+
+
+def _exhausted_user_json() -> str:
+    user = json.loads(AVAILABLE_USER_JSON)
+    premium = user["quota_snapshots"]["premium_interactions"]
+    premium["remaining"] = 0
+    premium["quota_remaining"] = 0.0
+    premium["percent_remaining"] = 0.0
+    return json.dumps(user)
+
+
+def _user_json_without_premium_snapshot() -> str:
+    user = json.loads(AVAILABLE_USER_JSON)
+    del user["quota_snapshots"]
+    return json.dumps(user)
+
+
+def _gh_stub(token_result: tuple[int, str], api_result: tuple[int, str]):
+    def _fake_run_gh(
+        command_arguments: list[str],
+        extra_environment: dict[str, str] | None = None,
+    ) -> tuple[int, str]:
+        if command_arguments and command_arguments[0] == "auth":
+            return token_result
+        if command_arguments and command_arguments[0] == "api":
+            return api_result
+        raise AssertionError(f"unexpected gh command {command_arguments}")
+
+    return _fake_run_gh
+
+
+@pytest.fixture(autouse=True)
+def _isolate_account_sources(monkeypatch: pytest.MonkeyPatch, tmp_path: Path) -> None:
+    monkeypatch.delenv("COPILOT_QUOTA_ACCOUNT", raising=False)
+    monkeypatch.setattr(
+        copilot_quota, "COPILOT_QUOTA_DEFAULT_ENV_FILE_PATH", tmp_path / ".env"
+    )
+
+
+def test_main_runs_copilot_when_premium_quota_available(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    monkeypatch.setenv("COPILOT_QUOTA_ACCOUNT", "jonecho")
+    monkeypatch.setattr(
+        copilot_quota,
+        "_run_gh",
+        _gh_stub(FAKE_TOKEN_RESULT, (0, AVAILABLE_USER_JSON)),
+    )
+    exit_code = copilot_quota.main([])
+    captured = capsys.readouterr()
+    assert exit_code == 0
+    assert "running Copilot" in captured.out
+    assert "6817" in captured.out
+
+
+def test_main_exits_out_of_quota_when_premium_exhausted(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    monkeypatch.setenv("COPILOT_QUOTA_ACCOUNT", "jonecho")
+    monkeypatch.setattr(
+        copilot_quota,
+        "_run_gh",
+        _gh_stub(FAKE_TOKEN_RESULT, (0, _exhausted_user_json())),
+    )
+    exit_code = copilot_quota.main([])
+    captured = capsys.readouterr()
+    assert exit_code == 1
+    assert "scenario A" in captured.err
+
+
+def test_main_exits_api_down_on_non_json_response(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    monkeypatch.setenv("COPILOT_QUOTA_ACCOUNT", "jonecho")
+    monkeypatch.setattr(
+        copilot_quota,
+        "_run_gh",
+        _gh_stub(FAKE_TOKEN_RESULT, (0, "not json at all")),
+    )
+    exit_code = copilot_quota.main([])
+    captured = capsys.readouterr()
+    assert exit_code == 2
+    assert "scenario B" in captured.err
+
+
+def test_main_exits_api_down_on_missing_premium_snapshot(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    monkeypatch.setenv("COPILOT_QUOTA_ACCOUNT", "jonecho")
+    monkeypatch.setattr(
+        copilot_quota,
+        "_run_gh",
+        _gh_stub(FAKE_TOKEN_RESULT, (0, _user_json_without_premium_snapshot())),
+    )
+    exit_code = copilot_quota.main([])
+    captured = capsys.readouterr()
+    assert exit_code == 2
+    assert "scenario B" in captured.err
+
+
+def test_main_exits_api_down_when_gh_token_unresolved(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    monkeypatch.setenv("COPILOT_QUOTA_ACCOUNT", "jonecho")
+    monkeypatch.setattr(
+        copilot_quota,
+        "_run_gh",
+        _gh_stub((1, ""), (0, AVAILABLE_USER_JSON)),
+    )
+    exit_code = copilot_quota.main([])
+    captured = capsys.readouterr()
+    assert exit_code == 2
+    assert "scenario B" in captured.err
+
+
+def test_main_exits_no_config_and_names_env_path_and_key(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    def _fail_if_called(
+        command_arguments: list[str],
+        extra_environment: dict[str, str] | None = None,
+    ) -> tuple[int, str]:
+        raise AssertionError("gh must not run when no account is configured")
+
+    monkeypatch.setattr(copilot_quota, "_run_gh", _fail_if_called)
+    exit_code = copilot_quota.main([])
+    captured = capsys.readouterr()
+    assert exit_code == 3
+    assert "scenario C" in captured.err
+    assert "COPILOT_QUOTA_ACCOUNT" in captured.err
+    assert ".env" in captured.err
+
+
+@pytest.mark.parametrize(
+    ("api_result", "expected_exit_code", "expected_scenario"),
+    [
+        ((0, _exhausted_user_json()), 1, "scenario A"),
+        ((0, "not json at all"), 2, "scenario B"),
+    ],
+)
+def test_every_gh_backed_skip_writes_a_log_line_naming_the_scenario(
+    monkeypatch: pytest.MonkeyPatch,
+    capsys: pytest.CaptureFixture[str],
+    api_result: tuple[int, str],
+    expected_exit_code: int,
+    expected_scenario: str,
+) -> None:
+    monkeypatch.setenv("COPILOT_QUOTA_ACCOUNT", "jonecho")
+    monkeypatch.setattr(
+        copilot_quota, "_run_gh", _gh_stub(FAKE_TOKEN_RESULT, api_result)
+    )
+    exit_code = copilot_quota.main([])
+    captured = capsys.readouterr()
+    assert exit_code == expected_exit_code
+    assert captured.out == ""
+    assert expected_scenario in captured.err
+    assert captured.err.strip() != ""
+
+
+def test_cli_account_takes_precedence_over_env_var(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    monkeypatch.setenv("COPILOT_QUOTA_ACCOUNT", "env-user")
+    accounts_seen: list[str] = []
+
+    def _fake_run_gh(
+        command_arguments: list[str],
+        extra_environment: dict[str, str] | None = None,
+    ) -> tuple[int, str]:
+        if command_arguments[0] == "auth":
+            accounts_seen.append(command_arguments[-1])
+            return FAKE_TOKEN_RESULT
+        return (0, AVAILABLE_USER_JSON)
+
+    monkeypatch.setattr(copilot_quota, "_run_gh", _fake_run_gh)
+    decision = copilot_quota.evaluate_copilot_quota(
+        cli_account="cli-user", env_file_path=tmp_path / ".env"
+    )
+    assert decision.exit_code == 0
+    assert accounts_seen == ["cli-user"]
+
+
+def test_account_resolves_from_env_file_when_flag_and_env_absent(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    env_file = tmp_path / ".env"
+    env_file.write_text(
+        "# local copilot quota account\nCOPILOT_QUOTA_ACCOUNT=file-user\n",
+        encoding="utf-8",
+    )
+    accounts_seen: list[str] = []
+
+    def _fake_run_gh(
+        command_arguments: list[str],
+        extra_environment: dict[str, str] | None = None,
+    ) -> tuple[int, str]:
+        if command_arguments[0] == "auth":
+            accounts_seen.append(command_arguments[-1])
+            return FAKE_TOKEN_RESULT
+        return (0, AVAILABLE_USER_JSON)
+
+    monkeypatch.setattr(copilot_quota, "_run_gh", _fake_run_gh)
+    decision = copilot_quota.evaluate_copilot_quota(
+        cli_account=None, env_file_path=env_file
+    )
+    assert decision.exit_code == 0
+    assert accounts_seen == ["file-user"]

package/_shared/pr-loop/scripts/tests/test_copilot_quota_constants.py

@@ -0,0 +1,63 @@
+"""Tests for copilot_quota_constants.py extracted constant set."""
+
+import importlib.util
+from pathlib import Path
+from types import ModuleType
+
+
+def _load_constants_module() -> ModuleType:
+    module_path = (
+        Path(__file__).parent.parent
+        / "pr_loop_shared_constants"
+        / "copilot_quota_constants.py"
+    )
+    specification = importlib.util.spec_from_file_location(
+        "pr_loop_shared_constants.copilot_quota_constants", module_path
+    )
+    assert specification is not None
+    assert specification.loader is not None
+    module = importlib.util.module_from_spec(specification)
+    specification.loader.exec_module(module)
+    return module
+
+
+constants_module = _load_constants_module()
+
+
+def test_copilot_quota_account_env_var_name() -> None:
+    assert (
+        constants_module.COPILOT_QUOTA_ACCOUNT_ENV_VAR_NAME == "COPILOT_QUOTA_ACCOUNT"
+    )
+
+
+def test_gh_token_env_var_name() -> None:
+    assert constants_module.GH_TOKEN_ENV_VAR_NAME == "GH_TOKEN"
+
+
+def test_copilot_internal_user_api_path() -> None:
+    assert constants_module.COPILOT_INTERNAL_USER_API_PATH == "copilot_internal/user"
+
+
+def test_premium_interactions_gating_field_names() -> None:
+    assert constants_module.QUOTA_SNAPSHOTS_FIELD_NAME == "quota_snapshots"
+    assert constants_module.PREMIUM_INTERACTIONS_FIELD_NAME == "premium_interactions"
+    assert constants_module.PREMIUM_UNLIMITED_FIELD_NAME == "unlimited"
+    assert constants_module.PREMIUM_REMAINING_FIELD_NAME == "remaining"
+    assert constants_module.PREMIUM_OVERAGE_PERMITTED_FIELD_NAME == "overage_permitted"
+
+
+def test_exit_codes_are_the_four_distinct_scenarios() -> None:
+    all_exit_codes = (
+        constants_module.EXIT_CODE_QUOTA_AVAILABLE,
+        constants_module.EXIT_CODE_OUT_OF_QUOTA,
+        constants_module.EXIT_CODE_QUOTA_API_DOWN,
+        constants_module.EXIT_CODE_NO_ACCOUNT_CONFIGURED,
+    )
+    assert all_exit_codes == (0, 1, 2, 3)
+    assert len(set(all_exit_codes)) == len(all_exit_codes)
+
+
+def test_default_env_file_path_sits_at_the_package_root() -> None:
+    default_env_file_path = constants_module.COPILOT_QUOTA_DEFAULT_ENV_FILE_PATH
+    assert default_env_file_path.name == ".env"
+    assert default_env_file_path.parent.name == "claude-dev-env"

package/audit-rubrics/category_rubrics/category-k-codebase-conflicts.md

@@ -22,6 +22,7 @@
 - A module's existing `_resolve_base_ref` guards a missing remote with `getattr(remote, "name", "") or DEFAULT_REMOTE`; the diff adds `_resolve_head_ref` beside it that dereferences `remote.name` bare, crashing on the detached-HEAD case its sibling survives.
 - A rules reference whose enforcement table marks letter J with ⚡ (blocking hook) while its audit-surface section three paragraphs later lists J under "non-blocking, multi-file reasoning" — one letter, two contradictory enforcement claims in one document.
 - A hooks.json with the same hook registered in two parallel matcher blocks (Write|Edit + MultiEdit) when an existing Write|Edit|MultiEdit block already handles the same surface.
+- A new function re-implements an in-place atomic file rewrite — stream to a temp sibling, `os.replace` over the original, best-effort temp cleanup on failure — that a shared helper already centralizes (`rewrite_stp_member_atomically` and the like); the two copies drift the moment one gets a temp-naming or concurrency fix the other misses (CODE_RULES §3, reuse before create). The audit catches it by matching the diff's temp-sibling-plus-`os.replace` orchestration against the shared module the same file already imports from.
 
 **Companion reference:** see `../source-material-section-types.md`.
 

package/bin/install.mjs

@@ -312,6 +312,7 @@ export const FOLDED_HOOK_RELATIVE_PATHS = new Set([
     'blocking/verified_commit_message_accuracy_blocker.py',
     'blocking/workflow_substitution_slot_blocker.py',
     'blocking/claude_md_orphan_file_blocker.py',
+    'blocking/env_var_table_code_drift_blocker.py',
     'blocking/pytest_testpaths_orphan_blocker.py',
     'blocking/open_questions_in_plans_blocker.py',
     'blocking/plain_language_blocker.py',

package/bin/install.test.mjs

@@ -718,8 +718,8 @@ const OLD_FOLDED_HOOKS_SETTINGS = {
 };
 
 
-test('FOLDED_HOOK_RELATIVE_PATHS contains all 15 hooks removed from hooks.json', () => {
-    assert.equal(FOLDED_HOOK_RELATIVE_PATHS.size, 15);
+test('FOLDED_HOOK_RELATIVE_PATHS contains all 16 hooks removed from hooks.json', () => {
+    assert.equal(FOLDED_HOOK_RELATIVE_PATHS.size, 16);
     assert.ok(FOLDED_HOOK_RELATIVE_PATHS.has('blocking/write_existing_file_blocker.py'));
     assert.ok(FOLDED_HOOK_RELATIVE_PATHS.has('blocking/plain_language_blocker.py'));
     assert.ok(FOLDED_HOOK_RELATIVE_PATHS.has('blocking/code_rules_enforcer.py'));
@@ -741,6 +741,7 @@ test('FOLDED_HOOK_RELATIVE_PATHS lists every hook the PreToolUse dispatcher host
         'blocking/verified_commit_message_accuracy_blocker.py',
         'blocking/workflow_substitution_slot_blocker.py',
         'blocking/claude_md_orphan_file_blocker.py',
+        'blocking/env_var_table_code_drift_blocker.py',
         'blocking/pytest_testpaths_orphan_blocker.py',
         'blocking/open_questions_in_plans_blocker.py',
         'blocking/plain_language_blocker.py',

package/hooks/blocking/CLAUDE.md

@@ -38,7 +38,7 @@ The check modules it calls are the `code_rules_<concern>.py` files below.
 | `code_rules_naming_collection.py` | Collection names must use `all_*` prefix |
 | `code_rules_optional_params.py` | No optional parameters where a required one would do |
 | `code_rules_orphan_css_class.py` | CSS class attributes in Python markup with no matching `.<class>` selector |
-| `code_rules_paired_test.py` | A public function omitted by a module's established paired test suite must get a behavioral test |
+| `code_rules_paired_test.py` | A public function omitted by a module's established paired test suite must get a behavioral test — checked on both the production-module write and the stem-matched test-file write |
 | `code_rules_path_utils.py` | Path utility helpers shared across check modules |
 | `code_rules_paths_syspath.py` | `sys.path.insert` must be guarded |
 | `code_rules_probe_chains.py` | Probe-chain detection logic |
@@ -66,6 +66,7 @@ The check modules it calls are the `code_rules_<concern>.py` files below.
 | `destructive_command_blocker.py` | PreToolUse (Bash/PowerShell) | Shell commands with destructive literals (`rm -rf`, `git reset --hard`, etc.) |
 | `docstring_rule_gate_count_blocker.py` | PreToolUse (Write/Edit/MultiEdit) | A stale spelled-out gate-validator count in `docstring-prose-matches-implementation.md` — the "N more gate validators" / "M gated slices" count drifting from the `check_docstring_*` validators the prose names |
 | `duplicate_rmtree_helper_blocker.py` | PreToolUse (Write/Edit) | A local re-definition of the Windows-safe rmtree helper trio (`_strip_read_only_and_retry`, `_force_remove_tree` / `force_rmtree`) in place of importing a shared helper |
+| `env_var_table_code_drift_blocker.py` | PreToolUse (Write/Edit/MultiEdit) | A markdown env-var summary table row attributing an environment variable to a code file whose source never references that variable name |
 | `es_exe_path_rewriter.py` | PreToolUse | Rewrites paths referencing `.exe` under the Everything search path |
 | `gh_body_arg_blocker.py` | PreToolUse (Bash) | `gh` commands passing `--body`/`-b` directly (requires `--body-file` instead) |
 | `gh_pr_author_enforcer.py` | PreToolUse | Enforces PR author identity rules |
@@ -75,7 +76,7 @@ The check modules it calls are the `code_rules_<concern>.py` files below.
 | `intent_only_ending_blocker.py` | Stop | Responses that end on a plan or intent without doing the work |
 | `md_to_html_blocker.py` | PreToolUse (Write/Edit) | Writing `.md` files when an `.html` companion is required |
 | `open_questions_in_plans_blocker.py` | PreToolUse (Write/Edit) | Plan documents with unresolved open questions |
-| `package_inventory_stale_blocker.py` | PreToolUse (Write) | A new production code file created in a directory whose `README.md`/`CLAUDE.md` inventory names two or more sibling files but no entry for the new file |
+| `package_inventory_stale_blocker.py` | PreToolUse (Write) | A new production code file created in a directory whose `README.md`/`CLAUDE.md` inventory (or a parent skill's `SKILL.md` Layout table mapping the `scripts/` subdirectory) names two or more sibling files but no entry for the new file |
 | `plain_language_blocker.py` | PreToolUse (Write/Edit/AskUserQuestion) | Heavy or jargon words in user-facing prose |
 | `pr_converge_bugteam_enforcer.py` | PreToolUse | Enforces that bugteam runs in parallel with bugbot in pr-converge loops |
 | `pr_description_enforcer.py` | PreToolUse (Bash) | `gh pr create`/`edit` without a PR-description-writer-authored body |