claude-dev-env 1.77.0 → 1.79.0

package/hooks/blocking/code_rules_enforcer.py

@@ -64,22 +64,32 @@ from code_rules_dead_dataclass_field import (  # noqa: E402
 from code_rules_dead_module_constant import (  # noqa: E402
     check_dead_module_constants,
 )
+from code_rules_dead_split_branch import (  # noqa: E402
+    check_dead_split_truthiness_branch,
+)
 from code_rules_docstrings import (  # noqa: E402
     check_class_docstring_names_public_methods,
     check_docstring_args_match_signature,
     check_docstring_args_single_line_scope_vs_span,
     check_docstring_cardinal_count_matches_constant_family,
+    check_docstring_documents_unreferenced_parameter,
     check_docstring_fallback_branch_coverage,
+    check_docstring_field_runmode_outcome,
     check_docstring_format,
+    check_docstring_length_constant_superlative_vs_exact_gate,
     check_docstring_names_undefined_constant,
     check_docstring_no_consumer_claim,
     check_docstring_no_inline_literal_claim,
+    check_docstring_no_network_claim_with_metadata_access,
+    check_docstring_punctuation_mark_enumeration_coverage,
+    check_docstring_raises_unraisable_largezipfile,
     check_docstring_returns_plural_cardinality,
     check_docstring_runon_sentence,
     check_docstring_step_enumeration_dispatch_coverage,
     check_docstring_tuple_enumeration_match,
     check_docstring_unguarded_malformed_payload_claim,
     check_module_docstring_names_public_checks,
+    check_module_docstring_scope_omits_data_schema_constants,
 )
 from code_rules_duplicate_body import (  # noqa: E402
     advise_cross_skill_duplicate_helper,
@@ -107,6 +117,7 @@ from code_rules_mock_completeness import (  # noqa: E402
 from code_rules_naming_collection import (  # noqa: E402
     check_collection_prefix,
     check_loop_variable_naming,
+    check_polarity_name_contradiction,
     check_stuttering_collection_prefix,
 )
 from code_rules_optional_params import (  # noqa: E402
@@ -116,6 +127,10 @@ from code_rules_optional_params import (  # noqa: E402
 from code_rules_orphan_css_class import (  # noqa: E402
     check_orphan_css_classes,
 )
+from code_rules_paired_test import (  # noqa: E402
+    check_public_function_missing_paired_test,
+    check_test_file_omits_module_public_function,
+)
 from code_rules_paths_syspath import (  # noqa: E402
     check_hardcoded_user_paths,
     check_sys_path_insert_deduplication_guard,
@@ -131,6 +146,7 @@ from code_rules_string_magic import (  # noqa: E402
     check_inline_literal_collections,
     check_inline_tuple_string_magic,
     check_string_literal_magic,
+    check_whitespace_indentation_magic,
 )
 from code_rules_test_assertions import (  # noqa: E402
     check_constant_equality_tests,
@@ -138,6 +154,7 @@ from code_rules_test_assertions import (  # noqa: E402
     check_flag_gated_scenario_test_naming,
     check_skip_decorators_in_tests,
     check_stale_test_name_target,
+    check_vacuous_cleanup_assertion_tests,
 )
 from code_rules_test_branching_except import (  # noqa: E402
     check_bare_except,
@@ -285,8 +302,16 @@ def validate_content(
         all_issues.extend(check_boundary_types(effective_content, file_path))
         all_issues.extend(check_docstring_format(effective_content, file_path))
         all_issues.extend(check_docstring_args_match_signature(effective_content, file_path))
+        all_issues.extend(
+            check_docstring_documents_unreferenced_parameter(effective_content, file_path)
+        )
         all_issues.extend(check_docstring_fallback_branch_coverage(effective_content, file_path))
         all_issues.extend(check_docstring_no_consumer_claim(effective_content, file_path))
+        all_issues.extend(
+            check_docstring_no_network_claim_with_metadata_access(
+                effective_content, file_path
+            )
+        )
         all_issues.extend(
             check_docstring_unguarded_malformed_payload_claim(
                 effective_content, file_path
@@ -302,9 +327,19 @@ def validate_content(
         all_issues.extend(
             check_module_docstring_names_public_checks(effective_content, file_path)
         )
+        all_issues.extend(
+            check_module_docstring_scope_omits_data_schema_constants(
+                effective_content, file_path
+            )
+        )
         all_issues.extend(
             check_docstring_tuple_enumeration_match(effective_content, file_path)
         )
+        all_issues.extend(
+            check_docstring_punctuation_mark_enumeration_coverage(
+                effective_content, file_path
+            )
+        )
         all_issues.extend(
             check_docstring_step_enumeration_dispatch_coverage(
                 effective_content, file_path
@@ -313,6 +348,17 @@ def validate_content(
         all_issues.extend(
             check_docstring_returns_plural_cardinality(effective_content, file_path)
         )
+        all_issues.extend(
+            check_docstring_length_constant_superlative_vs_exact_gate(
+                effective_content, file_path
+            )
+        )
+        all_issues.extend(
+            check_docstring_field_runmode_outcome(effective_content, file_path)
+        )
+        all_issues.extend(
+            check_docstring_raises_unraisable_largezipfile(effective_content, file_path)
+        )
         all_issues.extend(
             check_docstring_cardinal_count_matches_constant_family(
                 effective_content, file_path
@@ -351,6 +397,7 @@ def validate_content(
         )
         all_issues.extend(check_existence_check_tests(content, file_path))
         all_issues.extend(check_constant_equality_tests(content, file_path))
+        all_issues.extend(check_vacuous_cleanup_assertion_tests(content, file_path))
         all_issues.extend(check_stale_test_name_target(content, file_path))
         check_flag_gated_scenario_test_naming(content, file_path)
         all_issues.extend(check_unused_optional_parameters(content, file_path))
@@ -373,6 +420,7 @@ def validate_content(
         all_issues.extend(
             check_dead_module_constants(content, file_path, full_file_content)
         )
+        all_issues.extend(check_dead_split_truthiness_branch(content, file_path))
         all_issues.extend(check_library_print(content, file_path))
         all_issues.extend(check_parameter_annotations(content, file_path))
         all_issues.extend(check_known_pytest_fixture_annotations(content, file_path))
@@ -388,10 +436,26 @@ def validate_content(
                 defer_scope_to_caller,
             )
         )
+        all_issues.extend(
+            check_public_function_missing_paired_test(
+                effective_content,
+                file_path,
+                all_changed_lines,
+                defer_scope_to_caller,
+            )
+        )
+        all_issues.extend(
+            check_test_file_omits_module_public_function(
+                effective_content,
+                file_path,
+            )
+        )
         all_issues.extend(check_loop_variable_naming(content, file_path))
+        all_issues.extend(check_polarity_name_contradiction(content, file_path))
         all_issues.extend(check_inline_literal_collections(content, file_path))
         all_issues.extend(check_inline_tuple_string_magic(content, file_path))
         all_issues.extend(check_string_literal_magic(content, file_path))
+        all_issues.extend(check_whitespace_indentation_magic(content, file_path))
         all_issues.extend(check_orphan_css_classes(effective_content, file_path))
         check_incomplete_mocks(content, file_path)
         check_duplicated_format_patterns(content, file_path)

package/hooks/blocking/code_rules_naming_collection.py

@@ -1,6 +1,7 @@
-"""Collection-prefix, stuttering-prefix, and loop-variable naming checks."""
+"""Collection-prefix, stuttering-prefix, loop-variable, and polarity-name-contradiction naming checks."""
 
 import ast
+import re
 import sys
 from pathlib import Path
 
@@ -11,6 +12,7 @@ if _blocking_directory not in sys.path:
 if _hooks_directory not in sys.path:
     sys.path.insert(0, _hooks_directory)
 
+from code_rules_boolean_mustcheck import _called_terminal_name  # noqa: E402
 from code_rules_shared import (  # noqa: E402
     _collect_annotated_arguments,
     _collect_target_names,
@@ -22,11 +24,13 @@ from code_rules_shared import (  # noqa: E402
 from hooks_constants.code_rules_enforcer_constants import (  # noqa: E402
     ALL_COLLECTION_TYPE_NAMES,
     ALL_LOOP_INDEX_LETTER_EXEMPTIONS,
+    ALL_POLARITY_ANTONYM_TOKEN_PAIRS,
     ALL_SUBSCRIPT_ONLY_COLLECTION_TYPE_NAMES,
     ALL_UNION_TYPING_NAMES,
     BARE_EACH_TOKEN,
     COLLECTION_BY_NAME_PATTERN,
     EACH_PREFIX,
+    POLARITY_TOKEN_BOUNDARY_PATTERN,
     UPPER_SNAKE_CONSTANT_PATTERN,
 )
 from hooks_constants.stuttering_check_config import (  # noqa: E402
@@ -262,3 +266,74 @@ def check_loop_variable_naming(content: str, file_path: str) -> list[str]:
                 f"Line {each_name_node.lineno}: loop variable {target_name!r} - prefix with each_ (CODE_RULES §5)"
             )
     return issues
+
+
+def _name_carries_token(name: str, token: str) -> bool:
+    """True when name carries token as a whole underscore-delimited word."""
+    return re.search(POLARITY_TOKEN_BOUNDARY_PATTERN % re.escape(token), name) is not None
+
+
+def _contradicting_polarity_pair(target_name: str, called_name: str) -> tuple[str, str] | None:
+    """The (target_token, called_token) antonym pair when target and callee assert opposite polarity."""
+    target_lower = target_name.lower()
+    called_lower = called_name.lower()
+    for each_positive_token, each_negative_token in ALL_POLARITY_ANTONYM_TOKEN_PAIRS:
+        if _name_carries_token(target_lower, each_positive_token) and _name_carries_token(
+            called_lower, each_negative_token
+        ):
+            return each_positive_token, each_negative_token
+        if _name_carries_token(target_lower, each_negative_token) and _name_carries_token(
+            called_lower, each_positive_token
+        ):
+            return each_negative_token, each_positive_token
+    return None
+
+
+def check_polarity_name_contradiction(content: str, file_path: str) -> list[str]:
+    """Flag a boolean assignment whose target and callee assert opposite polarity.
+
+    Catches the self-contradicting statement ``is_inside_allowed =
+    _point_hits_any_forbidden(...)`` — a target name carrying one polarity token
+    (``allowed``) assigned directly from a single call whose callee name carries
+    the antonym token (``forbidden``). One side lies about the behavior, so the
+    reader cannot trust either name. Rename the callee to a neutral form that
+    reads truthfully at every call site.
+    """
+    if is_test_file(file_path):
+        return []
+    if is_workflow_registry_file(file_path) or is_migration_file(file_path):
+        return []
+    try:
+        tree = ast.parse(content)
+    except SyntaxError:
+        return []
+    issues: list[str] = []
+    for each_node in ast.walk(tree):
+        target_name: str | None = None
+        value_node: ast.expr | None = None
+        target_line = 0
+        if isinstance(each_node, ast.Assign) and len(each_node.targets) == 1 and isinstance(
+            each_node.targets[0], ast.Name
+        ):
+            target_name = each_node.targets[0].id
+            value_node = each_node.value
+            target_line = each_node.lineno
+        elif isinstance(each_node, ast.AnnAssign) and isinstance(each_node.target, ast.Name):
+            target_name = each_node.target.id
+            value_node = each_node.value
+            target_line = each_node.lineno
+        if target_name is None or not isinstance(value_node, ast.Call):
+            continue
+        called_name = _called_terminal_name(value_node)
+        if called_name is None:
+            continue
+        contradicting_pair = _contradicting_polarity_pair(target_name, called_name)
+        if contradicting_pair is None:
+            continue
+        target_token, called_token = contradicting_pair
+        issues.append(
+            f"Line {target_line}: {target_name!r} (says {target_token!r}) is assigned from"
+            f" {called_name!r} (says {called_token!r}) - the name contradicts the value; rename the"
+            f" callee to a neutral form so each call site reads truthfully (CODE_RULES §5)"
+        )
+    return issues