claude-dev-env 1.58.0 → 1.60.0

package/skills/autoconverge/workflow/converge.contract.test.mjs

@@ -1,206 +1,206 @@
-import { test } from 'node:test';
-import { strict as assert } from 'node:assert';
-import { readFileSync } from 'node:fs';
-import { fileURLToPath } from 'node:url';
-import { dirname, join } from 'node:path';
-
-const workflowDirectory = dirname(fileURLToPath(import.meta.url));
-const convergeSource = readFileSync(join(workflowDirectory, 'converge.mjs'), 'utf8');
-const gotchasSource = readFileSync(
-  join(workflowDirectory, '..', 'reference', 'gotchas.md'),
-  'utf8',
-);
-
-function lensPromptBody(builderName) {
-  const builderStart = convergeSource.indexOf(`function ${builderName}(`);
-  assert.notEqual(builderStart, -1, `expected ${builderName} to exist`);
-  const nextBuilderStart = convergeSource.indexOf('\nfunction ', builderStart + 1);
-  const builderEnd = nextBuilderStart === -1 ? convergeSource.length : nextBuilderStart;
-  return convergeSource.slice(builderStart, builderEnd);
-}
-
-test('code-review lens prompt no longer instructs a per-lens git fetch', () => {
-  assert.doesNotMatch(lensPromptBody('runCodeReviewLens'), /git fetch origin main/);
-});
-
-test('bug-audit lens prompt no longer instructs a per-lens git fetch', () => {
-  assert.doesNotMatch(lensPromptBody('runAuditLens'), /git fetch origin main/);
-});
-
-test('a single round-level prefetch step fetches origin/main before the parallel lenses', () => {
-  assert.match(convergeSource, /function prefetchMainForRound\(/);
-  const prefetchCallIndex = convergeSource.indexOf('await prefetchMainForRound(');
-  const parallelLensIndex = convergeSource.indexOf('const lenses = await parallel(');
-  assert.notEqual(prefetchCallIndex, -1, 'expected prefetchMainForRound to be invoked');
-  assert.notEqual(parallelLensIndex, -1, 'expected the parallel lens block to exist');
-  assert.ok(
-    prefetchCallIndex < parallelLensIndex,
-    'expected the round prefetch to run before the parallel lenses spawn',
-  );
-});
-
-test('bugbot lens preamble does not blanket-instruct passing --owner/--repo to every script', () => {
-  const bugbotPrompt = lensPromptBody('runBugbotLens');
-  assert.doesNotMatch(
-    bugbotPrompt,
-    /use the existing scripts; pass --owner/,
-    'the blanket clause breaks reviews_disabled.py, which accepts only --reviewer',
-  );
-});
-
-test('bugbot lens invokes reviews_disabled.py with only --reviewer', () => {
-  const bugbotPrompt = lensPromptBody('runBugbotLens');
-  const reviewsDisabledIndex = bugbotPrompt.indexOf('reviews_disabled.py');
-  assert.notEqual(reviewsDisabledIndex, -1, 'expected reviews_disabled.py invocation');
-  const invocationLineEnd = bugbotPrompt.indexOf('\\n', reviewsDisabledIndex);
-  const invocationLine = bugbotPrompt.slice(reviewsDisabledIndex, invocationLineEnd);
-  assert.match(invocationLine, /--reviewer bugbot/);
-  assert.doesNotMatch(
-    invocationLine,
-    /--owner|--repo/,
-    'reviews_disabled.py argparse rejects --owner/--repo with SystemExit(2)',
-  );
-});
-
-test('gotchas doc states parallel lenses must avoid concurrent git operations', () => {
-  assert.doesNotMatch(gotchasSource, /cannot race on git state/);
-  assert.match(gotchasSource, /fetch.*once.*before/i);
-});
-
-test('repair-convergence filters unresolved threads to bot authors and skips human threads', () => {
-  const repairPrompt = lensPromptBody('repairConvergence');
-  assert.match(
-    repairPrompt,
-    /cursor.*claude.*copilot|copilot.*cursor.*claude|claude.*cursor.*copilot/is,
-    'expected the bot-author allowlist (Cursor/Claude/Copilot) to be named',
-  );
-  assert.match(
-    repairPrompt,
-    /skip.*human|human.*skip/is,
-    'expected an explicit instruction to skip human reviewer threads',
-  );
-});
-
-test('repair-convergence no longer instructs resolving every unresolved thread without an author filter', () => {
-  const repairPrompt = lensPromptBody('repairConvergence');
-  assert.doesNotMatch(
-    repairPrompt,
-    /fetch every thread where isResolved is false/,
-    'the unfiltered instruction could resolve human reviewer threads',
-  );
-});
-
-test('bugbot lens delay instructions are shell-agnostic with PowerShell as an alternative', () => {
-  const bugbotPrompt = lensPromptBody('runBugbotLens');
-  assert.match(bugbotPrompt, /sleep 60/, 'expected a shell-agnostic 60-second poll delay');
-  assert.match(bugbotPrompt, /sleep 8/, 'expected a concrete 8-second delay command');
-  assert.match(
-    bugbotPrompt,
-    /Start-Sleep[\s\S]*alternative|alternative[\s\S]*Start-Sleep/i,
-    'expected PowerShell to be named only as an allowed alternative',
-  );
-  assert.doesNotMatch(
-    bugbotPrompt,
-    /wait 8 seconds(?!,)/,
-    'the vague "wait 8 seconds" phrasing must carry a concrete command',
-  );
-});
-
-test('copilot gate delay instruction is shell-agnostic with PowerShell as an alternative', () => {
-  const copilotPrompt = lensPromptBody('runCopilotGate');
-  assert.match(copilotPrompt, /sleep 360/, 'expected a shell-agnostic 360-second poll delay');
-  assert.match(
-    copilotPrompt,
-    /Start-Sleep[\s\S]*alternative|alternative[\s\S]*Start-Sleep/i,
-    'expected PowerShell to be named only as an allowed alternative',
-  );
-});
-
-test('gotchas doc describes the reviewer wait as shell-agnostic', () => {
-  assert.match(
-    gotchasSource,
-    /\bsleep\b/i,
-    'expected the wait guidance to name a shell-agnostic sleep',
-  );
-  assert.doesNotMatch(
-    gotchasSource,
-    /a single PowerShell\s*`?Start-Sleep`?\s*loop/i,
-    'PowerShell Start-Sleep must be an alternative, not the sole mechanism',
-  );
-});
-
-function finalizeRepairBranch() {
-  const repairCallIndex = convergeSource.indexOf('await repairConvergence(');
-  assert.notEqual(repairCallIndex, -1, 'expected the FINALIZE repair call to exist');
-  const transitionIndex = convergeSource.indexOf("phase = 'CONVERGE'", repairCallIndex);
-  assert.notEqual(transitionIndex, -1, 'expected a CONVERGE transition after the repair call');
-  const continueIndex = convergeSource.indexOf('continue', transitionIndex);
-  assert.notEqual(continueIndex, -1, 'expected a continue statement to close the FINALIZE repair branch');
-  const branchEnd = continueIndex + 'continue'.length;
-  return convergeSource.slice(repairCallIndex, branchEnd);
-}
-
-test('the FINALIZE repair branch does not re-assign head from the repair before re-converging', () => {
-  assert.doesNotMatch(
-    finalizeRepairBranch(),
-    /head\s*=\s*repair/,
-    'the next CONVERGE pass re-resolves HEAD from GitHub, so assigning the repair SHA here is dead',
-  );
-});
-
-function fixBranchAfter(branchLabel) {
-  const labelIndex = convergeSource.indexOf(branchLabel);
-  assert.notEqual(labelIndex, -1, `expected the ${branchLabel} marker to exist`);
-  const applyFixesIndex = convergeSource.indexOf('await applyFixes(', labelIndex);
-  assert.notEqual(applyFixesIndex, -1, `expected an applyFixes call after ${branchLabel}`);
-  const continueIndex = convergeSource.indexOf('continue', applyFixesIndex);
-  assert.notEqual(continueIndex, -1, `expected a continue statement to close the ${branchLabel} branch`);
-  const branchEnd = continueIndex + 'continue'.length;
-  return convergeSource.slice(applyFixesIndex, branchEnd);
-}
-
-test('the CONVERGE fix branch does not re-assign head from the fix before re-converging', () => {
-  assert.doesNotMatch(
-    fixBranchAfter('${findings.length} finding(s) — applying fixes'),
-    /head\s*=\s*fixProgress/,
-    'the next CONVERGE pass re-resolves HEAD from GitHub, so assigning the fix SHA here is dead',
-  );
-});
-
-test('the COPILOT fix branch does not re-assign head from the fix before re-converging', () => {
-  assert.doesNotMatch(
-    fixBranchAfter('${copilotOutcome.findings.length} finding(s) — fixing and re-converging'),
-    /head\s*=\s*fixProgress/,
-    'the CONVERGE pass it transitions to re-resolves HEAD from GitHub, so assigning the fix SHA here is dead',
-  );
-});
-
-test('the CONVERGE branch re-resolves HEAD from GitHub on every entry', () => {
-  const convergeBranchStart = convergeSource.indexOf("if (phase === 'CONVERGE')");
-  assert.notEqual(convergeBranchStart, -1, 'expected the CONVERGE branch to exist');
-  const resolveHeadIndex = convergeSource.indexOf('head = await resolveHead()', convergeBranchStart);
-  assert.notEqual(resolveHeadIndex, -1, 'expected CONVERGE to re-resolve HEAD via resolveHead()');
-});
-
-test('fix prompt resolves threads by PRRT thread node id looked up from the comment databaseId', () => {
-  const fixPrompt = lensPromptBody('applyFixes');
-  assert.match(fixPrompt, /PRRT/, 'expected the thread node id form (PRRT_...) to be named');
-  assert.match(
-    fixPrompt,
-    /databaseId/,
-    'expected the GraphQL lookup matching comment databaseId to be named',
-  );
-  assert.match(
-    fixPrompt,
-    /not the numeric comment id/,
-    'expected an explicit guard against passing the numeric comment id to resolve_thread',
-  );
-});
-
-test('fix prompt does not pass the numeric comment id straight to resolve_thread', () => {
-  assert.doesNotMatch(
-    lensPromptBody('applyFixes'),
-    /then resolve that thread \(use the github MCP pull_request_review_write/,
-    'resolve_thread and resolveReviewThread require a PRRT_... thread node id, not the comment id',
-  );
-});
+import { test } from 'node:test';
+import { strict as assert } from 'node:assert';
+import { readFileSync } from 'node:fs';
+import { fileURLToPath } from 'node:url';
+import { dirname, join } from 'node:path';
+
+const workflowDirectory = dirname(fileURLToPath(import.meta.url));
+const convergeSource = readFileSync(join(workflowDirectory, 'converge.mjs'), 'utf8');
+const gotchasSource = readFileSync(
+  join(workflowDirectory, '..', 'reference', 'gotchas.md'),
+  'utf8',
+);
+
+function lensPromptBody(builderName) {
+  const builderStart = convergeSource.indexOf(`function ${builderName}(`);
+  assert.notEqual(builderStart, -1, `expected ${builderName} to exist`);
+  const nextBuilderStart = convergeSource.indexOf('\nfunction ', builderStart + 1);
+  const builderEnd = nextBuilderStart === -1 ? convergeSource.length : nextBuilderStart;
+  return convergeSource.slice(builderStart, builderEnd);
+}
+
+test('code-review lens prompt no longer instructs a per-lens git fetch', () => {
+  assert.doesNotMatch(lensPromptBody('runCodeReviewLens'), /git fetch origin main/);
+});
+
+test('bug-audit lens prompt no longer instructs a per-lens git fetch', () => {
+  assert.doesNotMatch(lensPromptBody('runAuditLens'), /git fetch origin main/);
+});
+
+test('a single round-level prefetch step fetches origin/main before the parallel lenses', () => {
+  assert.match(convergeSource, /function prefetchMainForRound\(/);
+  const prefetchCallIndex = convergeSource.indexOf('await prefetchMainForRound(');
+  const parallelLensIndex = convergeSource.indexOf('const lenses = await parallel(');
+  assert.notEqual(prefetchCallIndex, -1, 'expected prefetchMainForRound to be invoked');
+  assert.notEqual(parallelLensIndex, -1, 'expected the parallel lens block to exist');
+  assert.ok(
+    prefetchCallIndex < parallelLensIndex,
+    'expected the round prefetch to run before the parallel lenses spawn',
+  );
+});
+
+test('bugbot lens preamble does not blanket-instruct passing --owner/--repo to every script', () => {
+  const bugbotPrompt = lensPromptBody('runBugbotLens');
+  assert.doesNotMatch(
+    bugbotPrompt,
+    /use the existing scripts; pass --owner/,
+    'the blanket clause breaks reviews_disabled.py, which accepts only --reviewer',
+  );
+});
+
+test('bugbot lens invokes reviews_disabled.py with only --reviewer', () => {
+  const bugbotPrompt = lensPromptBody('runBugbotLens');
+  const reviewsDisabledIndex = bugbotPrompt.indexOf('reviews_disabled.py');
+  assert.notEqual(reviewsDisabledIndex, -1, 'expected reviews_disabled.py invocation');
+  const invocationLineEnd = bugbotPrompt.indexOf('\\n', reviewsDisabledIndex);
+  const invocationLine = bugbotPrompt.slice(reviewsDisabledIndex, invocationLineEnd);
+  assert.match(invocationLine, /--reviewer bugbot/);
+  assert.doesNotMatch(
+    invocationLine,
+    /--owner|--repo/,
+    'reviews_disabled.py argparse rejects --owner/--repo with SystemExit(2)',
+  );
+});
+
+test('gotchas doc states parallel lenses must avoid concurrent git operations', () => {
+  assert.doesNotMatch(gotchasSource, /cannot race on git state/);
+  assert.match(gotchasSource, /fetch.*once.*before/i);
+});
+
+test('repair-convergence filters unresolved threads to bot authors and skips human threads', () => {
+  const repairPrompt = lensPromptBody('repairConvergence');
+  assert.match(
+    repairPrompt,
+    /cursor.*claude.*copilot|copilot.*cursor.*claude|claude.*cursor.*copilot/is,
+    'expected the bot-author allowlist (Cursor/Claude/Copilot) to be named',
+  );
+  assert.match(
+    repairPrompt,
+    /skip.*human|human.*skip/is,
+    'expected an explicit instruction to skip human reviewer threads',
+  );
+});
+
+test('repair-convergence no longer instructs resolving every unresolved thread without an author filter', () => {
+  const repairPrompt = lensPromptBody('repairConvergence');
+  assert.doesNotMatch(
+    repairPrompt,
+    /fetch every thread where isResolved is false/,
+    'the unfiltered instruction could resolve human reviewer threads',
+  );
+});
+
+test('bugbot lens delay instructions are shell-agnostic with PowerShell as an alternative', () => {
+  const bugbotPrompt = lensPromptBody('runBugbotLens');
+  assert.match(bugbotPrompt, /sleep 60/, 'expected a shell-agnostic 60-second poll delay');
+  assert.match(bugbotPrompt, /sleep 8/, 'expected a concrete 8-second delay command');
+  assert.match(
+    bugbotPrompt,
+    /Start-Sleep[\s\S]*alternative|alternative[\s\S]*Start-Sleep/i,
+    'expected PowerShell to be named only as an allowed alternative',
+  );
+  assert.doesNotMatch(
+    bugbotPrompt,
+    /wait 8 seconds(?!,)/,
+    'the vague "wait 8 seconds" phrasing must carry a concrete command',
+  );
+});
+
+test('copilot gate delay instruction is shell-agnostic with PowerShell as an alternative', () => {
+  const copilotPrompt = lensPromptBody('runCopilotGate');
+  assert.match(copilotPrompt, /sleep 360/, 'expected a shell-agnostic 360-second poll delay');
+  assert.match(
+    copilotPrompt,
+    /Start-Sleep[\s\S]*alternative|alternative[\s\S]*Start-Sleep/i,
+    'expected PowerShell to be named only as an allowed alternative',
+  );
+});
+
+test('gotchas doc describes the reviewer wait as shell-agnostic', () => {
+  assert.match(
+    gotchasSource,
+    /\bsleep\b/i,
+    'expected the wait guidance to name a shell-agnostic sleep',
+  );
+  assert.doesNotMatch(
+    gotchasSource,
+    /a single PowerShell\s*`?Start-Sleep`?\s*loop/i,
+    'PowerShell Start-Sleep must be an alternative, not the sole mechanism',
+  );
+});
+
+function finalizeRepairBranch() {
+  const repairCallIndex = convergeSource.indexOf('await repairConvergence(');
+  assert.notEqual(repairCallIndex, -1, 'expected the FINALIZE repair call to exist');
+  const transitionIndex = convergeSource.indexOf("phase = 'CONVERGE'", repairCallIndex);
+  assert.notEqual(transitionIndex, -1, 'expected a CONVERGE transition after the repair call');
+  const continueIndex = convergeSource.indexOf('continue', transitionIndex);
+  assert.notEqual(continueIndex, -1, 'expected a continue statement to close the FINALIZE repair branch');
+  const branchEnd = continueIndex + 'continue'.length;
+  return convergeSource.slice(repairCallIndex, branchEnd);
+}
+
+test('the FINALIZE repair branch does not re-assign head from the repair before re-converging', () => {
+  assert.doesNotMatch(
+    finalizeRepairBranch(),
+    /head\s*=\s*repair/,
+    'the next CONVERGE pass re-resolves HEAD from GitHub, so assigning the repair SHA here is dead',
+  );
+});
+
+function fixBranchAfter(branchLabel) {
+  const labelIndex = convergeSource.indexOf(branchLabel);
+  assert.notEqual(labelIndex, -1, `expected the ${branchLabel} marker to exist`);
+  const applyFixesIndex = convergeSource.indexOf('await applyFixes(', labelIndex);
+  assert.notEqual(applyFixesIndex, -1, `expected an applyFixes call after ${branchLabel}`);
+  const continueIndex = convergeSource.indexOf('continue', applyFixesIndex);
+  assert.notEqual(continueIndex, -1, `expected a continue statement to close the ${branchLabel} branch`);
+  const branchEnd = continueIndex + 'continue'.length;
+  return convergeSource.slice(applyFixesIndex, branchEnd);
+}
+
+test('the CONVERGE fix branch does not re-assign head from the fix before re-converging', () => {
+  assert.doesNotMatch(
+    fixBranchAfter('${findings.length} finding(s) — applying fixes'),
+    /head\s*=\s*fixProgress/,
+    'the next CONVERGE pass re-resolves HEAD from GitHub, so assigning the fix SHA here is dead',
+  );
+});
+
+test('the COPILOT fix branch does not re-assign head from the fix before re-converging', () => {
+  assert.doesNotMatch(
+    fixBranchAfter('${copilotOutcome.findings.length} finding(s) — fixing and re-converging'),
+    /head\s*=\s*fixProgress/,
+    'the CONVERGE pass it transitions to re-resolves HEAD from GitHub, so assigning the fix SHA here is dead',
+  );
+});
+
+test('the CONVERGE branch re-resolves HEAD from GitHub on every entry', () => {
+  const convergeBranchStart = convergeSource.indexOf("if (phase === 'CONVERGE')");
+  assert.notEqual(convergeBranchStart, -1, 'expected the CONVERGE branch to exist');
+  const resolveHeadIndex = convergeSource.indexOf('head = await resolveHead()', convergeBranchStart);
+  assert.notEqual(resolveHeadIndex, -1, 'expected CONVERGE to re-resolve HEAD via resolveHead()');
+});
+
+test('fix prompt resolves threads by PRRT thread node id looked up from the comment databaseId', () => {
+  const fixPrompt = lensPromptBody('applyFixes');
+  assert.match(fixPrompt, /PRRT/, 'expected the thread node id form (PRRT_...) to be named');
+  assert.match(
+    fixPrompt,
+    /databaseId/,
+    'expected the GraphQL lookup matching comment databaseId to be named',
+  );
+  assert.match(
+    fixPrompt,
+    /not the numeric comment id/,
+    'expected an explicit guard against passing the numeric comment id to resolve_thread',
+  );
+});
+
+test('fix prompt does not pass the numeric comment id straight to resolve_thread', () => {
+  assert.doesNotMatch(
+    lensPromptBody('applyFixes'),
+    /then resolve that thread \(use the github MCP pull_request_review_write/,
+    'resolve_thread and resolveReviewThread require a PRRT_... thread node id, not the comment id',
+  );
+});