npm - claude-dev-env - Versions diffs - 1.57.2 → 1.59.0 - Mend

claude-dev-env 1.57.2 → 1.59.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (77) hide show

package/skills/autoconverge/reference/stop-conditions.md CHANGED Viewed

@@ -6,8 +6,6 @@ skill still runs teardown (revoke permissions, final report).
 ## Blockers (end the run short of ready)
-- **Copilot no-show** — Copilot surfaces no review on the current HEAD after
-  three polls (360 seconds apart). `blocker` names the Copilot timeout.
 - **Iteration cap** — 20 loop iterations pass without a full convergence-check
   pass. The iteration counter increments on every pass through any phase, so a
   convergence-check gate that no round can clear (for example a `mergeable_state`
@@ -40,6 +38,13 @@ skill still runs teardown (revoke permissions, final report).
   run or review after the lens poll budget, the Bugbot lens returns `down: true`.
   The run continues, and the convergence check runs with `--bugbot-down` so its
   Bugbot gate is bypassed.
+- **Copilot down or out of quota** — when Copilot posts an out-of-usage notice on
+  the current HEAD (the user who requested the review reached their quota limit)
+  rather than a code review, or surfaces no review at all after three polls, the
+  Copilot gate returns `down: true`. The run logs a notice, runs the convergence
+  check with `--copilot-down` (the Copilot review gate and the
+  pending-requested-reviews gate bypassed), and marks the PR ready. `copilotNote`
+  records the bypass for the final report.
 - **A lens agent dies** — when one parallel lens returns null (a terminal agent
   failure), the round proceeds on the surviving lenses. A real defect it would
   have caught surfaces in a later round or at the convergence check. A dead

package/skills/autoconverge/workflow/autoconverge_report_constants/__init__.py ADDED Viewed

File without changes

package/skills/autoconverge/workflow/autoconverge_report_constants/render_report_constants.py ADDED Viewed

@@ -0,0 +1,105 @@
+"""Named constants for render_report.py."""
+STRUCTURED_OUTPUT_TOOL_NAME = "StructuredOutput"
+LABEL_RESOLVE_HEAD = "resolve-head"
+LABEL_PREFIX_LENS = "lens:"
+LABEL_PREFIX_FIX = "fix:"
+LABEL_COPILOT_GATE = "copilot-gate"
+JOURNAL_SIBLING_SUBAGENTS = "subagents"
+JOURNAL_SIBLING_WORKFLOWS = "workflows"
+THEME_PATH_SEGMENT_COUNT = 2
+THEME_FALLBACK = "other"
+SEVERITY_CRITICAL_BUCKET = "Critical"
+SEVERITY_MINOR_BUCKET = "Minor"
+SEVERITY_CRITICAL_LEVELS = frozenset({"P0", "P1"})
+SEVERITY_BADGE_CLASS_BY_LEVEL = {
+    "P0": "b-p0",
+    "P1": "b-p1",
+    "P2": "b-p2",
+}
+BAR_COLOR_SEVERITY_CRITICAL = "#dc2626"
+BAR_COLOR_SEVERITY_MINOR = "#eab308"
+BAR_COLOR_ROUND = "#2563eb"
+BAR_COLOR_TESTS = "#10b981"
+BAR_COLOR_THEME = "#8b5cf6"
+TEST_DEFINITION_PATTERN = r"^\+\s*(async\s+)?def\s+(test|should)"
+TEST_PATH_GLOBS = ("*test*.py", "**/*test*.py")
+BAR_FILL_MAX_PERCENT = 100
+GITHUB_PR_URL_TEMPLATE = "https://github.com/{owner}/{repo}/pull/{number}"
+HTML_DOCTYPE = "<!DOCTYPE html>"
+HTML_HEAD_TEMPLATE = """\
+<head>
+    <meta charset="utf-8">
+    <title>PR #{pr_number} Convergence Insights</title>
+    <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700&display=swap" rel="stylesheet">
+    {style_block}
+</head>"""
+HTML_STYLE_BLOCK = """\
+<style>
+    * { box-sizing: border-box; margin: 0; padding: 0; }
+    body { font-family: 'Inter', -apple-system, BlinkMacSystemFont, sans-serif; background: #f8fafc; color: #334155; line-height: 1.65; padding: 48px 24px; }
+    .container { max-width: 800px; margin: 0 auto; }
+    h1 { font-size: 32px; font-weight: 700; color: #0f172a; margin-bottom: 8px; }
+    h2 { font-size: 20px; font-weight: 600; color: #0f172a; margin-top: 48px; margin-bottom: 16px; }
+    .subtitle { color: #64748b; font-size: 15px; margin-bottom: 32px; }
+    .nav-toc { display: flex; flex-wrap: wrap; gap: 8px; margin: 24px 0 32px 0; padding: 16px; background: white; border-radius: 8px; border: 1px solid #e2e8f0; }
+    .nav-toc a { font-size: 12px; color: #64748b; text-decoration: none; padding: 6px 12px; border-radius: 6px; background: #f1f5f9; transition: all 0.15s; }
+    .nav-toc a:hover { background: #e2e8f0; color: #334155; }
+    .stats-row { display: flex; gap: 24px; margin-bottom: 40px; padding: 20px 0; border-top: 1px solid #e2e8f0; border-bottom: 1px solid #e2e8f0; flex-wrap: wrap; }
+    .stat { text-align: center; }
+    .stat-value { font-size: 24px; font-weight: 700; color: #0f172a; }
+    .stat-label { font-size: 11px; color: #64748b; text-transform: uppercase; }
+    .at-a-glance { background: linear-gradient(135deg, #fef3c7 0%, #fde68a 100%); border: 1px solid #f59e0b; border-radius: 12px; padding: 20px 24px; margin-bottom: 32px; }
+    .glance-title { font-size: 16px; font-weight: 700; color: #92400e; margin-bottom: 16px; }
+    .glance-sections { display: flex; flex-direction: column; gap: 12px; }
+    .glance-section { font-size: 14px; color: #78350f; line-height: 1.6; }
+    .glance-section strong { color: #92400e; }
+    .section-intro { font-size: 14px; color: #64748b; margin-bottom: 16px; }
+    .charts-row { display: grid; grid-template-columns: 1fr 1fr; gap: 24px; margin: 24px 0; }
+    .chart-card { background: white; border: 1px solid #e2e8f0; border-radius: 8px; padding: 16px; }
+    .chart-title { font-size: 12px; font-weight: 600; color: #64748b; text-transform: uppercase; margin-bottom: 12px; }
+    .bar-row { display: flex; align-items: center; margin-bottom: 6px; }
+    .bar-label { width: 116px; font-size: 11px; color: #475569; flex-shrink: 0; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; }
+    .bar-track { flex: 1; height: 6px; background: #f1f5f9; border-radius: 3px; margin: 0 8px; }
+    .bar-fill { height: 100%; border-radius: 3px; }
+    .bar-value { width: 28px; font-size: 11px; font-weight: 500; color: #64748b; text-align: right; }
+    .bugs { display: flex; flex-direction: column; gap: 16px; margin-bottom: 24px; }
+    .bug-card { border-radius: 8px; padding: 16px; }
+    .bug-card.crit { background: #fef2f2; border: 1px solid #fca5a5; }
+    .bug-card.minor { background: #fffbeb; border: 1px solid #fcd34d; }
+    .bug-head { display: flex; align-items: flex-start; gap: 10px; flex-wrap: wrap; }
+    .bug-num { font-size: 13px; font-weight: 700; color: #94a3b8; min-width: 28px; }
+    .bug-title { flex: 1 1 300px; font-weight: 600; font-size: 15px; }
+    .bug-card.crit .bug-title { color: #991b1b; }
+    .bug-card.minor .bug-title { color: #92400e; }
+    .badges { display: flex; gap: 6px; flex-wrap: wrap; }
+    .badge { font-size: 10px; font-weight: 700; text-transform: uppercase; letter-spacing: .5px; padding: 3px 8px; border-radius: 20px; white-space: nowrap; }
+    .b-p0 { background: #fee2e2; color: #991b1b; }
+    .b-p1 { background: #fee2e2; color: #991b1b; }
+    .b-p2 { background: #fef3c7; color: #92400e; }
+    .b-fixed { background: #dcfce7; color: #166534; }
+    .bug-impact { font-size: 13px; color: #7f1d1d; margin-top: 10px; line-height: 1.55; }
+    .bug-card.minor .bug-impact { color: #78350f; }
+    .bug-fix { background: #f0fdf4; border: 1px solid #bbf7d0; border-radius: 6px; padding: 10px 12px; margin-top: 10px; font-size: 13px; color: #166534; line-height: 1.5; }
+    .bug-fix b { color: #15803d; }
+    .bug-meta { font-size: 11px; color: #94a3b8; margin-top: 10px; }
+    .bug-meta code { background: #f1f5f9; padding: 1px 6px; border-radius: 4px; font-family: monospace; color: #475569; }
+    .horizon-card { background: linear-gradient(135deg, #faf5ff 0%, #f5f3ff 100%); border: 1px solid #c4b5fd; border-radius: 8px; padding: 16px; }
+    .horizon-title { font-weight: 600; font-size: 15px; color: #5b21b6; margin-bottom: 8px; }
+    .horizon-possible { font-size: 14px; color: #334155; margin-bottom: 10px; line-height: 1.5; }
+    .horizon-tip { font-size: 13px; color: #6b21a8; background: rgba(255,255,255,0.6); padding: 8px 12px; border-radius: 4px; }
+    footer { margin-top: 40px; padding-top: 18px; border-top: 1px solid #e2e8f0; color: #94a3b8; font-size: 12px; }
+    footer code { background: #f1f5f9; padding: 1px 6px; border-radius: 4px; font-family: monospace; color: #475569; }
+    @media (max-width: 640px) { .charts-row { grid-template-columns: 1fr; } .stats-row { justify-content: center; } }
+</style>"""

package/skills/autoconverge/workflow/converge.contract.test.mjs CHANGED Viewed

@@ -134,7 +134,9 @@ function finalizeRepairBranch() {
   assert.notEqual(repairCallIndex, -1, 'expected the FINALIZE repair call to exist');
   const transitionIndex = convergeSource.indexOf("phase = 'CONVERGE'", repairCallIndex);
   assert.notEqual(transitionIndex, -1, 'expected a CONVERGE transition after the repair call');
-  const branchEnd = convergeSource.indexOf('continue', transitionIndex) + 'continue'.length;
+  const continueIndex = convergeSource.indexOf('continue', transitionIndex);
+  assert.notEqual(continueIndex, -1, 'expected a continue statement to close the FINALIZE repair branch');
+  const branchEnd = continueIndex + 'continue'.length;
   return convergeSource.slice(repairCallIndex, branchEnd);
 }
@@ -146,6 +148,33 @@ test('the FINALIZE repair branch does not re-assign head from the repair before
   );
 });
+function fixBranchAfter(branchLabel) {
+  const labelIndex = convergeSource.indexOf(branchLabel);
+  assert.notEqual(labelIndex, -1, `expected the ${branchLabel} marker to exist`);
+  const applyFixesIndex = convergeSource.indexOf('await applyFixes(', labelIndex);
+  assert.notEqual(applyFixesIndex, -1, `expected an applyFixes call after ${branchLabel}`);
+  const continueIndex = convergeSource.indexOf('continue', applyFixesIndex);
+  assert.notEqual(continueIndex, -1, `expected a continue statement to close the ${branchLabel} branch`);
+  const branchEnd = continueIndex + 'continue'.length;
+  return convergeSource.slice(applyFixesIndex, branchEnd);
+}
+test('the CONVERGE fix branch does not re-assign head from the fix before re-converging', () => {
+  assert.doesNotMatch(
+    fixBranchAfter('${findings.length} finding(s) — applying fixes'),
+    /head\s*=\s*fixProgress/,
+    'the next CONVERGE pass re-resolves HEAD from GitHub, so assigning the fix SHA here is dead',
+  );
+});
+test('the COPILOT fix branch does not re-assign head from the fix before re-converging', () => {
+  assert.doesNotMatch(
+    fixBranchAfter('${copilotOutcome.findings.length} finding(s) — fixing and re-converging'),
+    /head\s*=\s*fixProgress/,
+    'the CONVERGE pass it transitions to re-resolves HEAD from GitHub, so assigning the fix SHA here is dead',
+  );
+});
 test('the CONVERGE branch re-resolves HEAD from GitHub on every entry', () => {
   const convergeBranchStart = convergeSource.indexOf("if (phase === 'CONVERGE')");
   assert.notEqual(convergeBranchStart, -1, 'expected the CONVERGE branch to exist');

package/skills/autoconverge/workflow/converge.copilot-gate.test.mjs ADDED Viewed

@@ -0,0 +1,265 @@
+import { test } from 'node:test';
+import { strict as assert } from 'node:assert';
+import { readFileSync } from 'node:fs';
+import { fileURLToPath } from 'node:url';
+import { dirname, join } from 'node:path';
+const workflowDirectory = dirname(fileURLToPath(import.meta.url));
+const convergeSource = readFileSync(join(workflowDirectory, 'converge.mjs'), 'utf8');
+function functionBody(functionName) {
+  const functionStart = convergeSource.indexOf(`function ${functionName}(`);
+  assert.notEqual(functionStart, -1, `expected ${functionName} to exist`);
+  const nextFunctionStart = convergeSource.indexOf('\nfunction ', functionStart + 1);
+  const functionEnd = nextFunctionStart === -1 ? convergeSource.length : nextFunctionStart;
+  return convergeSource.slice(functionStart, functionEnd);
+}
+const productionModule = new Function(
+  `${functionBody('classifyCopilotOutcome')}\n` +
+    `${functionBody('resolveCopilotDown')}\n` +
+    'return { classifyCopilotOutcome, resolveCopilotDown };',
+)();
+const { classifyCopilotOutcome, resolveCopilotDown } = productionModule;
+function copilotResult(overrides) {
+  return {
+    sha: 'abcdef0',
+    clean: false,
+    down: false,
+    findings: [],
+    ...overrides,
+  };
+}
+test('an out-of-usage Copilot result (down) routes to the down kind', () => {
+  const outcome = classifyCopilotOutcome(copilotResult({ clean: true, down: true }));
+  assert.equal(outcome.kind, 'down');
+});
+test('a down Copilot result routes to down even when clean is false', () => {
+  const outcome = classifyCopilotOutcome(copilotResult({ clean: false, down: true }));
+  assert.equal(outcome.kind, 'down');
+});
+test('a dead Copilot gate agent retries rather than passing', () => {
+  assert.equal(classifyCopilotOutcome(null).kind, 'retry');
+});
+test('a reachable Copilot gate with no findings and no clean verdict retries', () => {
+  const outcome = classifyCopilotOutcome(copilotResult({ clean: false, down: false }));
+  assert.equal(outcome.kind, 'retry');
+});
+test('Copilot findings route to a fix when Copilot is reachable and not down', () => {
+  const outcome = classifyCopilotOutcome(
+    copilotResult({
+      findings: [
+        {
+          file: 'a.py',
+          line: 1,
+          severity: 'P1',
+          category: 'bug',
+          title: 't',
+          detail: 'd',
+          replyToCommentId: null,
+        },
+      ],
+    }),
+  );
+  assert.equal(outcome.kind, 'fix');
+});
+test('COPILOT_SCHEMA carries a required down field', () => {
+  const schemaStart = convergeSource.indexOf('const COPILOT_SCHEMA =');
+  const schemaEnd = convergeSource.indexOf('const HEAD_SCHEMA =');
+  assert.notEqual(schemaStart, -1, 'expected COPILOT_SCHEMA to exist');
+  const schemaSource = convergeSource.slice(schemaStart, schemaEnd);
+  assert.match(schemaSource, /down:\s*\{\s*type:\s*'boolean'/);
+  assert.match(schemaSource, /required:\s*\[[^\]]*'down'[^\]]*\]/);
+  assert.doesNotMatch(
+    schemaSource,
+    /blocker:/,
+    'the Copilot gate no longer surfaces a blocker; a down result carries the outage',
+  );
+});
+test('the Copilot gate prompt detects an out-of-usage notice and returns a down result', () => {
+  const copilotPrompt = functionBody('runCopilotGate');
+  assert.match(
+    copilotPrompt,
+    /quota|out of usage|out-of-usage/i,
+    'expected the gate to name the out-of-usage / quota signal',
+  );
+  assert.match(
+    copilotPrompt,
+    /down:\s*true/,
+    'expected the gate to return down:true on an out-of-usage notice',
+  );
+});
+test('the step-1 out-of-usage down-detection requires the notice commit_id to start with HEAD', () => {
+  const copilotPrompt = functionBody('runCopilotGate');
+  const stepOneStart = copilotPrompt.indexOf('`1.');
+  assert.notEqual(stepOneStart, -1, 'expected a step-1 instruction in the gate prompt');
+  const stepTwoStart = copilotPrompt.indexOf('`2.', stepOneStart);
+  assert.notEqual(stepTwoStart, -1, 'expected a step-2 instruction in the gate prompt');
+  const stepOneText = copilotPrompt.slice(stepOneStart, stepTwoStart);
+  assert.match(
+    stepOneText,
+    /commit_id starts with \$\{head\}/,
+    'expected step 1 to scope the out-of-usage notice to reviews whose commit_id starts with HEAD, matching step 2 and the convergence gate',
+  );
+});
+test('a Copilot no-show after the poll cap returns a down result rather than a blocker', () => {
+  const copilotPrompt = functionBody('runCopilotGate');
+  const noReviewStart = copilotPrompt.indexOf('No review after');
+  assert.notEqual(noReviewStart, -1, 'expected a no-show branch in the gate prompt');
+  const noReviewBranch = copilotPrompt.slice(noReviewStart, noReviewStart + 200);
+  assert.match(
+    noReviewBranch,
+    /down:\s*true/,
+    'expected a Copilot no-show after the poll cap to return down:true',
+  );
+  assert.doesNotMatch(
+    noReviewBranch,
+    /blocker:/,
+    'expected the no-show branch to carry a down result, not a blocker',
+  );
+});
+test('checkConvergence wires the --copilot-down flag from a copilotDown argument', () => {
+  const checkConvergenceBody = functionBody('checkConvergence');
+  assert.match(
+    checkConvergenceBody,
+    /copilotDown \? ' --copilot-down' : ''/,
+    'expected checkConvergence to append --copilot-down when copilotDown is set',
+  );
+  assert.match(
+    checkConvergenceBody,
+    /\$\{copilotDownFlag\}/,
+    'expected the --copilot-down flag to be interpolated into the script invocation',
+  );
+});
+test('the COPILOT phase routes a down outcome to FINALIZE with the gate bypassed', () => {
+  const copilotPhaseStart = convergeSource.indexOf("if (phase === 'COPILOT') {");
+  assert.notEqual(copilotPhaseStart, -1, 'expected a COPILOT phase block');
+  const downBranchStart = convergeSource.indexOf("copilotOutcome.kind === 'down'", copilotPhaseStart);
+  assert.notEqual(downBranchStart, -1, 'expected the COPILOT phase to handle a down outcome');
+  const downBranch = convergeSource.slice(downBranchStart, downBranchStart + 400);
+  assert.match(downBranch, /copilotDown = true/);
+  assert.match(downBranch, /copilotNote =/);
+  assert.match(downBranch, /phase = 'FINALIZE'/);
+});
+test('resolveCopilotDown reports down only for a down outcome', () => {
+  assert.equal(resolveCopilotDown({ kind: 'down' }), true);
+});
+test('resolveCopilotDown clears the bypass for an approved outcome', () => {
+  assert.equal(resolveCopilotDown({ kind: 'approved' }), false);
+});
+test('resolveCopilotDown clears the bypass for a fix outcome carrying findings', () => {
+  assert.equal(
+    resolveCopilotDown({
+      kind: 'fix',
+      findings: [
+        {
+          file: 'a.py',
+          line: 1,
+          severity: 'P1',
+          category: 'bug',
+          title: 't',
+          detail: 'd',
+          replyToCommentId: null,
+        },
+      ],
+    }),
+    false,
+  );
+});
+test('resolveCopilotDown clears the bypass for a retry outcome', () => {
+  assert.equal(resolveCopilotDown({ kind: 'retry' }), false);
+});
+test('the standards-only Copilot sub-path resets copilotDown before FINALIZE', () => {
+  const standardsBranchStart = convergeSource.indexOf(
+    'isStandardsOnlyRound(copilotOutcome.findings)',
+  );
+  assert.notEqual(
+    standardsBranchStart,
+    -1,
+    'expected the COPILOT phase to handle a standards-only Copilot fix outcome',
+  );
+  const standardsBranch = convergeSource.slice(standardsBranchStart, standardsBranchStart + 600);
+  const resetIndex = standardsBranch.indexOf('copilotDown = false');
+  const finalizeIndex = standardsBranch.indexOf("phase = 'FINALIZE'");
+  assert.notEqual(
+    resetIndex,
+    -1,
+    'expected the standards-only sub-path to reset copilotDown so a recovered Copilot is not bypassed',
+  );
+  assert.notEqual(finalizeIndex, -1, 'expected the standards-only sub-path to reach FINALIZE');
+  assert.ok(
+    resetIndex < finalizeIndex,
+    'expected copilotDown to be cleared before the transition to FINALIZE',
+  );
+  assert.match(
+    standardsBranch.slice(0, finalizeIndex),
+    /copilotNote = null/,
+    'expected the standards-only sub-path to clear the stale copilotNote alongside copilotDown',
+  );
+});
+test('the COPILOT phase recomputes copilotDown from each gate outcome via resolveCopilotDown', () => {
+  const copilotPhaseStart = convergeSource.indexOf("if (phase === 'COPILOT') {");
+  assert.notEqual(copilotPhaseStart, -1, 'expected a COPILOT phase block');
+  const finalizePhaseStart = convergeSource.indexOf(
+    "if (phase === 'FINALIZE') {",
+    copilotPhaseStart,
+  );
+  assert.notEqual(finalizePhaseStart, -1, 'expected a FINALIZE phase block after COPILOT');
+  const copilotPhase = convergeSource.slice(copilotPhaseStart, finalizePhaseStart);
+  assert.match(
+    copilotPhase,
+    /copilotDown = resolveCopilotDown\(copilotOutcome\)/,
+    'expected the COPILOT phase to recompute copilotDown from the current outcome so a recovered Copilot is never bypassed',
+  );
+});
+test('markReady receives copilotDown so it can opt the unflagged hook out of the Copilot gate', () => {
+  const finalizeStart = convergeSource.indexOf("if (phase === 'FINALIZE') {");
+  assert.notEqual(finalizeStart, -1, 'expected a FINALIZE phase block');
+  const markReadyCall = convergeSource.indexOf('await markReady(', finalizeStart);
+  assert.notEqual(markReadyCall, -1, 'expected the FINALIZE phase to call markReady');
+  const callSlice = convergeSource.slice(markReadyCall, markReadyCall + 40);
+  assert.match(
+    callSlice,
+    /markReady\(head,\s*copilotDown\)/,
+    'expected markReady to receive copilotDown so the mark-ready agent can opt the unflagged hook out of the Copilot gate',
+  );
+});
+test('the markReady prompt opts the unflagged convergence hook out of Copilot when copilotDown', () => {
+  const markReadyBody = functionBody('markReady');
+  assert.match(
+    markReadyBody,
+    /copilotDown/,
+    'expected markReady to branch on copilotDown',
+  );
+  assert.match(
+    markReadyBody,
+    /CLAUDE_REVIEWS_DISABLED/,
+    'expected the markReady prompt to set CLAUDE_REVIEWS_DISABLED so the unflagged hook re-derives the Copilot bypass',
+  );
+  assert.match(
+    markReadyBody,
+    /copilot/,
+    'expected the markReady opt-out to name the copilot token',
+  );
+});