claude-dev-env 1.57.1 → 1.58.0

package/skills/autoconverge/reference/closing-report.md

@@ -0,0 +1,44 @@
+# Closing Report
+
+When an autoconverge run converges (the workflow returns `converged: true`), the main session generates a convergence insights HTML report and publishes it as a secret gist with an idempotent PR comment linking to it.
+
+## Data source
+
+The report reads two file types written by the workflow during the run:
+
+- **Run journal** — `~/.claude/projects/**/workflows/wf_<runId>.json` — the PR args, round log lines, `workflowProgress` array (one entry per agent step), and the final result.
+- **Agent transcripts** — `~/.claude/projects/**/subagents/workflows/<runId>/agent-<agentId>.jsonl` — one file per agent; each line is a JSON object; the renderer extracts the last `StructuredOutput` tool_use from each file.
+
+`converge.mjs` is not modified. The report is a pure reader of files the workflow already writes.
+
+## Building the report
+
+```
+python "<skill>/workflow/render_report.py" \
+  --journal "<journal path>" \
+  --out "<output path>.html" \
+  --pr <owner>/<repo>#<n> \
+  --final-sha <sha> \
+  --rounds <N> \
+  --repo <worktree path>
+```
+
+The script reads the journal and transcripts, computes aggregated metrics (findings by severity, round, and theme; fix commits; tests added per round), and writes a self-contained HTML report. It prints the output path to stdout and exits 0 on success.
+
+All aggregation is deterministic: `generated_date` comes from the journal `timestamp`, not the system clock, so the same inputs always produce the same HTML.
+
+## Publishing
+
+After rendering, the main session:
+
+1. **Uploads the HTML as a secret gist** using `doc-gist/scripts/gist_upload.py --no-open`. Captures the htmlpreview URL from stdout.
+2. **Posts one idempotent PR comment** marked with `<!-- autoconverge-report -->`. If a comment with that marker already exists on the PR, it is edited in place; otherwise a new comment is created. The comment body has the gist URL and a summary of findings by severity, rounds, and tests added, followed by the full finding list grouped by severity (`file:line — P# — title`). Write the body to a BOM-free temp file and pass `--body-file` to `gh issue comment` (never `--body`), or use the GitHub MCP `add_issue_comment` tool.
+3. **Opens the report** with `Start-Process chrome -ArgumentList '--new-window', '<report path>'`. A missing Chrome does not abort teardown.
+
+## Live-dashboard seam
+
+The marker comment and gist together form a seam for future per-round dashboard refreshes: a live-dashboard step re-renders with the same `render_report_html` function (pure, no side effects), runs `gh gist edit` on the same gist, and edits the same marker comment. That per-round refresh path is out of scope here; this document describes the one-shot closing report only.
+
+## Scope
+
+The closing report runs only when `converged === true`. On a blocker exit (`blocker: "budget"` or similar), the report, gist, comment, and Chrome open are all skipped.

package/skills/autoconverge/workflow/autoconverge_report_constants/render_report_constants.py

@@ -0,0 +1,105 @@
+"""Named constants for render_report.py."""
+
+STRUCTURED_OUTPUT_TOOL_NAME = "StructuredOutput"
+
+LABEL_RESOLVE_HEAD = "resolve-head"
+LABEL_PREFIX_LENS = "lens:"
+LABEL_PREFIX_FIX = "fix:"
+LABEL_COPILOT_GATE = "copilot-gate"
+
+JOURNAL_SIBLING_SUBAGENTS = "subagents"
+JOURNAL_SIBLING_WORKFLOWS = "workflows"
+
+THEME_PATH_SEGMENT_COUNT = 2
+THEME_FALLBACK = "other"
+
+SEVERITY_CRITICAL_BUCKET = "Critical"
+SEVERITY_MINOR_BUCKET = "Minor"
+SEVERITY_CRITICAL_LEVELS = frozenset({"P0", "P1"})
+SEVERITY_BADGE_CLASS_BY_LEVEL = {
+    "P0": "b-p0",
+    "P1": "b-p1",
+    "P2": "b-p2",
+}
+
+BAR_COLOR_SEVERITY_CRITICAL = "#dc2626"
+BAR_COLOR_SEVERITY_MINOR = "#eab308"
+BAR_COLOR_ROUND = "#2563eb"
+BAR_COLOR_TESTS = "#10b981"
+BAR_COLOR_THEME = "#8b5cf6"
+
+TEST_DEFINITION_PATTERN = r"^\+\s*(async\s+)?def\s+(test|should)"
+TEST_PATH_GLOBS = ("*test*.py", "**/*test*.py")
+
+BAR_FILL_MAX_PERCENT = 100
+
+GITHUB_PR_URL_TEMPLATE = "https://github.com/{owner}/{repo}/pull/{number}"
+
+HTML_DOCTYPE = "<!DOCTYPE html>"
+
+HTML_HEAD_TEMPLATE = """\
+<head>
+    <meta charset="utf-8">
+    <title>PR #{pr_number} Convergence Insights</title>
+    <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700&display=swap" rel="stylesheet">
+    {style_block}
+</head>"""
+
+HTML_STYLE_BLOCK = """\
+<style>
+    * { box-sizing: border-box; margin: 0; padding: 0; }
+    body { font-family: 'Inter', -apple-system, BlinkMacSystemFont, sans-serif; background: #f8fafc; color: #334155; line-height: 1.65; padding: 48px 24px; }
+    .container { max-width: 800px; margin: 0 auto; }
+    h1 { font-size: 32px; font-weight: 700; color: #0f172a; margin-bottom: 8px; }
+    h2 { font-size: 20px; font-weight: 600; color: #0f172a; margin-top: 48px; margin-bottom: 16px; }
+    .subtitle { color: #64748b; font-size: 15px; margin-bottom: 32px; }
+    .nav-toc { display: flex; flex-wrap: wrap; gap: 8px; margin: 24px 0 32px 0; padding: 16px; background: white; border-radius: 8px; border: 1px solid #e2e8f0; }
+    .nav-toc a { font-size: 12px; color: #64748b; text-decoration: none; padding: 6px 12px; border-radius: 6px; background: #f1f5f9; transition: all 0.15s; }
+    .nav-toc a:hover { background: #e2e8f0; color: #334155; }
+    .stats-row { display: flex; gap: 24px; margin-bottom: 40px; padding: 20px 0; border-top: 1px solid #e2e8f0; border-bottom: 1px solid #e2e8f0; flex-wrap: wrap; }
+    .stat { text-align: center; }
+    .stat-value { font-size: 24px; font-weight: 700; color: #0f172a; }
+    .stat-label { font-size: 11px; color: #64748b; text-transform: uppercase; }
+    .at-a-glance { background: linear-gradient(135deg, #fef3c7 0%, #fde68a 100%); border: 1px solid #f59e0b; border-radius: 12px; padding: 20px 24px; margin-bottom: 32px; }
+    .glance-title { font-size: 16px; font-weight: 700; color: #92400e; margin-bottom: 16px; }
+    .glance-sections { display: flex; flex-direction: column; gap: 12px; }
+    .glance-section { font-size: 14px; color: #78350f; line-height: 1.6; }
+    .glance-section strong { color: #92400e; }
+    .section-intro { font-size: 14px; color: #64748b; margin-bottom: 16px; }
+    .charts-row { display: grid; grid-template-columns: 1fr 1fr; gap: 24px; margin: 24px 0; }
+    .chart-card { background: white; border: 1px solid #e2e8f0; border-radius: 8px; padding: 16px; }
+    .chart-title { font-size: 12px; font-weight: 600; color: #64748b; text-transform: uppercase; margin-bottom: 12px; }
+    .bar-row { display: flex; align-items: center; margin-bottom: 6px; }
+    .bar-label { width: 116px; font-size: 11px; color: #475569; flex-shrink: 0; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; }
+    .bar-track { flex: 1; height: 6px; background: #f1f5f9; border-radius: 3px; margin: 0 8px; }
+    .bar-fill { height: 100%; border-radius: 3px; }
+    .bar-value { width: 28px; font-size: 11px; font-weight: 500; color: #64748b; text-align: right; }
+    .bugs { display: flex; flex-direction: column; gap: 16px; margin-bottom: 24px; }
+    .bug-card { border-radius: 8px; padding: 16px; }
+    .bug-card.crit { background: #fef2f2; border: 1px solid #fca5a5; }
+    .bug-card.minor { background: #fffbeb; border: 1px solid #fcd34d; }
+    .bug-head { display: flex; align-items: flex-start; gap: 10px; flex-wrap: wrap; }
+    .bug-num { font-size: 13px; font-weight: 700; color: #94a3b8; min-width: 28px; }
+    .bug-title { flex: 1 1 300px; font-weight: 600; font-size: 15px; }
+    .bug-card.crit .bug-title { color: #991b1b; }
+    .bug-card.minor .bug-title { color: #92400e; }
+    .badges { display: flex; gap: 6px; flex-wrap: wrap; }
+    .badge { font-size: 10px; font-weight: 700; text-transform: uppercase; letter-spacing: .5px; padding: 3px 8px; border-radius: 20px; white-space: nowrap; }
+    .b-p0 { background: #fee2e2; color: #991b1b; }
+    .b-p1 { background: #fee2e2; color: #991b1b; }
+    .b-p2 { background: #fef3c7; color: #92400e; }
+    .b-fixed { background: #dcfce7; color: #166534; }
+    .bug-impact { font-size: 13px; color: #7f1d1d; margin-top: 10px; line-height: 1.55; }
+    .bug-card.minor .bug-impact { color: #78350f; }
+    .bug-fix { background: #f0fdf4; border: 1px solid #bbf7d0; border-radius: 6px; padding: 10px 12px; margin-top: 10px; font-size: 13px; color: #166534; line-height: 1.5; }
+    .bug-fix b { color: #15803d; }
+    .bug-meta { font-size: 11px; color: #94a3b8; margin-top: 10px; }
+    .bug-meta code { background: #f1f5f9; padding: 1px 6px; border-radius: 4px; font-family: monospace; color: #475569; }
+    .horizon-card { background: linear-gradient(135deg, #faf5ff 0%, #f5f3ff 100%); border: 1px solid #c4b5fd; border-radius: 8px; padding: 16px; }
+    .horizon-title { font-weight: 600; font-size: 15px; color: #5b21b6; margin-bottom: 8px; }
+    .horizon-possible { font-size: 14px; color: #334155; margin-bottom: 10px; line-height: 1.5; }
+    .horizon-tip { font-size: 13px; color: #6b21a8; background: rgba(255,255,255,0.6); padding: 8px 12px; border-radius: 4px; }
+    footer { margin-top: 40px; padding-top: 18px; border-top: 1px solid #e2e8f0; color: #94a3b8; font-size: 12px; }
+    footer code { background: #f1f5f9; padding: 1px 6px; border-radius: 4px; font-family: monospace; color: #475569; }
+    @media (max-width: 640px) { .charts-row { grid-template-columns: 1fr; } .stats-row { justify-content: center; } }
+</style>"""

package/skills/autoconverge/workflow/converge.contract.test.mjs

@@ -134,7 +134,9 @@ function finalizeRepairBranch() {
   assert.notEqual(repairCallIndex, -1, 'expected the FINALIZE repair call to exist');
   const transitionIndex = convergeSource.indexOf("phase = 'CONVERGE'", repairCallIndex);
   assert.notEqual(transitionIndex, -1, 'expected a CONVERGE transition after the repair call');
-  const branchEnd = convergeSource.indexOf('continue', transitionIndex) + 'continue'.length;
+  const continueIndex = convergeSource.indexOf('continue', transitionIndex);
+  assert.notEqual(continueIndex, -1, 'expected a continue statement to close the FINALIZE repair branch');
+  const branchEnd = continueIndex + 'continue'.length;
   return convergeSource.slice(repairCallIndex, branchEnd);
 }
 
@@ -146,6 +148,33 @@ test('the FINALIZE repair branch does not re-assign head from the repair before
   );
 });
 
+function fixBranchAfter(branchLabel) {
+  const labelIndex = convergeSource.indexOf(branchLabel);
+  assert.notEqual(labelIndex, -1, `expected the ${branchLabel} marker to exist`);
+  const applyFixesIndex = convergeSource.indexOf('await applyFixes(', labelIndex);
+  assert.notEqual(applyFixesIndex, -1, `expected an applyFixes call after ${branchLabel}`);
+  const continueIndex = convergeSource.indexOf('continue', applyFixesIndex);
+  assert.notEqual(continueIndex, -1, `expected a continue statement to close the ${branchLabel} branch`);
+  const branchEnd = continueIndex + 'continue'.length;
+  return convergeSource.slice(applyFixesIndex, branchEnd);
+}
+
+test('the CONVERGE fix branch does not re-assign head from the fix before re-converging', () => {
+  assert.doesNotMatch(
+    fixBranchAfter('${findings.length} finding(s) — applying fixes'),
+    /head\s*=\s*fixProgress/,
+    'the next CONVERGE pass re-resolves HEAD from GitHub, so assigning the fix SHA here is dead',
+  );
+});
+
+test('the COPILOT fix branch does not re-assign head from the fix before re-converging', () => {
+  assert.doesNotMatch(
+    fixBranchAfter('${copilotOutcome.findings.length} finding(s) — fixing and re-converging'),
+    /head\s*=\s*fixProgress/,
+    'the CONVERGE pass it transitions to re-resolves HEAD from GitHub, so assigning the fix SHA here is dead',
+  );
+});
+
 test('the CONVERGE branch re-resolves HEAD from GitHub on every entry', () => {
   const convergeBranchStart = convergeSource.indexOf("if (phase === 'CONVERGE')");
   assert.notEqual(convergeBranchStart, -1, 'expected the CONVERGE branch to exist');

package/skills/autoconverge/workflow/converge.mjs

@@ -416,7 +416,7 @@ async function resolveHead() {
     `Print the current HEAD SHA of ${prCoordinates}. Run exactly:\n` +
       `gh api repos/${input.owner}/${input.repo}/pulls/${input.prNumber} --jq .head.sha\n` +
       `Return the full 40-character SHA in the sha field. Do not modify any files.`,
-    { model: 'fable', label: 'resolve-head', phase: 'Converge', schema: HEAD_SCHEMA, agentType: 'Explore' },
+    { label: 'resolve-head', phase: 'Converge', schema: HEAD_SCHEMA, agentType: 'Explore' },
   )
   return head?.sha
 }
@@ -434,7 +434,7 @@ function prefetchMainForRound() {
     `Refresh the base ref for ${prCoordinates} so the parallel review lenses can diff against an up-to-date origin/main without each running its own fetch. Run exactly:\n` +
       `git fetch origin main\n` +
       `Do not edit, commit, push, rebase, or modify any files — fetch only.`,
-    { model: 'fable', label: 'prefetch-main', phase: 'Converge', agentType: 'Explore' },
+    { label: 'prefetch-main', phase: 'Converge', agentType: 'Explore' },
   )
 }
 
@@ -463,7 +463,7 @@ function runBugbotLens(head) {
       `4. No review yet on HEAD: check_bugbot_ci.py --check-active. If active (exit 0), poll: repeat check_bugbot_ci.py --check-clean / --check-active every 60 seconds (delay each iteration with "sleep 60", or the PowerShell alternative "Start-Sleep -Seconds 60") for up to 25 iterations, then re-fetch the review. If not active (exit 1), post the literal comment "bugbot run" (no @mention, no other text) via python "${CONFIG.sharedScripts}/post_fix_reply.py" --owner ${input.owner} --repo ${input.repo} --pr-number ${input.prNumber} --body "bugbot run", delay 8 seconds with "sleep 8" (PowerShell alternative "Start-Sleep -Seconds 8"), then poll as above.\n` +
       `5. If after the full poll budget Bugbot has neither a check run nor a review on HEAD -> return {sha:${'`'}${head}${'`'}, clean:true, down:true, findings:[]} (treat as down).\n\n` +
       `Scope is the whole PR; you are only reading Bugbot's own output here. For each finding set category: 'code-standard' when it is a pure CODE_RULES/style violation (naming, comments, type hints, magic values, structure) with no behavioral impact; 'bug' otherwise. Return strictly the schema.`,
-    { model: 'fable', label: 'lens:bugbot', phase: 'Converge', schema: LENS_SCHEMA },
+    { label: 'lens:bugbot', phase: 'Converge', schema: LENS_SCHEMA },
   )
 }
 
@@ -479,7 +479,7 @@ function runCodeReviewLens(head) {
       `Review the FULL origin/main...HEAD diff — every file the PR touches. Do NOT delta-scope to recent commits or to a single file. The workflow already fetched origin/main this round, so do NOT run git fetch; run git diff --name-only origin/main...HEAD to enumerate the changed files, then review the complete diff of each.\n\n` +
       `Apply correctness-focused review: real bugs, broken logic, incorrect error handling, data-loss or security risks, contract mismatches, and reuse/simplification problems. Report only defensible findings with concrete file:line evidence.\n\n` +
       `Do NOT edit, commit, or push — reporting only. Return strictly the schema: clean=true with empty findings when the diff is sound, otherwise one entry per finding (severity P0/P1/P2; category 'code-standard' for pure CODE_RULES/style violations with no behavioral impact, 'bug' otherwise; replyToCommentId=null since these are not yet GitHub threads). Set sha=${'`'}${head}${'`'}, down=false.`,
-    { model: 'fable', label: 'lens:code-review', phase: 'Converge', schema: LENS_SCHEMA, agentType: 'code-quality-agent' },
+    { label: 'lens:code-review', phase: 'Converge', schema: LENS_SCHEMA, agentType: 'code-quality-agent' },
   )
 }
 
@@ -495,7 +495,7 @@ function runAuditLens(head) {
       `Read the audit rubric at ${CONFIG.bugteamRubric} and apply its categories (A through P) against the FULL origin/main...HEAD diff — every file the PR touches, never a delta cut. The workflow already fetched origin/main this round, so do NOT run git fetch; run git diff --name-only origin/main...HEAD first to enumerate scope.\n\n` +
       `This is a clean-room audit: assume nothing from other lenses. Report only findings backed by concrete file:line evidence. Do NOT edit, commit, or push.\n\n` +
       `Return strictly the schema: clean=true with empty findings when the diff passes every category, otherwise one entry per finding (severity P0/P1/P2; category 'code-standard' for pure CODE_RULES/style violations with no behavioral impact, 'bug' otherwise; replyToCommentId=null). Set sha=${'`'}${head}${'`'}, down=false.`,
-    { model: 'fable', label: 'lens:bug-audit', phase: 'Converge', schema: LENS_SCHEMA, agentType: 'code-quality-agent' },
+    { label: 'lens:bug-audit', phase: 'Converge', schema: LENS_SCHEMA, agentType: 'code-quality-agent' },
   )
 }
 
@@ -533,7 +533,7 @@ function applyFixes(head, findings, sourceLabel) {
       `- When you commit and push a fix: newSha=the new HEAD SHA after your push, pushed=true, resolvedWithoutCommit=false.\n` +
       `- When every finding was already addressed so no code change is needed — yet you still resolved each GitHub review thread above: newSha=${head} (the unchanged HEAD), pushed=false, resolvedWithoutCommit=true. Only set this when every thread that carries a comment id is resolved; otherwise the round is treated as stalled.\n` +
       `Always include a one-line summary.`,
-    { model: 'fable', label: `fix:${sourceLabel}`, phase: 'Converge', schema: FIX_SCHEMA, agentType: 'clean-coder' },
+    { label: `fix:${sourceLabel}`, phase: 'Converge', schema: FIX_SCHEMA, agentType: 'clean-coder' },
   )
 }
 
@@ -549,7 +549,7 @@ function postCleanAudit(head) {
       `Write an empty findings file: create a temp file containing exactly [] (an empty JSON array). Then run:\n` +
       `python "${CONFIG.prLoopScripts}/post_audit_thread.py" --skill bugteam --owner ${input.owner} --repo ${input.repo} --pr-number ${input.prNumber} --commit ${head} --state CLEAN --findings-json <temp-file>\n` +
       `Run the script with --help first if any flag name differs. This posts the APPROVE review body that check_convergence.py reads for the bugteam gate. Do not edit code, commit, or push.`,
-    { model: 'fable', label: 'post-clean-audit', phase: 'Converge', agentType: 'general-purpose' },
+    { label: 'post-clean-audit', phase: 'Converge', agentType: 'general-purpose' },
   )
 }
 
@@ -569,7 +569,7 @@ function runCopilotGate(head) {
       `   - Copilot findings on HEAD -> return them (each with its inline comment id in replyToCommentId; category 'code-standard' for pure CODE_RULES/style violations with no behavioral impact, 'bug' otherwise), clean:false, blocker:null.\n` +
       `   - No review after ${CONFIG.copilotMaxPolls} attempts -> return {sha:${'`'}${head}${'`'}, clean:false, findings:[], blocker:"Copilot did not surface a review on HEAD after ${CONFIG.copilotMaxPolls} polls"}.\n\n` +
       `Return strictly the schema.`,
-    { model: 'fable', label: 'copilot-gate', phase: 'Copilot gate', schema: COPILOT_SCHEMA },
+    { label: 'copilot-gate', phase: 'Copilot gate', schema: COPILOT_SCHEMA },
   )
 }
 
@@ -586,7 +586,7 @@ function checkConvergence(bugbotDown) {
       `Exit 0 -> every gate passed: return {pass:true, failures:[]}.\n` +
       `Exit 1 -> return {pass:false, failures:[<each printed FAIL line verbatim>]}.\n` +
       `Exit 2 -> retry once; if it still errors, return {pass:false, failures:["check_convergence gh error"]}.`,
-    { model: 'fable', label: 'check-convergence', phase: 'Finalize', schema: CONVERGENCE_SCHEMA, agentType: 'Explore' },
+    { label: 'check-convergence', phase: 'Finalize', schema: CONVERGENCE_SCHEMA, agentType: 'Explore' },
   )
 }
 
@@ -601,7 +601,7 @@ function markReady(head) {
       `1. Run: gh pr ready ${input.prNumber} --repo ${input.owner}/${input.repo}\n` +
       `2. Re-query the draft state: gh api repos/${input.owner}/${input.repo}/pulls/${input.prNumber} --jq .draft\n` +
       `Return {ready:true} only when step 2 prints false (the PR is no longer a draft). If step 1 errors or step 2 still prints true, return {ready:false}.`,
-    { model: 'fable', label: 'mark-ready', phase: 'Finalize', schema: READY_SCHEMA, agentType: 'general-purpose' },
+    { label: 'mark-ready', phase: 'Finalize', schema: READY_SCHEMA, agentType: 'general-purpose' },
   )
 }
 
@@ -624,7 +624,7 @@ function repairConvergence(head, failures) {
       `- PR not mergeable: rebase onto origin/main and force-push (git fetch origin main; git rebase origin/main; resolve conflicts; git push --force-with-lease).\n` +
       `- A dirty bot review or a still-pending requested reviewer: leave it; the next round re-runs that reviewer.\n` +
       `Make at most one commit for any code fix. Return the HEAD SHA after any push in newSha (the unchanged ${head} when nothing was pushed), pushed true/false, resolvedWithoutCommit=false (this gate already accepts an unchanged HEAD), and a one-line summary.`,
-    { model: 'fable', label: 'repair-convergence', phase: 'Finalize', schema: FIX_SCHEMA, agentType: 'clean-coder' },
+    { label: 'repair-convergence', phase: 'Finalize', schema: FIX_SCHEMA, agentType: 'clean-coder' },
   )
 }
 
@@ -668,7 +668,7 @@ function spawnStandardsFollowUp(head, findings, sourceLabel) {
       `2. Environment-hardening PR: in the Claude environment config repo (the repo owning ~/.claude hooks and rules — JonEcho/llm-settings for hooks, jl-cmd/claude-code-config for rules/skills; pick whichever owns the needed surface), create a branch and open a DRAFT PR that hardens hooks/rules so each violation class found here is blocked at Write/Edit time, before code is written or reviewed. Reference the issue from step 1 in the PR body.\n` +
       `3. For each finding that carries a GitHub review comment id: post an inline reply via python "${CONFIG.sharedScripts}/post_fix_reply.py" --owner ${input.owner} --repo ${input.repo} --pr-number ${input.prNumber} --in-reply-to <id> --body "Code-standard-only finding — deferred to follow-up issue <url>." Then resolve the thread by its PRRT_ node id (GraphQL lookup on comment databaseId, then resolveReviewThread or the github MCP pull_request_review_write method=resolve_thread).\n\n` +
       `Return a one-line summary naming the follow-up issue URL and the hardening PR URL.`,
-    { model: 'fable', label: `standards-followup:${sourceLabel}`, phase: 'Converge', agentType: 'clean-coder' },
+    { label: `standards-followup:${sourceLabel}`, phase: 'Converge', agentType: 'clean-coder' },
   )
 }
 
@@ -722,7 +722,6 @@ while (iterations < CONFIG.maxIterations) {
           : `fix lens landed no push for ${findings.length} finding(s) on HEAD ${head}`
         break
       }
-      head = fixProgress.newSha
       continue
     }
     if (!roundOutcome.roundClean) {
@@ -764,7 +763,6 @@ while (iterations < CONFIG.maxIterations) {
           : `copilot fix lens landed no push for ${copilotOutcome.findings.length} finding(s) on HEAD ${head}`
         break
       }
-      head = fixProgress.newSha
       phase = 'CONVERGE'
       continue
     }

package/skills/autoconverge/workflow/fixtures/wf_run/subagents/workflows/wf_881252e6-700/agent-a11d903476b803493.jsonl

@@ -0,0 +1,2 @@
+{"type": "user", "uuid": "a11d903476b803493-u", "message": {"role": "user", "content": "Return the structured result."}}
+{"type": "assistant", "uuid": "a11d903476b803493-a", "message": {"role": "assistant", "content": [{"type": "tool_use", "id": "toolu_a11d903476b803493", "name": "StructuredOutput", "input": {"sha": "7c2f420c4d5b7c83aa47f93d99a0f1420e3373c4", "clean": false, "findings": [{"file": "src/exports/core/export_runner.py", "line": 96, "severity": "P2", "title": "New inline log string literal flagged by Magic-values rule", "detail": "Copilot (CodingGuidelineID 1000000, \"Magic values & configuration\"): the new log message at this line introduces a new string literal in production code. Prefer reusing an existing configured UI message (e.g. web_editor_config.ui_messages.msg_detected_version) instead of adding a new inline literal.", "replyToCommentId": 3407912224}, {"file": "src/web/services/os_generation_ssot.py", "line": 265, "severity": "P2", "title": "New inline warning string literal flagged by Magic-values rule", "detail": "Copilot (CodingGuidelineID 1000000, \"Magic values & configuration\"): read_current_version_name_or_none() adds a new inline warning string in production code. Per repo convention, extract this message into a shared config constant (in src/shared/web_automation/config/) so future callers reuse it consistently.", "replyToCommentId": 3407912234}], "blocker": null}}]}}

package/skills/autoconverge/workflow/fixtures/wf_run/subagents/workflows/wf_881252e6-700/agent-a26213978adeef6fb.jsonl

@@ -0,0 +1,2 @@
+{"type": "user", "uuid": "a26213978adeef6fb-u", "message": {"role": "user", "content": "Return the structured result."}}
+{"type": "assistant", "uuid": "a26213978adeef6fb-a", "message": {"role": "assistant", "content": [{"type": "tool_use", "id": "toolu_a26213978adeef6fb", "name": "StructuredOutput", "input": {"newSha": "620382f766c4731ba92eefeb30bdbb9d0bcd4c90", "pushed": true, "resolvedWithoutCommit": false, "summary": "Fixed all 11 Copilot findings in one commit (620382f7): renamed banned `result` to `skip_path` in test_resume_skip_export.py and added `-> None` return annotations to the test functions across test_resume_skip_export.py, test_stp_path_selection.py, test_version_export_guards.py, and test_import_isolation.py; all 9 affected tests pass; pushed to fix/example-feature, posted 11 inline replies, and all 11 review threads are resolved."}}]}}

package/skills/autoconverge/workflow/fixtures/wf_run/subagents/workflows/wf_881252e6-700/agent-a3def0d15ed9d9110.jsonl

@@ -0,0 +1,2 @@
+{"type": "user", "uuid": "a3def0d15ed9d9110-u", "message": {"role": "user", "content": "Return the structured result."}}
+{"type": "assistant", "uuid": "a3def0d15ed9d9110-a", "message": {"role": "assistant", "content": [{"type": "tool_use", "id": "toolu_a3def0d15ed9d9110", "name": "StructuredOutput", "input": {"sha": "6a5169ef635ddb841e6f0465a309691ff77f033e", "clean": false, "blocker": null, "findings": [{"file": "src/exports/tests/test_resume_skip_export.py", "line": 35, "severity": "P2", "title": "Banned identifier `result` in test", "detail": "Naming guideline (CodingGuidelineID 1000000): newly introduced identifier `result` is banned; rename to a descriptive name such as `existing_apk_path` or `skip_path`.", "replyToCommentId": 3407883689}, {"file": "src/exports/tests/test_resume_skip_export.py", "line": 47, "severity": "P2", "title": "Banned identifier `result` in test", "detail": "Naming guideline (CodingGuidelineID 1000000): newly introduced identifier `result` is banned; rename to a descriptive name such as `existing_apk_path` or `skip_path`.", "replyToCommentId": 3407883707}, {"file": "src/logging/tests/test_import_isolation.py", "line": 33, "severity": "P2", "title": "Missing return type annotation on test function", "detail": "Repository guideline (CodingGuidelineID 1000000 \u2014 Types): newly added test function is missing an explicit return type annotation. Add `-> None`.", "replyToCommentId": 3407883713}, {"file": "src/logging/tests/test_import_isolation.py", "line": 43, "severity": "P2", "title": "Missing return type annotation on test function", "detail": "Repository guideline (CodingGuidelineID 1000000 \u2014 Types): newly added test function is missing an explicit return type annotation. Add `-> None`.", "replyToCommentId": 3407883717}, {"file": "src/exports/tests/test_version_export_guards.py", "line": 37, "severity": "P2", "title": "Missing return type annotation on async test", "detail": "Repository guideline (CodingGuidelineID 1000000 \u2014 Types): newly added async test is missing an explicit return type annotation. Add `-> None`.", "replyToCommentId": 3407883723}, {"file": "src/exports/tests/test_version_export_guards.py", "line": 74, "severity": "P2", "title": "Missing return type annotation on async test", "detail": "Repository guideline (CodingGuidelineID 1000000 \u2014 Types): newly added async test is missing an explicit return type annotation. Add `-> None`.", "replyToCommentId": 3407883727}, {"file": "src/exports/tests/test_stp_path_selection.py", "line": 19, "severity": "P2", "title": "Missing return type annotation on test function", "detail": "Repository guideline (CodingGuidelineID 1000000 \u2014 Types): newly added test function is missing an explicit return type annotation. Add `-> None`.", "replyToCommentId": 3407883731}, {"file": "src/exports/tests/test_stp_path_selection.py", "line": 31, "severity": "P2", "title": "Missing return type annotation on test function", "detail": "Repository guideline (CodingGuidelineID 1000000 \u2014 Types): newly added test function is missing an explicit return type annotation. Add `-> None`.", "replyToCommentId": 3407883736}, {"file": "src/exports/tests/test_stp_path_selection.py", "line": 43, "severity": "P2", "title": "Missing return type annotation on test function", "detail": "Repository guideline (CodingGuidelineID 1000000 \u2014 Types): newly added test function is missing an explicit return type annotation. Add `-> None`.", "replyToCommentId": 3407883740}, {"file": "src/exports/tests/test_resume_skip_export.py", "line": 21, "severity": "P2", "title": "Missing return type annotation on test function", "detail": "Repository guideline (CodingGuidelineID 1000000 \u2014 Types): newly added test function is missing an explicit return type annotation. Add `-> None`.", "replyToCommentId": 3407883749}, {"file": "src/exports/tests/test_resume_skip_export.py", "line": 38, "severity": "P2", "title": "Missing return type annotation on test function", "detail": "Repository guideline (CodingGuidelineID 1000000 \u2014 Types): newly added test function is missing an explicit return type annotation. Add `-> None`.", "replyToCommentId": 3407883755}]}}]}}

package/skills/autoconverge/workflow/fixtures/wf_run/subagents/workflows/wf_881252e6-700/agent-a41f41b1b708ee3b7.jsonl

@@ -0,0 +1,2 @@
+{"type": "user", "uuid": "a41f41b1b708ee3b7-u", "message": {"role": "user", "content": "Return the structured result."}}
+{"type": "assistant", "uuid": "a41f41b1b708ee3b7-a", "message": {"role": "assistant", "content": [{"type": "tool_use", "id": "toolu_a41f41b1b708ee3b7", "name": "StructuredOutput", "input": {"sha": "7c2f420c4d5b7c83aa47f93d99a0f1420e3373c4", "clean": true, "findings": [], "blocker": null}}]}}

package/skills/autoconverge/workflow/fixtures/wf_run/subagents/workflows/wf_881252e6-700/agent-a758b880abecc3ff7.jsonl

@@ -0,0 +1,2 @@
+{"type": "user", "uuid": "a758b880abecc3ff7-u", "message": {"role": "user", "content": "Return the structured result."}}
+{"type": "assistant", "uuid": "a758b880abecc3ff7-a", "message": {"role": "assistant", "content": [{"type": "tool_use", "id": "toolu_a758b880abecc3ff7", "name": "StructuredOutput", "input": {"newSha": "7c2f420c4d5b7c83aa47f93d99a0f1420e3373c4", "pushed": false, "resolvedWithoutCommit": true, "summary": "Both Copilot magic-value findings were already fixed at HEAD 7c2f420c (export_runner.py uses web_editor_config.ui_messages.msg_detected_version; os_generation_ssot.py uses os_generation_ssot_constants.unavailable_warning_template); posted inline replies and resolved both review threads (PRRT_kwDORiaSZc6JUqSw, PRRT_kwDORiaSZc6JUqS6)."}}]}}

package/skills/autoconverge/workflow/fixtures/wf_run/subagents/workflows/wf_881252e6-700/agent-a8897b89656b1bd16.jsonl

@@ -0,0 +1,2 @@
+{"type": "user", "uuid": "a8897b89656b1bd16-u", "message": {"role": "user", "content": "Return the structured result."}}
+{"type": "assistant", "uuid": "a8897b89656b1bd16-a", "message": {"role": "assistant", "content": [{"type": "tool_use", "id": "toolu_a8897b89656b1bd16", "name": "StructuredOutput", "input": {"newSha": "7c2f420c4d5b7c83aa47f93d99a0f1420e3373c4", "pushed": true, "resolvedWithoutCommit": false, "summary": "Fixed both Copilot magic-value findings on PR #211: export_runner.py now reuses web_editor_config.ui_messages.msg_detected_version, and os_generation_ssot.py references a new os_generation_ssot_constants.unavailable_warning_template. Added a behavioral TDD test, committed (7c2f420c) and pushed; posted inline replies to both comments (3407912224, 3407912234) and resolved both review threads (PRRT_kwDORiaSZc6JUqSw, PRRT_kwDORiaSZc6JUqS6)."}}]}}

package/skills/autoconverge/workflow/fixtures/wf_run/subagents/workflows/wf_881252e6-700/agent-abd463d744a1437bc.jsonl

@@ -0,0 +1,2 @@
+{"type": "user", "uuid": "abd463d744a1437bc-u", "message": {"role": "user", "content": "Return the structured result."}}
+{"type": "assistant", "uuid": "abd463d744a1437bc-a", "message": {"role": "assistant", "content": [{"type": "tool_use", "id": "toolu_abd463d744a1437bc", "name": "StructuredOutput", "input": {"sha": "6a5169ef635ddb841e6f0465a309691ff77f033e", "clean": true, "down": false, "findings": []}}]}}

package/skills/autoconverge/workflow/fixtures/wf_run/subagents/workflows/wf_881252e6-700/agent-ad19d027ae8ee1816.jsonl

@@ -0,0 +1,2 @@
+{"type": "user", "uuid": "ad19d027ae8ee1816-u", "message": {"role": "user", "content": "Return the structured result."}}
+{"type": "assistant", "uuid": "ad19d027ae8ee1816-a", "message": {"role": "assistant", "content": [{"type": "tool_use", "id": "toolu_ad19d027ae8ee1816", "name": "StructuredOutput", "input": {"sha": "620382f766c4731ba92eefeb30bdbb9d0bcd4c90", "clean": false, "findings": [{"file": "src/exports/core/export_runner.py", "line": 94, "severity": "P2", "title": "New inline log string literal in production code", "detail": "Copilot (CodingGuidelineID 1000000, Magic values & configuration): the new log message at this line introduces a new string literal in production code. Prefer reusing an existing configured UI message (e.g., web_editor_config.ui_messages.msg_detected_version) instead of adding a new inline literal here.", "replyToCommentId": 3407912224}, {"file": "src/web/services/os_generation_ssot.py", "line": 266, "severity": "P2", "title": "New inline warning string literal in read_current_version_name_or_none()", "detail": "Copilot (CodingGuidelineID 1000000, Magic values & configuration): read_current_version_name_or_none() adds a new inline warning string in production code. Per repo convention, extract this message into a shared config constant (in src/shared/web_automation/config/) so future callers reuse it consistently.", "replyToCommentId": 3407912234}], "blocker": null}}]}}

package/skills/autoconverge/workflow/fixtures/wf_run/workflows/wf_881252e6-700.json

@@ -0,0 +1,259 @@
+{
+  "runId": "wf_881252e6-700",
+  "timestamp": "2026-06-13T12:21:55.114Z",
+  "workflowName": "autoconverge",
+  "args": "{\"owner\": \"example-owner\", \"repo\": \"example-repo\", \"prNumber\": 211, \"bugbotDisabled\": false}",
+  "result": {
+    "converged": true,
+    "rounds": 4,
+    "finalSha": "7c2f420c4d5b7c83aa47f93d99a0f1420e3373c4",
+    "blocker": null
+  },
+  "agentCount": 33,
+  "logs": [
+    "Round 1: parallel Bugbot + code-review + bug-audit on 6a5169e",
+    "Round 1: all lenses clean on 6a5169e \u2014 posting clean audit artifact",
+    "Copilot raised 11 finding(s) \u2014 fixing and re-converging",
+    "Round 2: parallel Bugbot + code-review + bug-audit on 620382f",
+    "Round 2: all lenses clean on 620382f \u2014 posting clean audit artifact",
+    "Copilot raised 2 finding(s) \u2014 fixing and re-converging",
+    "Round 3: parallel Bugbot + code-review + bug-audit on 7c2f420",
+    "Round 3: all lenses clean on 7c2f420 \u2014 posting clean audit artifact",
+    "Copilot raised 2 finding(s) \u2014 fixing and re-converging",
+    "Round 4: parallel Bugbot + code-review + bug-audit on 7c2f420",
+    "Round 4: all lenses clean on 7c2f420 \u2014 posting clean audit artifact"
+  ],
+  "workflowProgress": [
+    {
+      "index": 1,
+      "label": "resolve-head",
+      "phaseTitle": "Converge",
+      "agentId": "a5fe69b589d8d7fbb",
+      "state": "done"
+    },
+    {
+      "index": 2,
+      "label": "prefetch-main",
+      "phaseTitle": "Converge",
+      "agentId": "ac31351235aa865f1",
+      "state": "done"
+    },
+    {
+      "index": 3,
+      "label": "lens:bugbot",
+      "phaseTitle": "Converge",
+      "agentId": "a62ab69718928660b",
+      "state": "done"
+    },
+    {
+      "index": 4,
+      "label": "lens:code-review",
+      "phaseTitle": "Converge",
+      "agentId": "abd463d744a1437bc",
+      "state": "done"
+    },
+    {
+      "index": 5,
+      "label": "lens:bug-audit",
+      "phaseTitle": "Converge",
+      "agentId": "ab84b5cb3e6362e6b",
+      "state": "done"
+    },
+    {
+      "index": 6,
+      "label": "post-clean-audit",
+      "phaseTitle": "Converge",
+      "agentId": "aee38021859a3de55",
+      "state": "done"
+    },
+    {
+      "index": 7,
+      "label": "copilot-gate",
+      "phaseTitle": "Copilot gate",
+      "agentId": "a3def0d15ed9d9110",
+      "state": "done"
+    },
+    {
+      "index": 8,
+      "label": "fix:copilot",
+      "phaseTitle": "Converge",
+      "agentId": "a26213978adeef6fb",
+      "state": "done"
+    },
+    {
+      "index": 9,
+      "label": "resolve-head",
+      "phaseTitle": "Converge",
+      "agentId": "a88f58b25c2721e0a",
+      "state": "done"
+    },
+    {
+      "index": 10,
+      "label": "prefetch-main",
+      "phaseTitle": "Converge",
+      "agentId": "aabb9c42f62fefa4e",
+      "state": "done"
+    },
+    {
+      "index": 11,
+      "label": "lens:bugbot",
+      "phaseTitle": "Converge",
+      "agentId": "aaba3804f6e7ecdb9",
+      "state": "done"
+    },
+    {
+      "index": 12,
+      "label": "lens:code-review",
+      "phaseTitle": "Converge",
+      "agentId": "a7e434e6ea14aa176",
+      "state": "done"
+    },
+    {
+      "index": 13,
+      "label": "lens:bug-audit",
+      "phaseTitle": "Converge",
+      "agentId": "a46f6274a36a1db05",
+      "state": "done"
+    },
+    {
+      "index": 14,
+      "label": "post-clean-audit",
+      "phaseTitle": "Converge",
+      "agentId": "a3da3394c6ff72250",
+      "state": "done"
+    },
+    {
+      "index": 15,
+      "label": "copilot-gate",
+      "phaseTitle": "Copilot gate",
+      "agentId": "ad19d027ae8ee1816",
+      "state": "done"
+    },
+    {
+      "index": 16,
+      "label": "fix:copilot",
+      "phaseTitle": "Converge",
+      "agentId": "a8897b89656b1bd16",
+      "state": "done"
+    },
+    {
+      "index": 17,
+      "label": "resolve-head",
+      "phaseTitle": "Converge",
+      "agentId": "a196c9a85c88db8a7",
+      "state": "done"
+    },
+    {
+      "index": 18,
+      "label": "prefetch-main",
+      "phaseTitle": "Converge",
+      "agentId": "a3154efa58640a34e",
+      "state": "done"
+    },
+    {
+      "index": 19,
+      "label": "lens:bugbot",
+      "phaseTitle": "Converge",
+      "agentId": "a1f2a12f1470d7c7b",
+      "state": "done"
+    },
+    {
+      "index": 20,
+      "label": "lens:code-review",
+      "phaseTitle": "Converge",
+      "agentId": "a6754f2df6e70aa7c",
+      "state": "done"
+    },
+    {
+      "index": 21,
+      "label": "lens:bug-audit",
+      "phaseTitle": "Converge",
+      "agentId": "aabdfb7eba8ff036e",
+      "state": "done"
+    },
+    {
+      "index": 22,
+      "label": "post-clean-audit",
+      "phaseTitle": "Converge",
+      "agentId": "aa3438f61bdd9129e",
+      "state": "done"
+    },
+    {
+      "index": 23,
+      "label": "copilot-gate",
+      "phaseTitle": "Copilot gate",
+      "agentId": "a11d903476b803493",
+      "state": "done"
+    },
+    {
+      "index": 24,
+      "label": "fix:copilot",
+      "phaseTitle": "Converge",
+      "agentId": "a758b880abecc3ff7",
+      "state": "done"
+    },
+    {
+      "index": 25,
+      "label": "resolve-head",
+      "phaseTitle": "Converge",
+      "agentId": "a536d1ed4bb9ad0de",
+      "state": "done"
+    },
+    {
+      "index": 26,
+      "label": "prefetch-main",
+      "phaseTitle": "Converge",
+      "agentId": "a89686ea20e9224e2",
+      "state": "done"
+    },
+    {
+      "index": 27,
+      "label": "lens:bugbot",
+      "phaseTitle": "Converge",
+      "agentId": "a82b70fdc78fe7c3a",
+      "state": "done"
+    },
+    {
+      "index": 28,
+      "label": "lens:code-review",
+      "phaseTitle": "Converge",
+      "agentId": "a00c5df83283e9cf6",
+      "state": "done"
+    },
+    {
+      "index": 29,
+      "label": "lens:bug-audit",
+      "phaseTitle": "Converge",
+      "agentId": "a89412c46f53a3218",
+      "state": "done"
+    },
+    {
+      "index": 30,
+      "label": "post-clean-audit",
+      "phaseTitle": "Converge",
+      "agentId": "add6f0d13e1911d87",
+      "state": "done"
+    },
+    {
+      "index": 31,
+      "label": "copilot-gate",
+      "phaseTitle": "Copilot gate",
+      "agentId": "a41f41b1b708ee3b7",
+      "state": "done"
+    },
+    {
+      "index": 32,
+      "label": "check-convergence",
+      "phaseTitle": "Finalize",
+      "agentId": "a3338954faed1eb55",
+      "state": "done"
+    },
+    {
+      "index": 33,
+      "label": "mark-ready",
+      "phaseTitle": "Finalize",
+      "agentId": "add93d458ce4da043",
+      "state": "done"
+    }
+  ]
+}