claude-dev-env 1.42.0 → 1.44.0

package/hooks/hooks_constants/test_md_to_html_blocker_constants.py

@@ -0,0 +1,110 @@
+"""Behavior tests for md_to_html_blocker_constants module."""
+
+from __future__ import annotations
+
+import sys
+from pathlib import Path
+
+_HOOKS_ROOT = Path(__file__).resolve().parent.parent
+if str(_HOOKS_ROOT) not in sys.path:
+    sys.path.insert(0, str(_HOOKS_ROOT))
+
+from hooks_constants import md_to_html_blocker_constants as constants_module
+
+
+def test_indicator_path_segments_are_named_constants() -> None:
+    """The two leading segments of the Claude Code source indicator
+    (`packages/claude-dev-env`) must live as named constants so
+    `_is_exempt_path` references symbols, not inline literals. Bugbot flagged
+    these as magic strings even though the third segment was already a named
+    constant; align all three."""
+    assert constants_module.PACKAGES_TOP_LEVEL_SEGMENT == "packages"
+    assert constants_module.CLAUDE_DEV_ENV_REPO_NAME_SEGMENT == "claude-dev-env"
+    for each_name in ("PACKAGES_TOP_LEVEL_SEGMENT", "CLAUDE_DEV_ENV_REPO_NAME_SEGMENT"):
+        assert each_name in constants_module.__all__
+
+
+def test_claude_code_source_top_directories_enumerates_six_canonical_dirs() -> None:
+    """The exempt top-level directory set must match the six canonical Claude
+    Code source directories (agents, docs, skills, rules, system-prompts,
+    commands). Drift in either direction silently changes the exemption
+    surface."""
+    expected_directories = frozenset(
+        {"agents", "docs", "skills", "rules", "system-prompts", "commands"}
+    )
+    assert constants_module.ALL_CLAUDE_CODE_SOURCE_TOP_DIRECTORIES == expected_directories
+    assert "ALL_CLAUDE_CODE_SOURCE_TOP_DIRECTORIES" in constants_module.__all__
+
+
+def test_minimum_segment_count_to_match_indicator_is_four() -> None:
+    """Matching `packages/claude-dev-env/<dir>/<file>` requires at least 4
+    consecutive path segments from the starting index. The constant documents
+    that requirement explicitly."""
+    assert constants_module.MINIMUM_SEGMENT_COUNT_TO_MATCH_INDICATOR == 4
+    assert "MINIMUM_SEGMENT_COUNT_TO_MATCH_INDICATOR" in constants_module.__all__
+
+
+def test_exempt_anywhere_filenames_include_skill_md() -> None:
+    """`SKILL.md` files are exempt anywhere in the tree. The constant stores
+    the display-case spelling; the lookup at use sites lowercases the
+    candidate basename, so casing here documents the human-facing form."""
+    assert "SKILL.md" in constants_module.ALL_EXEMPT_ANYWHERE_FILENAMES
+    assert "ALL_EXEMPT_ANYWHERE_FILENAMES" in constants_module.__all__
+
+
+def test_exempt_plugin_directory_segments_match_claude_code_layout() -> None:
+    """The three plugin-layout directory names recognized anywhere in a path:
+    agents/, skills/, commands/. Drift in either direction silently changes
+    the exemption surface."""
+    expected_segments = ("agents", "skills", "commands")
+    assert constants_module.ALL_EXEMPT_PLUGIN_DIRECTORY_SEGMENTS == expected_segments
+    assert "ALL_EXEMPT_PLUGIN_DIRECTORY_SEGMENTS" in constants_module.__all__
+
+
+def test_exempt_plugin_segments_subset_of_claude_code_source_top_directories() -> None:
+    """ALL_EXEMPT_PLUGIN_DIRECTORY_SEGMENTS (matched anywhere in the path)
+    must be a subset of ALL_CLAUDE_CODE_SOURCE_TOP_DIRECTORIES (matched
+    only at the anchored claude-dev-env source root). If a future change
+    adds a segment to the anywhere list that is not in the anchored set,
+    the anywhere rule would let writes through that the anchored rule
+    would still block — surprising and asymmetric."""
+    anywhere_segments = set(constants_module.ALL_EXEMPT_PLUGIN_DIRECTORY_SEGMENTS)
+    anchored_source_directories = set(
+        constants_module.ALL_CLAUDE_CODE_SOURCE_TOP_DIRECTORIES
+    )
+    assert anywhere_segments.issubset(anchored_source_directories)
+
+
+def test_exempt_home_relative_directories_include_session_log() -> None:
+    """SessionLog/ under the user's home directory is the canonical Obsidian
+    vault entrypoint and must be writable as .md."""
+    assert "SessionLog" in constants_module.ALL_EXEMPT_HOME_RELATIVE_DIRECTORIES
+    assert "ALL_EXEMPT_HOME_RELATIVE_DIRECTORIES" in constants_module.__all__
+
+
+def test_exempt_root_filenames_cover_readme_and_changelog() -> None:
+    """README.md and CHANGELOG.md at a repo root are universally exempt;
+    every repo with a `.git` marker satisfies the root check."""
+    assert constants_module.ALL_EXEMPT_ROOT_FILENAMES == ("readme.md", "changelog.md")
+    assert "ALL_EXEMPT_ROOT_FILENAMES" in constants_module.__all__
+
+
+def test_repo_root_marker_name_is_dot_git() -> None:
+    """A directory containing `.git` (file or directory) is treated as a repo
+    root for the README/CHANGELOG exemption."""
+    assert constants_module.REPO_ROOT_MARKER_NAME == ".git"
+    assert "REPO_ROOT_MARKER_NAME" in constants_module.__all__
+
+
+def test_claude_directory_name_is_dot_claude() -> None:
+    """Any path containing a `.claude/` segment bypasses the .md block
+    (project-level Claude Code infrastructure)."""
+    assert constants_module.CLAUDE_DIRECTORY_NAME == ".claude"
+    assert "CLAUDE_DIRECTORY_NAME" in constants_module.__all__
+
+
+def test_plugin_root_marker_directory_name_is_dot_claude_plugin() -> None:
+    """Any directory whose ancestor contains `.claude-plugin/` is treated as
+    a plugin repo root and exempted."""
+    assert constants_module.PLUGIN_ROOT_MARKER_DIRECTORY_NAME == ".claude-plugin"
+    assert "PLUGIN_ROOT_MARKER_DIRECTORY_NAME" in constants_module.__all__

package/hooks/{config → hooks_constants}/test_messages.py

@@ -1,10 +1,6 @@
-"""Smoke tests for config.messages — verify user-facing notice constants exist."""
+"""Smoke tests for hooks_constants.messages — verify user-facing notice constants exist."""
 
-import sys
-
-sys.modules.pop("config", None)
-
-from config import messages
+from hooks_constants import messages
 
 
 def test_user_facing_notice_is_nonempty_string() -> None:

package/hooks/{config → hooks_constants}/test_path_rewriter_constants.py

@@ -7,7 +7,7 @@ _HOOKS_ROOT = Path(__file__).resolve().parent.parent
 if str(_HOOKS_ROOT) not in sys.path:
     sys.path.insert(0, str(_HOOKS_ROOT))
 
-from config.path_rewriter_constants import (
+from hooks_constants.path_rewriter_constants import (
     BASH_TOOL_NAME,
     HOOK_EVENT_NAME,
     PERMISSION_ALLOW,

package/hooks/hooks_constants/test_pr_description_enforcer_constants.py

@@ -0,0 +1,292 @@
+"""Behavior tests for pr_description_enforcer_constants module."""
+
+from __future__ import annotations
+
+import os
+import sys
+from pathlib import Path
+
+import pytest
+
+_HOOKS_ROOT = Path(__file__).resolve().parent.parent
+if str(_HOOKS_ROOT) not in sys.path:
+    sys.path.insert(0, str(_HOOKS_ROOT))
+
+from hooks_constants import pr_description_enforcer_constants as constants_module
+
+
+def test_plugin_root_is_private_module_attribute() -> None:
+    assert hasattr(constants_module, "_PLUGIN_ROOT")
+    assert isinstance(constants_module._PLUGIN_ROOT, str)
+    assert os.path.isabs(constants_module._PLUGIN_ROOT)
+
+
+def test_plugin_root_public_name_is_not_exported() -> None:
+    assert not hasattr(constants_module, "PLUGIN_ROOT")
+
+
+def test_pr_guide_path_resolves_under_plugin_root_docs() -> None:
+    expected_pr_guide_path = os.path.join(
+        constants_module._PLUGIN_ROOT, "docs", "PR_DESCRIPTION_GUIDE.md"
+    )
+    assert constants_module.PR_GUIDE_PATH == expected_pr_guide_path
+
+
+def test_fenced_code_block_pattern_matches_triple_backtick_block() -> None:
+    sample_markdown = "before ```python\ncode\n``` after"
+    match = constants_module.FENCED_CODE_BLOCK_PATTERN.search(sample_markdown)
+    assert match is not None
+    assert match.group(0).startswith("```")
+    assert match.group(0).endswith("```")
+
+
+def test_inline_code_pattern_matches_single_backtick_span() -> None:
+    match = constants_module.INLINE_CODE_PATTERN.search("see `value` here")
+    assert match is not None
+    assert match.group(0) == "`value`"
+
+
+def test_heading_line_pattern_matches_atx_heading() -> None:
+    match = constants_module.HEADING_LINE_PATTERN.search("## Description\n")
+    assert match is not None
+    assert match.group(0).strip() == "## Description"
+
+
+def test_bold_pair_pattern_captures_inner_text() -> None:
+    match = constants_module.BOLD_PAIR_PATTERN.search("this is **bold** text")
+    assert match is not None
+    assert match.group(1) == "bold"
+
+
+def test_bullet_marker_pattern_strips_dash_bullet_from_line() -> None:
+    stripped_line = constants_module.BULLET_MARKER_PATTERN.sub("", "- first item")
+    assert stripped_line == "first item"
+
+
+def test_blockquote_marker_pattern_strips_quote_marker_from_line() -> None:
+    stripped_line = constants_module.BLOCKQUOTE_MARKER_PATTERN.sub("", "> quoted line")
+    assert stripped_line == "quoted line"
+
+
+def test_link_text_pattern_captures_anchor_text() -> None:
+    match = constants_module.LINK_TEXT_PATTERN.search("See [the docs](https://example.com) now")
+    assert match is not None
+    assert match.group(1) == "the docs"
+
+
+def test_whitespace_run_pattern_collapses_multiple_spaces() -> None:
+    collapsed_text = constants_module.WHITESPACE_RUN_PATTERN.sub(" ", "a   b\t\tc\n\nd")
+    assert collapsed_text == "a b c d"
+
+
+def test_this_pr_opening_pattern_matches_any_verb() -> None:
+    """The guide says any `This PR ...` opening is a hard block. The pattern
+    must match regardless of the verb that follows, not a short allowlist."""
+    test_inputs = [
+        "This PR introduces a new feature.",
+        "This PR improves the algorithm.",
+        "This PR enables the cache.",
+        "This PR documents the contract.",
+        "This PR adds a check.",
+        "This PR fixes the bug.",
+    ]
+    for each_input in test_inputs:
+        assert constants_module.THIS_PR_OPENING_PATTERN.match(each_input), (
+            f"`{each_input}` must match THIS_PR_OPENING_PATTERN regardless of verb"
+        )
+
+
+def test_this_pr_opening_pattern_does_not_match_within_prose() -> None:
+    """The block applies to body openings, not mid-paragraph mentions."""
+    text_with_mid_mention = "Adds caching. This PR follows the playbook."
+    assert constants_module.THIS_PR_OPENING_PATTERN.match(text_with_mid_mention) is None
+
+
+def test_all_list_is_alphabetically_sorted() -> None:
+    """`__all__` is the export surface; alphabetical order makes it easy to
+    verify completeness, spot duplicates, and bisect missing entries. Pin
+    sorted order so drift cannot reintroduce the H-before-G / appended-at-end
+    inconsistencies Bugbot flagged."""
+    actual_all_list = constants_module.__all__
+    expected_sorted = sorted(actual_all_list)
+    if actual_all_list != expected_sorted:
+        first_divergence_index = next(
+            each_index
+            for each_index, (each_actual_value, each_expected_value) in enumerate(zip(actual_all_list, expected_sorted))
+            if each_actual_value != each_expected_value
+        )
+        raise AssertionError(
+            "constants_module.__all__ must be alphabetically sorted; "
+            f"the first divergence is at index {first_divergence_index}: "
+            f"got {actual_all_list[first_divergence_index]!r}, "
+            f"expected {expected_sorted[first_divergence_index]!r}"
+        )
+
+
+def test_dead_heavy_detection_constants_are_removed() -> None:
+    """`ALL_HEAVY_DETECTION_HEADERS` and `HEAVY_DETECTION_HEADER_COUNT_MIN`
+    were remnants of the prior two-condition shape classifier (length AND
+    detection-header count). e137dee9 simplified the classifier to use length
+    alone, leaving both names as dead exports. Pin their removal so they
+    cannot drift back as misleading vestigial constants."""
+    for each_name in ("ALL_HEAVY_DETECTION_HEADERS", "HEAVY_DETECTION_HEADER_COUNT_MIN"):
+        assert not hasattr(constants_module, each_name), (
+            f"{each_name} must be deleted; the classifier now uses "
+            "HEAVY_MIN_BODY_CHARS_FOR_CLASSIFICATION alone."
+        )
+        assert each_name not in constants_module.__all__
+
+
+def test_self_closing_reference_message_prefix_and_suffix_compose_full_message() -> None:
+    pr_number = 42
+    composed_message = (
+        f"{constants_module.SELF_CLOSING_REFERENCE_MESSAGE_PREFIX}"
+        f"{pr_number}"
+        f"{constants_module.SELF_CLOSING_REFERENCE_MESSAGE_SUFFIX}"
+    )
+    assert "#42" in composed_message
+    assert "Fixes/Closes/Resolves" in composed_message
+    assert "self-reference" in composed_message
+
+
+def test_loosen_factors_are_inverse_paired() -> None:
+    flesch_factor = constants_module.READABILITY_FLESCH_LOOSEN_FACTOR
+    sentence_factor = constants_module.READABILITY_SENTENCE_WORDS_LOOSEN_FACTOR
+    assert flesch_factor * sentence_factor == pytest.approx(1.0)
+
+
+def test_unused_header_constants_are_removed_from_module() -> None:
+    """The four header constants FIX_HEADER, CHANGES_HEADER, APPROACH_HEADER,
+    and ROOT_CAUSE_HEADER were dead exports with no call sites and must not be
+    re-introduced as either module attributes or __all__ entries."""
+    for each_dead_name in ("FIX_HEADER", "CHANGES_HEADER", "APPROACH_HEADER", "ROOT_CAUSE_HEADER"):
+        assert not hasattr(constants_module, each_dead_name), (
+            f"{each_dead_name} was re-introduced; the four header constants "
+            "had zero call sites and were deleted."
+        )
+        assert each_dead_name not in constants_module.__all__, (
+            f"{each_dead_name} re-appeared in __all__ even though it has no consumers."
+        )
+
+
+def test_module_internal_header_constants_are_not_publicly_exported() -> None:
+    """The seven header-name constants and three default-readability-threshold scalars
+    are consumed only inside this same module (used to build ALL_HEAVY_* frozensets
+    and DEFAULT_READABILITY_THRESHOLDS). They must remain module attributes for the
+    builder expressions, but they must NOT appear in __all__ -- callers should import
+    the public aggregates (ALL_HEAVY_OPENING_HEADERS / ALL_HEAVY_TESTING_HEADERS /
+    DEFAULT_READABILITY_THRESHOLDS) instead of the individual scalars."""
+    all_internal_only_names = (
+        "SUMMARY_HEADER",
+        "PROBLEM_HEADER",
+        "TEST_PLAN_HEADER",
+        "TESTS_HEADER",
+        "TESTING_HEADER",
+        "VERIFICATION_HEADER",
+        "VALIDATION_HEADER",
+        "READABILITY_MAX_SENTENCE_WORDS",
+        "READABILITY_AVG_SENTENCE_WORDS",
+        "READABILITY_MIN_FLESCH",
+    )
+    for each_internal_name in all_internal_only_names:
+        assert hasattr(constants_module, each_internal_name), (
+            f"{each_internal_name} must remain as a module attribute -- "
+            "the aggregate builders reference it."
+        )
+        assert each_internal_name not in constants_module.__all__, (
+            f"{each_internal_name} is consumed only inside the module and "
+            "must not be advertised in __all__."
+        )
+
+
+def test_self_reference_pattern_covers_all_nine_github_closing_keywords() -> None:
+    """GitHub recognizes nine closing keywords: close/closes/closed,
+    fix/fixes/fixed, resolve/resolves/resolved. The self-reference template
+    must enumerate all nine so no variant bypasses the self-closing block."""
+    pattern_source = constants_module.SELF_REFERENCE_PATTERN_TEMPLATE
+    for each_keyword in (
+        "Close", "Closes", "Closed",
+        "Fix", "Fixes", "Fixed",
+        "Resolve", "Resolves", "Resolved",
+    ):
+        assert each_keyword in pattern_source, (
+            f"SELF_REFERENCE_PATTERN_TEMPLATE must enumerate `{each_keyword}` "
+            f"to catch every GitHub closing-keyword variant; got: {pattern_source!r}"
+        )
+
+
+def test_body_shape_string_literals_are_named_constants() -> None:
+    """The three PR-body shape names (`trivial`, `standard`, `heavy`) are used
+    by both `_compute_pr_body_shape` (return values) and `validate_pr_body`
+    (string comparisons). Bugbot flagged the inline literals as cross-function
+    magic strings. Pin the canonical names in `hooks_constants/` so a typo in
+    either site cannot silently misclassify shape."""
+    assert constants_module.TRIVIAL_SHAPE == "trivial"
+    assert constants_module.STANDARD_SHAPE == "standard"
+    assert constants_module.HEAVY_SHAPE == "heavy"
+    for each_name in ("TRIVIAL_SHAPE", "STANDARD_SHAPE", "HEAVY_SHAPE"):
+        assert each_name in constants_module.__all__
+
+
+def test_readability_cli_flag_tokens_exposes_four_flags() -> None:
+    """ALL_READABILITY_CLI_FLAG_TOKENS centralises the four CLI flags the
+    dispatcher recognises (loosen/reset/disable/enable). Pinning the set keeps
+    main()'s dispatcher loop and the dispatcher itself in sync; adding a flag
+    requires updating both the constant and the dispatcher in the same commit."""
+    expected_tokens = frozenset(
+        {
+            "--readability-loosen",
+            "--readability-reset",
+            "--readability-disable",
+            "--readability-enable",
+        }
+    )
+    assert constants_module.ALL_READABILITY_CLI_FLAG_TOKENS == expected_tokens
+    assert "ALL_READABILITY_CLI_FLAG_TOKENS" in constants_module.__all__
+
+
+def test_ceremony_header_pattern_is_removed() -> None:
+    """`CEREMONY_HEADER_PATTERN` is replaced by the broader `HEADING_LINE_PATTERN`
+    check in the Trivial-ceremony violation; the constant must not linger as a
+    dead export to drift back into use."""
+    assert not hasattr(constants_module, "CEREMONY_HEADER_PATTERN"), (
+        "CEREMONY_HEADER_PATTERN must be deleted; the ceremony-on-Trivial check "
+        "now uses HEADING_LINE_PATTERN to cover every heading level."
+    )
+    assert "CEREMONY_HEADER_PATTERN" not in constants_module.__all__
+
+
+def test_flesch_formula_coefficients_are_named_constants() -> None:
+    """The Flesch Reading Ease formula coefficients (206.835, 1.015, 84.6) and
+    the perfect-score default (100.0) must live as named UPPER_SNAKE constants
+    in `hooks_constants/pr_description_enforcer_constants.py` so the production
+    function body has zero magic numeric literals."""
+    assert constants_module.FLESCH_BASE_SCORE == 206.835
+    assert constants_module.FLESCH_WORDS_PER_SENTENCE_COEFFICIENT == 1.015
+    assert constants_module.FLESCH_SYLLABLES_PER_WORD_COEFFICIENT == 84.6
+    assert constants_module.FLESCH_PERFECT_SCORE == 100.0
+    for each_name in (
+        "FLESCH_BASE_SCORE",
+        "FLESCH_WORDS_PER_SENTENCE_COEFFICIENT",
+        "FLESCH_SYLLABLES_PER_WORD_COEFFICIENT",
+        "FLESCH_PERFECT_SCORE",
+    ):
+        assert each_name in constants_module.__all__, (
+            f"{each_name} must appear in __all__ so the enforcer can import it."
+        )
+
+
+def test_all_heavy_testing_headers_enumerates_five_canonical_forms() -> None:
+    """The frozenset ALL_HEAVY_TESTING_HEADERS drives the violation message that
+    tells the writer which headers satisfy the heavy-shape testing-category
+    requirement. The set must include all five canonical forms (Test plan,
+    Testing, Tests, Verification, Validation) so the writer's documented
+    vocabulary matches the message it receives on a violation."""
+    expected_canonical_headers = [
+        "## Test plan",
+        "## Testing",
+        "## Tests",
+        "## Validation",
+        "## Verification",
+    ]
+    assert sorted(constants_module.ALL_HEAVY_TESTING_HEADERS) == expected_canonical_headers

package/hooks/{config → hooks_constants}/test_pre_tool_use_stdin.py

@@ -8,8 +8,8 @@ import json
 import sys
 from unittest.mock import patch
 
-from config import pre_tool_use_stdin
-from config.pre_tool_use_stdin import read_hook_input_dictionary_from_stdin
+from hooks_constants import pre_tool_use_stdin
+from hooks_constants.pre_tool_use_stdin import read_hook_input_dictionary_from_stdin
 
 
 def test_pre_tool_use_stdin_uses_shared_encoding_and_decode_constants() -> None:

package/hooks/{config → hooks_constants}/test_project_paths_reader.py

@@ -11,13 +11,13 @@ _HOOKS_ROOT = Path(__file__).resolve().parent.parent
 if str(_HOOKS_ROOT) not in sys.path:
     sys.path.insert(0, str(_HOOKS_ROOT))
 
-from config import project_paths_reader
-from config.project_paths_reader import (
+from hooks_constants import project_paths_reader
+from hooks_constants.project_paths_reader import (
     load_registry,
     registry_contains_path,
     registry_file_path,
 )
-from config.setup_project_paths_constants import META_KEY
+from hooks_constants.setup_project_paths_constants import META_KEY
 
 
 def test_reader_does_not_redefine_dynamic_stderr_handler_locally() -> None:

package/hooks/{config → hooks_constants}/test_session_env_cleanup_constants.py

@@ -11,7 +11,7 @@ for each_sys_path_entry in (str(_CONFIG_DIRECTORY), str(_HOOKS_ROOT)):
     if each_sys_path_entry not in sys.path:
         sys.path.insert(0, each_sys_path_entry)
 
-from config.session_env_cleanup_constants import SESSION_ID_PATTERN, SESSION_ID_PAYLOAD_KEY
+from hooks_constants.session_env_cleanup_constants import SESSION_ID_PATTERN, SESSION_ID_PAYLOAD_KEY
 
 
 class TestSessionIdPatternAccepts:

package/hooks/{config → hooks_constants}/test_setup_project_paths_constants.py

@@ -9,8 +9,8 @@ _HOOKS_ROOT = Path(__file__).resolve().parent.parent
 if str(_HOOKS_ROOT) not in sys.path:
     sys.path.insert(0, str(_HOOKS_ROOT))
 
-import config.setup_project_paths_constants as constants_module
-from config.setup_project_paths_constants import (
+import hooks_constants.setup_project_paths_constants as constants_module
+from hooks_constants.setup_project_paths_constants import (
     ABORTED_NOTHING_WRITTEN_MESSAGE,
     CONFIRMATION_PROMPT_TEXT,
     ES_EXE_FOLDERS_ONLY_QUERY_ARGUMENTS,

package/hooks/{config → hooks_constants}/test_unused_module_import_constants.py

@@ -9,7 +9,7 @@ _HOOKS_ROOT = Path(__file__).resolve().parent.parent
 if str(_HOOKS_ROOT) not in sys.path:
     sys.path.insert(0, str(_HOOKS_ROOT))
 
-from config.unused_module_import_constants import line_suppresses_unused_import_via_noqa
+from hooks_constants.unused_module_import_constants import line_suppresses_unused_import_via_noqa
 
 
 def test_line_suppresses_bare_noqa() -> None:

package/hooks/lifecycle/pr_converge_bugteam_skill_tracker.py

@@ -25,17 +25,11 @@ import tempfile
 from pathlib import Path
 from typing import TextIO
 
+_hooks_dir = str(Path(__file__).resolve().parent.parent)
+if _hooks_dir not in sys.path:
+    sys.path.insert(0, _hooks_dir)
 
-def _insert_hooks_tree_for_imports() -> None:
-    hooks_tree = Path(__file__).resolve().parent.parent
-    hooks_tree_string = str(hooks_tree)
-    if hooks_tree_string not in sys.path:
-        sys.path.insert(0, hooks_tree_string)
-
-
-_insert_hooks_tree_for_imports()
-
-from config.pr_converge_bugteam_enforcer_constants import (
+from hooks_constants.pr_converge_bugteam_enforcer_constants import (  # noqa: E402
     BUGTEAM_SKILL_NAME,
     SKILL_TOOL_NAME,
     STATE_FIELD_BUGTEAM_SKILL_INVOKED_AT_HEAD,
@@ -45,7 +39,7 @@ from config.pr_converge_bugteam_enforcer_constants import (
     STATE_FILE_ATOMIC_WRITE_SUFFIX,
     STATE_FILE_JSON_INDENT_SPACES,
 )
-from config.pr_converge_bugteam_enforcer_state import (
+from hooks_constants.pr_converge_bugteam_enforcer_state import (  # noqa: E402
     load_state_dictionary,
     resolve_state_path,
 )

package/hooks/lifecycle/test_pr_converge_bugteam_skill_tracker.py

@@ -33,7 +33,7 @@ assert hook_spec.loader is not None
 hook_module = importlib.util.module_from_spec(hook_spec)
 hook_spec.loader.exec_module(hook_module)
 
-from config.pr_converge_bugteam_enforcer_constants import (
+from hooks_constants.pr_converge_bugteam_enforcer_constants import (
     CLAUDE_JOB_DIR_ENV_VAR,
     PR_CONVERGE_STATE_FILENAME,
 )

package/hooks/session/gh_pr_author_session_cleanup.py

@@ -29,19 +29,18 @@ import tempfile
 import time
 from pathlib import Path
 
+hooks_parent_directory = str(Path(__file__).resolve().parent.parent)
+if hooks_parent_directory not in sys.path:
+    sys.path.insert(0, hooks_parent_directory)
 
-_hooks_tree_path = str(Path(__file__).absolute().parent.parent)
-if _hooks_tree_path not in sys.path:
-    sys.path.insert(0, _hooks_tree_path)
-
-from _gh_pr_author_swap_utils import (  # noqa: E402  # sys.path shim above must run first
+from _gh_pr_author_swap_utils import (  # noqa: E402
     _delete_state_file,
     _lstat_indicates_attacker_planted,
     _read_original_account,
     _switch_gh_account,
     _write_line,
 )
-from config.gh_pr_author_swap_constants import (  # noqa: E402  # sys.path shim above must run first
+from hooks_constants.gh_pr_author_swap_constants import (  # noqa: E402
     REQUIRED_ACCOUNT_ENV_VAR,
     STATE_FILE_PREFIX,
     STATE_FILE_STALE_AGE_SECONDS,

package/hooks/session/session_env_cleanup.py

@@ -25,17 +25,11 @@ import time
 from pathlib import Path
 from typing import Callable
 
+_hooks_dir = str(Path(__file__).resolve().parent.parent)
+if _hooks_dir not in sys.path:
+    sys.path.insert(0, _hooks_dir)
 
-def _insert_hooks_tree_for_imports() -> None:
-    hooks_tree = Path(__file__).resolve().parent.parent
-    hooks_tree_string = str(hooks_tree)
-    if hooks_tree_string not in sys.path:
-        sys.path.insert(0, hooks_tree_string)
-
-
-_insert_hooks_tree_for_imports()
-
-from config.session_env_cleanup_constants import (
+from hooks_constants.session_env_cleanup_constants import (  # noqa: E402
     ALL_RMTREE_ONEXC_PYTHON_VERSION_PARTS,
     SESSION_ENV_DIRECTORY,
     SESSION_ID_PATTERN,

package/hooks/session/test_gh_pr_author_session_cleanup.py

@@ -31,7 +31,7 @@ hook_module_spec.loader.exec_module(hook_module)
 
 import _gh_pr_author_swap_utils as swap_utils_module  # noqa: E402
 
-from config.gh_pr_author_swap_constants import (  # noqa: E402
+from hooks_constants.gh_pr_author_swap_constants import (  # noqa: E402
     STATE_FILE_PERMISSION_MODE,
     STATE_FILE_STALE_AGE_SECONDS,
 )

package/hooks/session/test_untracked_repo_detector.py

@@ -15,8 +15,8 @@ for each_sys_path_entry in (str(_SESSION_DIR), str(_HOOKS_ROOT)):
         sys.path.insert(0, each_sys_path_entry)
 
 import untracked_repo_detector as detector
-from config.project_paths_reader import registry_file_path
-from config.setup_project_paths_constants import GIT_DIRECTORY_SEGMENT_NAME
+from hooks_constants.project_paths_reader import registry_file_path
+from hooks_constants.setup_project_paths_constants import GIT_DIRECTORY_SEGMENT_NAME
 
 
 def _run_main_with_cwd(cwd: str, known_registry: dict) -> tuple[str, str, int]:

package/hooks/session/untracked_repo_detector.py

@@ -15,23 +15,17 @@ import os
 import sys
 from pathlib import Path
 
+_hooks_dir = str(Path(__file__).resolve().parent.parent)
+if _hooks_dir not in sys.path:
+    sys.path.insert(0, _hooks_dir)
 
-def _insert_hooks_tree_for_imports() -> None:
-    hooks_tree = Path(__file__).resolve().parent.parent
-    hooks_tree_string = str(hooks_tree)
-    if hooks_tree_string not in sys.path:
-        sys.path.insert(0, hooks_tree_string)
-
-
-_insert_hooks_tree_for_imports()
-
-from config.dynamic_stderr_handler import DynamicStderrHandler
-from config.project_paths_reader import (
+from hooks_constants.dynamic_stderr_handler import DynamicStderrHandler  # noqa: E402
+from hooks_constants.project_paths_reader import (  # noqa: E402
     load_registry,
     registry_contains_path,
     registry_file_path,
 )
-from config.setup_project_paths_constants import GIT_DIRECTORY_SEGMENT_NAME
+from hooks_constants.setup_project_paths_constants import GIT_DIRECTORY_SEGMENT_NAME  # noqa: E402
 
 
 _logger = logging.getLogger("untracked_repo_detector")

package/hooks/test__gh_pr_author_swap_utils.py

@@ -17,7 +17,7 @@ import tempfile
 
 import pytest
 
-from config.gh_pr_author_swap_constants import STATE_FILE_PERMISSION_MODE
+from hooks_constants.gh_pr_author_swap_constants import STATE_FILE_PERMISSION_MODE
 
 _HOOKS_ROOT = pathlib.Path(__file__).resolve().parent
 if str(_HOOKS_ROOT) not in sys.path: