claude-dev-env 1.40.0 → 1.41.0

package/CLAUDE.md

@@ -5,7 +5,7 @@ The user delegates execution to you and expects zero manual steps unless strictl
 ## Code Rules
 @~/.claude/docs/CODE_RULES.md
 
-When a UNC path is mapped to a drive letter, ALWAYS prefer the drive letter and NEVER use UNC.
+ALWAYS call the AskUserQuestion tool if you have a question for the user. Provide content-appropriate default options, with a flag for the recommended one.
 
 ## GOTCHAS
 When making code changes, make sure you are working in the proper worktree path for the task at hand.

package/_shared/pr-loop/scripts/grant_project_claude_permissions.py

@@ -9,9 +9,22 @@ the changes applied. No-op when the entries already exist.
 import sys
 from pathlib import Path
 
-sys.modules.pop("config", None)
-if str(Path(__file__).resolve().parent) not in sys.path:
-    sys.path.insert(0, str(Path(__file__).resolve().parent))
+parent_directory = str(Path(__file__).absolute().parent)
+try:
+    sys.path.remove(parent_directory)
+except ValueError:
+    pass
+if parent_directory not in sys.path:
+    sys.path.insert(0, parent_directory)
+
+for each_cached_module_name in [
+    each_module_key
+    for each_module_key in list(sys.modules)
+    if each_module_key == "config"
+    or each_module_key.startswith("config.")
+    or each_module_key == "_claude_permissions_common"
+]:
+    sys.modules.pop(each_cached_module_name, None)
 
 from _claude_permissions_common import (  # noqa: E402
     append_if_missing,
@@ -41,6 +54,15 @@ from config.claude_settings_keys_constants import (  # noqa: E402
 def add_rules_to_allow_list(
     all_settings: dict[str, object], all_rules_to_add: list[str]
 ) -> int:
+    """Add permission rules to the settings allow list.
+
+    Args:
+        all_settings: The parsed settings dictionary.
+        all_rules_to_add: Permission rule strings to append.
+
+    Returns:
+        Number of rules actually added (new entries).
+    """
     permissions_section = ensure_dict_section(
         all_settings, CLAUDE_SETTINGS_PERMISSIONS_KEY
     )
@@ -57,6 +79,15 @@ def add_rules_to_allow_list(
 def add_directory_to_additional_directories(
     all_settings: dict[str, object], directory_path: str
 ) -> int:
+    """Add a project path to the additionalDirectories allow list.
+
+    Args:
+        all_settings: The parsed settings dictionary.
+        directory_path: The project directory path to add.
+
+    Returns:
+        1 when the entry was added, 0 when it already existed.
+    """
     permissions_section = ensure_dict_section(
         all_settings, CLAUDE_SETTINGS_PERMISSIONS_KEY
     )
@@ -71,6 +102,15 @@ def add_directory_to_additional_directories(
 def add_auto_mode_environment_entry(
     all_settings: dict[str, object], entry_text: str
 ) -> int:
+    """Add an auto-mode environment entry for the project.
+
+    Args:
+        all_settings: The parsed settings dictionary.
+        entry_text: The environment entry text to add.
+
+    Returns:
+        1 when the entry was added, 0 when it already existed.
+    """
     auto_mode_section = ensure_dict_section(
         all_settings, CLAUDE_SETTINGS_AUTO_MODE_KEY
     )
@@ -83,6 +123,16 @@ def add_auto_mode_environment_entry(
 
 
 def grant_permissions_for_current_directory() -> None:
+    """Grant Edit/Write/Read permissions for the current project directory.
+
+    Reads the current project path, constructs permission rules from config
+    constants, and writes them to ~/.claude/settings.json atomically.
+
+    Raises:
+        SystemExit: When the current directory is not a valid project root.
+        ValueError: Propagated from get_current_project_path() when the path
+                    contains glob metacharacters.
+    """
     claude_user_settings_path: Path = get_claude_user_settings_path()
     project_root_path = Path.cwd()
     if not is_valid_project_root(project_root_path):

package/_shared/pr-loop/scripts/post_audit_thread.py

@@ -33,8 +33,8 @@ from pathlib import Path
 from typing import NoReturn
 
 sys.modules.pop("config", None)
-if str(Path(__file__).resolve().parent) not in sys.path:
-    sys.path.insert(0, str(Path(__file__).resolve().parent))
+if str(Path(__file__).absolute().parent) not in sys.path:
+    sys.path.insert(0, str(Path(__file__).absolute().parent))
 
 from config.post_audit_thread_constants import (
     ALL_GH_API_COMMAND_PARTS,

package/_shared/pr-loop/scripts/revoke_project_claude_permissions.py

@@ -10,9 +10,22 @@ autoMode sections so repeated grant/revoke cycles leave no dead structure.
 import sys
 from pathlib import Path
 
-sys.modules.pop("config", None)
-if str(Path(__file__).resolve().parent) not in sys.path:
-    sys.path.insert(0, str(Path(__file__).resolve().parent))
+parent_directory = str(Path(__file__).absolute().parent)
+try:
+    sys.path.remove(parent_directory)
+except ValueError:
+    pass
+if parent_directory not in sys.path:
+    sys.path.insert(0, parent_directory)
+
+for each_cached_module_name in [
+    each_module_key
+    for each_module_key in list(sys.modules)
+    if each_module_key == "config"
+    or each_module_key.startswith("config.")
+    or each_module_key == "_claude_permissions_common"
+]:
+    sys.modules.pop(each_cached_module_name, None)
 
 from _claude_permissions_common import (  # noqa: E402
     build_permission_rules,
@@ -40,6 +53,15 @@ from config.claude_settings_keys_constants import (  # noqa: E402
 def remove_values_from_list(
     all_target_list: list[object], all_values_to_remove: set[str]
 ) -> int:
+    """Remove matching values from a list in place.
+
+    Args:
+        all_target_list: The list to remove values from.
+        all_values_to_remove: Set of string values to remove.
+
+    Returns:
+        Number of values removed.
+    """
     original_length = len(all_target_list)
     all_target_list[:] = [
         each_value
@@ -52,6 +74,15 @@ def remove_values_from_list(
 def remove_rules_from_allow_list(
     all_settings: dict[str, object], all_rules_to_remove: list[str]
 ) -> int:
+    """Remove matching permission rules from the settings allow list.
+
+    Args:
+        all_settings: The parsed settings dictionary.
+        all_rules_to_remove: Permission rule strings to remove.
+
+    Returns:
+        Number of rules removed.
+    """
     permissions_section = all_settings.get(CLAUDE_SETTINGS_PERMISSIONS_KEY)
     if not isinstance(permissions_section, dict):
         return 0
@@ -64,6 +95,15 @@ def remove_rules_from_allow_list(
 def remove_directory_from_additional_directories(
     all_settings: dict[str, object], directory_path: str
 ) -> int:
+    """Remove a project path from the additionalDirectories list.
+
+    Args:
+        all_settings: The parsed settings dictionary.
+        directory_path: The project directory path to remove.
+
+    Returns:
+        1 when the entry was removed, 0 when not found.
+    """
     permissions_section = all_settings.get(CLAUDE_SETTINGS_PERMISSIONS_KEY)
     if not isinstance(permissions_section, dict):
         return 0
@@ -78,6 +118,15 @@ def remove_directory_from_additional_directories(
 def remove_auto_mode_environment_entry(
     all_settings: dict[str, object], entry_text: str
 ) -> int:
+    """Remove an auto-mode environment entry for the project.
+
+    Args:
+        all_settings: The parsed settings dictionary.
+        entry_text: The environment entry text to remove.
+
+    Returns:
+        1 when the entry was removed, 0 when not found.
+    """
     auto_mode_section = all_settings.get(CLAUDE_SETTINGS_AUTO_MODE_KEY)
     if not isinstance(auto_mode_section, dict):
         return 0
@@ -88,6 +137,11 @@ def remove_auto_mode_environment_entry(
 
 
 def prune_settings_after_revoke(all_settings: dict[str, object]) -> None:
+    """Remove empty lists and their parent sections after revoking entries.
+
+    Args:
+        all_settings: The parsed settings dictionary to prune in place.
+    """
     prune_empty_list_then_empty_section(
         all_settings,
         CLAUDE_SETTINGS_PERMISSIONS_KEY,
@@ -106,6 +160,17 @@ def prune_settings_after_revoke(all_settings: dict[str, object]) -> None:
 
 
 def revoke_permissions_for_current_directory() -> None:
+    """Revoke permissions previously granted for the current project directory.
+
+    Reads the current project path, constructs the matching permission rules,
+    removes them from ~/.claude/settings.json, and prunes any newly empty
+    sections.
+
+    Raises:
+        SystemExit: When the current directory is not a valid project root.
+        ValueError: Propagated from get_current_project_path() when the path
+                    contains glob metacharacters.
+    """
     claude_user_settings_path: Path = get_claude_user_settings_path()
     project_root_path = Path.cwd()
     if not is_valid_project_root(project_root_path):

package/_shared/pr-loop/scripts/tests/test_grant_project_claude_permissions.py

@@ -43,7 +43,7 @@ def test_grant_module_guards_sys_path_insert_against_duplicates() -> None:
     module_source = (
         Path(__file__).parent.parent / "grant_project_claude_permissions.py"
     ).read_text(encoding="utf-8")
-    assert "if str(Path(__file__).resolve().parent) not in sys.path:" in module_source, (
+    assert "if parent_directory not in sys.path:" in module_source, (
         "grant_project_claude_permissions.py must guard sys.path.insert against "
         "duplicate entries on reload (consistent with sibling modules)"
     )

package/_shared/pr-loop/scripts/tests/test_revoke_project_claude_permissions.py

@@ -43,7 +43,7 @@ def test_revoke_module_guards_sys_path_insert_against_duplicates() -> None:
     module_source = (
         Path(__file__).parent.parent / "revoke_project_claude_permissions.py"
     ).read_text(encoding="utf-8")
-    assert "if str(Path(__file__).resolve().parent) not in sys.path:" in module_source, (
+    assert "if parent_directory not in sys.path:" in module_source, (
         "revoke_project_claude_permissions.py must guard sys.path.insert against "
         "duplicate entries on reload (consistent with sibling modules)"
     )