claude-dev-env 1.37.1 → 1.38.1

package/hooks/blocking/test_code_rules_enforcer_unused_imports.py

@@ -30,6 +30,7 @@ assert _hook_spec.loader is not None
 _hook_module = importlib.util.module_from_spec(_hook_spec)
 _hook_spec.loader.exec_module(_hook_module)
 check_unused_module_level_imports = _hook_module.check_unused_module_level_imports
+_reconstruct_post_edit_file_content = _hook_module._reconstruct_post_edit_file_content
 
 
 PRODUCTION_FILE_PATH = "packages/app/services/loader.py"
@@ -297,6 +298,163 @@ def test_should_skip_when_noqa_is_bare() -> None:
     assert issues == [], f"Bare noqa must suppress unused import, got: {issues}"
 
 
+def test_should_not_flag_imports_referenced_only_in_full_file_content() -> None:
+    fragment = "from config.constants import NEW_NAME\n"
+    full_file = (
+        "from config.constants import NEW_NAME\n"
+        "\n"
+        "def existing_function() -> str:\n"
+        "    return NEW_NAME\n"
+    )
+    issues = check_unused_module_level_imports(
+        fragment, PRODUCTION_FILE_PATH, full_file_content=full_file,
+    )
+    assert issues == [], (
+        f"When the post-edit file references the import, it must not flag, got: {issues}"
+    )
+
+
+def test_should_flag_imports_unused_in_full_file_content() -> None:
+    fragment = "from config.constants import TRULY_UNUSED\n"
+    full_file = (
+        "from config.constants import TRULY_UNUSED\n"
+        "\n"
+        "def existing_function() -> None:\n"
+        "    return None\n"
+    )
+    issues = check_unused_module_level_imports(
+        fragment, PRODUCTION_FILE_PATH, full_file_content=full_file,
+    )
+    assert any("TRULY_UNUSED" in each_issue for each_issue in issues), (
+        f"Imports unused in the post-edit file must still flag, got: {issues}"
+    )
+
+
+def test_should_only_flag_imports_in_fragment_not_full_file() -> None:
+    fragment = "from config.constants import FRAGMENT_IMPORT\n"
+    full_file = (
+        "from config.other import PRE_EXISTING_UNUSED\n"
+        "from config.constants import FRAGMENT_IMPORT\n"
+        "\n"
+        "def existing_function() -> str:\n"
+        "    return FRAGMENT_IMPORT\n"
+    )
+    issues = check_unused_module_level_imports(
+        fragment, PRODUCTION_FILE_PATH, full_file_content=full_file,
+    )
+    assert issues == [], (
+        "Pre-existing imports outside the fragment must not be flagged on Edit; "
+        f"got: {issues}"
+    )
+
+
+def test_should_skip_when_full_file_declares_dunder_all() -> None:
+    fragment = "from config.constants import NEW_NAME\n"
+    full_file = (
+        "from config.constants import NEW_NAME\n"
+        "\n"
+        "__all__ = ['NEW_NAME']\n"
+    )
+    issues = check_unused_module_level_imports(
+        fragment, PRODUCTION_FILE_PATH, full_file_content=full_file,
+    )
+    assert issues == [], (
+        "__all__ in the post-edit file must skip the scan even when the fragment "
+        f"itself does not contain __all__, got: {issues}"
+    )
+
+
+def test_should_skip_when_full_file_uses_type_checking_gate() -> None:
+    fragment = "from config.constants import NEW_NAME\n"
+    full_file = (
+        "from typing import TYPE_CHECKING\n"
+        "from config.constants import NEW_NAME\n"
+        "\n"
+        "if TYPE_CHECKING:\n"
+        "    from somewhere import OtherName\n"
+        "\n"
+        "def run() -> None:\n"
+        "    return None\n"
+    )
+    issues = check_unused_module_level_imports(
+        fragment, PRODUCTION_FILE_PATH, full_file_content=full_file,
+    )
+    assert issues == [], (
+        "TYPE_CHECKING gate in the post-edit file must skip the scan, "
+        f"got: {issues}"
+    )
+
+
+def test_should_fall_back_to_content_when_full_file_content_is_none() -> None:
+    source = (
+        "from config.constants import VENV_DIRECTORY_NAME\n"
+        "\n"
+        "def run() -> None:\n"
+        "    return None\n"
+    )
+    issues = check_unused_module_level_imports(source, PRODUCTION_FILE_PATH, full_file_content=None)
+    assert any("VENV_DIRECTORY_NAME" in each_issue for each_issue in issues), (
+        f"Backward-compat: with full_file_content=None, behavior must match "
+        f"the existing single-argument scan, got: {issues}"
+    )
+
+
+def test_should_fall_back_when_full_file_content_has_syntax_error() -> None:
+    fragment = "from config.constants import NEW_NAME\n"
+    full_file_with_syntax_error = "from config import (\n  not python\n"
+    issues = check_unused_module_level_imports(
+        fragment, PRODUCTION_FILE_PATH, full_file_content=full_file_with_syntax_error,
+    )
+    assert issues == [], (
+        "When the reconstructed post-edit content cannot be parsed, return empty "
+        f"rather than raising, got: {issues}"
+    )
+
+
+def test_reconstruct_post_edit_returns_replaced_content(tmp_path: pathlib.Path) -> None:
+    target_file = tmp_path / "module.py"
+    target_file.write_text("ALPHA = 1\nBETA = 2\n", encoding="utf-8")
+    post_edit = _reconstruct_post_edit_file_content(
+        str(target_file), "BETA = 2", "BETA = 22\nGAMMA = 3",
+    )
+    assert post_edit == "ALPHA = 1\nBETA = 22\nGAMMA = 3\n", (
+        f"Helper must return the file body with the first occurrence replaced, got: {post_edit!r}"
+    )
+
+
+def test_reconstruct_post_edit_returns_none_when_file_missing(tmp_path: pathlib.Path) -> None:
+    missing_file = tmp_path / "does_not_exist.py"
+    post_edit = _reconstruct_post_edit_file_content(
+        str(missing_file), "any_old", "any_new",
+    )
+    assert post_edit is None, (
+        f"Missing file must yield None so the caller treats it as 'no full-file context', got: {post_edit!r}"
+    )
+
+
+def test_reconstruct_post_edit_returns_none_when_old_string_absent(tmp_path: pathlib.Path) -> None:
+    target_file = tmp_path / "module.py"
+    target_file.write_text("ALPHA = 1\n", encoding="utf-8")
+    post_edit = _reconstruct_post_edit_file_content(
+        str(target_file), "ZETA = 9", "OMEGA = 0",
+    )
+    assert post_edit is None, (
+        f"Absent old_string means the Edit will not apply cleanly — return None, got: {post_edit!r}"
+    )
+
+
+def test_reconstruct_post_edit_replaces_only_first_occurrence(tmp_path: pathlib.Path) -> None:
+    target_file = tmp_path / "module.py"
+    target_file.write_text("X = 1\nX = 1\n", encoding="utf-8")
+    post_edit = _reconstruct_post_edit_file_content(
+        str(target_file), "X = 1", "X = 2",
+    )
+    assert post_edit == "X = 2\nX = 1\n", (
+        "Edit replaces only the first occurrence; helper must mirror that, got: "
+        f"{post_edit!r}"
+    )
+
+
 def test_should_flag_import_when_only_shadowed_local_name_is_loaded() -> None:
     source = (
         "import json\n"

package/hooks/blocking/test_hedging_language_blocker.py

@@ -97,7 +97,7 @@ def test_hedging_reason_contains_not_installed_notice_when_skill_absent():
 
     assert parsed_response["decision"] == "block"
     assert "no research-mode skill installed" in parsed_response["reason"]
-    assert "verify with sources or reply" in parsed_response["reason"]
+    assert "verify with sources or prompt the user via AskUserQuestion" in parsed_response["reason"]
     assert "SKILL.md" not in parsed_response["reason"]
     assert RESEARCH_MODE_SKILL_BODY_MARKER not in parsed_response["reason"]