claude-dev-env 1.37.1 → 1.38.0

package/skills/pr-converge/scripts/test_view_pr_context.py

@@ -1,155 +0,0 @@
-"""Tests for view_pr_context.
-
-Covers:
-- gh pr view is invoked with the documented --json field list
-- the parsed JSON object is returned
-- subprocess errors propagate
-"""
-
-from __future__ import annotations
-
-import importlib.util
-import json
-import subprocess
-from pathlib import Path
-from types import ModuleType
-from unittest.mock import MagicMock, patch
-
-import pytest
-
-
-def _load_module() -> ModuleType:
-    module_path = Path(__file__).parent / "view_pr_context.py"
-    spec = importlib.util.spec_from_file_location("view_pr_context", module_path)
-    assert spec is not None
-    assert spec.loader is not None
-    module = importlib.util.module_from_spec(spec)
-    spec.loader.exec_module(module)
-    return module
-
-
-view_pr_context_module = _load_module()
-
-
-def _completed(stdout: str) -> subprocess.CompletedProcess:
-    process = MagicMock(spec=subprocess.CompletedProcess)
-    process.stdout = stdout
-    process.returncode = 0
-    return process
-
-
-def test_should_invoke_gh_pr_view_with_documented_field_list() -> None:
-    payload = json.dumps(
-        {
-            "number": 42,
-            "url": "https://github.com/acme/widget/pull/42",
-            "headRefOid": "abc123",
-            "baseRefName": "main",
-            "headRefName": "feat/x",
-            "isDraft": True,
-        }
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(payload)
-        view_pr_context_module.view_pr_context()
-    invoked_argv = mock_run.call_args[0][0]
-    assert invoked_argv[0:3] == ["gh", "pr", "view"]
-    assert "--json" in invoked_argv
-    fields_arg = invoked_argv[invoked_argv.index("--json") + 1]
-    for required_field in (
-        "number",
-        "url",
-        "headRefOid",
-        "baseRefName",
-        "headRefName",
-        "isDraft",
-    ):
-        assert required_field in fields_arg
-
-
-def test_should_return_parsed_json_object() -> None:
-    payload = {
-        "number": 42,
-        "url": "https://github.com/acme/widget/pull/42",
-        "headRefOid": "abc123",
-        "baseRefName": "main",
-        "headRefName": "feat/x",
-        "isDraft": True,
-    }
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(json.dumps(payload))
-        pr_context = view_pr_context_module.view_pr_context()
-    assert pr_context == payload
-
-
-def test_should_raise_when_gh_subprocess_fails() -> None:
-    failure = subprocess.CalledProcessError(
-        returncode=1, cmd=["gh"], stderr="auth failure"
-    )
-    with patch("subprocess.run", side_effect=failure):
-        with pytest.raises(subprocess.CalledProcessError):
-            view_pr_context_module.view_pr_context()
-
-
-def test_should_append_number_and_repo_flag_when_owner_repo_and_number_provided() -> None:
-    payload = json.dumps(
-        {
-            "number": 25,
-            "url": "https://github.com/acme/widget/pull/25",
-            "headRefOid": "abc123",
-            "baseRefName": "main",
-            "headRefName": "feat/x",
-            "isDraft": True,
-        }
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(payload)
-        view_pr_context_module.view_pr_context(number="25", owner="acme", repo="widget")
-    invoked_argv = mock_run.call_args[0][0]
-    assert "25" in invoked_argv
-    assert "--repo" in invoked_argv
-    assert "acme/widget" in invoked_argv
-
-
-def test_should_pass_imported_constant_directly_without_local_alias() -> None:
-    payload = json.dumps(
-        {
-            "number": 7,
-            "url": "https://github.com/acme/widget/pull/7",
-            "headRefOid": "deadbeef",
-            "baseRefName": "main",
-            "headRefName": "feat/y",
-            "isDraft": False,
-        }
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(payload)
-        view_pr_context_module.view_pr_context()
-    invoked_argv = mock_run.call_args[0][0]
-    fields_arg = invoked_argv[invoked_argv.index("--json") + 1]
-    expected_fields = view_pr_context_module.PR_CONTEXT_FIELDS
-    assert fields_arg is expected_fields
-
-
-def test_should_not_exit_when_number_provided_alone() -> None:
-    payload = json.dumps(
-        {
-            "number": 42,
-            "url": "https://github.com/acme/widget/pull/42",
-            "headRefOid": "abc123",
-            "baseRefName": "main",
-            "headRefName": "feat/x",
-            "isDraft": True,
-        }
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(payload)
-        with patch("sys.argv", ["view_pr_context.py", "--number", "42"]):
-            return_code = view_pr_context_module.main()
-    assert return_code == 0
-
-
-def test_should_exit_when_owner_and_repo_provided_without_number() -> None:
-    with patch("sys.argv", ["view_pr_context.py", "--owner", "acme", "--repo", "widget"]):
-        with pytest.raises(SystemExit):
-            view_pr_context_module.main()

package/skills/pr-converge/scripts/trigger_bugbot.py

@@ -1,77 +0,0 @@
-"""Post a `bugbot run` comment to re-trigger a Cursor Bugbot review.
-
-Writes the literal trigger phrase to a temp file (per the gh-body-file rule —
-`gh pr comment --body "..."` may corrupt backticks), invokes
-`gh pr comment --body-file`, and removes the temp file on success or failure.
-"""
-
-import argparse
-import os
-import subprocess
-import sys
-import tempfile
-from pathlib import Path
-
-if str(Path(__file__).resolve().parent) not in sys.path:
-    sys.path.insert(0, str(Path(__file__).resolve().parent))
-
-from evict_cached_config_modules import evict_cached_config_modules
-
-evict_cached_config_modules()
-
-from config.pr_converge_constants import (
-    BUGBOT_RUN_TEMPFILE_PREFIX,
-    BUGBOT_RUN_TEMPFILE_SUFFIX,
-    BUGBOT_RUN_TRIGGER_PHRASE,
-    GH_REPO_ARG_TEMPLATE,
-)
-
-
-def trigger_bugbot(*, owner: str, repo: str, number: int) -> str:
-    """Post the bugbot re-trigger comment, return the comment URL gh emits."""
-    file_descriptor, raw_path = tempfile.mkstemp(
-        suffix=BUGBOT_RUN_TEMPFILE_SUFFIX, prefix=BUGBOT_RUN_TEMPFILE_PREFIX
-    )
-    try:
-        os.close(file_descriptor)
-        body_file_path = Path(raw_path)
-        body_file_path.write_text(BUGBOT_RUN_TRIGGER_PHRASE, encoding="utf-8")
-        repo_arg = GH_REPO_ARG_TEMPLATE.format(owner=owner, repo=repo)
-        gh_command: list[str] = [
-            "gh",
-            "pr",
-            "comment",
-            str(number),
-            "--repo",
-            repo_arg,
-            "--body-file",
-            str(body_file_path),
-        ]
-        completed = subprocess.run(
-            gh_command,
-            capture_output=True,
-            check=True,
-            text=True,
-            encoding="utf-8",
-            errors="replace",
-        )
-        return completed.stdout.strip()
-    finally:
-        Path(raw_path).unlink(missing_ok=True)
-
-
-def main() -> int:
-    parser = argparse.ArgumentParser(description=__doc__)
-    parser.add_argument("--owner", required=True)
-    parser.add_argument("--repo", required=True)
-    parser.add_argument("--number", required=True, type=int)
-    parsed_arguments = parser.parse_args()
-    comment_url = trigger_bugbot(
-        owner=parsed_arguments.owner, repo=parsed_arguments.repo, number=parsed_arguments.number
-    )
-    sys.stdout.write(f"{comment_url}\n")
-    return 0
-
-
-if __name__ == "__main__":
-    sys.exit(main())

package/skills/pr-converge/scripts/view_pr_context.py

@@ -1,78 +0,0 @@
-"""Resolve the per-tick PR context (number, url, head sha, branch names, draft state).
-
-Wraps `gh pr view --json ...` so the skill body emits one script invocation
-instead of repeating the field list inline.
-"""
-
-import argparse
-import json
-import subprocess
-import sys
-from pathlib import Path
-
-if str(Path(__file__).resolve().parent) not in sys.path:
-    sys.path.insert(0, str(Path(__file__).resolve().parent))
-
-from evict_cached_config_modules import evict_cached_config_modules
-
-evict_cached_config_modules()
-
-from config.pr_converge_constants import (
-    GH_REPO_ARG_TEMPLATE,
-    GH_REPO_FLAG,
-    PR_CONTEXT_FIELDS,
-    PR_DETACHED_HEAD_ARGS_ERROR,
-    PR_NUMBER_ARG_FLAG,
-    PR_NUMBER_ARG_HELP,
-    PR_OWNER_ARG_FLAG,
-    PR_OWNER_ARG_HELP,
-    PR_REPO_ARG_FLAG,
-    PR_REPO_ARG_HELP,
-)
-
-
-def view_pr_context(
-    number: str | None = None,
-    owner: str | None = None,
-    repo: str | None = None,
-) -> dict[str, object]:
-    """Return the parsed JSON object from `gh pr view --json <fields>`."""
-    gh_command: list[str] = ["gh", "pr", "view", "--json", PR_CONTEXT_FIELDS]
-    if owner and repo and number:
-        gh_command.append(number)
-        gh_command.append(GH_REPO_FLAG)
-        gh_command.append(GH_REPO_ARG_TEMPLATE.format(owner=owner, repo=repo))
-    elif number:
-        gh_command.append(number)
-    completed = subprocess.run(
-        gh_command,
-        capture_output=True,
-        check=True,
-        text=True,
-        encoding="utf-8",
-        errors="replace",
-    )
-    return json.loads(completed.stdout)
-
-
-def main() -> int:
-    parser = argparse.ArgumentParser(description=__doc__)
-    parser.add_argument(PR_NUMBER_ARG_FLAG, default=None, help=PR_NUMBER_ARG_HELP)
-    parser.add_argument(PR_OWNER_ARG_FLAG, default=None, help=PR_OWNER_ARG_HELP)
-    parser.add_argument(PR_REPO_ARG_FLAG, default=None, help=PR_REPO_ARG_HELP)
-    parsed = parser.parse_args()
-    number = (parsed.number.strip() or None) if parsed.number else None
-    owner = (parsed.owner.strip() or None) if parsed.owner else None
-    repo = (parsed.repo.strip() or None) if parsed.repo else None
-    needs_repo = owner is not None or repo is not None
-    has_all = number is not None and owner is not None and repo is not None
-    if needs_repo and not has_all:
-        parser.error(PR_DETACHED_HEAD_ARGS_ERROR)
-    pr_context = view_pr_context(number=number, owner=owner, repo=repo)
-    json.dump(pr_context, sys.stdout)
-    sys.stdout.write("\n")
-    return 0
-
-
-if __name__ == "__main__":
-    sys.exit(main())

package/skills/pr-review-responder/scripts/respond_to_reviews.py

@@ -1,376 +0,0 @@
-#!/usr/bin/env python3
-"""
-Standalone script to respond to GitHub PR review comments.
-
-Usage:
-    python respond_to_reviews.py [--pr PR_NUMBER] [--auto-approve]
-
-Requirements:
-    - gh CLI installed and authenticated
-    - Git repository with GitHub remote
-    - Python 3.8+
-"""
-
-import json
-import subprocess
-import sys
-from dataclasses import dataclass
-from pathlib import Path
-from typing import Dict, List, Optional, Set
-
-
-@dataclass
-class ReviewComment:
-    id: int
-    path: str
-    line: int
-    body: str
-    user: str
-    created_at: str
-    in_reply_to: Optional[int]
-
-
-@dataclass
-class FileChange:
-    path: str
-    lines_changed: Set[int]
-    diff: str
-
-
-def run_command(cmd: List[str]) -> str:
-    """Run shell command and return output."""
-    try:
-        result = subprocess.run(
-            cmd,
-            capture_output=True,
-            text=True,
-            check=True
-        )
-        return result.stdout.strip()
-    except subprocess.CalledProcessError as e:
-        print(f"Error running command: {' '.join(cmd)}", file=sys.stderr)
-        print(f"Error: {e.stderr}", file=sys.stderr)
-        sys.exit(1)
-
-
-def get_current_pr() -> Optional[Dict]:
-    """Get PR number for current branch."""
-    output = run_command(['gh', 'pr', 'view', '--json', 'number,title,url'])
-    if not output:
-        return None
-    return json.loads(output)
-
-
-def get_review_comments(pr_number: int, repo: str) -> List[ReviewComment]:
-    """Fetch all review comments from PR."""
-    cmd = [
-        'gh', 'api',
-        f'repos/{repo}/pulls/{pr_number}/comments',
-        '--jq',
-        '.[] | {id, path, line, body, user: .user.login, created_at, in_reply_to}'
-    ]
-    output = run_command(cmd)
-
-    comments = []
-    for line in output.split('\n'):
-        if not line:
-            continue
-        data = json.loads(line)
-        comments.append(ReviewComment(
-            id=data['id'],
-            path=data['path'],
-            line=data['line'],
-            body=data['body'],
-            user=data['user'],
-            created_at=data['created_at'],
-            in_reply_to=data.get('in_reply_to')
-        ))
-
-    return comments
-
-
-def get_current_user() -> str:
-    """Get current GitHub username."""
-    return run_command(['gh', 'api', 'user', '--jq', '.login'])
-
-
-def filter_unresponded_comments(
-    comments: List[ReviewComment],
-    current_user: str
-) -> List[ReviewComment]:
-    """Filter for comments that haven't been responded to."""
-    # Group comments by thread (in_reply_to chain)
-    threads: Dict[int, List[ReviewComment]] = {}
-
-    for comment in comments:
-        if comment.in_reply_to is None:
-            # Top-level comment
-            thread_id = comment.id
-        else:
-            # Reply to another comment
-            thread_id = comment.in_reply_to
-
-        if thread_id not in threads:
-            threads[thread_id] = []
-        threads[thread_id].append(comment)
-
-    # Find threads where we haven't replied
-    unresponded = []
-    for thread_id, thread_comments in threads.items():
-        # Check if current user has replied in this thread
-        user_replied = any(c.user == current_user for c in thread_comments)
-
-        if not user_replied:
-            # Find the original comment (first in thread)
-            original = min(thread_comments, key=lambda c: c.created_at)
-            if original.user != current_user:
-                unresponded.append(original)
-
-    return unresponded
-
-
-def get_changed_files() -> List[FileChange]:
-    """Get files changed in the last commit."""
-    # Get list of changed files
-    files_output = run_command(['git', 'diff', '--name-only', 'HEAD~1..HEAD'])
-
-    changes = []
-    for file_path in files_output.split('\n'):
-        if not file_path:
-            continue
-
-        # Get diff for this file
-        diff = run_command(['git', 'diff', 'HEAD~1..HEAD', '--', file_path])
-
-        # Parse changed line numbers from diff
-        lines_changed = set()
-        for line in diff.split('\n'):
-            if line.startswith('@@'):
-                # Parse @@ -old_start,old_count +new_start,new_count @@
-                parts = line.split(' ')
-                if len(parts) >= 3:
-                    new_range = parts[2]  # +new_start,new_count
-                    if ',' in new_range:
-                        start, count = new_range[1:].split(',')
-                        start_line = int(start)
-                        count_lines = int(count)
-                        lines_changed.update(range(start_line, start_line + count_lines))
-
-        changes.append(FileChange(
-            path=file_path,
-            lines_changed=lines_changed,
-            diff=diff
-        ))
-
-    return changes
-
-
-def match_comments_to_changes(
-    comments: List[ReviewComment],
-    changes: List[FileChange]
-) -> List[tuple[ReviewComment, FileChange]]:
-    """Match review comments to file changes."""
-    matches = []
-
-    changes_by_path = {c.path: c for c in changes}
-
-    for comment in comments:
-        if comment.path in changes_by_path:
-            change = changes_by_path[comment.path]
-            # Check if the commented line was changed
-            if comment.line in change.lines_changed or not change.lines_changed:
-                # Either the exact line changed, or we changed the file (good enough)
-                matches.append((comment, change))
-
-    return matches
-
-
-def draft_response(comment: ReviewComment, change: FileChange) -> str:
-    """Draft a concise response to a review comment."""
-    # Analyze the diff to understand what changed
-    diff_lines = change.diff.split('\n')
-
-    # Look for common patterns
-    if 'class ' in change.diff and '- class ' in change.diff:
-        return "Removed wrapper class, using direct approach"
-
-    if 'def ' in change.diff:
-        if '+ def ' in change.diff:
-            return "Extracted to shared function"
-        if 'Type[' in change.diff or ': ' in change.diff:
-            return "Added type hints"
-
-    if 'import ' in change.diff:
-        return "Updated imports"
-
-    if '.css' in comment.path or 'style' in change.diff:
-        return "Moved CSS values to stylesheet"
-
-    if 'select_related' in change.diff or 'prefetch_related' in change.diff:
-        return "Added query optimization to eliminate N+1"
-
-    if comment.path.endswith('.py'):
-        # Generic Python change
-        return f"Updated {Path(comment.path).name}"
-
-    # Generic fallback
-    return f"Addressed feedback in {comment.path}"
-
-
-def post_response(comment_id: int, response: str, repo: str) -> bool:
-    """Post response to GitHub review comment."""
-    formatted_response = f"✅ **Fixed**: {response}"
-
-    try:
-        run_command([
-            'gh', 'api',
-            f'repos/{repo}/pulls/comments/{comment_id}/replies',
-            '-X', 'POST',
-            '-f', f'body={formatted_response}'
-        ])
-        return True
-    except Exception as e:
-        print(f"Failed to post response: {e}", file=sys.stderr)
-        return False
-
-
-def get_repo_name() -> str:
-    """Get owner/repo from git remote."""
-    remote_url = run_command(['git', 'remote', 'get-url', 'origin'])
-
-    # Parse GitHub URL
-    # SSH: git@github.com:owner/repo.git
-    # HTTPS: https://github.com/owner/repo.git
-
-    if 'github.com' not in remote_url:
-        print("Error: Not a GitHub repository", file=sys.stderr)
-        sys.exit(1)
-
-    if remote_url.startswith('git@'):
-        # SSH format
-        repo_part = remote_url.split(':')[1]
-    else:
-        # HTTPS format
-        repo_part = '/'.join(remote_url.split('/')[-2:])
-
-    # Remove .git suffix
-    return repo_part.replace('.git', '')
-
-
-def main():
-    import argparse
-
-    parser = argparse.ArgumentParser(
-        description='Respond to GitHub PR review comments'
-    )
-    parser.add_argument(
-        '--pr',
-        type=int,
-        help='PR number (auto-detected if not provided)'
-    )
-    parser.add_argument(
-        '--auto-approve',
-        action='store_true',
-        help='Auto-approve all responses without confirmation'
-    )
-
-    args = parser.parse_args()
-
-    # Get PR number
-    if args.pr:
-        pr_number = args.pr
-        pr_title = f"PR #{pr_number}"
-        pr_url = ""
-    else:
-        pr = get_current_pr()
-        if not pr:
-            print("Error: No PR found for current branch", file=sys.stderr)
-            print("Create a PR first or specify --pr NUMBER", file=sys.stderr)
-            sys.exit(1)
-        pr_number = pr['number']
-        pr_title = pr['title']
-        pr_url = pr['url']
-
-    print(f"Checking PR #{pr_number}: {pr_title}")
-    if pr_url:
-        print(f"URL: {pr_url}")
-    print()
-
-    # Get repository name
-    repo = get_repo_name()
-
-    # Get current user
-    current_user = get_current_user()
-
-    # Fetch review comments
-    print("Fetching review comments...")
-    all_comments = get_review_comments(pr_number, repo)
-    print(f"Found {len(all_comments)} total review comments")
-
-    # Filter for unresponded comments
-    unresponded = filter_unresponded_comments(all_comments, current_user)
-    print(f"Found {len(unresponded)} unresponded comments")
-
-    if not unresponded:
-        print("\nNo unresponded comments found!")
-        return
-
-    # Get changed files
-    print("\nAnalyzing recent changes...")
-    changes = get_changed_files()
-    print(f"Found {len(changes)} changed files in last commit")
-
-    # Match comments to changes
-    matches = match_comments_to_changes(unresponded, changes)
-
-    if not matches:
-        print("\nNo review comments match your recent changes.")
-        print(f"\nReview comments are about:")
-        for comment in unresponded:
-            print(f"  - {comment.path}:{comment.line}")
-        print(f"\nBut you changed:")
-        for change in changes:
-            print(f"  - {change.path}")
-        return
-
-    # Draft responses
-    print(f"\nFound {len(matches)} review comments addressed:\n")
-
-    responses = []
-    for i, (comment, change) in enumerate(matches, 1):
-        response = draft_response(comment, change)
-        responses.append((comment, response))
-
-        print(f"{i}. @{comment.user} on {comment.path}:{comment.line}")
-        print(f"   Comment: {comment.body[:80]}...")
-        print(f"   Response: ✅ **Fixed**: {response}")
-        print()
-
-    # Get approval
-    if not args.auto_approve:
-        answer = input(f"Post these {len(responses)} responses to the PR? (y/n) ")
-        if answer.lower() != 'y':
-            print("Cancelled.")
-            return
-
-    # Post responses
-    print("\nPosting responses...")
-    success_count = 0
-
-    for comment, response in responses:
-        if post_response(comment.id, response, repo):
-            print(f"  ✓ {comment.path}:{comment.line}")
-            success_count += 1
-        else:
-            print(f"  ✗ {comment.path}:{comment.line}")
-
-    print(f"\nPosted {success_count}/{len(responses)} responses to PR #{pr_number}")
-
-    if pr_url:
-        print(f"View PR: {pr_url}")
-
-    print("\nReady to push!")
-
-
-if __name__ == '__main__':
-    main()