claude-dev-env 1.36.2 → 1.37.0

package/skills/pr-converge/scripts/test_reviewer_specs.py

@@ -0,0 +1,107 @@
+"""Tests for reviewer_specs.
+
+Covers:
+- each ReviewerSpec instance carries the documented login_filter_substring
+- bugbot_spec.classify_review uses the dirty-body regex
+- copilot_spec.classify_review dispatches off review state plus body
+- claude_spec.classify_review dispatches off review state plus body
+"""
+
+from __future__ import annotations
+
+import importlib.util
+from pathlib import Path
+from types import ModuleType
+
+
+def _load_module() -> ModuleType:
+    module_path = Path(__file__).parent / "reviewer_specs.py"
+    spec = importlib.util.spec_from_file_location("reviewer_specs", module_path)
+    assert spec is not None
+    assert spec.loader is not None
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+reviewer_specs_module = _load_module()
+
+
+def test_bugbot_spec_uses_cursor_login_filter_substring() -> None:
+    assert reviewer_specs_module.bugbot_spec.login_filter_substring == "cursor"
+
+
+def test_copilot_spec_uses_copilot_login_filter_substring() -> None:
+    assert reviewer_specs_module.copilot_spec.login_filter_substring == "copilot"
+
+
+def test_claude_spec_uses_claude_login_filter_substring() -> None:
+    assert reviewer_specs_module.claude_spec.login_filter_substring == "claude"
+
+
+def test_bugbot_classify_returns_dirty_when_body_matches_findings_pattern() -> None:
+    review_payload = {
+        "body": "Cursor Bugbot has reviewed your changes and found 2 potential issues.",
+    }
+    assert reviewer_specs_module.bugbot_spec.classify_review(review_payload) == "dirty"
+
+
+def test_bugbot_classify_returns_clean_when_body_lacks_findings_pattern() -> None:
+    review_payload = {
+        "body": "Bugbot reviewed your changes and found no new issues!",
+    }
+    assert reviewer_specs_module.bugbot_spec.classify_review(review_payload) == "clean"
+
+
+def test_copilot_classify_returns_clean_when_state_is_approved() -> None:
+    review_payload = {"state": "APPROVED", "body": "lgtm"}
+    assert reviewer_specs_module.copilot_spec.classify_review(review_payload) == "clean"
+
+
+def test_copilot_classify_returns_dirty_when_state_is_changes_requested() -> None:
+    review_payload = {"state": "CHANGES_REQUESTED", "body": "fix this"}
+    assert reviewer_specs_module.copilot_spec.classify_review(review_payload) == "dirty"
+
+
+def test_copilot_classify_returns_dirty_when_state_is_commented_with_body() -> None:
+    review_payload = {"state": "COMMENTED", "body": "minor nit"}
+    assert reviewer_specs_module.copilot_spec.classify_review(review_payload) == "dirty"
+
+
+def test_copilot_classify_returns_clean_when_state_is_commented_with_empty_body() -> (
+    None
+):
+    review_payload = {"state": "COMMENTED", "body": ""}
+    assert reviewer_specs_module.copilot_spec.classify_review(review_payload) == "clean"
+
+
+def test_copilot_classify_returns_clean_when_state_is_unknown() -> None:
+    review_payload = {"state": "DISMISSED", "body": "ignored"}
+    assert reviewer_specs_module.copilot_spec.classify_review(review_payload) == "clean"
+
+
+def test_claude_classify_returns_clean_when_state_is_approved() -> None:
+    review_payload = {"state": "APPROVED", "body": "lgtm"}
+    assert reviewer_specs_module.claude_spec.classify_review(review_payload) == "clean"
+
+
+def test_claude_classify_returns_dirty_when_state_is_changes_requested() -> None:
+    review_payload = {"state": "CHANGES_REQUESTED", "body": "fix this"}
+    assert reviewer_specs_module.claude_spec.classify_review(review_payload) == "dirty"
+
+
+def test_claude_classify_returns_dirty_when_state_is_commented_with_body() -> None:
+    review_payload = {"state": "COMMENTED", "body": "minor nit"}
+    assert reviewer_specs_module.claude_spec.classify_review(review_payload) == "dirty"
+
+
+def test_claude_classify_returns_clean_when_state_is_commented_with_empty_body() -> (
+    None
+):
+    review_payload = {"state": "COMMENTED", "body": ""}
+    assert reviewer_specs_module.claude_spec.classify_review(review_payload) == "clean"
+
+
+def test_claude_classify_returns_clean_when_state_is_unknown() -> None:
+    review_payload = {"state": "DISMISSED", "body": "ignored"}
+    assert reviewer_specs_module.claude_spec.classify_review(review_payload) == "clean"

package/skills/pr-converge/workflows/schedule-wakeup-loop.md

@@ -1,37 +1,39 @@
 # ScheduleWakeup loop pacing (pr-converge)
 
-Load this document when **`ScheduleWakeup` is available** in the parent harness session and you use it for converge **loop pacing** (primary /
-  orchestrated-teams path). Follow it for **every** instruction below that depends on that choice. Shared bugbot / bugteam / Fix protocol steps
-  stay in the main `SKILL.md`.
+Load this document for converge **loop pacing**. The pre-flight in `SKILL.md`
+guarantees `ScheduleWakeup` is available before any tick runs. Shared bugbot
+/ bugteam / Fix protocol steps stay in the main `SKILL.md`.
 
 ## Session behavior
 
-Call `ScheduleWakeup` from this same session so the next tick fires back into **this** transcript with the prior tick's state line and PR
-  context still addressable.
+Call `ScheduleWakeup` from this same session so the next tick fires back into **this** transcript with the prior tick's state line and PR context still addressable.
 
-## Step 4 — `ScheduleWakeup` branch
+## Calling ScheduleWakeup
 
-At end of tick (unless convergence or another stop condition already omitted pacing), call `ScheduleWakeup` with:
+At end of tick (unless convergence or another stop condition already
+omitted pacing), call `ScheduleWakeup` with:
 
-- `delaySeconds: 270` whenever bugbot was just re-triggered (whether by Step 3 directly, by the Fix protocol's mandatory re-trigger, or by
-  BUGTEAM branch 1's same-tick re-trigger). Bugbot finishes a review in 1–4 minutes, so 270s stays under the 5-minute prompt-cache TTL while
-  giving a margin past bugbot's typical upper bound. The single exception is the BUGBOT inline-lag branch in Step 2 of the main skill, which
-  uses `delaySeconds: 60` because no re-trigger fired and the only thing being awaited is GitHub's inline-comments API catching up.
-- `reason`: one short sentence on what is being awaited, including the current `phase` and `bugbot_clean_at` SHA when set.
-- `prompt: "/pr-converge"` — re-enters this skill on the next firing with default loop semantics (no need for the user to type `/loop`). If
-  the parent harness requires the `/loop` wrapper for wakeups to execute, `prompt: "/loop /pr-converge"` is equivalent.
+- `delaySeconds: 270` whenever bugbot was just re-triggered (by the
+  bugbot re-trigger in `../reference/per-tick.md`, by Fix protocol's
+  mandatory re-trigger, or by BUGTEAM's same-tick re-trigger). Bugbot
+  finishes a review in 1–4 minutes, so 270s stays under the 5-minute
+  prompt-cache TTL with margin past bugbot's typical upper bound. The
+  exception is the BUGBOT inline-lag branch (see below).
+- `reason`: one short sentence on what is being awaited, including the
+  current `phase` and `bugbot_clean_at` SHA when set.
+- `prompt: "/pr-converge"` — re-enters this skill on the next firing.
 
-## BUGBOT inline-lag (this path only)
+## BUGBOT inline-lag
 
-When Step 2 BUGBOT branch c routes to API lag and you are on **this** pacing path: complete Step 4 with `ScheduleWakeup` using `delaySeconds:
-  60` (lag is short-lived).
+See [`../reference/per-tick.md`](../reference/per-tick.md) — the BUGBOT
+inline-lag branch (review body says findings, inline API returns zero
+matching for `current_head`) uses `delaySeconds: 90` because no
+re-trigger fired and only GitHub's inline-comments API needs to catch up.
 
 ## Convergence
 
-On back-to-back clean: **omit** further `ScheduleWakeup` calls. Do not start the AHK auto-typer for loop pacing when this path is the active
-  pacer.
+On convergence: **omit** further `ScheduleWakeup` calls.
 
-## Stop / safety (this path)
+## Stop / safety
 
-On hard blockers or user stop: omit `ScheduleWakeup` per main skill **Stop conditions**. If the session never used AHK for pacing,
-  skip AHK shutdown commands in the companion AHK workflow.
+On hard blockers or user stop: omit `ScheduleWakeup` per main skill **Stop conditions**.

package/skills/bugteam/reference/workflow-path-a-orchestrated-teams.md

@@ -1,113 +0,0 @@
-# Bugteam — Path A workflow (orchestrated teams)
-
-Load when bugteam `SKILL.md` **Path routing** selects **Path A** (`CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS` equals **`1`** after trim). Execute **after** shared `SKILL.md` steps through **Step 2 loop state**; then use this file for **harness-only** steps. Shared gate scripts, Step 3 cycle numbering, Step 2.5 `jq`/`gh` payload shapes, `PROMPTS.md`, and outcome XML rules remain in **`SKILL.md`**.
-
-## Step 2 harness — lifecycle, `TeamCreate`, and team metadata
-
-**This session is the lead.** Step 2 first resolves the team lifecycle from the [Team lifecycle](../SKILL.md#team-lifecycle-path-a-only) table in `SKILL.md`, then either creates or attaches to a team.
-
-**Lifecycle resolution (read once, then apply):**
-
-```python
-import os
-import re
-
-mode = os.environ.get("BUGTEAM_TEAM_LIFECYCLE", "auto").strip().lower() or "auto"
-attached_team_name = os.environ.get("BUGTEAM_TEAM_NAME", "").strip()
-
-if mode == "attach" and not attached_team_name:
-    raise RuntimeError(
-        "BUGTEAM_TEAM_LIFECYCLE=attach requires BUGTEAM_TEAM_NAME to name an existing team."
-    )
-```
-
-The mode then drives Step 2's `TeamCreate` decision:
-
-- **`mode == "attach"`** — skip `TeamCreate` entirely. Set `team_name = attached_team_name`, `team_owned = false`. Continue to teammate spawns using that `team_name`.
-
-- **`mode == "owned"`** — call `TeamCreate(team_name=<computed_team_name>, ...)` (form below). On the runtime error matching `Already leading team "(.+)"\.` → **fail** with `Already leading team <existing>; rerun with BUGTEAM_TEAM_LIFECYCLE=attach BUGTEAM_TEAM_NAME=<existing>`. On success, set `team_owned = true`.
-
-- **`mode == "auto"`** (default) — call `TeamCreate(team_name=<computed_team_name>, ...)`. On the same runtime error, parse the existing team name with the regex `r'Already leading team "([^"]+)"'`, set `team_name = <existing>`, `team_owned = false`, and continue without retrying `TeamCreate`. On success, set `team_owned = true`. Both branches honor §Team name below.
-
-**`TeamCreate` call shape (only when `mode != "attach"` and the auto branch did not already attach):**
-
-```
-TeamCreate(
-  team_name="<computed_team_name>",
-  description="Bugteam audit/fix loop for PR <number> (<owner>/<repo>)",
-  agent_type="team-lead"
-)
-```
-
-**Team name:** For a single-PR invocation use `bugteam-pr-<number>-<YYYYMMDDHHMMSS>`. For a multi-PR invocation use `bugteam-<YYYYMMDDHHMMSS>`. The timestamp is captured once at team-creation time. Apply the no-PR fallback (`bugteam-<sanitized-head>-<YYYYMMDDHHMMSS>`) only when no PR resolves at all. `TeamCreate` implements natural-language team creation ([`sources.md`](../sources.md) § Team creation in natural language).
-
-**Sanitize head branch (no-PR only):** replace characters outside `[A-Za-z0-9._-]` with `-` (e.g. `feat/foo*bar` → `feat-foo-bar`). Apply once; reuse everywhere below.
-
-**`<team_temp_dir>`:** `Path(tempfile.gettempdir()) / team_name` (lead resolves once to an absolute path; every shell gets that literal string).
-
-**Roles (spawned per loop, not here):** bugfind → `code-quality-agent` opus (4.7) at xhigh effort; bugfix → `clean-coder` opus (4.7) at xhigh effort. `model="opus"` resolves to Opus 4.7 on the Anthropic API and runs at the model's default `xhigh` effort level — see [`CONSTRAINTS.md`](../CONSTRAINTS.md) § **Opus 4.7 at xhigh effort for both teammates** for rationale. **Display:** inherit `teammateMode` from `~/.claude.json`. Reference subagent types by name when spawning teammates ([`sources.md`](../sources.md) § Referencing subagent types when spawning teammates).
-
-**Optional Groq-backed FIX path (explicit opt-in only):** when the user explicitly sets `BUGTEAM_FIX_IMPLEMENTER=groq-coder` before invocation, spawn the FIX teammate with `subagent_type="groq-coder"`. Before Step 3, `groq_bugteam.py` loads `packages/claude-dev-env/.env` when that file exists (gitignored; start from `packages/claude-dev-env/.env.example`). If `GROQ_API_KEY` is still unset after that load, stop and prompt the user to create `packages/claude-dev-env/.env` from the example path above—do not continue the Groq path without a key. Any other `BUGTEAM_FIX_IMPLEMENTER` value (or unset) keeps `clean-coder` on Opus. The FIX spawn XML in [`PROMPTS.md`](../PROMPTS.md) is identical for both implementers.
-
-**`--bugbot-retrigger` flag:** when present on the `/bugteam` invocation, after every successful FIX push in Step 3, post an additional `bugbot run` issue comment via the Step 2.5 issue-comments fallback endpoint (`POST .../issues/{issue}/comments`) to re-trigger Cursor's bugbot on the new commit. Omit when the flag is absent.
-
-## Step 2.5 — who posts (Path A)
-
-**Bugfind** posts one `POST .../pulls/<n>/reviews` per loop after audit. **Bugfix** posts `.../comments/<id>/replies` after push. The **lead’s** only PR write before Step 4.5 is unchanged from `SKILL.md` (Step 4.5 body edit).
-
-## AUDIT spawn (Path A)
-
-After shared setup in `SKILL.md` (`mkdir`, `gh pr diff`):
-
-```
-Agent(
-  subagent_type="code-quality-agent",
-  name="bugfind-pr<N>-loop<L>",
-  team_name="<team_name>",
-  model="opus",
-  description="Bugfind audit PR <N> loop <L>",
-  prompt="<audit XML; see PROMPTS.md>"
-)
-```
-
-Fresh `Agent` each loop; teammate context excludes lead history ([`sources.md`](../sources.md) § Teammate context isolation). [`PROMPTS.md`](../PROMPTS.md): XML + outcome schema. Lead reads `.bugteam-pr<N>-loop<L>.outcomes.xml`, fills `loop_comment_index` per `SKILL.md`.
-
-**Shutdown:** If `Agent` returned and the teammate already ended, skip. Otherwise:
-
-```
-SendMessage(
-  to="bugfind-pr<N>-loop<L>",
-  message={"type": "shutdown_request", "reason": "audit PR <N> loop <L> complete; outcome XML captured"}
-)
-```
-
-`approve: false` → `error: bugfind teammate refused shutdown` → Step 4 then 5 per `SKILL.md`.
-
-**Parallel auditors (`loop_count >= 4`):** after three full audit/fix rounds without convergence, issue three `Agent` calls in one assistant message with `team_name="<team_name>"` per `SKILL.md` § parallel variant naming (`-a` / `-b` / `-c`). Shutdown: parallel `SendMessage` to `b` and `c`, then `a`.
-
-## FIX spawn (Path A)
-
-```
-Agent(
-  subagent_type="clean-coder",
-  name="bugfix-pr<N>-loop<L>",
-  team_name="<team_name>",
-  model="opus",
-  description="Bugfix PR <N> loop <L>",
-  prompt="<fix XML; see PROMPTS.md>"
-)
-```
-
-**Shutdown:** same pattern as AUDIT; `SendMessage(to="bugfix-pr<N>-loop<L>", message={"type": "shutdown_request", "reason": "fix PR <N> loop <L> complete; commit <sha7> pushed"})`. `approve: false` → `error: bugfix teammate refused shutdown` → Step 4 then 5.
-
-Verify and outcome handling: unchanged from `SKILL.md` § FIX action (**Verify**, stuck message, [`PROMPTS.md`](../PROMPTS.md)).
-
-## Step 4 harness — after worktree remove, before shared `rmtree`
-
-Run **after** `SKILL.md` § Step 4 step 1 (`git worktree remove` for each PR).
-
-1. For each live teammate **spawned by this invocation**: `SendMessage(to="<name>", message={"type": "shutdown_request", "reason": "bugteam cycle ending"})`. `approve: false` on cleanup → log and continue. Teammates that pre-existed an attached team (mode `attach` or `auto` after the attach branch) are owned by the orchestrator, not this invocation — leave them alone.
-
-2. `TeamDelete()` — **only when `team_owned=true`** (set in Step 2 lifecycle resolution). When `team_owned=false`, **skip `TeamDelete`** and log `cleanup: skipped TeamDelete (team not owned by this invocation; lifecycle=<mode>)`. The orchestrator that originally created the team owns teardown — see [Team lifecycle](../SKILL.md#team-lifecycle-path-a-only).
-
-Then continue with `SKILL.md` § Step 4 step 3 (`<team_temp_dir>` cleanup, also gated on `team_owned`).

package/skills/bugteam/reference/workflow-path-b-task-harness.md

@@ -1,48 +0,0 @@
-# Bugteam — Path B workflow (Task harness)
-
-Load when bugteam `SKILL.md` **Path routing** selects **Path B** (`CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS` is not exactly **`1`** after trim — typical Cursor IDE). Execute **after** shared `SKILL.md` steps through **Step 2 loop state**. **Do not** run `TeamCreate` or `TeamDelete`. Harness substitutions vs Path A:
-
-| Path A | Path B |
-| --- | --- |
-| `TeamCreate(...)` | **Omit.** |
-| `Agent(..., team_name=..., ...)` | **`Task`** (or host-equivalent) with the same `model` and prompt contracts as Path A — **omit** `team_name`. `subagent_type` follows this file's **AUDIT** / **FIX spawn** sections (Claude Code: `code-quality-agent` / `clean-coder`; Cursor: `code-quality-agent` / `generalPurpose` + mandatory `clean-coder.md` **Read** on FIX when the enum rejects `clean-coder`). |
-| `SendMessage` shutdown | **Omit.** Await Task completion. |
-| `TeamDelete()` | **Omit.** |
-| Three parallel `Agent` (`loop_count >= 4`) | Three parallel **`Task`** with `subagent_type="code-quality-agent"`; merge outcomes in the lead like Path A `-a`/`-b`/`-c`. |
-
-## Step 2 harness — Path B
-
-No `TeamCreate`. After shared `SKILL.md` **Step 1** completes (PR scope **and** `<team_temp_dir>/pr-<N>/` per Step 1 items 1–3 there), use the same `team_name` string only as a **logical label** for paths under that `<team_temp_dir>`; do not pass `team_name` into spawns.
-
-**`--bugbot-retrigger` flag:** same as Path A [`workflow-path-a-orchestrated-teams.md`](workflow-path-a-orchestrated-teams.md) § Step 2 harness — the **lead** posts the issue comment after each successful FIX push when the flag is present.
-
-## Step 2.5 — who posts (Path B)
-
-The **lead** runs the **same** `gh api` / `jq` sequences as `SKILL.md` **Step 2.5** after reading each **`Task`** handoff / outcome XML — same JSON shapes and anchor rules; only **who executes the shell** changes.
-
-## AUDIT spawn (Path B)
-
-After shared setup in `SKILL.md` (`mkdir`, `gh pr diff`):
-
-`Task` with `subagent_type="code-quality-agent"`, **omit** `team_name`, same `model`, `description`, and `prompt="<audit XML; see PROMPTS.md>"` as Path A [`workflow-path-a-orchestrated-teams.md`](workflow-path-a-orchestrated-teams.md) § AUDIT spawn.
-
-Fresh **Task** each loop (clean-room intent: do not reuse prior Task transcript as audit input). Lead reads `.bugteam-pr<N>-loop<L>.outcomes.xml`, fills `loop_comment_index` per `SKILL.md`.
-
-**Parallel auditors (`loop_count >= 4`):** three **`Task`** calls with `subagent_type="code-quality-agent"` in one assistant message; merge outcomes in the lead exactly as Path A documents for variants `-a`/`-b`/`-c`. Await all three Tasks — no `SendMessage`.
-
-## FIX spawn (Path B)
-
-**Hosts that accept `clean-coder` as a `Task` subtype (typical Claude Code):** `Task` with `subagent_type="clean-coder"` (or `subagent_type="groq-coder"` when `BUGTEAM_FIX_IMPLEMENTER=groq-coder` per Path A optional Groq rules), **omit** `team_name`, same fields otherwise as Path A [`workflow-path-a-orchestrated-teams.md`](workflow-path-a-orchestrated-teams.md) § FIX spawn. Await Task completion — no `SendMessage`.
-
-**Cursor and other hosts with a fixed `Task` enum (no `clean-coder` value):** use `Task` with `subagent_type: "generalPurpose"` and put the **same** FIX obligations from Path A into the **`prompt`**, after a mandatory first step to **Read** the clean-coder agent markdown: macOS/Linux `$HOME/.claude/agents/clean-coder.md`, Windows `%USERPROFILE%\.claude\agents\clean-coder.md`. State that file is binding for naming, TDD when behavior changes, hooks, one commit, and scope. Do **not** use a bare `generalPurpose` prompt without that Read. Same bundle as [`../../pr-converge/SKILL.md`](../../pr-converge/SKILL.md) Fix protocol **Implement**. If `Task` cannot run, stop and notify the user.
-
-Verify and outcome handling: unchanged from `SKILL.md` § FIX action.
-## Step 4 harness — after worktree remove, before shared `rmtree`
-
-Run **after** `SKILL.md` § Step 4 step 1 (`git worktree remove` for each PR).
-
-**Omit** teammate `SendMessage` rounds and **`TeamDelete()`**. Then continue with `SKILL.md` § Step 4 step 3 (shared `rmtree` on `<team_temp_dir>`).
-
-## Clean-room note
-
-Path B approximates Path A isolation by spawning a **new** Task per AUDIT (and per FIX) with the same prompt contract as Path A, without reusing prior Task context as audit input.

package/skills/bugteam/test_team_lifecycle.py

@@ -1,103 +0,0 @@
-"""Markdown assertion tests for bugteam team-lifecycle decoupling.
-
-Locks in the contract that the bugteam skill must:
-  - support three team lifecycle modes (`owned`, `attach`, `auto`)
-  - default to `auto` (back-compat for solo invocations, safe for nested ones)
-  - skip `TeamDelete` when the invocation did not create the team
-  - parse the runtime's `Already leading team "<name>"` error and attach
-"""
-
-from __future__ import annotations
-
-import pathlib
-
-
-def _read(relative_path: str) -> str:
-    here = pathlib.Path(__file__).parent
-    return (here / relative_path).read_text(encoding="utf-8")
-
-
-def _skill_text() -> str:
-    return _read("SKILL.md")
-
-
-def _path_a_text() -> str:
-    return _read("reference/workflow-path-a-orchestrated-teams.md")
-
-
-def _constraints_text() -> str:
-    return _read("CONSTRAINTS.md")
-
-
-def test_skill_documents_three_team_lifecycle_modes():
-    skill_text = _skill_text()
-    assert "BUGTEAM_TEAM_LIFECYCLE" in skill_text
-    assert "owned" in skill_text
-    assert "attach" in skill_text
-    assert "auto" in skill_text
-
-
-def test_skill_documents_auto_as_default_lifecycle():
-    skill_text = _skill_text()
-    assert "default" in skill_text.lower()
-    assert "BUGTEAM_TEAM_LIFECYCLE" in skill_text
-    auto_default_phrases = [
-        "default: `auto`",
-        "default `auto`",
-        "defaults to `auto`",
-        "defaults to auto",
-        "default to `auto`",
-    ]
-    assert any(phrase in skill_text for phrase in auto_default_phrases)
-
-
-def test_skill_documents_BUGTEAM_TEAM_NAME_env_for_attach_mode():
-    skill_text = _skill_text()
-    assert "BUGTEAM_TEAM_NAME" in skill_text
-
-
-def test_path_a_workflow_handles_already_leading_team_error():
-    workflow_text = _path_a_text()
-    assert 'Already leading team "' in workflow_text
-    assert "team_owned" in workflow_text
-
-
-def test_path_a_workflow_step_4_skips_team_delete_when_not_owned():
-    workflow_text = _path_a_text()
-    assert "TeamDelete" in workflow_text
-    assert "team_owned" in workflow_text
-    skip_phrases = [
-        "skip `TeamDelete`",
-        "skip TeamDelete",
-        "omit `TeamDelete`",
-        "omit TeamDelete",
-        "do not call `TeamDelete`",
-        "do not call TeamDelete",
-    ]
-    assert any(phrase in workflow_text for phrase in skip_phrases)
-
-
-def test_path_a_workflow_documents_attach_mode_reuses_team_name():
-    workflow_text = _path_a_text()
-    assert "BUGTEAM_TEAM_NAME" in workflow_text
-    assert "attach" in workflow_text
-
-
-def test_constraints_lead_only_cleanup_includes_team_owned():
-    constraints_text = _constraints_text()
-    assert "team_owned" in constraints_text
-
-
-def test_constraints_warn_against_owned_mode_inside_orchestrator():
-    constraints_text = _constraints_text()
-    assert "orchestrator" in constraints_text.lower()
-    assert "attach" in constraints_text
-
-
-def test_skill_md_physical_lines_fit_eighty_column_limit():
-    skill_text = _skill_text()
-    for each_line_number, each_physical_line in enumerate(skill_text.splitlines(), 1):
-        assert len(each_physical_line) <= 80, (
-            "SKILL.md line %s exceeds 80 columns (%s chars)"
-            % (each_line_number, len(each_physical_line))
-        )

package/skills/monitor-open-prs/test_team_lifecycle.py

@@ -1,46 +0,0 @@
-"""Markdown assertion tests for monitor-open-prs team lifecycle.
-
-Locks in the contract that the sweep must:
-  - own a single long-lived team for every dispatched /bugteam
-  - pass attach mode + the team name into each per-PR /bugteam dispatch
-  - tear down only after all PR polling completes
-"""
-
-from __future__ import annotations
-
-import pathlib
-
-
-def _skill_text() -> str:
-    here = pathlib.Path(__file__).parent
-    return (here / "SKILL.md").read_text(encoding="utf-8")
-
-
-def test_skill_creates_one_team_for_the_whole_sweep():
-    skill_text = _skill_text()
-    assert "TeamCreate" in skill_text
-    sweep_phrases = [
-        "one team for the whole sweep",
-        "single team for the sweep",
-        "single long-lived team",
-    ]
-    assert any(phrase in skill_text for phrase in sweep_phrases)
-
-
-def test_skill_passes_attach_lifecycle_to_each_bugteam_dispatch():
-    skill_text = _skill_text()
-    assert "BUGTEAM_TEAM_LIFECYCLE" in skill_text
-    assert "attach" in skill_text
-    assert "BUGTEAM_TEAM_NAME" in skill_text
-
-
-def test_skill_tears_down_team_after_polling_completes():
-    skill_text = _skill_text()
-    assert "TeamDelete" in skill_text
-    teardown_phrases = [
-        "after every PR has exited polling",
-        "after polling completes",
-        "after the sweep",
-        "after all polling",
-    ]
-    assert any(phrase in skill_text for phrase in teardown_phrases)

package/skills/pr-converge/scripts/open_followup_copilot_pr.py

@@ -1,136 +0,0 @@
-"""Open a follow-up draft PR addressing Copilot findings from the parent PR.
-
-Subprocess sequence:
-
-1. ``gh pr view <parent_number> --json baseRefName`` to resolve the parent's base ref.
-2. ``git fetch origin <head_sha>`` to make the SHA available locally.
-3. ``git switch -c <new_branch> <head_sha>`` to create the follow-up branch off ``head_sha``.
-4. ``git push -u origin <new_branch>`` to publish it.
-5. ``gh pr create --draft --base <base_ref> --head <new_branch> --title <...> --body-file <findings_file>``
-   per the gh-body-file rule.
-
-Returns the trimmed PR URL emitted by ``gh pr create`` on stdout.
-"""
-
-import argparse
-import json
-import subprocess
-import sys
-from pathlib import Path
-
-if str(Path(__file__).resolve().parent) not in sys.path:
-    sys.path.insert(0, str(Path(__file__).resolve().parent))
-
-from evict_cached_config_modules import evict_cached_config_modules
-
-evict_cached_config_modules()
-
-from config.pr_converge_constants import (
-    COPILOT_FOLLOWUP_BRANCH_TEMPLATE,
-    COPILOT_FOLLOWUP_PR_TITLE_TEMPLATE,
-    COPILOT_FOLLOWUP_SHORT_SHA_LENGTH,
-    GH_REPO_ARG_TEMPLATE,
-    PR_BASE_REF_FIELDS,
-)
-
-
-def open_followup_copilot_pr(
-    *,
-    owner: str,
-    repo: str,
-    parent_number: int,
-    head: str,
-    findings_file: Path,
-) -> str:
-    """Create the follow-up branch + draft PR; return the new PR URL."""
-    repo_arg = GH_REPO_ARG_TEMPLATE.format(owner=owner, repo=repo)
-    parent_base_ref = _resolve_parent_base_ref(
-        parent_number=parent_number, repo_arg=repo_arg
-    )
-    short_sha = head[:COPILOT_FOLLOWUP_SHORT_SHA_LENGTH]
-    new_branch_name = COPILOT_FOLLOWUP_BRANCH_TEMPLATE.format(
-        parent_number=parent_number, short_sha=short_sha
-    )
-    _run_checked(["git", "fetch", "origin", head])
-    _run_checked(["git", "switch", "-c", new_branch_name, head])
-    _run_checked(["git", "push", "-u", "origin", new_branch_name])
-    pr_title = COPILOT_FOLLOWUP_PR_TITLE_TEMPLATE.format(parent_number=parent_number)
-    completed = _run_checked(
-        [
-            "gh",
-            "pr",
-            "create",
-            "--repo",
-            repo_arg,
-            "--draft",
-            "--base",
-            parent_base_ref,
-            "--head",
-            new_branch_name,
-            "--title",
-            pr_title,
-            "--body-file",
-            str(findings_file),
-        ]
-    )
-    return completed.stdout.strip()
-
-
-def _resolve_parent_base_ref(*, parent_number: int, repo_arg: str) -> str:
-    completed = _run_checked(
-        [
-            "gh",
-            "pr",
-            "view",
-            str(parent_number),
-            "--repo",
-            repo_arg,
-            "--json",
-            PR_BASE_REF_FIELDS,
-        ]
-    )
-    parent_pr_metadata = json.loads(completed.stdout)
-    base_ref_name_field = parent_pr_metadata.get("baseRefName")
-    if not isinstance(base_ref_name_field, str):
-        raise TypeError(
-            f"gh pr view baseRefName field is not str: {type(base_ref_name_field).__name__}"
-        )
-    return base_ref_name_field
-
-
-def _run_checked(all_command_arguments: list[str]) -> subprocess.CompletedProcess:
-    return subprocess.run(
-        all_command_arguments,
-        capture_output=True,
-        check=True,
-        text=True,
-        encoding="utf-8",
-        errors="replace",
-    )
-
-
-def main() -> int:
-    parser = argparse.ArgumentParser(description=__doc__)
-    parser.add_argument("--owner", required=True)
-    parser.add_argument("--repo", required=True)
-    parser.add_argument(
-        "--parent-number", required=True, type=int, dest="parent_number"
-    )
-    parser.add_argument("--head", required=True)
-    parser.add_argument(
-        "--findings-file", required=True, type=Path, dest="findings_file"
-    )
-    parsed_arguments = parser.parse_args()
-    new_pr_url = open_followup_copilot_pr(
-        owner=parsed_arguments.owner,
-        repo=parsed_arguments.repo,
-        parent_number=parsed_arguments.parent_number,
-        head=parsed_arguments.head,
-        findings_file=parsed_arguments.findings_file,
-    )
-    sys.stdout.write(f"{new_pr_url}\n")
-    return 0
-
-
-if __name__ == "__main__":
-    sys.exit(main())