claude-dev-env 1.36.1 → 1.37.0

package/_shared/pr-loop/scripts/tests/test_code_rules_gate_constants.py

@@ -0,0 +1,102 @@
+"""Tests for code_rules_gate_constants.py extracted constant set."""
+
+import importlib.util
+from pathlib import Path
+from types import ModuleType
+
+
+def _load_constants_module() -> ModuleType:
+    module_path = (
+        Path(__file__).parent.parent / "config" / "code_rules_gate_constants.py"
+    )
+    specification = importlib.util.spec_from_file_location(
+        "config.code_rules_gate_constants", module_path
+    )
+    assert specification is not None
+    assert specification.loader is not None
+    module = importlib.util.module_from_spec(specification)
+    specification.loader.exec_module(module)
+    return module
+
+
+constants_module = _load_constants_module()
+
+
+def test_max_violations_per_check_is_typed_integer() -> None:
+    assert isinstance(constants_module.MAX_VIOLATIONS_PER_CHECK, int)
+    assert constants_module.MAX_VIOLATIONS_PER_CHECK == 3
+
+
+def test_expected_tuple_pair_length_is_typed_integer() -> None:
+    assert isinstance(constants_module.EXPECTED_TUPLE_PAIR_LENGTH, int)
+    assert constants_module.EXPECTED_TUPLE_PAIR_LENGTH == 2
+
+
+def test_all_code_file_extensions_is_frozenset() -> None:
+    assert isinstance(constants_module.ALL_CODE_FILE_EXTENSIONS, frozenset)
+    assert constants_module.ALL_CODE_FILE_EXTENSIONS == frozenset(
+        {".py", ".js", ".ts", ".tsx", ".jsx"}
+    )
+
+
+def test_all_literal_keyword_exemptions_is_frozenset() -> None:
+    assert isinstance(constants_module.ALL_LITERAL_KEYWORD_EXEMPTIONS, frozenset)
+    assert constants_module.ALL_LITERAL_KEYWORD_EXEMPTIONS == frozenset(
+        {"true", "false", "none", "null"}
+    )
+
+
+def test_config_path_segment() -> None:
+    assert constants_module.CONFIG_PATH_SEGMENT == "/config/"
+
+
+def test_tests_path_segment() -> None:
+    assert constants_module.TESTS_PATH_SEGMENT == "/tests/"
+
+
+def test_test_filename_suffixes_present() -> None:
+    assert "_test.py" in constants_module.ALL_TEST_FILENAME_SUFFIXES
+
+
+def test_test_filename_glob_suffixes_present() -> None:
+    assert ".test." in constants_module.ALL_TEST_FILENAME_GLOB_SUFFIXES
+    assert ".spec." in constants_module.ALL_TEST_FILENAME_GLOB_SUFFIXES
+
+
+def test_test_conftest_filename() -> None:
+    assert constants_module.TEST_CONFTEST_FILENAME == "conftest.py"
+
+
+def test_test_filename_prefix() -> None:
+    assert constants_module.TEST_FILENAME_PREFIX == "test_"
+
+
+def test_minimum_column_name_length_after_first_char() -> None:
+    assert constants_module.MINIMUM_COLUMN_NAME_LENGTH_AFTER_FIRST_CHAR == 2
+
+
+def test_git_name_status_added_prefix() -> None:
+    assert constants_module.GIT_NAME_STATUS_ADDED_PREFIX == "A"
+
+
+def test_git_name_status_renamed_prefix() -> None:
+    assert constants_module.GIT_NAME_STATUS_RENAMED_PREFIX == "R"
+
+
+def test_expected_rename_column_count() -> None:
+    assert constants_module.EXPECTED_RENAME_COLUMN_COUNT == 3
+
+
+def test_column_key_pattern_template_renders_with_minimum_length() -> None:
+    rendered_pattern = constants_module.COLUMN_KEY_PATTERN_TEMPLATE.format(
+        minimum_length=constants_module.MINIMUM_COLUMN_NAME_LENGTH_AFTER_FIRST_CHAR
+    )
+    assert rendered_pattern == r"^[a-z][a-z0-9_]{2,}$"
+
+
+def test_git_diff_name_only_null_terminated_command_prefix_includes_dash_z() -> None:
+    command_prefix = (
+        constants_module.ALL_GIT_DIFF_NAME_ONLY_NULL_TERMINATED_COMMAND_PREFIX
+    )
+    assert command_prefix == ("git", "diff", "--name-only", "-z")
+

package/_shared/pr-loop/scripts/tests/test_fix_hookspath.py

@@ -0,0 +1,374 @@
+"""Tests for shared fix_hookspath.py extracted from skills/bugteam/scripts/.
+
+Covers:
+- removes a local-scope core.hooksPath override and re-runs preflight
+- sets global core.hooksPath when missing
+- idempotent: second invocation produces the same final state with no errors
+- no-op when no override exists and global is already canonical
+- exits non-zero with a clear message when canonical hooks dir is missing
+- handles paths with spaces
+"""
+
+import importlib.util
+import os
+import subprocess
+from pathlib import Path
+from types import ModuleType
+
+import pytest
+
+
+def _load_fix_module() -> ModuleType:
+    module_path = Path(__file__).parent.parent / "fix_hookspath.py"
+    spec = importlib.util.spec_from_file_location("fix_hookspath", module_path)
+    assert spec is not None
+    assert spec.loader is not None
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+fix_hookspath = _load_fix_module()
+
+
+def _make_isolated_git_environment(home_directory: Path) -> dict[str, str]:
+    isolated_environment = os.environ.copy()
+    isolated_environment["HOME"] = str(home_directory)
+    isolated_environment["USERPROFILE"] = str(home_directory)
+    isolated_environment["XDG_CONFIG_HOME"] = str(home_directory / ".config")
+    isolated_environment["GIT_CONFIG_GLOBAL"] = str(home_directory / ".gitconfig")
+    isolated_environment["GIT_CONFIG_NOSYSTEM"] = "1"
+    return isolated_environment
+
+
+def _initialize_repository(repository_path: Path, environment: dict[str, str]) -> None:
+    repository_path.mkdir(parents=True, exist_ok=True)
+    subprocess.run(
+        ["git", "init", "--quiet", str(repository_path)],
+        check=True,
+        env=environment,
+    )
+
+
+def _set_local_hooks_path(
+    repository_path: Path,
+    hooks_path_value: str,
+    environment: dict[str, str],
+) -> None:
+    subprocess.run(
+        [
+            "git",
+            "-C",
+            str(repository_path),
+            "config",
+            "--local",
+            "core.hooksPath",
+            hooks_path_value,
+        ],
+        check=True,
+        env=environment,
+    )
+
+
+def _set_global_hooks_path(hooks_path_value: str, environment: dict[str, str]) -> None:
+    subprocess.run(
+        ["git", "config", "--global", "core.hooksPath", hooks_path_value],
+        check=True,
+        env=environment,
+    )
+
+
+def _read_local_hooks_path(repository_path: Path, environment: dict[str, str]) -> str:
+    completed_process = subprocess.run(
+        [
+            "git",
+            "-C",
+            str(repository_path),
+            "config",
+            "--local",
+            "--get",
+            "core.hooksPath",
+        ],
+        capture_output=True,
+        text=True,
+        check=False,
+        env=environment,
+    )
+    return completed_process.stdout.strip()
+
+
+def _read_global_hooks_path(environment: dict[str, str]) -> str:
+    completed_process = subprocess.run(
+        ["git", "config", "--global", "--get", "core.hooksPath"],
+        capture_output=True,
+        text=True,
+        check=False,
+        env=environment,
+    )
+    return completed_process.stdout.strip()
+
+
+def _create_canonical_hooks_directory(home_directory: Path) -> Path:
+    canonical_hooks_directory = home_directory / ".claude" / "hooks" / "git-hooks"
+    canonical_hooks_directory.mkdir(parents=True)
+    return canonical_hooks_directory
+
+
+def test_should_remove_local_override_and_pass_preflight(tmp_path: Path) -> None:
+    home_directory = tmp_path / "home"
+    home_directory.mkdir()
+    environment = _make_isolated_git_environment(home_directory)
+    canonical_hooks_directory = _create_canonical_hooks_directory(home_directory)
+    _set_global_hooks_path(str(canonical_hooks_directory), environment)
+    repository_path = tmp_path / "synthetic-repo"
+    _initialize_repository(repository_path, environment)
+    stale_local_value = str(repository_path / ".git" / "hooks")
+    _set_local_hooks_path(repository_path, stale_local_value, environment)
+
+    exit_code = fix_hookspath.main(
+        ["--repo-root", str(repository_path)],
+        all_environment_overrides=environment,
+    )
+
+    assert exit_code == 0
+    assert _read_local_hooks_path(repository_path, environment) == ""
+
+
+def test_should_set_global_hooks_path_when_missing(tmp_path: Path) -> None:
+    home_directory = tmp_path / "home"
+    home_directory.mkdir()
+    environment = _make_isolated_git_environment(home_directory)
+    canonical_hooks_directory = _create_canonical_hooks_directory(home_directory)
+    repository_path = tmp_path / "synthetic-repo"
+    _initialize_repository(repository_path, environment)
+    stale_local_value = str(repository_path / ".git" / "hooks")
+    _set_local_hooks_path(repository_path, stale_local_value, environment)
+
+    exit_code = fix_hookspath.main(
+        ["--repo-root", str(repository_path)],
+        all_environment_overrides=environment,
+    )
+
+    assert exit_code == 0
+    global_value_after_fix = _read_global_hooks_path(environment)
+    assert (
+        global_value_after_fix.replace("\\", "/")
+        .rstrip("/")
+        .endswith("hooks/git-hooks")
+    )
+
+
+def test_should_be_idempotent(tmp_path: Path) -> None:
+    home_directory = tmp_path / "home"
+    home_directory.mkdir()
+    environment = _make_isolated_git_environment(home_directory)
+    canonical_hooks_directory = _create_canonical_hooks_directory(home_directory)
+    _set_global_hooks_path(str(canonical_hooks_directory), environment)
+    repository_path = tmp_path / "synthetic-repo"
+    _initialize_repository(repository_path, environment)
+    stale_local_value = str(repository_path / ".git" / "hooks")
+    _set_local_hooks_path(repository_path, stale_local_value, environment)
+
+    first_exit_code = fix_hookspath.main(
+        ["--repo-root", str(repository_path)],
+        all_environment_overrides=environment,
+    )
+    second_exit_code = fix_hookspath.main(
+        ["--repo-root", str(repository_path)],
+        all_environment_overrides=environment,
+    )
+
+    assert first_exit_code == 0
+    assert second_exit_code == 0
+    assert _read_local_hooks_path(repository_path, environment) == ""
+
+
+def test_should_no_op_when_already_clean(tmp_path: Path) -> None:
+    home_directory = tmp_path / "home"
+    home_directory.mkdir()
+    environment = _make_isolated_git_environment(home_directory)
+    canonical_hooks_directory = _create_canonical_hooks_directory(home_directory)
+    _set_global_hooks_path(str(canonical_hooks_directory), environment)
+    repository_path = tmp_path / "synthetic-repo"
+    _initialize_repository(repository_path, environment)
+
+    exit_code = fix_hookspath.main(
+        ["--repo-root", str(repository_path)],
+        all_environment_overrides=environment,
+    )
+
+    assert exit_code == 0
+    assert _read_local_hooks_path(repository_path, environment) == ""
+    assert (
+        _read_global_hooks_path(environment)
+        .replace("\\", "/")
+        .rstrip("/")
+        .endswith("hooks/git-hooks")
+    )
+
+
+def test_should_exit_nonzero_when_canonical_hooks_directory_missing(
+    tmp_path: Path,
+    capsys: pytest.CaptureFixture[str],
+) -> None:
+    home_directory = tmp_path / "home"
+    home_directory.mkdir()
+    environment = _make_isolated_git_environment(home_directory)
+    repository_path = tmp_path / "synthetic-repo"
+    _initialize_repository(repository_path, environment)
+    stale_local_value = str(repository_path / ".git" / "hooks")
+    _set_local_hooks_path(repository_path, stale_local_value, environment)
+
+    exit_code = fix_hookspath.main(
+        ["--repo-root", str(repository_path)],
+        all_environment_overrides=environment,
+    )
+
+    assert exit_code != 0
+    captured_streams = capsys.readouterr()
+    assert "hooks/git-hooks" in captured_streams.err.replace("\\", "/")
+
+
+def test_constant_wrapper_functions_have_been_removed() -> None:
+    """The three wrappers returned an already-imported module-level constant
+    unchanged. They added a layer of indirection with no transformation,
+    validation, or test seam, so they were inlined at every call site
+    and removed.
+    """
+    assert not hasattr(fix_hookspath, "_expected_hooks_path_suffix")
+    assert not hasattr(fix_hookspath, "_canonical_hooks_directory_components")
+    assert not hasattr(fix_hookspath, "_home_env_var_names")
+
+
+def test_is_canonical_hooks_path_still_recognizes_canonical_suffix() -> None:
+    canonical_value_with_suffix = "/home/example/.claude/hooks/git-hooks"
+    assert fix_hookspath.is_canonical_hooks_path(canonical_value_with_suffix)
+
+
+def test_resolve_canonical_hooks_directory_uses_home_env_overrides(
+    tmp_path: Path,
+) -> None:
+    fake_home = tmp_path / "fake_home"
+    fake_home.mkdir()
+    overrides = {"HOME": str(fake_home), "USERPROFILE": str(fake_home)}
+    resolved = fix_hookspath.resolve_canonical_hooks_directory(overrides)
+    assert resolved == fake_home / ".claude" / "hooks" / "git-hooks"
+
+
+def test_list_local_core_hooks_path_values_surfaces_git_stderr(
+    tmp_path: Path,
+    capsys: pytest.CaptureFixture[str],
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    """When git -C ... config --get-all exits non-zero with stderr, the helper
+    must print a diagnostic to sys.stderr so the failure is distinguishable from
+    "no local override exists".
+    """
+    failing_completed_process = subprocess.CompletedProcess(
+        args=["git"],
+        returncode=128,
+        stdout="",
+        stderr="fatal: not a git repository (or any parent up to mount point /)",
+    )
+    monkeypatch.setattr(
+        fix_hookspath.subprocess, "run", lambda *_args, **_kwargs: failing_completed_process
+    )
+
+    returned_values = fix_hookspath.list_local_core_hooks_path_values(
+        tmp_path / "any-repo", None
+    )
+
+    assert returned_values == []
+    captured_streams = capsys.readouterr()
+    assert "fix_hookspath" in captured_streams.err
+    assert "core.hooksPath" in captured_streams.err
+    assert "not a git repository" in captured_streams.err
+
+
+def test_list_local_core_hooks_path_values_quiet_when_stderr_empty(
+    tmp_path: Path,
+    capsys: pytest.CaptureFixture[str],
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    """`git config --get-all` exits 1 with empty stderr when the key is simply
+    unset. That is the dominant happy path and must NOT emit a diagnostic."""
+    unset_completed_process = subprocess.CompletedProcess(
+        args=["git"], returncode=1, stdout="", stderr=""
+    )
+    monkeypatch.setattr(
+        fix_hookspath.subprocess, "run", lambda *_args, **_kwargs: unset_completed_process
+    )
+
+    returned_values = fix_hookspath.list_local_core_hooks_path_values(
+        tmp_path / "any-repo", None
+    )
+
+    assert returned_values == []
+    captured_streams = capsys.readouterr()
+    assert captured_streams.err == ""
+
+
+def test_read_global_core_hooks_path_surfaces_git_stderr(
+    capsys: pytest.CaptureFixture[str],
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    """When the global git-config read exits non-zero with stderr, the helper
+    must print a diagnostic so callers can distinguish "global unset" from
+    "git broken"."""
+    failing_completed_process = subprocess.CompletedProcess(
+        args=["git"],
+        returncode=128,
+        stdout="",
+        stderr="fatal: bad config line 1 in file /home/example/.gitconfig",
+    )
+    monkeypatch.setattr(
+        fix_hookspath.subprocess, "run", lambda *_args, **_kwargs: failing_completed_process
+    )
+
+    returned_value = fix_hookspath.read_global_core_hooks_path(None)
+
+    assert returned_value == ""
+    captured_streams = capsys.readouterr()
+    assert "fix_hookspath" in captured_streams.err
+    assert "core.hooksPath" in captured_streams.err
+    assert "bad config" in captured_streams.err
+
+
+def test_read_global_core_hooks_path_quiet_when_stderr_empty(
+    capsys: pytest.CaptureFixture[str],
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    """`git config --global --get` exits 1 with empty stderr when the key is
+    simply unset. That is the dominant happy path and must NOT emit a diagnostic."""
+    unset_completed_process = subprocess.CompletedProcess(
+        args=["git"], returncode=1, stdout="", stderr=""
+    )
+    monkeypatch.setattr(
+        fix_hookspath.subprocess, "run", lambda *_args, **_kwargs: unset_completed_process
+    )
+
+    returned_value = fix_hookspath.read_global_core_hooks_path(None)
+
+    assert returned_value == ""
+    captured_streams = capsys.readouterr()
+    assert captured_streams.err == ""
+
+
+def test_should_handle_paths_with_spaces(tmp_path: Path) -> None:
+    home_directory = tmp_path / "home with space"
+    home_directory.mkdir()
+    environment = _make_isolated_git_environment(home_directory)
+    canonical_hooks_directory = _create_canonical_hooks_directory(home_directory)
+    _set_global_hooks_path(str(canonical_hooks_directory), environment)
+    repository_path = tmp_path / "repo with space"
+    _initialize_repository(repository_path, environment)
+    stale_local_value = str(repository_path / ".git" / "hooks")
+    _set_local_hooks_path(repository_path, stale_local_value, environment)
+
+    exit_code = fix_hookspath.main(
+        ["--repo-root", str(repository_path)],
+        all_environment_overrides=environment,
+    )
+
+    assert exit_code == 0
+    assert _read_local_hooks_path(repository_path, environment) == ""

package/_shared/pr-loop/scripts/tests/test_fix_hookspath_constants.py

@@ -0,0 +1,47 @@
+"""Tests for fix_hookspath_constants.
+
+Confirms HOOKS_PATH_SUFFIX is the full 3-component canonical hooks path so
+validators cannot accept arbitrary directories that merely end in
+``hooks/git-hooks``.
+"""
+
+import importlib.util
+from pathlib import Path
+from types import ModuleType
+
+
+def _load_constants_module() -> ModuleType:
+    module_path = Path(__file__).parent.parent / "config" / "fix_hookspath_constants.py"
+    specification = importlib.util.spec_from_file_location(
+        "config.fix_hookspath_constants", module_path
+    )
+    assert specification is not None
+    assert specification.loader is not None
+    module = importlib.util.module_from_spec(specification)
+    specification.loader.exec_module(module)
+    return module
+
+
+constants_module = _load_constants_module()
+
+
+def test_hooks_path_suffix_uses_full_three_component_canonical_suffix() -> None:
+    assert constants_module.HOOKS_PATH_SUFFIX == "/".join(
+        constants_module.ALL_CANONICAL_HOOKS_DIRECTORY_COMPONENTS
+    )
+    assert constants_module.HOOKS_PATH_SUFFIX == ".claude/hooks/git-hooks"
+
+
+def test_canonical_hooks_directory_components_remain_three_component_tuple() -> None:
+    assert constants_module.ALL_CANONICAL_HOOKS_DIRECTORY_COMPONENTS == (
+        ".claude",
+        "hooks",
+        "git-hooks",
+    )
+
+
+def test_hooks_path_verification_suffix_is_two_component_for_backward_compat() -> None:
+    assert constants_module.HOOKS_PATH_VERIFICATION_SUFFIX == "hooks/git-hooks"
+    assert constants_module.HOOKS_PATH_VERIFICATION_SUFFIX == "/".join(
+        constants_module.ALL_CANONICAL_HOOKS_DIRECTORY_COMPONENTS[-2:]
+    )