claude-dev-env 1.36.0 → 1.36.2

package/_shared/pr-loop/scripts/tests/test_claude_permissions_common.py

@@ -0,0 +1,169 @@
+"""Tests for _shared permission helpers extracted from skills/bugteam/scripts/."""
+
+import importlib.util
+import inspect
+import json
+import sys
+from pathlib import Path
+from types import ModuleType
+
+import pytest
+
+
+def _load_common_module() -> ModuleType:
+    module_path = Path(__file__).parent.parent / "_claude_permissions_common.py"
+    parent_directory = str(module_path.parent.resolve())
+    if parent_directory not in sys.path:
+        sys.path.insert(0, parent_directory)
+    spec = importlib.util.spec_from_file_location(
+        "_claude_permissions_common", module_path
+    )
+    assert spec is not None
+    assert spec.loader is not None
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+common = _load_common_module()
+
+
+def test_return_normalized_path_when_cwd_contains_spaces(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    directory_with_spaces = tmp_path / "dir with spaces"
+    directory_with_spaces.mkdir()
+    monkeypatch.chdir(directory_with_spaces)
+    returned_project_path = common.get_current_project_path()
+    expected_suffix = "/dir with spaces"
+    assert returned_project_path.endswith(expected_suffix)
+    assert "\\" not in returned_project_path
+    built_rule = common.build_permission_rule("Edit", returned_project_path)
+    assert built_rule.startswith("Edit(")
+    assert built_rule.endswith("/.claude/**)")
+    assert "dir with spaces" in built_rule
+
+
+def test_raise_when_cwd_contains_glob_metacharacters(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    directory_with_star = tmp_path / "weird[dir]"
+    directory_with_star.mkdir()
+    monkeypatch.chdir(directory_with_star)
+    with pytest.raises(ValueError, match="glob metacharacters"):
+        common.get_current_project_path()
+
+
+def test_flag_glob_metacharacters_in_any_position() -> None:
+    assert common.path_contains_glob_metacharacters("/home/user/[dir]/project")
+    assert common.path_contains_glob_metacharacters("/home/user/project*")
+    assert not common.path_contains_glob_metacharacters("/home/user/dir with spaces")
+
+
+def test_text_file_encoding_remains_local_constant() -> None:
+    assert common.TEXT_FILE_ENCODING == "utf-8"
+
+
+def test_module_no_longer_redeclares_migrated_constants() -> None:
+    assert not hasattr(common, "ALL_PERMISSION_ALLOW_TOOLS")
+    assert not hasattr(common, "AUTO_MODE_ENVIRONMENT_ENTRY_TEMPLATE")
+
+
+def test_save_settings_uses_unique_per_call_temp_suffix(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    """Regression for atomic-write race: each save_settings call must
+    derive its own unique temp path so concurrent writers do not collide
+    on the same `.tmp` filename.
+    """
+    settings_path = tmp_path / "settings.json"
+    settings_path.write_text(json.dumps({}), encoding="utf-8")
+
+    captured_temp_paths: list[Path] = []
+    real_write_atomically_with_mode = common.write_atomically_with_mode
+
+    def capturing_write(
+        temporary_path: Path, serialized_content: str, file_mode: int
+    ) -> None:
+        captured_temp_paths.append(Path(temporary_path))
+        real_write_atomically_with_mode(
+            temporary_path, serialized_content, file_mode
+        )
+
+    monkeypatch.setattr(common, "write_atomically_with_mode", capturing_write)
+
+    common.save_settings(settings_path, {"writer": "first"})
+    common.save_settings(settings_path, {"writer": "second"})
+
+    assert len(captured_temp_paths) == 2
+    assert captured_temp_paths[0] != captured_temp_paths[1]
+    for each_temp_path in captured_temp_paths:
+        assert ".tmp." in each_temp_path.name
+
+
+def test_save_settings_temp_suffix_includes_pid_and_random_token(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    """The unique temp suffix must include the process id and a random
+    hex token so two processes cannot collide on the same temp filename.
+    """
+    settings_path = tmp_path / "settings.json"
+    settings_path.write_text(json.dumps({}), encoding="utf-8")
+
+    captured_temp_paths: list[Path] = []
+    real_write_atomically_with_mode = common.write_atomically_with_mode
+
+    def capturing_write(
+        temporary_path: Path, serialized_content: str, file_mode: int
+    ) -> None:
+        captured_temp_paths.append(Path(temporary_path))
+        real_write_atomically_with_mode(
+            temporary_path, serialized_content, file_mode
+        )
+
+    monkeypatch.setattr(common, "write_atomically_with_mode", capturing_write)
+
+    common.save_settings(settings_path, {"writer": "only"})
+
+    assert len(captured_temp_paths) == 1
+    suffix_token = captured_temp_paths[0].name.split(".tmp.", maxsplit=1)[1]
+    pid_text, random_token = suffix_token.split(".", maxsplit=1)
+    assert pid_text.isdigit()
+    minimum_random_token_hex_chars = 4
+    assert len(random_token) >= minimum_random_token_hex_chars
+    assert all(
+        each_character in "0123456789abcdef" for each_character in random_token
+    )
+
+
+def test_text_file_encoding_sourced_from_config() -> None:
+    config_module_path = (
+        Path(__file__).parent.parent / "config" / "claude_permissions_constants.py"
+    )
+    specification = importlib.util.spec_from_file_location(
+        "config.claude_permissions_constants", config_module_path
+    )
+    assert specification is not None
+    assert specification.loader is not None
+    config_module = importlib.util.module_from_spec(specification)
+    specification.loader.exec_module(config_module)
+    assert common.TEXT_FILE_ENCODING == config_module.TEXT_FILE_ENCODING
+
+
+def test_path_contains_glob_metacharacters_local_tuple_uses_all_collection_prefix() -> None:
+    source_text = inspect.getsource(common.path_contains_glob_metacharacters)
+    assert "all_glob_metacharacters_in_path" in source_text
+    assert "glob_metacharacters_in_path:" not in source_text.replace(
+        "all_glob_metacharacters_in_path", ""
+    )
+
+
+def test_is_valid_project_root_uses_extracted_directory_marker_constants() -> None:
+    """is_valid_project_root must reference extracted constants, not inline string literals."""
+    source_text = inspect.getsource(common.is_valid_project_root)
+    assert "GIT_DIRECTORY_NAME" in source_text
+    assert "CLAUDE_SETTINGS_DIRECTORY_NAME" in source_text
+    assert "'.git'" not in source_text
+    assert '".git"' not in source_text
+    assert "'.claude'" not in source_text
+    assert '".claude"' not in source_text

package/_shared/pr-loop/scripts/tests/test_claude_permissions_constants.py

@@ -0,0 +1,58 @@
+"""Tests for shared constants powering grant/revoke claude permissions."""
+
+import importlib.util
+from pathlib import Path
+from types import ModuleType
+
+
+def _load_constants_module() -> ModuleType:
+    module_path = (
+        Path(__file__).parent.parent / "config" / "claude_permissions_constants.py"
+    )
+    specification = importlib.util.spec_from_file_location(
+        "config.claude_permissions_constants", module_path
+    )
+    assert specification is not None
+    assert specification.loader is not None
+    module = importlib.util.module_from_spec(specification)
+    specification.loader.exec_module(module)
+    return module
+
+
+constants_module = _load_constants_module()
+
+
+def test_exposes_all_permission_allow_tools_tuple() -> None:
+    assert constants_module.ALL_PERMISSION_ALLOW_TOOLS == ("Edit", "Write", "Read")
+
+
+def test_auto_mode_environment_entry_template_is_format_string() -> None:
+    rendered_template_text = (
+        constants_module.AUTO_MODE_ENVIRONMENT_ENTRY_TEMPLATE.format(
+            project_path="/tmp/x"
+        )
+    )
+    assert "/tmp/x" in rendered_template_text
+    assert ".claude/**" in rendered_template_text
+
+
+def test_get_claude_user_settings_path_ends_in_settings_json() -> None:
+    resolved_settings_path = constants_module.get_claude_user_settings_path()
+    assert resolved_settings_path.name == constants_module.CLAUDE_SETTINGS_FILENAME
+    assert (
+        resolved_settings_path.parent.name
+        == constants_module.CLAUDE_SETTINGS_DIRECTORY_NAME
+    )
+
+
+def test_text_file_encoding_lives_in_config() -> None:
+    assert constants_module.TEXT_FILE_ENCODING == "utf-8"
+
+
+def test_unique_temporary_suffix_byte_length_is_positive_integer() -> None:
+    assert isinstance(constants_module.UNIQUE_TEMPORARY_SUFFIX_BYTE_LENGTH, int)
+    assert constants_module.UNIQUE_TEMPORARY_SUFFIX_BYTE_LENGTH > 0
+
+
+def test_git_directory_name_lives_in_config() -> None:
+    assert constants_module.GIT_DIRECTORY_NAME == ".git"

package/_shared/pr-loop/scripts/tests/test_claude_settings_keys_constants.py

@@ -0,0 +1,50 @@
+"""Tests for claude_settings_keys_constants.py extracted constant set."""
+
+import importlib.util
+from pathlib import Path
+from types import ModuleType
+
+
+def _load_constants_module() -> ModuleType:
+    module_path = (
+        Path(__file__).parent.parent / "config" / "claude_settings_keys_constants.py"
+    )
+    specification = importlib.util.spec_from_file_location(
+        "config.claude_settings_keys_constants", module_path
+    )
+    assert specification is not None
+    assert specification.loader is not None
+    module = importlib.util.module_from_spec(specification)
+    specification.loader.exec_module(module)
+    return module
+
+
+constants_module = _load_constants_module()
+
+
+def test_permissions_key_is_typed_string() -> None:
+    assert isinstance(constants_module.CLAUDE_SETTINGS_PERMISSIONS_KEY, str)
+    assert constants_module.CLAUDE_SETTINGS_PERMISSIONS_KEY == "permissions"
+
+
+def test_allow_key_is_typed_string() -> None:
+    assert isinstance(constants_module.CLAUDE_SETTINGS_ALLOW_KEY, str)
+    assert constants_module.CLAUDE_SETTINGS_ALLOW_KEY == "allow"
+
+
+def test_additional_directories_key_is_typed_string() -> None:
+    assert isinstance(constants_module.CLAUDE_SETTINGS_ADDITIONAL_DIRECTORIES_KEY, str)
+    assert (
+        constants_module.CLAUDE_SETTINGS_ADDITIONAL_DIRECTORIES_KEY
+        == "additionalDirectories"
+    )
+
+
+def test_auto_mode_key_is_typed_string() -> None:
+    assert isinstance(constants_module.CLAUDE_SETTINGS_AUTO_MODE_KEY, str)
+    assert constants_module.CLAUDE_SETTINGS_AUTO_MODE_KEY == "autoMode"
+
+
+def test_environment_key_is_typed_string() -> None:
+    assert isinstance(constants_module.CLAUDE_SETTINGS_ENVIRONMENT_KEY, str)
+    assert constants_module.CLAUDE_SETTINGS_ENVIRONMENT_KEY == "environment"