claude-dev-env 1.29.3 → 1.30.1

package/skills/monitor-open-prs/scripts/test_discover_open_prs.py

@@ -0,0 +1,149 @@
+"""Tests for discover_open_prs.py — merges gh-search output across owners."""
+
+from __future__ import annotations
+
+import importlib.util
+import json
+import pathlib
+import sys
+
+import pytest
+
+
+def _load_discovery_module():
+    scripts_directory = pathlib.Path(__file__).parent
+    sys.path.insert(0, str(scripts_directory))
+    module_path = scripts_directory / "discover_open_prs.py"
+    module_spec = importlib.util.spec_from_file_location(
+        "discover_open_prs", module_path
+    )
+    loaded_module = importlib.util.module_from_spec(module_spec)
+    sys.modules["discover_open_prs"] = loaded_module
+    module_spec.loader.exec_module(loaded_module)
+    return loaded_module
+
+
+discover_open_prs = _load_discovery_module()
+
+
+def _make_fake_gh(responses_by_owner: dict):
+    """Return a callable whose behavior mocks subprocess.run for gh search."""
+
+    class FakeCompletedProcess:
+        def __init__(self, stdout_text: str):
+            self.stdout = stdout_text
+            self.returncode = 0
+
+    def fake_run(command_argv, check, capture_output, text):
+        owner = _extract_owner_argument(command_argv)
+        stdout_text = json.dumps(responses_by_owner.get(owner, []))
+        return FakeCompletedProcess(stdout_text)
+
+    return fake_run
+
+
+def _extract_owner_argument(command_argv) -> str:
+    for each_index, each_token in enumerate(command_argv):
+        if each_token == "--owner":
+            return command_argv[each_index + 1]
+    return ""
+
+
+class TestDiscoverOpenPrsBothOwnersReturnResults:
+    def test_merges_prs_across_both_owners(self, monkeypatch):
+        first_owner_prs = [
+            {
+                "number": 1,
+                "repository": {"nameWithOwner": "jl-cmd/alpha"},
+                "url": "https://github.com/jl-cmd/alpha/pull/1",
+                "headRefName": "feat-one",
+                "baseRefName": "main",
+            }
+        ]
+        second_owner_prs = [
+            {
+                "number": 2,
+                "repository": {"nameWithOwner": "JonEcho/beta"},
+                "url": "https://github.com/JonEcho/beta/pull/2",
+                "headRefName": "feat-two",
+                "baseRefName": "main",
+            }
+        ]
+        fake_run = _make_fake_gh(
+            {"jl-cmd": first_owner_prs, "JonEcho": second_owner_prs}
+        )
+        monkeypatch.setattr(discover_open_prs.subprocess, "run", fake_run)
+
+        all_discovered = discover_open_prs.discover_open_prs(
+            all_owners=["jl-cmd", "JonEcho"]
+        )
+
+        assert len(all_discovered) == 2
+        discovered_numbers = sorted(each["number"] for each in all_discovered)
+        assert discovered_numbers == [1, 2]
+
+
+class TestDiscoverOpenPrsOneOwnerEmpty:
+    def test_handles_single_owner_returning_empty_list(self, monkeypatch):
+        first_owner_prs = [
+            {
+                "number": 5,
+                "repository": {"nameWithOwner": "jl-cmd/gamma"},
+                "url": "https://github.com/jl-cmd/gamma/pull/5",
+                "headRefName": "feat-five",
+                "baseRefName": "main",
+            }
+        ]
+        fake_run = _make_fake_gh({"jl-cmd": first_owner_prs, "JonEcho": []})
+        monkeypatch.setattr(discover_open_prs.subprocess, "run", fake_run)
+
+        all_discovered = discover_open_prs.discover_open_prs(
+            all_owners=["jl-cmd", "JonEcho"]
+        )
+
+        assert len(all_discovered) == 1
+        assert all_discovered[0]["number"] == 5
+
+
+class TestDiscoverOpenPrsBothEmpty:
+    def test_returns_empty_list_when_no_owner_has_open_prs(self, monkeypatch):
+        fake_run = _make_fake_gh({"jl-cmd": [], "JonEcho": []})
+        monkeypatch.setattr(discover_open_prs.subprocess, "run", fake_run)
+
+        all_discovered = discover_open_prs.discover_open_prs(
+            all_owners=["jl-cmd", "JonEcho"]
+        )
+
+        assert all_discovered == []
+
+
+class TestDiscoverOpenPrsEntryShape:
+    def test_each_entry_exposes_number_owner_repo_refs_and_url(self, monkeypatch):
+        fake_run = _make_fake_gh(
+            {
+                "jl-cmd": [
+                    {
+                        "number": 42,
+                        "repository": {"nameWithOwner": "jl-cmd/demo"},
+                        "url": "https://github.com/jl-cmd/demo/pull/42",
+                        "headRefName": "feat-demo",
+                        "baseRefName": "main",
+                    }
+                ],
+                "JonEcho": [],
+            }
+        )
+        monkeypatch.setattr(discover_open_prs.subprocess, "run", fake_run)
+
+        all_discovered = discover_open_prs.discover_open_prs(
+            all_owners=["jl-cmd", "JonEcho"]
+        )
+
+        assert len(all_discovered) == 1
+        only_entry = all_discovered[0]
+        assert only_entry["number"] == 42
+        assert only_entry["owner"] == "jl-cmd"
+        assert only_entry["repo"] == "demo"
+        assert only_entry["head_ref"] == "feat-demo"
+        assert only_entry["base_ref"] == "main"
+        assert only_entry["url"].endswith("/pull/42")

package/skills/monitor-open-prs/test_skill_contract.py

@@ -0,0 +1,43 @@
+"""Markdown assertion tests for monitor-open-prs SKILL.md."""
+
+from __future__ import annotations
+
+import pathlib
+
+
+def _read_skill_text() -> str:
+    skill_path = pathlib.Path(__file__).parent / "SKILL.md"
+    return skill_path.read_text(encoding="utf-8")
+
+
+def test_skill_has_frontmatter_name():
+    skill_text = _read_skill_text()
+    assert skill_text.startswith("---\n")
+    assert "name: monitor-open-prs" in skill_text
+
+
+def test_skill_requires_agent_teams_env_var():
+    skill_text = _read_skill_text()
+    assert "CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS" in skill_text
+
+
+def test_skill_invokes_bugteam_with_groq_implementer():
+    skill_text = _read_skill_text()
+    assert "BUGTEAM_FIX_IMPLEMENTER" in skill_text
+    assert "groq-coder" in skill_text
+
+
+def test_skill_references_bugbot_retrigger_flag():
+    skill_text = _read_skill_text()
+    assert "--bugbot-retrigger" in skill_text
+
+
+def test_skill_enumerates_both_owner_scopes():
+    skill_text = _read_skill_text()
+    assert "jl-cmd" in skill_text
+    assert "JonEcho" in skill_text
+
+
+def test_skill_documents_bws_wrapping():
+    skill_text = _read_skill_text()
+    assert "bws run" in skill_text

package/skills/pr-review-responder/SKILL.md

@@ -23,7 +23,7 @@ Before doing ANYTHING:
 3. [ ] Fix comments ONE AT A TIME, marking complete as you go
 4. [ ] Draft reply for EVERY comment (DO NOT post directly)
 5. [ ] Create ONE review fix commit (DO NOT squash with original)
-6. [ ] Run pre-push-review skill before pushing
+6. [ ] Push — the git pre-push hook (installed via `npx claude-dev-env`) runs automatically
 7. [ ] Verify ALL draft replies are prepared
 
 **Responding WITHOUT completing this checklist = automatic failure.**
@@ -112,15 +112,17 @@ git commit -m "fix: address code review feedback
 Addresses review comments from PR #{number}"
 ```
 
-### Rule 6: Run Pre-Push Review
+### Rule 6: Pre-Push Gate Fires Automatically
 
-**NEVER push without running pre-push-review skill.**
+**The git pre-push hook (installed via `npx claude-dev-env`) runs automatically on every `git push`.** It covers lint, magic values, boolean naming, imports, and all code-rules enforcer checks — no manual invocation needed.
 
-- [ ] FORBIDDEN: Pushing without pre-push-review
+- [ ] FORBIDDEN: Pushing without gate passing
 - [ ] FORBIDDEN: Manually handling draft conversion
-- [x] REQUIRED: Invoke pre-push-review skill which handles all 24 checks + draft conversion
+- [x] REQUIRED: Run `git push`; the pre-push hook fires and blocks if any check fails
 
-**WHY:** Pre-push-review catches ALL patterns reviewers flag: code style, draft status, commit structure. Delegating to it ensures nothing is missed.
+Use `/qbug` only when you want a full multi-loop PR audit with subagents after the PR is open — it is NOT a substitute for the pre-push gate and refuses when no PR exists yet.
+
+**WHY:** The pre-push hook catches ALL patterns reviewers flag: code style, draft status, commit structure. It fires automatically so nothing is missed.
 
 ### Rule 7: Verify All Drafts Complete
 
@@ -136,7 +138,7 @@ Addresses review comments from PR #{number}"
 - **"Let me fix this one quickly before making the checklist"** -> WRONG. Without checklist you will miss others.
 - **"I'll post the replies myself to save time"** -> WRONG. User controls what gets posted.
 - **"This is a small fix, I can squash it"** -> WRONG. Squashing hides the delta from reviewers.
-- **"Pre-push review is overkill for review fixes"** -> WRONG. It catches style issues you introduced while fixing.
+- **"Pre-push review is overkill for review fixes"** -> WRONG. The git pre-push hook catches style issues you introduced while fixing; it fires automatically on every push.
 
 </EXTREMELY_IMPORTANT>
 
@@ -151,7 +153,7 @@ PR Review Response Complete
 
 Fetched: {X} comments (with per_page=100)
 Fixed: {X} issues
-Pre-push review: PASSED (all 24 checks)
+Pre-push hook: PASSED (fired automatically on git push)
 Draft replies: {X} prepared for user
 Commits: 2 (original + review fix, NOT squashed)
 

package/hooks/github-action/pre-push-review.yml

@@ -1,27 +0,0 @@
-name: Pre-Push Review
-
-on:
-  pull_request:
-    branches:
-      - main
-
-jobs:
-  validate:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Set up Python
-        uses: actions/setup-python@v5
-        with:
-          python-version: "3.13"
-
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install pyyaml pytest
-
-      - name: Run validators
-        working-directory: packages/claude-dev-env/hooks/validators
-        run: python run_all_validators.py --json

package/hooks/github-action/test_workflow.py

@@ -1,33 +0,0 @@
-"""Tests for GitHub Action workflow YAML validity."""
-
-from pathlib import Path
-
-import yaml
-
-
-def test_workflow_is_valid_yaml() -> None:
-    """Test that the workflow file is valid YAML."""
-    workflow_path = Path(__file__).parent / "pre-push-review.yml"
-    assert workflow_path.exists(), "Workflow file must exist"
-
-    with open(workflow_path) as f:
-        data = yaml.safe_load(f)
-
-    assert "name" in data
-    assert "on" in data or True in data
-    assert "jobs" in data
-
-
-def test_workflow_has_validate_job() -> None:
-    """Test that workflow has a validate job with required steps."""
-    workflow_path = Path(__file__).parent / "pre-push-review.yml"
-
-    with open(workflow_path) as f:
-        data = yaml.safe_load(f)
-
-    assert "validate" in data["jobs"]
-    job = data["jobs"]["validate"]
-    assert "steps" in job
-    step_names = [s.get("name", "") for s in job["steps"]]
-    assert "Checkout code" in step_names
-    assert "Set up Python" in step_names

package/skills/pr-review-responder/update_skill.py

@@ -1,297 +0,0 @@
-#!/usr/bin/env python3
-"""Update pr-review-responder skill with all changes at once."""
-
-import re
-from pathlib import Path
-
-SKILL_PATH = Path(__file__).parent / "SKILL.md"
-
-def main() -> None:
-    content = SKILL_PATH.read_text(encoding="utf-8")
-
-    # 1. Change 7-step to 8-step
-    content = content.replace("strict 7-step protocol", "strict 8-step protocol")
-
-    # 2. Update Step 4: Change from posting to drafting
-    old_step4 = '''## STEP 4: REPLY TO EACH COMMENT INLINE (MANDATORY)
-
-**For EACH comment, you MUST post an inline reply.**
-
-**NOT a summary comment. NOT a general "fixed everything" comment. EACH comment gets INDIVIDUAL reply.**
-
-1. **Response format**:
-   ```
-   ✅ **Fixed**: [brief description of what was changed]
-   ```
-
-2. **Post inline reply**:
-   ```bash
-   gh api repos/{owner}/{repo}/pulls/comments/{comment_id}/replies \\
-     -X POST \\
-     -f body="✅ **Fixed**: [description]"
-   ```
-
-3. **Examples**:
-   - `✅ **Fixed**: Removed wrapper function, using direct storage.upload_file() calls`
-   - `✅ **Fixed**: Extracted shared logic to utils/view_helpers.py`
-   - `✅ **Fixed**: Moved CSS values from Python to stylesheet`
-   - `✅ **Fixed**: Added type hints to all function parameters`
-
-**CRITICAL VALIDATION:**
-- ☐ Did you reply to EVERY comment? (not just some)
-- ☐ Are replies inline? (not summary comment)
-- ☐ Did you mark reply todos complete?
-
-**If validation fails:**
-```
-ERROR: Missing inline replies.
-Found {X} comments but only {Y} replies.
-STOPPING execution.
-```
-
-**Why this matters:** Reviewers need to know WHICH comments were addressed. Summary comments don't cut it.'''
-
-    new_step4 = '''## STEP 4: DRAFT REPLIES FOR EACH COMMENT (MANDATORY)
-
-**For EACH comment, you MUST draft an inline reply for the user to post.**
-
-**DO NOT POST COMMENTS DIRECTLY. Draft them and present to user for review.**
-
-1. **Response format**:
-   ```
-   ✅ **Fixed**: [brief description of what was changed]
-   ```
-
-2. **Draft replies in a clear format for user to copy**:
-   ```
-   DRAFT REPLIES (for user to post):
-   ================================
-
-   Comment #1 (file.py:45 - "description of comment"):
-   Reply: ✅ **Fixed**: [description of fix]
-
-   Comment #2 (file.py:67 - "description of comment"):
-   Reply: ✅ **Fixed**: [description of fix]
-   ```
-
-3. **Examples**:
-   - `✅ **Fixed**: Removed wrapper function, using direct storage.upload_file() calls`
-   - `✅ **Fixed**: Extracted shared logic to utils/view_helpers.py`
-   - `✅ **Fixed**: Moved CSS values from Python to stylesheet`
-   - `✅ **Fixed**: Added type hints to all function parameters`
-
-**CRITICAL VALIDATION:**
-- ☐ Did you draft a reply for EVERY comment? (not just some)
-- ☐ Are drafts specific and actionable?
-- ☐ Did you present drafts clearly for user review?
-
-**Why this matters:** User controls what gets posted. Drafts ensure nothing is missed while giving user final say.'''
-
-    content = content.replace(old_step4, new_step4)
-
-    # 3. Add new Step 5 (pre-push-review) before Step 5 (commits)
-    old_step5_header = '''---
-
-## STEP 5: KEEP COMMITS SEPARATE (MANDATORY)'''
-
-    new_step5_and_6 = '''---
-
-## STEP 5: RUN PRE-PUSH REVIEW (MANDATORY)
-
-**BEFORE committing, you MUST run the pre-push-review skill.**
-
-**This catches style violations, anti-patterns, and repeat mistakes BEFORE they get committed.**
-
-1. **Invoke the pre-push-review skill**:
-   ```
-   Skill(pre-push-review)
-   ```
-
-2. **CRITICAL VALIDATION**:
-   - ☐ Did you run pre-push-review on all changed files?
-   - ☐ Did all 22 checks pass?
-   - ☐ Did you fix any violations found?
-
-3. **If violations found**:
-   - Fix the violations FIRST
-   - Re-run pre-push-review
-   - Only proceed when all checks pass
-
-**Why this matters:** Pre-push-review catches the EXACT patterns reviewers flag in code reviews. Running it prevents repeat mistakes.
-
----
-
-## STEP 6: KEEP COMMITS SEPARATE (MANDATORY)'''
-
-    content = content.replace(old_step5_header, new_step5_and_6)
-
-    # 4. Renumber Step 6 -> Step 7
-    content = content.replace("## STEP 6: VERIFY ALL REPLIES POSTED", "## STEP 7: VERIFY ALL DRAFTS COMPLETE")
-
-    # 5. Update Step 7 (was 6) content
-    old_step6_content = '''**Before declaring success, you MUST verify ALL replies are visible on GitHub.**
-
-1. **Check PR comments page**:
-   ```bash
-   gh pr view {pr_number} --comments
-   ```
-
-2. **CRITICAL VALIDATION**:
-   - ☐ Are all replies visible?
-   - ☐ Do reply counts match comment counts?
-   - ☐ No failed posts?
-
-3. **If validation fails**:
-   ```
-   ERROR: Reply verification failed.
-   Expected {X} replies, found {Y}.
-   Check GitHub PR page manually.
-   ```'''
-
-    new_step7_content = '''**Before declaring success, you MUST verify ALL reply drafts are prepared.**
-
-1. **Review draft replies**:
-   - Count of drafts matches count of comments
-   - Each draft is specific and actionable
-   - Drafts are formatted clearly for user to copy
-
-2. **CRITICAL VALIDATION**:
-   - ☐ Draft count matches comment count?
-   - ☐ Each draft references specific fix?
-   - ☐ Drafts presented in clear format?
-
-3. **If validation fails**:
-   ```
-   ERROR: Missing draft replies.
-   Expected {X} drafts, found {Y}.
-   Complete all drafts before proceeding.
-   ```'''
-
-    content = content.replace(old_step6_content, new_step7_content)
-
-    # 6. Renumber Step 7 -> Step 8
-    content = content.replace("## STEP 7: FINAL REPORT", "## STEP 8: FINAL REPORT")
-
-    # 7. Update final report
-    old_report = '''```
-✅ PR Review Response Complete
-
-Fetched: {X} comments (with per_page=100)
-Fixed: {X} issues
-Replied: {X} inline comments (100% coverage)
-Commits: 2 (original + review fix, NOT squashed)
-
-TodoWrite checklist: 100% complete
-All inline replies verified on GitHub
-
-PR #{number}: {url}
-
-Ready to push!
-```'''
-
-    new_report = '''```
-✅ PR Review Response Complete
-
-Fetched: {X} comments (with per_page=100)
-Fixed: {X} issues
-Pre-push review: PASSED (all 22 checks)
-Draft replies: {X} prepared for user
-Commits: 2 (original + review fix, NOT squashed)
-
-TodoWrite checklist: 100% complete
-
-DRAFT REPLIES FOR USER TO POST:
-================================
-[List all draft replies here]
-
-PR #{number}: {url}
-
-Ready to push!
-```'''
-
-    content = content.replace(old_report, new_report)
-
-    # 8. Update enforcement mechanisms
-    old_enforcement4 = '''4. **Step 4 violation**: Missing inline replies
-   ```
-   ERROR: Missing inline replies to comments.
-   Found {X} comments, only {Y} replies posted.
-   Every comment requires individual inline reply.
-   STOPPING execution.
-   ```
-
-5. **Step 5 violation (ERROR)**: Commits were squashed'''
-
-    new_enforcement4_5_6 = '''4. **Step 4 violation**: Missing draft replies
-   ```
-   ERROR: Missing draft replies to comments.
-   Found {X} comments, only {Y} drafts prepared.
-   Every comment requires individual draft reply.
-   STOPPING execution.
-   ```
-
-5. **Step 5 violation**: Pre-push review not run or failed
-   ```
-   ERROR: Must run pre-push-review skill before committing.
-   This catches style violations and anti-patterns.
-   STOPPING execution.
-   ```
-
-6. **Step 6 violation (ERROR)**: Commits were squashed'''
-
-    content = content.replace(old_enforcement4, new_enforcement4_5_6)
-
-    # 9. Update Step 6 violation -> Step 7
-    content = content.replace(
-        '6. **Step 6 violation**: Reply verification failed',
-        '7. **Step 7 violation**: Draft verification failed'
-    )
-    content = content.replace(
-        'ERROR: Cannot verify all replies posted to GitHub.\n   Check PR page manually: {url}',
-        'ERROR: Cannot verify all draft replies prepared.\n   Expected {X} drafts, found {Y}.\n   Complete all drafts before proceeding.'
-    )
-
-    # 10. Update quick reference
-    old_quick_ref = '''# 4. Reply inline to EACH comment
-gh api repos/{owner}/{repo}/pulls/comments/{comment_id}/replies -X POST -f body="✅ Fixed: ..."
-
-# 5. Create ONE review fix commit (DON'T squash with original)'''
-
-    new_quick_ref = '''# 4. Draft replies for user (DO NOT POST)
-# Present drafts in clear format for user to copy and post
-
-# 5. Run pre-push-review skill
-Skill(pre-push-review)
-
-# 6. Create ONE review fix commit (DON'T squash with original)'''
-
-    content = content.replace(old_quick_ref, new_quick_ref)
-
-    # 11. Update remaining quick reference steps
-    content = content.replace(
-        "# 6. Verify ALL replies posted\ngh pr view {pr_number} --comments",
-        "# 7. Verify ALL draft replies complete\n# Count drafts matches count of comments"
-    )
-    content = content.replace(
-        "# 7. Push (keeps commits separate for GitHub visibility)\ngit push",
-        "# 8. Push (keeps commits separate for GitHub visibility)\ngit push"
-    )
-
-    # 12. Update root cause section
-    content = content.replace(
-        "- Did NOT reply inline to each comment\n- Did NOT verify all replies posted",
-        "- Did NOT draft replies for each comment\n- Did NOT run pre-push-review"
-    )
-
-    # 13. Update "why protocol is mandatory" section
-    content = content.replace(
-        "- ✅ Clear communication (inline reply to each)",
-        "- ✅ Clear communication (draft reply for each)"
-    )
-
-    SKILL_PATH.write_text(content, encoding="utf-8")
-    print("Skill updated successfully!")
-
-
-if __name__ == "__main__":
-    main()