claude-dev-env 1.29.3 → 1.30.0

package/hooks/blocking/test_destructive_command_blocker.py

@@ -90,7 +90,7 @@ def test_suppresses_output_on_gh_redirect_deny() -> None:
 
 
 def test_asks_on_rm_rf_still_works() -> None:
-    payload = _make_bash_payload("rm -rf /tmp/somewhere")
+    payload = _make_bash_payload("rm -rf /var/log/myapp")
     result = _run_hook(payload)
     response = json.loads(result.stdout)
     assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
@@ -159,10 +159,287 @@ def test_gh_api_post_comment_is_allowed_when_redirect_env_var_is_unset() -> None
     assert result.returncode == 0
 
 
-def test_rm_rf_still_asks_when_redirect_env_var_is_unset() -> None:
-    payload = _make_bash_payload("rm -rf /tmp/somewhere")
+def _run_rm_hook(payload: dict) -> subprocess.CompletedProcess[str]:
+    child_environment = os.environ.copy()
+    child_environment.pop(GH_REDIRECT_ACTIVE_ENV_VAR, None)
+    child_environment.pop("CLAUDE_DESTRUCTIVE_DISABLE_EPHEMERAL_AUTO_ALLOW", None)
+    return subprocess.run(
+        [sys.executable, str(SCRIPT_PATH)],
+        input=json.dumps(payload),
+        text=True,
+        capture_output=True,
+        check=False,
+        env=child_environment,
+    )
 
-    result = _run_hook(payload, gh_redirect_active=False)
+
+def test_rm_rf_asks_when_target_is_non_ephemeral_path() -> None:
+    payload = _make_bash_payload("rm -rf /var/log/myapp")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_allowed_when_target_is_under_tmp_segment() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/some_scratch_dir")
+
+    result = _run_rm_hook(payload)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_rm_rf_allowed_when_target_is_under_os_temp_directory() -> None:
+    system_temp_subdirectory = Path(tempfile.mkdtemp(prefix="rm_target_"))
+    forward_slash_temp_path = str(system_temp_subdirectory).replace("\\", "/")
+    payload = _make_bash_payload(f"rm -rf {forward_slash_temp_path}")
+
+    result = _run_rm_hook(payload)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_rm_rf_allowed_when_target_is_under_worktrees_segment() -> None:
+    payload = _make_bash_payload("rm -rf /Users/me/repo/worktrees/feature_branch/build")
+
+    result = _run_rm_hook(payload)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_rm_rf_asks_when_target_is_bare_worktrees_directory() -> None:
+    payload = _make_bash_payload("rm -rf /Users/me/repo/worktrees")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_rm_includes_option_with_equals_sign() -> None:
+    payload = _make_bash_payload("rm -rf --files0-from=/tmp/list /tmp/scratch")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_allowed_when_both_targets_are_ephemeral() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/first_dir /tmp/second_dir")
+
+    result = _run_rm_hook(payload)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_rm_rf_asks_when_any_target_is_non_ephemeral() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/scratch /etc/passwd")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_double_dash_includes_hyphen_prefixed_non_ephemeral_target() -> None:
+    payload = _make_bash_payload("rm -rf -- /tmp/scratch -non_ephemeral")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_command_is_compound_with_ampersand() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/reply && gh pr checks 19")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_target_is_bare_tmp_root() -> None:
+    payload = _make_bash_payload("rm -rf /tmp")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_target_is_double_slash_tmp_root() -> None:
+    payload = _make_bash_payload("rm -rf //tmp")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_target_is_bare_os_temp_root() -> None:
+    payload = _make_bash_payload(f"rm -rf {tempfile.gettempdir()}")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_ephemeral_auto_allow_disabled_via_env_var() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/scratch")
+
+    child_environment = os.environ.copy()
+    child_environment.pop(GH_REDIRECT_ACTIVE_ENV_VAR, None)
+    child_environment["CLAUDE_DESTRUCTIVE_DISABLE_EPHEMERAL_AUTO_ALLOW"] = "1"
+    result = subprocess.run(
+        [sys.executable, str(SCRIPT_PATH)],
+        input=json.dumps(payload),
+        text=True,
+        capture_output=True,
+        check=False,
+        env=child_environment,
+    )
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_recursive_force_long_flags_allowed_under_tmp() -> None:
+    payload = _make_bash_payload("rm --recursive --force /tmp/long_flag_scratch")
+
+    result = _run_rm_hook(payload)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_rm_rf_asks_when_quoted_dotdot_traverses_out_of_ephemeral_root() -> None:
+    payload = _make_bash_payload('rm -rf /tmp/".."/etc')
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_allowed_when_quoted_path_is_legitimate_ephemeral() -> None:
+    payload = _make_bash_payload('rm -rf "/tmp/some scratch dir"')
+
+    result = _run_rm_hook(payload)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_rm_rf_asks_when_single_quoted_dotdot_traverses_out_of_ephemeral() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/'..'/etc")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_target_is_glob_wildcard_under_tmp() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/*")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_target_is_question_mark_glob_under_tmp() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/?")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_target_is_bracket_glob_under_tmp() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/[abc]")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_target_is_worktrees_glob() -> None:
+    payload = _make_bash_payload("rm -rf /worktrees/*")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_target_is_os_temp_root_glob() -> None:
+    system_temporary_root = tempfile.gettempdir()
+    forward_slash_temp_root = system_temporary_root.replace("\\", "/")
+    payload = _make_bash_payload(f"rm -rf {forward_slash_temp_root}/*")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_allowed_when_unquoted_windows_backslash_target_is_ephemeral() -> None:
+    system_temporary_root = tempfile.gettempdir()
+    windows_style_target = system_temporary_root.replace("/", "\\") + "\\scratch"
+    payload = _make_bash_payload(f"rm -rf {windows_style_target}")
+
+    result = _run_rm_hook(payload)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_rm_rf_allowed_when_unquoted_windows_backslash_target_contains_worktrees_segment() -> None:
+    payload = _make_bash_payload(
+        r"rm -rf C:\Users\developer\project\worktrees\feature_branch\build"
+    )
+
+    result = _run_rm_hook(payload)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_rm_rf_allowed_when_finding_example_windows_backslash_ephemeral_target() -> None:
+    payload = _make_bash_payload(
+        r"rm -rf C:\Users\jon\AppData\Local\Temp\scratch"
+    )
+
+    result = _run_rm_hook(payload)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_rm_rf_asks_when_target_is_literal_tmp_star_finding_example() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/*")
+
+    result = _run_rm_hook(payload)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"
+
+
+def test_rm_rf_asks_when_target_basename_is_wildcard_with_prefix_under_tmp() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/foo*")
+
+    result = _run_rm_hook(payload)
 
     response = json.loads(result.stdout)
     assert response["hookSpecificOutput"]["permissionDecision"] == "ask"

package/hooks/git-hooks/test_config.py

@@ -1,13 +1,19 @@
 from __future__ import annotations
 
+import importlib
 import sys
 from pathlib import Path
 
 
 SCRIPT_DIRECTORY = Path(__file__).resolve().parent
-if str(SCRIPT_DIRECTORY) not in sys.path:
-    sys.path.insert(0, str(SCRIPT_DIRECTORY))
-sys.modules.pop("config", None)
+_git_hooks_directory_string = str(SCRIPT_DIRECTORY)
+while _git_hooks_directory_string in sys.path:
+    sys.path.remove(_git_hooks_directory_string)
+sys.path.insert(0, _git_hooks_directory_string)
+for each_module_name in list(sys.modules):
+    if each_module_name == "config" or each_module_name.startswith("config."):
+        del sys.modules[each_module_name]
+importlib.invalidate_caches()
 
 import config
 

package/hooks/git-hooks/test_gate_utils.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import importlib
 import sys
 from pathlib import Path
 
@@ -7,9 +8,14 @@ import pytest
 
 
 SCRIPT_DIRECTORY = Path(__file__).resolve().parent
-if str(SCRIPT_DIRECTORY) not in sys.path:
-    sys.path.insert(0, str(SCRIPT_DIRECTORY))
-sys.modules.pop("config", None)
+_git_hooks_directory_string = str(SCRIPT_DIRECTORY)
+while _git_hooks_directory_string in sys.path:
+    sys.path.remove(_git_hooks_directory_string)
+sys.path.insert(0, _git_hooks_directory_string)
+for each_module_name in list(sys.modules):
+    if each_module_name == "config" or each_module_name.startswith("config."):
+        del sys.modules[each_module_name]
+importlib.invalidate_caches()
 
 import gate_utils
 

package/hooks/git-hooks/test_pre_commit.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import importlib
 import sys
 from pathlib import Path
 
@@ -7,9 +8,14 @@ import pytest
 
 
 SCRIPT_DIRECTORY = Path(__file__).resolve().parent
-if str(SCRIPT_DIRECTORY) not in sys.path:
-    sys.path.insert(0, str(SCRIPT_DIRECTORY))
-sys.modules.pop("config", None)
+_git_hooks_directory_string = str(SCRIPT_DIRECTORY)
+while _git_hooks_directory_string in sys.path:
+    sys.path.remove(_git_hooks_directory_string)
+sys.path.insert(0, _git_hooks_directory_string)
+for each_module_name in list(sys.modules):
+    if each_module_name == "config" or each_module_name.startswith("config."):
+        del sys.modules[each_module_name]
+importlib.invalidate_caches()
 
 import pre_commit
 

package/hooks/git-hooks/test_pre_push.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import importlib
 import io
 import sys
 from pathlib import Path
@@ -8,9 +9,14 @@ import pytest
 
 
 SCRIPT_DIRECTORY = Path(__file__).resolve().parent
-if str(SCRIPT_DIRECTORY) not in sys.path:
-    sys.path.insert(0, str(SCRIPT_DIRECTORY))
-sys.modules.pop("config", None)
+_git_hooks_directory_string = str(SCRIPT_DIRECTORY)
+while _git_hooks_directory_string in sys.path:
+    sys.path.remove(_git_hooks_directory_string)
+sys.path.insert(0, _git_hooks_directory_string)
+for each_module_name in list(sys.modules):
+    if each_module_name == "config" or each_module_name.startswith("config."):
+        del sys.modules[each_module_name]
+importlib.invalidate_caches()
 
 import pre_push
 import config

package/hooks/validators/run_all_validators.py

@@ -6,8 +6,10 @@ Exit code 0 = all checks pass, 1 = violations found.
 # pragma: no-tdd-gate
 
 import argparse
+import os
 import subprocess
 import sys
+import tempfile
 import time
 from dataclasses import dataclass
 from datetime import datetime
@@ -26,18 +28,89 @@ hooks_dir = VALIDATORS_DIR.parent
 package_name = VALIDATORS_DIR.name
 
 
+def _windows_non_unc_working_directory_string(
+    candidate_directory_strings: list[str | None],
+) -> str:
+    """Return the first candidate cwd that is not a UNC path (Windows only)."""
+    for each_candidate in candidate_directory_strings:
+        if each_candidate is None:
+            continue
+        expanded_candidate = str(Path(each_candidate).expanduser())
+        if expanded_candidate.startswith("\\\\"):
+            continue
+        return expanded_candidate
+    current_working_directory = os.getcwd()
+    expanded_current_working_directory = str(Path(current_working_directory).expanduser())
+    if not expanded_current_working_directory.startswith("\\\\"):
+        return expanded_current_working_directory
+    raise RuntimeError(
+        "Cannot find a non-UNC working directory for hook validator subprocesses."
+    )
+
+
+def _hooks_subprocess_working_directory_and_environment() -> tuple[str, dict[str, str]]:
+    """Return cwd and env for validator subprocesses.
+
+    On Windows, ``CreateProcess`` rejects some UNC working directories (invalid
+    directory name). When the hooks tree resolves to UNC, use a local temp cwd
+    and put the hooks directory on ``PYTHONPATH`` so ``python -m validators.*``
+    still resolves.
+    """
+    hooks_directory_string = str(hooks_dir.resolve())
+    environment = os.environ.copy()
+    previous_pythonpath = environment.get("PYTHONPATH", "")
+    environment["PYTHONPATH"] = (
+        hooks_directory_string
+        + (os.pathsep + previous_pythonpath if previous_pythonpath else "")
+    )
+    working_directory_string = hooks_directory_string
+    if sys.platform == "win32" and working_directory_string.startswith("\\\\"):
+        windows_temp_fallback_directory = str(Path(r"C:\Windows\Temp"))
+        working_directory_string = _windows_non_unc_working_directory_string(
+            [
+                os.environ.get("TEMP"),
+                os.environ.get("TMP"),
+                tempfile.gettempdir(),
+                windows_temp_fallback_directory,
+            ]
+        )
+    return working_directory_string, environment
+
+
 def invoke_validator_module(module_stem: str, forwarded_file_paths: List[str]) -> subprocess.CompletedProcess[str]:  # pragma: no-tdd-gate
     """Run a sibling validator as ``python -m validators.<module_stem>``.
 
-    The subprocess is launched with ``cwd`` set to the hooks directory so the
-    ``validators`` package qualifier resolves without requiring PYTHONPATH.
+    The subprocess uses the hooks tree on ``PYTHONPATH`` (and normally ``cwd``
+    there). On Windows, if that path is UNC, ``cwd`` falls back to a local temp
+    directory so ``CreateProcess`` succeeds.
     """
     qualified_module = ".".join([package_name, module_stem])
+    working_directory_string, environment = (
+        _hooks_subprocess_working_directory_and_environment()
+    )
     return subprocess.run(
         [sys.executable, "-m", qualified_module, *forwarded_file_paths],
         capture_output=True,
         text=True,
-        cwd=str(hooks_dir),
+        cwd=working_directory_string,
+        env=environment,
+    )
+
+
+def run_validators_entrypoint_subprocess(
+    extra_arguments: List[str],
+) -> subprocess.CompletedProcess[str]:
+    """Run ``python -m validators.run_all_validators`` with a Windows-safe cwd."""
+    working_directory_string, environment = (
+        _hooks_subprocess_working_directory_and_environment()
+    )
+    entry_module = f"{package_name}.run_all_validators"
+    return subprocess.run(
+        [sys.executable, "-m", entry_module, *extra_arguments],
+        capture_output=True,
+        text=True,
+        cwd=working_directory_string,
+        env=environment,
     )
 
 

package/hooks/validators/test_output_formatter.py

@@ -1,7 +1,6 @@
 """Tests for output formatting."""
 
-import os
-import sys
+import json
 
 import pytest
 
@@ -15,6 +14,7 @@ from .output_formatter import (
     ViolationDict,
     ValidatorResultDict,
 )
+from .run_all_validators import run_validators_entrypoint_subprocess
 
 
 class TestColorize:
@@ -93,21 +93,9 @@ class TestOutputFormatter:
 
 class TestJsonFlag:
     def test_json_flag_produces_valid_json(self) -> None:
-        import json
-        import subprocess
+        completed_validation_run = run_validators_entrypoint_subprocess(["--json"])
 
-        validators_directory = os.path.dirname(os.path.abspath(__file__))
-        hooks_directory = os.path.normpath(
-            os.path.join(validators_directory, os.pardir)
-        )
-        result = subprocess.run(
-            [sys.executable, "-m", "validators.run_all_validators", "--json"],
-            capture_output=True,
-            text=True,
-            cwd=hooks_directory,
-        )
-
-        output = result.stdout.strip()
+        output = completed_validation_run.stdout.strip()
         parsed = json.loads(output)
         assert "results" in parsed
         assert isinstance(parsed["results"], list)

package/hooks/validators/test_run_all_validators.py

@@ -1,6 +1,8 @@
 """Tests for run_all_validators.py."""
 
+import os
 import sys
+import tempfile
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
@@ -8,6 +10,7 @@ import pytest
 
 from .run_all_validators import (
     ValidatorResult,
+    _hooks_subprocess_working_directory_and_environment,
     add_timing,
     build_json_output,
     create_timing_metrics,
@@ -258,3 +261,22 @@ class TestVersionHeader:
         assert "version" in json_output
         assert "timestamp" in json_output
         assert isinstance(json_output["version"], str)
+
+
+class TestHooksSubprocessWorkingDirectory:
+    def test_unc_path_fallback_on_windows_uses_tempdir_when_temp_unset(self) -> None:
+        mock_hooks_directory = MagicMock()
+        mock_hooks_directory.resolve.return_value = Path("\\\\server\\share\\hooks")
+        environment_without_temp = {
+            each_key: each_value
+            for each_key, each_value in os.environ.items()
+            if each_key not in ("TEMP", "TMP")
+        }
+        with patch("validators.run_all_validators.hooks_dir", mock_hooks_directory), patch(
+            "validators.run_all_validators.sys.platform", "win32"
+        ), patch("validators.run_all_validators.os.environ", environment_without_temp):
+            working_directory_string, _environment = (
+                _hooks_subprocess_working_directory_and_environment()
+            )
+        assert working_directory_string == tempfile.gettempdir()
+        assert not working_directory_string.startswith("\\\\")

package/hooks/validators/test_run_all_validators_integration.py

@@ -1,21 +1,12 @@
 """Integration test for new validators in run_all_validators.py"""
 
 import subprocess
-import sys
-from pathlib import Path
 
-VALIDATORS_DIR = Path(__file__).parent
-HOOKS_DIR = VALIDATORS_DIR.parent
-PACKAGE_MODULE = f"{VALIDATORS_DIR.name}.run_all_validators"
+from .run_all_validators import run_validators_entrypoint_subprocess
 
 
 def run_validators_help() -> subprocess.CompletedProcess[str]:
-    return subprocess.run(
-        [sys.executable, "-m", PACKAGE_MODULE, "--help"],
-        capture_output=True,
-        text=True,
-        cwd=str(HOOKS_DIR),
-    )
+    return run_validators_entrypoint_subprocess(["--help"])
 
 
 class TestNewValidatorsIntegration:

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "1.29.3",
+    "version": "1.30.0",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {