claude-dev-env 1.29.1 → 1.29.3

package/hooks/blocking/test_pr_description_enforcer.py

@@ -208,7 +208,7 @@ def test_extract_body_reassembles_split_quoted_equals_value() -> None:
     assert extract_body_from_command(command) == "this body has multiple words"
 
 
-def test_read_body_file_rejects_relative_path_traversal(tmp_path) -> None:
+def test_read_body_file_rejects_relative_path_traversal(tmp_path, monkeypatch) -> None:
     import importlib.util, pathlib, sys
     _HOOK_DIR = pathlib.Path(__file__).parent
     if str(_HOOK_DIR) not in sys.path:
@@ -217,14 +217,15 @@ def test_read_body_file_rejects_relative_path_traversal(tmp_path) -> None:
     m = importlib.util.module_from_spec(spec)
     spec.loader.exec_module(m)
     import os, pytest
-    sentinel_file = tmp_path / 'secret.txt'
+    sentinel_directory = tmp_path / 'sentinel'
+    sentinel_directory.mkdir()
+    working_directory = tmp_path / 'workdir'
+    working_directory.mkdir()
+    sentinel_file = sentinel_directory / 'secret.txt'
     sentinel_file.write_text('secret')
-    try:
-        rel_path = os.path.relpath(str(sentinel_file))
-    except ValueError:
-        pytest.skip('tmp_path on different drive than cwd; relpath undefined on Windows')
-    if '..' not in rel_path:
-        pytest.skip('file is under cwd, not a traversal case')
+    monkeypatch.chdir(working_directory)
+    rel_path = os.path.relpath(str(sentinel_file))
+    assert '..' in rel_path, 'chdir to a sibling of the sentinel must produce a traversal relpath'
     with pytest.raises(m.PathTraversalError):
         m._read_body_file_contents(rel_path)
 

package/hooks/validators/test_files/skip_decorators/conftest.py

@@ -0,0 +1,9 @@
+"""Exclude validator fixture files from pytest collection.
+
+Files in this directory are inputs for a skip-detection validator (see
+packages/claude-dev-env/hooks/validators/), not real tests. Each file
+demonstrates a skip/xfail pattern the validator must detect. Collecting
+them as real tests produces spurious skipped/xfailed counts in the suite.
+"""
+
+collect_ignore_glob = ["test_*.py"]

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "1.29.1",
+    "version": "1.29.3",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/scripts/groq_bugteam.py

@@ -248,6 +248,8 @@ def should_write_fixed_file(
 def is_safe_relative_path(each_path: str) -> bool:
     if os.path.isabs(each_path):
         return False
+    if each_path.startswith(("/", "\\")):
+        return False
     normalized = os.path.normpath(each_path)
     if normalized.startswith(".." + os.sep) or normalized == "..":
         return False

package/scripts/tests/test_sync_to_cursor.py

@@ -3,20 +3,19 @@
 from __future__ import annotations
 
 import json
-import os
-import subprocess
 import sys
 from pathlib import Path
 
+import pytest
+
 _SCRIPTS_DIR = Path(__file__).resolve().parent.parent
 if str(_SCRIPTS_DIR) not in sys.path:
     sys.path.insert(0, str(_SCRIPTS_DIR))
 
 import sync_to_cursor as mod
+from sync_to_cursor.engine import run as run_sync_to_cursor
 from sync_to_cursor.rules import _read_paths_glob
 
-_SYNC_SCRIPT = _SCRIPTS_DIR / "sync_to_cursor.py"
-
 
 def _minimal_rule_files(claude_rules: Path) -> None:
     claude_rules.mkdir(parents=True, exist_ok=True)
@@ -72,66 +71,45 @@ def test_sync_canonical_docs_skips_missing_with_no_dst(tmp_path: Path) -> None:
     assert not (cursor / "docs" / "TEST_QUALITY.md").is_file()
 
 
-def test_check_fails_when_doc_source_changes_without_resync(tmp_path: Path) -> None:
+def test_check_fails_when_doc_source_changes_without_resync(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
     claude = tmp_path / ".claude"
-    cursor = tmp_path / ".cursor"
     _minimal_rule_files(claude / "rules")
     _minimal_code_rules_and_test_quality(claude / "docs")
-    env = {**os.environ, "LLM_SETTINGS_ROOT": str(tmp_path)}
-    subprocess.run(
-        [sys.executable, str(_SYNC_SCRIPT), "--force"],
-        env=env,
-        check=True,
-        cwd=str(_SCRIPTS_DIR),
-    )
+    monkeypatch.setenv("LLM_SETTINGS_ROOT", str(tmp_path))
+    assert run_sync_to_cursor(["--force"]) == 0
     (claude / "docs" / "CODE_RULES.md").write_bytes(b"changed\n")
-    subprocess_result = subprocess.run(
-        [sys.executable, str(_SYNC_SCRIPT), "--check"],
-        env=env,
-        cwd=str(_SCRIPTS_DIR),
-    )
-    assert subprocess_result.returncode != 0
+    assert run_sync_to_cursor(["--check"]) != 0
 
 
-def test_check_passes_after_resync(tmp_path: Path) -> None:
+def test_check_passes_after_resync(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
     claude = tmp_path / ".claude"
-    cursor = tmp_path / ".cursor"
     _minimal_rule_files(claude / "rules")
     _minimal_code_rules_and_test_quality(claude / "docs")
-    env = {**os.environ, "LLM_SETTINGS_ROOT": str(tmp_path)}
-    subprocess.run(
-        [sys.executable, str(_SYNC_SCRIPT), "--force"],
-        env=env,
-        check=True,
-        cwd=str(_SCRIPTS_DIR),
-    )
-    subprocess_result = subprocess.run(
-        [sys.executable, str(_SYNC_SCRIPT), "--check"],
-        env=env,
-        cwd=str(_SCRIPTS_DIR),
-    )
-    assert subprocess_result.returncode == 0
+    monkeypatch.setenv("LLM_SETTINGS_ROOT", str(tmp_path))
+    assert run_sync_to_cursor(["--force"]) == 0
+    assert run_sync_to_cursor(["--check"]) == 0
 
 
-def test_manifest_includes_docs_entries(tmp_path: Path) -> None:
+def test_manifest_includes_docs_entries(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
     claude = tmp_path / ".claude"
     cursor = tmp_path / ".cursor"
     _minimal_rule_files(claude / "rules")
     _minimal_code_rules_and_test_quality(claude / "docs")
-    env = {**os.environ, "LLM_SETTINGS_ROOT": str(tmp_path)}
-    subprocess.run(
-        [sys.executable, str(_SYNC_SCRIPT), "--force"],
-        env=env,
-        check=True,
-        cwd=str(_SCRIPTS_DIR),
-    )
+    monkeypatch.setenv("LLM_SETTINGS_ROOT", str(tmp_path))
+    assert run_sync_to_cursor(["--force"]) == 0
     manifest = json.loads((cursor / ".sync-manifest.json").read_text(encoding="utf-8"))
     assert "docs_entries" in manifest
-    de = manifest["docs_entries"]
-    assert "docs/CODE_RULES.md" in de
-    assert "docs/TEST_QUALITY.md" in de
-    assert "sources_hash" in de["docs/CODE_RULES.md"]
-    assert "output_hash" in de["docs/CODE_RULES.md"]
+    docs_entries = manifest["docs_entries"]
+    assert "docs/CODE_RULES.md" in docs_entries
+    assert "docs/TEST_QUALITY.md" in docs_entries
+    assert "sources_hash" in docs_entries["docs/CODE_RULES.md"]
+    assert "output_hash" in docs_entries["docs/CODE_RULES.md"]
 
 
 def test_merge_code_standards_with_pointer_style_code_rules(tmp_path: Path) -> None:
@@ -166,40 +144,28 @@ def test_sync_canonical_docs_deletes_stale_copy_when_source_removed(tmp_path: Pa
     assert not (cursor / "docs" / "CODE_RULES.md").is_file()
 
 
-def test_dry_run_does_not_create_output_directory(tmp_path: Path) -> None:
+def test_dry_run_does_not_create_output_directory(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
     claude = tmp_path / ".claude"
     cursor = tmp_path / ".cursor"
     _minimal_rule_files(claude / "rules")
     _minimal_code_rules_and_test_quality(claude / "docs")
-    env = {**os.environ, "LLM_SETTINGS_ROOT": str(tmp_path)}
-    subprocess.run(
-        [sys.executable, str(_SYNC_SCRIPT), "--dry-run", "--quiet"],
-        env=env,
-        check=True,
-        cwd=str(_SCRIPTS_DIR),
-    )
+    monkeypatch.setenv("LLM_SETTINGS_ROOT", str(tmp_path))
+    assert run_sync_to_cursor(["--dry-run", "--quiet"]) == 0
     assert not (cursor / "rules").exists(), "--dry-run must not create the output directory"
 
 
-def test_check_skips_optional_mapping_when_source_missing(tmp_path: Path) -> None:
+def test_check_skips_optional_mapping_when_source_missing(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
     claude = tmp_path / ".claude"
-    cursor = tmp_path / ".cursor"
     _minimal_rule_files(claude / "rules")
     _minimal_code_rules_and_test_quality(claude / "docs")
-    env = {**os.environ, "LLM_SETTINGS_ROOT": str(tmp_path)}
-    subprocess.run(
-        [sys.executable, str(_SYNC_SCRIPT), "--force"],
-        env=env,
-        check=True,
-        cwd=str(_SCRIPTS_DIR),
-    )
+    monkeypatch.setenv("LLM_SETTINGS_ROOT", str(tmp_path))
+    assert run_sync_to_cursor(["--force"]) == 0
     (claude / "rules" / "tasklings-preferences.md").unlink()
-    subprocess_result = subprocess.run(
-        [sys.executable, str(_SYNC_SCRIPT), "--check"],
-        env=env,
-        cwd=str(_SCRIPTS_DIR),
-    )
-    assert subprocess_result.returncode == 0, "--check must pass when only optional sources are missing"
+    assert run_sync_to_cursor(["--check"]) == 0, "--check must pass when only optional sources are missing"
 
 
 def test_tasklings_glob_derived_from_frontmatter(tmp_path: Path) -> None:

package/skills/qbug/test_qbug_skill_audit_schema.py

@@ -112,10 +112,10 @@ def test_contract_should_require_files_opened_in_proof_of_absence() -> None:
     )
 
 
-def test_step2_spawn_should_include_model_sonnet_parameter() -> None:
+def test_step2_spawn_should_include_model_opus_parameter() -> None:
     skill_text = _load_skill_text()
-    assert 'model="sonnet"' in skill_text, (
-        "Step 2 Agent() spawn template must include model=\"sonnet\" for the primary subagent"
+    assert 'model="opus"' in skill_text, (
+        "Step 2 Agent() spawn template must include model=\"opus\" for the primary subagent"
     )