claude-dev-env 1.28.1 → 1.29.0

package/hooks/config/project_paths_reader.py

@@ -0,0 +1,78 @@
+"""Load the per-user project-path registry from ~/.claude/project-paths.json."""
+
+from __future__ import annotations
+
+import json
+import logging
+import os
+from pathlib import Path
+
+from config.dynamic_stderr_handler import DynamicStderrHandler
+from config.setup_project_paths_constants import META_KEY, UTF8_ENCODING
+
+
+_logger = logging.getLogger("project_paths_reader")
+if not _logger.handlers:
+    _stderr_handler = DynamicStderrHandler()
+    _stderr_handler.setFormatter(logging.Formatter("%(name)s: %(message)s"))
+    _logger.addHandler(_stderr_handler)
+    _logger.setLevel(logging.INFO)
+    _logger.propagate = False
+
+
+def registry_file_path() -> Path:
+    """Return the canonical path to ~/.claude/project-paths.json."""
+    return Path.home() / ".claude" / "project-paths.json"
+
+
+def _default_config_path() -> Path:
+    return registry_file_path()
+
+
+def _normalize_path_separators(raw_path: str) -> str:
+    forward_slash_form = raw_path.replace("\\", "/")
+    return os.path.normcase(os.path.normpath(forward_slash_form)).replace("\\", "/")
+
+
+def load_registry(config_path: Path | None = None) -> dict[str, str]:
+    """Return the name-to-absolute-path mapping with the _meta key stripped.
+
+    Returns an empty dict when the file is missing, unreadable, malformed,
+    or otherwise invalid. Logs one line to stderr when the file cannot be
+    read or contains malformed JSON.
+    """
+    resolved_path = config_path if config_path is not None else _default_config_path()
+    if not resolved_path.is_file():
+        return {}
+    try:
+        raw_text = resolved_path.read_text(encoding=UTF8_ENCODING)
+    except OSError as e:
+        _logger.error("cannot read %s: %s", resolved_path, e)
+        return {}
+    try:
+        parsed = json.loads(raw_text)
+    except json.JSONDecodeError as e:
+        _logger.error("malformed JSON in %s: %s", resolved_path, e)
+        return {}
+    if not isinstance(parsed, dict):
+        return {}
+    return {
+        each_key: each_value
+        for each_key, each_value in parsed.items()
+        if each_key != META_KEY
+        and isinstance(each_key, str)
+        and isinstance(each_value, str)
+    }
+
+
+def registry_contains_path(known_registry: dict[str, str], path_to_find: str) -> bool:
+    """Return True when the given path appears as any registry value.
+
+    Normalizes both sides before comparing so Windows and POSIX separator
+    forms of the same path compare equal.
+    """
+    normalized_target = _normalize_path_separators(path_to_find)
+    for each_registered_path in known_registry.values():
+        if _normalize_path_separators(each_registered_path) == normalized_target:
+            return True
+    return False

package/hooks/config/setup_project_paths_constants.py

@@ -0,0 +1,41 @@
+"""Configuration constants for the setup_project_paths bootstrap script.
+
+Shared constants consumed by two or more modules across the hook subsystem.
+Single-use values are inlined into their consuming functions per the
+file-global-constants use-count rule.
+"""
+
+from __future__ import annotations
+
+ES_EXE_FOLDERS_ONLY_QUERY_ARGUMENTS = ("/ad", "folder:.git")
+
+EXCLUDED_PATH_SEGMENTS = frozenset(
+    {
+        "temp",
+        "tmp",
+        "worktree",
+        "node_modules",
+        ".cache",
+        "$recycle.bin",
+    }
+)
+
+JSON_INDENT_SPACES = 2
+
+GIT_DIRECTORY_SEGMENT_NAME = ".git"
+
+ES_EXE_BINARY_NAME = "es.exe"
+
+SUPPORTED_SCHEMA_VERSION = 1
+
+META_KEY = "_meta"
+
+UTF8_ENCODING = "utf-8"
+
+CONFIRMATION_PROMPT_TEXT = "Write this mapping to the config file? (yes/no): "
+
+ABORTED_NOTHING_WRITTEN_MESSAGE = "Aborted. Nothing written."
+
+WROTE_ENTRIES_STATUS_TEMPLATE = "Wrote {entry_count} entries to {save_path}."
+
+STDERR_TRUNCATION_LENGTH = 200

package/hooks/config/test_dynamic_stderr_handler.py

@@ -0,0 +1,48 @@
+"""Tests for DynamicStderrHandler — resolves sys.stderr at emit time."""
+
+from __future__ import annotations
+
+import logging
+import sys
+from io import StringIO
+from pathlib import Path
+from unittest.mock import patch
+
+_HOOKS_ROOT = Path(__file__).resolve().parent.parent
+if str(_HOOKS_ROOT) not in sys.path:
+    sys.path.insert(0, str(_HOOKS_ROOT))
+
+from config.dynamic_stderr_handler import DynamicStderrHandler
+
+
+def _make_logger_with_handler() -> tuple[logging.Logger, DynamicStderrHandler]:
+    handler_instance = DynamicStderrHandler()
+    handler_instance.setFormatter(logging.Formatter("%(name)s: %(message)s"))
+    test_logger = logging.getLogger("test_dynamic_stderr_handler_logger")
+    for each_existing_handler in list(test_logger.handlers):
+        test_logger.removeHandler(each_existing_handler)
+    test_logger.addHandler(handler_instance)
+    test_logger.setLevel(logging.INFO)
+    test_logger.propagate = False
+    return test_logger, handler_instance
+
+
+def test_emit_writes_to_current_sys_stderr() -> None:
+    test_logger, _ = _make_logger_with_handler()
+    captured_stderr = StringIO()
+    with patch("sys.stderr", captured_stderr):
+        test_logger.error("hello from handler")
+    assert "hello from handler" in captured_stderr.getvalue()
+
+
+def test_emit_resolves_stderr_at_emit_time_not_construction_time() -> None:
+    test_logger, _ = _make_logger_with_handler()
+    first_captured_stderr = StringIO()
+    second_captured_stderr = StringIO()
+    with patch("sys.stderr", first_captured_stderr):
+        test_logger.error("first message")
+    with patch("sys.stderr", second_captured_stderr):
+        test_logger.error("second message")
+    assert "first message" in first_captured_stderr.getvalue()
+    assert "second message" in second_captured_stderr.getvalue()
+    assert "second message" not in first_captured_stderr.getvalue()

package/hooks/config/test_messages.py

@@ -1,4 +1,8 @@
-"""Smoke tests for hooks.config.messages — verify user-facing notice constants exist."""
+"""Smoke tests for config.messages — verify user-facing notice constants exist."""
+
+import sys
+
+sys.modules.pop("config", None)
 
 from config import messages
 

package/hooks/config/test_path_rewriter_constants.py

@@ -0,0 +1,57 @@
+"""Pin tests for path_rewriter_constants — values consumed by es_exe_path_rewriter."""
+
+import sys
+from pathlib import Path
+
+_HOOKS_ROOT = Path(__file__).resolve().parent.parent
+if str(_HOOKS_ROOT) not in sys.path:
+    sys.path.insert(0, str(_HOOKS_ROOT))
+
+from config.path_rewriter_constants import (
+    BASH_TOOL_NAME,
+    HOOK_EVENT_NAME,
+    PERMISSION_ALLOW,
+    PLACEHOLDER_TOKEN_PATTERN,
+)
+
+
+def test_bash_tool_name_is_bash() -> None:
+    assert BASH_TOOL_NAME == "Bash"
+
+
+def test_hook_event_name_is_pre_tool_use() -> None:
+    assert HOOK_EVENT_NAME == "PreToolUse"
+
+
+def test_permission_allow_is_allow() -> None:
+    assert PERMISSION_ALLOW == "allow"
+
+
+def test_placeholder_token_pattern_matches_curly_brace_form() -> None:
+    match = PLACEHOLDER_TOKEN_PATTERN.match("{my-repo}")
+    assert match is not None
+    assert match.group(1) == "my-repo"
+
+
+def test_placeholder_token_pattern_matches_double_quoted_form() -> None:
+    match = PLACEHOLDER_TOKEN_PATTERN.match('"{my-repo}"')
+    assert match is not None
+    assert match.group(1) == "my-repo"
+
+
+def test_placeholder_token_pattern_matches_single_quoted_form() -> None:
+    match = PLACEHOLDER_TOKEN_PATTERN.match("'{my-repo}'")
+    assert match is not None
+    assert match.group(1) == "my-repo"
+
+
+def test_placeholder_token_pattern_does_not_match_shell_parameter_expansion() -> None:
+    assert PLACEHOLDER_TOKEN_PATTERN.search("${myrepo}") is None
+
+
+def test_placeholder_token_pattern_does_not_match_embedded_in_flag() -> None:
+    assert PLACEHOLDER_TOKEN_PATTERN.search("--flag={my-repo}") is None
+
+
+def test_placeholder_token_pattern_does_not_match_embedded_in_token() -> None:
+    assert PLACEHOLDER_TOKEN_PATTERN.search("foo{my-repo}bar") is None

package/hooks/config/test_project_paths_reader.py

@@ -0,0 +1,149 @@
+"""Tests for project_paths_reader — config reader for ~/.claude/project-paths.json."""
+
+import inspect
+import json
+import sys
+from pathlib import Path
+
+import pytest
+
+_HOOKS_ROOT = Path(__file__).resolve().parent.parent
+if str(_HOOKS_ROOT) not in sys.path:
+    sys.path.insert(0, str(_HOOKS_ROOT))
+
+from config import project_paths_reader
+from config.project_paths_reader import (
+    load_registry,
+    registry_contains_path,
+    registry_file_path,
+)
+from config.setup_project_paths_constants import META_KEY
+
+
+def test_reader_does_not_redefine_dynamic_stderr_handler_locally() -> None:
+    """Pin PR #230 round 3 DRY fix: handler is imported from the shared module.
+
+    Both project_paths_reader and es_exe_path_rewriter previously defined
+    identical `_DynamicStderrHandler` classes. This test fails if the
+    duplicate class reappears in project_paths_reader.
+    """
+    assert not hasattr(project_paths_reader, "_DynamicStderrHandler")
+
+
+def test_load_registry_returns_empty_dict_when_file_missing(tmp_path: Path) -> None:
+    missing_path = tmp_path / "nonexistent.json"
+    loaded_registry = load_registry(config_path=missing_path)
+    assert loaded_registry == {}
+
+
+def test_load_registry_returns_empty_dict_when_json_is_malformed(
+    tmp_path: Path,
+) -> None:
+    malformed_file = tmp_path / "project-paths.json"
+    malformed_file.write_text("{ not valid json", encoding="utf-8")
+    loaded_registry = load_registry(config_path=malformed_file)
+    assert loaded_registry == {}
+
+
+def test_load_registry_strips_meta_key(tmp_path: Path) -> None:
+    registry_file = tmp_path / "project-paths.json"
+    registry_file.write_text(
+        json.dumps(
+            {
+                "_meta": {"schema_version": 1, "last_scan": "2026-01-01T00:00:00Z"},
+                "my-repo": "Y:\\Projects\\my-repo",
+            }
+        ),
+        encoding="utf-8",
+    )
+    loaded_registry = load_registry(config_path=registry_file)
+    assert "_meta" not in loaded_registry
+    assert loaded_registry["my-repo"] == "Y:\\Projects\\my-repo"
+
+
+def test_load_registry_returns_name_to_path_mapping(tmp_path: Path) -> None:
+    registry_file = tmp_path / "project-paths.json"
+    registry_file.write_text(
+        json.dumps(
+            {
+                "repo-alpha": "Y:\\Projects\\repo-alpha",
+                "repo-beta": "C:\\Dev\\repo-beta",
+            }
+        ),
+        encoding="utf-8",
+    )
+    loaded_registry = load_registry(config_path=registry_file)
+    assert loaded_registry == {
+        "repo-alpha": "Y:\\Projects\\repo-alpha",
+        "repo-beta": "C:\\Dev\\repo-beta",
+    }
+
+
+def test_load_registry_returns_empty_dict_when_top_level_is_not_object(
+    tmp_path: Path,
+) -> None:
+    registry_file = tmp_path / "project-paths.json"
+    registry_file.write_text(json.dumps(["a", "b"]), encoding="utf-8")
+    loaded_registry = load_registry(config_path=registry_file)
+    assert loaded_registry == {}
+
+
+def test_registry_contains_path_returns_true_when_path_present(tmp_path: Path) -> None:
+    known_registry = {"my-repo": str(tmp_path)}
+    assert registry_contains_path(known_registry, str(tmp_path)) is True
+
+
+def test_registry_contains_path_returns_false_when_path_absent(tmp_path: Path) -> None:
+    known_registry = {"other-repo": "C:\\Other\\Path"}
+    assert registry_contains_path(known_registry, str(tmp_path)) is False
+
+
+def test_registry_contains_path_normalizes_separators(tmp_path: Path) -> None:
+    forward_slash_path = str(tmp_path).replace("\\", "/")
+    known_registry = {"my-repo": str(tmp_path)}
+    assert registry_contains_path(known_registry, forward_slash_path) is True
+
+
+def test_registry_contains_path_treats_backslash_and_forward_slash_as_equal() -> None:
+    backslash_path = "C:\\foo\\bar"
+    forward_slash_path = "C:/foo/bar"
+    known_registry = {"my-repo": backslash_path}
+    assert registry_contains_path(known_registry, forward_slash_path) is True
+    known_registry_forward = {"my-repo": forward_slash_path}
+    assert registry_contains_path(known_registry_forward, backslash_path) is True
+
+
+def test_registry_file_path_returns_dot_claude_project_paths_json() -> None:
+    resolved_path = registry_file_path()
+    assert resolved_path.name == "project-paths.json"
+    assert resolved_path.parent.name == ".claude"
+    assert resolved_path.parent.parent == Path.home()
+
+
+def test_registry_file_path_is_absolute() -> None:
+    resolved_path = registry_file_path()
+    assert resolved_path.is_absolute()
+
+
+def test_load_registry_uses_shared_meta_key_constant() -> None:
+    """Pin: load_registry must import META_KEY from setup_project_paths_constants.
+
+    The bare string literal "_meta" must not appear in load_registry;
+    it must use the shared META_KEY constant as the single source of truth.
+    """
+    source = inspect.getsource(project_paths_reader.load_registry)
+    assert '"_meta"' not in source, (
+        'load_registry must use META_KEY constant, not the bare literal "_meta"'
+    )
+
+
+def test_load_registry_uses_shared_utf8_encoding_constant() -> None:
+    """Pin fix_1: load_registry must import UTF8_ENCODING from setup_project_paths_constants.
+
+    The bare string literal "utf-8" in the read_text call must be replaced
+    with the shared constant so there is one source of truth for the encoding name.
+    """
+    source = inspect.getsource(project_paths_reader)
+    assert 'encoding="utf-8"' not in source, (
+        'load_registry must use UTF8_ENCODING constant, not the bare literal "utf-8"'
+    )

package/hooks/config/test_setup_project_paths_constants.py

@@ -0,0 +1,74 @@
+"""Regression-guard tests for setup_project_paths_constants module."""
+
+from __future__ import annotations
+
+import sys
+from pathlib import Path
+
+_HOOKS_ROOT = Path(__file__).resolve().parent.parent
+if str(_HOOKS_ROOT) not in sys.path:
+    sys.path.insert(0, str(_HOOKS_ROOT))
+
+import config.setup_project_paths_constants as constants_module
+from config.setup_project_paths_constants import (
+    ABORTED_NOTHING_WRITTEN_MESSAGE,
+    CONFIRMATION_PROMPT_TEXT,
+    ES_EXE_FOLDERS_ONLY_QUERY_ARGUMENTS,
+    STDERR_TRUNCATION_LENGTH,
+    WROTE_ENTRIES_STATUS_TEMPLATE,
+)
+
+
+def test_es_exe_arguments_is_immutable_tuple() -> None:
+    """Pin PR #230 round 6: constant must be a tuple, not a mutable list.
+
+    Tuples unpack identically into subprocess.run([...]) args and prevent
+    accidental mutation of the shared constant at call sites.
+    """
+    assert isinstance(ES_EXE_FOLDERS_ONLY_QUERY_ARGUMENTS, tuple)
+
+
+def test_es_exe_arguments_contains_folders_only_flag() -> None:
+    assert "/ad" in ES_EXE_FOLDERS_ONLY_QUERY_ARGUMENTS
+
+
+def test_es_exe_arguments_contains_git_folder_query() -> None:
+    assert "folder:.git" in ES_EXE_FOLDERS_ONLY_QUERY_ARGUMENTS
+
+
+def test_es_exe_arguments_do_not_include_name_flag() -> None:
+    assert "-name" not in ES_EXE_FOLDERS_ONLY_QUERY_ARGUMENTS
+
+
+def test_user_config_file_relative_parts_is_removed() -> None:
+    """Pin PR #230 round 7: dead constant USER_CONFIG_FILE_RELATIVE_PARTS removed.
+
+    This constant had zero references after round 6 moved the canonical
+    source to registry_file_path() in project_paths_reader.py.
+    """
+    assert not hasattr(constants_module, "USER_CONFIG_FILE_RELATIVE_PARTS")
+
+
+def test_confirmation_prompt_text_constant_exists() -> None:
+    """Pin PR #230 round 7: prompt string extracted from prompt_and_write magic values."""
+    assert isinstance(CONFIRMATION_PROMPT_TEXT, str)
+    assert len(CONFIRMATION_PROMPT_TEXT) > 0
+
+
+def test_aborted_nothing_written_message_constant_exists() -> None:
+    """Pin PR #230 round 7: abort message extracted from prompt_and_write magic values."""
+    assert isinstance(ABORTED_NOTHING_WRITTEN_MESSAGE, str)
+    assert len(ABORTED_NOTHING_WRITTEN_MESSAGE) > 0
+
+
+def test_wrote_entries_status_template_constant_exists() -> None:
+    """Pin PR #230 round 7: success message template extracted from prompt_and_write magic values."""
+    assert isinstance(WROTE_ENTRIES_STATUS_TEMPLATE, str)
+    assert "{entry_count}" in WROTE_ENTRIES_STATUS_TEMPLATE
+    assert "{save_path}" in WROTE_ENTRIES_STATUS_TEMPLATE
+
+
+def test_stderr_truncation_length_constant_exists() -> None:
+    """Pin PR #230 round 9: STDERR_TRUNCATION_LENGTH required for EverythingScanError messages."""
+    assert isinstance(STDERR_TRUNCATION_LENGTH, int)
+    assert STDERR_TRUNCATION_LENGTH > 0

package/hooks/git-hooks/test_config.py

@@ -7,6 +7,7 @@ from pathlib import Path
 SCRIPT_DIRECTORY = Path(__file__).resolve().parent
 if str(SCRIPT_DIRECTORY) not in sys.path:
     sys.path.insert(0, str(SCRIPT_DIRECTORY))
+sys.modules.pop("config", None)
 
 import config
 

package/hooks/git-hooks/test_gate_utils.py

@@ -9,6 +9,7 @@ import pytest
 SCRIPT_DIRECTORY = Path(__file__).resolve().parent
 if str(SCRIPT_DIRECTORY) not in sys.path:
     sys.path.insert(0, str(SCRIPT_DIRECTORY))
+sys.modules.pop("config", None)
 
 import gate_utils
 

package/hooks/git-hooks/test_pre_commit.py

@@ -9,6 +9,7 @@ import pytest
 SCRIPT_DIRECTORY = Path(__file__).resolve().parent
 if str(SCRIPT_DIRECTORY) not in sys.path:
     sys.path.insert(0, str(SCRIPT_DIRECTORY))
+sys.modules.pop("config", None)
 
 import pre_commit
 

package/hooks/git-hooks/test_pre_push.py

@@ -10,6 +10,7 @@ import pytest
 SCRIPT_DIRECTORY = Path(__file__).resolve().parent
 if str(SCRIPT_DIRECTORY) not in sys.path:
     sys.path.insert(0, str(SCRIPT_DIRECTORY))
+sys.modules.pop("config", None)
 
 import pre_push
 import config

package/hooks/hooks.json

@@ -60,6 +60,11 @@
       {
         "matcher": "Bash",
         "hooks": [
+          {
+            "type": "command",
+            "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/blocking/es_exe_path_rewriter.py",
+            "timeout": 10
+          },
           {
             "type": "command",
             "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/blocking/destructive_command_blocker.py",
@@ -106,6 +111,11 @@
             "type": "command",
             "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/session/plugin_data_dir_cleanup.py",
             "timeout": 10
+          },
+          {
+            "type": "command",
+            "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/session/untracked_repo_detector.py",
+            "timeout": 10
           }
         ]
       }