claude-dev-env 1.26.4 → 1.26.5

package/hooks/blocking/hedging_language_blocker.py

@@ -11,6 +11,9 @@ import os
 import re
 import sys
 
+sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "config"))
+from messages import USER_FACING_NOTICE
+
 PLUGIN_ROOT = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
 RESEARCH_MODE_SKILL_SEARCH_PATHS = [
@@ -99,14 +102,19 @@ def main() -> None:
 
     formatted_term_list = ", ".join(f'"{term}"' for term in found_hedging_terms)
 
-    research_mode_content = "(Could not load research-mode skill file)"
+    resolved_skill_path: str | None = None
     for each_skill_path in RESEARCH_MODE_SKILL_SEARCH_PATHS:
-        try:
-            with open(each_skill_path, encoding="utf-8") as skill_file:
-                research_mode_content = skill_file.read()
-                break
-        except OSError:
-            continue
+        if os.path.exists(each_skill_path):
+            resolved_skill_path = each_skill_path
+            break
+
+    if resolved_skill_path is not None:
+        skill_reference = f"under the research-mode constraints defined in:\n\n{resolved_skill_path}"
+    else:
+        skill_reference = (
+            "under research-mode constraints "
+            "(no research-mode skill installed; verify with sources or reply 'I don't know')"
+        )
 
     block_response = {
         "decision": "block",
@@ -114,12 +122,13 @@ def main() -> None:
             f"ANTI-HALLUCINATION GUARDRAIL: Your response contains hedging language: "
             f"{formatted_term_list}. "
             f"These words signal unverified claims. You MUST rewrite your response "
-            f"with these constraints active:\n\n"
-            f"{research_mode_content}\n\n"
+            f"{skill_reference}\n\n"
             f"Do NOT simply remove the hedging word and keep the unverified claim. "
             f"Either VERIFY it with a source or replace it with 'I don't know'.\n\n"
             f"You MUST re-output the complete, revised response with the corrections applied."
         ),
+        "systemMessage": USER_FACING_NOTICE,
+        "suppressOutput": True,
     }
 
     print(json.dumps(block_response))

package/hooks/blocking/test_hedging_language_blocker.py

@@ -0,0 +1,135 @@
+"""Tests for hedging_language_blocker hook response shape."""
+
+import importlib.util
+import json
+import os
+import subprocess
+import sys
+import tempfile
+
+HOOK_SCRIPT_PATH = os.path.join(os.path.dirname(__file__), "hedging_language_blocker.py")
+_HOOKS_DIR = os.path.dirname(HOOK_SCRIPT_PATH)
+_CONFIG_DIR = os.path.join(_HOOKS_DIR, "..", "config")
+if _HOOKS_DIR not in sys.path:
+    sys.path.insert(0, _HOOKS_DIR)
+if _CONFIG_DIR not in sys.path:
+    sys.path.insert(0, _CONFIG_DIR)
+import hedging_language_blocker
+from messages import USER_FACING_NOTICE
+
+RESEARCH_MODE_SKILL_BODY_MARKER = "Three anti-hallucination constraints are ALWAYS active."
+HEDGING_MESSAGE = "This is likely correct."
+CLEAN_MESSAGE = "This is verified by the source document."
+EMPTY_MESSAGE = ""
+
+
+def run_hook_with_message(assistant_message: str) -> subprocess.CompletedProcess:
+    hook_input_payload = json.dumps({"last_assistant_message": assistant_message})
+    return subprocess.run(
+        [sys.executable, HOOK_SCRIPT_PATH],
+        input=hook_input_payload,
+        capture_output=True,
+        text=True,
+        check=False,
+    )
+
+
+def run_hook_with_patched_search_paths(
+    assistant_message: str,
+    search_paths: list[str],
+) -> subprocess.CompletedProcess:
+    """Run the hook with RESEARCH_MODE_SKILL_SEARCH_PATHS overridden via a wrapper script."""
+    wrapper_script = (
+        "import sys, json, os\n"
+        f"sys.path.insert(0, {repr(os.path.dirname(HOOK_SCRIPT_PATH))})\n"
+        "import hedging_language_blocker as blocker\n"
+        f"blocker.RESEARCH_MODE_SKILL_SEARCH_PATHS = {repr(search_paths)}\n"
+        "blocker.main()\n"
+    )
+    with tempfile.NamedTemporaryFile(mode="w", suffix=".py", delete=False) as wrapper_file:
+        wrapper_file.write(wrapper_script)
+        wrapper_file_path = wrapper_file.name
+
+    hook_input_payload = json.dumps({"last_assistant_message": assistant_message})
+    try:
+        completed_process = subprocess.run(
+            [sys.executable, wrapper_file_path],
+            input=hook_input_payload,
+            capture_output=True,
+            text=True,
+            check=False,
+        )
+    finally:
+        os.unlink(wrapper_file_path)
+    return completed_process
+
+
+def test_user_facing_notice_importable_from_config_messages():
+    config_messages_path = os.path.join(_CONFIG_DIR, "messages.py")
+    specification = importlib.util.spec_from_file_location("messages", config_messages_path)
+    module = importlib.util.module_from_spec(specification)
+    specification.loader.exec_module(module)
+
+    assert module.USER_FACING_NOTICE == USER_FACING_NOTICE
+
+
+def test_hedging_message_emits_block_with_short_user_notice():
+    completed_process = run_hook_with_message(HEDGING_MESSAGE)
+
+    assert completed_process.returncode == 0
+    parsed_response = json.loads(completed_process.stdout)
+
+    assert parsed_response["decision"] == "block"
+    assert parsed_response["systemMessage"] == USER_FACING_NOTICE
+    assert parsed_response["suppressOutput"] is True
+    assert "likely" in parsed_response["reason"]
+
+
+def test_hedging_reason_contains_not_installed_notice_when_skill_absent():
+    completed_process = run_hook_with_patched_search_paths(
+        HEDGING_MESSAGE,
+        ["/nonexistent/path/one/SKILL.md", "/nonexistent/path/two/SKILL.md"],
+    )
+
+    assert completed_process.returncode == 0
+    parsed_response = json.loads(completed_process.stdout)
+
+    assert parsed_response["decision"] == "block"
+    assert "no research-mode skill installed" in parsed_response["reason"]
+    assert "verify with sources or reply" in parsed_response["reason"]
+    assert "SKILL.md" not in parsed_response["reason"]
+    assert RESEARCH_MODE_SKILL_BODY_MARKER not in parsed_response["reason"]
+
+
+def test_hedging_reason_contains_skill_path_when_skill_present():
+    with tempfile.TemporaryDirectory() as skill_dir:
+        skill_file_path = os.path.join(skill_dir, "SKILL.md")
+        with open(skill_file_path, "w") as skill_file:
+            skill_file.write("# Research Mode Skill\n")
+
+        completed_process = run_hook_with_patched_search_paths(
+            HEDGING_MESSAGE,
+            ["/nonexistent/path/SKILL.md", skill_file_path],
+        )
+
+    assert completed_process.returncode == 0
+    parsed_response = json.loads(completed_process.stdout)
+
+    assert parsed_response["decision"] == "block"
+    assert "SKILL.md" in parsed_response["reason"]
+    assert "no research-mode skill installed" not in parsed_response["reason"]
+    assert RESEARCH_MODE_SKILL_BODY_MARKER not in parsed_response["reason"]
+
+
+def test_clean_message_passes_through_with_no_output():
+    completed_process = run_hook_with_message(CLEAN_MESSAGE)
+
+    assert completed_process.returncode == 0
+    assert completed_process.stdout == ""
+
+
+def test_empty_message_passes_through_with_no_output():
+    completed_process = run_hook_with_message(EMPTY_MESSAGE)
+
+    assert completed_process.returncode == 0
+    assert completed_process.stdout == ""

package/hooks/config/__init__.py

@@ -0,0 +1 @@
+# pragma: no-tdd-gate

package/hooks/config/messages.py

@@ -0,0 +1,4 @@
+# pragma: no-tdd-gate
+"""User-facing notice messages for blocking hooks."""
+
+USER_FACING_NOTICE = "Agent was found guessing - sourcing opinions..."

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "1.26.4",
+    "version": "1.26.5",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {