claude-dev-env 1.26.0 → 1.26.2

package/hooks/blocking/code_rules_enforcer.py

@@ -1036,6 +1036,8 @@ def _resolve_enclosing_function_qname(
             break
         current_ancestor = parent_by_child_id.get(id(current_ancestor))
     if enclosing_function_name is None:
+        if enclosing_class_name is not None:
+            return f"<class:{enclosing_class_name}>"
         return None
     if enclosing_class_name is not None:
         return f"{enclosing_class_name}.{enclosing_function_name}"
@@ -1077,7 +1079,9 @@ def check_file_global_constants_use_count(content: str, file_path: str) -> list[
         if each_node.id not in callers_by_constant:
             continue
         enclosing_qname = _resolve_enclosing_function_qname(each_node, parent_by_child_id)
-        if enclosing_qname is not None:
+        if enclosing_qname is None:
+            callers_by_constant[each_node.id].add("<module-scope>")
+        else:
             callers_by_constant[each_node.id].add(enclosing_qname)
 
     issues: list[str] = []

package/hooks/blocking/test_code_rules_enforcer.py

@@ -0,0 +1,61 @@
+"""Tests covering file-global constant reference resolution edge cases.
+
+Loop2-C: class-decorator usage of a module-level constant must count as a
+caller so the single-caller rule fires correctly.
+
+Loop2-D: module-scope usages must register as a distinct caller bucket so
+the "zero function references" exemption does not swallow real references.
+"""
+
+from __future__ import annotations
+
+import importlib.util
+from pathlib import Path
+from types import ModuleType
+
+
+def _load_enforcer_module() -> ModuleType:
+    module_path = Path(__file__).parent / "code_rules_enforcer.py"
+    spec = importlib.util.spec_from_file_location("code_rules_enforcer", module_path)
+    assert spec is not None
+    assert spec.loader is not None
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+code_rules_enforcer = _load_enforcer_module()
+
+
+PRODUCTION_FILE_PATH = "packages/claude-dev-env/hooks/blocking/example_production.py"
+
+
+def test_should_flag_constant_used_only_in_class_level_decorator() -> None:
+    source = (
+        "TIMEOUT = 5\n"
+        "\n"
+        "def register(value):\n"
+        "    def wrap(cls):\n"
+        "        return cls\n"
+        "    return wrap\n"
+        "\n"
+        "@register(TIMEOUT)\n"
+        "class Foo:\n"
+        "    pass\n"
+    )
+    issues = code_rules_enforcer.check_file_global_constants_use_count(
+        source, PRODUCTION_FILE_PATH
+    )
+    assert any(
+        "TIMEOUT" in issue and "only 1 function/method" in issue for issue in issues
+    ), f"Expected class-decorator usage to register as a caller, got: {issues}"
+
+
+def test_should_flag_constant_used_once_at_module_scope_and_once_in_function() -> None:
+    source = "UPPER = 1\nSHADOW = UPPER\n\ndef lonely_caller():\n    return UPPER\n"
+    issues = code_rules_enforcer.check_file_global_constants_use_count(
+        source, PRODUCTION_FILE_PATH
+    )
+    assert issues == [], (
+        f"Expected module-scope + function usage to count as 2 distinct callers, got: {issues}"
+    )

package/hooks/blocking/test_code_rules_enforcer_file_global_constants.py

@@ -165,12 +165,14 @@ def test_should_flag_private_upper_snake_constant_used_by_only_one_function() ->
     ), f"Expected private UPPER_SNAKE to be flagged, got: {issues}"
 
 
-def test_should_accept_constant_referenced_only_at_module_scope() -> None:
+def test_should_flag_constant_referenced_only_at_module_scope() -> None:
     source = "A = 1\nB = A + 1\n"
     issues = code_rules_enforcer.check_file_global_constants_use_count(
         source, PRODUCTION_FILE_PATH
     )
-    assert issues == [], f"Expected module-scope reference to not count, got: {issues}"
+    assert any("A" in issue and "only 1 function/method" in issue for issue in issues), (
+        f"Expected single module-scope reference to be flagged, got: {issues}"
+    )
 
 
 def test_should_skip_non_python_files() -> None:

package/hooks/notification/subagent_complete_notify.py

@@ -9,11 +9,13 @@ import subprocess
 import sys
 import platform
 import os
+import time
+from datetime import datetime
 
 sys.path.insert(0, os.path.dirname(os.path.abspath(__file__)))
 from notification_utils import notify_discord
 
-NTFY_TOPIC = "claude-02633f9d93ea8794"
+NTFY_TOPIC = os.environ.get("CLAUDE_NTFY_TOPIC", "")
 DEFAULT_MESSAGE = "Task completed"
 ACTIVITY_WEBHOOK_SECRET_ID = os.environ.get("BWS_DISCORD_ACTIVITY_SECRET_ID", "")
 
@@ -25,8 +27,6 @@ LOG_FILE = os.path.join(CACHE_DIR, "subagent-notify-debug.log")
 def log_debug(message: str) -> None:
     """Append debug message to log file."""
     try:
-        from datetime import datetime
-
         with open(LOG_FILE, "a") as f:
             f.write(f"{datetime.now().isoformat()} - {message}\n")
     except Exception:
@@ -60,8 +60,6 @@ def get_task_info_from_stdin() -> str:
             return f"Agent {agent_id} completed" if agent_id else DEFAULT_MESSAGE
 
         # Find the Task tool call that spawned this agent (with retry for race condition)
-        import time
-
         tool_use_id = None
         for attempt in range(3):
             with open(transcript_path, "r") as f:
@@ -118,6 +116,8 @@ def get_project_name() -> str:
 
 def notify_ntfy(title: str, message: str, priority: str = "default") -> None:
     """Send push notification via ntfy.sh with title and message."""
+    if not NTFY_TOPIC:
+        return
     try:
         subprocess.Popen(
             [

package/hooks/notification/test_subagent_complete_notify.py

@@ -56,6 +56,13 @@ def test_main_forwards_activity_secret_id_to_notify_discord() -> None:
     assert call_kwargs["message"] == FIXTURE_TASK_DESCRIPTION
 
 
+def test_notify_ntfy_skips_when_topic_unset() -> None:
+    module_under_test = load_hook_with_environment({"CLAUDE_NTFY_TOPIC": ""})
+    with patch.object(module_under_test.subprocess, "Popen") as popen_spy:
+        module_under_test.notify_ntfy(title="t", message="m")
+    assert popen_spy.call_count == 0
+
+
 def test_main_skips_notify_discord_when_task_description_is_empty() -> None:
     module_under_test = load_hook_with_environment(
         {"BWS_DISCORD_ACTIVITY_SECRET_ID": FIXTURE_ACTIVITY_SECRET_ID}

package/hooks/validators/git_checks.py

@@ -6,7 +6,10 @@ import sys
 from dataclasses import dataclass
 from typing import List
 
-from config import DEFAULT_BASE_BRANCH_WHEN_UNKNOWN
+try:
+    from .validator_defaults import DEFAULT_BASE_BRANCH_WHEN_UNKNOWN
+except ImportError:
+    from validator_defaults import DEFAULT_BASE_BRANCH_WHEN_UNKNOWN
 
 
 SUBPROCESS_TIMEOUT_SECONDS = 30

package/hooks/validators/test_output_formatter.py

@@ -1,6 +1,7 @@
 """Tests for output formatting."""
 
 import os
+import sys
 
 import pytest
 
@@ -95,11 +96,15 @@ class TestJsonFlag:
         import json
         import subprocess
 
+        validators_directory = os.path.dirname(os.path.abspath(__file__))
+        hooks_directory = os.path.normpath(
+            os.path.join(validators_directory, os.pardir)
+        )
         result = subprocess.run(
-            ["python", "run_all_validators.py", "--json"],
+            [sys.executable, "-m", "validators.run_all_validators", "--json"],
             capture_output=True,
             text=True,
-            cwd=os.path.dirname(os.path.abspath(__file__)),
+            cwd=hooks_directory,
         )
 
         output = result.stdout.strip()

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "1.26.0",
+    "version": "1.26.2",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {