claude-dev-env 1.25.0 → 1.25.2

package/CLAUDE.md

@@ -1,39 +1,26 @@
 # Claude Development Assistant
 
-## Code Rules (NON-NEGOTIABLE)
+## Code Rules
 @~/.claude/docs/CODE_RULES.md
 
 ## Core Philosophy
 
 **TDD IS NON-NEGOTIABLE.** Build it right, build it simple. Maintainable > Clever.
 
-## Working with Claude
-
-### Expectations
+## Expectations for Claude
 
 1. **ALWAYS FOLLOW TDD** - No production code without failing test
 2. **MANDATORY SELF-CHECK before proposing** - See protocol below
 3. Assess refactoring after every green
 
-### Mandatory Self-Check Protocol
-
 **BEFORE proposing plans/implementation:**
 
-☐ Project rules review (e.g. Tasklings `tasklings-preferences` when in that repo path)
 ☐ "Is this KISS?" (simplest? unnecessary complexity?)
 ☐ "Over-engineering?" (multiple files? premature abstractions?)
 ☐ Test infrastructure? (ONE file, functions, YAGNI)
 ☐ Tests add value? (no existence checks, no constant tests)
-
-## Pre-PR Submission Checklist
-
-**Run `/check-pr` OR verify:**
-- ☐ KISS / preferences (multiple requirements.txt? over-engineered?)
-- ☐ KISS (simplest? one file? functions not classes?)
-- ☐ Files (proper modules, correct dirs, no empty __init__.py)
-- ☐ Quality (no dupes, types complete, no Any/any)
-- ☐ Tests (no existence checks, no constant value tests)
-- ☐ Self-checked before proposing?
+☐ Files (proper modules, correct dirs, no empty __init__.py)
+☐ Quality (DRY, types complete, no Any/any)
 
 ## Additional Non-overlapping Rules
 
@@ -47,4 +34,4 @@ When compacting, always preserve:
 - Active task and current goal
 - Full list of modified files
 - Any failing test names or error messages
-- Current git branch and PR state
+- Current git branch and PR state

package/hooks/blocking/destructive-command-blocker.py

@@ -7,6 +7,13 @@ import sys
 from pathlib import Path
 
 CLAUDE_DIRECTORY_PATH = os.path.normpath(os.path.expanduser("~/.claude"))
+GH_REDIRECT_ACTIVE_ENV_VAR = "CLAUDE_GH_REDIRECT_ACTIVE"
+GH_REDIRECT_ACTIVE_TRUTHY_VALUES = frozenset({"1", "true", "yes", "on"})
+
+
+def gh_redirect_is_active() -> bool:
+    env_var_value = os.environ.get(GH_REDIRECT_ACTIVE_ENV_VAR, "").strip().lower()
+    return env_var_value in GH_REDIRECT_ACTIVE_TRUTHY_VALUES
 
 # Projects where git reset --hard is explicitly allowed by the user.
 # Add your own project paths here, e.g.:
@@ -116,10 +123,11 @@ def main() -> None:
 
     command = tool_input.get("command", "")
 
-    redirected_gh_description = find_redirected_gh_pattern(command)
-    if redirected_gh_description is not None:
-        print(json.dumps(_build_silent_gh_deny_response(redirected_gh_description)))
-        sys.exit(0)
+    if gh_redirect_is_active():
+        redirected_gh_description = find_redirected_gh_pattern(command)
+        if redirected_gh_description is not None:
+            print(json.dumps(_build_silent_gh_deny_response(redirected_gh_description)))
+            sys.exit(0)
 
     matched_description = find_destructive_pattern(command)
 

package/hooks/blocking/tdd-enforcer.py

@@ -18,6 +18,15 @@ SKIP_PATTERNS = {
     'conftest', 'fixture', 'mock', 'stub'
 }
 SKIP_EXTENSIONS = {'.md', '.json', '.yaml', '.yml', '.toml', '.ini', '.cfg', '.txt'}
+DOTCLAUDE_PATH_SEGMENTS = frozenset({".claude"})
+
+
+def _is_inside_dotclaude_segment(file_path_string: str) -> bool:
+    normalized_path = file_path_string.replace("\\", "/")
+    for each_segment in normalized_path.split("/"):
+        if each_segment and each_segment in DOTCLAUDE_PATH_SEGMENTS:
+            return True
+    return False
 
 
 def _freshness_seconds() -> int:
@@ -221,6 +230,9 @@ def main() -> None:
     if not file_path:
         sys.exit(0)
 
+    if _is_inside_dotclaude_segment(file_path):
+        sys.exit(0)
+
     path = Path(file_path)
     ext = path.suffix.lower()
 

package/hooks/blocking/test_destructive_command_blocker.py

@@ -1,6 +1,7 @@
 """Tests for destructive-command-blocker hook."""
 
 import json
+import os
 import subprocess
 import sys
 from pathlib import Path
@@ -8,15 +9,26 @@ from pathlib import Path
 
 SCRIPT_PATH = Path(__file__).parent / "destructive-command-blocker.py"
 GH_GATE_USER_FACING_PREFIX = "[gh-gate]"
-
-
-def _run_hook(payload: dict) -> subprocess.CompletedProcess[str]:
+GH_REDIRECT_ACTIVE_ENV_VAR = "CLAUDE_GH_REDIRECT_ACTIVE"
+GH_REDIRECT_ACTIVE_VALUE = "1"
+
+
+def _run_hook(
+    payload: dict,
+    gh_redirect_active: bool = True,
+) -> subprocess.CompletedProcess[str]:
+    child_environment = os.environ.copy()
+    if gh_redirect_active:
+        child_environment[GH_REDIRECT_ACTIVE_ENV_VAR] = GH_REDIRECT_ACTIVE_VALUE
+    else:
+        child_environment.pop(GH_REDIRECT_ACTIVE_ENV_VAR, None)
     return subprocess.run(
         [sys.executable, str(SCRIPT_PATH)],
         input=json.dumps(payload),
         text=True,
         capture_output=True,
         check=False,
+        env=child_environment,
     )
 
 
@@ -106,3 +118,50 @@ def test_ignores_non_bash_tool() -> None:
     result = _run_hook(payload)
     assert result.stdout.strip() == ""
     assert result.returncode == 0
+
+
+def test_gh_issue_comment_is_allowed_when_redirect_env_var_is_unset() -> None:
+    payload = _make_bash_payload('gh issue comment 83 --body "hello"')
+
+    result = _run_hook(payload, gh_redirect_active=False)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_gh_pr_comment_is_allowed_when_redirect_env_var_is_unset() -> None:
+    payload = _make_bash_payload('gh pr comment 42 --body "ok"')
+
+    result = _run_hook(payload, gh_redirect_active=False)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_gh_pr_review_is_allowed_when_redirect_env_var_is_unset() -> None:
+    payload = _make_bash_payload("gh pr review 42 --approve")
+
+    result = _run_hook(payload, gh_redirect_active=False)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_gh_api_post_comment_is_allowed_when_redirect_env_var_is_unset() -> None:
+    payload = _make_bash_payload(
+        "gh api /repos/owner/name/issues/1/comments -X POST -f body=hello"
+    )
+
+    result = _run_hook(payload, gh_redirect_active=False)
+
+    assert result.stdout.strip() == ""
+    assert result.returncode == 0
+
+
+def test_rm_rf_still_asks_when_redirect_env_var_is_unset() -> None:
+    payload = _make_bash_payload("rm -rf /tmp/somewhere")
+
+    result = _run_hook(payload, gh_redirect_active=False)
+
+    response = json.loads(result.stdout)
+    assert response["hookSpecificOutput"]["permissionDecision"] == "ask"

package/hooks/blocking/test_tdd_enforcer.py

@@ -247,3 +247,55 @@ def test_directory_skip_components_excludes_pluralized_conftest() -> None:
     actual_directory_skip_components = _PRODUCTION_MODULE._directory_skip_components()
 
     assert "conftests" not in actual_directory_skip_components
+
+
+def test_should_skip_silently_when_posix_path_has_dotclaude_segment(tmp_path: Path) -> None:
+    dotclaude_production_file = tmp_path / ".claude" / "agents" / "reviewer.py"
+
+    completed = _run_hook_with_payload(
+        _make_write_payload(dotclaude_production_file, "def review(): pass\n")
+    )
+
+    assert completed.returncode == 0
+    assert completed.stdout.strip() == ""
+
+
+def test_should_skip_silently_when_windows_backslash_path_has_dotclaude_segment() -> None:
+    windows_style_path = "C:\\Users\\dev\\.claude\\agents\\reviewer.py"
+
+    completed = _run_hook_with_payload({
+        "tool_name": "Write",
+        "tool_input": {"file_path": windows_style_path, "content": "def review(): pass\n"},
+    })
+
+    assert completed.returncode == 0
+    assert completed.stdout.strip() == ""
+
+
+def test_should_skip_silently_when_mixed_separator_path_has_dotclaude_segment() -> None:
+    mixed_separator_path = "C:/Users/dev\\.claude/agents\\reviewer.py"
+
+    completed = _run_hook_with_payload({
+        "tool_name": "Write",
+        "tool_input": {"file_path": mixed_separator_path, "content": "def review(): pass\n"},
+    })
+
+    assert completed.returncode == 0
+    assert completed.stdout.strip() == ""
+
+
+def test_should_not_skip_when_dotclaude_is_only_a_filename_substring(tmp_path: Path) -> None:
+    sandbox = _sandbox(tmp_path)
+    substring_production_file = sandbox / "my.claude.helpers.py"
+    substring_production_file.write_text("def help(): pass\n")
+
+    completed = _run_hook_with_payload(_make_write_payload(substring_production_file))
+
+    assert _decision_from(completed) == "deny"
+
+
+def test_is_inside_dotclaude_segment_helper_matches_only_exact_segments() -> None:
+    assert _PRODUCTION_MODULE._is_inside_dotclaude_segment("/home/user/.claude/agent.py") is True
+    assert _PRODUCTION_MODULE._is_inside_dotclaude_segment("C:\\Users\\dev\\.claude\\agent.py") is True
+    assert _PRODUCTION_MODULE._is_inside_dotclaude_segment("/src/my.claude.helpers.py") is False
+    assert _PRODUCTION_MODULE._is_inside_dotclaude_segment("/src/app/service.py") is False

package/hooks/notification/notification_utils.py

@@ -4,8 +4,8 @@ import os
 import platform
 import subprocess
 
-NTFY_TOPIC = os.environ.get("NTFY_TOPIC", "claude-notifications")
-NTFY_BASE_URL = f"https://ntfy.sh/{NTFY_TOPIC}"
+NTFY_TOPIC = os.environ.get("NTFY_TOPIC", "")
+NTFY_BASE_URL = f"https://ntfy.sh/{NTFY_TOPIC}" if NTFY_TOPIC else ""
 WINDOWS_CHIMES_PATH = os.path.join(os.environ.get("SYSTEMROOT", r"C:\Windows"), "Media", "Windows Battery Critical.wav")
 LINUX_NOTIFICATION_SOUND = os.environ.get("NOTIFICATION_SOUND", "/usr/share/sounds/freedesktop/stereo/message.oga")
 LINUX_NOTIFICATION_TIMEOUT_MS = "3000"
@@ -138,6 +138,8 @@ def notify_windows(title: str, message: str) -> None:
 
 
 def notify_ntfy(title: str, message: str, priority: str = "high") -> None:
+    if not NTFY_TOPIC:
+        return
     try:
         subprocess.Popen(
             [

package/hooks/notification/test_notification_utils.py

@@ -0,0 +1,46 @@
+"""Unit tests for notification_utils ntfy guard behavior."""
+
+import importlib.util
+import pathlib
+import types
+from unittest.mock import patch
+
+HOOK_DIRECTORY = pathlib.Path(__file__).parent
+MODULE_PATH = HOOK_DIRECTORY / "notification_utils.py"
+
+
+def load_notification_utils_with_environment(
+    environment_overrides: dict[str, str],
+) -> types.ModuleType:
+    module_specification = importlib.util.spec_from_file_location(
+        "notification_utils_under_test",
+        MODULE_PATH,
+    )
+    assert module_specification is not None
+    assert module_specification.loader is not None
+    module_under_test = importlib.util.module_from_spec(module_specification)
+    with patch.dict("os.environ", environment_overrides, clear=False):
+        module_specification.loader.exec_module(module_under_test)
+    return module_under_test
+
+
+def test_should_skip_curl_when_topic_environment_variable_is_unset() -> None:
+    environment_with_topic_removed = {"NTFY_TOPIC": ""}
+    module_under_test = load_notification_utils_with_environment(
+        environment_with_topic_removed
+    )
+    with patch("subprocess.Popen") as popen_spy:
+        module_under_test.notify_ntfy(title="Test", message="payload")
+    assert popen_spy.call_count == 0
+
+
+def test_should_invoke_curl_when_topic_environment_variable_is_set() -> None:
+    environment_with_topic_set = {"NTFY_TOPIC": "private-topic-for-test"}
+    module_under_test = load_notification_utils_with_environment(
+        environment_with_topic_set
+    )
+    with patch("subprocess.Popen") as popen_spy:
+        module_under_test.notify_ntfy(title="Test", message="payload")
+    assert popen_spy.call_count == 1
+    curl_arguments = popen_spy.call_args.args[0]
+    assert "https://ntfy.sh/private-topic-for-test" in curl_arguments

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "1.25.0",
+    "version": "1.25.2",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {