claude-crap 0.4.6 → 0.4.7

package/plugin/hooks/lib/quality-gate.mjs

@@ -150,6 +150,9 @@ const LOC_WALK_SKIP_DIRS = new Set([
   ".git",
   // Build outputs
   "dist", "build", "bundle", "out", "target", "coverage",
+  // Test coverage report bundles (ReportGenerator, Istanbul, coverage.py, dotnet test)
+  "coverage-report", "CoverageReport", "coveragereport",
+  "TestResults", "cobertura", "lcov-report", "htmlcov",
   // Framework build outputs
   ".next", ".nuxt", ".output", ".vercel", ".svelte-kit",
   ".astro", ".angular", ".turbo", ".parcel-cache", ".expo",

package/src/dashboard/file-detail.ts

@@ -58,6 +58,12 @@ export interface FileDetailSummary {
 /** Full response payload for the file detail endpoint. */
 export interface FileDetailResponse {
   readonly filePath: string;
+  /**
+   * Absolute path on the host filesystem, already resolved through the
+   * workspace-traversal guard. The UI uses this to build editor
+   * deep-links (e.g. `vscode://file/{absolutePath}:{line}`).
+   */
+  readonly absolutePath: string;
   readonly language: SupportedLanguage | null;
   readonly physicalLoc: number;
   readonly logicalLoc: number;
@@ -175,6 +181,7 @@ export async function buildFileDetail(
 
   return {
     filePath: relativePath,
+    absolutePath,
     language,
     physicalLoc,
     logicalLoc,

package/src/dashboard/public/index.html

@@ -317,6 +317,95 @@
         opacity: 0.7;
         margin-left: 12px;
       }
+      /* CC heat bar — ReportGenerator-style visual severity */
+      .heat-bar {
+        position: relative;
+        width: 140px;
+        height: 8px;
+        background: rgba(255, 255, 255, 0.06);
+        border-radius: 4px;
+        overflow: hidden;
+      }
+      .heat-bar-fill {
+        height: 100%;
+        border-radius: 4px;
+        transition: width 120ms ease-out;
+      }
+      .heat-bar-threshold {
+        position: absolute;
+        top: -2px;
+        bottom: -2px;
+        width: 1px;
+        background: rgba(255, 255, 255, 0.35);
+      }
+      /* CC chip — numeric value + % of threshold */
+      .cc-chip {
+        display: inline-flex;
+        align-items: baseline;
+        gap: 6px;
+        font-variant-numeric: tabular-nums;
+      }
+      .cc-chip .cc-value {
+        font-weight: 700;
+        font-size: 13px;
+      }
+      .cc-chip .cc-ratio {
+        font-size: 11px;
+        color: var(--muted);
+      }
+      /* Method name button — scrolls source view to fn start line */
+      .method-jump {
+        background: none;
+        border: none;
+        padding: 0;
+        font: inherit;
+        font-family: "SF Mono", "Fira Code", "Consolas", monospace;
+        font-size: 13px;
+        color: var(--accent);
+        cursor: pointer;
+      }
+      .method-jump:hover { text-decoration: underline; }
+      /* "Open in editor" icon link */
+      .editor-link {
+        display: inline-flex;
+        align-items: center;
+        justify-content: center;
+        width: 24px;
+        height: 24px;
+        border-radius: 4px;
+        color: var(--muted);
+        text-decoration: none;
+        font-size: 13px;
+        transition: background 120ms, color 120ms;
+      }
+      .editor-link:hover {
+        background: rgba(62, 166, 255, 0.12);
+        color: var(--accent);
+        text-decoration: none;
+      }
+      /* "Show all / show fewer" toggle under the methods table */
+      .show-all-btn {
+        display: inline-block;
+        margin: 12px 0 0 0;
+        padding: 6px 12px;
+        background: transparent;
+        border: 1px solid var(--border);
+        border-radius: 6px;
+        color: var(--accent);
+        font-size: 12px;
+        cursor: pointer;
+      }
+      .show-all-btn:hover {
+        background: rgba(62, 166, 255, 0.08);
+      }
+      /* Line-flash animation when the user jumps to a source line */
+      .source-line.jump-target {
+        animation: jumpFlash 1.2s ease-out;
+      }
+      @keyframes jumpFlash {
+        0%   { background: rgba(62, 166, 255, 0.35); }
+        100% { background: transparent; }
+      }
     </style>
   </head>
   <body>
@@ -372,33 +461,74 @@
             </div>
           </div>
 
-          <!-- Methods table -->
-          <div v-if="fileDetail.functions.length" class="section-title">Methods</div>
+          <!-- Methods table — top-5 by CC with heat bar + jump + editor link -->
+          <div v-if="fileDetail.functions.length" class="section-title">
+            Methods
+            <span style="color: var(--muted); font-weight: 400; text-transform: none; letter-spacing: 0; margin-left: 8px;">
+              threshold CC {{ fileDetail.cyclomaticMax }}
+            </span>
+          </div>
           <div v-if="fileDetail.functions.length" class="card">
             <table>
               <thead>
                 <tr>
                   <th>Method</th>
                   <th style="text-align: right">Line</th>
-                  <th style="text-align: right">CC</th>
+                  <th style="width: 180px;">CC</th>
                   <th style="text-align: right">Lines</th>
                   <th>Status</th>
+                  <th style="width: 32px;"></th>
                 </tr>
               </thead>
               <tbody>
-                <tr v-for="fn in sortedFunctions" :key="fn.startLine">
-                  <td><code>{{ fn.name }}</code></td>
+                <tr v-for="fn in visibleFunctions" :key="fn.startLine">
+                  <td>
+                    <button
+                      class="method-jump"
+                      @click="jumpToLine(fn.startLine)"
+                      :title="'Jump to line ' + fn.startLine"
+                    >{{ fn.name }}</button>
+                  </td>
                   <td style="text-align: right; font-variant-numeric: tabular-nums;">{{ fn.startLine }}</td>
-                  <td style="text-align: right; font-variant-numeric: tabular-nums;">{{ fn.cyclomaticComplexity }}</td>
+                  <td>
+                    <div class="cc-chip">
+                      <div class="heat-bar" :title="ccTooltip(fn)">
+                        <div
+                          class="heat-bar-fill"
+                          :style="heatBarStyle(fn)"
+                        ></div>
+                        <div
+                          class="heat-bar-threshold"
+                          :style="{ left: thresholdMarker() + '%' }"
+                        ></div>
+                      </div>
+                      <span class="cc-value" :style="{ color: ccColor(fn) }">{{ fn.cyclomaticComplexity }}</span>
+                      <span class="cc-ratio">{{ ccRatio(fn) }}%</span>
+                    </div>
+                  </td>
                   <td style="text-align: right; font-variant-numeric: tabular-nums;">{{ fn.lineCount }}</td>
                   <td>
                     <span v-if="fn.cyclomaticComplexity >= fileDetail.cyclomaticMax * 2" class="pill pill-error">error</span>
                     <span v-else-if="fn.cyclomaticComplexity > fileDetail.cyclomaticMax" class="pill pill-warning">warning</span>
                     <span v-else class="pill pill-note">ok</span>
                   </td>
+                  <td>
+                    <a
+                      class="editor-link"
+                      :href="editorLink(fn)"
+                      :title="'Open ' + fileDetail.filePath + ':' + fn.startLine + ' in VS Code'"
+                    >&#x2197;</a>
+                  </td>
                 </tr>
               </tbody>
             </table>
+            <button
+              v-if="fileDetail.functions.length > topMethodsLimit"
+              class="show-all-btn"
+              @click="toggleShowAllMethods()"
+            >
+              {{ showAllMethods ? 'Show top ' + topMethodsLimit : 'Show all ' + fileDetail.functions.length + ' methods' }}
+            </button>
           </div>
 
           <!-- Findings table -->
@@ -622,11 +752,87 @@
           });
 
           // ── File detail computed ──
+          const topMethodsLimit = 5;
+          const showAllMethods = ref(false);
+
           const sortedFunctions = computed(() => {
             if (!fileDetail.value) return [];
             return [...fileDetail.value.functions].sort((a, b) => b.cyclomaticComplexity - a.cyclomaticComplexity);
           });
 
+          const visibleFunctions = computed(() => {
+            if (showAllMethods.value) return sortedFunctions.value;
+            return sortedFunctions.value.slice(0, topMethodsLimit);
+          });
+
+          function toggleShowAllMethods() {
+            showAllMethods.value = !showAllMethods.value;
+          }
+
+          // ── CC heat-bar helpers ──
+          // Fill width is clamped at 3× threshold so a CC of 80 with
+          // threshold 15 still produces a visually meaningful bar rather
+          // than overflowing. The threshold marker sits at the "1.0×"
+          // position (i.e. threshold/3threshold = 33%).
+          function ccRatio(fn) {
+            const max = fileDetail.value?.cyclomaticMax || 1;
+            return Math.round((fn.cyclomaticComplexity / max) * 100);
+          }
+
+          function heatBarStyle(fn) {
+            const max = fileDetail.value?.cyclomaticMax || 1;
+            const cap = max * 3;
+            const pct = Math.min(100, (fn.cyclomaticComplexity / cap) * 100);
+            return { width: pct + "%", background: ccColor(fn) };
+          }
+
+          function thresholdMarker() {
+            // threshold sits at 1/3 of the bar (since we cap at 3× threshold)
+            return 33.33;
+          }
+
+          function ccColor(fn) {
+            const max = fileDetail.value?.cyclomaticMax || 1;
+            const r = fn.cyclomaticComplexity / max;
+            if (r >= 2) return "var(--rating-E)"; // red — error (≥ 2×)
+            if (r > 1) return "var(--rating-C)";  // yellow — warning
+            if (r > 0.66) return "var(--rating-B)"; // yellow-green — near threshold
+            return "var(--rating-A)";              // green — healthy
+          }
+
+          function ccTooltip(fn) {
+            const max = fileDetail.value?.cyclomaticMax || 1;
+            return (
+              "CC " + fn.cyclomaticComplexity +
+              " / threshold " + max +
+              " (" + ccRatio(fn) + "% of threshold)"
+            );
+          }
+
+          // ── Editor deep-link + jump-to-line ──
+          // vscode:// handler accepts absolute paths. The `absolutePath`
+          // field is resolved server-side through the workspace-traversal
+          // guard, so this is safe to paste into an href.
+          function editorLink(fn) {
+            const abs = fileDetail.value?.absolutePath;
+            if (!abs) return "#";
+            return "vscode://file" + abs + ":" + fn.startLine + ":1";
+          }
+
+          function jumpToLine(lineNum) {
+            // Source lines are keyed by 0-based index, so line N lives at
+            // child index N-1 of `.source-view`.
+            const view = document.querySelector(".source-view");
+            if (!view) return;
+            const row = view.children[lineNum - 1];
+            if (!row) return;
+            row.scrollIntoView({ behavior: "smooth", block: "center" });
+            row.classList.remove("jump-target");
+            // force reflow so the animation restarts on repeat clicks
+            void row.offsetWidth;
+            row.classList.add("jump-target");
+          }
+
           const sortedFindings = computed(() => {
             if (!fileDetail.value) return [];
             return [...fileDetail.value.findings].sort((a, b) => a.startLine - b.startLine);
@@ -777,7 +983,10 @@
             currentView, selectedFile, fileDetail,
             score, complexity, loading, error,
             toolEntries, fileEntries, formatTimestamp,
-            sortedFunctions, sortedFindings,
+            sortedFunctions, sortedFindings, visibleFunctions,
+            showAllMethods, toggleShowAllMethods, topMethodsLimit,
+            ccRatio, ccColor, ccTooltip, heatBarStyle, thresholdMarker,
+            editorLink, jumpToLine,
             navigateToFile, goBack,
             lineFindings, lineClass, gutterClass, lineFnLabel,
           };

package/src/shared/exclusions.ts

@@ -40,6 +40,17 @@ export const DEFAULT_SKIP_DIRS: ReadonlySet<string> = new Set([
   "artifacts",    // CI artefact staging, Maven
   "publish",      // `dotnet publish` output
 
+  // Test coverage report bundles (generated HTML/JS from coverage tools;
+  // walking them floods the complexity scanner with synthetic minified
+  // functions like `coverage-report/main.js::gG` at CC 80+).
+  "coverage-report",  // ReportGenerator default (.NET)
+  "CoverageReport",   // ReportGenerator PascalCase variant
+  "coveragereport",   // ReportGenerator lowercase fallback
+  "TestResults",      // `dotnet test` default output
+  "cobertura",        // Cobertura XML reporter
+  "lcov-report",      // Istanbul HTML reporter
+  "htmlcov",          // coverage.py HTML output
+
   // Desktop / mobile packaging outputs
   "dist-electron",// Electron-builder
   "release",      // Electron-builder, Tauri

package/src/tests/exclusions.test.ts

@@ -50,6 +50,25 @@ describe("DEFAULT_SKIP_DIRS", () => {
       assert.ok(DEFAULT_SKIP_DIRS.has(dir), `missing skip dir: ${dir}`);
     }
   });
+
+  it("includes coverage report directories emitted by test tooling", () => {
+    // ReportGenerator (.NET), Istanbul (JS) and dotCover emit generated
+    // HTML/JS bundles into these folders. Previously only the bare
+    // `coverage` name was skipped, which leaked files like
+    // `GanttLite.Server/coverage-report/main.js` into complexity scans
+    // and flooded the dashboard with false-positive high-CC findings.
+    for (const dir of [
+      "coverage-report",  // ReportGenerator default
+      "CoverageReport",   // ReportGenerator PascalCase
+      "coveragereport",   // ReportGenerator lowercase fallback
+      "TestResults",      // dotnet test default
+      "cobertura",        // Cobertura XML output
+      "lcov-report",      // Istanbul HTML reporter
+      "htmlcov",          // coverage.py HTML output
+    ]) {
+      assert.ok(DEFAULT_SKIP_DIRS.has(dir), `missing coverage skip dir: ${dir}`);
+    }
+  });
 });
 
 describe("DEFAULT_SKIP_PATTERNS", () => {
@@ -93,6 +112,21 @@ describe("createExclusionFilter", () => {
       assert.equal(filter.shouldSkipDir("generated"), true);
       assert.equal(filter.shouldSkipDir("src"), false);
     });
+
+    it("skips coverage report directories from every major test runner", () => {
+      // Regression: the ReportGenerator bundle
+      // (`coverage-report/main.js`, `class.js`, etc.) used to surface
+      // in the dashboard's complexity hotspots as minified code with
+      // CC ≥ 80. These directories must never be walked.
+      const filter = createExclusionFilter();
+      assert.equal(filter.shouldSkipDir("coverage-report"), true);
+      assert.equal(filter.shouldSkipDir("CoverageReport"), true);
+      assert.equal(filter.shouldSkipDir("coveragereport"), true);
+      assert.equal(filter.shouldSkipDir("TestResults"), true);
+      assert.equal(filter.shouldSkipDir("cobertura"), true);
+      assert.equal(filter.shouldSkipDir("lcov-report"), true);
+      assert.equal(filter.shouldSkipDir("htmlcov"), true);
+    });
   });
 
   describe("shouldSkipFile", () => {

package/src/tests/file-detail-api.test.ts

@@ -190,6 +190,44 @@ describe("buildFileDetail", () => {
     }
   });
 
+  it("returns the resolved absolute path so the UI can build editor deep-links", async () => {
+    // The file-detail view exposes "Open in editor" buttons that emit
+    // `vscode://file/{absolutePath}:{line}` (and JetBrains equivalents).
+    // Constructing that URL client-side requires the absolute path —
+    // the workspace-relative `filePath` alone is not enough. This
+    // characterization test pins that contract so the UI can rely on it.
+    const dir = makeTmpDir();
+    try {
+      writeFileSync(join(dir, "hello.ts"), SAMPLE_TS);
+      const store = new SarifStore({
+        workspaceRoot: dir,
+        outputDir: join(dir, ".claude-crap/reports"),
+      });
+      const result = await buildFileDetail({
+        relativePath: "hello.ts",
+        workspaceRoot: dir,
+        astEngine: engine,
+        sarifStore: store,
+        cyclomaticMax: 15,
+      });
+      assert.equal(
+        result.absolutePath,
+        join(dir, "hello.ts"),
+        `expected absolutePath to join workspaceRoot with filePath, got ${result.absolutePath}`,
+      );
+      assert.ok(
+        result.absolutePath.endsWith("hello.ts"),
+        "absolutePath should end with the relative path",
+      );
+      assert.ok(
+        result.absolutePath.startsWith(dir),
+        "absolutePath must live under the workspace root (path-traversal defense)",
+      );
+    } finally {
+      rmSync(dir, { recursive: true, force: true });
+    }
+  });
+
   it("returns empty functions for unsupported languages", async () => {
     const dir = makeTmpDir();
     try {

package/src/tests/workspace-walker.test.ts

@@ -61,4 +61,34 @@ describe("estimateWorkspaceLoc — default skip dirs exclude common build artefa
       rmSync(dir, { recursive: true, force: true });
     }
   });
+
+  it("skips generated test coverage report bundles", async () => {
+    // Regression: the dashboard flagged GanttLite.Server/coverage-report/main.js
+    // (ReportGenerator output) as the hottest file in the project with
+    // four CC-80+ errors, all coming from minified `main.js` / `class.js`.
+    // The walker must not descend into any coverage-report variant.
+    const dir = makeTmpDir();
+    try {
+      touch(join(dir, "src/real.ts"), "export const x = 1;\n");
+
+      touch(join(dir, "coverage-report/main.js"), "function gG(){return 1}\n");
+      touch(join(dir, "coverage-report/class.js"), "function N(){return 1}\n");
+      touch(join(dir, "CoverageReport/index.js"), "function a(){}\n");
+      touch(join(dir, "coveragereport/bundle.js"), "function b(){}\n");
+      touch(join(dir, "TestResults/report.js"), "function c(){}\n");
+      touch(join(dir, "cobertura/cobertura.js"), "function d(){}\n");
+      touch(join(dir, "lcov-report/prettify.js"), "function e(){}\n");
+      touch(join(dir, "htmlcov/pycov.js"), "function f(){}\n");
+
+      const result = await estimateWorkspaceLoc(dir);
+
+      assert.equal(
+        result.fileCount,
+        1,
+        `coverage-report bundles leaked into walk — fileCount=${result.fileCount}`,
+      );
+    } finally {
+      rmSync(dir, { recursive: true, force: true });
+    }
+  });
 });