claude-code-workflow 6.3.31 → 6.3.34

package/.claude/skills/review-code/specs/rules/index.md

@@ -1,140 +1,140 @@
-# Code Review Rules Index
-
-This directory contains externalized review rules for the multi-dimensional code review skill.
-
-## Directory Structure
-
-```
-rules/
-├── index.md                    # This file
-├── correctness-rules.json      # CORR - Logic and error handling
-├── security-rules.json         # SEC  - Security vulnerabilities
-├── performance-rules.json      # PERF - Performance issues
-├── readability-rules.json      # READ - Code clarity
-├── testing-rules.json          # TEST - Test quality
-└── architecture-rules.json     # ARCH - Design patterns
-```
-
-## Rule File Schema
-
-Each rule file follows this JSON schema:
-
-```json
-{
-  "dimension": "string",        // Dimension identifier
-  "prefix": "string",           // Finding ID prefix (4 chars)
-  "description": "string",      // Dimension description
-  "rules": [
-    {
-      "id": "string",           // Unique rule identifier
-      "category": "string",     // Rule category within dimension
-      "severity": "critical|high|medium|low",
-      "pattern": "string",      // Detection pattern
-      "patternType": "regex|includes|ast",
-      "negativePatterns": [],   // Patterns that exclude matches
-      "caseInsensitive": false, // For regex patterns
-      "contextPattern": "",     // Additional context requirement
-      "contextPath": [],        // Path patterns for context
-      "lineThreshold": 0,       // For size-based rules
-      "methodThreshold": 0,     // For complexity rules
-      "description": "string",  // Issue description
-      "recommendation": "string", // How to fix
-      "fixExample": "string"    // Code example
-    }
-  ]
-}
-```
-
-## Dimension Summary
-
-| Dimension | Prefix | Rules | Focus Areas |
-|-----------|--------|-------|-------------|
-| Correctness | CORR | 5 | Null checks, error handling, type safety |
-| Security | SEC | 5 | XSS, injection, secrets, crypto |
-| Performance | PERF | 5 | Complexity, I/O, memory leaks |
-| Readability | READ | 5 | Naming, length, nesting, magic values |
-| Testing | TEST | 5 | Assertions, coverage, mock quality |
-| Architecture | ARCH | 5 | Dependencies, layering, coupling |
-
-## Severity Levels
-
-| Severity | Description | Action |
-|----------|-------------|--------|
-| **critical** | Security vulnerability or data loss risk | Must fix before release |
-| **high** | Bug or significant quality issue | Fix in current sprint |
-| **medium** | Code smell or maintainability concern | Plan to address |
-| **low** | Style or minor improvement | Address when convenient |
-
-## Pattern Types
-
-### regex
-Standard regular expression pattern. Supports flags via `caseInsensitive`.
-
-```json
-{
-  "pattern": "catch\\s*\\([^)]*\\)\\s*\\{\\s*\\}",
-  "patternType": "regex"
-}
-```
-
-### includes
-Simple substring match. Faster than regex for literal strings.
-
-```json
-{
-  "pattern": "innerHTML",
-  "patternType": "includes"
-}
-```
-
-### ast (Future)
-AST-based detection for complex structural patterns.
-
-```json
-{
-  "pattern": "function[params>5]",
-  "patternType": "ast"
-}
-```
-
-## Usage in Code
-
-```javascript
-// Load rules
-const rules = JSON.parse(fs.readFileSync('correctness-rules.json'));
-
-// Apply rules
-for (const rule of rules.rules) {
-  const matches = detectByPattern(content, rule.pattern, rule.patternType);
-  for (const match of matches) {
-    // Check negative patterns
-    if (rule.negativePatterns?.some(np => match.context.includes(np))) {
-      continue;
-    }
-    findings.push({
-      id: `${rules.prefix}-${counter++}`,
-      severity: rule.severity,
-      category: rule.category,
-      description: rule.description,
-      recommendation: rule.recommendation,
-      fixExample: rule.fixExample
-    });
-  }
-}
-```
-
-## Adding New Rules
-
-1. Identify the appropriate dimension
-2. Create rule with unique `id` within dimension
-3. Choose appropriate `patternType`
-4. Provide clear `description` and `recommendation`
-5. Include practical `fixExample`
-6. Test against sample code
-
-## Rule Maintenance
-
-- Review rules quarterly for relevance
-- Update patterns as language/framework evolves
-- Track false positive rates
-- Collect feedback from users
+# Code Review Rules Index
+
+This directory contains externalized review rules for the multi-dimensional code review skill.
+
+## Directory Structure
+
+```
+rules/
+├── index.md                    # This file
+├── correctness-rules.json      # CORR - Logic and error handling
+├── security-rules.json         # SEC  - Security vulnerabilities
+├── performance-rules.json      # PERF - Performance issues
+├── readability-rules.json      # READ - Code clarity
+├── testing-rules.json          # TEST - Test quality
+└── architecture-rules.json     # ARCH - Design patterns
+```
+
+## Rule File Schema
+
+Each rule file follows this JSON schema:
+
+```json
+{
+  "dimension": "string",        // Dimension identifier
+  "prefix": "string",           // Finding ID prefix (4 chars)
+  "description": "string",      // Dimension description
+  "rules": [
+    {
+      "id": "string",           // Unique rule identifier
+      "category": "string",     // Rule category within dimension
+      "severity": "critical|high|medium|low",
+      "pattern": "string",      // Detection pattern
+      "patternType": "regex|includes|ast",
+      "negativePatterns": [],   // Patterns that exclude matches
+      "caseInsensitive": false, // For regex patterns
+      "contextPattern": "",     // Additional context requirement
+      "contextPath": [],        // Path patterns for context
+      "lineThreshold": 0,       // For size-based rules
+      "methodThreshold": 0,     // For complexity rules
+      "description": "string",  // Issue description
+      "recommendation": "string", // How to fix
+      "fixExample": "string"    // Code example
+    }
+  ]
+}
+```
+
+## Dimension Summary
+
+| Dimension | Prefix | Rules | Focus Areas |
+|-----------|--------|-------|-------------|
+| Correctness | CORR | 5 | Null checks, error handling, type safety |
+| Security | SEC | 5 | XSS, injection, secrets, crypto |
+| Performance | PERF | 5 | Complexity, I/O, memory leaks |
+| Readability | READ | 5 | Naming, length, nesting, magic values |
+| Testing | TEST | 5 | Assertions, coverage, mock quality |
+| Architecture | ARCH | 5 | Dependencies, layering, coupling |
+
+## Severity Levels
+
+| Severity | Description | Action |
+|----------|-------------|--------|
+| **critical** | Security vulnerability or data loss risk | Must fix before release |
+| **high** | Bug or significant quality issue | Fix in current sprint |
+| **medium** | Code smell or maintainability concern | Plan to address |
+| **low** | Style or minor improvement | Address when convenient |
+
+## Pattern Types
+
+### regex
+Standard regular expression pattern. Supports flags via `caseInsensitive`.
+
+```json
+{
+  "pattern": "catch\\s*\\([^)]*\\)\\s*\\{\\s*\\}",
+  "patternType": "regex"
+}
+```
+
+### includes
+Simple substring match. Faster than regex for literal strings.
+
+```json
+{
+  "pattern": "innerHTML",
+  "patternType": "includes"
+}
+```
+
+### ast (Future)
+AST-based detection for complex structural patterns.
+
+```json
+{
+  "pattern": "function[params>5]",
+  "patternType": "ast"
+}
+```
+
+## Usage in Code
+
+```javascript
+// Load rules
+const rules = JSON.parse(fs.readFileSync('correctness-rules.json'));
+
+// Apply rules
+for (const rule of rules.rules) {
+  const matches = detectByPattern(content, rule.pattern, rule.patternType);
+  for (const match of matches) {
+    // Check negative patterns
+    if (rule.negativePatterns?.some(np => match.context.includes(np))) {
+      continue;
+    }
+    findings.push({
+      id: `${rules.prefix}-${counter++}`,
+      severity: rule.severity,
+      category: rule.category,
+      description: rule.description,
+      recommendation: rule.recommendation,
+      fixExample: rule.fixExample
+    });
+  }
+}
+```
+
+## Adding New Rules
+
+1. Identify the appropriate dimension
+2. Create rule with unique `id` within dimension
+3. Choose appropriate `patternType`
+4. Provide clear `description` and `recommendation`
+5. Include practical `fixExample`
+6. Test against sample code
+
+## Rule Maintenance
+
+- Review rules quarterly for relevance
+- Update patterns as language/framework evolves
+- Track false positive rates
+- Collect feedback from users

package/.claude/skills/skill-generator/specs/cli-integration.md

@@ -304,28 +304,22 @@ async function runWithTool(tool, context) {
 ### 引用协议模板
 
 ```bash
-# 分析模式 - 必须引用 analysis-protocol.md
+# Analysis mode - use --rule to auto-load protocol and template (appended to prompt)
 ccw cli -p "
-RULES: $(cat ~/.claude/workflows/cli-templates/protocols/analysis-protocol.md)
-$(cat ~/.claude/workflows/cli-templates/prompts/analysis/02-analyze-code-patterns.txt)
-..." --tool gemini --mode analysis
+CONSTRAINTS: ...
+..." --tool gemini --mode analysis --rule analysis-code-patterns
 
-# 写入模式 - 必须引用 write-protocol.md
+# Write mode - use --rule to auto-load protocol and template (appended to prompt)
 ccw cli -p "
-RULES: $(cat ~/.claude/workflows/cli-templates/protocols/write-protocol.md)
-$(cat ~/.claude/workflows/cli-templates/prompts/development/02-implement-feature.txt)
-..." --tool codex --mode write
+CONSTRAINTS: ...
+..." --tool codex --mode write --rule development-feature
 ```
 
 ### 动态模板构建
 
 ```javascript
 function buildPrompt(config) {
-  const { purpose, task, mode, context, expected, template } = config;
-
-  const protocolPath = mode === 'write'
-    ? '~/.claude/workflows/cli-templates/protocols/write-protocol.md'
-    : '~/.claude/workflows/cli-templates/protocols/analysis-protocol.md';
+  const { purpose, task, mode, context, expected, constraints } = config;
 
   return `
 PURPOSE: ${purpose}
@@ -333,8 +327,8 @@ TASK: ${task.map(t => `• ${t}`).join('\n')}
 MODE: ${mode}
 CONTEXT: ${context}
 EXPECTED: ${expected}
-RULES: $(cat ${protocolPath}) $(cat ${template})
-`;
+CONSTRAINTS: ${constraints || ''}
+`; // Use --rule option to auto-append protocol + template
 }
 ```
 
@@ -435,11 +429,11 @@ CLI 调用 (Bash + ccw cli):
 - 相关任务使用 `--resume` 保持上下文
 - 独立任务不使用 `--resume`
 
-### 4. 提示词规范
+### 4. Prompt Specification
 
-- 始终使用 PURPOSE/TASK/MODE/CONTEXT/EXPECTED/RULES 结构
-- 必须引用协议模板（analysis-protocol 或 write-protocol）
-- 使用 `$(cat ...)` 动态加载模板
+- Always use PURPOSE/TASK/MODE/CONTEXT/EXPECTED/CONSTRAINTS structure
+- Use `--rule <template>` to auto-append protocol + template to prompt
+- Template name format: `category-function` (e.g., `analysis-code-patterns`)
 
 ### 5. 结果处理