claude-code-workflow 6.3.22 → 6.3.24

package/.claude/agents/issue-plan-agent.md

@@ -212,14 +212,14 @@ Write solution JSON to JSONL file (one line per solution):
 
 **File Format** (JSONL - each line is a complete solution):
 ```
-{"id":"SOL-GH-123-1","description":"...","approach":"...","analysis":{...},"score":0.85,"tasks":[...]}
-{"id":"SOL-GH-123-2","description":"...","approach":"...","analysis":{...},"score":0.75,"tasks":[...]}
+{"id":"SOL-GH-123-a7x9","description":"...","approach":"...","analysis":{...},"score":0.85,"tasks":[...]}
+{"id":"SOL-GH-123-b2k4","description":"...","approach":"...","analysis":{...},"score":0.75,"tasks":[...]}
 ```
 
 **Solution Schema** (must match CLI `Solution` interface):
 ```typescript
 {
-  id: string;                    // Format: SOL-{issue-id}-{N}
+  id: string;                    // Format: SOL-{issue-id}-{uid}
   description?: string;
   approach?: string;
   tasks: SolutionTask[];
@@ -232,9 +232,14 @@ Write solution JSON to JSONL file (one line per solution):
 **Write Operation**:
 ```javascript
 // Append solution to JSONL file (one line per solution)
-const solutionId = `SOL-${issueId}-${seq}`;
+// Use 4-char random uid to avoid collisions across multiple plan runs
+const uid = Math.random().toString(36).slice(2, 6);  // e.g., "a7x9"
+const solutionId = `SOL-${issueId}-${uid}`;
 const solutionLine = JSON.stringify({ id: solutionId, ...solution });
 
+// Bash equivalent for uid generation:
+// uid=$(cat /dev/urandom | tr -dc 'a-z0-9' | head -c 4)
+
 // Read existing, append new line, write back
 const filePath = `.workflow/issues/solutions/${issueId}.jsonl`;
 const existing = existsSync(filePath) ? readFileSync(filePath) : '';
@@ -311,7 +316,7 @@ Each line is a solution JSON containing tasks. Schema: `cat .claude/workflows/cl
 6. Evaluate each solution with `analysis` and `score`
 7. Write solutions to `.workflow/issues/solutions/{issue-id}.jsonl` (append mode)
 8. For HIGH complexity: generate 2-3 candidate solutions
-9. **Solution ID format**: `SOL-{issue-id}-{N}` (e.g., `SOL-GH-123-1`, `SOL-GH-123-2`)
+9. **Solution ID format**: `SOL-{issue-id}-{uid}` where uid is 4 random alphanumeric chars (e.g., `SOL-GH-123-a7x9`)
 10. **GitHub Reply Task**: If issue has `github_url` or `github_number`, add final task to comment on GitHub issue with completion summary
 
 **CONFLICT AVOIDANCE** (for batch processing of similar issues):

package/.claude/commands/issue/plan.md

@@ -203,7 +203,7 @@ ${issueList}
 7. Single solution → auto-bind; Multiple → return for selection
 
 ### Rules
-- Solution ID format: SOL-{issue-id}-{seq}
+- Solution ID format: SOL-{issue-id}-{uid} (uid: 4 random alphanumeric chars, e.g., a7x9)
 - Single solution per issue → auto-bind via ccw issue bind
 - Multiple solutions → register only, return pending_selection
 - Tasks must have quantified acceptance.criteria

package/.claude/skills/review-code/SKILL.md

@@ -0,0 +1,170 @@
+---
+name: review-code
+description: Multi-dimensional code review with structured reports. Analyzes correctness, readability, performance, security, testing, and architecture. Triggers on "review code", "code review", "审查代码", "代码审查".
+allowed-tools: Task, AskUserQuestion, Read, Write, Glob, Grep, Bash, mcp__ace-tool__search_context, mcp__ide__getDiagnostics
+---
+
+# Review Code
+
+Multi-dimensional code review skill that analyzes code across 6 key dimensions and generates structured review reports with actionable recommendations.
+
+## Architecture Overview
+
+```
+┌─────────────────────────────────────────────────────────────────┐
+│  ⚠️ Phase 0: Specification Study (强制前置)                       │
+│              → 阅读 specs/review-dimensions.md                   │
+│              → 理解审查维度和问题分类标准                          │
+└───────────────┬─────────────────────────────────────────────────┘
+                ↓
+┌─────────────────────────────────────────────────────────────────┐
+│           Orchestrator (状态驱动决策)                             │
+│           → 读取状态 → 选择审查动作 → 执行 → 更新状态              │
+└───────────────┬─────────────────────────────────────────────────┘
+                │
+    ┌───────────┼───────────┬───────────┬───────────┐
+    ↓           ↓           ↓           ↓           ↓
+┌─────────┐ ┌─────────┐ ┌─────────┐ ┌─────────┐ ┌─────────┐
+│ Collect │ │ Quick   │ │ Deep    │ │ Report  │ │Complete │
+│ Context │ │ Scan    │ │ Review  │ │ Generate│ │         │
+└─────────┘ └─────────┘ └─────────┘ └─────────┘ └─────────┘
+     ↓           ↓           ↓           ↓
+┌─────────────────────────────────────────────────────────────────┐
+│                     Review Dimensions                            │
+│  ┌──────────┐ ┌──────────┐ ┌──────────┐ ┌──────────┐            │
+│  │Correctness│ │Readability│ │Performance│ │ Security │            │
+│  └──────────┘ └──────────┘ └──────────┘ └──────────┘            │
+│  ┌──────────┐ ┌──────────┐                                       │
+│  │ Testing  │ │Architecture│                                      │
+│  └──────────┘ └──────────┘                                       │
+└─────────────────────────────────────────────────────────────────┘
+```
+
+## Key Design Principles
+
+1. **多维度审查**: 覆盖正确性、可读性、性能、安全性、测试覆盖、架构一致性六大维度
+2. **分层执行**: 快速扫描识别高风险区域，深入审查聚焦关键问题
+3. **结构化报告**: 按严重程度分类，提供文件位置和修复建议
+4. **状态驱动**: 自主模式，根据审查进度动态选择下一步动作
+
+---
+
+## ⚠️ Mandatory Prerequisites (强制前置条件)
+
+> **⛔ 禁止跳过**: 在执行任何审查操作之前，**必须**完整阅读以下文档。
+
+### 规范文档 (必读)
+
+| Document | Purpose | Priority |
+|----------|---------|----------|
+| [specs/review-dimensions.md](specs/review-dimensions.md) | 审查维度定义和检查点 | **P0 - 最高** |
+| [specs/issue-classification.md](specs/issue-classification.md) | 问题分类和严重程度标准 | **P0 - 最高** |
+| [specs/quality-standards.md](specs/quality-standards.md) | 审查质量标准 | P1 |
+
+### 模板文件 (生成前必读)
+
+| Document | Purpose |
+|----------|---------|
+| [templates/review-report.md](templates/review-report.md) | 审查报告模板 |
+| [templates/issue-template.md](templates/issue-template.md) | 问题记录模板 |
+
+---
+
+## Execution Flow
+
+```
+┌─────────────────────────────────────────────────────────────────┐
+│  Phase 0: Specification Study (强制前置 - 禁止跳过)               │
+│  → Read: specs/review-dimensions.md                              │
+│  → Read: specs/issue-classification.md                           │
+│  → 理解审查标准和问题分类                                          │
+├─────────────────────────────────────────────────────────────────┤
+│  Action: collect-context                                         │
+│  → 收集目标文件/目录                                               │
+│  → 识别技术栈和语言                                                │
+│  → Output: state.context (files, language, framework)            │
+├─────────────────────────────────────────────────────────────────┤
+│  Action: quick-scan                                              │
+│  → 快速扫描整体结构                                                │
+│  → 识别高风险区域                                                  │
+│  → Output: state.risk_areas, state.scan_summary                  │
+├─────────────────────────────────────────────────────────────────┤
+│  Action: deep-review (per dimension)                             │
+│  → 逐维度深入审查                                                  │
+│  → 记录发现的问题                                                  │
+│  → Output: state.findings[]                                      │
+├─────────────────────────────────────────────────────────────────┤
+│  Action: generate-report                                         │
+│  → 汇总所有发现                                                    │
+│  → 生成结构化报告                                                  │
+│  → Output: review-report.md                                      │
+├─────────────────────────────────────────────────────────────────┤
+│  Action: complete                                                │
+│  → 保存最终状态                                                    │
+│  → 输出审查摘要                                                    │
+└─────────────────────────────────────────────────────────────────┘
+```
+
+## Directory Setup
+
+```javascript
+const timestamp = new Date().toISOString().slice(0,19).replace(/[-:T]/g, '');
+const workDir = `.workflow/.scratchpad/review-code-${timestamp}`;
+
+Bash(`mkdir -p "${workDir}"`);
+Bash(`mkdir -p "${workDir}/findings"`);
+```
+
+## Output Structure
+
+```
+.workflow/.scratchpad/review-code-{timestamp}/
+├── state.json                    # 审查状态
+├── context.json                  # 目标上下文
+├── findings/                     # 问题发现
+│   ├── correctness.json
+│   ├── readability.json
+│   ├── performance.json
+│   ├── security.json
+│   ├── testing.json
+│   └── architecture.json
+└── review-report.md              # 最终审查报告
+```
+
+## Review Dimensions
+
+| Dimension | Focus Areas | Key Checks |
+|-----------|-------------|------------|
+| **Correctness** | 逻辑正确性 | 边界条件、错误处理、null 检查 |
+| **Readability** | 代码可读性 | 命名规范、函数长度、注释质量 |
+| **Performance** | 性能效率 | 算法复杂度、I/O 优化、资源使用 |
+| **Security** | 安全性 | 注入风险、敏感信息、权限控制 |
+| **Testing** | 测试覆盖 | 测试充分性、边界覆盖、可维护性 |
+| **Architecture** | 架构一致性 | 设计模式、分层结构、依赖管理 |
+
+## Issue Severity Levels
+
+| Level | Prefix | Description | Action Required |
+|-------|--------|-------------|-----------------|
+| **Critical** | [C] | 阻塞性问题，必须立即修复 | Must fix before merge |
+| **High** | [H] | 重要问题，需要修复 | Should fix |
+| **Medium** | [M] | 建议改进 | Consider fixing |
+| **Low** | [L] | 可选优化 | Nice to have |
+| **Info** | [I] | 信息性建议 | For reference |
+
+## Reference Documents
+
+| Document | Purpose |
+|----------|---------|
+| [phases/orchestrator.md](phases/orchestrator.md) | 审查编排器 |
+| [phases/state-schema.md](phases/state-schema.md) | 状态结构定义 |
+| [phases/actions/action-collect-context.md](phases/actions/action-collect-context.md) | 收集上下文 |
+| [phases/actions/action-quick-scan.md](phases/actions/action-quick-scan.md) | 快速扫描 |
+| [phases/actions/action-deep-review.md](phases/actions/action-deep-review.md) | 深入审查 |
+| [phases/actions/action-generate-report.md](phases/actions/action-generate-report.md) | 生成报告 |
+| [phases/actions/action-complete.md](phases/actions/action-complete.md) | 完成审查 |
+| [specs/review-dimensions.md](specs/review-dimensions.md) | 审查维度规范 |
+| [specs/issue-classification.md](specs/issue-classification.md) | 问题分类标准 |
+| [specs/quality-standards.md](specs/quality-standards.md) | 质量标准 |
+| [templates/review-report.md](templates/review-report.md) | 报告模板 |
+| [templates/issue-template.md](templates/issue-template.md) | 问题模板 |

package/.claude/skills/review-code/phases/actions/action-collect-context.md

@@ -0,0 +1,139 @@
+# Action: Collect Context
+
+收集审查目标的上下文信息。
+
+## Purpose
+
+在开始审查前，收集目标代码的基本信息：
+- 确定审查范围（文件/目录）
+- 识别编程语言和框架
+- 统计代码规模
+
+## Preconditions
+
+- [ ] state.status === 'pending' || state.context === null
+
+## Execution
+
+```javascript
+async function execute(state, workDir) {
+  // 1. 询问用户审查目标
+  const input = await AskUserQuestion({
+    questions: [{
+      question: "请指定要审查的代码路径：",
+      header: "审查目标",
+      multiSelect: false,
+      options: [
+        { label: "当前目录", description: "审查当前工作目录下的所有代码" },
+        { label: "src/", description: "审查 src/ 目录" },
+        { label: "手动指定", description: "输入自定义路径" }
+      ]
+    }]
+  });
+  
+  const targetPath = input["审查目标"] === "手动指定" 
+    ? input["其他"] 
+    : input["审查目标"] === "当前目录" ? "." : "src/";
+  
+  // 2. 收集文件列表
+  const files = Glob(`${targetPath}/**/*.{ts,tsx,js,jsx,py,java,go,rs,cpp,c,cs}`);
+  
+  // 3. 检测主要语言
+  const languageCounts = {};
+  files.forEach(file => {
+    const ext = file.split('.').pop();
+    const langMap = {
+      'ts': 'TypeScript', 'tsx': 'TypeScript',
+      'js': 'JavaScript', 'jsx': 'JavaScript',
+      'py': 'Python',
+      'java': 'Java',
+      'go': 'Go',
+      'rs': 'Rust',
+      'cpp': 'C++', 'c': 'C',
+      'cs': 'C#'
+    };
+    const lang = langMap[ext] || 'Unknown';
+    languageCounts[lang] = (languageCounts[lang] || 0) + 1;
+  });
+  
+  const primaryLanguage = Object.entries(languageCounts)
+    .sort((a, b) => b[1] - a[1])[0]?.[0] || 'Unknown';
+  
+  // 4. 统计代码行数
+  let totalLines = 0;
+  for (const file of files.slice(0, 100)) {  // 限制前100个文件
+    try {
+      const content = Read(file);
+      totalLines += content.split('\n').length;
+    } catch (e) {}
+  }
+  
+  // 5. 检测框架
+  let framework = null;
+  if (files.some(f => f.includes('package.json'))) {
+    const pkg = JSON.parse(Read('package.json'));
+    if (pkg.dependencies?.react) framework = 'React';
+    else if (pkg.dependencies?.vue) framework = 'Vue';
+    else if (pkg.dependencies?.angular) framework = 'Angular';
+    else if (pkg.dependencies?.express) framework = 'Express';
+    else if (pkg.dependencies?.next) framework = 'Next.js';
+  }
+  
+  // 6. 构建上下文
+  const context = {
+    target_path: targetPath,
+    files: files.slice(0, 200),  // 限制最多200个文件
+    language: primaryLanguage,
+    framework: framework,
+    total_lines: totalLines,
+    file_count: files.length
+  };
+  
+  // 7. 保存上下文
+  Write(`${workDir}/context.json`, JSON.stringify(context, null, 2));
+  
+  return {
+    stateUpdates: {
+      status: 'running',
+      context: context
+    }
+  };
+}
+```
+
+## State Updates
+
+```javascript
+return {
+  stateUpdates: {
+    status: 'running',
+    context: {
+      target_path: targetPath,
+      files: fileList,
+      language: primaryLanguage,
+      framework: detectedFramework,
+      total_lines: totalLines,
+      file_count: fileCount
+    }
+  }
+};
+```
+
+## Output
+
+- **File**: `context.json`
+- **Location**: `${workDir}/context.json`
+- **Format**: JSON
+
+## Error Handling
+
+| Error Type | Recovery |
+|------------|----------|
+| 路径不存在 | 提示用户重新输入 |
+| 无代码文件 | 返回错误，终止审查 |
+| 读取权限问题 | 跳过该文件，记录警告 |
+
+## Next Actions
+
+- 成功: action-quick-scan
+- 失败: action-abort

package/.claude/skills/review-code/phases/actions/action-complete.md

@@ -0,0 +1,115 @@
+# Action: Complete
+
+完成审查，保存最终状态。
+
+## Purpose
+
+结束代码审查流程：
+- 保存最终状态
+- 输出审查摘要
+- 提供报告路径
+
+## Preconditions
+
+- [ ] state.status === 'running'
+- [ ] state.report_generated === true
+
+## Execution
+
+```javascript
+async function execute(state, workDir) {
+  // 1. 计算审查时长
+  const duration = Date.now() - new Date(state.started_at).getTime();
+  const durationMinutes = Math.round(duration / 60000);
+  
+  // 2. 生成最终摘要
+  const summary = {
+    ...state.summary,
+    review_duration_ms: duration,
+    completed_at: new Date().toISOString()
+  };
+  
+  // 3. 保存最终状态
+  const finalState = {
+    ...state,
+    status: 'completed',
+    completed_at: summary.completed_at,
+    summary: summary
+  };
+  
+  Write(`${workDir}/state.json`, JSON.stringify(finalState, null, 2));
+  
+  // 4. 输出摘要信息
+  console.log('========================================');
+  console.log('        CODE REVIEW COMPLETED');
+  console.log('========================================');
+  console.log('');
+  console.log(`📁 审查目标: ${state.context.target_path}`);
+  console.log(`📄 文件数量: ${state.context.file_count}`);
+  console.log(`📝 代码行数: ${state.context.total_lines}`);
+  console.log('');
+  console.log('--- 问题统计 ---');
+  console.log(`🔴 Critical: ${summary.critical}`);
+  console.log(`🟠 High:     ${summary.high}`);
+  console.log(`🟡 Medium:   ${summary.medium}`);
+  console.log(`🔵 Low:      ${summary.low}`);
+  console.log(`⚪ Info:     ${summary.info}`);
+  console.log(`📊 Total:    ${summary.total_issues}`);
+  console.log('');
+  console.log(`⏱️  审查用时: ${durationMinutes} 分钟`);
+  console.log('');
+  console.log(`📋 报告位置: ${state.report_path}`);
+  console.log('========================================');
+  
+  // 5. 返回状态更新
+  return {
+    stateUpdates: {
+      status: 'completed',
+      completed_at: summary.completed_at,
+      summary: summary
+    }
+  };
+}
+```
+
+## State Updates
+
+```javascript
+return {
+  stateUpdates: {
+    status: 'completed',
+    completed_at: new Date().toISOString(),
+    summary: {
+      total_issues: state.summary.total_issues,
+      critical: state.summary.critical,
+      high: state.summary.high,
+      medium: state.summary.medium,
+      low: state.summary.low,
+      info: state.summary.info,
+      review_duration_ms: duration
+    }
+  }
+};
+```
+
+## Output
+
+- **Console**: 审查完成摘要
+- **State**: 最终状态保存到 `state.json`
+
+## Error Handling
+
+| Error Type | Recovery |
+|------------|----------|
+| 状态保存失败 | 输出到控制台 |
+
+## Next Actions
+
+- 无（终止状态）
+
+## Post-Completion
+
+用户可以：
+1. 查看完整报告: `cat ${workDir}/review-report.md`
+2. 查看问题详情: `cat ${workDir}/findings/*.json`
+3. 导出报告到其他位置