claude-code-session-manager 0.35.9 → 0.35.10

package/dist/index.html

@@ -7,7 +7,7 @@
     <link rel="preconnect" href="https://fonts.googleapis.com">
     <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
     <link href="https://fonts.googleapis.com/css2?family=Newsreader:ital,opsz,wght@0,6..72,400;0,6..72,500;0,6..72,600;0,6..72,700;1,6..72,400&family=Geist:wght@300;400;500;600;700&family=IBM+Plex+Mono:wght@400;500;600&display=swap" rel="stylesheet">
-    <script type="module" crossorigin src="./assets/index-B4PkQh71.js"></script>
+    <script type="module" crossorigin src="./assets/index-B1hI9l9p.js"></script>
     <link rel="modulepreload" crossorigin href="./assets/monaco-editor-BW5C4Iv1.js">
     <link rel="stylesheet" crossorigin href="./assets/monaco-editor-BTnBOi8r.css">
     <link rel="stylesheet" crossorigin href="./assets/index-C7NyYuXu.css">

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-code-session-manager",
-  "version": "0.35.9",
+  "version": "0.35.10",
   "description": "Local cockpit for the Claude Code CLI — multi-tab terminal, full config surface, scheduler, voice dictation, and live observability.",
   "type": "module",
   "main": "src/main/index.cjs",

package/src/main/__tests__/runVerify.test.cjs

@@ -903,6 +903,25 @@ test('pass_no_commit: SCHEDULER_VERDICT: PASS but no commit landed → needs_rev
   }
 });
 
+test('pass_no_commit: fix-plan job (slug ^\\d+-fix-) with PASS but no commit is exempt → clean', async () => {
+  const tmp = makeTmpDir();
+  try {
+    const slug = '523-fix-bounded-fix-plan-retry';
+    writeLog(tmp, slug, noOpRunEvents('Verification complete — no code gap exists.\nSCHEDULER_VERDICT: PASS'));
+    const prdPath = writePrd(tmp, slug, '# Fix: bounded fix-plan retry');
+    const verdict = await verifyRun({
+      runDir: tmp,
+      prdPath,
+      queueEntry: { slug, status: 'running' },
+      allJobs: [],
+      committedDuringRun: false,
+    });
+    assert.equal(verdict.verdict, 'clean', `expected clean (fix-plan exemption), got ${verdict.verdict}: ${verdict.reason}`);
+  } finally {
+    rmdir(tmp);
+  }
+});
+
 // (e) halt + sentinel PASS → still halt (override must not apply to halt)
 test('halt result + sentinel PASS + committedDuringRun:true → still halt', async () => {
   const tmp = makeTmpDir();

package/src/main/__tests__/scheduler-autofix-select.test.cjs

@@ -8,7 +8,10 @@
 
 const { test } = require('node:test');
 const assert = require('node:assert/strict');
-const { selectAutoFixTargets, isUnresolvableNeedsReview, isRescanCandidate } = require('../scheduler.cjs');
+const {
+  selectAutoFixTargets, isUnresolvableNeedsReview, isRescanCandidate,
+  healTargetForFix, isFixPlanBeyondDepthCap, MAX_INVESTIGATION_DEPTH,
+} = require('../scheduler.cjs');
 
 const noSiblingOnDisk = () => false;
 const noRunDir = () => null;
@@ -150,4 +153,64 @@ test('isRescanCandidate: needs_review + runId + uncommitted_changes → false (g
   assert.strictEqual(isRescanCandidate(job), false);
 });
 
+test('isRescanCandidate: needs_review + runId + pass_no_commit → true (fix-plan exemption can flip the verdict on rescan)', () => {
+  const job = makeJob({ verifierVerdict: 'pass_no_commit' });
+  assert.strictEqual(isRescanCandidate(job), true);
+});
+
+// ---- investigationDepth bound (fix-plan-of-a-fix-plan recursion cap) ----
+
+test('depth-1 (ordinary, no investigationDepth field) needs_review job is eligible', () => {
+  const jobs = [makeJob({ slug: '05-my-feature' })];
+  const result = selectAutoFixTargets(jobs, { fixSlugExists: noSiblingOnDisk });
+  assert.strictEqual(result.length, 1);
+});
+
+test('fix-plan job with investigationDepth: 2 is now ALSO eligible', () => {
+  const jobs = [makeJob({ slug: '05-fix-foo', investigationDepth: 2 })];
+  const result = selectAutoFixTargets(jobs, { fixSlugExists: noSiblingOnDisk });
+  assert.strictEqual(result.length, 1);
+});
+
+test('fix-plan job with investigationDepth: 3 is NOT eligible (bound holds)', () => {
+  const jobs = [makeJob({ slug: '05-fix-foo', investigationDepth: 3 })];
+  const result = selectAutoFixTargets(jobs, { fixSlugExists: noSiblingOnDisk });
+  assert.strictEqual(result.length, 0);
+});
+
+test('legacy fix-plan job with no investigationDepth field defaults to excluded (back-compat)', () => {
+  const jobs = [makeJob({ slug: '05-fix-foo' })];
+  const result = selectAutoFixTargets(jobs, { fixSlugExists: noSiblingOnDisk });
+  assert.strictEqual(result.length, 0);
+});
+
+test('isFixPlanBeyondDepthCap: non-fix-plan slug is never capped regardless of depth', () => {
+  assert.strictEqual(isFixPlanBeyondDepthCap('05-my-feature', 99), false);
+});
+
+test('isFixPlanBeyondDepthCap: fix-plan at depth 1 or 2 is not capped, depth 3 is', () => {
+  assert.strictEqual(isFixPlanBeyondDepthCap('05-fix-foo', 1), false);
+  assert.strictEqual(isFixPlanBeyondDepthCap('05-fix-foo', MAX_INVESTIGATION_DEPTH), false);
+  assert.strictEqual(isFixPlanBeyondDepthCap('05-fix-foo', MAX_INVESTIGATION_DEPTH + 1), true);
+});
+
+test('healTargetForFix: depth-2 fix-of-a-fix slug resolves back to the depth-1 fix job (521-fix-recorder-export-footer-redesign)', () => {
+  // Depth-1 fix job: originally authored to fix job 521, itself in needs_review.
+  const depth1FixJob = {
+    slug: '521-fix-recorder-export-footer-redesign',
+    status: 'needs_review',
+    parallelGroup: 521,
+    investigationDepth: 2,
+  };
+  const jobs = [depth1FixJob];
+  // spawnInvestigation's fix-slug formula: baseSlug strips only the leading
+  // numeric prefix (not "fix-"), so investigating this depth-1 fix job
+  // produces a depth-2 fix slug of the form "<group>-fix-fix-<rest>".
+  const baseSlug = depth1FixJob.slug.replace(/^\d+-/, '');
+  const depth2FixSlug = `${String(depth1FixJob.parallelGroup).padStart(2, '0')}-fix-${baseSlug}`;
+  assert.strictEqual(depth2FixSlug, '521-fix-fix-recorder-export-footer-redesign');
+  const resolved = healTargetForFix(depth2FixSlug, jobs);
+  assert.strictEqual(resolved, depth1FixJob);
+});
+
 console.log('scheduler-autofix-select tests: PASS');

package/src/main/runVerify.cjs

@@ -636,7 +636,20 @@ async function verifyRun({ runDir, prdPath, queueEntry, allJobs = [], committedD
     // silently accepting a bare sentinel as proof of work done. Mutually
     // exclusive with the no_verdict_sentinel case above (sentinel === null
     // vs sentinel === 'pass'), kept as a separate sibling check for clarity.
-    if (sentinel === 'pass' && !committedDuringRun) {
+    //
+    // EXEMPTION: fix-plan jobs (slug matches ^\d+-fix-) are investigations —
+    // "I checked, the original work already landed correctly, nothing to
+    // change" is a legitimate, correct, common outcome for them, not a
+    // silent no-op bug. Applying this check to fix-plan jobs the same way as
+    // original feature/bugfix PRDs produced a false-positive cascade
+    // (2026-07-12: 523-fix-bounded-fix-plan-retry re-verified PRD 523, found
+    // it already fully implemented and committed, correctly declined to make
+    // a no-op commit, and printed a truthful PASS — but still got flagged
+    // needs_review). Original PRDs are expected to build something new, so a
+    // bare PASS with no commit from one is still a strong silent-failure
+    // signal and stays covered by this check.
+    const isFixPlanJob = /^\d+-fix-/.test(queueEntry?.slug || '');
+    if (sentinel === 'pass' && !committedDuringRun && !isFixPlanJob) {
       issues.push({
         verdict: 'pass_no_commit',
         reason: 'SCHEDULER_VERDICT: PASS but no commit landed during the run window — the run claims success but produced no code change',

package/src/main/scheduler.cjs

@@ -616,7 +616,7 @@ async function reconcile(state) {
   }
   for (const [slug, p] of onDisk) {
     if (seen.has(slug)) continue;
-    next.push({
+    const entry = {
       slug,
       title: p.title,
       cwd: p.cwd,
@@ -629,7 +629,16 @@ async function reconcile(state) {
       finishedAt: null,
       exitCode: null,
       error: null,
-    });
+    };
+    // Newly-discovered fix-plan PRD: stamp its investigationDepth relative to
+    // the original job it heals, so selectAutoFixTargets/spawnInvestigation
+    // can bound the fix-of-a-fix recursion (see MAX_INVESTIGATION_DEPTH).
+    // Non-fix-plan jobs get no explicit field — they read as depth 1 via `?? 1`.
+    if (isFixPlanSlug(slug)) {
+      const parent = healTargetForFix(slug, state.jobs);
+      entry.investigationDepth = parent ? (parent.investigationDepth ?? 1) + 1 : 2;
+    }
+    next.push(entry);
   }
   state.jobs = next.sort((a, b) => b.slug.localeCompare(a.slug));
   return state;
@@ -1244,8 +1253,8 @@ DO NOT attempt the fix. ONLY write the file. When the file exists, exit immediat
  * Skipped if the failed job is itself a fix-plan (avoids infinite recursion).
  */
 async function spawnInvestigation(failedJob, runDir) {
-  if (isFixPlanSlug(failedJob.slug)) {
-    console.log(`[scheduler] skip investigation: ${failedJob.slug} is itself a fix plan`);
+  if (isFixPlanBeyondDepthCap(failedJob.slug, failedJob.investigationDepth)) {
+    console.log(`[scheduler] skip investigation: ${failedJob.slug} is a fix plan at/beyond depth cap (depth=${failedJob.investigationDepth ?? 'none'})`);
     return { deferred: false };
   }
   if (investigationsInFlight >= MAX_CONCURRENT_INVESTIGATIONS) {
@@ -1929,8 +1938,35 @@ function selectHistoryJobs(jobs, limit) {
 // commit-detection, which committedInWindow() can fix retroactively (e.g. the
 // git-log --all scan added for missed non-HEAD commits) — rescanning lets a
 // job whose commit is now correctly detected clear on its own instead of
-// staying stuck in needs_review forever.
-const RESCANNABLE_VERDICTS = new Set(['transcript_errors', 'verify_unavailable', 'no_verdict_sentinel']);
+// staying stuck in needs_review forever. 'pass_no_commit' is included because
+// verifyRun now exempts fix-plan jobs (slug ^\d+-fix-) from that check — a
+// fix-plan job flagged before that exemption shipped gets a genuinely
+// different verdict on rescan (2026-07-12: false-positive cascade where
+// investigation jobs correctly found "nothing to fix" but were flagged
+// anyway). For non-fix-plan jobs the exemption never applies, so rescanning
+// their pass_no_commit verdict is a harmless no-op (same facts, same verdict).
+const RESCANNABLE_VERDICTS = new Set(['transcript_errors', 'verify_unavailable', 'no_verdict_sentinel', 'pass_no_commit']);
+
+// Bounds fix-plan recursion: depth 1 = the original job, depth 2 = its fix
+// (gets exactly one follow-up investigation if it also lands in
+// needs_review), depth 3+ (a fix-of-a-fix-of-a-fix) is excluded. Shared by
+// selectAutoFixTargets and spawnInvestigation so both call sites agree on
+// one threshold.
+const MAX_INVESTIGATION_DEPTH = 2;
+
+/**
+ * True when a fix-plan job's investigationDepth is at or past the recursion
+ * cap and it must be excluded from auto-fix eligibility. A fix-plan job with
+ * no recorded investigationDepth (a job already in the queue before this
+ * depth tracking shipped) is treated as excluded too, preserving the
+ * pre-existing blanket-exclusion behavior for legacy jobs — no retroactive
+ * migration. Non-fix-plan slugs are never capped here. Exported for tests.
+ */
+function isFixPlanBeyondDepthCap(slug, investigationDepth) {
+  if (!isFixPlanSlug(slug)) return false;
+  if (investigationDepth == null) return true;
+  return investigationDepth >= MAX_INVESTIGATION_DEPTH + 1;
+}
 
 /**
  * Backfill a job's missing runId by scanning RUNS_DIR for a run directory
@@ -2019,7 +2055,7 @@ function selectAutoFixTargets(jobs, { fixSlugExists, resolveJobRunId = resolveRu
     if (job.status !== 'needs_review') return false;
     const runId = job.runId || resolveJobRunId(job);
     if (!runId) return false;
-    if (isFixPlanSlug(job.slug)) return false;
+    if (isFixPlanBeyondDepthCap(job.slug, job.investigationDepth)) return false;
     if (job.autoFixAttempted) {
       if (job.autoFixOutcome !== 'no-plan') return false;
       if ((job.autoFixRetries ?? 0) >= 1) return false;
@@ -2665,4 +2701,4 @@ const remote = {
   },
 };
 
-module.exports = { registerScheduleHandlers, attachWindow, init, ROOT, PRDS_DIR, selectHistoryJobs, parsePorcelain, FINISH_PROTOCOL, remote, pickNextBatch, pickForProject, reapDeadRunningJobs, pollRecoveryClearSource, memoryLimitedBatchSize, availableForJobs, reverifyNeedsReview, isRescanCandidate, isPromotableOriginal, selectAutoFixTargets, resolveRunId, isUnresolvableNeedsReview, healTargetForFix, buildInvestigationPrompt, committedInWindow };
+module.exports = { registerScheduleHandlers, attachWindow, init, ROOT, PRDS_DIR, selectHistoryJobs, parsePorcelain, FINISH_PROTOCOL, remote, pickNextBatch, pickForProject, reapDeadRunningJobs, pollRecoveryClearSource, memoryLimitedBatchSize, availableForJobs, reverifyNeedsReview, isRescanCandidate, isPromotableOriginal, selectAutoFixTargets, resolveRunId, isUnresolvableNeedsReview, healTargetForFix, buildInvestigationPrompt, committedInWindow, isFixPlanSlug, isFixPlanBeyondDepthCap, MAX_INVESTIGATION_DEPTH };