clanka 0.2.18 → 0.2.20

package/src/fixtures/patch11-broken.txt

@@ -0,0 +1,219 @@
+const patch = `*** Begin Patch
+*** Update File: packages/effect/src/Cron.ts
+@@
+ export const next = (cron: Cron, now?: DateTime.DateTime.Input): Date => {
++  return stepCron(cron, now, "next")
++}
++
++/**
++ * Returns the previous scheduled date/time for the given Cron instance.
++ *
++ * This function calculates the most recent date and time when the cron
++ * schedule should have triggered, before the specified date (or current
++ * time if not provided).
++ *
++ * @example
++ * ```ts
++ * import { Cron, Result } from "effect"
++ *
++ * const cron = Result.getOrThrow(Cron.parse("0 0 4 8-14 * *"))
++ *
++ * // Get previous run before a specific date
++ * const before = new Date("2021-01-15T00:00:00Z")
++ * const previousRun = Cron.prev(cron, before)
++ * console.log(previousRun) // 2021-01-14T04:00:00.000Z
++ *
++ * // Get previous run from current time
++ * const previousFromNow = Cron.prev(cron)
++ * console.log(previousFromNow) // Previous occurrence from now
++ * ```
++ *
++ * @since 4.0.0
++ * @category utils
++ */
++export const prev = (cron: Cron, now?: DateTime.DateTime.Input): Date => {
++  return stepCron(cron, now, "prev")
++}
++
++const stepCron = (cron: Cron, now: DateTime.DateTime.Input | undefined, direction: "next" | "prev"): Date => {
+   const tz = Option.getOrUndefined(cron.tz)
+   const zoned = dateTime.makeZonedUnsafe(now ?? new Date(), {
+     timeZone: tz
+   })
++
++  const reverse = direction === "prev"
++  const tick = reverse ? -1 : 1
++  const table = cron[direction]
++  const boundary = reverse ? cron.last : cron.first
++
++  const needsStep = reverse ?
++    (next: number, current: number) => next < current :
++    (next: number, current: number) => next > current
+
+   const utc = tz !== undefined && dateTime.isTimeZoneNamed(tz) && tz.id === "UTC"
+   const adjustDst = utc ? constVoid : (current: Date) => {
+     const adjusted = dateTime.makeZonedUnsafe(current, {
+       timeZone: zoned.zone,
+-      adjustForTimeZone: true
++      adjustForTimeZone: true,
++      disambiguation: reverse ? "later" : undefined
+     }).pipe(dateTime.toDate)
+
+-    // TODO: This implementation currently only skips forward when transitioning into daylight savings time.
+     const drift = current.getTime() - adjusted.getTime()
+-    if (drift > 0) {
+-      current.setTime(current.getTime() + drift)
++    if (reverse ? drift !== 0 : drift > 0) {
++      current.setTime(adjusted.getTime())
+     }
+   }
+
+   const result = dateTime.mutate(zoned, (current) => {
+-    current.setUTCSeconds(current.getUTCSeconds() + 1, 0)
++    current.setUTCSeconds(current.getUTCSeconds() + tick, 0)
+
+     for (let i = 0; i < 10_000; i++) {
+       if (cron.seconds.size !== 0) {
+         const currentSecond = current.getUTCSeconds()
+-        const nextSecond = cron.next.second[currentSecond]
++        const nextSecond = table.second[currentSecond]
+         if (nextSecond === undefined) {
+-          current.setUTCMinutes(current.getUTCMinutes() + 1, cron.first.second)
++          current.setUTCMinutes(current.getUTCMinutes() + tick, boundary.second)
+           adjustDst(current)
+           continue
+         }
+-        if (nextSecond > currentSecond) {
++        if (needsStep(nextSecond, currentSecond)) {
+           current.setUTCSeconds(nextSecond)
+           adjustDst(current)
+           continue
+         }
+       }
+
+       if (cron.minutes.size !== 0) {
+         const currentMinute = current.getUTCMinutes()
+-        const nextMinute = cron.next.minute[currentMinute]
++        const nextMinute = table.minute[currentMinute]
+         if (nextMinute === undefined) {
+-          current.setUTCHours(current.getUTCHours() + 1, cron.first.minute, cron.first.second)
++          current.setUTCHours(current.getUTCHours() + tick, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+-        if (nextMinute > currentMinute) {
+-          current.setUTCMinutes(nextMinute, cron.first.second)
++        if (needsStep(nextMinute, currentMinute)) {
++          current.setUTCMinutes(nextMinute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+       }
+
+       if (cron.hours.size !== 0) {
+         const currentHour = current.getUTCHours()
+-        const nextHour = cron.next.hour[currentHour]
++        const nextHour = table.hour[currentHour]
+         if (nextHour === undefined) {
+-          current.setUTCDate(current.getUTCDate() + 1)
+-          current.setUTCHours(cron.first.hour, cron.first.minute, cron.first.second)
++          current.setUTCDate(current.getUTCDate() + tick)
++          current.setUTCHours(boundary.hour, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+-        if (nextHour > currentHour) {
+-          current.setUTCHours(nextHour, cron.first.minute, cron.first.second)
++        if (needsStep(nextHour, currentHour)) {
++          current.setUTCHours(nextHour, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+       }
+
+       if (cron.weekdays.size !== 0 || cron.days.size !== 0) {
+-        let a: number = Infinity
+-        let b: number = Infinity
++        let a: number = reverse ? -Infinity : Infinity
++        let b: number = reverse ? -Infinity : Infinity
+
+         if (cron.weekdays.size !== 0) {
+           const currentWeekday = current.getUTCDay()
+-          const nextWeekday = cron.next.weekday[currentWeekday]
+-          a = nextWeekday === undefined ? 7 - currentWeekday + cron.first.weekday : nextWeekday - currentWeekday
++          const nextWeekday = table.weekday[currentWeekday]
++          if (nextWeekday === undefined) {
++            a = reverse ?
++              currentWeekday - 7 + boundary.weekday :
++              7 - currentWeekday + boundary.weekday
++          } else {
++            a = nextWeekday - currentWeekday
++          }
+         }
+
+         if (cron.days.size !== 0 && a !== 0) {
+           const currentDay = current.getUTCDate()
+-          const nextDay = cron.next.day[currentDay]
+-          b = nextDay === undefined ? daysInMonth(current) - currentDay + cron.first.day : nextDay - currentDay
++          const nextDay = table.day[currentDay]
++          if (nextDay === undefined) {
++            if (reverse) {
++              const prevMonthDays = daysInMonth(new Date(Date.UTC(current.getUTCFullYear(), current.getUTCMonth(), 0)))
++              b = -(currentDay + (prevMonthDays - boundary.day))
++            } else {
++              b = daysInMonth(current) - currentDay + boundary.day
++            }
++          } else {
++            b = nextDay - currentDay
++          }
+         }
+
+-        const addDays = Math.min(a, b)
++        const addDays = reverse ? Math.max(a, b) : Math.min(a, b)
+         if (addDays !== 0) {
+           current.setUTCDate(current.getUTCDate() + addDays)
+-          current.setUTCHours(cron.first.hour, cron.first.minute, cron.first.second)
++          current.setUTCHours(boundary.hour, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+       }
+
+       if (cron.months.size !== 0) {
+         const currentMonth = current.getUTCMonth() + 1
+-        const nextMonth = cron.next.month[currentMonth]
++        const nextMonth = table.month[currentMonth]
++        const clampBoundaryDay = (targetMonthIndex: number): number => {
++          if (cron.days.size !== 0) {
++            return boundary.day
++          }
++          const maxDayInMonth = daysInMonth(new Date(Date.UTC(current.getUTCFullYear(), targetMonthIndex + 1, 0)))
++          return Math.min(boundary.day, maxDayInMonth)
++        }
+         if (nextMonth === undefined) {
+-          current.setUTCFullYear(current.getUTCFullYear() + 1)
+-          current.setUTCMonth(cron.first.month, cron.first.day)
+-          current.setUTCHours(cron.first.hour, cron.first.minute, cron.first.second)
++          current.setUTCFullYear(current.getUTCFullYear() + tick)
++          current.setUTCMonth(boundary.month, clampBoundaryDay(boundary.month))
++          current.setUTCHours(boundary.hour, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+-        if (nextMonth > currentMonth) {
+-          current.setUTCMonth(nextMonth - 1, cron.first.day)
+-          current.setUTCHours(cron.first.hour, cron.first.minute, cron.first.second)
++        if (needsStep(nextMonth, currentMonth)) {
++          const targetMonthIndex = nextMonth - 1
++          current.setUTCMonth(targetMonthIndex, clampBoundaryDay(targetMonthIndex))
++          current.setUTCHours(boundary.hour, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+       }
+@@
+-    throw new Error("Unable to find next cron date")
++    throw new Error(`Unable to find ${direction} cron date`)
+   })
+*** End Patch`
+console.log(await applyPatch(patch))

package/src/fixtures/patch11-fixed.txt

@@ -0,0 +1,219 @@
+const patch = `*** Begin Patch
+*** Update File: packages/effect/src/Cron.ts
+@@
+ export const next = (cron: Cron, now?: DateTime.DateTime.Input): Date => {
++  return stepCron(cron, now, "next")
++}
++
++/**
++ * Returns the previous scheduled date/time for the given Cron instance.
++ *
++ * This function calculates the most recent date and time when the cron
++ * schedule should have triggered, before the specified date (or current
++ * time if not provided).
++ *
++ * @example
++ * \`\`\`ts
++ * import { Cron, Result } from "effect"
++ *
++ * const cron = Result.getOrThrow(Cron.parse("0 0 4 8-14 * *"))
++ *
++ * // Get previous run before a specific date
++ * const before = new Date("2021-01-15T00:00:00Z")
++ * const previousRun = Cron.prev(cron, before)
++ * console.log(previousRun) // 2021-01-14T04:00:00.000Z
++ *
++ * // Get previous run from current time
++ * const previousFromNow = Cron.prev(cron)
++ * console.log(previousFromNow) // Previous occurrence from now
++ * \`\`\`
++ *
++ * @since 4.0.0
++ * @category utils
++ */
++export const prev = (cron: Cron, now?: DateTime.DateTime.Input): Date => {
++  return stepCron(cron, now, "prev")
++}
++
++const stepCron = (cron: Cron, now: DateTime.DateTime.Input | undefined, direction: "next" | "prev"): Date => {
+   const tz = Option.getOrUndefined(cron.tz)
+   const zoned = dateTime.makeZonedUnsafe(now ?? new Date(), {
+     timeZone: tz
+   })
++
++  const reverse = direction === "prev"
++  const tick = reverse ? -1 : 1
++  const table = cron[direction]
++  const boundary = reverse ? cron.last : cron.first
++
++  const needsStep = reverse ?
++    (next: number, current: number) => next < current :
++    (next: number, current: number) => next > current
+
+   const utc = tz !== undefined && dateTime.isTimeZoneNamed(tz) && tz.id === "UTC"
+   const adjustDst = utc ? constVoid : (current: Date) => {
+     const adjusted = dateTime.makeZonedUnsafe(current, {
+       timeZone: zoned.zone,
+-      adjustForTimeZone: true
++      adjustForTimeZone: true,
++      disambiguation: reverse ? "later" : undefined
+     }).pipe(dateTime.toDate)
+
+-    // TODO: This implementation currently only skips forward when transitioning into daylight savings time.
+     const drift = current.getTime() - adjusted.getTime()
+-    if (drift > 0) {
+-      current.setTime(current.getTime() + drift)
++    if (reverse ? drift !== 0 : drift > 0) {
++      current.setTime(adjusted.getTime())
+     }
+   }
+
+   const result = dateTime.mutate(zoned, (current) => {
+-    current.setUTCSeconds(current.getUTCSeconds() + 1, 0)
++    current.setUTCSeconds(current.getUTCSeconds() + tick, 0)
+
+     for (let i = 0; i < 10_000; i++) {
+       if (cron.seconds.size !== 0) {
+         const currentSecond = current.getUTCSeconds()
+-        const nextSecond = cron.next.second[currentSecond]
++        const nextSecond = table.second[currentSecond]
+         if (nextSecond === undefined) {
+-          current.setUTCMinutes(current.getUTCMinutes() + 1, cron.first.second)
++          current.setUTCMinutes(current.getUTCMinutes() + tick, boundary.second)
+           adjustDst(current)
+           continue
+         }
+-        if (nextSecond > currentSecond) {
++        if (needsStep(nextSecond, currentSecond)) {
+           current.setUTCSeconds(nextSecond)
+           adjustDst(current)
+           continue
+         }
+       }
+
+       if (cron.minutes.size !== 0) {
+         const currentMinute = current.getUTCMinutes()
+-        const nextMinute = cron.next.minute[currentMinute]
++        const nextMinute = table.minute[currentMinute]
+         if (nextMinute === undefined) {
+-          current.setUTCHours(current.getUTCHours() + 1, cron.first.minute, cron.first.second)
++          current.setUTCHours(current.getUTCHours() + tick, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+-        if (nextMinute > currentMinute) {
+-          current.setUTCMinutes(nextMinute, cron.first.second)
++        if (needsStep(nextMinute, currentMinute)) {
++          current.setUTCMinutes(nextMinute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+       }
+
+       if (cron.hours.size !== 0) {
+         const currentHour = current.getUTCHours()
+-        const nextHour = cron.next.hour[currentHour]
++        const nextHour = table.hour[currentHour]
+         if (nextHour === undefined) {
+-          current.setUTCDate(current.getUTCDate() + 1)
+-          current.setUTCHours(cron.first.hour, cron.first.minute, cron.first.second)
++          current.setUTCDate(current.getUTCDate() + tick)
++          current.setUTCHours(boundary.hour, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+-        if (nextHour > currentHour) {
+-          current.setUTCHours(nextHour, cron.first.minute, cron.first.second)
++        if (needsStep(nextHour, currentHour)) {
++          current.setUTCHours(nextHour, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+       }
+
+       if (cron.weekdays.size !== 0 || cron.days.size !== 0) {
+-        let a: number = Infinity
+-        let b: number = Infinity
++        let a: number = reverse ? -Infinity : Infinity
++        let b: number = reverse ? -Infinity : Infinity
+
+         if (cron.weekdays.size !== 0) {
+           const currentWeekday = current.getUTCDay()
+-          const nextWeekday = cron.next.weekday[currentWeekday]
+-          a = nextWeekday === undefined ? 7 - currentWeekday + cron.first.weekday : nextWeekday - currentWeekday
++          const nextWeekday = table.weekday[currentWeekday]
++          if (nextWeekday === undefined) {
++            a = reverse ?
++              currentWeekday - 7 + boundary.weekday :
++              7 - currentWeekday + boundary.weekday
++          } else {
++            a = nextWeekday - currentWeekday
++          }
+         }
+
+         if (cron.days.size !== 0 && a !== 0) {
+           const currentDay = current.getUTCDate()
+-          const nextDay = cron.next.day[currentDay]
+-          b = nextDay === undefined ? daysInMonth(current) - currentDay + cron.first.day : nextDay - currentDay
++          const nextDay = table.day[currentDay]
++          if (nextDay === undefined) {
++            if (reverse) {
++              const prevMonthDays = daysInMonth(new Date(Date.UTC(current.getUTCFullYear(), current.getUTCMonth(), 0)))
++              b = -(currentDay + (prevMonthDays - boundary.day))
++            } else {
++              b = daysInMonth(current) - currentDay + boundary.day
++            }
++          } else {
++            b = nextDay - currentDay
++          }
+         }
+
+-        const addDays = Math.min(a, b)
++        const addDays = reverse ? Math.max(a, b) : Math.min(a, b)
+         if (addDays !== 0) {
+           current.setUTCDate(current.getUTCDate() + addDays)
+-          current.setUTCHours(cron.first.hour, cron.first.minute, cron.first.second)
++          current.setUTCHours(boundary.hour, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+       }
+
+       if (cron.months.size !== 0) {
+         const currentMonth = current.getUTCMonth() + 1
+-        const nextMonth = cron.next.month[currentMonth]
++        const nextMonth = table.month[currentMonth]
++        const clampBoundaryDay = (targetMonthIndex: number): number => {
++          if (cron.days.size !== 0) {
++            return boundary.day
++          }
++          const maxDayInMonth = daysInMonth(new Date(Date.UTC(current.getUTCFullYear(), targetMonthIndex + 1, 0)))
++          return Math.min(boundary.day, maxDayInMonth)
++        }
+         if (nextMonth === undefined) {
+-          current.setUTCFullYear(current.getUTCFullYear() + 1)
+-          current.setUTCMonth(cron.first.month, cron.first.day)
+-          current.setUTCHours(cron.first.hour, cron.first.minute, cron.first.second)
++          current.setUTCFullYear(current.getUTCFullYear() + tick)
++          current.setUTCMonth(boundary.month, clampBoundaryDay(boundary.month))
++          current.setUTCHours(boundary.hour, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+-        if (nextMonth > currentMonth) {
+-          current.setUTCMonth(nextMonth - 1, cron.first.day)
+-          current.setUTCHours(cron.first.hour, cron.first.minute, cron.first.second)
++        if (needsStep(nextMonth, currentMonth)) {
++          const targetMonthIndex = nextMonth - 1
++          current.setUTCMonth(targetMonthIndex, clampBoundaryDay(targetMonthIndex))
++          current.setUTCHours(boundary.hour, boundary.minute, boundary.second)
+           adjustDst(current)
+           continue
+         }
+       }
+@@
+-    throw new Error("Unable to find next cron date")
++    throw new Error(\`Unable to find \${direction} cron date\`)
+   })
+*** End Patch`
+console.log(await applyPatch(patch))

package/src/fixtures/patch8-broken.txt

@@ -0,0 +1,30 @@
+await taskComplete(`Implemented backport of Cron reverse scheduling support.
+
+### ✅ Changes made
+- Added internal reverse lookup support to \\`Cron\\`:
+  - new internal \\`last\\` boundary values
+  - new internal \\`prev\\` lookup tables
+  - generalized lookup table builder for both directions
+- Added new public APIs in \\`packages/effect/src/Cron.ts\\`:
+  - \\`Cron.prev(cron, now?)\\`
+  - \\`Cron.sequenceReverse(cron, now?)\\`
+- Refactored \\`Cron.next\\` and \\`Cron.prev\\` to share core stepping logic via internal \\`stepCron\\`.
+- Included DST-aware reverse stepping behavior (including fall-back disambiguation handling).
+- Added test coverage in \\`packages/effect/test/Cron.test.ts\\` for:
+  - basic \\`prev\\` behavior
+  - \\`sequenceReverse\\`
+  - month/day edge cases (e.g. day 31 skipping shorter months)
+  - month-clamping behavior with month-only constraints
+  - DST fall-back reverse behavior
+- Added changeset:
+  - \\`.changeset/backport-cron-prev.md\\` (
+    \\`"effect": minor\\`
+    )
+
+### ✅ Validation run
+- \\`pnpm lint-fix\\`
+- \\`pnpm test packages/effect/test/Cron.test.ts\\`
+- \\`pnpm check:tsgo\\`
+- \\`pnpm docgen\\`
+
+All completed successfully.`);

package/src/fixtures/patch8-fixed.txt

@@ -0,0 +1,30 @@
+await taskComplete(`Implemented backport of Cron reverse scheduling support.
+
+### ✅ Changes made
+- Added internal reverse lookup support to \`Cron\`:
+  - new internal \`last\` boundary values
+  - new internal \`prev\` lookup tables
+  - generalized lookup table builder for both directions
+- Added new public APIs in \`packages/effect/src/Cron.ts\`:
+  - \`Cron.prev(cron, now?)\`
+  - \`Cron.sequenceReverse(cron, now?)\`
+- Refactored \`Cron.next\` and \`Cron.prev\` to share core stepping logic via internal \`stepCron\`.
+- Included DST-aware reverse stepping behavior (including fall-back disambiguation handling).
+- Added test coverage in \`packages/effect/test/Cron.test.ts\` for:
+  - basic \`prev\` behavior
+  - \`sequenceReverse\`
+  - month/day edge cases (e.g. day 31 skipping shorter months)
+  - month-clamping behavior with month-only constraints
+  - DST fall-back reverse behavior
+- Added changeset:
+  - \`.changeset/backport-cron-prev.md\` (
+    \`"effect": minor\`
+    )
+
+### ✅ Validation run
+- \`pnpm lint-fix\`
+- \`pnpm test packages/effect/test/Cron.test.ts\`
+- \`pnpm check:tsgo\`
+- \`pnpm docgen\`
+
+All completed successfully.`);

package/src/fixtures/patch9-broken.txt

@@ -0,0 +1,10 @@
+const tasks = await listTasks({});
+const task = tasks.find((t) => t.id === 'EFF-738');
+if (!task) throw new Error('Task EFF-738 not found');
+const addition = `\n\nDiscovery update:\n\n* Archived regression tests are in \\.repos/effect-old/packages/effect/test/Cron.test.ts (not Cron.ts) and include extensive \\`prev\\` + \\`sequenceReverse\\` coverage that maps cleanly to current APIs by renaming \\`unsafeParse\\` -> \\`parseUnsafe\\` and DateTime helpers to \\`zoneMakeNamedUnsafe\\` / \\`makeZonedUnsafe\\`.\n* Old \\`prev\\` implementation depends on internal cron metadata additions: \\`last\\` boundaries + reverse lookup tables \\`prev\\`; these need to be added to current \\`Cron.make\\` output before implementing reverse stepping.`;
+await updateTask({
+  taskId: 'EFF-738',
+  description: task.description + addition,
+  state: 'in-progress'
+});
+console.log('updated task');

package/src/fixtures/patch9-fixed.txt

@@ -0,0 +1,10 @@
+const tasks = await listTasks({});
+const task = tasks.find((t) => t.id === 'EFF-738');
+if (!task) throw new Error('Task EFF-738 not found');
+const addition = `\n\nDiscovery update:\n\n* Archived regression tests are in .repos/effect-old/packages/effect/test/Cron.test.ts (not Cron.ts) and include extensive \`prev\` + \`sequenceReverse\` coverage that maps cleanly to current APIs by renaming \`unsafeParse\` -> \`parseUnsafe\` and DateTime helpers to \`zoneMakeNamedUnsafe\` / \`makeZonedUnsafe\`.\n* Old \`prev\` implementation depends on internal cron metadata additions: \`last\` boundaries + reverse lookup tables \`prev\`; these need to be added to current \`Cron.make\` output before implementing reverse stepping.`;
+await updateTask({
+  taskId: 'EFF-738',
+  description: task.description + addition,
+  state: 'in-progress'
+});
+console.log('updated task');